Page MenuHomePhabricator

kpn (Kevin P. Neal)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 20 2018, 9:31 AM (134 w, 5 d)

Recent Activity

Fri, Sep 11

kpn added a comment to D69272: Enable '#pragma STDC FENV_ACCESS' in frontend.

Say, in D80952 I added support for disabling strictfp support when a target doesn't support it. But it only applies to command line arguments.

Fri, Sep 11, 10:31 AM · Restricted Project

Thu, Sep 10

kpn added a comment to D87223: [FPEnv] [Clang] Enable constrained FP support for PowerPC.
In D87223#2261086, @kpn wrote:

Over in D80952 there was a comment from @steven.zhang: "Agree that we can turn on it later when it is done." But your comment here is that it is "almost done".

Is it fair to say that the PowerPC work is at _parity_ with X86 and SystemZ? I think that's a better cutover point than "done".

Yes, we've disabled the FP mutation in rG6afb2791. vector-constrained-fp-intrinsics.ll is also aligned with X86 & SystemZ.

Thu, Sep 10, 7:09 AM · Restricted Project

Tue, Sep 8

kpn added a comment to D87223: [FPEnv] [Clang] Enable constrained FP support for PowerPC.

Over in D80952 there was a comment from @steven.zhang: "Agree that we can turn on it later when it is done." But your comment here is that it is "almost done".

Tue, Sep 8, 8:41 AM · Restricted Project

Thu, Aug 27

kpn committed rG0ec098e22ba9: [FPEnv] Allow fneg + strict_fadd -> strict_fsub in DAGCombiner (authored by Drew Wock <drew.wock@sas.com>).
[FPEnv] Allow fneg + strict_fadd -> strict_fsub in DAGCombiner
Thu, Aug 27, 5:17 AM
kpn closed D85548: Allow fneg + strict_fadd -> strict_fsub in DAGCombiner.
Thu, Aug 27, 5:17 AM · Restricted Project

Aug 17 2020

kpn planned changes to D85920: [FPEnv][AST] WIP!!! For casts, keep FP options in trailing storage of CastExpr.

It would be better to go with D85960. I'll hedge and keep this open until that one gets pushed.

Aug 17 2020, 12:44 PM · Restricted Project

Aug 14 2020

kpn added inline comments to D85548: Allow fneg + strict_fadd -> strict_fsub in DAGCombiner.
Aug 14 2020, 12:23 PM · Restricted Project
kpn added a comment to D85960: [AST][FPEnv] Keep FP options in trailing storage of CastExpr.

You mentioned in D85920 a need to merge this review with that review. I don't think that's needed. This code here is farther along. It does everything that D85920 does and has necessary pieces implemented as well.

Aug 14 2020, 12:16 PM · Restricted Project

Aug 13 2020

kpn requested review of D85920: [FPEnv][AST] WIP!!! For casts, keep FP options in trailing storage of CastExpr.
Aug 13 2020, 11:46 AM · Restricted Project

Aug 3 2020

kpn committed rGd535a91d13b8: [FPEnv] IRBuilder fails to add strictfp attribute (authored by kpn).
[FPEnv] IRBuilder fails to add strictfp attribute
Aug 3 2020, 10:26 AM
kpn closed D84878: [FPEnv] IRBuilder fails to add strictfp attribute.
Aug 3 2020, 10:25 AM · Restricted Project

Jul 29 2020

kpn requested review of D84878: [FPEnv] IRBuilder fails to add strictfp attribute.
Jul 29 2020, 11:13 AM · Restricted Project

Jul 21 2020

kpn committed rG2d27f24b5a47: [NFC] Make documentation for CallBase::hasFnAttr() more clear. (authored by kpn).
[NFC] Make documentation for CallBase::hasFnAttr() more clear.
Jul 21 2020, 10:00 AM

Jul 10 2020

kpn committed rG523a8513f8ba: [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking… (authored by kpn).
[FPEnv][Clang][Driver] Disable constrained floating point on targets lacking…
Jul 10 2020, 7:34 AM
kpn added inline comments to D80952: [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support..
Jul 10 2020, 6:11 AM · Restricted Project
kpn committed rGd4ce862f2aa8: Reland "[FPEnv][Clang][Driver] Disable constrained floating point on targets… (authored by kpn).
Reland "[FPEnv][Clang][Driver] Disable constrained floating point on targets…
Jul 10 2020, 5:51 AM
kpn closed D80952: [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support..
Jul 10 2020, 5:50 AM · Restricted Project

Jul 9 2020

kpn added a comment to D80952: [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support..

Thanks for the reviews and the fast turnaround! I do appreciate it!

Jul 9 2020, 3:06 PM · Restricted Project

Jul 7 2020

kpn updated the diff for D80952: [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support..

Add the -fexperimental-strict-floating-point flag to enable on hosts that are not marked as supporting strict FP yet. Add test and documentation.

Jul 7 2020, 12:01 PM · Restricted Project

Jul 6 2020

kpn reopened D80952: [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support..
Jul 6 2020, 12:20 PM · Restricted Project
kpn added a reverting change for rGbfdafa32a0fa: [FPEnv][Clang][Driver] Failing tests are now expected failures.: rG916e2ca99785: Revert "[FPEnv][Clang][Driver] Disable constrained floating point on targets….
Jul 6 2020, 12:00 PM
kpn added a reverting change for rG39d2ae0afb23: [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking…: rG916e2ca99785: Revert "[FPEnv][Clang][Driver] Disable constrained floating point on targets….
Jul 6 2020, 12:00 PM
kpn added a reverting change for rG2b3551135045: [FPEnv][Clang][Driver] Failing tests are now expected failures only on PowerPC: rG916e2ca99785: Revert "[FPEnv][Clang][Driver] Disable constrained floating point on targets….
Jul 6 2020, 12:00 PM
kpn committed rG916e2ca99785: Revert "[FPEnv][Clang][Driver] Disable constrained floating point on targets… (authored by kpn).
Revert "[FPEnv][Clang][Driver] Disable constrained floating point on targets…
Jul 6 2020, 12:00 PM
kpn added a comment to D80952: [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support..

Already on it. I hope I got it now.

Jul 6 2020, 11:45 AM · Restricted Project
kpn committed rG2b3551135045: [FPEnv][Clang][Driver] Failing tests are now expected failures only on PowerPC (authored by kpn).
[FPEnv][Clang][Driver] Failing tests are now expected failures only on PowerPC
Jul 6 2020, 11:44 AM
kpn committed rGbfdafa32a0fa: [FPEnv][Clang][Driver] Failing tests are now expected failures. (authored by kpn).
[FPEnv][Clang][Driver] Failing tests are now expected failures.
Jul 6 2020, 11:24 AM
kpn committed rG39d2ae0afb23: [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking… (authored by kpn).
[FPEnv][Clang][Driver] Disable constrained floating point on targets lacking…
Jul 6 2020, 10:34 AM
kpn closed D80952: [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support..
Jul 6 2020, 10:33 AM · Restricted Project

Jun 30 2020

kpn added a comment to D80952: [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support..

Ping. I'm really hoping to get this into 11. Otherwise we're going multiple releases with options that people already use causing crashes on most architectures.

Jun 30 2020, 6:28 AM · Restricted Project

Jun 26 2020

kpn committed rGe91c4b2af2c0: [NFC] Eliminate an unneeded -vv used in test development. (authored by kpn).
[NFC] Eliminate an unneeded -vv used in test development.
Jun 26 2020, 8:12 AM

Jun 25 2020

kpn committed rG15edd7aaa714: [FPEnv] PowerPC-specific builtin constrained FP enablement (authored by ajwock).
[FPEnv] PowerPC-specific builtin constrained FP enablement
Jun 25 2020, 9:08 AM
kpn closed D82020: PowerPC-specific builtin constrained FP enablement.
Jun 25 2020, 9:08 AM · Restricted Project

Jun 22 2020

kpn updated the diff for D80952: [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support..

Remove debugging command left in accidentally. Rebase.

Jun 22 2020, 1:26 PM · Restricted Project
kpn added a comment to D80952: [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support..

Ping?

Jun 22 2020, 12:21 PM · Restricted Project

Jun 15 2020

kpn committed rG07f335128410: [strictfp] Replace dangling strictfp attrs with nobuiltin (authored by kpn).
[strictfp] Replace dangling strictfp attrs with nobuiltin
Jun 15 2020, 7:34 AM
kpn closed D70096: [strictfp] Replace dangling strictfp attrs with nobuiltin.
Jun 15 2020, 7:33 AM · Restricted Project

Jun 12 2020

kpn added a comment to D70096: [strictfp] Replace dangling strictfp attrs with nobuiltin.

Ping.

Jun 12 2020, 10:52 AM · Restricted Project

Jun 11 2020

kpn updated the diff for D80952: [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support..

Added new warnings to a new group "unsupported-floating-point-opt". The warning can be disabled. The disabling of constrained floating point is unaffected by the status of the warning.

Jun 11 2020, 1:47 PM · Restricted Project

Jun 8 2020

kpn added inline comments to D81178: [FPEnv] Initialization of C++ globals not strictfp aware.
Jun 8 2020, 11:02 AM · Restricted Project

Jun 4 2020

kpn updated subscribers of D81178: [FPEnv] Initialization of C++ globals not strictfp aware.
Jun 4 2020, 11:00 AM · Restricted Project
kpn created D81178: [FPEnv] Initialization of C++ globals not strictfp aware.
Jun 4 2020, 11:00 AM · Restricted Project

Jun 3 2020

kpn committed rG15a1780a10e3: [PowerPC] Replace subtract-from-zero float in version with fneg in PowerPC… (authored by ajwock).
[PowerPC] Replace subtract-from-zero float in version with fneg in PowerPC…
Jun 3 2020, 7:08 AM

Jun 2 2020

kpn added a comment to D80952: [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support..

The problem for the command-line arguments in particular is that they aren't really new; clang has been eating them for a long time, without any warning. So if -frounding-math crashes the compiler, that's a regression.

Could we get an -fexperimental-something flag to override this behavior then?

Jun 2 2020, 6:36 AM · Restricted Project

Jun 1 2020

kpn added a comment to D80952: [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support..

This currently triggers a failure in test "Clang :: Misc/warning-flags.c". Suggestions on how to fix that correctly are welcome.

Jun 1 2020, 2:05 PM · Restricted Project
kpn created D80952: [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support..
Jun 1 2020, 2:05 PM · Restricted Project

May 29 2020

kpn committed rGcd74ccc965e7: [X86] Fix errors in use of strictfp attribute. (authored by kpn).
[X86] Fix errors in use of strictfp attribute.
May 29 2020, 9:47 AM
kpn committed rGc21a4f84b0e8: Fix errors in use of strictfp attribute. (authored by kpn).
Fix errors in use of strictfp attribute.
May 29 2020, 9:47 AM
kpn committed rG66d1899e2ffd: Fix errors in use of strictfp attribute. (authored by kpn).
Fix errors in use of strictfp attribute.
May 29 2020, 9:46 AM
kpn committed rGa38788201e44: Fix errors in use of strictfp attribute. (authored by kpn).
Fix errors in use of strictfp attribute.
May 29 2020, 9:46 AM

May 28 2020

kpn updated the diff for D70096: [strictfp] Replace dangling strictfp attrs with nobuiltin.

Update to not "upgrade" the strictfp attribute on a call to a constrained FP intrinsic. When my IR verifier changes land it will result in a misleading error message.

May 28 2020, 9:49 AM · Restricted Project
kpn added inline comments to D68233: [FPEnv] [WIP] Verify strictfp attribute correctness.
May 28 2020, 8:07 AM · Restricted Project
kpn updated the diff for D68233: [FPEnv] [WIP] Verify strictfp attribute correctness.

Address review comments.

May 28 2020, 8:07 AM · Restricted Project

May 15 2020

kpn updated the diff for D70096: [strictfp] Replace dangling strictfp attrs with nobuiltin.

Address review comments, and add a test to verify the additional code.

May 15 2020, 8:06 AM · Restricted Project
kpn commandeered D70096: [strictfp] Replace dangling strictfp attrs with nobuiltin.

Commandeering with Andy's permission.

May 15 2020, 8:06 AM · Restricted Project

May 5 2020

kpn added a comment to D72749: [PowerPC] Add exception constraint to FP sqrt, fma, min/max.

Most of this is in TableGen files, and I have so little experience there that I can't review. I'm sorry.

May 5 2020, 9:08 AM · Restricted Project

Apr 28 2020

kpn added a comment to D74729: [FPEnv] Intrinsic for setting rounding mode.
In D74729#2005958, @kpn wrote:

I think we need to be clear in the documentation that this is _not_ a substitute for the constrained FP intrinsics. Can you please add that to your new documentation? Include a link to the "Floating-Point Environment" section in the language ref.

It cannot be such substitute. IIUC constrained intrinsics were introduced to represent variants of corresponding C functions that operate in non-default FP environment to distinguish them from "ordinary" variants, that are pure functions. Functions like set_rounding always access FP environment, it always have side effect and must be properly ordered.

Apr 28 2020, 11:50 AM · Restricted Project

Apr 27 2020

kpn added a comment to D74729: [FPEnv] Intrinsic for setting rounding mode.

I think we need to be clear in the documentation that this is _not_ a substitute for the constrained FP intrinsics. Can you please add that to your new documentation? Include a link to the "Floating-Point Environment" section in the language ref.

Apr 27 2020, 12:22 PM · Restricted Project
kpn added a comment to D74729: [FPEnv] Intrinsic for setting rounding mode.
In D74729#2005777, @kpn wrote:

Are there GPUs or AI cores _targeted by llvm_ that support changing the rounding mode at run-time?

AMDGPU can

Apr 27 2020, 11:49 AM · Restricted Project
kpn added a comment to D74729: [FPEnv] Intrinsic for setting rounding mode.

Are there GPUs or AI cores _targeted by llvm_ that support changing the rounding mode at run-time?

Apr 27 2020, 11:17 AM · Restricted Project

Apr 10 2020

kpn committed rG7f38812d5b7e: [FPEnv][AArch64] Platform-specific builtin constrained FP enablement (authored by kpn).
[FPEnv][AArch64] Platform-specific builtin constrained FP enablement
Apr 10 2020, 10:04 AM
kpn closed D77074: [FPEnv][AArch64] Platform-specific builtin constrained FP enablement.
Apr 10 2020, 10:04 AM · Restricted Project

Apr 8 2020

kpn updated the diff for D77074: [FPEnv][AArch64] Platform-specific builtin constrained FP enablement.

Update from review comments. The new emitCallMaybeConstrainedFPBuiltin() function does make the code much cleaner.

Apr 8 2020, 1:03 PM · Restricted Project

Apr 3 2020

kpn committed rG9f1c35d8b14f: Revert "[PowerPC] Replace subtract-from-zero float in version with fneg in… (authored by kpn).
Revert "[PowerPC] Replace subtract-from-zero float in version with fneg in…
Apr 3 2020, 1:01 PM
kpn added a reverting change for rGba87430cadb2: [PowerPC] Replace subtract-from-zero float in version with fneg in PowerPC…: rG9f1c35d8b14f: Revert "[PowerPC] Replace subtract-from-zero float in version with fneg in….
Apr 3 2020, 1:01 PM
kpn added a comment to D76928: [InstCombine][X86] Simplify demanded elts in SSE intrinsics with repeated args (PR24523).

Didn't Andy Kaylor have a plan to pass strict FP metadata through using (I think he called it) bundles?

Apr 3 2020, 12:57 PM · Restricted Project
kpn committed rGd7a0516ddcfe: Fix typo in test. (authored by kpn).
Fix typo in test.
Apr 3 2020, 12:27 PM
kpn committed rGba87430cadb2: [PowerPC] Replace subtract-from-zero float in version with fneg in PowerPC… (authored by ajwock).
[PowerPC] Replace subtract-from-zero float in version with fneg in PowerPC…
Apr 3 2020, 12:27 PM
kpn closed D76949: Replace subtract-from-zero float in version with fneg in PowerPC special fma compiler builtins.
Apr 3 2020, 12:26 PM · Restricted Project, Restricted Project

Apr 2 2020

kpn added inline comments to D77074: [FPEnv][AArch64] Platform-specific builtin constrained FP enablement.
Apr 2 2020, 7:01 AM · Restricted Project

Apr 1 2020

kpn added a comment to D70096: [strictfp] Replace dangling strictfp attrs with nobuiltin.

I ran a check myself. I found that there are quite a few existing tests that enter BitcodeReader::materialize() from someplace other than BitcodeReader::materializeModule(). Perhaps one of these would be helpful in coming up with a new test?

Apr 1 2020, 2:45 PM · Restricted Project

Mar 30 2020

kpn added a comment to D77074: [FPEnv][AArch64] Platform-specific builtin constrained FP enablement.

Note that the AArch64 backend isn't ready for some of these changes. That's why the test is marked XFAIL.

Mar 30 2020, 10:19 AM · Restricted Project
kpn created D77074: [FPEnv][AArch64] Platform-specific builtin constrained FP enablement.
Mar 30 2020, 10:16 AM · Restricted Project

Mar 27 2020

kpn added a comment to D72930: [FEnv] Constfold some unary constrained operations.

It looks like a whole bunch of instructions got converted into simple loads. Which is exactly what was expected.

Mar 27 2020, 12:01 PM · Restricted Project
kpn added a comment to D72930: [FEnv] Constfold some unary constrained operations.
Mar 27 2020, 9:41 AM · Restricted Project

Feb 28 2020

kpn added inline comments to D72930: [FEnv] Constfold some unary constrained operations.
Feb 28 2020, 5:53 AM · Restricted Project

Feb 12 2020

kpn added inline comments to D72930: [FEnv] Constfold some unary constrained operations.
Feb 12 2020, 5:45 AM · Restricted Project

Feb 11 2020

kpn added inline comments to D72930: [FEnv] Constfold some unary constrained operations.
Feb 11 2020, 9:30 AM · Restricted Project
kpn added a comment to D72685: [PowerPC] Exploit VSX rounding instrs for rint.

Correct me if I'm wrong. rint(x) returns x if x is an NaN. However, intruction like XSRDPIC may turn SNAN to QNAN. Does it matter?

Feb 11 2020, 9:21 AM · Restricted Project

Feb 6 2020

kpn committed rGad0e03fd4c80: Revert "[FPEnv][X86] Platform-specific builtin constrained FP enablement" (authored by kpn).
Revert "[FPEnv][X86] Platform-specific builtin constrained FP enablement"
Feb 6 2020, 4:24 PM
kpn added a reverting change for rG208470dd5d0a: [FPEnv][X86] Platform-specific builtin constrained FP enablement: rGad0e03fd4c80: Revert "[FPEnv][X86] Platform-specific builtin constrained FP enablement".
Feb 6 2020, 4:23 PM
kpn added a reverting change for rG80e17e5fcc09: [FPEnv][X86] Speculative fix for failures introduced by eda495426.: rGad0e03fd4c80: Revert "[FPEnv][X86] Platform-specific builtin constrained FP enablement".
Feb 6 2020, 4:23 PM
kpn committed rG80e17e5fcc09: [FPEnv][X86] Speculative fix for failures introduced by eda495426. (authored by kpn).
[FPEnv][X86] Speculative fix for failures introduced by eda495426.
Feb 6 2020, 12:33 PM
kpn committed rG208470dd5d0a: [FPEnv][X86] Platform-specific builtin constrained FP enablement (authored by kpn).
[FPEnv][X86] Platform-specific builtin constrained FP enablement
Feb 6 2020, 11:26 AM
kpn closed D73570: [FPEnv][X86] Platform-specific builtin constrained FP enablement.
Feb 6 2020, 11:26 AM · Restricted Project

Jan 31 2020

kpn updated the diff for D73570: [FPEnv][X86] Platform-specific builtin constrained FP enablement.

Address review comments: FMA tests are now run optimized. This changes where the FIXME lines are located.

Jan 31 2020, 10:54 AM · Restricted Project

Jan 29 2020

kpn added inline comments to D73570: [FPEnv][X86] Platform-specific builtin constrained FP enablement.
Jan 29 2020, 5:49 AM · Restricted Project

Jan 28 2020

kpn created D73570: [FPEnv][X86] Platform-specific builtin constrained FP enablement.
Jan 28 2020, 11:46 AM · Restricted Project

Jan 24 2020

kpn added inline comments to D72820: [FPEnv] Add pragma FP_CONTRACT support under strict FP..
Jan 24 2020, 9:17 AM · Restricted Project, Restricted Project
kpn added inline comments to D72820: [FPEnv] Add pragma FP_CONTRACT support under strict FP..
Jan 24 2020, 5:02 AM · Restricted Project, Restricted Project

Jan 22 2020

kpn added a comment to D73201: [FPEnv][AArch64] Add lowering and instruction selection for STRICT_FP_ROUND.

We want to remove all the mutation code once the in tree targets all support STRICT_ nodes properly. It's a hack to enable targets to limp along a little bit, but in hindsight may have been a bad idea since it creates the illusion of things working when they really don't.

Jan 22 2020, 11:10 AM · Restricted Project

Jan 21 2020

kpn committed rG2e667d07c773: [FPEnv][SystemZ] Platform-specific builtin constrained FP enablement (authored by kpn).
[FPEnv][SystemZ] Platform-specific builtin constrained FP enablement
Jan 21 2020, 9:49 AM
kpn closed D72722: [FPEnv] [SystemZ] Platform-specific builtin constrained FP enablement.
Jan 21 2020, 9:48 AM · Restricted Project
kpn updated the diff for D72722: [FPEnv] [SystemZ] Platform-specific builtin constrained FP enablement.

Eliminate a blank line I thought I had already had gotten.

Jan 21 2020, 7:52 AM · Restricted Project
kpn updated the diff for D72722: [FPEnv] [SystemZ] Platform-specific builtin constrained FP enablement.

Update for review comments.

Jan 21 2020, 7:50 AM · Restricted Project
kpn added inline comments to D72722: [FPEnv] [SystemZ] Platform-specific builtin constrained FP enablement.
Jan 21 2020, 7:47 AM · Restricted Project

Jan 17 2020

kpn added inline comments to D72930: [FEnv] Constfold some unary constrained operations.
Jan 17 2020, 10:32 AM · Restricted Project
kpn committed rG0bcfafc5e71d: [SeparateConstOffsetFromGEP] Fix: sext(a) + sext(b) -> sext(a + b) matches add… (authored by ajwock).
[SeparateConstOffsetFromGEP] Fix: sext(a) + sext(b) -> sext(a + b) matches add…
Jan 17 2020, 9:25 AM
kpn closed D65967: [SeparateConstOffsetFromGEP][PowerPC] Fix: sext(a) + sext(b) -> sext(a + b) matches add and sub instructions with one another.
Jan 17 2020, 9:25 AM · Restricted Project

Jan 15 2020

kpn added a comment to D65967: [SeparateConstOffsetFromGEP][PowerPC] Fix: sext(a) + sext(b) -> sext(a + b) matches add and sub instructions with one another.

Excellent! Thanks Matt!

Jan 15 2020, 7:35 AM · Restricted Project