Page MenuHomePhabricator

kpn (Kevin P. Neal)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 20 2018, 9:31 AM (173 w, 6 d)

Recent Activity

Fri, Jun 18

kpn added inline comments to D103169: [FPEnv][InstSimplify] Constrained FP support for NaN.
Fri, Jun 18, 2:37 PM · Restricted Project

Thu, Jun 17

kpn accepted D104479: [PartiallyInlineLibCalls] Disable sqrt expansion for strictfp..

Ah, errno. That was the missing piece. Got it.

Thu, Jun 17, 1:28 PM · Restricted Project
kpn added a comment to D103490: [SystemZ][z/OS] Add support for TXT records in the GOFF reader.

Say, I can't find any file in the llvm repository named "GOFF*". They don't show up on Github, either, so I'm not sure what's going on. Where is the GOFF support in the LLVM tree currently? There's no "https://github.com/llvm/llvm-project/tree/main/llvm/lib/Object/GOFFObjectFile.cpp", for example.

Thu, Jun 17, 12:32 PM · Restricted Project
kpn added inline comments to D104479: [PartiallyInlineLibCalls] Disable sqrt expansion for strictfp..
Thu, Jun 17, 12:08 PM · Restricted Project
kpn added inline comments to D104479: [PartiallyInlineLibCalls] Disable sqrt expansion for strictfp..
Thu, Jun 17, 11:46 AM · Restricted Project
kpn updated the diff for D103169: [FPEnv][InstSimplify] Constrained FP support for NaN.

Rebase after a precommit of the tests.

Thu, Jun 17, 10:40 AM · Restricted Project
kpn committed rG60a8edf30d29: [FPEnv][InstSimplify] Precommit tests for D103169. (authored by kpn).
[FPEnv][InstSimplify] Precommit tests for D103169.
Thu, Jun 17, 7:35 AM

Wed, Jun 16

kpn added inline comments to D103169: [FPEnv][InstSimplify] Constrained FP support for NaN.
Wed, Jun 16, 9:01 AM · Restricted Project
kpn added a comment to D103169: [FPEnv][InstSimplify] Constrained FP support for NaN.

Phab just lost a comment of mine. Weird.

Wed, Jun 16, 8:33 AM · Restricted Project
kpn added inline comments to D103169: [FPEnv][InstSimplify] Constrained FP support for NaN.
Wed, Jun 16, 8:29 AM · Restricted Project

Thu, Jun 10

kpn updated the diff for D103169: [FPEnv][InstSimplify] Constrained FP support for NaN.

Update for review comments and reduce to just operating on NaN.

Thu, Jun 10, 12:18 PM · Restricted Project

Thu, Jun 3

kpn added a comment to D103169: [FPEnv][InstSimplify] Constrained FP support for NaN.

There's a lot going on here. I think we need to break this up to make sure we're testing the corner cases.

Thu, Jun 3, 12:50 PM · Restricted Project

Wed, May 26

kpn added a comment to D103169: [FPEnv][InstSimplify] Constrained FP support for NaN.

There's a lot going on here. I think we need to break this up to make sure we're testing the corner cases.

What if we start with plain constant folding? I don't see any existing tests for these intrinsics in llvm/test/Transforms/InstSimplify/ConstProp. See fp-undef.ll in that dir for test ideas.
For example, what can we do with this set of tests:

define float @fadd_undef_strict(float %x) #0 {
  %r = call float @llvm.experimental.constrained.fadd.f32(float undef, float undef, metadata !"round.dynamic", metadata !"fpexcept.strict") #0
  ret float %r
}

define float @fadd_undef_maytrap(float %x) #0 {
  %r = call float @llvm.experimental.constrained.fadd.f32(float undef, float undef, metadata !"round.dynamic", metadata !"fpexcept.maytrap") #0
  ret float %r
}

define float @fadd_undef_upward(float %x) #0 {
  %r = call float @llvm.experimental.constrained.fadd.f32(float undef, float undef, metadata !"round.upward", metadata !"fpexcept.ignore") #0
  ret float %r
}

define float @fadd_undef_defaultfp(float %x) #0 {
  %r = call float @llvm.experimental.constrained.fadd.f32(float undef, float undef, metadata !"round.tonearest", metadata !"fpexcept.ignore") #0
  ret float %r
}

What should happen if we replace each of those undef values with a constant number, NaN, etc?

Wed, May 26, 2:23 PM · Restricted Project
kpn added inline comments to D102673: [ConstantFolding] Fold constrained arithmetic intrinsics.
Wed, May 26, 8:07 AM · Restricted Project
kpn requested review of D103169: [FPEnv][InstSimplify] Constrained FP support for NaN.
Wed, May 26, 7:50 AM · Restricted Project

May 20 2021

kpn committed rGf21f1eea05d6: [FPEnv] EarlyCSE support for constrained intrinsics, default FP environment… (authored by kpn).
[FPEnv] EarlyCSE support for constrained intrinsics, default FP environment…
May 20 2021, 11:41 AM
kpn closed D99962: [FPEnv] EarlyCSE support for constrained intrinsics, default FP environment edition.
May 20 2021, 11:41 AM · Restricted Project

May 18 2021

kpn updated the diff for D99962: [FPEnv] EarlyCSE support for constrained intrinsics, default FP environment edition.

Update for review comments.

May 18 2021, 11:45 AM · Restricted Project
kpn added inline comments to D99962: [FPEnv] EarlyCSE support for constrained intrinsics, default FP environment edition.
May 18 2021, 11:44 AM · Restricted Project
kpn added a comment to D99675: [llvm][clang] Create new intrinsic llvm.arithmetic.fence to control FP optimization at expression level.
In D99675#2695424, @kpn wrote:

What changes are needed for a backend, and what happens if they aren't done?

As far as I understand it, backend does optimizations based on patterns of the known nodes and MIs. Inserting a new node/MI will block any optimizations across the fence. So it respects the semantics of the intrinsic without target special chenges.
I'm not sure if there's room for optimization cross the arithmetic.fence. If there is and no changes for it, backend may have some performance loss under these circumstances.

Having something needed for correctness silently not work seems ... sub-optimal.

I think backend is conservative for optimizations when use the intrinsic. It won't have correctness issue silently, but performance loss might.

May 18 2021, 7:51 AM · Restricted Project

May 13 2021

kpn added a reviewer for D99962: [FPEnv] EarlyCSE support for constrained intrinsics, default FP environment edition: JosephTremoulet.
May 13 2021, 11:47 AM · Restricted Project
kpn requested review of D102421: [FPEnv][WIP] Verify non-mixing of strictfp instructions and regular FP instructions.
May 13 2021, 10:09 AM · Restricted Project
kpn updated the diff for D68233: [FPEnv] [WIP] Verify strictfp attribute correctness.

We're still not ready to push this, but it can be used to find issues in clang. Once all tests pass with this change we can push it. We're not there yet.

May 13 2021, 9:49 AM · Restricted Project

May 4 2021

kpn added a comment to D99962: [FPEnv] EarlyCSE support for constrained intrinsics, default FP environment edition.

Ping.

May 4 2021, 10:41 AM · Restricted Project

May 3 2021

kpn added inline comments to D101010: [SystemZ] [z/OS] Add XPLINK64 Calling Convention to SystemZ.
May 3 2021, 10:51 AM · Restricted Project
kpn added a comment to D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.

OK, I have nothing more. I'll leave formal signoff to @jhenderson.

May 3 2021, 10:48 AM · Restricted Project

Apr 23 2021

kpn added inline comments to D101010: [SystemZ] [z/OS] Add XPLINK64 Calling Convention to SystemZ.
Apr 23 2021, 7:40 AM · Restricted Project
kpn added inline comments to D101010: [SystemZ] [z/OS] Add XPLINK64 Calling Convention to SystemZ.
Apr 23 2021, 5:54 AM · Restricted Project

Apr 22 2021

kpn added inline comments to D101010: [SystemZ] [z/OS] Add XPLINK64 Calling Convention to SystemZ.
Apr 22 2021, 12:32 PM · Restricted Project

Apr 20 2021

kpn added a reviewer for D99962: [FPEnv] EarlyCSE support for constrained intrinsics, default FP environment edition: asbirlea.
Apr 20 2021, 12:04 PM · Restricted Project
kpn added a comment to D100834: Bug 49739 - [Matrix] Support #pragma clang fp.

I don't know the matrix implementation so I can't swear this hits every place needed, but the uses of CGFPOptionsRAII in this patch look correct at least.

Apr 20 2021, 11:53 AM · Restricted Project
kpn added inline comments to D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens.
Apr 20 2021, 11:14 AM · Restricted Project, Restricted Project
kpn added a comment to D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.

There's still not much testing here, and there is plenty to test. The continuation records, for example. Tests can verify that all the invalid cases are rejected. Tests can also verify that GOFF is rejected if it is missing an HDR card or missing an END card. And since GOFF objects can be concatenated you can test that an object deck that is HDR+ESD+END+HDR+ESD+END is handled properly.

Apr 20 2021, 10:46 AM · Restricted Project

Apr 16 2021

kpn added a comment to D99675: [llvm][clang] Create new intrinsic llvm.arithmetic.fence to control FP optimization at expression level.
In D99675#2695424, @kpn wrote:

What changes are needed for a backend, and what happens if they aren't done?

In the clang patch, I'm planning to add into TargetInfo a function like "does the target support __arithmetic_fence"?
In the llvm patch, the fallback implementation could be to merely ignore the call, and pass through the operand value. Is that adequate?

Apr 16 2021, 12:26 PM · Restricted Project
kpn added a comment to D99675: [llvm][clang] Create new intrinsic llvm.arithmetic.fence to control FP optimization at expression level.

What changes are needed for a backend, and what happens if they aren't done?

Apr 16 2021, 11:30 AM · Restricted Project
kpn added a comment to D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens.

I thought that adding a new fence required changing every optimization pass in LLVM. That's why the constrained intrinsics were implemented they way they are where no fence is needed.

Aren't you going to have miscompiles using this new fence until all that optimization work is done? Or am I wrong? @andrew.w.kaylor?

Apr 16 2021, 11:21 AM · Restricted Project, Restricted Project
kpn added a comment to D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens.

I thought that adding a new fence required changing every optimization pass in LLVM. That's why the constrained intrinsics were implemented they way they are where no fence is needed.

Apr 16 2021, 11:10 AM · Restricted Project, Restricted Project

Apr 6 2021

kpn updated the diff for D99962: [FPEnv] EarlyCSE support for constrained intrinsics, default FP environment edition.

Address review comments: use early return.

Apr 6 2021, 1:25 PM · Restricted Project
kpn added a comment to D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.

The convention here is to wait a week or so before a ping, and the same between pings.

Apr 6 2021, 11:17 AM · Restricted Project
kpn requested review of D99962: [FPEnv] EarlyCSE support for constrained intrinsics, default FP environment edition.
Apr 6 2021, 8:21 AM · Restricted Project

Mar 19 2021

kpn added a comment to D98923: [Driver] Pass -fexperimental-strict-floating-point to cc1 if it is specified.

Test case?

Mar 19 2021, 10:45 AM · Restricted Project

Mar 11 2021

kpn added a comment to D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.

You'll need to add much comprehensive testing like @jhenderson requested in the previous ticket.

Mar 11 2021, 12:18 PM · Restricted Project

Mar 9 2021

kpn added a comment to D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

The majority of your code is still untested as far as I can see. There appear to be three test cases you have so far:

  1. An invalid size for a GOFF object.
  2. A valid size for a GOFF object.
  3. That getSymbolName returns the name of a single symbol in the symbol table.

What about all the rest of the functionality that is included in this patch, including, but certainly not limited to, the following?

  1. More than one symbol in the symbol table.
  2. Other properties of symbols.
  3. The various properties of records.
  4. Relocations.
  5. And so on...

For each bit of code you have written, consider whether a test would fail if that bit of code was broken in some way, or didn't exist. If no test fails, then that code needs a new test case of some form. There may also be other cases where testing is appropriate, e.g. where two separate aspects of the same system interact in some way, although those are harder to judge.

Mar 9 2021, 7:56 AM · Restricted Project
kpn added inline comments to D83036: [X86][FPEnv] Lowering of {get,set,reset}_fpmode.
Mar 9 2021, 7:38 AM · Restricted Project

Mar 5 2021

kpn added inline comments to D83036: [X86][FPEnv] Lowering of {get,set,reset}_fpmode.
Mar 5 2021, 12:33 PM · Restricted Project
kpn added inline comments to D83036: [X86][FPEnv] Lowering of {get,set,reset}_fpmode.
Mar 5 2021, 6:38 AM · Restricted Project

Feb 22 2021

kpn added a comment to D97125: Stop traping on sNaN in __builtin_isinf.

System/Z's TEST DATA CLASS instruction covers most (all?) of the possible FP value states. You might want to subscribe, or add as a reviewer, jonpa just to make sure everyone stays in sync.

Feb 22 2021, 7:30 AM · Restricted Project

Feb 5 2021

kpn accepted D95948: Stop traping on sNaN in __builtin_isnan.

LGTM

Feb 5 2021, 9:13 AM · Restricted Project, Restricted Project

Feb 4 2021

kpn added a comment to D95948: Stop traping on sNaN in __builtin_isnan.

Should we add tests for mlong-double-64, -80, -128?

Feb 4 2021, 11:24 AM · Restricted Project, Restricted Project
kpn added a comment to D95948: Stop traping on sNaN in __builtin_isnan.

This looks like a definite step forward. Thank you!

Feb 4 2021, 11:00 AM · Restricted Project, Restricted Project

Feb 3 2021

kpn committed rG81b69879c946: [FPEnv][X86] Platform builtins edition: clang should get from the AST the… (authored by kpn).
[FPEnv][X86] Platform builtins edition: clang should get from the AST the…
Feb 3 2021, 8:49 AM
kpn closed D94614: [FPEnv][X86] Platform builtins edition: clang should get from the AST the metadata for constrained FP builtins.
Feb 3 2021, 8:49 AM · Restricted Project

Jan 22 2021

kpn updated the diff for D94614: [FPEnv][X86] Platform builtins edition: clang should get from the AST the metadata for constrained FP builtins.

Update for review comments: Move uses of CGFPOptionsRAII lower and closer to where they are needed. This should be less error prone as well.

Jan 22 2021, 10:12 AM · Restricted Project

Jan 19 2021

kpn added inline comments to D94614: [FPEnv][X86] Platform builtins edition: clang should get from the AST the metadata for constrained FP builtins.
Jan 19 2021, 6:37 AM · Restricted Project

Jan 14 2021

kpn added a comment to D94614: [FPEnv][X86] Platform builtins edition: clang should get from the AST the metadata for constrained FP builtins.

This doesn't add metadata to llvm intrinsics that are not constrained.

Jan 14 2021, 8:12 AM · Restricted Project

Jan 13 2021

kpn added a reviewer for D94614: [FPEnv][X86] Platform builtins edition: clang should get from the AST the metadata for constrained FP builtins: pengfei.
Jan 13 2021, 10:05 AM · Restricted Project
kpn requested review of D94614: [FPEnv][X86] Platform builtins edition: clang should get from the AST the metadata for constrained FP builtins.
Jan 13 2021, 10:04 AM · Restricted Project

Jan 6 2021

kpn requested review of D94186: [FPEnv][PowerPC] Platform builtins edition: clang should get from the AST the metadata for constrained FP builtins.
Jan 6 2021, 11:53 AM · Restricted Project

Dec 21 2020

kpn added a comment to D93455: Constrained fp OpBundles.
In D93455#2463506, @kpn wrote:
In D93455#2460765, @kpn wrote:

Do you need tests for the verifier part?

Probably. With this patch standalone, we can only do "catch-22 testing": all uses of the bundle are illegal. We can extend that once the VP floating-point intrinsics are upstream that actually support these bundles.

Would replacing some of the constrained intrinsics with operand bundles on other intrinsics have the same safety guarantee in the middle end? Currently the middle end doesn't know about the constrained intrinsics so it handles code conservatively.

Not easily. This has the same re-occurring issue as enabling predication on all instructions: if we allow the constrained bundle on regular fp intrinsics overnight, existing optimization code will ignore the bundles and potentially break code.

That's a non-starter. People are relying on the strictfp options and #pragmas to work correctly already. That's why I had to add to clang the ability to turn it off the command-line option on targets that don't support it yet. So regressing and making strictfp unsafe again is just not an option.

An elegant way out for this would be to introduce an FPMathIntrinsic helper class that only matches intrinsics in the default fp environment (that is without the bundle). All code that looks for a specific fp math function can then no longer just take the intrinsic id but needs to cast the intrinsic to that helper class first.
Btw, the FPMathIntrinsic helper also fits well into the generalized pattern matching framework (D92086).

If there's a way to replace the constrained intrinsics with other, existing intrinsics plus operand bundles _while_ keeping the safety guarantee that we currently have then that sounds good. But the safety _must_ be the default until we get to updating optimizations to understand strictfp.

That's why i am proposing to initially use these bundles only for the VP intrinsics and keep the constrained fp intrinsics in place. When we are sure that all optimizations use the proper abstractions, we can move to replace constrained fp intrinsics with the bundled version instead.

Dec 21 2020, 10:28 AM · Restricted Project

Dec 18 2020

kpn added a comment to D93455: Constrained fp OpBundles.
In D93455#2460765, @kpn wrote:

Do you need tests for the verifier part?

Probably. With this patch standalone, we can only do "catch-22 testing": all uses of the bundle are illegal. We can extend that once the VP floating-point intrinsics are upstream that actually support these bundles.

Would replacing some of the constrained intrinsics with operand bundles on other intrinsics have the same safety guarantee in the middle end? Currently the middle end doesn't know about the constrained intrinsics so it handles code conservatively.

Not easily. This has the same re-occurring issue as enabling predication on all instructions: if we allow the constrained bundle on regular fp intrinsics overnight, existing optimization code will ignore the bundles and potentially break code.

Dec 18 2020, 9:56 AM · Restricted Project
kpn committed rG7fef551cb123: Revert "Revert "[FPEnv] Teach the IRBuilder about invoke's correct use of the… (authored by kpn).
Revert "Revert "[FPEnv] Teach the IRBuilder about invoke's correct use of the…
Dec 18 2020, 9:42 AM

Dec 17 2020

kpn added a comment to D93455: Constrained fp OpBundles.

Do you need tests for the verifier part?

Dec 17 2020, 9:16 AM · Restricted Project

Dec 15 2020

kpn added a reverting change for rG67a1ffd88ac0: [FPEnv] Teach the IRBuilder about invoke's correct use of the strictfp…: rG2ec5973fddb0: Revert "[FPEnv] Teach the IRBuilder about invoke's correct use of the strictfp….
Dec 15 2020, 9:59 AM
kpn committed rG2ec5973fddb0: Revert "[FPEnv] Teach the IRBuilder about invoke's correct use of the strictfp… (authored by kpn).
Revert "[FPEnv] Teach the IRBuilder about invoke's correct use of the strictfp…
Dec 15 2020, 9:59 AM
kpn added a reverting change for D93134: [FPEnv] Teach the IRBuilder about invoke's correct use of the strictfp attribute.: rG2ec5973fddb0: Revert "[FPEnv] Teach the IRBuilder about invoke's correct use of the strictfp….
Dec 15 2020, 9:59 AM · Restricted Project, Restricted Project
kpn committed rG67a1ffd88ac0: [FPEnv] Teach the IRBuilder about invoke's correct use of the strictfp… (authored by kpn).
[FPEnv] Teach the IRBuilder about invoke's correct use of the strictfp…
Dec 15 2020, 9:38 AM
kpn closed D93134: [FPEnv] Teach the IRBuilder about invoke's correct use of the strictfp attribute..
Dec 15 2020, 9:38 AM · Restricted Project, Restricted Project

Dec 11 2020

kpn requested review of D93134: [FPEnv] Teach the IRBuilder about invoke's correct use of the strictfp attribute..
Dec 11 2020, 11:15 AM · Restricted Project, Restricted Project

Dec 8 2020

kpn committed rGacd4950d4f1e: [FPEnv] Correct constrained metadata in fp16-ops-strict.c (authored by kpn).
[FPEnv] Correct constrained metadata in fp16-ops-strict.c
Dec 8 2020, 7:19 AM
kpn closed D92596: [FPEnv] Correct constrained metadata in fp16-ops-strict.c.
Dec 8 2020, 7:18 AM · Restricted Project

Dec 7 2020

kpn added inline comments to D92596: [FPEnv] Correct constrained metadata in fp16-ops-strict.c.
Dec 7 2020, 8:12 AM · Restricted Project
kpn added inline comments to D92596: [FPEnv] Correct constrained metadata in fp16-ops-strict.c.
Dec 7 2020, 7:31 AM · Restricted Project

Dec 3 2020

kpn requested review of D92596: [FPEnv] Correct constrained metadata in fp16-ops-strict.c.
Dec 3 2020, 12:08 PM · Restricted Project

Nov 30 2020

kpn added a comment to D92122: [FPEnv] clang should get from the AST the metadata for constrained FP builtins.

Thanks for the quick turnaround!

Nov 30 2020, 9:01 AM · Restricted Project
kpn committed rGabfbc5579bd4: [FPEnv] clang should get from the AST the metadata for constrained FP builtins (authored by kpn).
[FPEnv] clang should get from the AST the metadata for constrained FP builtins
Nov 30 2020, 9:00 AM
kpn closed D92122: [FPEnv] clang should get from the AST the metadata for constrained FP builtins.
Nov 30 2020, 8:59 AM · Restricted Project

Nov 25 2020

kpn requested review of D92122: [FPEnv] clang should get from the AST the metadata for constrained FP builtins.
Nov 25 2020, 12:05 PM · Restricted Project

Nov 23 2020

kpn updated subscribers of D90554: [CostModel] remove cost-kind predicate for intrinsics in basic TTI implementation.
Nov 23 2020, 11:39 AM · Restricted Project

Nov 13 2020

kpn added a reviewer for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format: kpn.
Nov 13 2020, 2:36 PM · Restricted Project
kpn added inline comments to D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.
Nov 13 2020, 2:35 PM · Restricted Project

Nov 12 2020

kpn committed rGac523d2de51c: [FPEnv][Clang][Driver] Use MarshallingInfoFlag for -fexperimental-strict… (authored by kpn).
[FPEnv][Clang][Driver] Use MarshallingInfoFlag for -fexperimental-strict…
Nov 12 2020, 9:52 AM
kpn closed D88987: [FPEnv][Clang][Driver] Use MarshallingInfoFlag for -fexperimental-strict-floating-point.
Nov 12 2020, 9:51 AM · Restricted Project

Nov 11 2020

kpn updated the diff for D88987: [FPEnv][Clang][Driver] Use MarshallingInfoFlag for -fexperimental-strict-floating-point.

Update for review comments.

Nov 11 2020, 9:44 AM · Restricted Project
kpn added a comment to D88987: [FPEnv][Clang][Driver] Use MarshallingInfoFlag for -fexperimental-strict-floating-point.

No worries!

Nov 11 2020, 9:41 AM · Restricted Project
kpn added inline comments to D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.
Nov 11 2020, 9:38 AM · Restricted Project
kpn added a comment to D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

OK, I'll bite. I do know GOFF, having implemented it in a shipping, commercial compiler before. Give me some time to take a closer look.

Nov 11 2020, 8:23 AM · Restricted Project

Nov 6 2020

kpn committed rG2069403cdf35: [FPEnv] Use strictfp metadata in casting nodes (authored by kpn).
[FPEnv] Use strictfp metadata in casting nodes
Nov 6 2020, 8:56 AM
kpn closed D88913: [FPEnv] Use strictfp metadata in casting nodes.
Nov 6 2020, 8:56 AM · Restricted Project, Restricted Project
kpn accepted D90921: [Clang][AArch64] Remove unused prefix in constrained rounding test.

LGTM

Nov 6 2020, 6:05 AM · Restricted Project

Nov 4 2020

kpn updated the diff for D88913: [FPEnv] Use strictfp metadata in casting nodes.

Update for review comments.

Nov 4 2020, 8:51 AM · Restricted Project, Restricted Project
kpn added a comment to D88913: [FPEnv] Use strictfp metadata in casting nodes.

Update for review comments.

Nov 4 2020, 8:49 AM · Restricted Project, Restricted Project

Nov 2 2020

kpn added inline comments to D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.
Nov 2 2020, 6:35 AM · Restricted Project

Oct 30 2020

kpn added a comment to D88913: [FPEnv] Use strictfp metadata in casting nodes.

I'll see how much I can simplify of the tests.

Oct 30 2020, 7:54 AM · Restricted Project, Restricted Project

Oct 29 2020

kpn updated the diff for D88913: [FPEnv] Use strictfp metadata in casting nodes.

Fix test, and eliminate a debugging "tee" command accidentally left in.

Oct 29 2020, 11:19 AM · Restricted Project, Restricted Project

Oct 28 2020

kpn updated the diff for D88913: [FPEnv] Use strictfp metadata in casting nodes.

Add some tests for changing the rounding metadata.

Oct 28 2020, 12:54 PM · Restricted Project, Restricted Project
kpn added a comment to D90316: [FPEnv] Diagnose pragmas FENV_ROUND,_ACCESS and float_control if target does not support StrictFP.

I also added "-fexperimental-strict-floating-point" which makes it possible to write tests for a target when bringing up the support on that target. I think it would be confusing for that flag to work on command line arguments but not pragmas.

Oct 28 2020, 9:37 AM · Restricted Project

Oct 27 2020

kpn added a comment to D88913: [FPEnv] Use strictfp metadata in casting nodes.

Generally the patch looks good. But the need to expect incorrect values in tests is a concern. Maybe this is a consequence of storing exception behavior in a separate field of CGFPOptionsRAII. This misbehavior should be fixed.

Oct 27 2020, 5:25 AM · Restricted Project, Restricted Project

Oct 26 2020

kpn added a comment to D88987: [FPEnv][Clang][Driver] Use MarshallingInfoFlag for -fexperimental-strict-floating-point.

Ping

Oct 26 2020, 11:31 AM · Restricted Project
kpn added a comment to D74729: [FPEnv] Intrinsic for setting rounding mode.

ok, I've no more questions @arsenm @kpn?

Oct 26 2020, 11:30 AM · Restricted Project

Oct 23 2020

kpn added inline comments to D88913: [FPEnv] Use strictfp metadata in casting nodes.
Oct 23 2020, 11:01 AM · Restricted Project, Restricted Project