This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Lower vro{l,r} for fixed vectors
ClosedPublic

Authored by luke on Aug 7 2023, 9:46 AM.

Details

Summary

We need to add new VL nodes to mirror ISD::ROTL and ISD::ROTR.

Diff Detail

Event Timeline

luke created this revision.Aug 7 2023, 9:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 7 2023, 9:46 AM
luke requested review of this revision.Aug 7 2023, 9:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 7 2023, 9:46 AM
craig.topper added inline comments.Aug 7 2023, 9:55 AM
llvm/lib/Target/RISCV/RISCVISelLowering.cpp
5083

Don't we need to check for vector type here?

luke added inline comments.Aug 7 2023, 10:03 AM
llvm/lib/Target/RISCV/RISCVISelLowering.cpp
5083

Yep, forgot to check that

luke updated this revision to Diff 547842.Aug 7 2023, 10:20 AM

Check for fixed length vector

This revision is now accepted and ready to land.Aug 7 2023, 8:14 PM
This revision was landed with ongoing or failed builds.Aug 8 2023, 1:47 AM
This revision was automatically updated to reflect the committed changes.