This is an archive of the discontinued LLVM Phabricator instance.

cmake: add missing dependencies on ClangDriverOptions tablegen
ClosedPublic

Authored by jroelofs on Aug 4 2023, 10:05 AM.

Details

Summary

The modules build trips over this frequently because there is no textual include of the tablegen output, but the module includes it.

Diff Detail

Event Timeline

jroelofs created this revision.Aug 4 2023, 10:05 AM
Herald added a reviewer: njames93. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
jroelofs requested review of this revision.Aug 4 2023, 10:05 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptAug 4 2023, 10:05 AM
steven_wu accepted this revision.Aug 4 2023, 10:09 AM
steven_wu added subscribers: aprantl, dblaikie.

LGTM. @aprantl @dblaikie who cares about module builds.

This revision is now accepted and ready to land.Aug 4 2023, 10:09 AM
This revision was landed with ongoing or failed builds.Aug 4 2023, 10:28 AM
This revision was automatically updated to reflect the committed changes.

I suspect one of your recent changes broke https://lab.llvm.org/buildbot/#/builders/168/builds/14944
Can you please take a look?

I suspect one of your recent changes broke https://lab.llvm.org/buildbot/#/builders/168/builds/14944
Can you please take a look?

Happy to take a look, but there are 28 commits in the blame list for that build... what makes you suspect it's the one change that only *adds* build dependencies? ISTM the clangd binary should be bit-identical before/after this change, right?

I can't reproduce the failure locally. Do we have a way to re-trigger that job for specific commits & bisect the blame list?

I suspect one of your recent changes broke https://lab.llvm.org/buildbot/#/builders/168/builds/14944
Can you please take a look?

Happy to take a look, but there are 28 commits in the blame list for that build... what makes you suspect it's the one change that only *adds* build dependencies? ISTM the clangd binary should be bit-identical before/after this change, right?

Just 3 mention clangd

I can't reproduce the failure locally.

Have you tried instruction in the error report:

How to reproduce locally: https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild

Do we have a way to re-trigger that job for specific commits & bisect the blame list?

Another easy ways are:

  1. trigger from buildbot, but I don't know you need special permision for that
  2. revert, see if it helps, and reland if it's not.
How to reproduce locally: https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild

Does not reproduce on my workstation too.

Flaky test? Here's a later build where it succeeds, but the change has nothing to do with clangd: https://lab.llvm.org/buildbot/#/builders/168/builds/14997

Flaky test? Here's a later build where it succeeds, but the change has nothing to do with clangd: https://lab.llvm.org/buildbot/#/builders/168/builds/14997

No, I manually requested a revision in the blame range.
I am bisecting on VM forked from the bot. Can reproduce there.
I will update the bug in a few hours.

Flaky test? Here's a later build where it succeeds, but the change has nothing to do with clangd: https://lab.llvm.org/buildbot/#/builders/168/builds/14997

No, I manually requested a revision in the blame range.
I am bisecting on VM forked from the bot. Can reproduce there.
I will update the bug in a few hours.

Sorry, this patch is not to blame.
D153536 is the cause.