- User Since
- Nov 27 2013, 1:02 PM (373 w, 1 d)
Wed, Jan 20
Dec 14 2020
Dec 4 2020
Nov 17 2020
Nov 16 2020
Since this adds a dependency on the AAResultsWrapperPass, shouldn't we be informing the pass manager about it?
Nov 13 2020
More context: https://www.openwall.com/lists/musl/2013/03/29/13
Oct 5 2020
Sep 28 2020
Sep 18 2020
There's quite a few dead variables added in this patch. Do they belong in later patches in the series?
small nits, otherwise LGTM
update LGTM too
Sep 17 2020
btw, do you need me to commit it for you?
Yeah, this should do what you're after. LGTM
Sep 16 2020
LGTM, with some optional suggestions.
Sep 15 2020
I know almost nothing about how DebugInfo is represented in llvm/dwarf, but is there not a way to represent what this transformation is doing in DI? It's always a little sad when you have to drop it, since doing so makes the debug experience worse.
Sep 14 2020
Sep 10 2020
Sep 9 2020
The Baremetal toolchain currently has a fixed behavior regardless of the -rtlib option's value. It is always linking against compiler-rt unless -nodefaultlibs is enabled.
This proposal slightly changes the code in such a way that enabling -rtlib=libgcc implies linking against -libgcc.
Something that I'm unsure about this patch is that we are not enforcing the existence of such libgcc. By reading other toolchains, I understood that is not always enforced. Do you think this policy is acceptable? If it is not, how would you think it should be addressed?
Sep 2 2020
Aug 28 2020
I was *just* thinking about the inverse of this transformation as a way to increase available ILP on CPUs where there are more pipes that can do arithmetic than compares.... cool!
I'm having trouble getting -stop-before MIR output to trigger these remarks when fed back into llc, so instead I've just relaxed the checks against specific cycle counts to be more forgiving.
Aug 20 2020
Aug 3 2020
Jul 31 2020
Isn't it missing DEPENDS cxxabi the same way this was missing DEPENDS unwind?
Mind doing the same thing for libcxxabi? I think it has the same problem.
LGTM, thank you!