Page MenuHomePhabricator
People jroelofs

jroelofs (Jon Roelofs)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 27 2013, 1:02 PM (448 w, 11 h)

Recent Activity
View All

Mon, Jun 27

jroelofs accepted D128654: [MC] Allow annotating custom sections as zerofill.

LGTM

Mon, Jun 27, 8:51 AM · Restricted Project, Restricted Project

May 19 2022

jroelofs committed rZORG793716f3d6bf: Force HAVE_LIB_RT to NO when building with Xcode toolchains (authored by jroelofs).
Force HAVE_LIB_RT to NO when building with Xcode toolchains
May 19 2022, 8:08 AM · Restricted Project

May 18 2022

jroelofs committed rGd699e54ca291: Fix an or+and miscompile w/ GlobalISel (authored by jroelofs).
Fix an or+and miscompile w/ GlobalISel
May 18 2022, 7:10 PM · Restricted Project, Restricted Project
jroelofs committed rT33c34454f18c: Force HAVE_LIB_RT to NO when building with Xcode toolchains (authored by jroelofs).
Force HAVE_LIB_RT to NO when building with Xcode toolchains
May 18 2022, 6:47 PM · Restricted Project
jroelofs closed D125275: Force HAVE_LIB_RT to NO when building with Xcode toolchains.
May 18 2022, 6:32 PM · Restricted Project
jroelofs added a comment to D125275: Force HAVE_LIB_RT to NO when building with Xcode toolchains.

33c34454f18c5086eae797850992692e60bed11b

May 18 2022, 6:32 PM · Restricted Project

May 12 2022

jroelofs requested review of D125472: Fix an or+and miscompile w/ GlobalISel.
May 12 2022, 9:15 AM · Restricted Project, Restricted Project

May 9 2022

jroelofs updated the summary of D125275: Force HAVE_LIB_RT to NO when building with Xcode toolchains.
May 9 2022, 3:18 PM · Restricted Project
jroelofs added a comment to D121343: Update benchmarks.

https://reviews.llvm.org/D125275

May 9 2022, 3:16 PM · Restricted Project
jroelofs requested review of D125275: Force HAVE_LIB_RT to NO when building with Xcode toolchains.
May 9 2022, 3:15 PM · Restricted Project
jroelofs updated subscribers of D121343: Update benchmarks.

@fhahn suggested this might be an issue with how caches/util/xcode_sdk.cmake configures try_compile, and sure enough:

May 9 2022, 3:05 PM · Restricted Project

May 3 2022

jroelofs closed D124882: Fix zero-width bitfield extracts to emit 0.

e1c808b36e2ec7050016c2eaafab3e17696583a0

May 3 2022, 2:47 PM · Restricted Project, Restricted Project
jroelofs committed rGe1c808b36e2e: Fix zero-width bitfield extracts to emit 0 (authored by jroelofs).
Fix zero-width bitfield extracts to emit 0
May 3 2022, 2:47 PM · Restricted Project, Restricted Project
jroelofs requested review of D124882: Fix zero-width bitfield extracts to emit 0.
May 3 2022, 2:36 PM · Restricted Project, Restricted Project

Apr 22 2022

jroelofs added a comment to D121343: Update benchmarks.

As a workaround, what if we wrapped the check in an if(NOT APPLE)?

Apr 22 2022, 11:48 AM · Restricted Project

Apr 6 2022

jroelofs added inline comments to D123227: Make the version check PEP440-compliant.
Apr 6 2022, 2:15 PM · Restricted Project
jroelofs added a comment to D123227: Make the version check PEP440-compliant.

sounds good to me, thank you!

Apr 6 2022, 1:29 PM · Restricted Project
jroelofs added a comment to D123227: Make the version check PEP440-compliant.

Seems I don't have permissions on the repo to commit this.

Apr 6 2022, 12:58 PM · Restricted Project
jroelofs added a comment to D123227: Make the version check PEP440-compliant.

This showed up in one of our buildbots:

Apr 6 2022, 11:33 AM · Restricted Project
jroelofs requested review of D123227: Make the version check PEP440-compliant.
Apr 6 2022, 8:36 AM · Restricted Project

Apr 2 2022

jroelofs added inline comments to D121343: Update benchmarks.
Apr 2 2022, 8:23 AM · Restricted Project

Mar 30 2022

jroelofs accepted D122744: [Docs] Add documentation for llvm-remark-size-diff.

LGTM

Mar 30 2022, 12:47 PM · Restricted Project, Restricted Project

Feb 8 2022

jroelofs committed rG8440ec66f4f0: [docs] Document -ffinite-math-only, -fhonor-{infinities,infinites,nans} (authored by jroelofs).
[docs] Document -ffinite-math-only, -fhonor-{infinities,infinites,nans}
Feb 8 2022, 6:10 PM

Feb 4 2022

jroelofs committed rWf108bd04bb67: devmtg 2015-10: fixup the video link on "An update on Clang-based C++ Tooling" (authored by jroelofs).
devmtg 2015-10: fixup the video link on "An update on Clang-based C++ Tooling"
Feb 4 2022, 12:41 PM

Jan 3 2022

jroelofs accepted D115530: [GlobalOpt][Evaluator] Rewrite global ctor evaluation (fixes PR51879).

Looks like rebasing dropped the addition of clear(). LGTM with that and a linter-appeasing clang-format.

Jan 3 2022, 8:59 AM · Restricted Project

Dec 10 2021

jroelofs retitled D111158: [Docs][ORCv2] GetForCurrentProcess now returns an Expected<std::unique_ptr>. NFC from [Docs][ORCv2] GetForCurrentProcess now returns an ErrorOr<std::unique_ptr>. NFC to [Docs][ORCv2] GetForCurrentProcess now returns an Expected<std::unique_ptr>. NFC.
Dec 10 2021, 2:22 PM · Restricted Project
jroelofs committed rGd08303e40416: [Docs][ORCv2] GetForCurrentProcess now returns an Expected<std::unique_ptr>. NFC (authored by jroelofs).
[Docs][ORCv2] GetForCurrentProcess now returns an Expected<std::unique_ptr>. NFC
Dec 10 2021, 2:21 PM
jroelofs closed D111158: [Docs][ORCv2] GetForCurrentProcess now returns an Expected<std::unique_ptr>. NFC.
Dec 10 2021, 2:21 PM · Restricted Project
jroelofs added a comment to D115530: [GlobalOpt][Evaluator] Rewrite global ctor evaluation (fixes PR51879).

Elegant solution, I like it!

Dec 10 2021, 10:05 AM · Restricted Project

Dec 8 2021

jroelofs added inline comments to D115381: [AArch64][GlobalISel] Select scalar G_FMAXIMUM + G_FMINIMUM.
Dec 8 2021, 1:03 PM · Restricted Project, Restricted Project
jroelofs accepted D115376: [AArch64][GlobalISel] Add regbankselect support for G_FMAXIMUM/G_FMINIMUM.

LGTM

Dec 8 2021, 12:33 PM · Restricted Project
jroelofs accepted D115372: [AArch64][GlobalISel] Legalize scalar G_FMAXIMUM + G_FMINIMUM.

LGTM

Dec 8 2021, 12:23 PM · Restricted Project
jroelofs added inline comments to D115372: [AArch64][GlobalISel] Legalize scalar G_FMAXIMUM + G_FMINIMUM.
Dec 8 2021, 12:22 PM · Restricted Project
jroelofs added inline comments to D115372: [AArch64][GlobalISel] Legalize scalar G_FMAXIMUM + G_FMINIMUM.
Dec 8 2021, 12:22 PM · Restricted Project
jroelofs added inline comments to D115372: [AArch64][GlobalISel] Legalize scalar G_FMAXIMUM + G_FMINIMUM.
Dec 8 2021, 12:14 PM · Restricted Project

Nov 5 2021

jroelofs added a comment to D113054: [libcxxabi][SystemZ][z/OS] Update libcxxabi/src/cxa_exception_storage.cpp to support POSIX(OFF).

LGTM, but of course, please get a Group Reviewer's approval too.

Nov 5 2021, 10:27 AM · Restricted Project

Nov 3 2021

jroelofs added inline comments to D113069: [libcxx][SystemZ][z/OS] Update libcxx/src/random_shuffle.cpp to accommodate POSIX(OFF).
Nov 3 2021, 11:25 AM · Restricted Project
jroelofs added inline comments to D113066: [libcxx][SystemZ][z/OS] Update libcxx/src/memory.cpp to accommodate POSIX(OFF).
Nov 3 2021, 11:15 AM · Restricted Project
jroelofs added a comment to D113065: [libcxx][SystemZ][z/OS] Update libcxx/src/debug.cpp to accommodate POSIX(OFF).

LGTM

Nov 3 2021, 11:03 AM · Restricted Project
jroelofs added inline comments to D113054: [libcxxabi][SystemZ][z/OS] Update libcxxabi/src/cxa_exception_storage.cpp to support POSIX(OFF).
Nov 3 2021, 10:57 AM · Restricted Project
jroelofs added a comment to D110349: [libcxx][SystemZ][z/OS] Added is_threading_api_enabled and might_have_multiple_threads to __threading_support.

LGTM

Nov 3 2021, 10:07 AM · Restricted Project, Restricted Project

Nov 2 2021

jroelofs resigned from D113048: [libcxxabi] Fix NO_THREADS version of test_exception_storage.pass.cpp.

Looks ok to me, that said I'm not one of this project's group reviewers, so you'll need someone else's approval.

Nov 2 2021, 2:39 PM · Restricted Project

Oct 20 2021

jroelofs committed rGb046eb19b8a4: [AArch64][GlobalISel] combine (and (or x, c1), c2) => (and x, c2) iff c1 & c2… (authored by jroelofs).
[AArch64][GlobalISel] combine (and (or x, c1), c2) => (and x, c2) iff c1 & c2…
Oct 20 2021, 12:12 PM
jroelofs closed D111856: [AArch64][GlobalISel] combine (and (or x, c1), c2) => (and x, c2) iff c1 & c2 == 0.
Oct 20 2021, 12:12 PM · Restricted Project
jroelofs added a comment to D111856: [AArch64][GlobalISel] combine (and (or x, c1), c2) => (and x, c2) iff c1 & c2 == 0.

ping

Oct 20 2021, 10:53 AM · Restricted Project

Oct 18 2021

jroelofs committed rG1300677f976e: [AArch64][GlobalISel] combine and + [la]sr => ubfx (authored by jroelofs).
[AArch64][GlobalISel] combine and + [la]sr => ubfx
Oct 18 2021, 10:42 AM
jroelofs closed D111839: [AArch64][GlobalISel] combine and + [la]sr => ubfx.
Oct 18 2021, 10:42 AM · Restricted Project
jroelofs added a comment to D91815: Fix small typo in Block ABI docs.

can you please upload the patch with more context?

Oct 18 2021, 9:08 AM · Restricted Project
jroelofs added a reviewer for D91815: Fix small typo in Block ABI docs: rjmccall.
Oct 18 2021, 9:08 AM · Restricted Project

Oct 15 2021

jroelofs updated the diff for D111856: [AArch64][GlobalISel] combine (and (or x, c1), c2) => (and x, c2) iff c1 & c2 == 0.

Modify the G_AND in-place, and ignore vector types.

Oct 15 2021, 12:57 PM · Restricted Project
jroelofs updated the diff for D111839: [AArch64][GlobalISel] combine and + [la]sr => ubfx.
Oct 15 2021, 10:14 AM · Restricted Project
jroelofs added a comment to D111839: [AArch64][GlobalISel] combine and + [la]sr => ubfx.
In D111839#3066249, @foad wrote:

I don't think there are any cases where it is beneficial to combine ashr (and x, n), k -> sbfx (are there?), because for any case where you can do that, it would be better just to remove the and and leave it as an ashr.

Oct 15 2021, 8:57 AM · Restricted Project

Oct 14 2021

jroelofs updated the summary of D111839: [AArch64][GlobalISel] combine and + [la]sr => ubfx.
Oct 14 2021, 5:13 PM · Restricted Project
jroelofs updated the summary of D111856: [AArch64][GlobalISel] combine (and (or x, c1), c2) => (and x, c2) iff c1 & c2 == 0.
Oct 14 2021, 5:13 PM · Restricted Project
jroelofs requested review of D111856: [AArch64][GlobalISel] combine (and (or x, c1), c2) => (and x, c2) iff c1 & c2 == 0.
Oct 14 2021, 5:05 PM · Restricted Project
jroelofs requested review of D111839: [AArch64][GlobalISel] combine and + [la]sr => ubfx.
Oct 14 2021, 2:22 PM · Restricted Project

Oct 5 2021

jroelofs requested review of D111158: [Docs][ORCv2] GetForCurrentProcess now returns an Expected<std::unique_ptr>. NFC.
Oct 5 2021, 8:02 AM · Restricted Project

Oct 1 2021

jroelofs accepted D110959: [AArch64][GlobalISel] Change G_ANYEXT fed by scalar G_ICMP to G_ZEXT.

LGTM

Oct 1 2021, 1:49 PM · Restricted Project
jroelofs added inline comments to D110959: [AArch64][GlobalISel] Change G_ANYEXT fed by scalar G_ICMP to G_ZEXT.
Oct 1 2021, 1:02 PM · Restricted Project

Sep 16 2021

jroelofs committed rG4b19e7dfaee9: [LoopIdiomRecognize][Remarks] Track loop-strided store to/from blocks (authored by jroelofs).
[LoopIdiomRecognize][Remarks] Track loop-strided store to/from blocks
Sep 16 2021, 3:47 PM
jroelofs closed D109929: [LoopIdiomRecognize][Remarks] Track loop-strided store to/from blocks.
Sep 16 2021, 3:47 PM · Restricted Project
jroelofs added inline comments to D109929: [LoopIdiomRecognize][Remarks] Track loop-strided store to/from blocks.
Sep 16 2021, 3:47 PM · Restricted Project
jroelofs updated the diff for D109929: [LoopIdiomRecognize][Remarks] Track loop-strided store to/from blocks.
Sep 16 2021, 2:59 PM · Restricted Project
jroelofs updated the diff for D109929: [LoopIdiomRecognize][Remarks] Track loop-strided store to/from blocks.
Sep 16 2021, 2:58 PM · Restricted Project
jroelofs requested review of D109929: [LoopIdiomRecognize][Remarks] Track loop-strided store to/from blocks.
Sep 16 2021, 2:36 PM · Restricted Project
jroelofs accepted D109450: [IRSim][IROutliner] Allowing Intrinsic Calls to be Used in Similarity Matching and Outlined Regions.

LGTM

Sep 16 2021, 9:17 AM · Restricted Project

Sep 14 2021

jroelofs added inline comments to D109448: [IRSim][IROutliner] Treating Called Functions as Values and Outlining Indirect Calls.
Sep 14 2021, 8:53 AM · Restricted Project

Sep 3 2021

jroelofs accepted D109264: [GlobalISel] Add G_ROTL and G_ROTR to right_identity_zero.

LGTM

Sep 3 2021, 6:40 PM · Restricted Project
jroelofs added inline comments to D109131: [GlobalISel] Add a store-merging optimization pass and enable for AArch64..
Sep 3 2021, 1:30 PM · Restricted Project

Sep 1 2021

jroelofs added a reverting change for rG5cd63e9ec2a3: [AArch64][GlobalISel] Legalize bswap <2 x i16>: rG9237eda30407: Revert "[AArch64][GlobalISel] Legalize bswap <2 x i16>".
Sep 1 2021, 4:51 PM
jroelofs committed rG9237eda30407: Revert "[AArch64][GlobalISel] Legalize bswap <2 x i16>" (authored by jroelofs).
Revert "[AArch64][GlobalISel] Legalize bswap <2 x i16>"
Sep 1 2021, 4:51 PM
jroelofs added a reverting change for D105935: [AArch64][GlobalISel] Legalize bswap <2 x i16>: rG9237eda30407: Revert "[AArch64][GlobalISel] Legalize bswap <2 x i16>".
Sep 1 2021, 4:51 PM · Restricted Project
jroelofs added a comment to D105671: [Intrinsics][ObjC] Mark objc_retain and friends as thisreturn..
In D105671#2978248, @rjmccall wrote:

How does stripPointerCasts "see through" an attribute on the underlying call instruction?

Sep 1 2021, 4:11 PM · Restricted Project, Restricted Project

Aug 30 2021

jroelofs updated the diff for D105671: [Intrinsics][ObjC] Mark objc_retain and friends as thisreturn..

Also, turns out that stripPointerCasts() can see through the thisreturn attribute, which defeats a self retain optimization, breaking one of the clang tests. I tweaked a callback to make it configurable. Let me know if you see a better way of dealing with that.

Aug 30 2021, 5:12 PM · Restricted Project, Restricted Project

Aug 24 2021

jroelofs accepted D108673: [CodeExtractor] Preserve topological order for the return blocks..
Aug 24 2021, 5:01 PM · Restricted Project, Restricted Project
jroelofs added inline comments to D108657: [CodeExtractor] Ensuring ordering of exitStub creation.
Aug 24 2021, 2:01 PM · Restricted Project
jroelofs accepted D108660: [AArch64][GlobalISel] Legalize narrow scalar FP arithmetic.
Aug 24 2021, 1:47 PM · Restricted Project
jroelofs added inline comments to D108657: [CodeExtractor] Ensuring ordering of exitStub creation.
Aug 24 2021, 1:27 PM · Restricted Project
jroelofs added inline comments to D108656: [IROutliner] Using Canonical Values to find Corresponding Items between Regions.
Aug 24 2021, 1:06 PM · Restricted Project
jroelofs accepted D108610: [AArch64][GlobalISel] Legalize + select v2p0 -> v264 G_PTRTOINT.
Aug 24 2021, 9:32 AM · Restricted Project
jroelofs accepted D108600: [AArch64][GlobalISel] Select @llvm.aarch64.neon.ld4.*.
Aug 24 2021, 8:51 AM · Restricted Project

Aug 23 2021

jroelofs accepted D108590: [AArch64][GlobalISel] Select @llvm.aarch64.neon.ld2.*.
Aug 23 2021, 4:59 PM · Restricted Project
jroelofs accepted D108566: [AArch64][GlobalISel] Add regbankselect support for G_LLROUND.
Aug 23 2021, 10:18 AM · Restricted Project
jroelofs accepted D108564: [AArch64][GlobalISel] Legalize G_LLROUND for s64 + s32.
Aug 23 2021, 9:42 AM · Restricted Project
jroelofs accepted D108563: [GlobalISel] Translate @llvm.llround.* -> G_LLROUND.
Aug 23 2021, 9:18 AM · Restricted Project

Aug 20 2021

jroelofs added inline comments to D104143: [IRSim][IROutliner] Canonicalizing commutative value numbering between similarity sections..
Aug 20 2021, 1:55 PM · Restricted Project
jroelofs accepted D108419: [AArch64][GlobalISel] Add regbankselect support for G_LROUND.

LGTM

Aug 20 2021, 10:00 AM · Restricted Project
jroelofs accepted D108429: [GlobalISel] Add G_LLROUND.

LGTM

Aug 20 2021, 9:45 AM · Restricted Project
jroelofs accepted D108420: [AArch64][GlobalISel] Mark G_LROUND as legal for s64 dst + s32/s64 src..

LGTM

Aug 20 2021, 9:38 AM · Restricted Project

Aug 19 2021

jroelofs accepted D108418: [GlobalISel] Add IRTranslator support for @llvm.lround.* -> G_LROUND.

LGTM

Aug 19 2021, 3:54 PM · Restricted Project
jroelofs accepted D108417: [GlobalISel] Add a G_LROUND instruction.

LGTM

Aug 19 2021, 3:53 PM · Restricted Project
jroelofs added a comment to D108155: [PassBuilder] Use loop-mssa for licm.

Thank you!

Aug 19 2021, 3:47 PM · Restricted Project
jroelofs added a comment to D108155: [PassBuilder] Use loop-mssa for licm.

After some bisection, it appears this change broke llvm/test/Transforms/GuardWidening/loop-schedule.ll. The NewPM half of that test fails with:

Aug 19 2021, 3:00 PM · Restricted Project

Aug 17 2021

jroelofs accepted D108260: [AArch64][GlobalISel] Mark G_FMINNUM/G_FMAXNUM as floating point opcodes.

LGTM

Aug 17 2021, 5:53 PM · Restricted Project
jroelofs accepted D108226: [GlobalISel] Add IRTranslator support for G_ISNAN.

LGTM

Aug 17 2021, 11:21 AM · Restricted Project

Aug 13 2021

jroelofs accepted D108007: Simplify a .mailmap entry.

Thanks! I think the first and last line of the diff are now redundant. Otherwise LGTM.

Aug 13 2021, 9:20 AM · Restricted Project

Aug 6 2021

jroelofs committed rGeae4a44c1d4b: [GlobalISel][KnownBits] Implement G_CTPOP (authored by jroelofs).
[GlobalISel][KnownBits] Implement G_CTPOP
Aug 6 2021, 9:50 AM

Aug 5 2021

jroelofs added a comment to D107606: [GlobalISel][KnownBits] Implement G_CTPOP.

Also seems to have broken on PPC:

Aug 5 2021, 5:53 PM · Restricted Project
jroelofs added a reverting change for rGce6eb4f15a15: [GlobalISel][KnownBits] Implement G_CTPOP: rG5fc7b1a260f2: Revert "[GlobalISel][KnownBits] Implement G_CTPOP".
Aug 5 2021, 5:48 PM
jroelofs committed rG5fc7b1a260f2: Revert "[GlobalISel][KnownBits] Implement G_CTPOP" (authored by jroelofs).
Revert "[GlobalISel][KnownBits] Implement G_CTPOP"
Aug 5 2021, 5:48 PM