Page MenuHomePhabricator
People jroelofs

jroelofs (Jon Roelofs)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 27 2013, 1:02 PM (395 w, 1 d)

Recent Activity
View All

Tue, Jun 22

jroelofs committed rG493d6928fe10: [Remarks] Make memsize remarks report as an analysis, not a missed opportunity. (authored by jroelofs).
[Remarks] Make memsize remarks report as an analysis, not a missed opportunity.
Tue, Jun 22, 6:23 PM
jroelofs closed D104078: [Remarks] Make memsize remarks report as an analysis, not a missed opportunity..
Tue, Jun 22, 6:23 PM · Restricted Project

Fri, Jun 18

jroelofs accepted D104528: [GlobalISel] Constant fold G_SITOFP and G_UITOFP in CSEMIRBuilder.

LGTM

Fri, Jun 18, 9:40 AM · Restricted Project

Thu, Jun 17

jroelofs committed rGa2ab765029dd: [GISel] Eliminate redundant bitmasking (authored by jroelofs).
[GISel] Eliminate redundant bitmasking
Thu, Jun 17, 12:53 PM
jroelofs committed rG7b0612088289: [AArch64][GISel] and+or+shl => bfi (authored by jroelofs).
[AArch64][GISel] and+or+shl => bfi
Thu, Jun 17, 12:53 PM
jroelofs closed D103334: [GISel] Eliminate redundant bitmasking.
Thu, Jun 17, 12:53 PM · Restricted Project
jroelofs closed D103291: [AArch64][GISel] and+or+shl => bfi.
Thu, Jun 17, 12:53 PM · Restricted Project

Wed, Jun 16

jroelofs added inline comments to D103334: [GISel] Eliminate redundant bitmasking.
Wed, Jun 16, 3:04 PM · Restricted Project

Thu, Jun 10

jroelofs added a reviewer for D104078: [Remarks] Make memsize remarks report as an analysis, not a missed opportunity.: paquette.
Thu, Jun 10, 5:01 PM · Restricted Project
jroelofs requested review of D104078: [Remarks] Make memsize remarks report as an analysis, not a missed opportunity..
Thu, Jun 10, 4:59 PM · Restricted Project
jroelofs accepted D104065: [AArch64][GlobalISel] Legalize scalar G_CTTZ + G_CTTZ_ZERO_UNDEF.

LGTM

Thu, Jun 10, 3:04 PM · Restricted Project

Wed, Jun 9

jroelofs committed rG047f6d99158c: Add .mailmap entries for myself, and sort the list (authored by jroelofs).
Add .mailmap entries for myself, and sort the list
Wed, Jun 9, 6:37 PM
jroelofs committed rGf8f1c9c38989: Annotate memcpy's of globals with info about the src/dst (authored by jroelofs).
Annotate memcpy's of globals with info about the src/dst
Wed, Jun 9, 6:11 PM
jroelofs closed D103994: Annotate memcpy's of globals with info about the src/dst.
Wed, Jun 9, 6:11 PM · Restricted Project
jroelofs accepted D103999: [AArch64][GlobalISel] Mark some G_BITREVERSE types as legal + select them.

LGTM

Wed, Jun 9, 6:09 PM · Restricted Project
jroelofs requested review of D103994: Annotate memcpy's of globals with info about the src/dst.
Wed, Jun 9, 4:37 PM · Restricted Project
jroelofs added inline comments to D103769: [libcxx] Implement P0883R2 ("Fixing Atomic Initialization").
Wed, Jun 9, 9:29 AM · Restricted Project
jroelofs accepted D87302: [IRSim][IROutliner] Adding DebugInfo handling for IR outlined functions..

LGTM

Wed, Jun 9, 8:15 AM · debug-info, Restricted Project

Wed, Jun 2

jroelofs accepted D103577: RFC: Remove redundant Begin/End form signpost format strings..

LGTM

Wed, Jun 2, 5:35 PM · Restricted Project

Tue, Jun 1

jroelofs added inline comments to D94264: [GlobalISel] Add MachineInstNumbering to CSEInfo and propagate CSE throughout AArch64 pipeline..
Tue, Jun 1, 8:31 AM · Restricted Project

Sat, May 29

jroelofs accepted D99283: [GlobalISel] Combine and (lshr x, cst), mask -> ubfx x, cst, width.

LGTM

Sat, May 29, 3:57 PM · Restricted Project

Fri, May 28

jroelofs updated the diff for D103334: [GISel] Eliminate redundant bitmasking.
Fri, May 28, 4:22 PM · Restricted Project
jroelofs added inline comments to D103334: [GISel] Eliminate redundant bitmasking.
Fri, May 28, 2:45 PM · Restricted Project
jroelofs updated the diff for D103334: [GISel] Eliminate redundant bitmasking.

simplify test

Fri, May 28, 2:30 PM · Restricted Project
jroelofs updated the diff for D103291: [AArch64][GISel] and+or+shl => bfi.
Fri, May 28, 2:19 PM · Restricted Project
jroelofs added inline comments to D103334: [GISel] Eliminate redundant bitmasking.
Fri, May 28, 2:18 PM · Restricted Project
jroelofs updated the diff for D103334: [GISel] Eliminate redundant bitmasking.
Fri, May 28, 2:08 PM · Restricted Project
jroelofs added inline comments to D103334: [GISel] Eliminate redundant bitmasking.
Fri, May 28, 12:42 PM · Restricted Project
jroelofs added inline comments to D103291: [AArch64][GISel] and+or+shl => bfi.
Fri, May 28, 12:25 PM · Restricted Project
jroelofs requested review of D103334: [GISel] Eliminate redundant bitmasking.
Fri, May 28, 12:11 PM · Restricted Project
jroelofs updated the diff for D103291: [AArch64][GISel] and+or+shl => bfi.
Fri, May 28, 8:58 AM · Restricted Project

Thu, May 27

jroelofs added inline comments to D103291: [AArch64][GISel] and+or+shl => bfi.
Thu, May 27, 11:08 PM · Restricted Project
jroelofs requested review of D103291: [AArch64][GISel] and+or+shl => bfi.
Thu, May 27, 3:55 PM · Restricted Project

May 24 2021

jroelofs closed D95070: Fix crash when emitting NullReturn guards for functions returning BOOL.

This landed in 1deee5cacbb76578367186d7ff2937b6fa79b827

May 24 2021, 11:44 AM · Restricted Project
jroelofs committed rG095e91c9737b: [Remarks] Add analysis remarks for memset/memcpy/memmove lengths (authored by jroelofs).
[Remarks] Add analysis remarks for memset/memcpy/memmove lengths
May 24 2021, 10:11 AM
jroelofs committed rG694068d0db43: [Remarks] Look through inttoptr/ptrtoint for -ftrivial-auto-var-init remarks. (authored by jroelofs).
[Remarks] Look through inttoptr/ptrtoint for -ftrivial-auto-var-init remarks.
May 24 2021, 9:23 AM
jroelofs closed D102935: [Remarks] Look through inttoptr/ptrtoint for -ftrivial-auto-var-init remarks..
May 24 2021, 9:23 AM · Restricted Project

May 21 2021

jroelofs committed rGcc9c895d8844: [compiler-rt][profile] Explicitly specify PROFILE_SOURCES extensions. NFC (authored by jroelofs).
[compiler-rt][profile] Explicitly specify PROFILE_SOURCES extensions. NFC
May 21 2021, 2:46 PM
jroelofs added a comment to D102943: Hashing: use a 64-bit storage type on all platforms..

why do module hashes need to be stable when cross-compiling?

May 21 2021, 2:26 PM · Restricted Project, Restricted Project, Restricted Project
jroelofs updated the diff for D102935: [Remarks] Look through inttoptr/ptrtoint for -ftrivial-auto-var-init remarks..

Side-step the issue by using the other getUnderlyingOjbects api.

May 21 2021, 11:39 AM · Restricted Project
jroelofs requested review of D102935: [Remarks] Look through inttoptr/ptrtoint for -ftrivial-auto-var-init remarks..
May 21 2021, 10:57 AM · Restricted Project

May 20 2021

jroelofs added a reverting change for rG4bf69fb52b3c: [Remarks] Add analysis remarks for memset/memcpy/memmove lengths: rG0af3105b641a: Revert "[Remarks] Add analysis remarks for memset/memcpy/memmove lengths".
May 20 2021, 12:20 PM
jroelofs committed rG0af3105b641a: Revert "[Remarks] Add analysis remarks for memset/memcpy/memmove lengths" (authored by jroelofs).
Revert "[Remarks] Add analysis remarks for memset/memcpy/memmove lengths"
May 20 2021, 12:20 PM
jroelofs added a reverting change for D102452: [Remarks] Add analysis remarks for memset/memcpy/memmove lengths: rG0af3105b641a: Revert "[Remarks] Add analysis remarks for memset/memcpy/memmove lengths".
May 20 2021, 12:20 PM · Restricted Project

May 19 2021

jroelofs added inline comments to D99283: [GlobalISel] Combine and (lshr x, cst), mask -> ubfx x, cst, width.
May 19 2021, 6:55 PM · Restricted Project
jroelofs added a comment to D102452: [Remarks] Add analysis remarks for memset/memcpy/memmove lengths.
In D102452#2769992, @vvereschaka wrote:

Hi @jroelofs,

we've started getting the warnings for newly created file llvm/lib/Transforms/Utils/MemoryOpRemark.cpp on the cross toolchain builders:

c:\buildbot\as-builder-2\x-aarch64\llvm-project\llvm\lib\transforms\utils\memoryopremark.cpp(123) : warning C4715: 'llvm::MemoryOpRemark::remarkName': not all control paths return a value
c:\buildbot\as-builder-2\x-aarch64\llvm-project\llvm\lib\transforms\utils\memoryopremark.cpp(381) : warning C4715: 'llvm::AutoInitRemark::remarkName': not all control paths return a value

one of the builds as example: https://lab.llvm.org/buildbot/#/builders/119/builds/3889

there is no return for the method's argument unknown value.

Would you take care of it?

May 19 2021, 5:44 PM · Restricted Project
jroelofs committed rG3d2ffc88e6af: Fix warnings in windows bots. NFC (authored by jroelofs).
Fix warnings in windows bots. NFC
May 19 2021, 5:43 PM
jroelofs committed rG4bf69fb52b3c: [Remarks] Add analysis remarks for memset/memcpy/memmove lengths (authored by jroelofs).
[Remarks] Add analysis remarks for memset/memcpy/memmove lengths
May 19 2021, 3:19 PM
jroelofs closed D102452: [Remarks] Add analysis remarks for memset/memcpy/memmove lengths.
May 19 2021, 3:19 PM · Restricted Project
jroelofs updated the diff for D102452: [Remarks] Add analysis remarks for memset/memcpy/memmove lengths.

Use TLI instead of string compares on function names.

May 19 2021, 1:22 PM · Restricted Project
jroelofs updated the diff for D102452: [Remarks] Add analysis remarks for memset/memcpy/memmove lengths.

Collect size information about variables being read from.

May 19 2021, 11:47 AM · Restricted Project
jroelofs updated the diff for D102452: [Remarks] Add analysis remarks for memset/memcpy/memmove lengths.

Collect object size from the dereferenceable attribute too.

May 19 2021, 10:01 AM · Restricted Project

May 18 2021

jroelofs added inline comments to D102452: [Remarks] Add analysis remarks for memset/memcpy/memmove lengths.
May 18 2021, 5:54 PM · Restricted Project
jroelofs updated the diff for D102452: [Remarks] Add analysis remarks for memset/memcpy/memmove lengths.
May 18 2021, 5:50 PM · Restricted Project
jroelofs updated the diff for D102452: [Remarks] Add analysis remarks for memset/memcpy/memmove lengths.

Unified with the autoinit remarks.

May 18 2021, 4:10 PM · Restricted Project
jroelofs accepted D102656: [AArch64][GlobalISel] Prefer mov for s32->s64 G_ZEXT.

LGTM

May 18 2021, 8:30 AM · Restricted Project

May 17 2021

jroelofs added a comment to D102612: SwiftTailCC: teach verifier musttail rules applicable to this CC..

Why doesn't the count and sequence of arguments/parameters have to match for swifttail calls?

May 17 2021, 8:48 AM · Restricted Project

May 14 2021

jroelofs accepted D102477: X86: support Swift Async context.

LGTM

May 14 2021, 10:24 AM · Restricted Project

May 13 2021

jroelofs requested review of D102452: [Remarks] Add analysis remarks for memset/memcpy/memmove lengths.
May 13 2021, 4:48 PM · Restricted Project

May 12 2021

jroelofs accepted D101925: [docs] Added llvm/cmake section.
May 12 2021, 9:50 AM · Restricted Project
jroelofs accepted D95044: IR+AArch64: add `swiftasync` function parameter attribute.

LGTM

May 12 2021, 8:48 AM · Restricted Project

May 7 2021

jroelofs added inline comments to D89570: [Arm][Unwind][libc++abi] Add _Unwind_ForcedUnwind to EHABI..
May 7 2021, 8:09 AM

May 5 2021

jroelofs added inline comments to D89570: [Arm][Unwind][libc++abi] Add _Unwind_ForcedUnwind to EHABI..
May 5 2021, 1:58 PM
jroelofs added inline comments to D95044: IR+AArch64: add `swiftasync` function parameter attribute.
May 5 2021, 9:33 AM · Restricted Project
jroelofs updated subscribers of D95443: IR/AArch64/X86: add "swifttailcc" calling convention..
May 5 2021, 8:46 AM · Restricted Project

May 4 2021

jroelofs accepted D100908: [AArch64][GlobalISel] Legalize narrow type G_CTPOPs.

LGTM. No need to gate getting GISel to parity on doing *better* than SDAG.

May 4 2021, 5:58 PM · Restricted Project
jroelofs accepted D101856: [VecLib] Add support for vector fns from Darwin's libsystem..

LGTM

May 4 2021, 2:22 PM · Restricted Project
jroelofs added a comment to D101844: [MicroBenchmarks] Add initial loop vectorization benchmarks..
In D101844#2736630, @Meinersbur wrote:

The comparison is part of the time measurements. This doesn't seem useful to be for benchmarking the vectorized and non-vectorized versions together.

May 4 2021, 9:49 AM

May 3 2021

jroelofs committed rGaad311341736: Partial revert of "Use std::foo_t rather than std::foo in LLVM." in googlebench (authored by jroelofs).
Partial revert of "Use std::foo_t rather than std::foo in LLVM." in googlebench
May 3 2021, 7:50 AM
jroelofs closed D101583: Partial revert of "Use std::foo_t rather than std::foo in LLVM." in googlebench.
May 3 2021, 7:50 AM · Restricted Project

May 1 2021

jroelofs accepted D101687: [AArch64] Fold CSEL x, x, cc -> x.

nice!

May 1 2021, 10:26 AM · Restricted Project

Apr 30 2021

jroelofs committed rG421569b244b6: [EarlyIfConversion] Avoid producing selects with identical operands (authored by jroelofs).
[EarlyIfConversion] Avoid producing selects with identical operands
Apr 30 2021, 3:55 PM
jroelofs committed rG7f2109128fc9: [PowerPC] modernize test via update_llc_test_checks.py. NFC (authored by jroelofs).
[PowerPC] modernize test via update_llc_test_checks.py. NFC
Apr 30 2021, 3:55 PM
jroelofs added a reverting change for rG3d27b5d28aab: [EarlyIfConversion] Avoid producing selects with identical operands: rG8be3af36f9e1: Revert "[EarlyIfConversion] Avoid producing selects with identical operands".
Apr 30 2021, 2:56 PM
jroelofs committed rG8be3af36f9e1: Revert "[EarlyIfConversion] Avoid producing selects with identical operands" (authored by jroelofs).
Revert "[EarlyIfConversion] Avoid producing selects with identical operands"
Apr 30 2021, 2:56 PM
jroelofs added a reverting change for D101508: [EarlyIfConversion] Avoid producing selects with identical operands: rG8be3af36f9e1: Revert "[EarlyIfConversion] Avoid producing selects with identical operands".
Apr 30 2021, 2:56 PM · Restricted Project
jroelofs committed rG3d27b5d28aab: [EarlyIfConversion] Avoid producing selects with identical operands (authored by jroelofs).
[EarlyIfConversion] Avoid producing selects with identical operands
Apr 30 2021, 2:43 PM
jroelofs closed D101508: [EarlyIfConversion] Avoid producing selects with identical operands.
Apr 30 2021, 2:43 PM · Restricted Project
jroelofs updated the diff for D101508: [EarlyIfConversion] Avoid producing selects with identical operands.
Apr 30 2021, 9:53 AM · Restricted Project

Apr 29 2021

jroelofs added a comment to D101583: Partial revert of "Use std::foo_t rather than std::foo in LLVM." in googlebench.
In D101583#2727555, @MaskRay wrote:

llvm/CMakeLists.txt sets CMAKE_CXX_STANDARD to 14.

Apr 29 2021, 6:04 PM · Restricted Project
jroelofs added a comment to D101583: Partial revert of "Use std::foo_t rather than std::foo in LLVM." in googlebench.
In D101583#2727459, @MaskRay wrote:

How about just using C++14 for utils/benchmark/ ?

Apr 29 2021, 5:11 PM · Restricted Project
jroelofs committed rT9804804683a3: Don't require c++14 features in matrix extensions tests. NFC (authored by jroelofs).
Don't require c++14 features in matrix extensions tests. NFC
Apr 29 2021, 4:19 PM
jroelofs closed D100861: Don't require c++14 features in matrix extensions tests. NFC.

9804804683a36b9b23ba9b37d2cca616f560afaf

Apr 29 2021, 3:52 PM
jroelofs requested review of D101583: Partial revert of "Use std::foo_t rather than std::foo in LLVM." in googlebench.
Apr 29 2021, 3:46 PM · Restricted Project
jroelofs updated the diff for D101508: [EarlyIfConversion] Avoid producing selects with identical operands.

Handle instructions with multiple defs.

Apr 29 2021, 12:23 PM · Restricted Project
jroelofs added inline comments to D46278: [AArch64] Fold B = csel A, A into B = COPY A.
Apr 29 2021, 10:30 AM · Restricted Project
jroelofs updated the diff for D101508: [EarlyIfConversion] Avoid producing selects with identical operands.
Apr 29 2021, 8:41 AM · Restricted Project
jroelofs added inline comments to D46278: [AArch64] Fold B = csel A, A into B = COPY A.
Apr 29 2021, 8:37 AM · Restricted Project

Apr 28 2021

jroelofs added inline comments to D101508: [EarlyIfConversion] Avoid producing selects with identical operands.
Apr 28 2021, 7:08 PM · Restricted Project
jroelofs added inline comments to D101508: [EarlyIfConversion] Avoid producing selects with identical operands.
Apr 28 2021, 7:04 PM · Restricted Project
jroelofs removed a reviewer for D101508: [EarlyIfConversion] Avoid producing selects with identical operands: greened.
Apr 28 2021, 6:51 PM · Restricted Project
jroelofs updated the summary of D101508: [EarlyIfConversion] Avoid producing selects with identical operands.
Apr 28 2021, 6:43 PM · Restricted Project
jroelofs added a comment to D101508: [EarlyIfConversion] Avoid producing selects with identical operands.
In D101508#2724583, @xbolva00 wrote:

Please add a testcase

Apr 28 2021, 6:43 PM · Restricted Project
jroelofs updated the diff for D101508: [EarlyIfConversion] Avoid producing selects with identical operands.
Apr 28 2021, 6:42 PM · Restricted Project
jroelofs added a comment to D46278: [AArch64] Fold B = csel A, A into B = COPY A.

Since the source of these seems to be early-ifcvt, maybe it's better to solve this problem there? https://reviews.llvm.org/D101508

Apr 28 2021, 6:41 PM · Restricted Project
jroelofs added a reviewer for D101508: [EarlyIfConversion] Avoid producing selects with identical operands: rengolin.
Apr 28 2021, 6:40 PM · Restricted Project
jroelofs requested review of D101508: [EarlyIfConversion] Avoid producing selects with identical operands.
Apr 28 2021, 6:39 PM · Restricted Project
jroelofs added inline comments to D46278: [AArch64] Fold B = csel A, A into B = COPY A.
Apr 28 2021, 11:25 AM · Restricted Project
jroelofs added inline comments to D46278: [AArch64] Fold B = csel A, A into B = COPY A.
Apr 28 2021, 10:16 AM · Restricted Project

Apr 26 2021

jroelofs updated the diff for D46278: [AArch64] Fold B = csel A, A into B = COPY A.

rebased & fixed a few issues that showed up in the tests

Apr 26 2021, 1:55 PM · Restricted Project