jroelofs (Jonathan Roelofs)
Sourcerer

Projects

User does not belong to any projects.

User Details

User Since
Nov 27 2013, 1:02 PM (238 w, 1 d)

Recent Activity

Apr 6 2018

jroelofs updated subscribers of D41316: [libcxx] Allow random_device to be built optionally.
the targets where you would want to use this can't run the libcxx

testsuite anyway (because they don't have an operating system to run the
test programs under).

Apr 6 2018, 6:36 AM

Feb 11 2018

jroelofs added a comment to D43159: Modernize: Use nullptr more..

Is it worth adding -Werror=zero-as-null-pointer-constant to the build?

Feb 11 2018, 1:24 PM

Jan 31 2018

jroelofs committed rC323864: Fix typo. NFC.
Fix typo. NFC
Jan 31 2018, 4:08 AM
jroelofs committed rL323864: Fix typo. NFC.
Fix typo. NFC
Jan 31 2018, 4:08 AM
jroelofs added inline comments to rC323665: [scan-build] Add an option to skip overriding CC and CXX make vars.
Jan 31 2018, 4:08 AM

Jan 29 2018

jroelofs committed rL323665: [scan-build] Add an option to skip overriding CC and CXX make vars.
[scan-build] Add an option to skip overriding CC and CXX make vars
Jan 29 2018, 8:51 AM
jroelofs committed rC323665: [scan-build] Add an option to skip overriding CC and CXX make vars.
[scan-build] Add an option to skip overriding CC and CXX make vars
Jan 29 2018, 8:51 AM
jroelofs committed rL323664: [analyzer] Fix -x language argument for C preprocessed sources.
[analyzer] Fix -x language argument for C preprocessed sources
Jan 29 2018, 8:39 AM
jroelofs committed rC323664: [analyzer] Fix -x language argument for C preprocessed sources.
[analyzer] Fix -x language argument for C preprocessed sources
Jan 29 2018, 8:39 AM

Jan 11 2018

jroelofs added a comment to D41316: [libcxx] Allow random_device to be built optionally.

Should we go with current patch?

Jan 11 2018, 10:38 AM

Jan 9 2018

jroelofs accepted D41873: [Option] For typo '-foo', suggest '--foo'.

LGTM

Jan 9 2018, 10:54 AM

Jan 8 2018

jroelofs added a comment to D41793: [Debugify] Add a mode to opt to enable faster testing.

You can avoid the env var by adding a substitution for opt in the lit.cfg.py with the extra argument.

Jan 8 2018, 9:38 AM · debug-info

Jan 5 2018

jroelofs accepted D41732: [Option] Add 'findNearest' method to catch typos.

LGTM

Jan 5 2018, 8:16 AM
jroelofs added inline comments to D41732: [Option] Add 'findNearest' method to catch typos.
Jan 5 2018, 4:48 AM
jroelofs added inline comments to D41732: [Option] Add 'findNearest' method to catch typos.
Jan 5 2018, 4:36 AM
jroelofs added inline comments to D41733: [Driver] Suggest correctly spelled driver options.
Jan 5 2018, 4:15 AM
jroelofs added inline comments to D41732: [Option] Add 'findNearest' method to catch typos.
Jan 5 2018, 4:10 AM

Jan 4 2018

jroelofs added inline comments to D41733: [Driver] Suggest correctly spelled driver options.
Jan 4 2018, 12:22 PM
jroelofs added inline comments to D41732: [Option] Add 'findNearest' method to catch typos.
Jan 4 2018, 12:19 PM

Dec 29 2017

jroelofs committed rCXXA321569: Try again, this time with the correct address.
Try again, this time with the correct address
Dec 29 2017, 12:48 PM
jroelofs committed rCXXA321564: Update CREDITS.txt with personal email address.
Update CREDITS.txt with personal email address
Dec 29 2017, 12:48 PM
jroelofs committed rCXX321570: Try again, this time with the correct address.
Try again, this time with the correct address
Dec 29 2017, 11:42 AM
jroelofs committed rCXX321563: Update CREDITS.txt with personal email.
Update CREDITS.txt with personal email
Dec 29 2017, 11:42 AM
jroelofs committed rL321570: Try again, this time with the correct address.
Try again, this time with the correct address
Dec 29 2017, 11:27 AM
jroelofs committed rL321569: Try again, this time with the correct address.
Try again, this time with the correct address
Dec 29 2017, 11:27 AM
jroelofs committed rL321564: Update CREDITS.txt with personal email address.
Update CREDITS.txt with personal email address
Dec 29 2017, 11:17 AM
jroelofs committed rL321563: Update CREDITS.txt with personal email.
Update CREDITS.txt with personal email
Dec 29 2017, 11:16 AM

Dec 16 2017

jroelofs added a comment to D41316: [libcxx] Allow random_device to be built optionally.

I say that because there are contexts where it is absolutely critical that https://xkcd.com/221/ not be the implementation of an RNG.

Dec 16 2017, 7:54 AM
jroelofs added a comment to D41316: [libcxx] Allow random_device to be built optionally.

I'd much rather provide no implementation than one that lies. Broken builds are much safer than problems at runtime.

Dec 16 2017, 7:49 AM

Dec 5 2017

jroelofs added a comment to D28820: Warn when calling a non interrupt function from an interrupt on ARM.

What is the best way to modify the code for this compiler change ?

Currently, the "interrupt" attribute only has an effect on functions, not function pointers, so your code won't work the way you want. It's a bug that we don't emit a warning for this.

Dec 5 2017, 3:38 AM

Dec 4 2017

jroelofs added a comment to D40816: [libunwind] Use the correct variable name for target triple in lit.

I think just remove it from them.

Dec 4 2017, 5:01 PM
jroelofs added a comment to D40816: [libunwind] Use the correct variable name for target triple in lit.

(i.e. you should delete that, since this is the last dependency on it AFAICT)

Dec 4 2017, 4:39 PM
jroelofs added a comment to D40816: [libunwind] Use the correct variable name for target triple in lit.

There's a: set(TARGET_TRIPLE ...) in each of these runtimes' CMakeLists.txt...

Dec 4 2017, 4:37 PM
jroelofs added a comment to D40775: [libcxx] Add underscores to win32 locale headers..

looks fine to me, but this is the sort of thing that @EricWF usually wants the final say on.

Dec 4 2017, 11:16 AM
jroelofs added inline comments to D40775: [libcxx] Add underscores to win32 locale headers..
Dec 4 2017, 8:12 AM

Dec 1 2017

jroelofs added a comment to D40734: New users should be using the runtimes dir, not projects.

The docs changes look good to me. I think if we want to deprecate llvm/projects for runtime libraries, we should have a discussion on llvm-dev & cfe-dev. I think too few people are using llvm/runtimes today as part of their regular builds for me to feel comfortable deprecating llvm/projects without giving some notice first and getting more people to try the runtimes directory.

Dec 1 2017, 3:04 PM
jroelofs created D40734: New users should be using the runtimes dir, not projects.
Dec 1 2017, 8:46 AM

Nov 19 2017

jroelofs added inline comments to D40218: [Clang] Add __builtin_launder.
Nov 19 2017, 2:13 PM
jroelofs added inline comments to D40218: [Clang] Add __builtin_launder.
Nov 19 2017, 1:59 PM

Nov 13 2017

jroelofs accepted D39793: [asan] Remove semicolon after do {} while (0).

LGTM

Nov 13 2017, 1:06 PM

Nov 12 2017

jroelofs added a comment to D39949: [CMake][libcxxabi] Support merging archives when statically linking unwinder.

What's the advantage to using python for this over doing it directly in CMake?

Nov 12 2017, 4:24 PM

Nov 4 2017

jroelofs added a comment to D39534: [libunwind] Add ifdefs around ELF specific parts of UnwindRegisters*.S for ARM.

Very well, if thats the current implementation in the AsmParser, thats reasonable. I don't think that the directive has anything to do with the file format though.

I can agree with that. In addition to making the assembler accept/reject certain instructions though, it actually does another thing which actually is file format specific - it sets the eabi attributes that indicates that the object file contains such instructions.

Are they eabi/gnueabi things?

I think so. You can read them with readelf -A foo.o, and override them with manual .eabi_attribute attributes. (That's useful e.g. for indicating that while a binary contains NEON instructions, it doesn't strict require them for running. E.g. raspbian does check such tags for checking that all binaries work on their baseline of armv6.)

Nov 4 2017, 2:36 PM
jroelofs added a comment to D39534: [libunwind] Add ifdefs around ELF specific parts of UnwindRegisters*.S for ARM.

Very well, if thats the current implementation in the AsmParser, thats reasonable. I don't think that the directive has anything to do with the file format though.

I can agree with that. In addition to making the assembler accept/reject certain instructions though, it actually does another thing which actually is file format specific - it sets the eabi attributes that indicates that the object file contains such instructions.

Nov 4 2017, 2:15 PM

Oct 29 2017

jroelofs added inline comments to D39146: WIP: fix ldscript AT> parsing.
Oct 29 2017, 6:51 PM
jroelofs added a comment to D39146: WIP: fix ldscript AT> parsing.

The name is a bad idea, because you could get an expression or a value which is not a region name. I think that you should test that as well.

Oct 29 2017, 6:50 PM

Oct 20 2017

jroelofs created D39146: WIP: fix ldscript AT> parsing.
Oct 20 2017, 2:57 PM

Oct 11 2017

jroelofs added a comment to D38599: Remove warnings for dynamic_cast fallback..

Needs a docs entry for the new flag (in libcxx's BuildingLibcxx.rst). Other than that, all the stuff I've asked you to add LGTM. I'd still appreciate @EricWF / @mclow 's opinion on the meat of the functional change part of this though... I don't know all the implications relaxing the search here.

Oct 11 2017, 4:01 PM
jroelofs accepted D38679: [libunwind] Support dwarf unwinding on i386 windows.

LGTM

Oct 11 2017, 7:30 AM

Oct 10 2017

jroelofs added a comment to D38599: Remove warnings for dynamic_cast fallback..

That reminds me... this does need a testcase or two.

Oh, also, any test I add is going to fail, since the case I'm trying to account for here is not the default behavior.

That's what an available_feature + // REQUIRES: is for.

Oct 10 2017, 5:23 PM
jroelofs added a comment to D38599: Remove warnings for dynamic_cast fallback..

That reminds me... this does need a testcase or two.

Oh, also, any test I add is going to fail, since the case I'm trying to account for here is not the default behavior.

Oct 10 2017, 3:59 PM
jroelofs added a comment to D38599: Remove warnings for dynamic_cast fallback..

That reminds me... this does need a testcase or two.

Oct 10 2017, 2:55 PM
jroelofs added a comment to D38741: [lit] Add host_cxx to lit config.

Where is it used?

Oct 10 2017, 9:55 AM

Oct 9 2017

jroelofs accepted D38711: typos in documentation?.

LGTM

Oct 9 2017, 4:41 PM
jroelofs edited reviewers for D38599: Remove warnings for dynamic_cast fallback., added: mclow.lists, EricWF; removed: jroelofs.
Oct 9 2017, 3:03 PM
jroelofs resigned from D38599: Remove warnings for dynamic_cast fallback..

I'm not sure I'm the right person to review this.

Oct 9 2017, 1:31 PM
jroelofs added inline comments to D38679: [libunwind] Support dwarf unwinding on i386 windows.
Oct 9 2017, 1:19 PM
jroelofs added inline comments to D38679: [libunwind] Support dwarf unwinding on i386 windows.
Oct 9 2017, 12:21 PM

Sep 29 2017

jroelofs updated the diff for D38416: [RFC] Add a LIT-style Progress Bar to libSupport.

Add a testcase per @bogner's advice (sort of). I tried doing the setenv trick, but that only worked when the testcase is ran not under LIT. Since I have to inject other state in anyway for testing, may as well just use that flag to force 60 cols too.

Sep 29 2017, 3:11 PM
jroelofs updated the diff for D38416: [RFC] Add a LIT-style Progress Bar to libSupport.

Rate-limit it, since it'll look awful if you call update() really often.

Sep 29 2017, 12:51 PM
jroelofs added a comment to D38416: [RFC] Add a LIT-style Progress Bar to libSupport.

It occurs to me that Chandler's also the right person to ask about ideas on how to estimate the progress of a PassManager.

Sep 29 2017, 11:30 AM
jroelofs added a reviewer for D38416: [RFC] Add a LIT-style Progress Bar to libSupport: chandlerc.

@aaron.ballman suggested adding @chandlerc as a reviewer

Sep 29 2017, 11:28 AM
jroelofs created D38416: [RFC] Add a LIT-style Progress Bar to libSupport.
Sep 29 2017, 10:26 AM

Sep 19 2017

jroelofs committed rL313680: [ARM] Relax 'cpsie'/'cpsid' flag parsing..
[ARM] Relax 'cpsie'/'cpsid' flag parsing.
Sep 19 2017, 2:25 PM
jroelofs closed D37953: [ARM] Relax `cpsie`/`cpsid` flag parsing..

r313680

Sep 19 2017, 2:25 PM

Sep 16 2017

jroelofs created D37953: [ARM] Relax `cpsie`/`cpsid` flag parsing..
Sep 16 2017, 6:11 PM

Sep 8 2017

jroelofs added a comment to D37629: [Sema] Move some stuff into -Wtautological-unsigned-enum-zero-compare.

I'm not sure it's better than writing the if/elseif/elseif/elseif out explicitly :/

Sep 8 2017, 10:39 AM · Restricted Project

Sep 7 2017

jroelofs added a comment to D37602: Properly hook debuginfo-tests up to lit and CMake.

Unless you're going for "make this lit.cfg as close as possible to clang's", then...

Sep 7 2017, 5:14 PM
jroelofs committed rL312748: Fix validation of the -mthread-model flag in the Clang driver.
Fix validation of the -mthread-model flag in the Clang driver
Sep 7 2017, 3:04 PM
jroelofs closed D37496: Fix validation of the -mthread-model flag in the Clang driver.

r312748

Sep 7 2017, 3:03 PM

Sep 6 2017

jroelofs committed rL312651: Fix ARM bare metal driver to support atomics.
Fix ARM bare metal driver to support atomics
Sep 6 2017, 10:10 AM
jroelofs closed D37493: Fix ARM bare metal driver to support atomics.

r312651

Sep 6 2017, 10:10 AM
jroelofs added a comment to D37493: Fix ARM bare metal driver to support atomics.

Sure. I'll commit it for you once this build/test cycle is finished.

Sep 6 2017, 9:47 AM

Sep 5 2017

jroelofs added a comment to D37493: Fix ARM bare metal driver to support atomics.

FWIW, I defaulted this to -mthread-model=single to match existing baremetal gcc toolchains, and support armv4t & others that don't have the requisite atomic ops.

Sep 5 2017, 2:56 PM
jroelofs added inline comments to D37484: [libunwind] Always use unwind tables in tests.
Sep 5 2017, 10:15 AM

Aug 7 2017

jroelofs accepted D36383: [CMake] Allow overriding lib dir suffix independently from LLVM.

LGTM

Aug 7 2017, 8:40 AM

Jul 31 2017

jroelofs added a comment to D35542: libcxxabi: Suppress LLVM_ENABLE_MODULES.

Does the unwinder need this too?

Jul 31 2017, 7:28 AM

Jul 26 2017

jroelofs committed rL309147: Partial fix for PR33858.
Partial fix for PR33858
Jul 26 2017, 11:15 AM
jroelofs closed D35848: Partial fix for PR33858.

r309147

Jul 26 2017, 11:15 AM
jroelofs added a comment to D35880: Un-revert "Teach the CMake build system to run lit's test suite. These can be run".

The code looks good, and seems to work. I'm sometimes getting a failure from shtest-timeout.py but I suspect that's an irrelevant race condition.

Jul 26 2017, 7:24 AM

Jul 25 2017

jroelofs created D35848: Partial fix for PR33858.
Jul 25 2017, 10:57 AM

Jul 24 2017

jroelofs accepted D35426: [clang] Add abi-breaking-checks support to clang.

LGTM

Jul 24 2017, 2:06 PM

Jul 18 2017

jroelofs added inline comments to D35038: [libunwind] Add a test harness.
Jul 18 2017, 3:34 PM
jroelofs added inline comments to D35038: [libunwind] Add a test harness.
Jul 18 2017, 2:47 PM
jroelofs added inline comments to D33561: [CMake] Add Android toolchain CMake cache files..
Jul 18 2017, 1:40 PM
jroelofs added inline comments to D33561: [CMake] Add Android toolchain CMake cache files..
Jul 18 2017, 1:00 PM

Jul 12 2017

jroelofs accepted D35328: Reland "[Driver] Update Fuchsia driver path handling".
Jul 12 2017, 2:39 PM
jroelofs added inline comments to D34075: [compiler-rt][builtins] Better Fuchsia support.
Jul 12 2017, 12:42 PM

Jul 9 2017

jroelofs added a comment to D34918: [libc++] Refactoring __sync_* builtins; NFC.

@EricWF , do you mean factoring out the __sync_* functions like this?

Jul 9 2017, 6:13 AM

Jul 6 2017

jroelofs closed D35038: [libunwind] Add a test harness.

r307266

Jul 6 2017, 8:20 AM
jroelofs committed rL307266: Add a test harness.
Add a test harness
Jul 6 2017, 8:20 AM

Jul 5 2017

jroelofs created D35038: [libunwind] Add a test harness.
Jul 5 2017, 4:49 PM

Jun 22 2017

jroelofs added inline comments to D34157: [llvm-stress] Use C++11 mersenne_twister_engine random device instead of our own (PR32585).
Jun 22 2017, 3:16 PM

Jun 20 2017

jroelofs added a comment to D33762: [libcxx][CMake] Add install path variable to allow overriding the destination.

@EricWF we don't do any installed testing, only testing from the build dir, right?

Jun 20 2017, 6:50 AM

Jun 13 2017

jroelofs added inline comments to D32816: [CMake] Support multi-target runtimes build.
Jun 13 2017, 7:16 AM

Jun 12 2017

jroelofs added inline comments to D34075: [compiler-rt][builtins] Better Fuchsia support.
Jun 12 2017, 7:16 AM

Jun 5 2017

jroelofs updated subscribers of D32816: [CMake] Support multi-target runtimes build.
Jun 5 2017, 10:22 AM
jroelofs added inline comments to D32835: [compiler-rt] [cmake] Support generic installation.
Jun 5 2017, 10:17 AM
jroelofs added a comment to D33259: Don't defer to the GCC driver for linking arm-baremetal.

This causes a test failure with non-standard CLANG_RESOURCE_DIR:

Jun 5 2017, 7:10 AM
jroelofs accepted D33877: [test] Fix baremetal test to allow any -resource-dir.

LGTM... thank you!

Jun 5 2017, 7:08 AM

May 25 2017

jroelofs added inline comments to D32816: [CMake] Support multi-target runtimes build.
May 25 2017, 3:12 PM