love it!

In D157283#4611447, @PiotrZSL wrote:

I don't know how, but somehow this change breaks clang-tidy/infrastructure/clang-tidy-mac-libcxx.cpp test.

LGTM, thank you!

Suggest using llvm/utils/update_llc_test_checks.py to write the CHECKs, so they're easier to update later.

In D150144#4583702, @chapuni wrote:

@jroelofs Sorry for the delay and thanks for the report.

I didn't expect the case of LLVM_TABLEGEN=$BUILD/bin/llvm-tblgen (with path). It would be bad if llvm-min-tblgen is overridden by LLVM_TABLEGEN, that is not an external executable but is built in-tree.

I would like the config not to specify LLVM_TABLEGEN unless it is external. But I could let CMake check whether LLVM_TABLEGEN points actually internal target.

LGTM

LGTM

Re-applying (shortly), because the revert broke the modules build again, which seems to have more short term positive impact than fixing the circular dependency:

Reverted, as this turned out to cause a cyclic dependency (as @bulbazord suspected). If the Modules bots run into this again, I'm not sure how to fix it...

Flaky test? Here's a later build where it succeeds, but the change has nothing to do with clangd: https://lab.llvm.org/buildbot/#/builders/168/builds/14997

In D157119#4564546, @vitalybuka wrote:

I suspect one of your recent changes broke https://lab.llvm.org/buildbot/#/builders/168/builds/14944
Can you please take a look?

missed one more: 3d756c32cdf005d0f4c05f561fec4a37b64b7ddd

back-porting to the release branch: https://github.com/llvm/llvm-project/issues/64432

related discussion: https://discourse.llvm.org/t/rfc-permanently-fixing-the-missing-tablegen-dependency-issue/70442/14

LGTM

In D74094#4559037, @dexonsmith wrote:

In D74094#4554327, @foad wrote:

Hi @erik.pilkington, I see this got reverted:

I'm not sure if @erik.pilkington is still watching Phabricator, but in any case I think (like me) he no longer has rdar access. Since this was a Linux PPC bot, it's possible Erik didn't get far investigating the failure. Three years later, the sands may have shifted substantially... maybe the best option to is rebase and investigate the new failures (if any).

@akyrtzi @arphaman @jroelofs, is one of you available to check rdar://58552124, in case it has extra context from the PPC bot failure?

LGTM

Found a simpler way to work around the issue that motivated this in D105671.

Rebase. Avoid the dependency on D156735

oops, uploaded the wrong patch to this review.

Move the stripPointerCasts() change into its own review: https://reviews.llvm.org/D156735

In D105671#4547848, @nikic wrote:

Please separate the change to stripPointerCasts() into a separate review.

d699e54ca291a7e58d997760481f246db32b506a

LGTM

I think this deserves an entry in llvm/utils/vim/syntax/llvm.vim under keywords.

Do you think this and the other patch are good candidates for .git-blame-ignore-revs entries?

@craig.topper's feedback

llvm/test/CodeGen/RISCV/rvv/setcc-integer.ll

More precise carveout.

Add a carveout for the cases the RISCV tests care about.