- User Since
- Nov 27 2013, 1:02 PM (251 w, 3 d)
Sun, Sep 16
Tue, Aug 28
LGTM. Thanks for fixing this!
Jul 27 2018
Apr 6 2018
the targets where you would want to use this can't run the libcxx
testsuite anyway (because they don't have an operating system to run the
test programs under).
Feb 11 2018
Is it worth adding -Werror=zero-as-null-pointer-constant to the build?
Jan 31 2018
Jan 29 2018
Jan 11 2018
Should we go with current patch?
Jan 9 2018
Jan 8 2018
You can avoid the env var by adding a substitution for opt in the lit.cfg.py with the extra argument.
Jan 5 2018
Jan 4 2018
Dec 29 2017
Dec 16 2017
I say that because there are contexts where it is absolutely critical that https://xkcd.com/221/ not be the implementation of an RNG.
I'd much rather provide no implementation than one that lies. Broken builds are much safer than problems at runtime.
Dec 5 2017
Dec 4 2017
I think just remove it from them.
(i.e. you should delete that, since this is the last dependency on it AFAICT)
There's a: set(TARGET_TRIPLE ...) in each of these runtimes' CMakeLists.txt...
looks fine to me, but this is the sort of thing that @EricWF usually wants the final say on.
Dec 1 2017
Nov 19 2017
Nov 13 2017
Nov 12 2017
What's the advantage to using python for this over doing it directly in CMake?
Nov 4 2017
Oct 29 2017
Oct 20 2017
Oct 11 2017
Needs a docs entry for the new flag (in libcxx's BuildingLibcxx.rst). Other than that, all the stuff I've asked you to add LGTM. I'd still appreciate @EricWF / @mclow 's opinion on the meat of the functional change part of this though... I don't know all the implications relaxing the search here.
Oct 10 2017
That reminds me... this does need a testcase or two.
Where is it used?
Oct 9 2017
I'm not sure I'm the right person to review this.
Sep 29 2017
Add a testcase per @bogner's advice (sort of). I tried doing the setenv trick, but that only worked when the testcase is ran not under LIT. Since I have to inject other state in anyway for testing, may as well just use that flag to force 60 cols too.
Rate-limit it, since it'll look awful if you call update() really often.
It occurs to me that Chandler's also the right person to ask about ideas on how to estimate the progress of a PassManager.
Sep 19 2017
Sep 16 2017
Sep 8 2017
I'm not sure it's better than writing the if/elseif/elseif/elseif out explicitly :/
Sep 7 2017
Unless you're going for "make this lit.cfg as close as possible to clang's", then...
Sep 6 2017
Sure. I'll commit it for you once this build/test cycle is finished.
Sep 5 2017
FWIW, I defaulted this to -mthread-model=single to match existing baremetal gcc toolchains, and support armv4t & others that don't have the requisite atomic ops.
Aug 7 2017
Jul 31 2017
Does the unwinder need this too?
Jul 26 2017
Jul 25 2017
Jul 24 2017
Jul 18 2017
Jul 12 2017
Jul 9 2017
Jul 6 2017
Jul 5 2017
Jun 22 2017
Jun 20 2017
@EricWF we don't do any installed testing, only testing from the build dir, right?