User Details
- User Since
- Nov 27 2013, 1:02 PM (512 w, 5 d)
Mon, Sep 18
Tue, Sep 5
Thu, Aug 31
love it!
Aug 23 2023
LGTM, thank you!
Aug 21 2023
Suggest using llvm/utils/update_llc_test_checks.py to write the CHECKs, so they're easier to update later.
Aug 15 2023
Aug 14 2023
Aug 11 2023
LGTM
Aug 10 2023
LGTM
Re-applying (shortly), because the revert broke the modules build again, which seems to have more short term positive impact than fixing the circular dependency:
Aug 9 2023
Reverted, as this turned out to cause a cyclic dependency (as @bulbazord suspected). If the Modules bots run into this again, I'm not sure how to fix it...
Aug 8 2023
Flaky test? Here's a later build where it succeeds, but the change has nothing to do with clangd: https://lab.llvm.org/buildbot/#/builders/168/builds/14997
Aug 7 2023
Aug 4 2023
missed one more: 3d756c32cdf005d0f4c05f561fec4a37b64b7ddd
back-porting to the release branch: https://github.com/llvm/llvm-project/issues/64432
Aug 3 2023
LGTM
LGTM
Aug 2 2023
Aug 1 2023
Found a simpler way to work around the issue that motivated this in D105671.
Rebase. Avoid the dependency on D156735
Jul 31 2023
oops, uploaded the wrong patch to this review.
Move the stripPointerCasts() change into its own review: https://reviews.llvm.org/D156735
Jul 29 2023
Jul 28 2023
LGTM
Jul 27 2023
Jul 26 2023
I think this deserves an entry in llvm/utils/vim/syntax/llvm.vim under keywords.
Jul 21 2023
Jul 18 2023
Do you think this and the other patch are good candidates for .git-blame-ignore-revs entries?
Jul 14 2023
Jul 13 2023
Jul 12 2023
@craig.topper's feedback
llvm/test/CodeGen/RISCV/rvv/setcc-integer.ll
More precise carveout.
Add a carveout for the cases the RISCV tests care about.