- User Since
- Nov 27 2013, 1:02 PM (355 w, 3 d)
There's quite a few dead variables added in this patch. Do they belong in later patches in the series?
small nits, otherwise LGTM
update LGTM too
Thu, Sep 17
btw, do you need me to commit it for you?
Yeah, this should do what you're after. LGTM
Wed, Sep 16
LGTM, with some optional suggestions.
Tue, Sep 15
I know almost nothing about how DebugInfo is represented in llvm/dwarf, but is there not a way to represent what this transformation is doing in DI? It's always a little sad when you have to drop it, since doing so makes the debug experience worse.
Mon, Sep 14
Thu, Sep 10
Wed, Sep 9
The Baremetal toolchain currently has a fixed behavior regardless of the -rtlib option's value. It is always linking against compiler-rt unless -nodefaultlibs is enabled.
This proposal slightly changes the code in such a way that enabling -rtlib=libgcc implies linking against -libgcc.
Something that I'm unsure about this patch is that we are not enforcing the existence of such libgcc. By reading other toolchains, I understood that is not always enforced. Do you think this policy is acceptable? If it is not, how would you think it should be addressed?
Wed, Sep 2
Fri, Aug 28
I was *just* thinking about the inverse of this transformation as a way to increase available ILP on CPUs where there are more pipes that can do arithmetic than compares.... cool!
I'm having trouble getting -stop-before MIR output to trigger these remarks when fed back into llc, so instead I've just relaxed the checks against specific cycle counts to be more forgiving.
Aug 20 2020
Aug 3 2020
Jul 31 2020
Isn't it missing DEPENDS cxxabi the same way this was missing DEPENDS unwind?
Mind doing the same thing for libcxxabi? I think it has the same problem.
LGTM, thank you!
Jul 30 2020
Jul 29 2020
Jul 28 2020
@njames93 I believe this change broke one of the buildbots (verified by reverting it locally). Mind taking a look? From a quick glance, I can't tell where the functional change is here.
Jul 27 2020
Jul 24 2020
@MaskRay I believe this broke one of the buildbots when it landed. Mind taking a look?
Kinda verbose, but it works. This would be so much easier if we had a way to dump mir from llvm-mc.
rm subsumed test