Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

jroelofs (Jon Roelofs)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 27 2013, 1:02 PM (512 w, 5 d)

Recent Activity

Mon, Sep 18

jroelofs added a reverting change for rG003bcad9a8b2: [ARM] Always lower direct calls as direct when the outliner is enabled (#66434): rG83e6d2edfcf9: Revert "[ARM] Always lower direct calls as direct when the outliner is enabled….
Mon, Sep 18, 9:47 AM · Restricted Project, Restricted Project
jroelofs committed rG83e6d2edfcf9: Revert "[ARM] Always lower direct calls as direct when the outliner is enabled… (authored by jroelofs).
Revert "[ARM] Always lower direct calls as direct when the outliner is enabled…
Mon, Sep 18, 9:47 AM · Restricted Project, Restricted Project

Tue, Sep 5

jroelofs added inline comments to D159162: [llvm] Add assembly syntax highlighting.
Tue, Sep 5, 8:34 AM · Restricted Project, Restricted Project

Thu, Aug 31

jroelofs added inline comments to D159162: [llvm] Add assembly syntax highlighting.
Thu, Aug 31, 10:26 AM · Restricted Project, Restricted Project
jroelofs added a comment to D159162: [llvm] Add assembly syntax highlighting.

love it!

Thu, Aug 31, 10:01 AM · Restricted Project, Restricted Project

Aug 23 2023

jroelofs added a comment to D157283: [clang] Match -isysroot behaviour with system compiler on Darwin.

I don't know how, but somehow this change breaks clang-tidy/infrastructure/clang-tidy-mac-libcxx.cpp test.

Aug 23 2023, 1:30 PM · Restricted Project, Restricted Project
jroelofs accepted D157283: [clang] Match -isysroot behaviour with system compiler on Darwin.

LGTM, thank you!

Aug 23 2023, 9:05 AM · Restricted Project, Restricted Project

Aug 21 2023

jroelofs accepted D158473: [AArch64] Check opcode before trying to extract register from operand.

Suggest using llvm/utils/update_llc_test_checks.py to write the CHECKs, so they're easier to update later.

Aug 21 2023, 9:47 PM · Restricted Project, Restricted Project

Aug 15 2023

jroelofs committed rG1e4d6122cda6: [CMake] Add a few more missing dependencies on ClangDriverOptions (authored by jroelofs).
[CMake] Add a few more missing dependencies on ClangDriverOptions
Aug 15 2023, 4:57 PM · Restricted Project, Restricted Project

Aug 14 2023

jroelofs committed rG1a135bceb66b: [MachineOutliner][LTO] Enable outlining of linkonceodr functions on all targets. (authored by jroelofs).
[MachineOutliner][LTO] Enable outlining of linkonceodr functions on all targets.
Aug 14 2023, 4:23 PM · Restricted Project, Restricted Project
jroelofs closed D157925: [MachineOutliner][LTO] Enable outlining of linkonceodr functions on all targets..
Aug 14 2023, 4:23 PM · Restricted Project, Restricted Project
jroelofs requested review of D157925: [MachineOutliner][LTO] Enable outlining of linkonceodr functions on all targets..
Aug 14 2023, 3:10 PM · Restricted Project, Restricted Project
jroelofs added a comment to D150144: cmake: add missing dependency on Attributes.inc.

@jroelofs Sorry for the delay and thanks for the report.

I didn't expect the case of LLVM_TABLEGEN=$BUILD/bin/llvm-tblgen (with path). It would be bad if llvm-min-tblgen is overridden by LLVM_TABLEGEN, that is not an external executable but is built in-tree.

I would like the config not to specify LLVM_TABLEGEN unless it is external. But I could let CMake check whether LLVM_TABLEGEN points actually internal target.

Aug 14 2023, 8:17 AM · Restricted Project, Restricted Project

Aug 11 2023

jroelofs accepted D157763: [llvm][NFC] Adjust AutoUpdater 'masked' address-space access.

LGTM

Aug 11 2023, 3:33 PM · Restricted Project, Restricted Project

Aug 10 2023

jroelofs accepted D157661: [clang][NFC] Robustify testcase.

LGTM

Aug 10 2023, 5:11 PM · Restricted Project, Restricted Project
jroelofs added a reverting change for rGd462f65b8242: Revert "cmake: add missing dependencies on Attributes.inc": rG25e2b4aa1ea4: Revert "Revert "cmake: add missing dependencies on Attributes.inc"".
Aug 10 2023, 2:54 PM · Restricted Project, Restricted Project
jroelofs committed rG25e2b4aa1ea4: Revert "Revert "cmake: add missing dependencies on Attributes.inc"" (authored by jroelofs).
Revert "Revert "cmake: add missing dependencies on Attributes.inc""
Aug 10 2023, 2:54 PM · Restricted Project, Restricted Project
jroelofs updated subscribers of D150144: cmake: add missing dependency on Attributes.inc.

Re-applying (shortly), because the revert broke the modules build again, which seems to have more short term positive impact than fixing the circular dependency:

Aug 10 2023, 2:52 PM · Restricted Project, Restricted Project
jroelofs added inline comments to D141917: WIP: Unwindabort: Implement CodeGen for DWARF-style exception handling..
Aug 10 2023, 1:52 PM · Restricted Project, Restricted Project

Aug 9 2023

jroelofs committed rG6affdbad938d: Remove a reference to rdar://5972456 (authored by jroelofs).
Remove a reference to rdar://5972456
Aug 9 2023, 6:12 PM · Restricted Project, Restricted Project
jroelofs committed rGf9ebcb4814d0: Remove a reference to rdar://problem/8030636 (authored by jroelofs).
Remove a reference to rdar://problem/8030636
Aug 9 2023, 5:28 PM · Restricted Project, Restricted Project
jroelofs committed rG250812abe733: Remove a reference to rdar://problem/16473581 (authored by jroelofs).
Remove a reference to rdar://problem/16473581
Aug 9 2023, 4:09 PM · Restricted Project, Restricted Project
jroelofs committed rG9d6db32640d7: Remove a reference to rdar://4653682 from X86/README.txt (authored by jroelofs).
Remove a reference to rdar://4653682 from X86/README.txt
Aug 9 2023, 3:25 PM · Restricted Project, Restricted Project
jroelofs committed rGbdd17b853fac: Remove a reference to rdar://problem/10664933 (authored by jroelofs).
Remove a reference to rdar://problem/10664933
Aug 9 2023, 3:13 PM · Restricted Project, Restricted Project
jroelofs committed rG8475d0a2b853: fixup! Remove a reference to rdar://8007500 (authored by jroelofs).
fixup! Remove a reference to rdar://8007500
Aug 9 2023, 3:04 PM · Restricted Project, Restricted Project
jroelofs committed rG9eb08e7619cc: Remove a reference to rdar://8007500 (authored by jroelofs).
Remove a reference to rdar://8007500
Aug 9 2023, 11:27 AM · Restricted Project, Restricted Project
jroelofs committed rGfceabd0de65f: Remove a reference to rdar://11522048 (authored by jroelofs).
Remove a reference to rdar://11522048
Aug 9 2023, 11:27 AM · Restricted Project, Restricted Project
jroelofs added a comment to D150144: cmake: add missing dependency on Attributes.inc.

Reverted, as this turned out to cause a cyclic dependency (as @bulbazord suspected). If the Modules bots run into this again, I'm not sure how to fix it...

Aug 9 2023, 10:51 AM · Restricted Project, Restricted Project
jroelofs added a reverting change for rG30b4351c7c75: cmake: add missing dependencies on Attributes.inc: rGd462f65b8242: Revert "cmake: add missing dependencies on Attributes.inc".
Aug 9 2023, 10:47 AM · Restricted Project, Restricted Project
jroelofs committed rGd462f65b8242: Revert "cmake: add missing dependencies on Attributes.inc" (authored by jroelofs).
Revert "cmake: add missing dependencies on Attributes.inc"
Aug 9 2023, 10:47 AM · Restricted Project, Restricted Project
jroelofs added a reverting change for D150144: cmake: add missing dependency on Attributes.inc: rGd462f65b8242: Revert "cmake: add missing dependencies on Attributes.inc".
Aug 9 2023, 10:47 AM · Restricted Project, Restricted Project

Aug 8 2023

jroelofs added a comment to D157119: cmake: add missing dependencies on ClangDriverOptions tablegen.

Flaky test? Here's a later build where it succeeds, but the change has nothing to do with clangd: https://lab.llvm.org/buildbot/#/builders/168/builds/14997

Aug 8 2023, 8:23 AM · Restricted Project, Restricted Project, Restricted Project

Aug 7 2023

jroelofs added a comment to D157119: cmake: add missing dependencies on ClangDriverOptions tablegen.

I suspect one of your recent changes broke https://lab.llvm.org/buildbot/#/builders/168/builds/14944
Can you please take a look?

Aug 7 2023, 8:19 AM · Restricted Project, Restricted Project, Restricted Project

Aug 4 2023

jroelofs added a comment to D157119: cmake: add missing dependencies on ClangDriverOptions tablegen.

missed one more: 3d756c32cdf005d0f4c05f561fec4a37b64b7ddd

Aug 4 2023, 10:48 AM · Restricted Project, Restricted Project, Restricted Project
jroelofs committed rG3d756c32cdf0: cmake: add missing dependencies on ClangDriverOptions tablegen (authored by jroelofs).
cmake: add missing dependencies on ClangDriverOptions tablegen
Aug 4 2023, 10:44 AM · Restricted Project, Restricted Project
jroelofs added a comment to D157119: cmake: add missing dependencies on ClangDriverOptions tablegen.

back-porting to the release branch: https://github.com/llvm/llvm-project/issues/64432

Aug 4 2023, 10:39 AM · Restricted Project, Restricted Project, Restricted Project
jroelofs committed rG2fb1c1082c01: cmake: add missing dependencies on ClangDriverOptions tablegen (authored by jroelofs).
cmake: add missing dependencies on ClangDriverOptions tablegen
Aug 4 2023, 10:28 AM · Restricted Project, Restricted Project, Restricted Project
jroelofs closed D157119: cmake: add missing dependencies on ClangDriverOptions tablegen.
Aug 4 2023, 10:28 AM · Restricted Project, Restricted Project, Restricted Project
jroelofs added a comment to D157119: cmake: add missing dependencies on ClangDriverOptions tablegen.

related discussion: https://discourse.llvm.org/t/rfc-permanently-fixing-the-missing-tablegen-dependency-issue/70442/14

Aug 4 2023, 10:07 AM · Restricted Project, Restricted Project, Restricted Project
jroelofs requested review of D157119: cmake: add missing dependencies on ClangDriverOptions tablegen.
Aug 4 2023, 10:05 AM · Restricted Project, Restricted Project, Restricted Project

Aug 3 2023

jroelofs accepted D156832: [GlobalISel] Handle sequences of trunc(sext/zext/anyext...) in artifact combiner.

LGTM

Aug 3 2023, 4:23 PM · Restricted Project, Restricted Project
jroelofs updated subscribers of D74094: Reapply: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas.

Hi @erik.pilkington, I see this got reverted:

I'm not sure if @erik.pilkington is still watching Phabricator, but in any case I think (like me) he no longer has rdar access. Since this was a Linux PPC bot, it's possible Erik didn't get far investigating the failure. Three years later, the sands may have shifted substantially... maybe the best option to is rebase and investigate the new failures (if any).

@akyrtzi @arphaman @jroelofs, is one of you available to check rdar://58552124, in case it has extra context from the PPC bot failure?

Aug 3 2023, 4:01 PM · Restricted Project, Restricted Project
jroelofs accepted D156991: [llvm][NFC] Use CreateMemTransferInst more.

LGTM

Aug 3 2023, 9:26 AM · Restricted Project, Restricted Project

Aug 2 2023

jroelofs accepted D156575: [llvm[NFC] Adjust mem fn auto upgrade detection.
Aug 2 2023, 2:01 PM · Restricted Project, Restricted Project

Aug 1 2023

jroelofs committed rGed83797f3cbf: [Intrinsics][ObjC] Mark objc_retain and friends as thisreturn. (authored by jroelofs).
[Intrinsics][ObjC] Mark objc_retain and friends as thisreturn.
Aug 1 2023, 6:02 PM · Restricted Project, Restricted Project, Restricted Project
jroelofs closed D105671: [Intrinsics][ObjC] Mark objc_retain and friends as thisreturn..
Aug 1 2023, 6:02 PM · Restricted Project, Restricted Project, Restricted Project
jroelofs added inline comments to D156832: [GlobalISel] Handle sequences of trunc(sext/zext/anyext...) in artifact combiner.
Aug 1 2023, 3:49 PM · Restricted Project, Restricted Project
jroelofs abandoned D156735: Do not let Value::stripPointerCasts() look through returned arg functions..

Found a simpler way to work around the issue that motivated this in D105671.

Aug 1 2023, 2:15 PM · Restricted Project, Restricted Project
jroelofs updated the diff for D105671: [Intrinsics][ObjC] Mark objc_retain and friends as thisreturn..

Rebase. Avoid the dependency on D156735

Aug 1 2023, 2:13 PM · Restricted Project, Restricted Project, Restricted Project

Jul 31 2023

jroelofs updated the diff for D156735: Do not let Value::stripPointerCasts() look through returned arg functions..
Jul 31 2023, 1:34 PM · Restricted Project, Restricted Project
jroelofs updated the diff for D105671: [Intrinsics][ObjC] Mark objc_retain and friends as thisreturn..
Jul 31 2023, 1:34 PM · Restricted Project, Restricted Project, Restricted Project
jroelofs added a comment to D105671: [Intrinsics][ObjC] Mark objc_retain and friends as thisreturn..

oops, uploaded the wrong patch to this review.

Jul 31 2023, 1:33 PM · Restricted Project, Restricted Project, Restricted Project
jroelofs updated the diff for D105671: [Intrinsics][ObjC] Mark objc_retain and friends as thisreturn..

Move the stripPointerCasts() change into its own review: https://reviews.llvm.org/D156735

Jul 31 2023, 1:31 PM · Restricted Project, Restricted Project, Restricted Project
jroelofs added a comment to D105671: [Intrinsics][ObjC] Mark objc_retain and friends as thisreturn..

Please separate the change to stripPointerCasts() into a separate review.

Jul 31 2023, 1:29 PM · Restricted Project, Restricted Project, Restricted Project
jroelofs added a reviewer for D156735: Do not let Value::stripPointerCasts() look through returned arg functions.: nikic.
Jul 31 2023, 1:29 PM · Restricted Project, Restricted Project
jroelofs updated the summary of D156735: Do not let Value::stripPointerCasts() look through returned arg functions..
Jul 31 2023, 1:29 PM · Restricted Project, Restricted Project
jroelofs requested review of D156735: Do not let Value::stripPointerCasts() look through returned arg functions..
Jul 31 2023, 1:26 PM · Restricted Project, Restricted Project
jroelofs updated the diff for D105671: [Intrinsics][ObjC] Mark objc_retain and friends as thisreturn..
Jul 31 2023, 11:48 AM · Restricted Project, Restricted Project, Restricted Project
jroelofs added inline comments to D156710: [TargetParser] Generate RISCVTargetParserDef only if RISCV is enabled..
Jul 31 2023, 9:58 AM · Restricted Project, Restricted Project

Jul 29 2023

jroelofs closed D125472: Fix an or+and miscompile w/ GlobalISel.

d699e54ca291a7e58d997760481f246db32b506a

Jul 29 2023, 11:12 AM · Restricted Project, Restricted Project
jroelofs closed D155095: TargetLowering: fix an infinite DAG combine in SimplifySETCC.
Jul 29 2023, 11:10 AM · Restricted Project, Restricted Project

Jul 28 2023

jroelofs accepted D156575: [llvm[NFC] Adjust mem fn auto upgrade detection.

LGTM

Jul 28 2023, 3:20 PM · Restricted Project, Restricted Project
jroelofs added inline comments to D141916: WIP: Unwindabort: add support for IR transforms and analysis..
Jul 28 2023, 12:07 PM · Restricted Project, Restricted Project
jroelofs added inline comments to D141918: WIP: [Clang] Emit 'unwindabort' when applicable..
Jul 28 2023, 10:45 AM · Restricted Project, Restricted Project
jroelofs committed rG2b418c3c00ec: [BitcodeReader] Add missing () to disambiguate precedence. NFC (authored by jroelofs).
[BitcodeReader] Add missing () to disambiguate precedence. NFC
Jul 28 2023, 10:08 AM · Restricted Project, Restricted Project
jroelofs added inline comments to D141913: WIP: Unwindabort: Add "unwindabort" syntax for the "call" instruction..
Jul 28 2023, 10:00 AM · Restricted Project, Restricted Project

Jul 27 2023

jroelofs committed rG3e0cdf332fc3: Upgrade a rdar://5907648 link to a github issue (authored by jroelofs).
Upgrade a rdar://5907648 link to a github issue
Jul 27 2023, 1:38 PM · Restricted Project, Restricted Project
jroelofs committed rG80fae88a64b2: Upgrade a rdar://8459039 link to a github issue (authored by jroelofs).
Upgrade a rdar://8459039 link to a github issue
Jul 27 2023, 1:38 PM · Restricted Project, Restricted Project

Jul 26 2023

jroelofs added inline comments to D141918: WIP: [Clang] Emit 'unwindabort' when applicable..
Jul 26 2023, 6:20 PM · Restricted Project, Restricted Project
jroelofs added inline comments to D141917: WIP: Unwindabort: Implement CodeGen for DWARF-style exception handling..
Jul 26 2023, 6:11 PM · Restricted Project, Restricted Project
jroelofs added inline comments to D141913: WIP: Unwindabort: Add "unwindabort" syntax for the "call" instruction..
Jul 26 2023, 5:23 PM · Restricted Project, Restricted Project
jroelofs added inline comments to D141916: WIP: Unwindabort: add support for IR transforms and analysis..
Jul 26 2023, 5:19 PM · Restricted Project, Restricted Project
jroelofs added inline comments to D141914: WIP: Unwindabort: Add "unwindabort" syntax for the "resume" instruction..
Jul 26 2023, 5:03 PM · Restricted Project, Restricted Project
jroelofs added a comment to D141913: WIP: Unwindabort: Add "unwindabort" syntax for the "call" instruction..

I think this deserves an entry in llvm/utils/vim/syntax/llvm.vim under keywords.

Jul 26 2023, 4:29 PM · Restricted Project, Restricted Project
jroelofs added inline comments to D141913: WIP: Unwindabort: Add "unwindabort" syntax for the "call" instruction..
Jul 26 2023, 4:22 PM · Restricted Project, Restricted Project

Jul 21 2023

jroelofs committed rG62a1fbe9f7f9: Enable compact unwind in all darwin simulators (authored by jroelofs).
Enable compact unwind in all darwin simulators
Jul 21 2023, 4:14 PM · Restricted Project, Restricted Project
jroelofs closed D155988: Enable compact unwind in all darwin simulators.
Jul 21 2023, 4:14 PM · Restricted Project, Restricted Project
jroelofs requested review of D155988: Enable compact unwind in all darwin simulators.
Jul 21 2023, 12:55 PM · Restricted Project, Restricted Project

Jul 18 2023

jroelofs added a comment to D155509: Revert "Remove rdar links; NFC".

Do you think this and the other patch are good candidates for .git-blame-ignore-revs entries?

Jul 18 2023, 10:25 AM · Restricted Project, Restricted Project

Jul 14 2023

jroelofs committed rG0dcc78a1a6d8: ORC: drop a FIXME that was addressed in dc078e6eaacf. NFC (authored by jroelofs).
ORC: drop a FIXME that was addressed in dc078e6eaacf. NFC
Jul 14 2023, 1:49 PM · Restricted Project, Restricted Project
jroelofs committed rGdc078e6eaacf: TargetParser: fix getProcessTriple in universal builds (authored by jroelofs).
TargetParser: fix getProcessTriple in universal builds
Jul 14 2023, 1:45 PM · Restricted Project, Restricted Project
jroelofs closed D138449: support: fix getProcessTriple in universal builds.
Jul 14 2023, 1:45 PM · Restricted Project, Restricted Project

Jul 13 2023

jroelofs committed rGa01d1831bc90: [DebugInfo] Add missing dependency on intrinsics_gen (authored by jroelofs).
[DebugInfo] Add missing dependency on intrinsics_gen
Jul 13 2023, 5:12 PM · Restricted Project, Restricted Project
jroelofs updated the summary of D155245: AArch64: don't crash when .cfi_startproc/.cfi_endproc are improperly nested.
Jul 13 2023, 4:03 PM · Restricted Project, Restricted Project
jroelofs requested review of D155245: AArch64: don't crash when .cfi_startproc/.cfi_endproc are improperly nested.
Jul 13 2023, 4:03 PM · Restricted Project, Restricted Project

Jul 12 2023

jroelofs added a reverting change for rGcdc633e4bc93: Revert "TargetLowering: fix an infinite DAG combine in SimplifySETCC": rG56e60bc5bbfb: TargetLowering: fix an infinite DAG combine in SimplifySETCC.
Jul 12 2023, 4:14 PM · Restricted Project, Restricted Project
jroelofs committed rG56e60bc5bbfb: TargetLowering: fix an infinite DAG combine in SimplifySETCC (authored by jroelofs).
TargetLowering: fix an infinite DAG combine in SimplifySETCC
Jul 12 2023, 4:14 PM · Restricted Project, Restricted Project
jroelofs updated the diff for D155095: TargetLowering: fix an infinite DAG combine in SimplifySETCC.

@craig.topper's feedback

Jul 12 2023, 4:05 PM · Restricted Project, Restricted Project
jroelofs added inline comments to D155095: TargetLowering: fix an infinite DAG combine in SimplifySETCC.
Jul 12 2023, 4:00 PM · Restricted Project, Restricted Project
jroelofs added inline comments to D155095: TargetLowering: fix an infinite DAG combine in SimplifySETCC.
Jul 12 2023, 3:38 PM · Restricted Project, Restricted Project
jroelofs added a comment to D155095: TargetLowering: fix an infinite DAG combine in SimplifySETCC.

llvm/test/CodeGen/RISCV/rvv/setcc-integer.ll

Jul 12 2023, 2:52 PM · Restricted Project, Restricted Project
jroelofs updated the diff for D155095: TargetLowering: fix an infinite DAG combine in SimplifySETCC.

More precise carveout.

Jul 12 2023, 2:29 PM · Restricted Project, Restricted Project
jroelofs updated the diff for D155095: TargetLowering: fix an infinite DAG combine in SimplifySETCC.

Add a carveout for the cases the RISCV tests care about.

Jul 12 2023, 2:16 PM · Restricted Project, Restricted Project
jroelofs added a reverting change for D155095: TargetLowering: fix an infinite DAG combine in SimplifySETCC: rGcdc633e4bc93: Revert "TargetLowering: fix an infinite DAG combine in SimplifySETCC".
Jul 12 2023, 12:23 PM · Restricted Project, Restricted Project
jroelofs added a reverting change for rGb76c85b35557: TargetLowering: fix an infinite DAG combine in SimplifySETCC: rGcdc633e4bc93: Revert "TargetLowering: fix an infinite DAG combine in SimplifySETCC".
Jul 12 2023, 12:23 PM · Restricted Project, Restricted Project
jroelofs committed rGcdc633e4bc93: Revert "TargetLowering: fix an infinite DAG combine in SimplifySETCC" (authored by jroelofs).
Revert "TargetLowering: fix an infinite DAG combine in SimplifySETCC"
Jul 12 2023, 12:22 PM · Restricted Project, Restricted Project
jroelofs committed rGb76c85b35557: TargetLowering: fix an infinite DAG combine in SimplifySETCC (authored by jroelofs).
TargetLowering: fix an infinite DAG combine in SimplifySETCC
Jul 12 2023, 11:48 AM · Restricted Project, Restricted Project
jroelofs closed D155095: TargetLowering: fix an infinite DAG combine in SimplifySETCC.
Jul 12 2023, 11:47 AM · Restricted Project, Restricted Project
jroelofs updated the diff for D155095: TargetLowering: fix an infinite DAG combine in SimplifySETCC.
Jul 12 2023, 11:24 AM · Restricted Project, Restricted Project
jroelofs added inline comments to D155095: TargetLowering: fix an infinite DAG combine in SimplifySETCC.
Jul 12 2023, 11:15 AM · Restricted Project, Restricted Project