User Details
- User Since
- Nov 27 2013, 1:02 PM (448 w, 11 h)
Mon, Jun 27
LGTM
May 19 2022
May 18 2022
May 12 2022
May 9 2022
@fhahn suggested this might be an issue with how caches/util/xcode_sdk.cmake configures try_compile, and sure enough:
May 3 2022
Apr 22 2022
As a workaround, what if we wrapped the check in an if(NOT APPLE)?
Apr 6 2022
sounds good to me, thank you!
Seems I don't have permissions on the repo to commit this.
This showed up in one of our buildbots:
Apr 2 2022
Mar 30 2022
LGTM
Feb 8 2022
Feb 4 2022
Jan 3 2022
Looks like rebasing dropped the addition of clear(). LGTM with that and a linter-appeasing clang-format.
Dec 10 2021
Elegant solution, I like it!
Dec 8 2021
LGTM
LGTM
Nov 5 2021
LGTM, but of course, please get a Group Reviewer's approval too.
Nov 3 2021
LGTM
LGTM
Nov 2 2021
Looks ok to me, that said I'm not one of this project's group reviewers, so you'll need someone else's approval.
Oct 20 2021
ping
Oct 18 2021
can you please upload the patch with more context?
Oct 15 2021
Modify the G_AND in-place, and ignore vector types.
Oct 14 2021
Oct 5 2021
Oct 1 2021
LGTM
Sep 16 2021
LGTM
Sep 14 2021
Sep 3 2021
LGTM
Sep 1 2021
Aug 30 2021
Also, turns out that stripPointerCasts() can see through the thisreturn attribute, which defeats a self retain optimization, breaking one of the clang tests. I tweaked a callback to make it configurable. Let me know if you see a better way of dealing with that.
Aug 24 2021
Aug 23 2021
Aug 20 2021
LGTM
LGTM
Aug 19 2021
LGTM
LGTM
Thank you!
After some bisection, it appears this change broke llvm/test/Transforms/GuardWidening/loop-schedule.ll. The NewPM half of that test fails with:
Aug 17 2021
LGTM
LGTM
Aug 13 2021
Thanks! I think the first and last line of the diff are now redundant. Otherwise LGTM.
Aug 6 2021
Aug 5 2021
Also seems to have broken on PPC: