Page MenuHomePhabricator

jroelofs (Jon Roelofs)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 27 2013, 1:02 PM (355 w, 3 d)

Recent Activity

Yesterday

jroelofs accepted D86978: [IROutliner] Deduplicating functions that only require inputs..

๐Ÿ‘

Fri, Sep 18, 10:44 PM ยท Restricted Project
jroelofs added inline comments to D86977: [IRSim][IROutliner] Limit to extracting regions that only require inputs.
Fri, Sep 18, 3:48 PM ยท Restricted Project
jroelofs accepted D87742: [IROutliner] Adding support for swift errors.
Fri, Sep 18, 12:09 PM ยท Restricted Project
jroelofs added inline comments to D86973: [IRSim] Adding wrapper pass for IRSimilarityIdentfier.
Fri, Sep 18, 12:01 PM ยท Restricted Project
jroelofs added a comment to D86978: [IROutliner] Deduplicating functions that only require inputs..

There's quite a few dead variables added in this patch. Do they belong in later patches in the series?

Fri, Sep 18, 11:56 AM ยท Restricted Project
jroelofs added inline comments to D86977: [IRSim][IROutliner] Limit to extracting regions that only require inputs.
Fri, Sep 18, 10:23 AM ยท Restricted Project
jroelofs added inline comments to D86977: [IRSim][IROutliner] Limit to extracting regions that only require inputs.
Fri, Sep 18, 9:47 AM ยท Restricted Project
jroelofs accepted D86976: [IRSim][IROutliner] Adding InstVisitor to disallow certain operations..

LGTM

Fri, Sep 18, 9:33 AM ยท Restricted Project
jroelofs accepted D87298: [IRSim][IROutliner] Merging output blocks for extracted functions with outputs.

LGTM

Fri, Sep 18, 9:29 AM ยท Restricted Project
jroelofs accepted D87296: [IRSim][IROutliner] Adding support for consolidating functions with different output arguments..

LGTM

Fri, Sep 18, 9:22 AM ยท Restricted Project
jroelofs committed rG51c5add8547a: Extending Baremetal toolchain's support for the rtlib option. (authored by jroelofs).
Extending Baremetal toolchain's support for the rtlib option.
Fri, Sep 18, 9:20 AM
jroelofs closed D87164: Extending Baremetal toolchain's support for the rtlib option..
Fri, Sep 18, 9:19 AM ยท Restricted Project, Restricted Project
jroelofs accepted D86972: [IRSim] Adding a basic similarity identifier..

small nits, otherwise LGTM

Fri, Sep 18, 9:17 AM ยท Restricted Project
jroelofs added a comment to D86971: [IRSim] Adding structural comparison to IRSimilarityCandidate..

update LGTM too

Fri, Sep 18, 9:05 AM ยท Restricted Project

Thu, Sep 17

jroelofs added inline comments to D86973: [IRSim] Adding wrapper pass for IRSimilarityIdentfier.
Thu, Sep 17, 1:48 PM ยท Restricted Project
jroelofs added a comment to D87164: Extending Baremetal toolchain's support for the rtlib option..

btw, do you need me to commit it for you?

Thu, Sep 17, 12:57 PM ยท Restricted Project, Restricted Project
jroelofs committed rGc145a1ca2593: AArch64::ArchKind's underlying type is uint64_t (authored by jroelofs).
AArch64::ArchKind's underlying type is uint64_t
Thu, Sep 17, 12:14 PM
jroelofs added inline comments to D86972: [IRSim] Adding a basic similarity identifier..
Thu, Sep 17, 11:51 AM ยท Restricted Project
jroelofs accepted D87164: Extending Baremetal toolchain's support for the rtlib option..

Yeah, this should do what you're after. LGTM

Thu, Sep 17, 8:44 AM ยท Restricted Project, Restricted Project

Wed, Sep 16

jroelofs accepted D87294: [IRSim][IROutliner] Adding support for elevating constants that are not the same in each region to arguments.

LGTM

Wed, Sep 16, 8:46 AM ยท Restricted Project
jroelofs accepted D86971: [IRSim] Adding structural comparison to IRSimilarityCandidate..

LGTM, with some optional suggestions.

Wed, Sep 16, 8:37 AM ยท Restricted Project
jroelofs accepted D86970: [IRSim] Adding IRSimilarityCandidate that contains a region of IRInstructionData.

LGTM

Wed, Sep 16, 8:19 AM ยท Restricted Project
jroelofs accepted D87309: [IRSim][IROutliner] Adding option to enable outlining from linkonceodr functions.

LGTM

Wed, Sep 16, 8:12 AM ยท Restricted Project

Tue, Sep 15

jroelofs added inline comments to D87294: [IRSim][IROutliner] Adding support for elevating constants that are not the same in each region to arguments.
Tue, Sep 15, 4:30 PM ยท Restricted Project
jroelofs added inline comments to D86975: [IRSim][IROutliner] Adding the extraction basics for the IROutliner..
Tue, Sep 15, 4:12 PM ยท Restricted Project
jroelofs added inline comments to D86968: [IRSim] Adding IR Instruction Mapper.
Tue, Sep 15, 2:52 PM ยท Restricted Project
jroelofs added a comment to D87302: [IRSim][IROutliner] Adding DebugInfo handling for IR outlined functions..

I know almost nothing about how DebugInfo is represented in llvm/dwarf, but is there not a way to represent what this transformation is doing in DI? It's always a little sad when you have to drop it, since doing so makes the debug experience worse.

Tue, Sep 15, 12:33 PM ยท debug-info, Restricted Project
jroelofs added inline comments to D87309: [IRSim][IROutliner] Adding option to enable outlining from linkonceodr functions.
Tue, Sep 15, 12:19 PM ยท Restricted Project
jroelofs added inline comments to D87298: [IRSim][IROutliner] Merging output blocks for extracted functions with outputs.
Tue, Sep 15, 12:13 PM ยท Restricted Project
jroelofs accepted D87317: [IRSim][IROutliner] Allowing GEP instructions to be outlined..

LGTM

Tue, Sep 15, 10:47 AM ยท Restricted Project
jroelofs added inline comments to D87296: [IRSim][IROutliner] Adding support for consolidating functions with different output arguments..
Tue, Sep 15, 10:44 AM ยท Restricted Project
jroelofs added inline comments to D87294: [IRSim][IROutliner] Adding support for elevating constants that are not the same in each region to arguments.
Tue, Sep 15, 10:24 AM ยท Restricted Project
jroelofs accepted D87314: [IRSim][IROutliner] Allowing call instructions to be outlined..

LGTM

Tue, Sep 15, 10:15 AM ยท Restricted Project
jroelofs accepted D87312: [IRSim] Letting call instructions be legal for similarity identification..

LGTM

Tue, Sep 15, 10:13 AM ยท Restricted Project
jroelofs added inline comments to D86975: [IRSim][IROutliner] Adding the extraction basics for the IROutliner..
Tue, Sep 15, 10:02 AM ยท Restricted Project
jroelofs accepted D86973: [IRSim] Adding wrapper pass for IRSimilarityIdentfier.

LGTM

Tue, Sep 15, 9:45 AM ยท Restricted Project
jroelofs added inline comments to D86972: [IRSim] Adding a basic similarity identifier..
Tue, Sep 15, 9:41 AM ยท Restricted Project
jroelofs added inline comments to D86971: [IRSim] Adding structural comparison to IRSimilarityCandidate..
Tue, Sep 15, 9:34 AM ยท Restricted Project
jroelofs added inline comments to D86970: [IRSim] Adding IRSimilarityCandidate that contains a region of IRInstructionData.
Tue, Sep 15, 9:21 AM ยท Restricted Project
jroelofs accepted D86969: [IRSim] Adding ilist for IRInstructionData.

LGTM

Tue, Sep 15, 9:11 AM ยท Restricted Project
jroelofs added inline comments to D86968: [IRSim] Adding IR Instruction Mapper.
Tue, Sep 15, 9:08 AM ยท Restricted Project
jroelofs accepted D86974: [IRSim] Adding basic implementation of llvm-sim..

LGTM

Tue, Sep 15, 8:35 AM ยท Restricted Project

Mon, Sep 14

jroelofs accepted D87315: [IRSim] Letting gep instructions be legal for similarity identification..

LGTM

Mon, Sep 14, 5:21 PM ยท Restricted Project
jroelofs added inline comments to D87312: [IRSim] Letting call instructions be legal for similarity identification..
Mon, Sep 14, 5:15 PM ยท Restricted Project
jroelofs added inline comments to D87314: [IRSim][IROutliner] Allowing call instructions to be outlined..
Mon, Sep 14, 5:06 PM ยท Restricted Project
jroelofs added inline comments to D86974: [IRSim] Adding basic implementation of llvm-sim..
Mon, Sep 14, 4:47 PM ยท Restricted Project
jroelofs added inline comments to D87296: [IRSim][IROutliner] Adding support for consolidating functions with different output arguments..
Mon, Sep 14, 4:09 PM ยท Restricted Project
jroelofs added a comment to D87164: Extending Baremetal toolchain's support for the rtlib option..

@jroelofs no worries, thanks a lot for your time.

Please tell me if I understood you correctly.

It is acceptable just to append the -lgcc if -rtlib=libgcc is used, although the user is responsible to ensure that correct paths are provided so libgcc is found.

Mon, Sep 14, 1:45 PM ยท Restricted Project, Restricted Project
jroelofs accepted D87300: [IRSim][IROutliner] Adding OptRemarks for the IROutliner..

LGTM

Mon, Sep 14, 1:29 PM ยท Restricted Project
jroelofs accepted D87310: [IRSim] Adding support for isomorphic predicates.

LGTM

Mon, Sep 14, 1:26 PM ยท Restricted Project
jroelofs accepted D87311: [IRSim] Adding commutativity matching to structure checking.

LGTM

Mon, Sep 14, 12:54 PM ยท Restricted Project
jroelofs accepted D87299: [IRSim][IROutliner] Adding a cost model, and debug option to turn the model off..

LGTM

Mon, Sep 14, 12:51 PM ยท Restricted Project

Thu, Sep 10

jroelofs added inline comments to D87299: [IRSim][IROutliner] Adding a cost model, and debug option to turn the model off..
Thu, Sep 10, 2:55 PM ยท Restricted Project
jroelofs added inline comments to D87298: [IRSim][IROutliner] Merging output blocks for extracted functions with outputs.
Thu, Sep 10, 2:48 PM ยท Restricted Project
jroelofs added inline comments to D87311: [IRSim] Adding commutativity matching to structure checking.
Thu, Sep 10, 2:40 PM ยท Restricted Project
jroelofs added inline comments to D87310: [IRSim] Adding support for isomorphic predicates.
Thu, Sep 10, 2:34 PM ยท Restricted Project
jroelofs added inline comments to D87310: [IRSim] Adding support for isomorphic predicates.
Thu, Sep 10, 2:31 PM ยท Restricted Project
jroelofs added inline comments to D87300: [IRSim][IROutliner] Adding OptRemarks for the IROutliner..
Thu, Sep 10, 2:19 PM ยท Restricted Project

Wed, Sep 9

jroelofs added a comment to D87164: Extending Baremetal toolchain's support for the rtlib option..

The Baremetal toolchain currently has a fixed behavior regardless of the -rtlib option's value. It is always linking against compiler-rt unless -nodefaultlibs is enabled.

This proposal slightly changes the code in such a way that enabling -rtlib=libgcc implies linking against -libgcc.

Something that I'm unsure about this patch is that we are not enforcing the existence of such libgcc. By reading other toolchains, I understood that is not always enforced. Do you think this policy is acceptable? If it is not, how would you think it should be addressed?

Wed, Sep 9, 12:47 PM ยท Restricted Project, Restricted Project

Wed, Sep 2

jroelofs closed D86797: [early-ifcvt] Add OptRemarks.

b15f2bd3ad4ab614e75ff859b03c3c1eb9f1a9d3

Wed, Sep 2, 8:47 AM ยท Restricted Project

Fri, Aug 28

jroelofs committed rGb15f2bd3ad4a: [early-ifcvt] Add OptRemarks (authored by jroelofs).
[early-ifcvt] Add OptRemarks
Fri, Aug 28, 2:56 PM
jroelofs added a comment to D63060: [InstCombine] usub.sat(a, b) + b => umax(a, b) (PR42178).

I was *just* thinking about the inverse of this transformation as a way to increase available ILP on CPUs where there are more pipes that can do arithmetic than compares.... cool!

Fri, Aug 28, 2:49 PM ยท Restricted Project
jroelofs updated the diff for D86797: [early-ifcvt] Add OptRemarks.

I'm having trouble getting -stop-before MIR output to trigger these remarks when fed back into llc, so instead I've just relaxed the checks against specific cycle counts to be more forgiving.

Fri, Aug 28, 2:27 PM ยท Restricted Project
jroelofs added a comment to D86797: [early-ifcvt] Add OptRemarks.

This looks great, thanks! Since it's a CodeGen pass, I would suggest using a MIR test instead of an IR one, but I think it's probably easier to read it as it is right now.

Fri, Aug 28, 1:34 PM ยท Restricted Project
jroelofs requested review of D86797: [early-ifcvt] Add OptRemarks.
Fri, Aug 28, 10:26 AM ยท Restricted Project

Aug 20 2020

jroelofs committed rG74ca5275e950: Fix a couple of typos. NFC (authored by jroelofs).
Fix a couple of typos. NFC
Aug 20 2020, 1:57 PM

Aug 3 2020

jroelofs committed rG7f1556f292cc: Fix typo: s/epomymous/eponymous/ NFC (authored by jroelofs).
Fix typo: s/epomymous/eponymous/ NFC
Aug 3 2020, 1:10 PM
jroelofs added a comment to D85004: [libunwind] Make the test depend on the libunwind explicitly..
Aug 3 2020, 8:48 AM ยท Restricted Project, Restricted Project

Jul 31 2020

jroelofs added a comment to D85004: [libunwind] Make the test depend on the libunwind explicitly..

Isn't it missing DEPENDS cxxabi the same way this was missing DEPENDS unwind?

Jul 31 2020, 11:26 AM ยท Restricted Project, Restricted Project
jroelofs added a comment to D85004: [libunwind] Make the test depend on the libunwind explicitly..

Mind doing the same thing for libcxxabi? I think it has the same problem.

Jul 31 2020, 9:02 AM ยท Restricted Project, Restricted Project
jroelofs accepted D85004: [libunwind] Make the test depend on the libunwind explicitly..

LGTM, thank you!

Jul 31 2020, 9:02 AM ยท Restricted Project, Restricted Project

Jul 30 2020

jroelofs committed rGafae6d97fa55: [SelectionDAG] Fix lowering of vector geps (authored by jroelofs).
[SelectionDAG] Fix lowering of vector geps
Jul 30 2020, 1:57 PM
jroelofs closed D84884: [SelectionDAG] Fix lowering of vector geps.
Jul 30 2020, 1:57 PM ยท Restricted Project

Jul 29 2020

jroelofs abandoned D23838: Unsuccessful stab at fuzzing for the bug in D23362.
Jul 29 2020, 2:00 PM
jroelofs abandoned D32178: Delete unstable integration tests.
Jul 29 2020, 1:59 PM
jroelofs abandoned D32866: Fix -DLLVM_BUILD_TESTS=ON lldb build.
Jul 29 2020, 1:58 PM
jroelofs abandoned D39146: WIP: fix ldscript AT> parsing.
Jul 29 2020, 1:58 PM
jroelofs requested review of D84884: [SelectionDAG] Fix lowering of vector geps.
Jul 29 2020, 12:18 PM ยท Restricted Project

Jul 28 2020

jroelofs added inline comments to D73151: [analyzer] Fix handle leak false positive when the handle dies too early.
Jul 28 2020, 4:30 PM ยท Restricted Project
jroelofs updated subscribers of D73151: [analyzer] Fix handle leak false positive when the handle dies too early.
Jul 28 2020, 4:28 PM ยท Restricted Project
jroelofs added a comment to rG7bae3188e087: [clang-tidy][NFC] Make OptionsView methods as const where missing.

@njames93 I believe this change broke one of the buildbots (verified by reverting it locally). Mind taking a look? From a quick glance, I can't tell where the functional change is here.

Jul 28 2020, 1:00 PM
jroelofs closed D84686: [OldPM] Print out a bit more when passes lie about changing IR.

736423af53d707e097a174c3a91b75132b8dc6b1

Jul 28 2020, 10:29 AM ยท Restricted Project
jroelofs committed rG736423af53d7: [OldPM] Print out a bit more when passes lie about changing IR (authored by jroelofs).
[OldPM] Print out a bit more when passes lie about changing IR
Jul 28 2020, 9:01 AM
jroelofs added a reverting change for rGb647d5d21dd8: [lit] Remove --repeat option, which wasn't that useful.: D84760: Revert: "[lit] Remove --repeat option, which wasn't that useful.".
Jul 28 2020, 8:24 AM
jroelofs requested review of D84760: Revert: "[lit] Remove --repeat option, which wasn't that useful.".
Jul 28 2020, 8:24 AM ยท Restricted Project

Jul 27 2020

jroelofs committed rG6dadf7cb654c: [llvm][examples][SimplifyCFG] Fix pass's IR changed reporting (authored by jroelofs).
[llvm][examples][SimplifyCFG] Fix pass's IR changed reporting
Jul 27 2020, 12:40 PM
Herald added a project to D84686: [OldPM] Print out a bit more when passes lie about changing IR: Restricted Project.
Jul 27 2020, 11:37 AM ยท Restricted Project
jroelofs added a comment to D84327: [SCEVExpander] Add helper to clean up instrs inserted while expanding..

LG to me, but probably wait a bit for @jroelofs.

Jul 27 2020, 10:15 AM ยท Restricted Project
jroelofs committed rG88ce9f9b441e: [TableGen][CGS] Print better errors on overlapping InstRW (authored by jroelofs).
[TableGen][CGS] Print better errors on overlapping InstRW
Jul 27 2020, 8:41 AM
jroelofs closed D83588: [TableGen][CGS] Print better errors on overlapping InstRW.
Jul 27 2020, 8:41 AM ยท Restricted Project
jroelofs committed rGf5e1ec8c5804: [AArch64] fjcvtzs,rmif,cfinv,setf* all clobber nzcv (authored by jroelofs).
[AArch64] fjcvtzs,rmif,cfinv,setf* all clobber nzcv
Jul 27 2020, 8:18 AM
jroelofs closed D83818: [AArch64] fjcvtzs,rmif,cfinv,setf* all clobber nzcv.
Jul 27 2020, 8:18 AM ยท Restricted Project

Jul 24 2020

jroelofs added a comment to rGf7ffb122d08e: [libFuzzer] Instrument bcmp.

4dc3014c51fda2a3189318c4ae54c4da9cfc6a0e

Jul 24 2020, 1:56 PM
jroelofs committed rG4dc3014c51fd: [compiler-rt][fuzzer] Disable bcmp.test on darwin (authored by jroelofs).
[compiler-rt][fuzzer] Disable bcmp.test on darwin
Jul 24 2020, 1:56 PM
jroelofs added a comment to D83818: [AArch64] fjcvtzs,rmif,cfinv,setf* all clobber nzcv.

Optional: since they are really small tests, you can try if it is convenient to have them all in one file, but separate is fine too I think.

Jul 24 2020, 1:48 PM ยท Restricted Project
jroelofs added a comment to D84450: Testcase for "More conservatively report status from LoopIdiomRecognize".

Thanks for sharing. I did not manage to get it to crash with the patches removed though :(

Jul 24 2020, 1:45 PM ยท Restricted Project
jroelofs added a comment to rGf7ffb122d08e: [libFuzzer] Instrument bcmp.

@MaskRay I believe this broke one of the buildbots when it landed. Mind taking a look?

Jul 24 2020, 12:30 PM
jroelofs added a comment to D83818: [AArch64] fjcvtzs,rmif,cfinv,setf* all clobber nzcv.

Kinda verbose, but it works. This would be so much easier if we had a way to dump mir from llvm-mc.

Jul 24 2020, 10:06 AM ยท Restricted Project
jroelofs updated the diff for D83818: [AArch64] fjcvtzs,rmif,cfinv,setf* all clobber nzcv.

rm subsumed test

Jul 24 2020, 10:05 AM ยท Restricted Project
jroelofs updated the diff for D83818: [AArch64] fjcvtzs,rmif,cfinv,setf* all clobber nzcv.
Jul 24 2020, 10:03 AM ยท Restricted Project