Page MenuHomePhabricator

jroelofs (Jonathan Roelofs)
Sourcerer

Projects

User does not belong to any projects.

User Details

User Since
Nov 27 2013, 1:02 PM (330 w, 6 d)

Recent Activity

Today

jroelofs updated the diff for D77160: Fix PR45371: SeparateConstOffsetFromGEP clean up bookkeeping.

implement review feedback

Tue, Mar 31, 3:59 PM · Restricted Project
jroelofs added inline comments to D77160: Fix PR45371: SeparateConstOffsetFromGEP clean up bookkeeping.
Tue, Mar 31, 3:27 PM · Restricted Project
jroelofs added reviewers for D77160: Fix PR45371: SeparateConstOffsetFromGEP clean up bookkeeping: ajwock, arsenm.
Tue, Mar 31, 12:35 PM · Restricted Project
jroelofs created D77160: Fix PR45371: SeparateConstOffsetFromGEP clean up bookkeeping.
Tue, Mar 31, 12:33 PM · Restricted Project

Yesterday

jroelofs updated the diff for D76994: [DAG] Fix PR45049: LegalizeTypes crash.
Mon, Mar 30, 12:30 PM · Restricted Project
jroelofs added inline comments to D76994: [DAG] Fix PR45049: LegalizeTypes crash.
Mon, Mar 30, 12:30 PM · Restricted Project

Sat, Mar 28

jroelofs created D76994: [DAG] Fix PR45049: LegalizeTypes crash.
Sat, Mar 28, 12:22 PM · Restricted Project

Thu, Mar 26

jroelofs committed rG7a89a5d81bbd: [InstCombine] Fix Incorrect fold of ashr+xor -> lshr w/ vectors (authored by jroelofs).
[InstCombine] Fix Incorrect fold of ashr+xor -> lshr w/ vectors
Thu, Mar 26, 11:25 AM
jroelofs closed D76800: [InstCombine] Fix Incorrect fold of ashr+xor -> lshr w/ vectors.

https://github.com/llvm/llvm-project/commit/7a89a5d81bbdc0ab6dbd14d9af4a52e64c868423

Thu, Mar 26, 11:22 AM · Restricted Project

Wed, Mar 25

jroelofs updated the diff for D76800: [InstCombine] Fix Incorrect fold of ashr+xor -> lshr w/ vectors.

Implement review feedback

Wed, Mar 25, 3:43 PM · Restricted Project
jroelofs retitled D76800: [InstCombine] Fix Incorrect fold of ashr+xor -> lshr w/ vectors from [Instcombine] Fix Incorrect fold of ashr+xor -> lshr w/ vectors to [InstCombine] Fix Incorrect fold of ashr+xor -> lshr w/ vectors.
Wed, Mar 25, 2:05 PM · Restricted Project
jroelofs created D76800: [InstCombine] Fix Incorrect fold of ashr+xor -> lshr w/ vectors.
Wed, Mar 25, 2:05 PM · Restricted Project

Thu, Mar 12

jroelofs committed rG2c9cf9f4ddd0: [clang-tidy] New check: bugprone-suspicious-include (authored by jroelofs).
[clang-tidy] New check: bugprone-suspicious-include
Thu, Mar 12, 9:14 AM
jroelofs added a comment to D74669: [clang-tidy] New check: bugprone-suspicious-include.

re-landed in https://github.com/llvm/llvm-project/commit/2c9cf9f4ddd01ae9eb47522266a6343104f9d0b5

Thu, Mar 12, 9:13 AM · Restricted Project, Restricted Project

Tue, Mar 10

jroelofs updated the diff for D74669: [clang-tidy] New check: bugprone-suspicious-include.

Don't fire on #imports.

Tue, Mar 10, 8:06 AM · Restricted Project, Restricted Project

Mon, Mar 9

jroelofs committed rG52bbdad7d63f: [clang-tidy][docs] Post-commit feedback on D74669 (authored by jroelofs).
[clang-tidy][docs] Post-commit feedback on D74669
Mon, Mar 9, 4:13 PM
jroelofs added a comment to D74669: [clang-tidy] New check: bugprone-suspicious-include.

https://github.com/llvm/llvm-project/commit/52bbdad7d63fd060d102b3591b433d116a982255

Mon, Mar 9, 4:12 PM · Restricted Project, Restricted Project
jroelofs committed rG2e9d33bccd58: Add missing list.rst entry (authored by jroelofs).
Add missing list.rst entry
Mon, Mar 9, 3:40 PM
jroelofs committed rG698a12712920: release notes: fix new check name (authored by jroelofs).
release notes: fix new check name
Mon, Mar 9, 3:40 PM
jroelofs committed rG1e0669bfe05f: [clang-tidy] New check: bugprone-suspicious-include (authored by jroelofs).
[clang-tidy] New check: bugprone-suspicious-include
Mon, Mar 9, 3:08 PM
jroelofs closed D74669: [clang-tidy] New check: bugprone-suspicious-include.

Thanks for the review!

Mon, Mar 9, 3:07 PM · Restricted Project, Restricted Project
jroelofs updated the diff for D74669: [clang-tidy] New check: bugprone-suspicious-include.

Implement review feedback.

Mon, Mar 9, 3:07 PM · Restricted Project, Restricted Project
jroelofs updated the diff for D74669: [clang-tidy] New check: bugprone-suspicious-include.

Add missing release notes.

Mon, Mar 9, 3:07 PM · Restricted Project, Restricted Project
jroelofs committed rG6bfd10ff80af: Fix internal links in Kaleidoscope tutorial (authored by jroelofs).
Fix internal links in Kaleidoscope tutorial
Mon, Mar 9, 2:36 PM
jroelofs committed rGc71ef7a85d24: Drop HEADER_ per review feedback on D74669 (authored by jroelofs).
Drop HEADER_ per review feedback on D74669
Mon, Mar 9, 11:20 AM
jroelofs added inline comments to D74669: [clang-tidy] New check: bugprone-suspicious-include.
Mon, Mar 9, 11:19 AM · Restricted Project, Restricted Project
jroelofs updated the diff for D74669: [clang-tidy] New check: bugprone-suspicious-include.

Fix comment, add docs.

Mon, Mar 9, 11:19 AM · Restricted Project, Restricted Project
jroelofs committed rG47caa69120e5: [clang-tidy] Use ; as separator for HeaderFileExtensions (authored by jroelofs).
[clang-tidy] Use ; as separator for HeaderFileExtensions
Mon, Mar 9, 10:47 AM
jroelofs committed rG3486cc014b20: [clang-tidy] Generalize HeaderFileExtensions.{h,cpp}. NFC (authored by jroelofs).
[clang-tidy] Generalize HeaderFileExtensions.{h,cpp}. NFC
Mon, Mar 9, 10:47 AM
jroelofs closed D75621: [clang-tidy] Use ; as separator for HeaderFileExtensions.

https://github.com/llvm/llvm-project/commit/47caa69120e582bf1b795ec646f069c83b0e9456

Mon, Mar 9, 10:46 AM · Restricted Project
jroelofs closed D75489: [clang-tidy] Generalize HeaderFileExtensions.{h,cpp}. NFC.

https://github.com/llvm/llvm-project/commit/3486cc014b208df3897cf5656db0d0fdeae26d6b

Mon, Mar 9, 10:46 AM · Restricted Project
jroelofs added inline comments to D75621: [clang-tidy] Use ; as separator for HeaderFileExtensions.
Mon, Mar 9, 8:35 AM · Restricted Project
jroelofs added inline comments to D75621: [clang-tidy] Use ; as separator for HeaderFileExtensions.
Mon, Mar 9, 8:03 AM · Restricted Project

Fri, Mar 6

jroelofs updated the diff for D75621: [clang-tidy] Use ; as separator for HeaderFileExtensions.
  • Drop dead include.
Fri, Mar 6, 9:18 AM · Restricted Project
jroelofs updated the diff for D75621: [clang-tidy] Use ; as separator for HeaderFileExtensions.
  • Don't spam the deprecation message. Move that to release notes.
  • Drop unnecessary const.
Fri, Mar 6, 9:18 AM · Restricted Project

Wed, Mar 4

jroelofs updated the diff for D75621: [clang-tidy] Use ; as separator for HeaderFileExtensions.
Wed, Mar 4, 4:53 PM · Restricted Project
jroelofs updated the diff for D74669: [clang-tidy] New check: bugprone-suspicious-include.
Wed, Mar 4, 11:15 AM · Restricted Project, Restricted Project
jroelofs updated the diff for D75621: [clang-tidy] Use ; as separator for HeaderFileExtensions.

Preserve backwards compatibility of ',' as a delimiter (for now).

Wed, Mar 4, 11:15 AM · Restricted Project
jroelofs updated the diff for D74669: [clang-tidy] New check: bugprone-suspicious-include.
Wed, Mar 4, 9:32 AM · Restricted Project, Restricted Project
jroelofs updated the diff for D75621: [clang-tidy] Use ; as separator for HeaderFileExtensions.

Fix comments

Wed, Mar 4, 9:32 AM · Restricted Project
jroelofs updated the diff for D74669: [clang-tidy] New check: bugprone-suspicious-include.

Split out https://reviews.llvm.org/D75621

Wed, Mar 4, 9:32 AM · Restricted Project, Restricted Project
jroelofs added a parent revision for D75621: [clang-tidy] Use ; as separator for HeaderFileExtensions: D75489: [clang-tidy] Generalize HeaderFileExtensions.{h,cpp}. NFC.
Wed, Mar 4, 9:32 AM · Restricted Project
jroelofs added a child revision for D75489: [clang-tidy] Generalize HeaderFileExtensions.{h,cpp}. NFC: D75621: [clang-tidy] Use ; as separator for HeaderFileExtensions.
Wed, Mar 4, 9:32 AM · Restricted Project
jroelofs added a parent revision for D74669: [clang-tidy] New check: bugprone-suspicious-include: D75621: [clang-tidy] Use ; as separator for HeaderFileExtensions.
Wed, Mar 4, 9:01 AM · Restricted Project, Restricted Project
jroelofs added a child revision for D75621: [clang-tidy] Use ; as separator for HeaderFileExtensions: D74669: [clang-tidy] New check: bugprone-suspicious-include.
Wed, Mar 4, 9:01 AM · Restricted Project
jroelofs created D75621: [clang-tidy] Use ; as separator for HeaderFileExtensions.
Wed, Mar 4, 9:00 AM · Restricted Project

Mon, Mar 2

jroelofs added a comment to D74669: [clang-tidy] New check: bugprone-suspicious-include.

Adding the parent revision means you don't need to have those changes in this patch.

Mon, Mar 2, 8:53 PM · Restricted Project, Restricted Project
jroelofs updated the diff for D74669: [clang-tidy] New check: bugprone-suspicious-include.

implement review feedback

Mon, Mar 2, 5:14 PM · Restricted Project, Restricted Project
jroelofs updated the diff for D75489: [clang-tidy] Generalize HeaderFileExtensions.{h,cpp}. NFC.
Mon, Mar 2, 4:58 PM · Restricted Project
jroelofs added inline comments to D75489: [clang-tidy] Generalize HeaderFileExtensions.{h,cpp}. NFC.
Mon, Mar 2, 4:14 PM · Restricted Project
jroelofs retitled D74669: [clang-tidy] New check: bugprone-suspicious-include from [clang-tidy] New check: misc-no-include-cpp to [clang-tidy] New check: bugprone-suspicious-include.
Mon, Mar 2, 4:14 PM · Restricted Project, Restricted Project
jroelofs added a parent revision for D74669: [clang-tidy] New check: bugprone-suspicious-include: D75489: [clang-tidy] Generalize HeaderFileExtensions.{h,cpp}. NFC.
Mon, Mar 2, 4:14 PM · Restricted Project, Restricted Project
jroelofs created D75489: [clang-tidy] Generalize HeaderFileExtensions.{h,cpp}. NFC.
Mon, Mar 2, 4:14 PM · Restricted Project
jroelofs added a child revision for D75489: [clang-tidy] Generalize HeaderFileExtensions.{h,cpp}. NFC: D74669: [clang-tidy] New check: bugprone-suspicious-include.
Mon, Mar 2, 4:14 PM · Restricted Project

Feb 25 2020

jroelofs updated the diff for D74669: [clang-tidy] New check: bugprone-suspicious-include.

Implement review feedback:

  • Re-purpose HeaderFileExtensionsUtils.h to support headers *and* sources.
  • Surround file extension in diagnostic with ''s.
Feb 25 2020, 5:12 PM · Restricted Project, Restricted Project

Feb 20 2020

jroelofs added a comment to D28820: Warn when calling a non interrupt function from an interrupt on ARM.

Thank you very much for recording the bug.

Feb 20 2020, 6:59 AM

Feb 18 2020

jroelofs updated the summary of D74812: [Sema] Teach -Warm-interrupt-safety about func ptrs.
Feb 18 2020, 7:33 PM · Restricted Project
jroelofs added inline comments to D74812: [Sema] Teach -Warm-interrupt-safety about func ptrs.
Feb 18 2020, 7:33 PM · Restricted Project
jroelofs created D74812: [Sema] Teach -Warm-interrupt-safety about func ptrs.
Feb 18 2020, 7:24 PM · Restricted Project

Feb 17 2020

jroelofs updated the diff for D74669: [clang-tidy] New check: bugprone-suspicious-include.

Make the diagnostics more accurate.

Feb 17 2020, 1:42 PM · Restricted Project, Restricted Project
jroelofs added inline comments to D74669: [clang-tidy] New check: bugprone-suspicious-include.
Feb 17 2020, 9:45 AM · Restricted Project, Restricted Project
jroelofs updated the diff for D74669: [clang-tidy] New check: bugprone-suspicious-include.

Implement review feedback re: DiagLoc

Feb 17 2020, 9:35 AM · Restricted Project, Restricted Project

Feb 16 2020

jroelofs added inline comments to D74669: [clang-tidy] New check: bugprone-suspicious-include.
Feb 16 2020, 8:30 AM · Restricted Project, Restricted Project
jroelofs updated the diff for D74669: [clang-tidy] New check: bugprone-suspicious-include.

git format-patch

Feb 16 2020, 8:30 AM · Restricted Project, Restricted Project
jroelofs added inline comments to D74669: [clang-tidy] New check: bugprone-suspicious-include.
Feb 16 2020, 8:21 AM · Restricted Project, Restricted Project
jroelofs updated the diff for D74669: [clang-tidy] New check: bugprone-suspicious-include.
  • Renamed to bugprone-suspicious-include
  • Removed FixIts in favor of note: suggestions, iff the suggested file exists on the header search path.
  • Removed unnecessary unused parameter casts-to-void.
Feb 16 2020, 8:21 AM · Restricted Project, Restricted Project
jroelofs added inline comments to D74669: [clang-tidy] New check: bugprone-suspicious-include.
Feb 16 2020, 8:21 AM · Restricted Project, Restricted Project
jroelofs added a comment to D74669: [clang-tidy] New check: bugprone-suspicious-include.

I have a feeling this check should be called something along the lines of bugprone-suspicous-include.

Feb 16 2020, 6:43 AM · Restricted Project, Restricted Project

Feb 15 2020

jroelofs created D74669: [clang-tidy] New check: bugprone-suspicious-include.
Feb 15 2020, 9:25 AM · Restricted Project, Restricted Project

Feb 3 2020

jroelofs added a comment to D73904: [clang] stop baremetal driver to append .a to lib.

+1, looks good with a test.

Feb 3 2020, 3:44 PM · Restricted Project

Jan 28 2020

jroelofs committed rG7f93ff58e1bf: [llvm] Fix broken cases of 'CHECK[^:]*$' in tests (authored by jroelofs).
[llvm] Fix broken cases of 'CHECK[^:]*$' in tests
Jan 28 2020, 8:58 AM
jroelofs committed rGa32f894f17b3: [ADT] Remove more llvm::make_unique (authored by jroelofs).
[ADT] Remove more llvm::make_unique
Jan 28 2020, 7:54 AM
jroelofs committed rG39fe44024689: [clang] Fix EOL whitespace. NFC (authored by jroelofs).
[clang] Fix EOL whitespace. NFC
Jan 28 2020, 7:48 AM

Jan 26 2020

jroelofs created D73440: [llvm] Fix broken cases of 'CHECK[^:]*$' in tests.
Jan 26 2020, 5:28 PM · Restricted Project

Jan 23 2020

jroelofs created D73316: [ADT] Remove more llvm::make_unique.
Jan 23 2020, 5:20 PM · Restricted Project

Jan 21 2020

jroelofs accepted D72501: [libcxx] Support Python 3.8 in the test suite.

Either way, LGTM.

Jan 21 2020, 7:07 AM · Restricted Project

Jan 17 2020

jroelofs accepted D72847: [libcxx] Introduce LinuxRemoteTI for remote testing.

Awesome, LGTM!

Jan 17 2020, 6:30 AM · Restricted Project

Jan 15 2020

jroelofs accepted D72720: [libcxx] Allow manually specifying locales for use in tests via CMake.

My long term plan for this was to have a set of "remote" TargetInfo objects that mirror/wrap these "local" ones, and have the SSHExecutor sub them in as appropriate, but this seems like a pragmatic compromise.

Jan 15 2020, 4:41 PM · Restricted Project

Jan 9 2020

jroelofs accepted D71894: [libcxxabi] Allow tests to link with static libc++abi/libc++ even if the shared version is present.

LGTM

Jan 9 2020, 7:24 AM · Restricted Project, Restricted Project, Restricted Project

Dec 7 2019

jroelofs accepted D71136: [libcxx] Replace func_name with __name__ for compatibility with Python 3.

LGTM

Dec 7 2019, 4:55 PM · Restricted Project

Apr 23 2019

jroelofs added inline comments to D61040: [Fuchsia] Support multilib for -fsanitize=address and -fno-exceptions.
Apr 23 2019, 5:41 PM · Restricted Project

Sep 26 2018

jroelofs accepted D52530: [analyzer] scan-build: if --status-bugs is passed, don't forget about the exit status of the actual build.

LGTM

Sep 26 2018, 5:39 AM

Sep 16 2018

jroelofs added a comment to D52151: Also manages clang-X as tool for scan-build.

$triple-clang, also

Sep 16 2018, 1:21 PM
jroelofs accepted D52153: scan-build: Add support of the option --exclude like in scan-build-py.

LGTM

Sep 16 2018, 1:00 PM
jroelofs added a comment to D52151: Also manages clang-X as tool for scan-build.

lgtm

Sep 16 2018, 12:31 PM

Aug 28 2018

jroelofs accepted D51354: Fix the -print-multi-directory flag to print the selected multilib..

LGTM. Thanks for fixing this!

Aug 28 2018, 7:23 PM

Jul 27 2018

jroelofs added a comment to D49898: Make test/Driver/baremetal.cpp work with linkers other than lld.

LGTM

Jul 27 2018, 10:11 AM

Apr 6 2018

jroelofs updated subscribers of D41316: [libcxx] Allow random_device to be built optionally.
the targets where you would want to use this can't run the libcxx

testsuite anyway (because they don't have an operating system to run the
test programs under).

Apr 6 2018, 6:36 AM

Feb 11 2018

jroelofs added a comment to D43159: Modernize: Use nullptr more..

Is it worth adding -Werror=zero-as-null-pointer-constant to the build?

Feb 11 2018, 1:24 PM

Jan 31 2018

jroelofs committed rC323864: Fix typo. NFC.
Fix typo. NFC
Jan 31 2018, 4:08 AM
jroelofs committed rL323864: Fix typo. NFC.
Fix typo. NFC
Jan 31 2018, 4:08 AM
jroelofs added inline comments to rC323665: [scan-build] Add an option to skip overriding CC and CXX make vars.
Jan 31 2018, 4:08 AM

Jan 29 2018

jroelofs committed rL323665: [scan-build] Add an option to skip overriding CC and CXX make vars.
[scan-build] Add an option to skip overriding CC and CXX make vars
Jan 29 2018, 8:51 AM
jroelofs committed rC323665: [scan-build] Add an option to skip overriding CC and CXX make vars.
[scan-build] Add an option to skip overriding CC and CXX make vars
Jan 29 2018, 8:51 AM
jroelofs committed rL323664: [analyzer] Fix -x language argument for C preprocessed sources.
[analyzer] Fix -x language argument for C preprocessed sources
Jan 29 2018, 8:39 AM
jroelofs committed rC323664: [analyzer] Fix -x language argument for C preprocessed sources.
[analyzer] Fix -x language argument for C preprocessed sources
Jan 29 2018, 8:39 AM

Jan 11 2018

jroelofs added a comment to D41316: [libcxx] Allow random_device to be built optionally.

Should we go with current patch?

Jan 11 2018, 10:38 AM

Jan 9 2018

jroelofs accepted D41873: [Option] For typo '-foo', suggest '--foo'.

LGTM

Jan 9 2018, 10:54 AM

Jan 8 2018

jroelofs added a comment to D41793: [Debugify] Add a mode to opt to enable faster testing.

You can avoid the env var by adding a substitution for opt in the lit.cfg.py with the extra argument.

Jan 8 2018, 9:38 AM · debug-info

Jan 5 2018

jroelofs accepted D41732: [Option] Add 'findNearest' method to catch typos.

LGTM

Jan 5 2018, 8:16 AM