Page MenuHomePhabricator

kadircet (Kadir Cetinkaya)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 14 2018, 2:16 AM (61 w, 2 d)

Recent Activity

Thu, Apr 18

kadircet created D60873: [clang][HeaderSuggestion] Handle the case of dotdot with an absolute path.
Thu, Apr 18, 8:29 AM · Restricted Project
kadircet accepted D60267: [clangd] Support relatedInformation in diagnostics..
Thu, Apr 18, 8:06 AM · Restricted Project, Restricted Project
kadircet committed rGb8f82ca1b2b2: [clang][CIndex] Use llvm::set_thread_priority (authored by kadircet).
[clang][CIndex] Use llvm::set_thread_priority
Thu, Apr 18, 6:48 AM
kadircet committed rC358665: [clang][CIndex] Use llvm::set_thread_priority.
[clang][CIndex] Use llvm::set_thread_priority
Thu, Apr 18, 6:47 AM
kadircet committed rL358665: [clang][CIndex] Use llvm::set_thread_priority.
[clang][CIndex] Use llvm::set_thread_priority
Thu, Apr 18, 6:47 AM
kadircet closed D60867: [clang][CIndex] Use llvm::set_thread_priority.
Thu, Apr 18, 6:47 AM · Restricted Project
kadircet committed rGf8537b3c6939: [clangd] Use llvm::set_thread_priority in background-index (authored by kadircet).
[clangd] Use llvm::set_thread_priority in background-index
Thu, Apr 18, 6:45 AM
kadircet committed rL358664: [clangd] Use llvm::set_thread_priority in background-index.
[clangd] Use llvm::set_thread_priority in background-index
Thu, Apr 18, 6:44 AM
kadircet committed rCTE358664: [clangd] Use llvm::set_thread_priority in background-index.
[clangd] Use llvm::set_thread_priority in background-index
Thu, Apr 18, 6:44 AM
kadircet closed D60865: [clangd] Use llvm::set_thread_priority in background-index.
Thu, Apr 18, 6:44 AM · Restricted Project
kadircet created D60867: [clang][CIndex] Use llvm::set_thread_priority.
Thu, Apr 18, 6:25 AM · Restricted Project
kadircet created D60865: [clangd] Use llvm::set_thread_priority in background-index.
Thu, Apr 18, 6:15 AM · Restricted Project
kadircet added inline comments to D60267: [clangd] Support relatedInformation in diagnostics..
Thu, Apr 18, 4:19 AM · Restricted Project, Restricted Project
kadircet added a reviewer for D59302: [clangd] Surface diagnostics from headers inside main file: sammccall.
Thu, Apr 18, 2:46 AM · Restricted Project
kadircet accepted D60827: [rename] Deduplicate symbol occurrences.

Thanks

Thu, Apr 18, 2:22 AM · Restricted Project

Wed, Apr 17

kadircet removed a reviewer for D59605: [clangd] Introduce background-indexer: ilya-biryukov.
Wed, Apr 17, 7:55 AM · Restricted Project
kadircet accepted D60819: [clangd] Strip the ' [some-check-name]' suffix from clang-tidy diagnostics. The check name is reported in Diagnostic.code..

LGTM, we might need to make sure clients that do not show "code" field become aware of this before LLVM9 releases

Wed, Apr 17, 7:18 AM · Restricted Project
kadircet accepted D60822: [clangd] Use shorter, more recognizable codes for diagnostics..

I agree that these are more useful. What about also adding "-W" in front of warning flags to make them more explicit and stand out from "non-flag" error names?

Wed, Apr 17, 7:02 AM · Restricted Project
kadircet accepted D58291: [clangd] Include textual diagnostic ID as Diagnostic.code..

It's a good question, it depends how this is surfaced, and we may want to tweak the behavior or suppress entirely in some cases.
I think at least some are useful:

  • clang-tidy check names are things users need to know about (used for configuration)
  • for warnings, we quite likely should replace with the most specific warning category (e.g. "unreachable-code-loop-increment"), again these are used for configuration (-W)
  • for others, maybe we should at least trim the err_ prefix, or maybe drop them entirely.
Wed, Apr 17, 2:55 AM · Restricted Project

Tue, Apr 16

kadircet committed rG8fdc5abffe2e: [llvm][Support] Provide interface to set thread priorities (authored by kadircet).
[llvm][Support] Provide interface to set thread priorities
Tue, Apr 16, 7:33 AM
kadircet committed rL358494: [llvm][Support] Provide interface to set thread priorities.
[llvm][Support] Provide interface to set thread priorities
Tue, Apr 16, 7:32 AM
kadircet closed D59130: [llvm][Support] Provide interface to set thread priorities.
Tue, Apr 16, 7:32 AM · Restricted Project
kadircet added inline comments to D59302: [clangd] Surface diagnostics from headers inside main file.
Tue, Apr 16, 7:17 AM · Restricted Project
kadircet updated the diff for D59302: [clangd] Surface diagnostics from headers inside main file.
  • Address comments
Tue, Apr 16, 7:17 AM · Restricted Project
kadircet added a comment to D59302: [clangd] Surface diagnostics from headers inside main file.

Ping

Tue, Apr 16, 1:02 AM · Restricted Project

Mon, Apr 15

kadircet committed rGbb6cd8254c24: [clangd] Fallback to OrigD when SLoc is invalid (authored by kadircet).
[clangd] Fallback to OrigD when SLoc is invalid
Mon, Apr 15, 7:38 AM
kadircet committed rL358413: [clangd] Fallback to OrigD when SLoc is invalid.
[clangd] Fallback to OrigD when SLoc is invalid
Mon, Apr 15, 7:37 AM
kadircet committed rCTE358413: [clangd] Fallback to OrigD when SLoc is invalid.
[clangd] Fallback to OrigD when SLoc is invalid
Mon, Apr 15, 7:37 AM
kadircet closed D60689: [clangd] Fallback to OrigD when SLoc is invalid.
Mon, Apr 15, 7:37 AM · Restricted Project
kadircet abandoned D60685: [clangd] Dont index Symbols with invalid source location.
Mon, Apr 15, 5:30 AM · Restricted Project
kadircet created D60689: [clangd] Fallback to OrigD when SLoc is invalid.
Mon, Apr 15, 5:29 AM · Restricted Project
kadircet created D60685: [clangd] Dont index Symbols with invalid source location.
Mon, Apr 15, 4:22 AM · Restricted Project
kadircet committed rGa9ce09be0333: [clangd] Bump clangd-index version for TemplateArgument changes (authored by kadircet).
[clangd] Bump clangd-index version for TemplateArgument changes
Mon, Apr 15, 2:19 AM
kadircet committed rCTE358383: [clangd] Bump clangd-index version for TemplateArgument changes.
[clangd] Bump clangd-index version for TemplateArgument changes
Mon, Apr 15, 2:19 AM
kadircet committed rL358383: [clangd] Bump clangd-index version for TemplateArgument changes.
[clangd] Bump clangd-index version for TemplateArgument changes
Mon, Apr 15, 2:19 AM
kadircet committed rG43e92880acf1: [clangd] Reorder source files in CMakeLists (authored by kadircet).
[clangd] Reorder source files in CMakeLists
Mon, Apr 15, 12:21 AM
kadircet committed rCTE358373: [clangd] Reorder source files in CMakeLists.
[clangd] Reorder source files in CMakeLists
Mon, Apr 15, 12:19 AM
kadircet committed rL358373: [clangd] Reorder source files in CMakeLists.
[clangd] Reorder source files in CMakeLists
Mon, Apr 15, 12:19 AM

Fri, Apr 12

kadircet committed rG5757bfbd54fd: [clangd] Fix an overflow inside a test (authored by kadircet).
[clangd] Fix an overflow inside a test
Fri, Apr 12, 9:40 AM
kadircet committed rL358293: [clangd] Fix an overflow inside a test.
[clangd] Fix an overflow inside a test
Fri, Apr 12, 9:40 AM
kadircet committed rCTE358293: [clangd] Fix an overflow inside a test.
[clangd] Fix an overflow inside a test
Fri, Apr 12, 9:40 AM
kadircet committed rG4f789e1b3932: [clangd] Show template argument list in workspacesymbols and documentsymbols… (authored by kadircet).
[clangd] Show template argument list in workspacesymbols and documentsymbols…
Fri, Apr 12, 3:11 AM
kadircet committed rG79063de95cbc: [clangd] Add TemplateArgumentList into Symbol (authored by kadircet).
[clangd] Add TemplateArgumentList into Symbol
Fri, Apr 12, 3:11 AM
kadircet committed rGa80a52283cb7: [clangd] Print template arguments helper (authored by kadircet).
[clangd] Print template arguments helper
Fri, Apr 12, 3:10 AM
kadircet committed rCTE358274: [clangd] Show template argument list in workspacesymbols and documentsymbols….
[clangd] Show template argument list in workspacesymbols and documentsymbols…
Fri, Apr 12, 3:10 AM
kadircet committed rCTE358273: [clangd] Add TemplateArgumentList into Symbol.
[clangd] Add TemplateArgumentList into Symbol
Fri, Apr 12, 3:10 AM
kadircet committed rCTE358272: [clangd] Print template arguments helper.
[clangd] Print template arguments helper
Fri, Apr 12, 3:10 AM
kadircet committed rL358274: [clangd] Show template argument list in workspacesymbols and documentsymbols….
[clangd] Show template argument list in workspacesymbols and documentsymbols…
Fri, Apr 12, 3:10 AM
kadircet committed rL358273: [clangd] Add TemplateArgumentList into Symbol.
[clangd] Add TemplateArgumentList into Symbol
Fri, Apr 12, 3:10 AM
kadircet closed D59641: [clangd] Show template argument list in workspacesymbols and documentsymbols responses.
Fri, Apr 12, 3:10 AM · Restricted Project, Restricted Project
kadircet closed D59640: [clangd] Add TemplateArgumentList into Symbol.
Fri, Apr 12, 3:10 AM · Restricted Project, Restricted Project
kadircet committed rL358272: [clangd] Print template arguments helper.
[clangd] Print template arguments helper
Fri, Apr 12, 3:10 AM
kadircet committed rC358272: [clangd] Print template arguments helper.
[clangd] Print template arguments helper
Fri, Apr 12, 3:10 AM
kadircet closed D59639: [clangd] Print template arguments helper.
Fri, Apr 12, 3:10 AM · Restricted Project, Restricted Project
kadircet abandoned D59599: [clangd] Fix a crash while printing Template Arguments.

It is incorporated into D59639

Fri, Apr 12, 3:02 AM · Restricted Project
kadircet updated the diff for D59640: [clangd] Add TemplateArgumentList into Symbol.
  • Fill in the TemplateSpecializationArgs in all code paths.
Fri, Apr 12, 2:16 AM · Restricted Project, Restricted Project
kadircet added inline comments to D59640: [clangd] Add TemplateArgumentList into Symbol.
Fri, Apr 12, 1:42 AM · Restricted Project, Restricted Project
kadircet added inline comments to D59641: [clangd] Show template argument list in workspacesymbols and documentsymbols responses.
Fri, Apr 12, 1:13 AM · Restricted Project, Restricted Project
kadircet added a comment to D59640: [clangd] Add TemplateArgumentList into Symbol.

Ping

Fri, Apr 12, 1:07 AM · Restricted Project, Restricted Project
kadircet updated the diff for D59641: [clangd] Show template argument list in workspacesymbols and documentsymbols responses.
  • Rebase
Fri, Apr 12, 1:05 AM · Restricted Project, Restricted Project

Thu, Apr 11

kadircet added a comment to D59605: [clangd] Introduce background-indexer.

Looking at the current state of BackgroundIndex, it has the following implementation details:

  • Loading of shards from storage
  • Storing of shards to storage
  • Collecting symbols from a TU
  • Sharding of symbol information collected from one translation unit
  • Performing all these tasks in a thread pool that can change scheduling priority of the thread depending on the task running.
Thu, Apr 11, 9:05 AM · Restricted Project
kadircet added inline comments to D59639: [clangd] Print template arguments helper.
Thu, Apr 11, 7:53 AM · Restricted Project, Restricted Project
kadircet updated the diff for D59639: [clangd] Print template arguments helper.
  • Address comments
Thu, Apr 11, 7:52 AM · Restricted Project, Restricted Project
kadircet updated the diff for D59639: [clangd] Print template arguments helper.
  • Update file comment for PrintASTTests.cpp
Thu, Apr 11, 3:40 AM · Restricted Project, Restricted Project
kadircet updated the diff for D59639: [clangd] Print template arguments helper.
  • Address comments
Thu, Apr 11, 3:38 AM · Restricted Project, Restricted Project
kadircet added inline comments to D59639: [clangd] Print template arguments helper.
Thu, Apr 11, 3:38 AM · Restricted Project, Restricted Project
kadircet added inline comments to D59641: [clangd] Show template argument list in workspacesymbols and documentsymbols responses.
Thu, Apr 11, 3:32 AM · Restricted Project, Restricted Project

Wed, Apr 10

kadircet updated the diff for D59302: [clangd] Surface diagnostics from headers inside main file.
  • Address comments
Wed, Apr 10, 8:50 AM · Restricted Project
kadircet added inline comments to D59302: [clangd] Surface diagnostics from headers inside main file.
Wed, Apr 10, 8:50 AM · Restricted Project
kadircet updated the diff for D59599: [clangd] Fix a crash while printing Template Arguments.
  • Address comments
Wed, Apr 10, 3:43 AM · Restricted Project
kadircet added inline comments to D60267: [clangd] Support relatedInformation in diagnostics..
Wed, Apr 10, 3:31 AM · Restricted Project, Restricted Project

Tue, Apr 9

kadircet added a comment to D60323: [clangd] Include compile command inference in fileStatus API.

What about surfacing compile command itself as well? IMO, it is an important information that we always extract from logs by digging currently.

Tue, Apr 9, 8:21 AM · Restricted Project

Fri, Mar 22

kadircet added a comment to D59640: [clangd] Add TemplateArgumentList into Symbol.

should we update YAML?

Fri, Mar 22, 4:53 AM · Restricted Project, Restricted Project
kadircet updated the diff for D59640: [clangd] Add TemplateArgumentList into Symbol.
  • Address comments
Fri, Mar 22, 4:53 AM · Restricted Project, Restricted Project
kadircet added inline comments to D59639: [clangd] Print template arguments helper.
Fri, Mar 22, 4:31 AM · Restricted Project, Restricted Project
kadircet updated the diff for D59639: [clangd] Print template arguments helper.
  • Address comments
Fri, Mar 22, 4:31 AM · Restricted Project, Restricted Project
kadircet added inline comments to D59481: [clangd] Count number of references while merging RefSlabs inside FileIndex.
Fri, Mar 22, 3:34 AM · Restricted Project
kadircet updated the diff for D59481: [clangd] Count number of references while merging RefSlabs inside FileIndex.
  • Address comments
Fri, Mar 22, 3:34 AM · Restricted Project
kadircet updated the diff for D59302: [clangd] Surface diagnostics from headers inside main file.
  • Address comments
Fri, Mar 22, 2:16 AM · Restricted Project
kadircet added inline comments to D59302: [clangd] Surface diagnostics from headers inside main file.
Fri, Mar 22, 2:16 AM · Restricted Project

Thu, Mar 21

kadircet added inline comments to D59605: [clangd] Introduce background-indexer.
Thu, Mar 21, 7:18 AM · Restricted Project
kadircet updated the diff for D59605: [clangd] Introduce background-indexer.
  • Address comments
Thu, Mar 21, 7:18 AM · Restricted Project
kadircet updated subscribers of D59641: [clangd] Show template argument list in workspacesymbols and documentsymbols responses.
Thu, Mar 21, 6:51 AM · Restricted Project, Restricted Project
kadircet added a parent revision for D59641: [clangd] Show template argument list in workspacesymbols and documentsymbols responses: D59640: [clangd] Add TemplateArgumentList into Symbol.
Thu, Mar 21, 6:51 AM · Restricted Project, Restricted Project
kadircet added a child revision for D59639: [clangd] Print template arguments helper: D59640: [clangd] Add TemplateArgumentList into Symbol.
Thu, Mar 21, 6:51 AM · Restricted Project, Restricted Project
kadircet added a child revision for D59640: [clangd] Add TemplateArgumentList into Symbol: D59641: [clangd] Show template argument list in workspacesymbols and documentsymbols responses.
Thu, Mar 21, 6:51 AM · Restricted Project, Restricted Project
kadircet added a parent revision for D59640: [clangd] Add TemplateArgumentList into Symbol: D59639: [clangd] Print template arguments helper.
Thu, Mar 21, 6:51 AM · Restricted Project, Restricted Project
kadircet created D59641: [clangd] Show template argument list in workspacesymbols and documentsymbols responses.
Thu, Mar 21, 6:51 AM · Restricted Project, Restricted Project
kadircet created D59640: [clangd] Add TemplateArgumentList into Symbol.
Thu, Mar 21, 6:47 AM · Restricted Project, Restricted Project
kadircet created D59639: [clangd] Print template arguments helper.
Thu, Mar 21, 6:41 AM · Restricted Project, Restricted Project

Mar 20 2019

kadircet created D59605: [clangd] Introduce background-indexer.
Mar 20 2019, 10:39 AM · Restricted Project
kadircet created D59599: [clangd] Fix a crash while printing Template Arguments.
Mar 20 2019, 8:49 AM · Restricted Project
kadircet added a comment to D52150: [clang-format] BeforeHash added to IndentPPDirectives.

Is it because the diff was made with the svn repository? It is for the newest revision.
Should I make a new diff with the git repo instead?
Or is it not because of the diff, but something in phabricator instead?
Sorry this is my first patch.

Mar 20 2019, 7:39 AM · Restricted Project
kadircet added a comment to D52150: [clang-format] BeforeHash added to IndentPPDirectives.

Could you do a rebase? I've tried to land it but there are too many merge conflicts currently.

Mar 20 2019, 4:27 AM · Restricted Project
kadircet added a comment to D59407: [clangd] Add RelationSlab.

If it's (B), how many bytes should the index be? Are the space gains worth the complexity, given that SymbolID is only 8 bytes to begin with? (As compared to say, the filenames in Ref, which can be much longer, making this sort of optimization more clearly worth it.)

Mar 20 2019, 3:51 AM · Restricted Project
kadircet updated the diff for D59302: [clangd] Surface diagnostics from headers inside main file.
  • Make limit a hardcoded value rather then a command line argument
  • Limit diags per include directive
Mar 20 2019, 3:11 AM · Restricted Project
kadircet committed rCTE356541: [clangd] Print arguments in template specializations.
[clangd] Print arguments in template specializations
Mar 20 2019, 2:45 AM
kadircet committed rG44a63f6a150d: [clangd] Print arguments in template specializations (authored by kadircet).
[clangd] Print arguments in template specializations
Mar 20 2019, 2:45 AM
kadircet committed rL356541: [clangd] Print arguments in template specializations.
[clangd] Print arguments in template specializations
Mar 20 2019, 2:45 AM
kadircet committed rC356541: [clangd] Print arguments in template specializations.
[clangd] Print arguments in template specializations
Mar 20 2019, 2:45 AM