Page MenuHomePhabricator

kadircet (Kadir Cetinkaya)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 14 2018, 2:16 AM (87 w, 16 h)

Recent Activity

Today

kadircet removed a child revision for D66647: [clangd] DefineInline action apply logic with fully qualified names: D67827: [clangd] Simplify name qualification in DefineInline.
Wed, Oct 16, 6:51 AM · Restricted Project
kadircet removed a parent revision for D67827: [clangd] Simplify name qualification in DefineInline: D66647: [clangd] DefineInline action apply logic with fully qualified names.
Wed, Oct 16, 6:51 AM · Restricted Project
kadircet removed parent revisions for D65433: [clangd] DefineInline action availability checks: D67748: [clangd] Add a helper for extracting nonlocal decls in a FunctionDecl, D66637: [clangd] Support multifile edits as output of Tweaks.
Wed, Oct 16, 6:51 AM · Restricted Project
kadircet removed a child revision for D66637: [clangd] Support multifile edits as output of Tweaks: D65433: [clangd] DefineInline action availability checks.
Wed, Oct 16, 6:50 AM · Restricted Project, Restricted Project
kadircet removed a child revision for D67748: [clangd] Add a helper for extracting nonlocal decls in a FunctionDecl: D65433: [clangd] DefineInline action availability checks.
Wed, Oct 16, 6:50 AM · Restricted Project, Restricted Project
kadircet added a parent revision for D68261: [clangd] Add "inline" keyword to prevent ODR-violations in DefineInline: D68937: [clangd] Add parameter renaming to define-inline code action.
Wed, Oct 16, 6:50 AM · Restricted Project
kadircet added a child revision for D68937: [clangd] Add parameter renaming to define-inline code action: D68261: [clangd] Add "inline" keyword to prevent ODR-violations in DefineInline.
Wed, Oct 16, 6:50 AM · Restricted Project
kadircet added a parent revision for D69033: [clangd] Improve symbol qualification in DefineInline code action: D68261: [clangd] Add "inline" keyword to prevent ODR-violations in DefineInline.
Wed, Oct 16, 6:50 AM · Restricted Project
kadircet added a child revision for D68261: [clangd] Add "inline" keyword to prevent ODR-violations in DefineInline: D69033: [clangd] Improve symbol qualification in DefineInline code action.
Wed, Oct 16, 6:50 AM · Restricted Project
kadircet added a comment to D68937: [clangd] Add parameter renaming to define-inline code action.

An alternative approach I'm thinking of:
After D68977 lands, we could try using findExplicitReferences to produce all of these edits:

  1. we collect locations of all references and declaration of relevant parameters and template parameters.
  2. find the ones where the name differs and produce the changes.

    That would handle not only references in the default argument, but also all references in the body and should be less code overall. IMO it's worth exploring this approach right away, e.g. you could layer your patch on top of the current version of D68977
Wed, Oct 16, 6:46 AM · Restricted Project
kadircet updated the diff for D68937: [clangd] Add parameter renaming to define-inline code action.
  • Accept StringRef for Source in rewriteParameterName instead of a NamedDecl
Wed, Oct 16, 6:46 AM · Restricted Project
kadircet created D69033: [clangd] Improve symbol qualification in DefineInline code action.
Wed, Oct 16, 6:36 AM · Restricted Project

Yesterday

kadircet committed rGb18170660e72: [clangd][NFC] Update comments to use triple-slashes (authored by kadircet).
[clangd][NFC] Update comments to use triple-slashes
Tue, Oct 15, 7:59 AM
kadircet committed rL374901: [clangd][NFC] Update comments to use triple-slashes.
[clangd][NFC] Update comments to use triple-slashes
Tue, Oct 15, 7:59 AM
kadircet accepted D68981: [clangd] Use our own relation kind..

Thanks, LGTM

Tue, Oct 15, 7:59 AM · Restricted Project, Restricted Project
kadircet added inline comments to D68981: [clangd] Use our own relation kind..
Tue, Oct 15, 7:39 AM · Restricted Project, Restricted Project
kadircet committed rG9d66247e9b78: [clangd] Propagate main context into ClangdServer (authored by kadircet).
[clangd] Propagate main context into ClangdServer
Tue, Oct 15, 7:20 AM
kadircet closed D68978: [clangd] Propagate main context into ClangdServer.
Tue, Oct 15, 7:20 AM · Restricted Project
kadircet committed rL374892: [clangd] Propagate main context into ClangdServer.
[clangd] Propagate main context into ClangdServer
Tue, Oct 15, 7:20 AM
kadircet updated the diff for D68978: [clangd] Propagate main context into ClangdServer.
  • Move context swapping next to server creation
Tue, Oct 15, 7:10 AM · Restricted Project
kadircet added inline comments to D68981: [clangd] Use our own relation kind..
Tue, Oct 15, 6:42 AM · Restricted Project, Restricted Project
kadircet created D68978: [clangd] Propagate main context into ClangdServer.
Tue, Oct 15, 3:00 AM · Restricted Project

Mon, Oct 14

kadircet added a parent revision for D68937: [clangd] Add parameter renaming to define-inline code action: D66647: [clangd] DefineInline action apply logic with fully qualified names.
Mon, Oct 14, 3:08 AM · Restricted Project
kadircet added a child revision for D66647: [clangd] DefineInline action apply logic with fully qualified names: D68937: [clangd] Add parameter renaming to define-inline code action.
Mon, Oct 14, 3:08 AM · Restricted Project
kadircet added inline comments to D66647: [clangd] DefineInline action apply logic with fully qualified names.
Mon, Oct 14, 3:04 AM · Restricted Project
kadircet created D68937: [clangd] Add parameter renaming to define-inline code action.
Mon, Oct 14, 3:04 AM · Restricted Project
kadircet updated the diff for D66647: [clangd] DefineInline action apply logic with fully qualified names.
  • Move parameter renaming logic to a separate patch.
Mon, Oct 14, 2:58 AM · Restricted Project

Fri, Oct 11

kadircet committed rGcb5324c4627a: [lldb] Insert break to avoid unannotated fall-through (authored by kadircet).
[lldb] Insert break to avoid unannotated fall-through
Fri, Oct 11, 5:36 AM
kadircet committed rL374545: [lldb] Insert break to avoid unannotated fall-through.
[lldb] Insert break to avoid unannotated fall-through
Fri, Oct 11, 5:35 AM
kadircet committed rG404e21289a5e: [ADT][Statistics] Fix test after rL374490 (authored by kadircet).
[ADT][Statistics] Fix test after rL374490
Fri, Oct 11, 12:21 AM
kadircet committed rL374518: [ADT][Statistics] Fix test after rL374490.
[ADT][Statistics] Fix test after rL374490
Fri, Oct 11, 12:20 AM

Thu, Oct 10

kadircet committed rGdd37a26f6d3e: Fix assertions disabled builds after rL374367 (authored by kadircet).
Fix assertions disabled builds after rL374367
Thu, Oct 10, 9:08 AM
kadircet committed rL374372: Fix assertions disabled builds after rL374367.
Fix assertions disabled builds after rL374367
Thu, Oct 10, 9:08 AM
kadircet committed rG62808631acce: Revert "Use -fdebug-compilation-dir to form absolute paths in coverage mappings" (authored by kadircet).
Revert "Use -fdebug-compilation-dir to form absolute paths in coverage mappings"
Thu, Oct 10, 5:23 AM
kadircet added a reverting change for rGf6777964bde2: Use -fdebug-compilation-dir to form absolute paths in coverage mappings: rG62808631acce: Revert "Use -fdebug-compilation-dir to form absolute paths in coverage mappings".
Thu, Oct 10, 5:23 AM
kadircet committed rL374324: Revert "Use -fdebug-compilation-dir to form absolute paths in coverage mappings".
Revert "Use -fdebug-compilation-dir to form absolute paths in coverage mappings"
Thu, Oct 10, 5:22 AM
kadircet committed rL374310: Add github commit access for kadircet.
Add github commit access for kadircet
Thu, Oct 10, 4:05 AM

Wed, Oct 9

kadircet committed rG9a3a87d18975: [clangd] Make sure ReplyCallbacks are destroyed before RequestCancelersMutex (authored by kadircet).
[clangd] Make sure ReplyCallbacks are destroyed before RequestCancelersMutex
Wed, Oct 9, 7:02 AM
kadircet closed D68702: [clangd] Make sure ReplyCallbacks are destroyed before RequestCancelersMutex.
Wed, Oct 9, 7:02 AM · Restricted Project
kadircet committed rL374168: [clangd] Make sure ReplyCallbacks are destroyed before RequestCancelersMutex.
[clangd] Make sure ReplyCallbacks are destroyed before RequestCancelersMutex
Wed, Oct 9, 7:02 AM
kadircet updated the summary of D68702: [clangd] Make sure ReplyCallbacks are destroyed before RequestCancelersMutex.
Wed, Oct 9, 7:01 AM · Restricted Project
kadircet updated the diff for D68702: [clangd] Make sure ReplyCallbacks are destroyed before RequestCancelersMutex.
  • Address comments
Wed, Oct 9, 7:01 AM · Restricted Project
kadircet created D68702: [clangd] Make sure ReplyCallbacks are destroyed before RequestCancelersMutex.
Wed, Oct 9, 6:23 AM · Restricted Project
kadircet committed rG1bb91093e7c3: [clangd] Propagate context into reply handlers (authored by kadircet).
[clangd] Propagate context into reply handlers
Wed, Oct 9, 5:50 AM
kadircet committed rL374163: [clangd] Propagate context into reply handlers.
[clangd] Propagate context into reply handlers
Wed, Oct 9, 5:49 AM

Tue, Oct 8

kadircet committed rG3c4646194ede: [clangd] Bump timeouts in speculative completion tests (authored by kadircet).
[clangd] Bump timeouts in speculative completion tests
Tue, Oct 8, 7:01 AM
kadircet committed rL374047: [clangd] Bump timeouts in speculative completion tests.
[clangd] Bump timeouts in speculative completion tests
Tue, Oct 8, 6:52 AM
kadircet committed rG18b6fe07bcf4: [LoopVectorize] Fix non-debug builds after rL374017 (authored by kadircet).
[LoopVectorize] Fix non-debug builds after rL374017
Tue, Oct 8, 12:39 AM
kadircet committed rL374021: [LoopVectorize] Fix non-debug builds after rL374017.
[LoopVectorize] Fix non-debug builds after rL374017
Tue, Oct 8, 12:38 AM

Mon, Oct 7

kadircet committed rGde8599776b52: [clangd] Fix raciness in code completion tests (authored by kadircet).
[clangd] Fix raciness in code completion tests
Mon, Oct 7, 10:15 PM
kadircet committed rL373924: [clangd] Fix raciness in code completion tests.
[clangd] Fix raciness in code completion tests
Mon, Oct 7, 10:15 PM
kadircet closed D68273: [clangd] Fix raciness in code completion tests.
Mon, Oct 7, 10:15 PM · Restricted Project, Restricted Project
kadircet added inline comments to D66647: [clangd] DefineInline action apply logic with fully qualified names.
Mon, Oct 7, 9:38 AM · Restricted Project
kadircet updated the diff for D66647: [clangd] DefineInline action apply logic with fully qualified names.
  • Address comments
Mon, Oct 7, 9:31 AM · Restricted Project
kadircet accepted D68564: [clangd] Catch an unchecked "Expected<T>" in HeaderSourceSwitch..

LGTM

Mon, Oct 7, 3:14 AM · Restricted Project, Restricted Project

Wed, Oct 2

kadircet updated the diff for D66647: [clangd] DefineInline action apply logic with fully qualified names.
  • Update test helper to take an out parameter
Wed, Oct 2, 12:41 PM · Restricted Project
kadircet added inline comments to D68273: [clangd] Fix raciness in code completion tests.
Wed, Oct 2, 12:32 PM · Restricted Project, Restricted Project
kadircet updated the diff for D68273: [clangd] Fix raciness in code completion tests.
  • Address comments
Wed, Oct 2, 12:32 PM · Restricted Project, Restricted Project
kadircet committed rGe95e5165960e: [clangd] Always send file URIs to editors (authored by kadircet).
[clangd] Always send file URIs to editors
Wed, Oct 2, 2:11 AM
kadircet committed rL373435: [clangd] Always send file URIs to editors.
[clangd] Always send file URIs to editors
Wed, Oct 2, 2:11 AM
kadircet closed D68324: [clangd] Always send file URIs to editors.
Wed, Oct 2, 2:11 AM · Restricted Project, Restricted Project
kadircet added a reviewer for D68324: [clangd] Always send file URIs to editors: sammccall.
Wed, Oct 2, 1:57 AM · Restricted Project, Restricted Project
kadircet created D68324: [clangd] Always send file URIs to editors.
Wed, Oct 2, 1:57 AM · Restricted Project, Restricted Project

Tue, Oct 1

kadircet updated the diff for D68273: [clangd] Fix raciness in code completion tests.
  • As discussed offline, making consumeRequests take an argument for how many requests to receive before returning.
Tue, Oct 1, 7:52 AM · Restricted Project, Restricted Project
kadircet created D68273: [clangd] Fix raciness in code completion tests.
Tue, Oct 1, 7:34 AM · Restricted Project, Restricted Project
kadircet committed rGfd019ed54e36: [clang] Make handling of unnamed template params similar to function params (authored by kadircet).
[clang] Make handling of unnamed template params similar to function params
Tue, Oct 1, 7:11 AM
kadircet committed rL373340: [clang] Make handling of unnamed template params similar to function params.
[clang] Make handling of unnamed template params similar to function params
Tue, Oct 1, 7:11 AM
kadircet closed D68143: [clang] Make handling of unnamed template params similar to function params.
Tue, Oct 1, 7:11 AM · Restricted Project, Restricted Project
kadircet updated the diff for D68024: [clangd] Implement GetEligiblePoints.
  • Address comments
Tue, Oct 1, 4:28 AM · Restricted Project
kadircet updated the diff for D68143: [clang] Make handling of unnamed template params similar to function params.
  • Address comments
Tue, Oct 1, 3:42 AM · Restricted Project, Restricted Project
kadircet added inline comments to D68143: [clang] Make handling of unnamed template params similar to function params.
Tue, Oct 1, 3:33 AM · Restricted Project, Restricted Project
kadircet added inline comments to D68182: [Clangd] Ensure children are always RootStmt in ExtractFunction (Fixes #153).
Tue, Oct 1, 3:04 AM · Restricted Project, Restricted Project
kadircet accepted D68245: [Clangd] ExtractFunction: Don't extract body of enclosing function..

LGTM, thanks

Tue, Oct 1, 2:36 AM · Restricted Project, Restricted Project
kadircet accepted D68137: [clangd] Handle template arguments in findExplicitReferences.

LGTM, thanks!

Tue, Oct 1, 2:33 AM · Restricted Project, Restricted Project
kadircet added inline comments to D68143: [clang] Make handling of unnamed template params similar to function params.
Tue, Oct 1, 2:30 AM · Restricted Project, Restricted Project
kadircet updated the diff for D68143: [clang] Make handling of unnamed template params similar to function params.
  • Address comments
Tue, Oct 1, 2:30 AM · Restricted Project, Restricted Project
kadircet updated the diff for D66647: [clangd] DefineInline action apply logic with fully qualified names.
  • Fix getSemiColon to handle semicolons at the end of file
Tue, Oct 1, 2:05 AM · Restricted Project
kadircet created D68261: [clangd] Add "inline" keyword to prevent ODR-violations in DefineInline.
Tue, Oct 1, 1:40 AM · Restricted Project

Mon, Sep 30

kadircet accepted D68211: [clangd] Use the index-based API to do the header-source switch..

some nits, thanks!

Mon, Sep 30, 7:59 AM · Restricted Project, Restricted Project
kadircet updated the diff for D68024: [clangd] Implement GetEligiblePoints.
  • Address comments
Mon, Sep 30, 7:54 AM · Restricted Project
kadircet added inline comments to D68024: [clangd] Implement GetEligiblePoints.
Mon, Sep 30, 7:54 AM · Restricted Project
kadircet added a comment to D68211: [clangd] Use the index-based API to do the header-source switch..

thanks, mostly LG

Mon, Sep 30, 7:37 AM · Restricted Project, Restricted Project
kadircet added inline comments to D68137: [clangd] Handle template arguments in findExplicitReferences.
Mon, Sep 30, 5:14 AM · Restricted Project, Restricted Project

Fri, Sep 27

kadircet added inline comments to D68024: [clangd] Implement GetEligiblePoints.
Fri, Sep 27, 9:35 AM · Restricted Project
kadircet accepted D68124: [clangd] Fix template type aliases in findExplicitReference.

LGTM.

Fri, Sep 27, 9:28 AM · Restricted Project, Restricted Project
kadircet accepted D67907: [clangd] Implement a smart version of HeaderSource switch..

thanks for formatting test cases, I had it in mind but forgot to mention in last round.

Fri, Sep 27, 9:24 AM · Restricted Project, Restricted Project
kadircet created D68143: [clang] Make handling of unnamed template params similar to function params.
Fri, Sep 27, 8:39 AM · Restricted Project, Restricted Project
kadircet added a comment to D66647: [clangd] DefineInline action apply logic with fully qualified names.

We also need to rename parameters sometimes, right?

// Sometimes we need to rename parameters.
void usages(int decl_param, int);

void usages(int def_param, int now_named) {
  llvm::errs() << def_param + now_named;
}

// And template parameters! (these are even more interesting)
template <class T>
struct Foo {
  template <class U, class>
  void usages();
};
template <class L>
template <class R, class NowNamed>
void Foo<L>::usages() {
  llvm::errs() << L() + R() + NowNamed();
}
Fri, Sep 27, 8:33 AM · Restricted Project
kadircet updated the diff for D66647: [clangd] DefineInline action apply logic with fully qualified names.
  • Add renaming of template and function parameters
Fri, Sep 27, 8:33 AM · Restricted Project
kadircet updated the diff for D65433: [clangd] DefineInline action availability checks.
  • Rebase and bail out on methods inside templated classes
Fri, Sep 27, 6:11 AM · Restricted Project
kadircet added inline comments to D68024: [clangd] Implement GetEligiblePoints.
Fri, Sep 27, 6:11 AM · Restricted Project
kadircet added a comment to D66647: [clangd] DefineInline action apply logic with fully qualified names.

Are we planning to fix this right away or should we keep this indefinitely?
If latter, I believe we should think about some heuristics to avoid qualification in the short term instead.
If we want to do it right away, that's great! (albeit more complicated, I guess)

Fri, Sep 27, 2:33 AM · Restricted Project
kadircet added inline comments to D68124: [clangd] Fix template type aliases in findExplicitReference.
Fri, Sep 27, 2:30 AM · Restricted Project, Restricted Project
kadircet added a comment to D66647: [clangd] DefineInline action apply logic with fully qualified names.

It's ok to leave this out of the initial change, but could we describe our strategy to tackle this somewhere in the comments - how we want to fix this and when.

Fri, Sep 27, 2:05 AM · Restricted Project
kadircet updated the diff for D66647: [clangd] DefineInline action apply logic with fully qualified names.
  • Address comments
Fri, Sep 27, 2:05 AM · Restricted Project
kadircet added a comment to D67907: [clangd] Implement a smart version of HeaderSource switch..

mostly LG, a few small comments

Fri, Sep 27, 1:36 AM · Restricted Project, Restricted Project
kadircet accepted D68118: [clangd] Support OverloadExpr in findExplicitReferences.
Fri, Sep 27, 1:00 AM · Restricted Project, Restricted Project
kadircet accepted D68120: [clangd] Handle type template parameters in findExplicitReferences.

LGTM. what about template template and non-type template params ?

Fri, Sep 27, 12:57 AM · Restricted Project, Restricted Project

Thu, Sep 26

kadircet updated the diff for D65433: [clangd] DefineInline action availability checks.
  • Use canonical decl when checking visibility
Thu, Sep 26, 7:36 AM · Restricted Project
kadircet updated the diff for D68024: [clangd] Implement GetEligiblePoints.
  • Address comments
Thu, Sep 26, 4:43 AM · Restricted Project