kadircet (Kadir Cetinkaya)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 14 2018, 2:16 AM (34 w, 6 d)

Recent Activity

Today

kadircet updated the diff for D52301: [clang] Set TypeSourceInfo for vardecl's in addition to type when we can deduce..

rebase

Tue, Oct 16, 1:36 PM
kadircet accepted D53266: [clangd] Simplify client capabilities parsing..

LGTM, thanks for the change!

Tue, Oct 16, 12:00 PM
kadircet accepted D53213: [clangd] Send CodeAction responses to textDocument/codeAction (LSP 3.8).

LGTM, thanks!

Tue, Oct 16, 8:54 AM

Fri, Oct 12

kadircet added inline comments to D53213: [clangd] Send CodeAction responses to textDocument/codeAction (LSP 3.8).
Fri, Oct 12, 10:33 PM
kadircet added a dependency for D53192: [clangd] Do not query index for new name completions.: D53191: [clang] Use Statement and Namespace instead of Name and PotentiallyQualifiedName.
Fri, Oct 12, 5:10 AM
kadircet added a dependent revision for D53191: [clang] Use Statement and Namespace instead of Name and PotentiallyQualifiedName: D53192: [clangd] Do not query index for new name completions..
Fri, Oct 12, 5:10 AM
kadircet updated the diff for D53191: [clang] Use Statement and Namespace instead of Name and PotentiallyQualifiedName.
  • Use statement as context for using decls.
Fri, Oct 12, 5:09 AM
kadircet created D53192: [clangd] Do not query index for new name completions..
Fri, Oct 12, 5:07 AM
kadircet created D53191: [clang] Use Statement and Namespace instead of Name and PotentiallyQualifiedName.
Fri, Oct 12, 5:02 AM
kadircet accepted D53186: [clangd] Support hover on "aut^o *"..

LGTM, thanks!

Fri, Oct 12, 2:21 AM

Wed, Oct 10

kadircet accepted D53070: [CodeComplete] Fix crash when completing params function declarations..

LGTM, thanks!

Wed, Oct 10, 3:50 AM

Tue, Oct 9

kadircet committed rCTE344033: [clangd] Mark colon as a safe character when percent-encoding..
[clangd] Mark colon as a safe character when percent-encoding.
Tue, Oct 9, 3:31 AM
kadircet committed rL344033: [clangd] Mark colon as a safe character when percent-encoding..
[clangd] Mark colon as a safe character when percent-encoding.
Tue, Oct 9, 3:31 AM
kadircet closed D53016: [clangd] Mark colon as a safe character when percent-encoding..
Tue, Oct 9, 3:31 AM
kadircet updated the diff for D53016: [clangd] Mark colon as a safe character when percent-encoding..
  • Add comments.
Tue, Oct 9, 3:30 AM
kadircet committed rL344025: [clangd] Revert back to previous heuristic for diagnostic range extraction..
[clangd] Revert back to previous heuristic for diagnostic range extraction.
Tue, Oct 9, 1:44 AM
kadircet committed rCTE344025: [clangd] Revert back to previous heuristic for diagnostic range extraction..
[clangd] Revert back to previous heuristic for diagnostic range extraction.
Tue, Oct 9, 1:44 AM
kadircet closed D52889: [clangd] Revert back to previous heuristic for diagnostic range extraction..
Tue, Oct 9, 1:44 AM
kadircet retitled D52889: [clangd] Revert back to previous heuristic for diagnostic range extraction. from [clangd] Add new test to cover no_member diag. to [clangd] Revert back to previous heuristic for diagnostic range extraction..
Tue, Oct 9, 1:41 AM
kadircet abandoned D52890: [clang] Report range of the missing-memmber on no_member diagnostic..
Tue, Oct 9, 1:39 AM
kadircet updated the diff for D52889: [clangd] Revert back to previous heuristic for diagnostic range extraction..
  • Revert to previous heuristic with special handling of empty fixit range.
Tue, Oct 9, 1:38 AM
kadircet created D53016: [clangd] Mark colon as a safe character when percent-encoding..
Tue, Oct 9, 1:25 AM

Thu, Oct 4

kadircet retitled D52890: [clang] Report range of the missing-memmber on no_member diagnostic. from Also report range for the name token on no_member error. to [clang] Report range of the missing-memmber on no_member diagnostic..
Thu, Oct 4, 8:59 AM
kadircet added a dependent revision for D52890: [clang] Report range of the missing-memmber on no_member diagnostic.: D52889: [clangd] Revert back to previous heuristic for diagnostic range extraction..
Thu, Oct 4, 8:58 AM
kadircet added a dependency for D52889: [clangd] Revert back to previous heuristic for diagnostic range extraction.: D52890: [clang] Report range of the missing-memmber on no_member diagnostic..
Thu, Oct 4, 8:58 AM
kadircet created D52890: [clang] Report range of the missing-memmber on no_member diagnostic..
Thu, Oct 4, 8:58 AM
kadircet added reviewers for D52889: [clangd] Revert back to previous heuristic for diagnostic range extraction.: sammccall, ilya-biryukov.
Thu, Oct 4, 8:58 AM
kadircet updated the summary of D52889: [clangd] Revert back to previous heuristic for diagnostic range extraction..
Thu, Oct 4, 8:58 AM
kadircet created D52889: [clangd] Revert back to previous heuristic for diagnostic range extraction..
Thu, Oct 4, 8:58 AM

Tue, Oct 2

kadircet committed rL343568: [clang] Implement Override Suggestions in Sema..
[clang] Implement Override Suggestions in Sema.
Tue, Oct 2, 2:44 AM
kadircet committed rC343568: [clang] Implement Override Suggestions in Sema..
[clang] Implement Override Suggestions in Sema.
Tue, Oct 2, 2:44 AM
kadircet closed D52225: [clang] Implement Override Suggestions in Sema..
Tue, Oct 2, 2:44 AM
kadircet committed rL343567: [clangd] Remove override result handling logic from clangd.
[clangd] Remove override result handling logic from clangd
Tue, Oct 2, 2:44 AM
kadircet committed rCTE343567: [clangd] Remove override result handling logic from clangd.
[clangd] Remove override result handling logic from clangd
Tue, Oct 2, 2:44 AM
kadircet closed D52226: [clangd] Remove override result handling logic from clangd.
Tue, Oct 2, 2:44 AM

Mon, Oct 1

kadircet updated the diff for D52301: [clang] Set TypeSourceInfo for vardecl's in addition to type when we can deduce..

rebase & ping

Mon, Oct 1, 6:12 AM
kadircet updated the diff for D52225: [clang] Implement Override Suggestions in Sema..
  • Add a fixme on limitation.
Mon, Oct 1, 6:09 AM
kadircet added inline comments to D52225: [clang] Implement Override Suggestions in Sema..
Mon, Oct 1, 5:22 AM
kadircet updated the diff for D52225: [clang] Implement Override Suggestions in Sema..
  • Fix a bug and address comments.
Mon, Oct 1, 5:22 AM
kadircet added inline comments to D52225: [clang] Implement Override Suggestions in Sema..
Mon, Oct 1, 4:46 AM
kadircet updated the diff for D52225: [clang] Implement Override Suggestions in Sema..
  • Address comments.
Mon, Oct 1, 4:46 AM
kadircet added a comment to D52225: [clang] Implement Override Suggestions in Sema..

ping

Mon, Oct 1, 2:01 AM

Thu, Sep 27

kadircet committed rL343237: Introduce completionItemKind capability support..
Introduce completionItemKind capability support.
Thu, Sep 27, 10:16 AM
kadircet committed rCTE343237: Introduce completionItemKind capability support..
Introduce completionItemKind capability support.
Thu, Sep 27, 10:16 AM
kadircet closed D52616: Introduce completionItemKind capability support..
Thu, Sep 27, 10:16 AM
kadircet updated the diff for D52616: Introduce completionItemKind capability support..
  • Address comments.
Thu, Sep 27, 10:09 AM
kadircet updated the diff for D52616: Introduce completionItemKind capability support..
  • Minimum CompletionItemKind is Text.
Thu, Sep 27, 8:27 AM
kadircet created D52616: Introduce completionItemKind capability support..
Thu, Sep 27, 8:19 AM
kadircet committed rL343221: Tell whether file/folder for include completions..
Tell whether file/folder for include completions.
Thu, Sep 27, 7:23 AM
kadircet committed rCTE343221: Tell whether file/folder for include completions..
Tell whether file/folder for include completions.
Thu, Sep 27, 7:22 AM
kadircet closed D52547: Tell whether file/folder for include completions..
Thu, Sep 27, 7:22 AM
kadircet updated the diff for D52547: Tell whether file/folder for include completions..

Preparing the patch to respect client capabilities.

  • Add other itemkinds as well.
  • Address comments.
Thu, Sep 27, 7:22 AM
kadircet added a comment to D52547: Tell whether file/folder for include completions..

A drive-by comment.
Would it be cleaner to pass this information from clang? Relying on completion label seems shaky.

Thu, Sep 27, 5:43 AM
kadircet committed rCTE343197: Improve diagnostics range reporting..
Improve diagnostics range reporting.
Thu, Sep 27, 5:16 AM
kadircet committed rL343197: Improve diagnostics range reporting..
Improve diagnostics range reporting.
Thu, Sep 27, 5:16 AM
kadircet closed D52544: Improve diagnostics range reporting..
Thu, Sep 27, 5:16 AM
kadircet added inline comments to D52544: Improve diagnostics range reporting..
Thu, Sep 27, 5:04 AM
kadircet updated the diff for D52544: Improve diagnostics range reporting..
  • Address comments.
Thu, Sep 27, 5:03 AM

Wed, Sep 26

kadircet created D52547: Tell whether file/folder for include completions..
Wed, Sep 26, 6:15 AM
kadircet created D52544: Improve diagnostics range reporting..
Wed, Sep 26, 5:16 AM
kadircet accepted D52517: [clangd] clangd-indexer: Drop support for MR-via-YAML.

LGTM

Wed, Sep 26, 1:49 AM
kadircet updated the diff for D52226: [clangd] Remove override result handling logic from clangd.
  • Remove test, since it has been moved into Sema.
Wed, Sep 26, 1:20 AM
kadircet updated the diff for D52225: [clang] Implement Override Suggestions in Sema..
  • Change order of fucntions for better diff.
  • Add tests.
Wed, Sep 26, 1:11 AM

Tue, Sep 25

kadircet accepted D52465: [clangd] Extract mapper logic from clangd-indexer into a library..

LGTM, thanks for factoring out this to a library.

Tue, Sep 25, 9:50 AM
kadircet accepted D52422: [clangd] Handle template args for disabled function arg snippets.

LGTM

Tue, Sep 25, 1:55 AM

Thu, Sep 20

kadircet created D52301: [clang] Set TypeSourceInfo for vardecl's in addition to type when we can deduce..
Thu, Sep 20, 6:31 AM

Wed, Sep 19

kadircet committed rL342533: [clangd] Add option to enable/disable function argument snippets..
[clangd] Add option to enable/disable function argument snippets.
Wed, Sep 19, 3:19 AM
kadircet committed rCTE342533: [clangd] Add option to enable/disable function argument snippets..
[clangd] Add option to enable/disable function argument snippets.
Wed, Sep 19, 3:19 AM
kadircet closed D51214: [clangd] Add option to enable/disable function argument snippets..
Wed, Sep 19, 3:19 AM
kadircet retitled D51214: [clangd] Add option to enable/disable function argument snippets. from [clangd] Add options to enable/disable fixits and function argument snippets. to [clangd] Add option to enable/disable function argument snippets..
Wed, Sep 19, 1:30 AM
kadircet added inline comments to D51214: [clangd] Add option to enable/disable function argument snippets..
Wed, Sep 19, 1:26 AM
kadircet updated the diff for D51214: [clangd] Add option to enable/disable function argument snippets..
  • Delete include fixit option.
  • Rebase
Wed, Sep 19, 1:26 AM

Tue, Sep 18

kadircet added a dependency for D52226: [clangd] Remove override result handling logic from clangd: D52225: [clang] Implement Override Suggestions in Sema..
Tue, Sep 18, 3:32 AM
kadircet added a dependent revision for D52225: [clang] Implement Override Suggestions in Sema.: D52226: [clangd] Remove override result handling logic from clangd.
Tue, Sep 18, 3:32 AM
kadircet created D52226: [clangd] Remove override result handling logic from clangd.
Tue, Sep 18, 3:32 AM
kadircet created D52225: [clang] Implement Override Suggestions in Sema..
Tue, Sep 18, 3:25 AM

Sep 14 2018

kadircet accepted D52089: [clangd] Get rid of AST matchers in SymbolCollector. NFC.

LGTM

Sep 14 2018, 6:19 AM
kadircet added a comment to D51747: [clangd] Show deprecation diagnostics.

Np, not planning to land it before we figure out the issue with vim can't handling lots of diagnostics anyway.

Just wondering: what's the problem with Vim? Slowness? Bad UI for diagnostics when there are many of those?

Sep 14 2018, 3:25 AM
kadircet updated the diff for D51747: [clangd] Show deprecation diagnostics.
  • Add matchers to test.
Sep 14 2018, 3:25 AM

Sep 13 2018

kadircet added a comment to D51747: [clangd] Show deprecation diagnostics.

Sorry for all the back and forth on this patch, but I have to ask... what's up with switching to lit tests?

We've mostly started avoiding these as they're hard to maintain and debug (not to mention write... crazy sed tricks!)

They're mostly used in places where we need to test specifically the protocol (smoke testing features, startup/shutdown, protocol edge cases...)

Sorry my bad actually forgot to mention. We set additional flags in ClangdServer::getCompileCommand and it is not used on the path of TestTU actually, instead it creates its own command line flags and uses them to invoke the compiler. So I changed to lit tests to make sure it gets invoked through getCompileCommand

Ah, that's unfortunate :-(
Sorry to be a pain, but can these be in ClangdTests instead? (Should really be called ClangdServerTests). It's not as nice as TestTU, but...

Sep 13 2018, 8:21 AM
kadircet updated the diff for D51747: [clangd] Show deprecation diagnostics.
  • Turn back to unit tests.
Sep 13 2018, 8:20 AM
kadircet added a comment to D51747: [clangd] Show deprecation diagnostics.

Sorry for all the back and forth on this patch, but I have to ask... what's up with switching to lit tests?

We've mostly started avoiding these as they're hard to maintain and debug (not to mention write... crazy sed tricks!)

They're mostly used in places where we need to test specifically the protocol (smoke testing features, startup/shutdown, protocol edge cases...)

Sep 13 2018, 7:24 AM
kadircet planned changes to D51747: [clangd] Show deprecation diagnostics.

When doing some manual testing saw that it causes a lot of slow down on vim, even when I have just about 200 diagnostics, will wait till a few others check that out. We might wanna limit the number of diagnostics and keep only the ones that are closest to current cursor position.

Sep 13 2018, 6:59 AM
kadircet updated the diff for D51747: [clangd] Show deprecation diagnostics.
  • Convert unit tests to lit tests and address comments.
Sep 13 2018, 6:57 AM
kadircet added inline comments to D51725: Allow un-setting the compilation database path.
Sep 13 2018, 6:18 AM
kadircet retitled D51747: [clangd] Show deprecation diagnostics from [clangd] Implement deprecation diagnostics with lower severity. to [clangd] Show deprecation diagnostics.
Sep 13 2018, 6:02 AM
kadircet added inline comments to D51747: [clangd] Show deprecation diagnostics.
Sep 13 2018, 5:59 AM
kadircet updated the diff for D51747: [clangd] Show deprecation diagnostics.
  • Do not show up as errors even on codebases with -Werror.
Sep 13 2018, 5:59 AM
kadircet accepted D52004: [clangd] Allow all LSP methods to signal cancellation via $/cancelRequest.

LGTM, thanks!

Sep 13 2018, 5:40 AM
kadircet updated the diff for D51747: [clangd] Show deprecation diagnostics.
  • Resolve discussions.
Sep 13 2018, 4:53 AM
kadircet added a comment to D51747: [clangd] Show deprecation diagnostics.

As discussed offline with Ilya, decided to keep the compile flag addition since it would be easier to pass the logic of a command line flag to that point. Also not changing the severity level, since they will show up on diagnostics lists in anyway it doesn't save much.

Sep 13 2018, 4:53 AM
kadircet accepted D51996: [clangd] Simplify cancellation public API.

LGTM

Sep 13 2018, 12:58 AM

Sep 12 2018

kadircet added a comment to D52004: [clangd] Allow all LSP methods to signal cancellation via $/cancelRequest.

Wonder if we can still keep the onCancelRequest registry within ProtocolHandler's scope, so that it is clear that we implement it. Other than that seems fascinating, thanks!

Sep 12 2018, 3:01 PM
kadircet added a comment to D51996: [clangd] Simplify cancellation public API.

Seems a lot cleaner now, thanks!

Sep 12 2018, 2:10 PM

Sep 11 2018

kadircet committed rCTE341950: [clangd] Add unittests for D51917.
[clangd] Add unittests for D51917
Sep 11 2018, 8:13 AM
kadircet committed rL341950: [clangd] Add unittests for D51917.
[clangd] Add unittests for D51917
Sep 11 2018, 8:13 AM
kadircet closed D51924: [clangd] Add unittests for D51917.
Sep 11 2018, 8:13 AM
kadircet committed rL341949: [CodeCompletion] Enable signature help when initializing class/struct/union….
[CodeCompletion] Enable signature help when initializing class/struct/union…
Sep 11 2018, 8:05 AM
kadircet committed rC341949: [CodeCompletion] Enable signature help when initializing class/struct/union….
[CodeCompletion] Enable signature help when initializing class/struct/union…
Sep 11 2018, 8:05 AM
kadircet closed D51917: [CodeCompletion] Enable signature help when initializing class/struct/union members..
Sep 11 2018, 8:05 AM