Page MenuHomePhabricator

kadircet (Kadir Cetinkaya)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 14 2018, 2:16 AM (79 w, 2 d)

Recent Activity

Today

kadircet updated the diff for D66637: [clangd] Support multifile edits as output of Tweaks.
  • Address comments
Fri, Aug 23, 6:38 AM · Restricted Project
kadircet added a parent revision for D66647: [clangd] DefineInline action apply logic with fully qualified names: D65433: [clangd] DefineInline action availability checks.
Fri, Aug 23, 5:48 AM · Restricted Project
kadircet added a child revision for D66637: [clangd] Support multifile edits as output of Tweaks: D65433: [clangd] DefineInline action availability checks.
Fri, Aug 23, 5:48 AM · Restricted Project
kadircet added a child revision for D65433: [clangd] DefineInline action availability checks: D66647: [clangd] DefineInline action apply logic with fully qualified names.
Fri, Aug 23, 5:48 AM · Restricted Project
kadircet added a reviewer for D65433: [clangd] DefineInline action availability checks: ilya-biryukov.
Fri, Aug 23, 5:48 AM · Restricted Project
kadircet added a parent revision for D65433: [clangd] DefineInline action availability checks: D66637: [clangd] Support multifile edits as output of Tweaks.
Fri, Aug 23, 5:48 AM · Restricted Project
kadircet created D66647: [clangd] DefineInline action apply logic with fully qualified names.
Fri, Aug 23, 5:48 AM · Restricted Project
kadircet added a reviewer for D66637: [clangd] Support multifile edits as output of Tweaks: ilya-biryukov.
Fri, Aug 23, 5:48 AM · Restricted Project
kadircet added inline comments to D66637: [clangd] Support multifile edits as output of Tweaks.
Fri, Aug 23, 5:38 AM · Restricted Project
kadircet updated the diff for D65433: [clangd] DefineInline action availability checks.
  • Rebase
Fri, Aug 23, 5:29 AM · Restricted Project
kadircet created D66637: [clangd] Support multifile edits as output of Tweaks.
Fri, Aug 23, 3:47 AM · Restricted Project

Tue, Aug 20

kadircet planned changes to D64718: [clangd] Triggering indexing on each translation unit with an error.

this requires keeping an inverted dependency graph, which can be quite expensive memory-wise.
In a project like chromium there are ~40k translation units, and it is safe to assume there are ~1k core headers just coming from std library,
that are most likely included by all of the translation units directly or transatively. This results in ~320MB of memory usage even if we just
store a pointer.

Tue, Aug 20, 3:32 AM · Restricted Project
kadircet added inline comments to D65526: [Clangd] First version of ExtractFunction.
Tue, Aug 20, 3:25 AM · Restricted Project
kadircet accepted D66226: [clangd] Skip function bodies inside processed files while indexing.
Tue, Aug 20, 1:37 AM · Restricted Project, Restricted Project
kadircet added a comment to D66226: [clangd] Skip function bodies inside processed files while indexing.

This looks great, thanks!

Tue, Aug 20, 12:34 AM · Restricted Project, Restricted Project

Wed, Jul 31

kadircet accepted D65486: [clangd] Ignore semicolons, whitespace, and comments in SelectionTree..

Thanks for the comments, LGTM!

Wed, Jul 31, 6:20 AM · Restricted Project, Restricted Project

Tue, Jul 30

kadircet committed rG38496d5bd9a0: [clangd] Ignore diags from builtin files (authored by kadircet).
[clangd] Ignore diags from builtin files
Tue, Jul 30, 3:30 AM
kadircet committed rL367303: [clangd] Ignore diags from builtin files.
[clangd] Ignore diags from builtin files
Tue, Jul 30, 3:26 AM
kadircet closed D64863: [clangd] Ignore diags from builtin files.
Tue, Jul 30, 3:26 AM · Restricted Project, Restricted Project
kadircet updated the diff for D64863: [clangd] Ignore diags from builtin files.
  • Address comments
Tue, Jul 30, 3:22 AM · Restricted Project, Restricted Project
kadircet added a reviewer for D65433: [clangd] DefineInline action availability checks: sammccall.
Tue, Jul 30, 1:47 AM · Restricted Project
kadircet created D65433: [clangd] DefineInline action availability checks.
Tue, Jul 30, 1:46 AM · Restricted Project

Sun, Jul 28

kadircet added inline comments to D64863: [clangd] Ignore diags from builtin files.
Sun, Jul 28, 11:49 PM · Restricted Project, Restricted Project
kadircet updated the diff for D64863: [clangd] Ignore diags from builtin files.
  • Always set LastDiagWasAdjusted.
Sun, Jul 28, 11:49 PM · Restricted Project, Restricted Project

Jul 23 2019

kadircet accepted D65154: [clangd] Reformat use of cl::opt: use unqualified name and don't bin-pack attributes. NFC.

That LGTM, but i didn't have any bad feelings regarding the previous state. Since we tend to read those options in isolation and don't care about how they look like in general, but that might be just me.

Jul 23 2019, 11:50 AM · Restricted Project, Restricted Project

Jul 19 2019

kadircet added inline comments to D64863: [clangd] Ignore diags from builtin files.
Jul 19 2019, 9:20 AM · Restricted Project, Restricted Project
kadircet updated the diff for D64863: [clangd] Ignore diags from builtin files.
  • Address comments
Jul 19 2019, 7:45 AM · Restricted Project, Restricted Project
kadircet updated the diff for D64863: [clangd] Ignore diags from builtin files.
  • Move deduplication logic back into the flushLastDiag as discussed offline.
Jul 19 2019, 7:31 AM · Restricted Project, Restricted Project
kadircet committed rG9dc0160d2673: [clangd] Disable background-index on lit-tests by default (authored by kadircet).
[clangd] Disable background-index on lit-tests by default
Jul 19 2019, 6:41 AM
kadircet committed rL366575: [clangd] Disable background-index on lit-tests by default.
[clangd] Disable background-index on lit-tests by default
Jul 19 2019, 6:40 AM
kadircet closed D64990: [clangd] Disable background-index on lit-tests by default.
Jul 19 2019, 6:40 AM · Restricted Project, Restricted Project
kadircet created D64990: [clangd] Disable background-index on lit-tests by default.
Jul 19 2019, 6:29 AM · Restricted Project, Restricted Project
kadircet accepted D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs.

Thanks, LGTM from my side. Do you have any concerns @sammccall ?

Jul 19 2019, 5:00 AM · Restricted Project
kadircet added inline comments to D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs.
Jul 19 2019, 4:22 AM · Restricted Project
kadircet committed rG91e5f4b46b58: Revert "Revert r366458, r366467 and r366468" (authored by kadircet).
Revert "Revert r366458, r366467 and r366468"
Jul 19 2019, 3:20 AM
kadircet added a reverting change for rG9c377105da0b: Revert r366458, r366467 and r366468: rG91e5f4b46b58: Revert "Revert r366458, r366467 and r366468".
Jul 19 2019, 3:20 AM
kadircet committed rL366559: Revert "Revert r366458, r366467 and r366468".
Revert "Revert r366458, r366467 and r366468"
Jul 19 2019, 3:18 AM
kadircet closed D64980: [clangd][BackgroundIndexLoader] Directly store DependentTU while loading shard.
Jul 19 2019, 3:18 AM · Restricted Project, Restricted Project
kadircet added inline comments to D64863: [clangd] Ignore diags from builtin files.
Jul 19 2019, 2:54 AM · Restricted Project, Restricted Project
kadircet updated the diff for D64863: [clangd] Ignore diags from builtin files.
  • Add tests.
  • Change the layer we ignore the diags:
    • Mark diags from headers as insidemainfile when we decide to surface them.
Jul 19 2019, 2:54 AM · Restricted Project, Restricted Project
kadircet committed rGf3ae501d36eb: [clangd] Handle windows line endings in QueryDriver (authored by kadircet).
[clangd] Handle windows line endings in QueryDriver
Jul 19 2019, 2:11 AM
kadircet committed rL366545: [clangd] Handle windows line endings in QueryDriver.
[clangd] Handle windows line endings in QueryDriver
Jul 19 2019, 2:11 AM
kadircet closed D64970: [clangd] Handle windows line endings in QueryDriver.
Jul 19 2019, 2:11 AM · Restricted Project, Restricted Project, Restricted Project
kadircet created D64980: [clangd][BackgroundIndexLoader] Directly store DependentTU while loading shard.
Jul 19 2019, 2:02 AM · Restricted Project, Restricted Project

Jul 18 2019

kadircet accepted D64970: [clangd] Handle windows line endings in QueryDriver.

LGTM thanks!

Jul 18 2019, 11:17 PM · Restricted Project, Restricted Project, Restricted Project
kadircet committed rGcfa14ac2a776: [clangd] Remove dead code from BackgroundIndex (authored by kadircet).
[clangd] Remove dead code from BackgroundIndex
Jul 18 2019, 10:27 AM
kadircet committed rL366468: [clangd] Remove dead code from BackgroundIndex.
[clangd] Remove dead code from BackgroundIndex
Jul 18 2019, 10:26 AM
kadircet committed rG006d1915e2de: [clangd] BackgroundIndex stores shards to the closest project (authored by kadircet).
[clangd] BackgroundIndex stores shards to the closest project
Jul 18 2019, 10:24 AM
kadircet committed rL366467: [clangd] BackgroundIndex stores shards to the closest project.
[clangd] BackgroundIndex stores shards to the closest project
Jul 18 2019, 10:24 AM
kadircet closed D64745: [clangd] BackgroundIndex stores shards to the closest project.
Jul 18 2019, 10:24 AM · Restricted Project, Restricted Project
kadircet added inline comments to D64745: [clangd] BackgroundIndex stores shards to the closest project.
Jul 18 2019, 10:08 AM · Restricted Project, Restricted Project
kadircet updated the diff for D64745: [clangd] BackgroundIndex stores shards to the closest project.
  • Address comments
Jul 18 2019, 10:07 AM · Restricted Project, Restricted Project
kadircet committed rG40073f922a82: [clangd] Refactor background-index shard loading (authored by kadircet).
[clangd] Refactor background-index shard loading
Jul 18 2019, 9:26 AM
kadircet committed rL366458: [clangd] Refactor background-index shard loading.
[clangd] Refactor background-index shard loading
Jul 18 2019, 9:25 AM
kadircet closed D64712: [clangd] Refactor background-index shard loading.
Jul 18 2019, 9:25 AM · Restricted Project, Restricted Project
kadircet committed rG6d53adfffda8: [clangd] Get rid of dots and dotsdots within GlobalCompilationDatabase (authored by kadircet).
[clangd] Get rid of dots and dotsdots within GlobalCompilationDatabase
Jul 18 2019, 9:15 AM
kadircet committed rL366455: [clangd] Get rid of dots and dotsdots within GlobalCompilationDatabase.
[clangd] Get rid of dots and dotsdots within GlobalCompilationDatabase
Jul 18 2019, 9:14 AM
kadircet closed D64860: [clangd] Get rid of dots and dotsdots within GlobalCompilationDatabase.
Jul 18 2019, 9:14 AM · Restricted Project, Restricted Project
kadircet updated the diff for D64860: [clangd] Get rid of dots and dotsdots within GlobalCompilationDatabase.
  • Address comments
Jul 18 2019, 9:11 AM · Restricted Project, Restricted Project
kadircet updated the diff for D64712: [clangd] Refactor background-index shard loading.
  • Get rid of CachedShard
Jul 18 2019, 8:46 AM · Restricted Project, Restricted Project
kadircet updated the diff for D64712: [clangd] Refactor background-index shard loading.
  • Add comments
Jul 18 2019, 7:37 AM · Restricted Project, Restricted Project
kadircet accepted D64918: [ASTUnit] Fix a regression in cached completions.

LGTM from my side as well

Jul 18 2019, 7:01 AM · Restricted Project, Restricted Project
kadircet added inline comments to D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs.
Jul 18 2019, 6:47 AM · Restricted Project
kadircet added inline comments to D64712: [clangd] Refactor background-index shard loading.
Jul 18 2019, 6:00 AM · Restricted Project, Restricted Project
kadircet updated the diff for D64712: [clangd] Refactor background-index shard loading.
  • Address comments
Jul 18 2019, 6:00 AM · Restricted Project, Restricted Project
kadircet added inline comments to D64912: [Clangd] Changed ExtractVariable to only work on non empty selections.
Jul 18 2019, 5:57 AM · Restricted Project, Restricted Project
kadircet added inline comments to D64912: [Clangd] Changed ExtractVariable to only work on non empty selections.
Jul 18 2019, 4:48 AM · Restricted Project, Restricted Project
kadircet added a parent revision for D64718: [clangd] Triggering indexing on each translation unit with an error: D64712: [clangd] Refactor background-index shard loading.
Jul 18 2019, 3:16 AM · Restricted Project
kadircet added a parent revision for D64745: [clangd] BackgroundIndex stores shards to the closest project: D64712: [clangd] Refactor background-index shard loading.
Jul 18 2019, 3:16 AM · Restricted Project, Restricted Project
kadircet added child revisions for D64712: [clangd] Refactor background-index shard loading: D64745: [clangd] BackgroundIndex stores shards to the closest project, D64718: [clangd] Triggering indexing on each translation unit with an error.
Jul 18 2019, 3:16 AM · Restricted Project, Restricted Project
kadircet added a parent revision for D64712: [clangd] Refactor background-index shard loading: D64860: [clangd] Get rid of dots and dotsdots within GlobalCompilationDatabase.
Jul 18 2019, 3:15 AM · Restricted Project, Restricted Project
kadircet added a child revision for D64860: [clangd] Get rid of dots and dotsdots within GlobalCompilationDatabase: D64712: [clangd] Refactor background-index shard loading.
Jul 18 2019, 3:15 AM · Restricted Project, Restricted Project
kadircet added inline comments to D64712: [clangd] Refactor background-index shard loading.
Jul 18 2019, 3:02 AM · Restricted Project, Restricted Project
kadircet updated the diff for D64712: [clangd] Refactor background-index shard loading.
  • Address comments
Jul 18 2019, 3:00 AM · Restricted Project, Restricted Project
kadircet retitled D64712: [clangd] Refactor background-index shard loading from [clangd][NFC] Refactor background-index shard loading to [clangd] Refactor background-index shard loading.
Jul 18 2019, 12:55 AM · Restricted Project, Restricted Project
kadircet added inline comments to D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs.
Jul 18 2019, 12:55 AM · Restricted Project

Jul 17 2019

kadircet updated the summary of D64860: [clangd] Get rid of dots and dotsdots within GlobalCompilationDatabase.
Jul 17 2019, 10:09 AM · Restricted Project, Restricted Project
kadircet added inline comments to D64860: [clangd] Get rid of dots and dotsdots within GlobalCompilationDatabase.
Jul 17 2019, 9:55 AM · Restricted Project, Restricted Project
kadircet updated the diff for D64860: [clangd] Get rid of dots and dotsdots within GlobalCompilationDatabase.
  • Add removeDots helper to FS.h
  • Revert changes in getFallbackCommands.
  • Add comments for the reasoning behind removeDots calls.
Jul 17 2019, 9:55 AM · Restricted Project, Restricted Project
kadircet created D64863: [clangd] Ignore diags from builtin files.
Jul 17 2019, 6:21 AM · Restricted Project, Restricted Project
kadircet committed rG6011a285edf2: [clangd] Handle windows line endings in QueryDriver (authored by kadircet).
[clangd] Handle windows line endings in QueryDriver
Jul 17 2019, 6:16 AM
kadircet committed rL366320: [clangd] Handle windows line endings in QueryDriver.
[clangd] Handle windows line endings in QueryDriver
Jul 17 2019, 6:13 AM
kadircet closed D64789: [clangd] Handle windows line endings in QueryDriver.
Jul 17 2019, 6:13 AM · Restricted Project, Restricted Project
kadircet updated the diff for D64712: [clangd] Refactor background-index shard loading.
  • As discussed offline, moved the "staleness" detection back to background index
  • A renaming within Rebuilder, "LoadedTUs -> LoadedShards"
Jul 17 2019, 6:07 AM · Restricted Project, Restricted Project
kadircet accepted D64613: [clangd] Type hierarchy: don't resolve parents if the client only asked for children.

LGTM, thanks!

Jul 17 2019, 6:05 AM · Restricted Project, Restricted Project
kadircet accepted D64857: [clangd] Force the required interpretation of #import on windows tests..
Jul 17 2019, 6:05 AM · Restricted Project
kadircet created D64860: [clangd] Get rid of dots and dotsdots within GlobalCompilationDatabase.
Jul 17 2019, 5:57 AM · Restricted Project, Restricted Project

Jul 16 2019

kadircet created D64789: [clangd] Handle windows line endings in QueryDriver.
Jul 16 2019, 2:56 AM · Restricted Project, Restricted Project

Jul 15 2019

kadircet committed rG1d91f94f095b: [clangd] Fix doc (authored by kadircet).
[clangd] Fix doc
Jul 15 2019, 8:18 AM
kadircet committed rL366073: [clangd] Fix doc.
[clangd] Fix doc
Jul 15 2019, 8:16 AM
kadircet added inline comments to D58710: Added more detailed documentation for clangd.
Jul 15 2019, 8:12 AM · Restricted Project, Restricted Project
kadircet created D64745: [clangd] BackgroundIndex stores shards to the closest project.
Jul 15 2019, 7:47 AM · Restricted Project, Restricted Project
kadircet added inline comments to D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs.
Jul 15 2019, 7:05 AM · Restricted Project
kadircet added inline comments to D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs.
Jul 15 2019, 6:51 AM · Restricted Project
kadircet added inline comments to D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs.
Jul 15 2019, 5:54 AM · Restricted Project
kadircet added inline comments to D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs.
Jul 15 2019, 5:54 AM · Restricted Project
kadircet created D64718: [clangd] Triggering indexing on each translation unit with an error.
Jul 15 2019, 5:45 AM · Restricted Project
kadircet accepted D64677: [SemaTemplate] Fix uncorrected typos after pack expansion.
Jul 15 2019, 3:10 AM · Restricted Project
kadircet accepted D64682: [clangd] Don't rebuild background index until we indexed one TU per thread..
Jul 15 2019, 3:05 AM · Restricted Project
kadircet added inline comments to D64677: [SemaTemplate] Fix uncorrected typos after pack expansion.
Jul 15 2019, 2:23 AM · Restricted Project