Page MenuHomePhabricator

kadircet (Kadir Cetinkaya)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 14 2018, 2:16 AM (175 w, 1 d)

Recent Activity

Today

kadircet requested review of D104843: [clangd] Introduce a log-prefix flag to remote-index-server.
Thu, Jun 24, 2:38 AM · Restricted Project

Yesterday

kadircet requested review of D104841: [clangd] Call malloc_trim in clangd-index-server periodically.
Wed, Jun 23, 11:19 PM · Restricted Project

Tue, Jun 22

kadircet added inline comments to D104117: [clangd] Fix highlighting for implicit ObjC property refs.
Tue, Jun 22, 11:14 PM · Restricted Project
kadircet committed rG544d20eab662: [clangd] Dont index ObjCCategoryDecls for completion (authored by kadircet).
[clangd] Dont index ObjCCategoryDecls for completion
Tue, Jun 22, 1:43 PM
kadircet closed D104540: [clangd] Dont index ObjCCategoryDecls for completion.
Tue, Jun 22, 1:43 PM · Restricted Project
kadircet added inline comments to D104540: [clangd] Dont index ObjCCategoryDecls for completion.
Tue, Jun 22, 8:22 AM · Restricted Project
kadircet updated the diff for D104540: [clangd] Dont index ObjCCategoryDecls for completion.
  • Also handle ObjcCategoryImplDecl
Tue, Jun 22, 8:22 AM · Restricted Project

Fri, Jun 18

kadircet requested review of D104540: [clangd] Dont index ObjCCategoryDecls for completion.
Fri, Jun 18, 8:26 AM · Restricted Project

Thu, Jun 17

kadircet committed rG204014ec7557: [clangd] Fix feature modules to drop diagnostics (authored by kadircet).
[clangd] Fix feature modules to drop diagnostics
Thu, Jun 17, 12:30 AM
kadircet closed D103387: [clangd] Fix feature modules to drop diagnostics.
Thu, Jun 17, 12:30 AM · Restricted Project
kadircet committed rGb662651586be: [clangd] Use command line adjusters for inserting compile flags (authored by kadircet).
[clangd] Use command line adjusters for inserting compile flags
Thu, Jun 17, 12:25 AM
kadircet closed D99523: [clangd] Use command line adjusters for inserting compile flags.
Thu, Jun 17, 12:25 AM · Restricted Project
kadircet updated the diff for D103387: [clangd] Fix feature modules to drop diagnostics.
  • Bail out early before filling in diag info
  • Move isExcluded check into handleDiagnostics, rather than handling it during

flushing

Thu, Jun 17, 12:17 AM · Restricted Project

Tue, Jun 8

kadircet accepted D103825: [clang] Do not crash when ArgTy is null in CheckArgAlignment.

as discussed offline LG from my side.

Tue, Jun 8, 9:56 AM · Restricted Project
kadircet added inline comments to D103825: [clang] Do not crash when ArgTy is null in CheckArgAlignment.
Tue, Jun 8, 3:39 AM · Restricted Project

Mon, Jun 7

kadircet added a comment to D103797: [clang] Use resolved path for headers in decluse diagnostics.

It is the absolute path of the header. e.g:

Mon, Jun 7, 8:44 AM · Restricted Project
kadircet added a reviewer for D103797: [clang] Use resolved path for headers in decluse diagnostics: sammccall.
Mon, Jun 7, 7:45 AM · Restricted Project
kadircet updated the diff for D103797: [clang] Use resolved path for headers in decluse diagnostics.
  • handle windows paths in tests
Mon, Jun 7, 7:45 AM · Restricted Project
kadircet accepted D103393: [clangd] Bump recommended gRPC version (1.33.2 -> 1.36.3).

looks like the https://lab.llvm.org/buildbot/#/builders/131 is green after the version bump. thanks for taking care of this!

Mon, Jun 7, 5:20 AM · Restricted Project
kadircet committed rG4728aca9a8ad: [clangd] Drop TestTUs dependency on gtest (authored by kadircet).
[clangd] Drop TestTUs dependency on gtest
Mon, Jun 7, 4:26 AM
kadircet closed D103685: [clangd] Drop TestTUs dependency on gtest.
Mon, Jun 7, 4:25 AM · Restricted Project
kadircet updated the diff for D103685: [clangd] Drop TestTUs dependency on gtest.
  • Assert for daigs rather than abort.
Mon, Jun 7, 3:41 AM · Restricted Project
kadircet requested review of D103797: [clang] Use resolved path for headers in decluse diagnostics.
Mon, Jun 7, 2:59 AM · Restricted Project
kadircet added inline comments to D103685: [clangd] Drop TestTUs dependency on gtest.
Mon, Jun 7, 2:15 AM · Restricted Project
kadircet updated the diff for D103685: [clangd] Drop TestTUs dependency on gtest.
  • Use log + abort instead of llvm_unreachable to not rely on UB.
Mon, Jun 7, 2:15 AM · Restricted Project
kadircet accepted D103472: [clang] Fix a crash during code completion.

we discussed offline but i forgot to stamp this one. it would be nice to have a test case, but fix is relatively safe and getting a repro turned out to be hard (since it depends on a densemap growing).

Mon, Jun 7, 1:11 AM · Restricted Project

Fri, Jun 4

kadircet added a comment to D99540: [clangd] Preserve diags between tweak enumeration and execution.

Sorry I've lost my context - did we decide to move forward with this patch?

Fri, Jun 4, 8:24 AM · Restricted Project
kadircet requested review of D103685: [clangd] Drop TestTUs dependency on gtest.
Fri, Jun 4, 4:35 AM · Restricted Project

Wed, Jun 2

kadircet committed rG9e9ac4138890: [clangd] Drop optional on ExternalIndexSpec (authored by kadircet).
[clangd] Drop optional on ExternalIndexSpec
Wed, Jun 2, 2:27 PM
kadircet closed D100308: [clangd] Drop optional on ExternalIndexSpec.
Wed, Jun 2, 2:27 PM · Restricted Project
kadircet updated the diff for D100308: [clangd] Drop optional on ExternalIndexSpec.

Rebase

Wed, Jun 2, 2:26 PM · Restricted Project
kadircet added inline comments to D100308: [clangd] Drop optional on ExternalIndexSpec.
Wed, Jun 2, 2:22 PM · Restricted Project
kadircet updated the diff for D100308: [clangd] Drop optional on ExternalIndexSpec.

Add comment to IndexFactory about pre-condition of spec never being none.

Wed, Jun 2, 2:22 PM · Restricted Project
kadircet committed rGdc10bf1a4ed0: [clangd][Protocol] Drop optional from WorkspaceEdit::changes (authored by kadircet).
[clangd][Protocol] Drop optional from WorkspaceEdit::changes
Wed, Jun 2, 2:03 PM
kadircet closed D103449: [clangd][Protocol] Drop optional from WorkspaceEdit::changes.
Wed, Jun 2, 2:03 PM · Restricted Project
kadircet updated the diff for D103449: [clangd][Protocol] Drop optional from WorkspaceEdit::changes.

Get rid of the special case around empty changes.

Wed, Jun 2, 1:59 PM · Restricted Project
kadircet committed rG6c2a4e28f4d1: [clangd] TUScheduler uses last active file for file-less queries (authored by kadircet).
[clangd] TUScheduler uses last active file for file-less queries
Wed, Jun 2, 1:58 PM
kadircet closed D103476: [clangd] TUScheduler uses last active file for file-less queries.
Wed, Jun 2, 1:57 PM · Restricted Project
kadircet abandoned D103179: [clangd] Handle queries without an originating file in ProjectAwareIndex.

in favor of D103476

Wed, Jun 2, 1:52 PM · Restricted Project
kadircet updated the diff for D103476: [clangd] TUScheduler uses last active file for file-less queries.

Keep using Path in runWithSemaphore, by substituting LastActiveFile when empty.

Wed, Jun 2, 1:52 PM · Restricted Project
kadircet accepted D103538: [clangd] Run code completion on each token coverd by --check-lines.

A little bit thinking out loud, was there a particular reason to introduce --check-line into ClangdMain.cpp rather than Check.cpp?

Wed, Jun 2, 1:47 PM · Restricted Project

Tue, Jun 1

kadircet requested review of D103476: [clangd] TUScheduler uses last active file for file-less queries.
Tue, Jun 1, 11:10 AM · Restricted Project
kadircet added inline comments to D103387: [clangd] Fix feature modules to drop diagnostics.
Tue, Jun 1, 8:13 AM · Restricted Project
kadircet added inline comments to D99523: [clangd] Use command line adjusters for inserting compile flags.
Tue, Jun 1, 7:27 AM · Restricted Project
kadircet updated the diff for D99523: [clangd] Use command line adjusters for inserting compile flags.
  • Address comments
Tue, Jun 1, 7:27 AM · Restricted Project
kadircet requested review of D103449: [clangd][Protocol] Drop optional from WorkspaceEdit::changes.
Tue, Jun 1, 4:25 AM · Restricted Project

Mon, May 31

kadircet added a comment to D103393: [clangd] Bump recommended gRPC version (1.33.2 -> 1.36.3).

I think we should wait for build bot update on this one too. Otherwise we might miss some breakages.

Mon, May 31, 6:02 AM · Restricted Project
kadircet added a comment to D103377: [clangd] Add ability to change storage directory of index files.

Strictly speaking you could, assuming you have a compile database and it's okay to have copies or symlinks of the database.

Mon, May 31, 5:49 AM · Restricted Project
kadircet added a comment to D103377: [clangd] Add ability to change storage directory of index files.

I mainly added this because I am doing profiling of indexing and needed a way for multiple instances of index files not to conflict with each other.

Mon, May 31, 3:22 AM · Restricted Project
kadircet updated the diff for D103387: [clangd] Fix feature modules to drop diagnostics.

Get rid of LastDiagWasSuppressed state in StoreDiags

Mon, May 31, 1:54 AM · Restricted Project

Sun, May 30

kadircet updated the diff for D103387: [clangd] Fix feature modules to drop diagnostics.

Exit after introducing cleanup function

Sun, May 30, 11:49 PM · Restricted Project
kadircet requested review of D103387: [clangd] Fix feature modules to drop diagnostics.
Sun, May 30, 11:29 PM · Restricted Project
kadircet committed rGe97206884071: [clangd] Move gtest include to TestTU.cpp from TestTU.h (authored by kadircet).
[clangd] Move gtest include to TestTU.cpp from TestTU.h
Sun, May 30, 11:03 PM

Wed, May 26

kadircet added a comment to D103179: [clangd] Handle queries without an originating file in ProjectAwareIndex.

Note that I don't feel strongly about making use of Context to figure out config::Params vs moving the Params into the Config. But I'd rather not only store Path in the Config since we might end up needing other environment variables in future.

Wed, May 26, 9:18 AM · Restricted Project
kadircet requested review of D103179: [clangd] Handle queries without an originating file in ProjectAwareIndex.
Wed, May 26, 9:14 AM · Restricted Project
kadircet committed rG8f79203a22d8: [clangd] New ParsingCallback for semantics changes (authored by kadircet).
[clangd] New ParsingCallback for semantics changes
Wed, May 26, 8:02 AM
kadircet closed D102761: [clangd] New ParsingCallback for semantics changes.
Wed, May 26, 8:02 AM · Restricted Project

May 25 2021

kadircet added a comment to D102761: [clangd] New ParsingCallback for semantics changes.

It seems like a lit test for this would be terrible. A ClangdServer one should be possible, but I can't quite wrap my head around how to write it.
(Delivering the PreambleData as a param would make the test easier, you could assert that the preamble version was > any previously notified preamble & also > any preamble previously obtained via runWithPreamble.)

May 25 2021, 3:33 AM · Restricted Project
kadircet updated the diff for D102761: [clangd] New ParsingCallback for semantics changes.
  • s/onSemanticsMaybeChanged/onPreamblePublished
May 25 2021, 3:33 AM · Restricted Project

May 24 2021

kadircet edited reviewers for D102761: [clangd] New ParsingCallback for semantics changes, added: hokein; removed: adamcz.
May 24 2021, 11:07 PM · Restricted Project
kadircet added a reviewer for D102761: [clangd] New ParsingCallback for semantics changes: adamcz.
May 24 2021, 11:06 PM · Restricted Project

May 19 2021

kadircet requested review of D102761: [clangd] New ParsingCallback for semantics changes.
May 19 2021, 4:56 AM · Restricted Project
kadircet accepted D102750: [clang] Fix a crash on CheckArgAlignment..

thanks!

May 19 2021, 3:15 AM · Restricted Project

May 17 2021

kadircet committed rGec2f7376e39f: [clangd][QueryDriver] Dont check for existence of driver (authored by kadircet).
[clangd][QueryDriver] Dont check for existence of driver
May 17 2021, 3:43 AM
kadircet closed D102431: [clangd][QueryDriver] Dont check for existence of driver.
May 17 2021, 3:43 AM · Restricted Project
kadircet added a comment to D102519: [clangd] Set FileSystem for tweaks in Check tool..

oops, sorry. i thought i've accepted the revision already :D

May 17 2021, 2:14 AM · Restricted Project
kadircet added a comment to D102519: [clangd] Set FileSystem for tweaks in Check tool..

thanks, lgtm!

May 17 2021, 12:35 AM · Restricted Project

May 14 2021

kadircet committed rGed339111bff6: [clangd] Always default to raw pch format (authored by kadircet).
[clangd] Always default to raw pch format
May 14 2021, 7:40 AM
kadircet closed D102418: [clangd] Always default to raw pch format.
May 14 2021, 7:40 AM · Restricted Project

May 13 2021

kadircet requested review of D102431: [clangd][QueryDriver] Dont check for existence of driver.
May 13 2021, 11:58 AM · Restricted Project
kadircet requested review of D102418: [clangd] Always default to raw pch format.
May 13 2021, 9:57 AM · Restricted Project

May 10 2021

kadircet committed rG888307ee625b: [clangd][remote-client] Set HasMore to true for failure (authored by kadircet).
[clangd][remote-client] Set HasMore to true for failure
May 10 2021, 11:28 PM
kadircet committed rGdaf3cb3b8a58: [clangd][index-sever] Limit results in repsonse (authored by kadircet).
[clangd][index-sever] Limit results in repsonse
May 10 2021, 11:28 PM
kadircet closed D101915: [clangd][remote-client] Set HasMore to true for failure.
May 10 2021, 11:27 PM · Restricted Project
kadircet closed D101914: [clangd][index-sever] Limit results in repsonse.
May 10 2021, 11:27 PM · Restricted Project
kadircet added inline comments to D101914: [clangd][index-sever] Limit results in repsonse.
May 10 2021, 11:21 PM · Restricted Project
kadircet updated the diff for D101914: [clangd][index-sever] Limit results in repsonse.
  • Change logs to mention original limits.
  • Add the test i forgot first time.
May 10 2021, 11:20 PM · Restricted Project
kadircet added a comment to D101616: [clangd] Fix data type of WorkDoneProgressReport::percentage.

done, sorry for the delay!

May 10 2021, 5:59 AM · Restricted Project
kadircet committed rGf088af37e6b5: [clangd] Fix data type of WorkDoneProgressReport::percentage (authored by ckandeler).
[clangd] Fix data type of WorkDoneProgressReport::percentage
May 10 2021, 5:59 AM
kadircet closed D101616: [clangd] Fix data type of WorkDoneProgressReport::percentage.
May 10 2021, 5:58 AM · Restricted Project
kadircet committed rG761f3d16753e: [clang][PreProcessor] Cutoff parsing after hitting completion point (authored by kadircet).
[clang][PreProcessor] Cutoff parsing after hitting completion point
May 10 2021, 2:31 AM
kadircet closed D102069: [clang][PreProcessor] Cutoff parsing after hitting completion point.
May 10 2021, 2:31 AM · Restricted Project
kadircet updated the diff for D102069: [clang][PreProcessor] Cutoff parsing after hitting completion point.
  • Fix lit
May 10 2021, 1:19 AM · Restricted Project
kadircet updated the diff for D102069: [clang][PreProcessor] Cutoff parsing after hitting completion point.
  • Fix typo in comment
  • Handle the \#elif case too.
May 10 2021, 1:19 AM · Restricted Project

May 7 2021

kadircet requested review of D102069: [clang][PreProcessor] Cutoff parsing after hitting completion point.
May 7 2021, 6:27 AM · Restricted Project

May 6 2021

kadircet accepted D101785: [clangd][ObjC] Highlight Objc Ivar refs.

thanks!

May 6 2021, 8:04 AM · Restricted Project
kadircet added a comment to D101785: [clangd][ObjC] Highlight Objc Ivar refs.

Thanks! Can you also add a test to FindExplicitReferencesTest.All ? as that's where the underlying change lies.

May 6 2021, 2:56 AM · Restricted Project

May 5 2021

kadircet committed rG16c7829784f0: [clangd] Check if macro is already in the IdentifierTable before loading it (authored by qdelacru).
[clangd] Check if macro is already in the IdentifierTable before loading it
May 5 2021, 11:32 PM
kadircet closed D101870: [clangd] Check if macro is already in the IdentifierTable before loading it.
May 5 2021, 11:32 PM · Restricted Project
kadircet accepted D101870: [clangd] Check if macro is already in the IdentifierTable before loading it.

please provide an email address (for attribution) if i should land this for you.

May 5 2021, 1:48 PM · Restricted Project
kadircet requested review of D101915: [clangd][remote-client] Set HasMore to true for failure.
May 5 2021, 8:48 AM · Restricted Project
kadircet requested review of D101914: [clangd][index-sever] Limit results in repsonse.
May 5 2021, 8:42 AM · Restricted Project
kadircet accepted D101902: [clangd] Split CC and refs limit and increase refs limit to 1000.

thanks, lgtm!

May 5 2021, 7:02 AM · Restricted Project
kadircet added a comment to D101870: [clangd] Check if macro is already in the IdentifierTable before loading it.

oh wow thanks! would you mind adding a test case like:

TEST(CompletionTest, NoCrashDueToMacroOrdering) {
  EXPECT_THAT(completions(R"cpp(
    #define ECHO(X) X
    #define ECHO2(X) ECHO(X)
    int finish_preamble = E^CHO(2);)cpp")
                  .Completions,
              UnorderedElementsAre(Labeled("ECHO"), Labeled("ECHO2")));
}

into clang-tools-extra/clangd/unittest/CodeCompleteTests.cpp ?

May 5 2021, 2:07 AM · Restricted Project

May 4 2021

kadircet accepted D101516: Introduce clangd-server-monitor tool.

thanks, let's ship it!

May 4 2021, 3:33 AM · Restricted Project
kadircet committed rGf800ac830941: [clangd] Fix hover crash on broken code (authored by kadircet).
[clangd] Fix hover crash on broken code
May 4 2021, 2:46 AM
kadircet closed D101743: [clangd] Fix hover crash on broken code.
May 4 2021, 2:46 AM · Restricted Project
kadircet added inline comments to D101743: [clangd] Fix hover crash on broken code.
May 4 2021, 1:56 AM · Restricted Project
kadircet updated the diff for D101743: [clangd] Fix hover crash on broken code.
  • s/x/undefined
May 4 2021, 1:56 AM · Restricted Project

May 3 2021

kadircet accepted D101750: [clangd] Find implementors only when index is present..
May 3 2021, 7:59 AM · Restricted Project