Page MenuHomePhabricator

kadircet (Kadir Cetinkaya)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 14 2018, 2:16 AM (70 w, 6 d)

Recent Activity

Today

kadircet added a comment to D63760: [clangd] Address limitations in SelectionTree:.

Also there were some offline discussions around, handling of "invisible nodes"(e.g, ExprWithCleanups) and other types of typelocs like ParenTypeLocs and owner of '=' sign in copy/move assignment constructors

Tue, Jun 25, 7:48 AM · Restricted Project
kadircet updated the diff for D63755: [clang][Tooling] Infer target and mode from argv[0] when using JSONCompilationDatabase.
  • Rename file
  • Fix tests
Tue, Jun 25, 1:18 AM · Restricted Project
kadircet added a parent revision for D63194: [clangd] Link and initialize target infos: D63755: [clang][Tooling] Infer target and mode from argv[0] when using JSONCompilationDatabase.
Tue, Jun 25, 12:57 AM · Restricted Project
kadircet created D63755: [clang][Tooling] Infer target and mode from argv[0] when using JSONCompilationDatabase.
Tue, Jun 25, 12:57 AM · Restricted Project
kadircet added a child revision for D63755: [clang][Tooling] Infer target and mode from argv[0] when using JSONCompilationDatabase: D63194: [clangd] Link and initialize target infos.
Tue, Jun 25, 12:57 AM · Restricted Project
kadircet retitled D63194: [clangd] Link and initialize target infos from [clangd] Link in target infos and pass target and mode while invoking driver to [clangd] Link and initialize target infos.
Tue, Jun 25, 12:57 AM · Restricted Project
kadircet updated the diff for D63194: [clangd] Link and initialize target infos.
  • Move clang related changes to a different patch
Tue, Jun 25, 12:52 AM · Restricted Project

Yesterday

kadircet updated the diff for D62804: [clangd] Enable extraction of system includes from custom toolchains.
  • Rename SystemIncludeExtractor to QueryDriverDatabase
  • Address comments
Mon, Jun 24, 8:51 AM · Restricted Project
kadircet accepted D63714: [clangd] Cleanup the duplicated getTokenRange..
Mon, Jun 24, 8:45 AM · Restricted Project, Restricted Project
kadircet added inline comments to D63330: [clangd] Add Value field to HoverInfo.
Mon, Jun 24, 7:06 AM · Restricted Project
kadircet updated the diff for D63330: [clangd] Add Value field to HoverInfo.
  • Address comments
Mon, Jun 24, 7:06 AM · Restricted Project
kadircet accepted D63708: [clangd] Fix NestedNameSpecifierLoc in SelectionTree.
Mon, Jun 24, 5:19 AM · Restricted Project, Restricted Project
kadircet updated the diff for D63194: [clangd] Link and initialize target infos.
  • Introduce a new wrapper CDB that adds target and mode info to returned compile commands
Mon, Jun 24, 5:06 AM · Restricted Project
kadircet added a comment to D63194: [clangd] Link and initialize target infos.

The only suggestion from me would be maybe try moving this to a layer that would also make also benefit other compilation-db-based things like clang-tidy, etc?
Any ideas on how to do this? Would this potentially break anything?

Mon, Jun 24, 5:05 AM · Restricted Project
kadircet abandoned D63264: [clang][Driver] Deduce target triplet from clang executable name.
Mon, Jun 24, 2:35 AM · Restricted Project

Fri, Jun 21

kadircet added a comment to D62804: [clangd] Enable extraction of system includes from custom toolchains.

ping

Fri, Jun 21, 6:31 AM · Restricted Project
kadircet added a comment to D63194: [clangd] Link and initialize target infos.

ping

Fri, Jun 21, 6:31 AM · Restricted Project
kadircet added a comment to D63264: [clang][Driver] Deduce target triplet from clang executable name.

ping

Fri, Jun 21, 6:31 AM · Restricted Project
kadircet committed rGb9b1aaf07dff: [clang-tidy] Move test files of rL363975 into Inputs directory (authored by kadircet).
[clang-tidy] Move test files of rL363975 into Inputs directory
Fri, Jun 21, 12:52 AM
kadircet committed rL364008: [clang-tidy] Move test files of rL363975 into Inputs directory.
[clang-tidy] Move test files of rL363975 into Inputs directory
Fri, Jun 21, 12:52 AM

Thu, Jun 20

kadircet committed rGc230eea2f349: [clang][ASTMatchers] Add definition for cxxDeductionGuideDecl introduced in… (authored by kadircet).
[clang][ASTMatchers] Add definition for cxxDeductionGuideDecl introduced in…
Thu, Jun 20, 3:13 AM
kadircet committed rL363917: [clang][ASTMatchers] Add definition for cxxDeductionGuideDecl introduced in….
[clang][ASTMatchers] Add definition for cxxDeductionGuideDecl introduced in…
Thu, Jun 20, 3:11 AM

Wed, Jun 19

kadircet accepted D63562: [clangd] Format changes produced by rename.
Wed, Jun 19, 9:43 AM · Restricted Project, Restricted Project
kadircet added inline comments to D63330: [clangd] Add Value field to HoverInfo.
Wed, Jun 19, 2:45 AM · Restricted Project
kadircet updated the diff for D63330: [clangd] Add Value field to HoverInfo.
  • Address comments
Wed, Jun 19, 2:45 AM · Restricted Project

Mon, Jun 17

kadircet committed rG3c9391aad9ee: [clang][CodeGen] Remove std::move on temporary (authored by kadircet).
[clang][CodeGen] Remove std::move on temporary
Mon, Jun 17, 7:20 AM
kadircet committed rL363563: [clang][CodeGen] Remove std::move on temporary.
[clang][CodeGen] Remove std::move on temporary
Mon, Jun 17, 7:19 AM
kadircet accepted D63425: [clangd] Perform merge for main file symbols..
Mon, Jun 17, 6:35 AM · Restricted Project, Restricted Project
kadircet added a comment to D63425: [clangd] Perform merge for main file symbols..

We also make use of PickOne in updatePreamble shouldn't that also cause similar troubles?

Mon, Jun 17, 6:18 AM · Restricted Project, Restricted Project
kadircet accepted D63397: [clangd] Detect C++ for extension-less source files in vscode extension.
Mon, Jun 17, 1:31 AM · Restricted Project, Restricted Project
kadircet accepted D63316: [clangd] Include the diagnostics's code when comparing diagnostics.

LGTM with one more test case request. Thanks!

Mon, Jun 17, 1:18 AM · Restricted Project, Restricted Project
kadircet added a comment to D63397: [clangd] Detect C++ for extension-less source files in vscode extension.

Could you also update summary to include a link to documentation regarding contributes.languages ?

Mon, Jun 17, 1:13 AM · Restricted Project, Restricted Project

Fri, Jun 14

kadircet created D63330: [clangd] Add Value field to HoverInfo.
Fri, Jun 14, 5:05 AM · Restricted Project
kadircet accepted D63323: [clangd] Don't maintain a list of c-family extensions in vscode extension..

could you also bump the version numbers?

Fri, Jun 14, 4:24 AM · Restricted Project, Restricted Project
kadircet accepted D63270: [clangd] Add include-mapping for C symbols..
Fri, Jun 14, 4:05 AM · Restricted Project, Restricted Project
kadircet accepted D62839: [clangd] Index API and implementations for relations.

LGTM, thanks!

Fri, Jun 14, 1:06 AM · Restricted Project, Restricted Project
kadircet accepted D58880: [clangd] Type hierarchy subtypes.

LGTM with a few small comments.

Fri, Jun 14, 12:52 AM · Restricted Project, Restricted Project
kadircet added a comment to D63316: [clangd] Include the diagnostics's code when comparing diagnostics.

Could you also add a lit test for the case you mentioned in the github issue?

Fri, Jun 14, 12:29 AM · Restricted Project, Restricted Project

Thu, Jun 13

kadircet created D63295: [clang][HeaderSearch] Shorten paths for includes in mainfile's directory.
Thu, Jun 13, 12:39 PM · Restricted Project
kadircet added inline comments to D63270: [clangd] Add include-mapping for C symbols..
Thu, Jun 13, 10:56 AM · Restricted Project, Restricted Project
kadircet added a parent revision for D63194: [clangd] Link and initialize target infos: D63264: [clang][Driver] Deduce target triplet from clang executable name.
Thu, Jun 13, 6:53 AM · Restricted Project
kadircet added inline comments to D63194: [clangd] Link and initialize target infos.
Thu, Jun 13, 6:53 AM · Restricted Project
kadircet added a child revision for D63264: [clang][Driver] Deduce target triplet from clang executable name: D63194: [clangd] Link and initialize target infos.
Thu, Jun 13, 6:53 AM · Restricted Project
kadircet created D63264: [clang][Driver] Deduce target triplet from clang executable name.
Thu, Jun 13, 6:53 AM · Restricted Project
kadircet committed rG88e636dfc15d: [Clangd] Fixed clangd diagnostics priority (authored by kadircet).
[Clangd] Fixed clangd diagnostics priority
Thu, Jun 13, 5:30 AM
kadircet committed rL363253: [Clangd] Fixed clangd diagnostics priority.
[Clangd] Fixed clangd diagnostics priority
Thu, Jun 13, 5:30 AM
kadircet closed D63222: [Clangd] Fixed clangd diagnostics priority.
Thu, Jun 13, 5:30 AM · Restricted Project, Restricted Project, Restricted Project
kadircet added inline comments to D63194: [clangd] Link and initialize target infos.
Thu, Jun 13, 4:35 AM · Restricted Project
kadircet updated the diff for D63194: [clangd] Link and initialize target infos.
  • Move target name deduction into Driver
Thu, Jun 13, 4:35 AM · Restricted Project
kadircet accepted D63222: [Clangd] Fixed clangd diagnostics priority.

Also please make sure you've clang-formatted the code before you land this.

Thu, Jun 13, 3:36 AM · Restricted Project, Restricted Project, Restricted Project
kadircet committed rG497792753607: [clangd] Treat lambdas as functions when preparing hover response (authored by kadircet).
[clangd] Treat lambdas as functions when preparing hover response
Thu, Jun 13, 1:49 AM
kadircet committed rL363237: [clangd] Treat lambdas as functions when preparing hover response.
[clangd] Treat lambdas as functions when preparing hover response
Thu, Jun 13, 1:49 AM
kadircet closed D62814: [clangd] Treat lambdas as functions when preparing hover response.
Thu, Jun 13, 1:49 AM · Restricted Project, Restricted Project
kadircet added inline comments to D62839: [clangd] Index API and implementations for relations.
Thu, Jun 13, 1:43 AM · Restricted Project, Restricted Project
kadircet added a comment to D63222: [Clangd] Fixed clangd diagnostics priority.

Mostly LG, just a few re-orderings to make code more readable and get rid of redundant Lexer calls.

Thu, Jun 13, 1:36 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Jun 12

kadircet added a comment to D58880: [clangd] Type hierarchy subtypes.

mostly LG, thanks!

Wed, Jun 12, 7:53 AM · Restricted Project, Restricted Project
kadircet added a comment to D62839: [clangd] Index API and implementations for relations.

LGTM, except the batch query support.

Wed, Jun 12, 7:11 AM · Restricted Project, Restricted Project
kadircet added inline comments to D63194: [clangd] Link and initialize target infos.
Wed, Jun 12, 6:42 AM · Restricted Project
kadircet updated the diff for D63194: [clangd] Link and initialize target infos.
  • Add comments to the test
Wed, Jun 12, 6:42 AM · Restricted Project
kadircet created D63194: [clangd] Link and initialize target infos.
Wed, Jun 12, 6:02 AM · Restricted Project
kadircet added a comment to D62804: [clangd] Enable extraction of system includes from custom toolchains.

For example a gcc cross compiling to arm comes with its own system includes and has some mechanisms to discover that implicitly, without requiring any "-I" flags.
Hence when used with clangd, we make use of system includes instead of the target's include library. This patch aims to solve that issue, tools like cquery also handles that problem in a similar way.

That's exactly what driver is about. The approach is slightly different, though. Instead of executing a binary, one has to mimic the toolchain search logic of a particular toolchain by hand.
In addition to includes, it also handles adding the corresponding -D flags and anything else that the cross-compile toolchain does. Is this toolchain not currently supported by the driver? Is adding it so much work that we would choose to workaround like this instead?

Wed, Jun 12, 5:18 AM · Restricted Project
kadircet updated the diff for D62804: [clangd] Enable extraction of system includes from custom toolchains.
  • Fix off-by-one bug and improve lit test
Wed, Jun 12, 2:58 AM · Restricted Project

Tue, Jun 11

kadircet added a comment to D62804: [clangd] Enable extraction of system includes from custom toolchains.

Could you give more context on what the custom toolchains are?
One feasible alternative is to move this detection to clang's driver (where the rest of include path detection lives), why won't that work?

Tue, Jun 11, 7:43 AM · Restricted Project
kadircet updated the diff for D62804: [clangd] Enable extraction of system includes from custom toolchains.
  • Address comments
Tue, Jun 11, 7:30 AM · Restricted Project

Fri, Jun 7

kadircet added inline comments to D62839: [clangd] Index API and implementations for relations.
Fri, Jun 7, 6:04 AM · Restricted Project, Restricted Project
kadircet added inline comments to D62814: [clangd] Treat lambdas as functions when preparing hover response.
Fri, Jun 7, 4:15 AM · Restricted Project, Restricted Project
kadircet updated the diff for D62814: [clangd] Treat lambdas as functions when preparing hover response.
  • Address comments
Fri, Jun 7, 4:15 AM · Restricted Project, Restricted Project

Thu, Jun 6

kadircet committed rG51f85b40bc6c: [clang][HeaderSearch] Consider all path separators equal (authored by kadircet).
[clang][HeaderSearch] Consider all path separators equal
Thu, Jun 6, 11:48 AM
kadircet committed rL362731: [clang][HeaderSearch] Consider all path separators equal.
[clang][HeaderSearch] Consider all path separators equal
Thu, Jun 6, 11:46 AM
kadircet closed D62965: [clang][HeaderSearch] Consider all path separators equal.
Thu, Jun 6, 11:46 AM · Restricted Project, Restricted Project
kadircet updated the diff for D62965: [clang][HeaderSearch] Consider all path separators equal.
  • Update comment
Thu, Jun 6, 10:16 AM · Restricted Project, Restricted Project
kadircet added inline comments to D62839: [clangd] Index API and implementations for relations.
Thu, Jun 6, 10:16 AM · Restricted Project, Restricted Project
kadircet created D62965: [clang][HeaderSearch] Consider all path separators equal.
Thu, Jun 6, 9:33 AM · Restricted Project, Restricted Project

Tue, Jun 4

kadircet added inline comments to D62814: [clangd] Treat lambdas as functions when preparing hover response.
Tue, Jun 4, 7:11 AM · Restricted Project, Restricted Project
kadircet updated the diff for D62814: [clangd] Treat lambdas as functions when preparing hover response.
  • Address comments
Tue, Jun 4, 7:11 AM · Restricted Project, Restricted Project
kadircet committed rGa7f9f42d2895: [clangd] Also apply adjustArguments when returning fallback commands (authored by kadircet).
[clangd] Also apply adjustArguments when returning fallback commands
Tue, Jun 4, 6:38 AM
kadircet committed rL362496: [clangd] Also apply adjustArguments when returning fallback commands.
[clangd] Also apply adjustArguments when returning fallback commands
Tue, Jun 4, 6:35 AM
kadircet closed D62856: [clangd] Also apply adjustArguments when returning fallback commands.
Tue, Jun 4, 6:35 AM · Restricted Project, Restricted Project
kadircet created D62856: [clangd] Also apply adjustArguments when returning fallback commands.
Tue, Jun 4, 6:29 AM · Restricted Project, Restricted Project
kadircet updated the diff for D62814: [clangd] Treat lambdas as functions when preparing hover response.
  • Address comments
Tue, Jun 4, 2:56 AM · Restricted Project, Restricted Project
kadircet added inline comments to D62814: [clangd] Treat lambdas as functions when preparing hover response.
Tue, Jun 4, 2:56 AM · Restricted Project, Restricted Project
kadircet added a comment to D62839: [clangd] Index API and implementations for relations.

For relations, should we include a copy in both the file containing the definition of the subject, and (if different) the file containing the definition of the object?

Tue, Jun 4, 1:17 AM · Restricted Project, Restricted Project
kadircet added a comment to D62814: [clangd] Treat lambdas as functions when preparing hover response.

Nice catch! I think it makes sense to show signature in those cases as well.
Updating according to that.

Tue, Jun 4, 1:11 AM · Restricted Project, Restricted Project
kadircet updated the diff for D62814: [clangd] Treat lambdas as functions when preparing hover response.
  • Address comments
  • Handle pointer/reference types to lambdas
Tue, Jun 4, 1:11 AM · Restricted Project, Restricted Project

Mon, Jun 3

kadircet updated the diff for D62814: [clangd] Treat lambdas as functions when preparing hover response.
  • Get rid of wrong check
Mon, Jun 3, 9:32 AM · Restricted Project, Restricted Project
kadircet created D62814: [clangd] Treat lambdas as functions when preparing hover response.
Mon, Jun 3, 9:26 AM · Restricted Project, Restricted Project
kadircet accepted D62471: [clangd] SymbolCollector support for relations.

I suppose there are only two patches left now?

  • Exposing relations in SymbolIndex.
  • Implementing children resolution using that information.
Mon, Jun 3, 1:47 AM · Restricted Project, Restricted Project
kadircet created D62804: [clangd] Enable extraction of system includes from custom toolchains.
Mon, Jun 3, 1:43 AM · Restricted Project

Fri, May 31

kadircet accepted D62459: [clangd] Serialization support for RelationSlab.

LG, thanks for the patch!

Fri, May 31, 1:47 AM · Restricted Project, Restricted Project
kadircet added inline comments to D62471: [clangd] SymbolCollector support for relations.
Fri, May 31, 1:34 AM · Restricted Project, Restricted Project
kadircet accepted D59407: [clangd] Add RelationSlab.

Still LG, thanks for the patch!

Fri, May 31, 12:57 AM · Restricted Project, Restricted Project

Wed, May 29

kadircet accepted D62579: [Index] Compute correct symbol kind for variable templates.

LGTM

Wed, May 29, 10:16 AM · Restricted Project
kadircet added inline comments to D62579: [Index] Compute correct symbol kind for variable templates.
Wed, May 29, 7:10 AM · Restricted Project
kadircet accepted D61601: [clangd] Represent Hover result using FormattedString.

LGTM, thanks!

Wed, May 29, 2:43 AM · Restricted Project, Restricted Project
kadircet accepted D62573: [Index] Correctly set symbol kind of IndirectFieldDecl.

LGTM thanks!

Wed, May 29, 1:31 AM · Restricted Project
kadircet added a comment to D61601: [clangd] Represent Hover result using FormattedString.

Ping, D61497 has landed

Wed, May 29, 1:06 AM · Restricted Project, Restricted Project

Tue, May 28

kadircet added a comment to D59407: [clangd] Add RelationSlab.

btw, I believe you have enough good quality patches to apply for commit access.

Tue, May 28, 7:46 AM · Restricted Project, Restricted Project
kadircet accepted D62514: [CodeComplete] Set preferred type for qualified-id.

one irrelevant question though, it looks like most of the calls to ResultBuilder::setPreferredType performs a !isNull check before hand. should we perform this check implicitly and make the setPreferredType no-op in case of a null type?

Tue, May 28, 4:40 AM · Restricted Project, Restricted Project
kadircet committed rGc6578eefdd57: [clangd] Introduce a structured hover response (authored by kadircet).
[clangd] Introduce a structured hover response
Tue, May 28, 3:28 AM
kadircet committed rCTE361803: [clangd] Introduce a structured hover response.
[clangd] Introduce a structured hover response
Tue, May 28, 3:28 AM