Page MenuHomePhabricator

kadircet (Kadir Cetinkaya)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 14 2018, 2:16 AM (53 w, 17 h)

Recent Activity

Today

kadircet accepted D58440: [clangd] Store index in '.clangd/index' instead of '.clangd-index'.

Thanks!

Wed, Feb 20, 8:38 AM · Restricted Project, Restricted Project
kadircet accepted D58447: [clangd] Fix a crash in Selection.

LGTM

Wed, Feb 20, 6:49 AM · Restricted Project, Restricted Project
kadircet committed rG592e7c9b0eb8: [clangd] Revert r354442 and r354444 (authored by kadircet).
[clangd] Revert r354442 and r354444
Wed, Feb 20, 3:46 AM
kadircet committed rL354453: [clangd] Revert r354442 and r354444.
[clangd] Revert r354442 and r354444
Wed, Feb 20, 3:46 AM
kadircet committed rCTE354453: [clangd] Revert r354442 and r354444.
[clangd] Revert r354442 and r354444
Wed, Feb 20, 3:46 AM
kadircet committed rG60ba9b44604d: [clangd] Try to fix windows build bots (authored by kadircet).
[clangd] Try to fix windows build bots
Wed, Feb 20, 2:32 AM
kadircet committed rCTE354444: [clangd] Try to fix windows build bots.
[clangd] Try to fix windows build bots
Wed, Feb 20, 2:31 AM
kadircet committed rL354444: [clangd] Try to fix windows build bots.
[clangd] Try to fix windows build bots
Wed, Feb 20, 2:31 AM
kadircet committed rG30d340839ca7: [clangd] Testcase for bug 39811 (authored by kadircet).
[clangd] Testcase for bug 39811
Wed, Feb 20, 1:41 AM
kadircet committed rCTE354442: [clangd] Testcase for bug 39811.
[clangd] Testcase for bug 39811
Wed, Feb 20, 1:41 AM
kadircet committed rL354442: [clangd] Testcase for bug 39811.
[clangd] Testcase for bug 39811
Wed, Feb 20, 1:41 AM
kadircet closed D58133: [clangd] Testcase for bug 39811.
Wed, Feb 20, 1:41 AM · Restricted Project, Restricted Project
kadircet updated the diff for D58293: [clang][Index] Enable indexing of Template Type Parameters behind a flag.
  • Move handleDecl call to top of the loop
Wed, Feb 20, 1:00 AM · Restricted Project

Yesterday

kadircet updated the diff for D58341: [clangd] Index UsingDecls.
  • Revert last change
Tue, Feb 19, 8:04 AM · Restricted Project
kadircet updated the diff for D58294: [clangd] Enable indexing of template type parameters.
  • Option's name has changed
Tue, Feb 19, 7:51 AM · Restricted Project
kadircet added inline comments to D58293: [clang][Index] Enable indexing of Template Type Parameters behind a flag.
Tue, Feb 19, 7:51 AM · Restricted Project
kadircet updated the diff for D58293: [clang][Index] Enable indexing of Template Type Parameters behind a flag.
  • Change options name
  • Also index decls
Tue, Feb 19, 7:51 AM · Restricted Project
kadircet updated the diff for D58341: [clangd] Index UsingDecls.
  • Add tests for code completion
Tue, Feb 19, 7:24 AM · Restricted Project
kadircet updated the diff for D58294: [clangd] Enable indexing of template type parameters.
  • Add handling for template template type parameters
Tue, Feb 19, 3:34 AM · Restricted Project
kadircet added inline comments to D58293: [clang][Index] Enable indexing of Template Type Parameters behind a flag.
Tue, Feb 19, 3:29 AM · Restricted Project
kadircet updated the summary of D58293: [clang][Index] Enable indexing of Template Type Parameters behind a flag.
Tue, Feb 19, 3:29 AM · Restricted Project
kadircet updated the diff for D58293: [clang][Index] Enable indexing of Template Type Parameters behind a flag.
  • Fix handling of TemplateTemplateTypeParams
Tue, Feb 19, 3:28 AM · Restricted Project
kadircet added a comment to D58294: [clangd] Enable indexing of template type parameters.

Yeah you are right, no need to have those in the index. I thought we looked at only index for findreferences(which turned out to be wrong, we also traverse ast), therefore I had turned this functionality on for dynamic index.

Tue, Feb 19, 12:54 AM · Restricted Project
kadircet updated the diff for D58294: [clangd] Enable indexing of template type parameters.
  • Turn off indexing of template type parms for dynamic index
Tue, Feb 19, 12:54 AM · Restricted Project

Mon, Feb 18

kadircet committed rG9b4db445ce1e: [clangd] Add tests for template specializations (authored by kadircet).
[clangd] Add tests for template specializations
Mon, Feb 18, 6:23 AM
kadircet committed rCTE354272: [clangd] Add tests for template specializations.
[clangd] Add tests for template specializations
Mon, Feb 18, 6:23 AM
kadircet committed rL354272: [clangd] Add tests for template specializations.
[clangd] Add tests for template specializations
Mon, Feb 18, 6:23 AM
kadircet closed D58190: [clangd] Add tests for template specializations.
Mon, Feb 18, 6:22 AM · Restricted Project, Restricted Project
kadircet updated the diff for D58190: [clangd] Add tests for template specializations.
  • Fix typo and make comments start with 2 slashes
Mon, Feb 18, 6:21 AM · Restricted Project, Restricted Project
kadircet updated the diff for D58340: [clang][Index] Visit UsingDecls and generate USRs for them.
  • Address comments
Mon, Feb 18, 6:10 AM · Restricted Project
kadircet committed rGf53621bb0f52: [clang][Index] Fix usage of IndexImplicitInstantiation (authored by kadircet).
[clang][Index] Fix usage of IndexImplicitInstantiation
Mon, Feb 18, 3:31 AM
kadircet committed rC354262: [clang][Index] Fix usage of IndexImplicitInstantiation.
[clang][Index] Fix usage of IndexImplicitInstantiation
Mon, Feb 18, 3:30 AM
kadircet committed rL354262: [clang][Index] Fix usage of IndexImplicitInstantiation.
[clang][Index] Fix usage of IndexImplicitInstantiation
Mon, Feb 18, 3:30 AM
kadircet closed D58189: [clang][Index] Fix usage of IndexImplicitInstantiation.
Mon, Feb 18, 3:30 AM · Restricted Project, Restricted Project
kadircet updated the diff for D58190: [clangd] Add tests for template specializations.
  • Add more testcases
Mon, Feb 18, 3:27 AM · Restricted Project, Restricted Project
kadircet updated the diff for D58341: [clangd] Index UsingDecls.
  • Update USR to include "UD"
Mon, Feb 18, 3:06 AM · Restricted Project
kadircet updated the diff for D58340: [clang][Index] Visit UsingDecls and generate USRs for them.
  • Address comments
Mon, Feb 18, 3:06 AM · Restricted Project
kadircet added a child revision for D58340: [clang][Index] Visit UsingDecls and generate USRs for them: D58341: [clangd] Index UsingDecls.
Mon, Feb 18, 2:19 AM · Restricted Project
kadircet added a parent revision for D58341: [clangd] Index UsingDecls: D58340: [clang][Index] Visit UsingDecls and generate USRs for them.
Mon, Feb 18, 2:19 AM · Restricted Project
kadircet created D58341: [clangd] Index UsingDecls.
Mon, Feb 18, 2:18 AM · Restricted Project
kadircet created D58340: [clang][Index] Visit UsingDecls and generate USRs for them.
Mon, Feb 18, 2:16 AM · Restricted Project

Sun, Feb 17

kadircet added a reviewer for D58190: [clangd] Add tests for template specializations: ilya-biryukov.
Sun, Feb 17, 11:54 PM · Restricted Project, Restricted Project
kadircet accepted D58291: [clangd] Include textual diagnostic ID as Diagnostic.code..

LG but is this information really useful to users? According to LSP The diagnostic's code, which might appear in the user interface., I think seeing this will be mostly noise for users.

Sun, Feb 17, 6:50 AM · Restricted Project

Fri, Feb 15

kadircet added a child revision for D58293: [clang][Index] Enable indexing of Template Type Parameters behind a flag: D58294: [clangd] Enable indexing of template type parameters.
Fri, Feb 15, 10:53 AM · Restricted Project
kadircet added a parent revision for D58294: [clangd] Enable indexing of template type parameters: D58293: [clang][Index] Enable indexing of Template Type Parameters behind a flag.
Fri, Feb 15, 10:53 AM · Restricted Project
kadircet created D58294: [clangd] Enable indexing of template type parameters.
Fri, Feb 15, 10:49 AM · Restricted Project
kadircet created D58293: [clang][Index] Enable indexing of Template Type Parameters behind a flag.
Fri, Feb 15, 10:48 AM · Restricted Project
kadircet updated the diff for D58189: [clang][Index] Fix usage of IndexImplicitInstantiation.
  • Get rid of redundant test
Fri, Feb 15, 6:57 AM · Restricted Project, Restricted Project
kadircet added inline comments to D58189: [clang][Index] Fix usage of IndexImplicitInstantiation.
Fri, Feb 15, 5:25 AM · Restricted Project, Restricted Project
kadircet updated the diff for D58189: [clang][Index] Fix usage of IndexImplicitInstantiation.

Address comments

Fri, Feb 15, 4:48 AM · Restricted Project, Restricted Project

Wed, Feb 13

kadircet added a child revision for D58189: [clang][Index] Fix usage of IndexImplicitInstantiation: D58190: [clangd] Add tests for template specializations.
Wed, Feb 13, 9:18 AM · Restricted Project, Restricted Project
kadircet added a parent revision for D58190: [clangd] Add tests for template specializations: D58189: [clang][Index] Fix usage of IndexImplicitInstantiation.
Wed, Feb 13, 9:18 AM · Restricted Project, Restricted Project
kadircet created D58190: [clangd] Add tests for template specializations.
Wed, Feb 13, 9:18 AM · Restricted Project, Restricted Project
kadircet created D58189: [clang][Index] Fix usage of IndexImplicitInstantiation.
Wed, Feb 13, 9:15 AM · Restricted Project, Restricted Project

Tue, Feb 12

kadircet committed rG87731440d46d: [clangd] Fix a lit-test. (authored by kadircet).
[clangd] Fix a lit-test.
Tue, Feb 12, 8:55 AM
kadircet committed rL353857: [clangd] Fix a lit-test..
[clangd] Fix a lit-test.
Tue, Feb 12, 8:54 AM
kadircet committed rCTE353857: [clangd] Fix a lit-test..
[clangd] Fix a lit-test.
Tue, Feb 12, 8:54 AM
kadircet closed D58126: [clangd] Fix a lit-test..
Tue, Feb 12, 8:54 AM · Restricted Project
kadircet created D58133: [clangd] Testcase for bug 39811.
Tue, Feb 12, 8:50 AM · Restricted Project, Restricted Project
kadircet created D58126: [clangd] Fix a lit-test..
Tue, Feb 12, 8:08 AM · Restricted Project

Mon, Feb 11

kadircet committed rG429022995bc1: [clangd] Index parameters in function decls (authored by kadircet).
[clangd] Index parameters in function decls
Mon, Feb 11, 5:04 AM
kadircet committed rG0468fc0b8d71: [clang][Index] Add a knob to index function parameters in declarations (authored by kadircet).
[clang][Index] Add a knob to index function parameters in declarations
Mon, Feb 11, 5:03 AM
kadircet committed rL353696: [clangd] Index parameters in function decls.
[clangd] Index parameters in function decls
Mon, Feb 11, 5:03 AM
kadircet committed rCTE353696: [clangd] Index parameters in function decls.
[clangd] Index parameters in function decls
Mon, Feb 11, 5:02 AM
kadircet closed D57950: [clangd] Index parameters in function decls.
Mon, Feb 11, 5:02 AM · Restricted Project
kadircet committed rC353695: [clang][Index] Add a knob to index function parameters in declarations.
[clang][Index] Add a knob to index function parameters in declarations
Mon, Feb 11, 5:02 AM
kadircet committed rL353695: [clang][Index] Add a knob to index function parameters in declarations.
[clang][Index] Add a knob to index function parameters in declarations
Mon, Feb 11, 5:02 AM
kadircet committed rGcf13bfee0012: [clangd] Fix broken windows build bots. (authored by kadircet).
[clangd] Fix broken windows build bots.
Mon, Feb 11, 5:02 AM
kadircet closed D57949: [clang][Index] Add a knob to index function parameters in declarations.
Mon, Feb 11, 5:02 AM · Restricted Project, Restricted Project
kadircet committed rCTE353694: [clangd] Fix broken windows build bots..
[clangd] Fix broken windows build bots.
Mon, Feb 11, 5:01 AM
kadircet committed rL353694: [clangd] Fix broken windows build bots..
[clangd] Fix broken windows build bots.
Mon, Feb 11, 5:01 AM
kadircet committed rCTE353687: [clangd] Make system header mappings available for PreambleParsedCallback.
[clangd] Make system header mappings available for PreambleParsedCallback
Mon, Feb 11, 2:37 AM
kadircet committed rGdb7fbcb038f0: [clangd] Make system header mappings available for PreambleParsedCallback (authored by kadircet).
[clangd] Make system header mappings available for PreambleParsedCallback
Mon, Feb 11, 2:32 AM
kadircet committed rL353687: [clangd] Make system header mappings available for PreambleParsedCallback.
[clangd] Make system header mappings available for PreambleParsedCallback
Mon, Feb 11, 2:31 AM
kadircet closed D58029: [clangd] Make system header mappings available for PreambleParsedCallback.
Mon, Feb 11, 2:31 AM · Restricted Project, Restricted Project
kadircet added inline comments to D56370: [clangd] Add support for type hierarchy (super types only for now).
Mon, Feb 11, 1:58 AM · Restricted Project
kadircet created D58029: [clangd] Make system header mappings available for PreambleParsedCallback.
Mon, Feb 11, 1:44 AM · Restricted Project, Restricted Project

Fri, Feb 8

kadircet updated the diff for D57950: [clangd] Index parameters in function decls.

Also index function params in findrefs

Fri, Feb 8, 7:22 AM · Restricted Project
kadircet updated the diff for D57949: [clang][Index] Add a knob to index function parameters in declarations.
  • Also delete comment
Fri, Feb 8, 6:20 AM · Restricted Project, Restricted Project
kadircet added a parent revision for D57950: [clangd] Index parameters in function decls: D57949: [clang][Index] Add a knob to index function parameters in declarations.
Fri, Feb 8, 6:18 AM · Restricted Project
kadircet added a child revision for D57949: [clang][Index] Add a knob to index function parameters in declarations: D57950: [clangd] Index parameters in function decls.
Fri, Feb 8, 6:18 AM · Restricted Project, Restricted Project
kadircet planned changes to D57950: [clangd] Index parameters in function decls.
Fri, Feb 8, 6:18 AM · Restricted Project
kadircet created D57950: [clangd] Index parameters in function decls.
Fri, Feb 8, 6:16 AM · Restricted Project
kadircet created D57949: [clang][Index] Add a knob to index function parameters in declarations.
Fri, Feb 8, 6:16 AM · Restricted Project, Restricted Project
kadircet updated subscribers of D56370: [clangd] Add support for type hierarchy (super types only for now).

Implementation LG, but I am not sure about adding a functionality on a proposal that might change. WDYT @sammccall ?

Fri, Feb 8, 2:54 AM · Restricted Project

Thu, Feb 7

kadircet committed rGb88144e4babd: [clangd] Mention indexing in docs. (authored by kadircet).
[clangd] Mention indexing in docs.
Thu, Feb 7, 8:11 AM
kadircet committed rL353423: [clangd] Mention indexing in docs..
[clangd] Mention indexing in docs.
Thu, Feb 7, 8:11 AM
kadircet committed rCTE353423: [clangd] Mention indexing in docs..
[clangd] Mention indexing in docs.
Thu, Feb 7, 8:10 AM
kadircet closed D57392: [clangd] Mention indexing in docs..
Thu, Feb 7, 8:10 AM · Restricted Project
kadircet updated the diff for D57392: [clangd] Mention indexing in docs..

Address comments

Thu, Feb 7, 8:09 AM · Restricted Project
kadircet committed rGee23633eab72: [clangd] Reduce number of threads used by BackgroundIndex to number of physical… (authored by kadircet).
[clangd] Reduce number of threads used by BackgroundIndex to number of physical…
Thu, Feb 7, 8:05 AM
kadircet committed rL353422: [clangd] Reduce number of threads used by BackgroundIndex to number of physical….
[clangd] Reduce number of threads used by BackgroundIndex to number of physical…
Thu, Feb 7, 8:04 AM
kadircet committed rCTE353422: [clangd] Reduce number of threads used by BackgroundIndex to number of physical….
[clangd] Reduce number of threads used by BackgroundIndex to number of physical…
Thu, Feb 7, 8:04 AM
kadircet closed D57819: [clangd] Reduce number of threads used by BackgroundIndex to number of physical cores..
Thu, Feb 7, 8:04 AM · Restricted Project
kadircet updated the summary of D57819: [clangd] Reduce number of threads used by BackgroundIndex to number of physical cores..
Thu, Feb 7, 8:02 AM · Restricted Project

Wed, Feb 6

kadircet created D57819: [clangd] Reduce number of threads used by BackgroundIndex to number of physical cores..
Wed, Feb 6, 7:12 AM · Restricted Project

Mon, Feb 4

kadircet committed rGc3dcd2673e7a: [clangd] Enable include insertion for static index (authored by kadircet).
[clangd] Enable include insertion for static index
Mon, Feb 4, 8:21 AM
kadircet committed rCTE353054: [clangd] Enable include insertion for static index.
[clangd] Enable include insertion for static index
Mon, Feb 4, 8:20 AM
kadircet committed rL353054: [clangd] Enable include insertion for static index.
[clangd] Enable include insertion for static index
Mon, Feb 4, 8:20 AM
kadircet closed D57508: [clangd] Enable include insertion for dynamic index.
Mon, Feb 4, 8:19 AM · Restricted Project, Restricted Project