kadircet (Kadir Cetinkaya)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 14 2018, 2:16 AM (26 w, 3 d)

Recent Activity

Yesterday

kadircet committed rCTE340040: [clangd] Add parantheses while auto-completing functions..
[clangd] Add parantheses while auto-completing functions.
Fri, Aug 17, 8:43 AM
kadircet committed rL340040: [clangd] Add parantheses while auto-completing functions..
[clangd] Add parantheses while auto-completing functions.
Fri, Aug 17, 8:43 AM
kadircet closed D50835: [clangd] Add parantheses while auto-completing functions..
Fri, Aug 17, 8:43 AM
kadircet retitled D50898: [clangd] Suggest code-completions for overriding base class virtual methods. from Suggest code-completions for overriding base class virtual methods. to [clangd] Suggest code-completions for overriding base class virtual methods..
Fri, Aug 17, 8:36 AM
kadircet added inline comments to D50835: [clangd] Add parantheses while auto-completing functions..
Fri, Aug 17, 8:35 AM
kadircet updated the diff for D50835: [clangd] Add parantheses while auto-completing functions..
  • Resolve discussions.
Fri, Aug 17, 8:35 AM
kadircet added inline comments to D50502: [clangd] Initial cancellation mechanism for LSP requests..
Fri, Aug 17, 8:27 AM
kadircet updated the diff for D50502: [clangd] Initial cancellation mechanism for LSP requests..
  • Resolve discussions & Delete enclosing quotes when normalizing.
Fri, Aug 17, 8:27 AM
kadircet updated the diff for D50835: [clangd] Add parantheses while auto-completing functions..
  • Only append to snippets of type function or method.
Fri, Aug 17, 8:15 AM
kadircet added inline comments to D50835: [clangd] Add parantheses while auto-completing functions..
Fri, Aug 17, 7:32 AM
kadircet updated the diff for D50835: [clangd] Add parantheses while auto-completing functions..
  • Change option name.
Fri, Aug 17, 7:32 AM
kadircet created D50898: [clangd] Suggest code-completions for overriding base class virtual methods..
Fri, Aug 17, 7:22 AM

Thu, Aug 16

kadircet added inline comments to D50835: [clangd] Add parantheses while auto-completing functions..
Thu, Aug 16, 6:59 AM
kadircet updated the diff for D50835: [clangd] Add parantheses while auto-completing functions..
  • Change option name.
Thu, Aug 16, 6:59 AM
kadircet added inline comments to D50502: [clangd] Initial cancellation mechanism for LSP requests..
Thu, Aug 16, 6:36 AM
kadircet updated the diff for D50502: [clangd] Initial cancellation mechanism for LSP requests..
  • Resolve discussions.
Thu, Aug 16, 6:36 AM
kadircet updated the diff for D50502: [clangd] Initial cancellation mechanism for LSP requests..
  • Made TaskHandle move-only. Since it is costly and most likely unnecessary to copy it other than to move it into Context.
  • Provided an explicit clone method for copying.
Thu, Aug 16, 2:41 AM
kadircet created D50835: [clangd] Add parantheses while auto-completing functions..
Thu, Aug 16, 2:24 AM
kadircet accepted D50727: [clangd] Fetch documentation from the Index during signature help.

LGTM

Thu, Aug 16, 1:40 AM

Tue, Aug 14

kadircet added inline comments to D50502: [clangd] Initial cancellation mechanism for LSP requests..
Tue, Aug 14, 2:30 PM
kadircet updated the diff for D50502: [clangd] Initial cancellation mechanism for LSP requests..
  • Resolve discussions.
  • Get rid of CancellationHandler class.
  • Change error class name.
  • Improve documentation.
Tue, Aug 14, 11:38 AM
kadircet added inline comments to D50502: [clangd] Initial cancellation mechanism for LSP requests..
Tue, Aug 14, 10:38 AM
kadircet updated the diff for D50502: [clangd] Initial cancellation mechanism for LSP requests..
  • Get rid of getCancellationError.
  • Add replyError helper.
Tue, Aug 14, 10:37 AM
kadircet updated the diff for D50502: [clangd] Initial cancellation mechanism for LSP requests..
  • Polished API.
  • Resolved discussions.
Tue, Aug 14, 1:36 AM

Mon, Aug 13

kadircet committed rCTE339572: Fix lint tests for D50449.
Fix lint tests for D50449
Mon, Aug 13, 7:33 AM
kadircet committed rL339572: Fix lint tests for D50449.
Fix lint tests for D50449
Mon, Aug 13, 7:33 AM
kadircet closed D50635: Fix lint tests for D50449.
Mon, Aug 13, 7:32 AM
kadircet created D50635: Fix lint tests for D50449.
Mon, Aug 13, 7:09 AM
kadircet committed rL339547: [clangd] Introduce scoring mechanism for SignatureInformations..
[clangd] Introduce scoring mechanism for SignatureInformations.
Mon, Aug 13, 1:41 AM
kadircet committed rCTE339547: [clangd] Introduce scoring mechanism for SignatureInformations..
[clangd] Introduce scoring mechanism for SignatureInformations.
Mon, Aug 13, 1:40 AM
kadircet closed D50555: [clangd] Introduce scoring mechanism for SignatureInformations..
Mon, Aug 13, 1:40 AM
kadircet updated the diff for D50555: [clangd] Introduce scoring mechanism for SignatureInformations..
  • Rebase & Resolve discussions.
  • Resolve discussions.
Mon, Aug 13, 1:34 AM
kadircet committed rCTE339543: [clangd] Support textEdit in addition to insertText..
[clangd] Support textEdit in addition to insertText.
Mon, Aug 13, 1:24 AM
kadircet committed rL339543: [clangd] Support textEdit in addition to insertText..
[clangd] Support textEdit in addition to insertText.
Mon, Aug 13, 1:23 AM
kadircet closed D50449: [clangd] Support textEdit in addition to insertText..
Mon, Aug 13, 1:23 AM
kadircet updated the diff for D50449: [clangd] Support textEdit in addition to insertText..
  • Rebase.
  • Resolve discussions.
Mon, Aug 13, 1:21 AM
kadircet committed rC339540: [clang] Store code completion token range in preprocessor..
[clang] Store code completion token range in preprocessor.
Mon, Aug 13, 1:14 AM
kadircet committed rL339540: [clang] Store code completion token range in preprocessor..
[clang] Store code completion token range in preprocessor.
Mon, Aug 13, 1:14 AM
kadircet closed D50443: [clang] Store code completion token range in preprocessor..
Mon, Aug 13, 1:14 AM
kadircet updated the summary of D50443: [clang] Store code completion token range in preprocessor..
Mon, Aug 13, 1:10 AM
kadircet updated the diff for D50443: [clang] Store code completion token range in preprocessor..
  • Resolve discussions.
  • Fix typo.
Mon, Aug 13, 1:10 AM

Fri, Aug 10

kadircet updated the diff for D50555: [clangd] Introduce scoring mechanism for SignatureInformations..
  • Resolve discussions.
Fri, Aug 10, 6:10 AM
kadircet added inline comments to D50449: [clangd] Support textEdit in addition to insertText..
Fri, Aug 10, 2:22 AM
kadircet updated the diff for D50449: [clangd] Support textEdit in addition to insertText..
  • Resolve discussions.
Fri, Aug 10, 2:21 AM
kadircet created D50555: [clangd] Introduce scoring mechanism for SignatureInformations..
Fri, Aug 10, 1:45 AM

Thu, Aug 9

kadircet created D50502: [clangd] Initial cancellation mechanism for LSP requests..
Thu, Aug 9, 3:48 AM

Wed, Aug 8

kadircet created D50449: [clangd] Support textEdit in addition to insertText..
Wed, Aug 8, 7:01 AM
kadircet updated the diff for D50443: [clang] Store code completion token range in preprocessor..
  • Resolve discussions.
Wed, Aug 8, 6:21 AM
kadircet updated the summary of D50443: [clang] Store code completion token range in preprocessor..
Wed, Aug 8, 6:20 AM
kadircet retitled D50443: [clang] Store code completion token range in preprocessor. from [clang] Store code completion token range in preprocessor. This change is to support a new fature in clangd, tests will be send to clang-tools-extra with that change. to [clang] Store code completion token range in preprocessor..
Wed, Aug 8, 6:20 AM
kadircet created D50443: [clang] Store code completion token range in preprocessor..
Wed, Aug 8, 6:06 AM
kadircet committed rL339224: Added functionality to suggest FixIts for conversion of '->' to '.' and vice….
Added functionality to suggest FixIts for conversion of '->' to '.' and vice…
Wed, Aug 8, 2:00 AM
kadircet committed rCTE339224: Added functionality to suggest FixIts for conversion of '->' to '.' and vice….
Added functionality to suggest FixIts for conversion of '->' to '.' and vice…
Wed, Aug 8, 2:00 AM
kadircet closed D50193: Added functionality to suggest FixIts for conversion of '->' to '.' and vice versa..
Wed, Aug 8, 2:00 AM
kadircet updated the diff for D50193: Added functionality to suggest FixIts for conversion of '->' to '.' and vice versa..
  • Resolve some more discussions.
Wed, Aug 8, 1:05 AM

Tue, Aug 7

kadircet updated the diff for D50193: Added functionality to suggest FixIts for conversion of '->' to '.' and vice versa..
  • Resolve discussions.
Tue, Aug 7, 7:51 AM

Mon, Aug 6

kadircet updated the diff for D50193: Added functionality to suggest FixIts for conversion of '->' to '.' and vice versa..

Added functionality to suggest FixIts for conversion of '->' to '.' and vice versa.

  • Fixes for comments.
  • Take unnecessary patches back
  • Second pass for comments.
  • Add downranking for scores of fixit elements.
Mon, Aug 6, 2:21 AM

Fri, Aug 3

kadircet updated the diff for D50193: Added functionality to suggest FixIts for conversion of '->' to '.' and vice versa..

Fixed discussions

Fri, Aug 3, 6:54 AM

Thu, Aug 2

kadircet created D50193: Added functionality to suggest FixIts for conversion of '->' to '.' and vice versa..
Thu, Aug 2, 9:42 AM

Feb 26 2018

kadircet added a comment to D43303: [Format] Fix for bug 35641.

ping

Feb 26 2018, 10:00 PM · Restricted Project

Feb 18 2018

kadircet updated the diff for D43303: [Format] Fix for bug 35641.

Rebased and uploaded diff to the master. Sorry for the inconvenience.

Feb 18 2018, 2:57 AM · Restricted Project
kadircet added a comment to D43303: [Format] Fix for bug 35641.

Btw, I cannot commit the change myself, don't have commit rights.

Feb 18 2018, 2:25 AM · Restricted Project

Feb 15 2018

kadircet updated the diff for D43303: [Format] Fix for bug 35641.

Changed description of unit test to include direct link to bug.
Used different variable types to make sure alignment happens.

Feb 15 2018, 6:04 AM · Restricted Project

Feb 14 2018

kadircet created D43303: [Format] Fix for bug 35641.
Feb 14 2018, 10:54 AM · Restricted Project