Page MenuHomePhabricator

kadircet (Kadir Cetinkaya)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 14 2018, 2:16 AM (228 w, 21 h)

Recent Activity

Yesterday

kadircet committed rG333620d37a26: [clangd] Support multiline semantic tokens (authored by kadircet).
[clangd] Support multiline semantic tokens
Wed, Jun 29, 4:49 AM · Restricted Project, Restricted Project
kadircet closed D127856: [clangd] Support multiline semantic tokens.
Wed, Jun 29, 4:49 AM · Restricted Project, Restricted Project

Mon, Jun 27

kadircet added inline comments to D128621: [clangd] Do not try to use $0 as a placeholder in completion snippets.
Mon, Jun 27, 1:17 AM · Restricted Project, Restricted Project

Fri, Jun 24

kadircet added a comment to D122677: [prototype] include-cleaner library.

hi Serge, sorry for the silence here. we'll be moving this towards a production ready version over the next months (also releasing some comments i've forgotten to send, we've already discussed these offline so no need for action).
we'll probably be leaving some todos/fixmes as we go, if you want to help it'd be great to keep an eye on changes going into the clang-tools-extra/include-cleaner directory (i'll also try to add you as a subscriber to them) and mention things you'd be interested in picking up.

Fri, Jun 24, 6:50 AM · Restricted Project, Restricted Project, Restricted Project
kadircet added a comment to D128379: [clangd] Change the url for clang-tidy check documentation.

luckily this document links were introduced only recently, hence they didn't make it to clangd-14, but they'll start being around from clangd-15 and such changes will be breaking all the links in existing clangd's.
i wonder if we should actually point these at releases.llvm.org/CLANG_VERSION/... instead of top of the head:

  • downside, we don't have a release until it's there, so everything will be broken with a non-released clangd.

i suppose we can make use of different urls based on build configuration, but i couldn't find any existing mechanisms for doing so. hence this needs to be introduced.
another option would be to have a redirection from releases.llvm.org/15.0.0 to clang.llvm.org, until it's released, but the directory structure/subdomain is different so this will also need some adjustments.

Fri, Jun 24, 6:12 AM · Restricted Project, Restricted Project

Wed, Jun 22

kadircet added a comment to D128204: [clangd] Add fix-it for inserting IWYU pragma: keep.

I had another idea about offering the export pragma when in a header file but I don't know if that's going too far

Wed, Jun 22, 12:09 AM · Restricted Project, Restricted Project

Tue, Jun 21

kadircet added a comment to D126859: [clangd] Validate clang-tidy CheckOptions in clangd config.

I also agree with the typo correction verdict. In theory there'll be two cases:

  • typo correction helps, in which case it'll be obvious from the warning itself.
  • typo correction doesn't help, because the option doesn't exist at all, we'll be just showing a random option. I don't think how this'll be helpful.
Tue, Jun 21, 8:50 AM · Restricted Project, Restricted Project
kadircet added a comment to D128204: [clangd] Add fix-it for inserting IWYU pragma: keep.

as discussed offline I agree that we should have this, as no matter how hard we try there are going to be cases that we can't get right due to ADL/template instantiations or depending on 3rd party code that cannot be edited and also doesn't have relevant pragmas inside.

Tue, Jun 21, 8:34 AM · Restricted Project, Restricted Project
kadircet added inline comments to D127856: [clangd] Support multiline semantic tokens.
Tue, Jun 21, 8:18 AM · Restricted Project, Restricted Project
kadircet updated the diff for D127856: [clangd] Support multiline semantic tokens.

Get rid of the copy in common case

Tue, Jun 21, 8:18 AM · Restricted Project, Restricted Project

Mon, Jun 20

kadircet committed rG1c92e06ded2d: [clangd] Handle initializers that contain = (authored by kadircet).
[clangd] Handle initializers that contain =
Mon, Jun 20, 7:43 AM · Restricted Project, Restricted Project
kadircet closed D128197: [clangd] Handle initializers that contain =.
Mon, Jun 20, 7:43 AM · Restricted Project, Restricted Project
kadircet added inline comments to D127856: [clangd] Support multiline semantic tokens.
Mon, Jun 20, 7:29 AM · Restricted Project, Restricted Project
kadircet updated the diff for D127856: [clangd] Support multiline semantic tokens.

Split highlights into multiple tokens rather than trimming

Mon, Jun 20, 7:29 AM · Restricted Project, Restricted Project
kadircet requested review of D128197: [clangd] Handle initializers that contain =.
Mon, Jun 20, 6:23 AM · Restricted Project, Restricted Project

Fri, Jun 17

kadircet added a reverting change for rG7aac15d5df6c: Revert "[clang] Dont print implicit forrange initializer": rG1a02c963e338: Revert "Revert "[clang] Dont print implicit forrange initializer"".
Fri, Jun 17, 7:51 AM · Restricted Project, Restricted Project
kadircet committed rG1a02c963e338: Revert "Revert "[clang] Dont print implicit forrange initializer"" (authored by kadircet).
Revert "Revert "[clang] Dont print implicit forrange initializer""
Fri, Jun 17, 7:51 AM · Restricted Project, Restricted Project
kadircet updated subscribers of D127863: [clang] Dont print implicit forrange initializer.

thanks for the revert, you beat me to it.

Fri, Jun 17, 6:09 AM · Restricted Project, Restricted Project
kadircet committed rG32805e60c9de: [clang] Dont print implicit forrange initializer (authored by kadircet).
[clang] Dont print implicit forrange initializer
Fri, Jun 17, 2:30 AM · Restricted Project, Restricted Project
kadircet closed D127863: [clang] Dont print implicit forrange initializer.
Fri, Jun 17, 2:30 AM · Restricted Project, Restricted Project

Wed, Jun 15

kadircet requested review of D127863: [clang] Dont print implicit forrange initializer.
Wed, Jun 15, 7:56 AM · Restricted Project, Restricted Project
kadircet committed rG04735302814e: [clangd][NFC] Use the existing ASTContext from scope (authored by kadircet).
[clangd][NFC] Use the existing ASTContext from scope
Wed, Jun 15, 7:13 AM · Restricted Project, Restricted Project
kadircet committed rG7212977fbb41: [clangd] Always desugar type aliases in hover (authored by kadircet).
[clangd] Always desugar type aliases in hover
Wed, Jun 15, 7:13 AM · Restricted Project, Restricted Project
kadircet closed D127832: [clangd] Always desugar type aliases in hover.
Wed, Jun 15, 7:13 AM · Restricted Project, Restricted Project
kadircet updated the diff for D127832: [clangd] Always desugar type aliases in hover.
  • Leave the Ctx refactoring out of the patch.
Wed, Jun 15, 7:09 AM · Restricted Project, Restricted Project
kadircet committed rG462def25ec13: [clang] Use correct visibility parameters when following a Using declaration (authored by furkanusta).
[clang] Use correct visibility parameters when following a Using declaration
Wed, Jun 15, 6:53 AM · Restricted Project, Restricted Project, Restricted Project
kadircet closed D127629: [clang] Use correct visibility parameters when following a Using declaration.
Wed, Jun 15, 6:53 AM · Restricted Project, Restricted Project, Restricted Project
kadircet updated subscribers of D127629: [clang] Use correct visibility parameters when following a Using declaration.

thanks! you're right, it was already included in the arcanist metadata, i
was too lazy to check beforehand, sorry.

Wed, Jun 15, 6:48 AM · Restricted Project, Restricted Project, Restricted Project
kadircet requested review of D127856: [clangd] Support multiline semantic tokens.
Wed, Jun 15, 6:46 AM · Restricted Project, Restricted Project
kadircet updated the diff for D127844: [clangd] Pull suppression logic into common path, apply for driver diagnostics.

Just pass optional directly

Wed, Jun 15, 4:27 AM · Restricted Project, Restricted Project
kadircet requested review of D127844: [clangd] Pull suppression logic into common path, apply for driver diagnostics.
Wed, Jun 15, 4:19 AM · Restricted Project, Restricted Project
kadircet committed rGa67beef3acac: [clangd] Enable AKA type printing by default (authored by kadircet).
[clangd] Enable AKA type printing by default
Wed, Jun 15, 1:48 AM · Restricted Project, Restricted Project
kadircet closed D127833: [clangd] Enable AKA type printing by default.
Wed, Jun 15, 1:48 AM · Restricted Project, Restricted Project
kadircet added a reviewer for D127833: [clangd] Enable AKA type printing by default: ilya-biryukov.
Wed, Jun 15, 1:33 AM · Restricted Project, Restricted Project
kadircet added a reviewer for D127832: [clangd] Always desugar type aliases in hover: ilya-biryukov.
Wed, Jun 15, 1:33 AM · Restricted Project, Restricted Project
kadircet accepted D127629: [clang] Use correct visibility parameters when following a Using declaration.

do you have commit access or should i land this for you? if i should, can you provide an email address for attribution of the commit

Wed, Jun 15, 1:11 AM · Restricted Project, Restricted Project, Restricted Project
kadircet requested review of D127833: [clangd] Enable AKA type printing by default.
Wed, Jun 15, 1:07 AM · Restricted Project, Restricted Project
kadircet requested review of D127832: [clangd] Always desugar type aliases in hover.
Wed, Jun 15, 1:06 AM · Restricted Project, Restricted Project
kadircet accepted D127125: [clangd] Improve ObjC protocol suggestions from the index.

thanks, lgtm!

Wed, Jun 15, 12:17 AM · Restricted Project, Restricted Project

Tue, Jun 14

kadircet committed rG3ecfeb4c2f45: [clangd] Wire up compilation for style blocks (authored by kadircet).
[clangd] Wire up compilation for style blocks
Tue, Jun 14, 11:19 PM · Restricted Project, Restricted Project
kadircet closed D127749: [clangd] Wire up compilation for style blocks.
Tue, Jun 14, 11:19 PM · Restricted Project, Restricted Project
kadircet requested review of D127749: [clangd] Wire up compilation for style blocks.
Tue, Jun 14, 8:08 AM · Restricted Project, Restricted Project

Mon, Jun 13

kadircet added a comment to D127629: [clang] Use correct visibility parameters when following a Using declaration.

Also if you put Fixes https://github.com/clangd/clangd/issues/1137 in the commit message, it'll automatically close the issue.

Mon, Jun 13, 6:00 AM · Restricted Project, Restricted Project, Restricted Project
kadircet added a reviewer for D127629: [clang] Use correct visibility parameters when following a Using declaration: kadircet.
Mon, Jun 13, 5:59 AM · Restricted Project, Restricted Project, Restricted Project

May 19 2022

kadircet accepted D125925: Add an option to fill container for ref.

thanks, lgtm!

May 19 2022, 7:01 AM · Restricted Project, Restricted Project
kadircet added a comment to D125925: Add an option to fill container for ref.

Can you also update the remote-index protos & marshalling logic in:

  • clang-tools-extra/clangd/index/remote/Index.proto
  • clang-tools-extra/clangd/index/remote/marshalling/Marshalling.cpp
May 19 2022, 3:08 AM · Restricted Project, Restricted Project

May 18 2022

kadircet added a comment to D125863: [clangd] Dont mark terminating PP-directives as skipped.

sorry, I might be lack of the context, where is the user complaint? I'm not sure which cases are improved with this patch.

May 18 2022, 7:35 AM · Restricted Project, Restricted Project
kadircet added inline comments to D125684: [clangd] Support UnresolvedUsingTypeLoc AST node in FindTarget..
May 18 2022, 3:55 AM · Restricted Project, Restricted Project
kadircet accepted D125684: [clangd] Support UnresolvedUsingTypeLoc AST node in FindTarget..

thanks!

May 18 2022, 3:54 AM · Restricted Project, Restricted Project
kadircet requested review of D125863: [clangd] Dont mark terminating PP-directives as skipped.
May 18 2022, 2:21 AM · Restricted Project, Restricted Project

May 16 2022

kadircet accepted D115232: [clangd] Indexing of standard library.

sorry for the long turn around here, LGTM. let's ship it!

May 16 2022, 8:42 AM · Restricted Project, Restricted Project
kadircet accepted D125675: Optimise findRefs for XRefs and docHighlights.

thanks for noticing this, LGTM!

May 16 2022, 6:56 AM · Restricted Project, Restricted Project
kadircet accepted D125682: Add documentHighlight in clangd check for performance measurements..
May 16 2022, 6:29 AM · Restricted Project, Restricted Project
kadircet added a reviewer for D125675: Optimise findRefs for XRefs and docHighlights: kadircet.

66% win sounds great, it would be nice to have some detailed numbers (but this is clearly a huge win, so no need to reperform the experiments if numbers are gone)

May 16 2022, 3:12 AM · Restricted Project, Restricted Project
kadircet accepted D125673: [clangd] Add command-line flag to set background indexing thread priority..

thanks, LGTM. i agree that having this as a config to let users prioritise some sources over others could be useful, but it's too intrusive and unclear how useful that would be in practice (i don't think people would care to write a separate config for those)

May 16 2022, 2:53 AM · Restricted Project, Restricted Project

May 13 2022

kadircet added inline comments to D125468: [clangd] Include Cleaner: ignore headers with IWYU export pragmas.
May 13 2022, 4:46 AM · Restricted Project, Restricted Project

May 11 2022

kadircet added inline comments to D121733: Clean pathnames in FileManager..
May 11 2022, 10:44 AM · Restricted Project, Restricted Project, Restricted Project

May 10 2022

kadircet committed rG3137ca80b9ef: [clangd] Support for standard inlayHint protocol (authored by kadircet).
[clangd] Support for standard inlayHint protocol
May 10 2022, 10:00 AM · Restricted Project, Restricted Project
kadircet closed D125228: [clangd] Support for standard inlayHint protocol.
May 10 2022, 9:59 AM · Restricted Project, Restricted Project
kadircet updated the diff for D125228: [clangd] Support for standard inlayHint protocol.
  • Default initialize paddingLeft/Right
  • Don't serialize kind when its null
  • Run in vscode, seems to be working.
May 10 2022, 9:48 AM · Restricted Project, Restricted Project
kadircet updated the diff for D125228: [clangd] Support for standard inlayHint protocol.
  • Advertise inlayHintProvider
May 10 2022, 7:23 AM · Restricted Project, Restricted Project
kadircet added inline comments to D125228: [clangd] Support for standard inlayHint protocol.
May 10 2022, 7:17 AM · Restricted Project, Restricted Project
kadircet updated the diff for D125228: [clangd] Support for standard inlayHint protocol.
  • Get rid of warning and not advertising when client has capability.
  • Introduce paddingLeft/paddingRight, get rid of leading/trailing spaces in label, but re-introduce them when serializing for extension.
  • Update documentation to reflect LSP docs.
May 10 2022, 7:17 AM · Restricted Project, Restricted Project

May 9 2022

kadircet updated the diff for D125228: [clangd] Support for standard inlayHint protocol.
  • Mention range as an extension field.
May 9 2022, 8:06 AM · Restricted Project, Restricted Project
kadircet updated the diff for D125228: [clangd] Support for standard inlayHint protocol.
  • Add lit test
May 9 2022, 6:53 AM · Restricted Project, Restricted Project
kadircet requested review of D125228: [clangd] Support for standard inlayHint protocol.
May 9 2022, 6:49 AM · Restricted Project, Restricted Project
kadircet accepted D125180: [Frontend] when attaching a preamble, don't generate the long predefines buffer..
May 9 2022, 5:54 AM · Restricted Project, Restricted Project
kadircet added a comment to D125179: [clangd] Skip (most) predefined macros when scanning for preamble patching..

Thx, LGTM. I agree that figuring out includes/macros in conditional branches is already best-effort, so I don't think this will result in noticeable regressions.

May 9 2022, 2:49 AM · Restricted Project, Restricted Project
kadircet accepted D125149: [Frontend] Flip default of CreateInvocationOptions::ProbePrecompiled to false.
May 9 2022, 2:46 AM · Restricted Project, Restricted Project
kadircet closed D125088: [clangd] Add parsing for IgnoreHeaders config option.

Landed as rG9fe89a1f0fa6d88aa4786580b89e81dc906fcc52

May 9 2022, 1:24 AM · Restricted Project, Restricted Project

May 6 2022

kadircet committed rG9fe89a1f0fa6: [clangd] Add parsing for IgnoreHeaders config option (authored by kadircet).
[clangd] Add parsing for IgnoreHeaders config option
May 6 2022, 7:12 AM · Restricted Project, Restricted Project
kadircet requested review of D125088: [clangd] Add parsing for IgnoreHeaders config option.
May 6 2022, 5:35 AM · Restricted Project, Restricted Project
kadircet accepted D125012: [clang] createInvocationFromCommandLine -> createInvocation, delete former. NFC.

thanks, lgtm!

May 6 2022, 3:43 AM · Restricted Project, Restricted Project, Restricted Project

May 5 2022

kadircet added a comment to D124715: Add ThreadPriority::Low, and use QoS class Utility on Mac.

I agree that clangd's indexing should probably be higher priority than whatever FS indexing is going on (because clangd's indexing only start when user actually starts working on a project, hence this indicates some level of "interactiveness"). so I feel like the right default is Utility, rather than Background.
But we had this behavior for a long while and people didn't complain up until M1s. So this is definitely going to result in some behavior change for intel users, even if we agree on this is making the state better for M1s.
Unfortunately I am not in a position to say what does the Utility vs Background imply for intel chips for sure, to tell the behavior change isn't going to be a regression. If this renders next clangd unusable by intel mac folks, it would be really unfortunate.

May 5 2022, 6:20 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
kadircet accepted D124970: [Driver] Make "upgrade" of -include to include-pch optional; disable in clangd.

as discussed offline, let's move forward with what you proposed (i.e. this patch, and then flip the default while making libclang opt-in)

May 5 2022, 6:02 AM · Restricted Project, Restricted Project, Restricted Project
kadircet added a comment to D124971: [Frontend] give createInvocationFromCommandLine an options struct.

Thanks this LGTM. Just two questions:

  • Why not migrate rest of the usages and drop the old function completely in this patch
  • What about moving the function from clang/Frontend to Tooling, Support or FrontendTool? this is clearly only inteded to be used by tools and not part of the Frontend. There's actually Tooling/Tooling.h which has a newInvocation that takes in cc1 args, rather than driver args. so these two seem like siblings.
May 5 2022, 5:35 AM · Restricted Project, Restricted Project, Restricted Project

Apr 29 2022

kadircet accepted D124679: [clangd] More precisely enable clang warnings through ClangTidy options.

thanks, lgtm!

Apr 29 2022, 9:10 AM · Restricted Project, Restricted Project, Restricted Project

Apr 28 2022

kadircet committed rG5e4a77f0c4e7: [clangd] Record latency for ASTSignal derivation (authored by kadircet).
[clangd] Record latency for ASTSignal derivation
Apr 28 2022, 5:35 AM · Restricted Project, Restricted Project

Apr 27 2022

kadircet accepted D124164: [include-cleaner] Include-cleaner library structure, and simplistic AST walking..

thanks, as discussed offline. this mostly LG. there are concerns about more code re-use, especially around handling pragmas but we should probably address them as we go rather than now.

Apr 27 2022, 5:29 AM · Restricted Project, Restricted Project, Restricted Project

Apr 26 2022

kadircet accepted D124427: [Serialization] Pack Expr ObjectKind and ValueKind into one VBR..

thanks, lgtm!

Apr 26 2022, 1:24 AM · Restricted Project, Restricted Project

Apr 25 2022

kadircet added a comment to D124344: [clangd] Output inlay hints with `clangd --check`.

can you please upload the patch with full context? see https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface

Apr 25 2022, 12:48 AM · Restricted Project, Restricted Project

Apr 22 2022

kadircet accepted D124242: [Frontend] shrink in-memory PCH buffers to fit.
Apr 22 2022, 9:09 AM · Restricted Project, Restricted Project
kadircet committed rG2efccf5166f4: [clangd][NFC] Reduce memory usage while building dex (authored by kadircet).
[clangd][NFC] Reduce memory usage while building dex
Apr 22 2022, 8:45 AM · Restricted Project, Restricted Project
kadircet closed D124240: [clangd][NFC] Reduce memory usage while building dex.
Apr 22 2022, 8:45 AM · Restricted Project, Restricted Project
kadircet updated the diff for D124240: [clangd][NFC] Reduce memory usage while building dex.

Copy-assign to empty containers rather than clear.

Apr 22 2022, 8:40 AM · Restricted Project, Restricted Project
kadircet added inline comments to D124240: [clangd][NFC] Reduce memory usage while building dex.
Apr 22 2022, 5:51 AM · Restricted Project, Restricted Project
kadircet updated the diff for D124240: [clangd][NFC] Reduce memory usage while building dex.

Get rid of shrink_to_fit as PostingList representation doesn't really make a copy of the vector, but rather build a new representation.

Apr 22 2022, 2:22 AM · Restricted Project, Restricted Project
kadircet requested review of D124240: [clangd][NFC] Reduce memory usage while building dex.
Apr 22 2022, 1:51 AM · Restricted Project, Restricted Project

Apr 21 2022

kadircet accepted D124176: [clangd] Add beforeExecute() callback to FeatureModules..

thanks, lgtm!

Apr 21 2022, 8:02 AM · Restricted Project, Restricted Project

Apr 20 2022

kadircet closed D123289: [clangd][SymbolCollector] Introduce a cache for SymbolID generation and some cleanups.

Landed in 001e88ac83b5c3a4d4f4e61480953ebcabc82b88

Apr 20 2022, 4:37 AM · Restricted Project, Restricted Project

Apr 19 2022

kadircet committed rG1aa3a54921a1: [clangd] Dont include version string in update tasks (authored by kadircet).
[clangd] Dont include version string in update tasks
Apr 19 2022, 10:27 AM · Restricted Project, Restricted Project
kadircet closed D124013: [clangd] Dont include version string in update tasks.
Apr 19 2022, 10:27 AM · Restricted Project, Restricted Project
kadircet requested review of D124013: [clangd] Dont include version string in update tasks.
Apr 19 2022, 9:26 AM · Restricted Project, Restricted Project

Apr 11 2022

kadircet committed rG001e88ac83b5: [clangd] Performance improvements and cleanup (authored by kadircet).
[clangd] Performance improvements and cleanup
Apr 11 2022, 8:22 AM · Restricted Project, Restricted Project
kadircet added inline comments to D123289: [clangd][SymbolCollector] Introduce a cache for SymbolID generation and some cleanups.
Apr 11 2022, 2:47 AM · Restricted Project, Restricted Project
kadircet accepted D123478: [clangd] Fix incorrect operator< impl for HighlightingToken.

Oopsy :/ Thanks for the fix!

Apr 11 2022, 2:38 AM · Restricted Project, Restricted Project
kadircet added inline comments to D123289: [clangd][SymbolCollector] Introduce a cache for SymbolID generation and some cleanups.
Apr 11 2022, 2:32 AM · Restricted Project, Restricted Project
kadircet updated the diff for D123289: [clangd][SymbolCollector] Introduce a cache for SymbolID generation and some cleanups.
  • Get rid of leftovers and update comments
Apr 11 2022, 2:31 AM · Restricted Project, Restricted Project
kadircet updated the summary of D123289: [clangd][SymbolCollector] Introduce a cache for SymbolID generation and some cleanups.
Apr 11 2022, 1:41 AM · Restricted Project, Restricted Project
kadircet updated the diff for D123289: [clangd][SymbolCollector] Introduce a cache for SymbolID generation and some cleanups.
  • Address comments and more cleanups
Apr 11 2022, 1:40 AM · Restricted Project, Restricted Project