Page MenuHomePhabricator

kadircet (Kadir Cetinkaya)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 14 2018, 2:16 AM (43 w, 6 d)

Recent Activity

Yesterday

kadircet added inline comments to D55224: [clangd] Introduce loading of shards within auto-index.
Tue, Dec 18, 8:15 AM
kadircet updated the diff for D55818: [clangd] Unify path canonicalizations in the codebase.
  • Address comments
Tue, Dec 18, 8:15 AM
kadircet added inline comments to D55818: [clangd] Unify path canonicalizations in the codebase.
Tue, Dec 18, 8:15 AM
kadircet updated the diff for D55224: [clangd] Introduce loading of shards within auto-index.
  • Address comments
Tue, Dec 18, 7:35 AM
kadircet accepted D55770: [clangd] BackgroundIndex rebuilds symbol index periodically..

LGTM, thanks!

Tue, Dec 18, 7:33 AM
kadircet added inline comments to D55770: [clangd] BackgroundIndex rebuilds symbol index periodically..
Tue, Dec 18, 7:11 AM
kadircet added inline comments to D55770: [clangd] BackgroundIndex rebuilds symbol index periodically..
Tue, Dec 18, 7:06 AM
kadircet added inline comments to D55770: [clangd] BackgroundIndex rebuilds symbol index periodically..
Tue, Dec 18, 4:59 AM
kadircet added a comment to D55224: [clangd] Introduce loading of shards within auto-index.

Sending out everything related to canonical path at: D55818

Tue, Dec 18, 3:38 AM
kadircet created D55818: [clangd] Unify path canonicalizations in the codebase.
Tue, Dec 18, 3:34 AM

Mon, Dec 17

kadircet added inline comments to D55770: [clangd] BackgroundIndex rebuilds symbol index periodically..
Mon, Dec 17, 9:43 AM
kadircet committed rCTE349348: [clangd] Change diskbackedstorage to be atomic.
[clangd] Change diskbackedstorage to be atomic
Mon, Dec 17, 4:41 AM
kadircet committed rL349348: [clangd] Change diskbackedstorage to be atomic.
[clangd] Change diskbackedstorage to be atomic
Mon, Dec 17, 4:41 AM
kadircet closed D55417: [clangd] Change disk-backed storage to be atomic.
Mon, Dec 17, 4:41 AM
kadircet updated the diff for D55417: [clangd] Change disk-backed storage to be atomic.
  • Address comments
Mon, Dec 17, 4:41 AM
kadircet committed rCTE349345: [clangd] Only reduce priority of a thread for indexing..
[clangd] Only reduce priority of a thread for indexing.
Mon, Dec 17, 4:33 AM
kadircet committed rL349345: [clangd] Only reduce priority of a thread for indexing..
[clangd] Only reduce priority of a thread for indexing.
Mon, Dec 17, 4:33 AM
kadircet closed D55315: [clangd] Only reduce priority of a thread for indexing..
Mon, Dec 17, 4:33 AM
kadircet updated the diff for D55315: [clangd] Only reduce priority of a thread for indexing..
  • Revert name from Tasks to Queue
Mon, Dec 17, 4:31 AM

Fri, Dec 14

kadircet committed rCTE349152: [dexp] Change FuzzyFind to also print scope of symbols.
[dexp] Change FuzzyFind to also print scope of symbols
Fri, Dec 14, 6:20 AM
kadircet committed rL349152: [dexp] Change FuzzyFind to also print scope of symbols.
[dexp] Change FuzzyFind to also print scope of symbols
Fri, Dec 14, 6:20 AM
kadircet closed D55705: [dexp] Change FuzzyFind to also print scope of symbols.
Fri, Dec 14, 6:20 AM
kadircet created D55705: [dexp] Change FuzzyFind to also print scope of symbols.
Fri, Dec 14, 6:11 AM
kadircet accepted D55702: [clangd] Fix memory leak in ClangdTests..

LGTM, thanks!

Fri, Dec 14, 5:18 AM
kadircet accepted D55650: [clangd] Fix an assertion failure in background index..

LGTM, thanks!

Fri, Dec 14, 3:36 AM
kadircet added a comment to D55650: [clangd] Fix an assertion failure in background index..

Ah you are right, the Optional.. Thanks!

Fri, Dec 14, 2:41 AM

Thu, Dec 13

kadircet updated the diff for D55315: [clangd] Only reduce priority of a thread for indexing..
  • Use std::deque instead of std::list
Thu, Dec 13, 10:37 AM
kadircet added inline comments to D55315: [clangd] Only reduce priority of a thread for indexing..
Thu, Dec 13, 10:37 AM
kadircet added inline comments to D55648: [CodeComplete] Fill preferred type on binary expressions.
Thu, Dec 13, 8:04 AM
kadircet added inline comments to D55315: [clangd] Only reduce priority of a thread for indexing..
Thu, Dec 13, 8:00 AM
kadircet added inline comments to D55649: [clangd] Enable cross-namespace completions by default in clangd.
Thu, Dec 13, 7:14 AM
kadircet updated the diff for D55417: [clangd] Change disk-backed storage to be atomic.
  • Use creauteUniqueFile.
  • Don't remove on success.
Thu, Dec 13, 7:10 AM
kadircet updated the diff for D55315: [clangd] Only reduce priority of a thread for indexing..
  • Address comments
Thu, Dec 13, 6:50 AM
kadircet added inline comments to D55649: [clangd] Enable cross-namespace completions by default in clangd.
Thu, Dec 13, 6:35 AM
kadircet added a comment to D55650: [clangd] Fix an assertion failure in background index..

I think the description is misleading, you are saying that we were triggering an assertion and you are fixing that. But in reality, we were not triggering any assertions, this patch is adding the assertions right?

Thu, Dec 13, 6:33 AM
kadircet accepted D55648: [CodeComplete] Fill preferred type on binary expressions.

It seems like we have some assumptions about what people might be trying to do in most of the cases, but i think it is OK since this never performs worse than the older version.

Thu, Dec 13, 5:54 AM

Fri, Dec 7

kadircet accepted D55431: [CodeComplete] Set preferred type to bool on conditions.

LGTM

Fri, Dec 7, 6:46 AM
kadircet added inline comments to D55315: [clangd] Only reduce priority of a thread for indexing..
Fri, Dec 7, 5:24 AM
kadircet updated the diff for D55315: [clangd] Only reduce priority of a thread for indexing..
  • Move priority change logic to runner
  • Change storage for tasks from deque to list, since we only pop from front but we might end up adding into middle.
Fri, Dec 7, 5:24 AM
kadircet updated the diff for D55417: [clangd] Change disk-backed storage to be atomic.
  • Address comments
Fri, Dec 7, 4:57 AM
kadircet retitled D55417: [clangd] Change disk-backed storage to be atomic from [clangd] Change diskbackedstorage to be atomic to [clangd] Change disk-backed storage to be atomic.
Fri, Dec 7, 4:35 AM
kadircet updated the diff for D55417: [clangd] Change disk-backed storage to be atomic.
  • Fix returns
Fri, Dec 7, 1:45 AM
kadircet created D55417: [clangd] Change disk-backed storage to be atomic.
Fri, Dec 7, 1:37 AM

Thu, Dec 6

kadircet added inline comments to D55315: [clangd] Only reduce priority of a thread for indexing..
Thu, Dec 6, 10:42 AM
kadircet updated the diff for D55315: [clangd] Only reduce priority of a thread for indexing..
  • Delete redundant comment
Thu, Dec 6, 10:38 AM
kadircet updated the diff for D55224: [clangd] Introduce loading of shards within auto-index.
  • Fix a few problems that come up in the field test.
Thu, Dec 6, 10:30 AM
kadircet accepted D55331: [CodeComplete] Fix assertion failure.

LGTM

Thu, Dec 6, 2:19 AM

Wed, Dec 5

kadircet accepted D55260: [CodeComplete] Fix a crash in access checks of inner classes.

LGTM, thanks!

Wed, Dec 5, 8:08 AM
kadircet updated the diff for D55315: [clangd] Only reduce priority of a thread for indexing..
  • Move priority change logic into enqueueTask
Wed, Dec 5, 8:07 AM
kadircet created D55315: [clangd] Only reduce priority of a thread for indexing..
Wed, Dec 5, 4:28 AM
kadircet committed rCTE348359: [clangd] Dont provide locations for non-existent files..
[clangd] Dont provide locations for non-existent files.
Wed, Dec 5, 4:00 AM
kadircet committed rL348359: [clangd] Dont provide locations for non-existent files..
[clangd] Dont provide locations for non-existent files.
Wed, Dec 5, 4:00 AM
kadircet closed D55275: [clangd] Dont provide locations for non-existent files..
Wed, Dec 5, 4:00 AM
kadircet updated the diff for D55275: [clangd] Dont provide locations for non-existent files..
Wed, Dec 5, 1:21 AM

Tue, Dec 4

kadircet created D55275: [clangd] Dont provide locations for non-existent files..
Tue, Dec 4, 8:34 AM
kadircet added a comment to D55260: [CodeComplete] Fix a crash in access checks of inner classes.

I believe also we need another test case where Cls and NamingClass are different.

Tue, Dec 4, 3:43 AM
kadircet committed rCTE348252: [clangd] Partition include graph on auto-index..
[clangd] Partition include graph on auto-index.
Tue, Dec 4, 3:36 AM
kadircet committed rL348252: [clangd] Partition include graph on auto-index..
[clangd] Partition include graph on auto-index.
Tue, Dec 4, 3:35 AM
kadircet closed D55062: [clangd] Partition include graph on auto-index..
Tue, Dec 4, 3:35 AM
kadircet updated the diff for D55062: [clangd] Partition include graph on auto-index..
  • Address comments
Tue, Dec 4, 3:34 AM
kadircet added inline comments to D55260: [CodeComplete] Fix a crash in access checks of inner classes.
Tue, Dec 4, 3:31 AM

Mon, Dec 3

kadircet updated the diff for D55062: [clangd] Partition include graph on auto-index..
  • Addresss comments
  • Make sure there are no uninitialized values in IncludeGraphNode.
Mon, Dec 3, 8:37 AM
kadircet created D55224: [clangd] Introduce loading of shards within auto-index.
Mon, Dec 3, 8:04 AM
kadircet updated the diff for D55062: [clangd] Partition include graph on auto-index..
  • Rebase
Mon, Dec 3, 3:28 AM
kadircet added inline comments to D55206: [clangd] Get rid of AST matchers in CodeComplete, NFC.
Mon, Dec 3, 3:08 AM
kadircet accepted D55206: [clangd] Get rid of AST matchers in CodeComplete, NFC.

LG

Mon, Dec 3, 3:08 AM
kadircet added inline comments to D55062: [clangd] Partition include graph on auto-index..
Mon, Dec 3, 1:47 AM
kadircet updated the diff for D55062: [clangd] Partition include graph on auto-index..
  • Address comments
Mon, Dec 3, 1:47 AM
kadircet accepted D55124: [CodeComplete] Cleanup access checking in code completion.
Mon, Dec 3, 1:38 AM
kadircet accepted D55139: [clangd] Avoid memory-mapping files on Windows.

LGTM

Mon, Dec 3, 12:55 AM

Fri, Nov 30

kadircet committed rC348015: [clang] Fix rL348006 for windows.
[clang] Fix rL348006 for windows
Fri, Nov 30, 10:39 AM
kadircet committed rL348015: [clang] Fix rL348006 for windows.
[clang] Fix rL348006 for windows
Fri, Nov 30, 10:39 AM
kadircet committed rL348006: [clang] Fill RealPathName for virtual files..
[clang] Fill RealPathName for virtual files.
Fri, Nov 30, 9:13 AM
kadircet committed rC348006: [clang] Fill RealPathName for virtual files..
[clang] Fill RealPathName for virtual files.
Fri, Nov 30, 9:13 AM
kadircet closed D55054: [clang] Fill RealPathName for virtual files..
Fri, Nov 30, 9:13 AM
kadircet updated the diff for D55054: [clang] Fill RealPathName for virtual files..
  • Address comments
Fri, Nov 30, 9:12 AM
kadircet committed rCTE348005: [clangd] Populate include graph during static indexing action..
[clangd] Populate include graph during static indexing action.
Fri, Nov 30, 9:02 AM
kadircet committed rL348005: [clangd] Populate include graph during static indexing action..
[clangd] Populate include graph during static indexing action.
Fri, Nov 30, 9:02 AM
kadircet closed D54999: [clangd] Populate include graph during static indexing action..
Fri, Nov 30, 9:02 AM
kadircet updated the diff for D54999: [clangd] Populate include graph during static indexing action..
  • Address comments
Fri, Nov 30, 9:01 AM
kadircet added inline comments to D55062: [clangd] Partition include graph on auto-index..
Fri, Nov 30, 4:44 AM
kadircet updated the diff for D55062: [clangd] Partition include graph on auto-index..
  • Address comments
Fri, Nov 30, 4:44 AM
kadircet added inline comments to D55054: [clang] Fill RealPathName for virtual files..
Fri, Nov 30, 4:28 AM
kadircet updated the diff for D55054: [clang] Fill RealPathName for virtual files..

Address comments

Fri, Nov 30, 3:37 AM
kadircet updated the diff for D54999: [clangd] Populate include graph during static indexing action..
  • Address comments.
Fri, Nov 30, 2:38 AM
kadircet added inline comments to D55065: [clangd] Drop injected class name when class scope is not explicitly specified..
Fri, Nov 30, 1:13 AM
kadircet accepted D55065: [clangd] Drop injected class name when class scope is not explicitly specified..

LGTM, thanks!

Fri, Nov 30, 1:00 AM

Thu, Nov 29

kadircet added inline comments to D54999: [clangd] Populate include graph during static indexing action..
Thu, Nov 29, 10:27 AM
kadircet updated the diff for D54999: [clangd] Populate include graph during static indexing action..
  • Address comments.
Thu, Nov 29, 10:19 AM
kadircet updated the diff for D55054: [clang] Fill RealPathName for virtual files..
  • Update tests
Thu, Nov 29, 10:11 AM
kadircet added parent revisions for D55062: [clangd] Partition include graph on auto-index.: D54999: [clangd] Populate include graph during static indexing action., D55054: [clang] Fill RealPathName for virtual files..
Thu, Nov 29, 9:54 AM
kadircet added a child revision for D54999: [clangd] Populate include graph during static indexing action.: D55062: [clangd] Partition include graph on auto-index..
Thu, Nov 29, 9:54 AM
kadircet added a child revision for D55054: [clang] Fill RealPathName for virtual files.: D55062: [clangd] Partition include graph on auto-index..
Thu, Nov 29, 9:54 AM
kadircet created D55062: [clangd] Partition include graph on auto-index..
Thu, Nov 29, 9:41 AM
kadircet updated the diff for D54999: [clangd] Populate include graph during static indexing action..
  • Address comments
Thu, Nov 29, 8:59 AM
kadircet created D55054: [clang] Fill RealPathName for virtual files..
Thu, Nov 29, 7:21 AM
kadircet added inline comments to D54999: [clangd] Populate include graph during static indexing action..
Thu, Nov 29, 2:48 AM
kadircet updated the diff for D54999: [clangd] Populate include graph during static indexing action..
  • Address comments.
Thu, Nov 29, 2:48 AM

Wed, Nov 28

kadircet updated the diff for D54999: [clangd] Populate include graph during static indexing action..
  • Address comments.
Wed, Nov 28, 7:02 AM
kadircet added inline comments to D54999: [clangd] Populate include graph during static indexing action..
Wed, Nov 28, 7:02 AM