Page MenuHomePhabricator

kadircet (Kadir Cetinkaya)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 14 2018, 2:16 AM (101 w, 5 d)

Recent Activity

Today

kadircet added a comment to D73451: [clangd] Update the include mappings for std symbols..

we seem to be missing some symbols now, like polymorphic_allocator random_shuffle gets etc.

yeap, two majoir reasons:

  • some symbols are deprecated/removed in new C++ standard, e.g. random_shuffle is removed in C++17
  • missing information in cppreference page, e.g. there is no header section for polymorphic_allocator in the offline cppreference page :(

    Regarding those deprecated symbols, we could handle them according to which C++ standard we are using, as we have enough information from cppreferences, but it needs some work, and is low priority.
Mon, Jan 27, 3:56 AM · Restricted Project
kadircet added a comment to D73451: [clangd] Update the include mappings for std symbols..

we seem to be missing some symbols now, like polymorphic_allocator random_shuffle gets etc. and there seems to be a functional change to the parser. Are they intentional, if so why?

Mon, Jan 27, 2:46 AM · Restricted Project
kadircet added inline comments to D73450: [clangd] Add a symbol-name-based blacklist for rename..
Mon, Jan 27, 2:43 AM · Restricted Project

Fri, Jan 24

kadircet committed rG1b996faa1575: [clangd][Hover] Change arrow in return type back to → (authored by kadircet).
[clangd][Hover] Change arrow in return type back to →
Fri, Jan 24, 4:08 AM
kadircet closed D73336: [clangd][Hover] Change arrow in return type back to →.
Fri, Jan 24, 4:08 AM · Restricted Project
kadircet created D73344: [clangd][Hover] Handle uninstantiated templates.
Fri, Jan 24, 4:08 AM · Restricted Project
kadircet created D73336: [clangd][Hover] Change arrow in return type back to →.
Fri, Jan 24, 2:37 AM · Restricted Project
kadircet accepted D73218: [clangd] Show background index status using LSP 3.15 work-done progress notifications.
Fri, Jan 24, 2:10 AM · Restricted Project, Restricted Project

Thu, Jan 23

kadircet committed rG24364cd12bbf: [clang][CodeComplete] Make completion work after initializer lists (authored by kadircet).
[clang][CodeComplete] Make completion work after initializer lists
Thu, Jan 23, 6:39 AM
kadircet closed D73177: [clang][CodeComplete] Make completion work after initializer lists.
Thu, Jan 23, 6:39 AM · Restricted Project
kadircet created D73271: [clang][CodeComplete] Support for designated initializers.
Thu, Jan 23, 6:39 AM · Restricted Project
kadircet added inline comments to D73218: [clangd] Show background index status using LSP 3.15 work-done progress notifications.
Thu, Jan 23, 1:26 AM · Restricted Project, Restricted Project
kadircet accepted D73199: [clangd] Errors in TestTU cause test failures unless suppressed with error-ok..

LGTM, thanks for the cleanup!

Thu, Jan 23, 12:13 AM · Restricted Project

Wed, Jan 22

kadircet updated the diff for D73177: [clang][CodeComplete] Make completion work after initializer lists.
  • Add comments
Wed, Jan 22, 5:47 AM · Restricted Project
kadircet created D73177: [clang][CodeComplete] Make completion work after initializer lists.
Wed, Jan 22, 5:20 AM · Restricted Project
kadircet committed rG9570f1e5a612: [clangd] Do not duplicate TemplatedDecls in findExplicitReferences (authored by kadircet).
[clangd] Do not duplicate TemplatedDecls in findExplicitReferences
Wed, Jan 22, 2:46 AM
kadircet closed D73101: [clangd] Do not duplicate TemplatedDecls in findExplicitReferences.
Wed, Jan 22, 2:46 AM · Restricted Project
kadircet updated the diff for D73101: [clangd] Do not duplicate TemplatedDecls in findExplicitReferences.
  • Update comments
Wed, Jan 22, 2:45 AM · Restricted Project
kadircet added inline comments to D72746: [clangd] Add a flag for implicit references in the Index.
Wed, Jan 22, 2:08 AM · Restricted Project
kadircet resigned from D72746: [clangd] Add a flag for implicit references in the Index.
Wed, Jan 22, 2:08 AM · Restricted Project

Tue, Jan 21

kadircet committed rG1fbb1d6df011: [clangd] Drop returntype/type when hovering over type-ish names (authored by kadircet).
[clangd] Drop returntype/type when hovering over type-ish names
Tue, Jan 21, 8:12 AM
kadircet closed D73110: [clangd] Drop returntype/type when hovering over type-ish names.
Tue, Jan 21, 8:12 AM · Restricted Project
kadircet accepted D73109: [clang][index] Index the injected class name types..

Thanks this LG (please apply clang-format fixes though)

Tue, Jan 21, 8:05 AM · Restricted Project
kadircet created D73110: [clangd] Drop returntype/type when hovering over type-ish names.
Tue, Jan 21, 7:52 AM · Restricted Project
kadircet updated the diff for D73101: [clangd] Do not duplicate TemplatedDecls in findExplicitReferences.
  • Filter out templateddecls in VisitNamedDecls, instead of defining a new Visit method.
Tue, Jan 21, 7:25 AM · Restricted Project
kadircet added inline comments to D73101: [clangd] Do not duplicate TemplatedDecls in findExplicitReferences.
Tue, Jan 21, 7:16 AM · Restricted Project
kadircet added inline comments to D73101: [clangd] Do not duplicate TemplatedDecls in findExplicitReferences.
Tue, Jan 21, 7:07 AM · Restricted Project
kadircet updated the diff for D73101: [clangd] Do not duplicate TemplatedDecls in findExplicitReferences.
  • Rebase
Tue, Jan 21, 6:48 AM · Restricted Project
kadircet created D73101: [clangd] Do not duplicate TemplatedDecls in findExplicitReferences.
Tue, Jan 21, 6:21 AM · Restricted Project
kadircet accepted D73088: [clangd] Capture the missing injected class names in findExplicitReferences..

LGTM

Tue, Jan 21, 3:43 AM · Restricted Project
kadircet added inline comments to D73088: [clangd] Capture the missing injected class names in findExplicitReferences..
Tue, Jan 21, 3:41 AM · Restricted Project

Mon, Jan 20

kadircet committed rGfb3d9153c01b: [clangd] Fix DocumentOutline for concepts (authored by kadircet).
[clangd] Fix DocumentOutline for concepts
Mon, Jan 20, 11:22 AM
kadircet closed D73056: [clangd] Fix DocumentOutline for concepts.
Mon, Jan 20, 11:22 AM · Restricted Project
kadircet created D73056: [clangd] Fix DocumentOutline for concepts.
Mon, Jan 20, 10:07 AM · Restricted Project
kadircet accepted D73035: [clangd] Avoid redundant testcases in rename unittest, NFC..
Mon, Jan 20, 7:06 AM · Restricted Project
kadircet added inline comments to D72638: [clangd] Fix rename for explicit destructor calls.
Mon, Jan 20, 3:58 AM · Restricted Project
kadircet committed rG1f946ee2faba: [clang][CodeComplete] Propogate printing policy to FunctionDecl (authored by kadircet).
[clang][CodeComplete] Propogate printing policy to FunctionDecl
Mon, Jan 20, 3:30 AM
kadircet closed D72715: [clang][CodeComplete] Propogate printing policy to FunctionDecl.
Mon, Jan 20, 3:30 AM · Restricted Project
kadircet added a comment to D72746: [clangd] Add a flag for implicit references in the Index.

I started using TokenBuffer, but I ran into the following issue: when I'm
creating TokenBuffer and TokenCollector, they do not contain any tokens.
Preprocessor does not seem to have a non-null Lexer instance, TokenWatcher
(set in TokenCollector) is not triggered anywhere and neither is
Lexer::Lex. I don't have much familiarity with the code and I looked at the
other usages of TokenBuffer but didn't figure out what's wrong with the code
in this patch. I suspect the lexer in Preprocessor should be re-initialized
somehow? I'm certainly missing something here.

Mon, Jan 20, 3:03 AM · Restricted Project

Fri, Jan 17

kadircet added a reviewer for D72715: [clang][CodeComplete] Propogate printing policy to FunctionDecl: hokein.
Fri, Jan 17, 6:59 AM · Restricted Project

Thu, Jan 16

kadircet committed rG4df94d5b513c: Revert "[clangd][test] Disable a particular testcase in… (authored by kadircet).
Revert "[clangd][test] Disable a particular testcase in…
Thu, Jan 16, 11:59 PM
kadircet added a reverting change for rG42b3c38903c9: [clangd][test] Disable a particular testcase in FindExplicitReferencesTest when…: rG4df94d5b513c: Revert "[clangd][test] Disable a particular testcase in….
Thu, Jan 16, 11:59 PM
kadircet added a comment to D72883: [clangd][test] Disable a particular testcase in FindExplicitReferencesTest when LLVM_ENABLE_EXPENSIVE_CHECKS.

Hi @jkorous, reverting this as d54d71b67e60 should've fixed this. Please let us know if that's not the case.

Thu, Jan 16, 11:58 PM · Restricted Project
kadircet committed rG0474fe465d8f: [clangd] Print underlying type for decltypes in hover (authored by kadircet).
[clangd] Print underlying type for decltypes in hover
Thu, Jan 16, 11:01 AM
kadircet committed rGa881fcafaa5a: [clangd] Make define outline code action visible (authored by kadircet).
[clangd] Make define outline code action visible
Thu, Jan 16, 11:01 AM
kadircet closed D72498: [clangd] Print underlying type for decltypes in hover.
Thu, Jan 16, 11:01 AM · Restricted Project
kadircet closed D72840: [clangd] Make define outline code action visible.
Thu, Jan 16, 11:01 AM · Restricted Project
kadircet created D72840: [clangd] Make define outline code action visible.
Thu, Jan 16, 6:38 AM · Restricted Project
kadircet updated the diff for D72498: [clangd] Print underlying type for decltypes in hover.
  • Handle return and parameter types as well
Thu, Jan 16, 6:23 AM · Restricted Project
kadircet committed rGd54d71b67e60: [clangd] Make output order of allTargetDecls deterministic (authored by kadircet).
[clangd] Make output order of allTargetDecls deterministic
Thu, Jan 16, 5:51 AM
kadircet closed D72826: [clangd] Make output order of allTargetDecls deterministic.
Thu, Jan 16, 5:51 AM · Restricted Project
kadircet added inline comments to D72826: [clangd] Make output order of allTargetDecls deterministic.
Thu, Jan 16, 5:51 AM · Restricted Project
kadircet updated the diff for D72826: [clangd] Make output order of allTargetDecls deterministic.
  • Get rid of redundant sorting step
Thu, Jan 16, 5:47 AM · Restricted Project
kadircet updated the diff for D72826: [clangd] Make output order of allTargetDecls deterministic.
  • Address comments
Thu, Jan 16, 4:18 AM · Restricted Project
kadircet committed rGb08e8353a89f: [clangd] Dont display `<unknown>` kinds in hover board (authored by kadircet).
[clangd] Dont display `<unknown>` kinds in hover board
Thu, Jan 16, 2:47 AM
kadircet closed D72777: [clangd] Dont display `<unknown>` kinds in hover board.
Thu, Jan 16, 2:47 AM · Restricted Project
kadircet created D72826: [clangd] Make output order of allTargetDecls deterministic.
Thu, Jan 16, 2:45 AM · Restricted Project

Wed, Jan 15

kadircet created D72777: [clangd] Dont display `<unknown>` kinds in hover board.
Wed, Jan 15, 9:15 AM · Restricted Project
kadircet committed rG041650da6705: [clangd] Extract string literals in macro arguments to unbreak gcc buildbots (authored by kadircet).
[clangd] Extract string literals in macro arguments to unbreak gcc buildbots
Wed, Jan 15, 9:06 AM
kadircet committed rG60adfb83cda8: [clangd] Fix windows buildbots (authored by kadircet).
[clangd] Fix windows buildbots
Wed, Jan 15, 7:26 AM
kadircet committed rG44f9c7a820c1: [clangd] Rearrange type, returntype and parameters in hover card (authored by kadircet).
[clangd] Rearrange type, returntype and parameters in hover card
Wed, Jan 15, 6:58 AM
kadircet committed rGd74a3d470c31: [clangd] Add a ruler after header in hover (authored by kadircet).
[clangd] Add a ruler after header in hover
Wed, Jan 15, 6:58 AM
kadircet closed D72623: [clangd] Rearrange type, returntype and parameters in hover card.
Wed, Jan 15, 6:58 AM · Restricted Project
kadircet closed D72622: [clangd] Add a ruler after header in hover.
Wed, Jan 15, 6:58 AM · Restricted Project
kadircet added a comment to D72623: [clangd] Rearrange type, returntype and parameters in hover card.

I think the character "🡺" should be avoided, as it may not display properly in some environments.

Wed, Jan 15, 6:57 AM · Restricted Project
kadircet updated the diff for D72498: [clangd] Print underlying type for decltypes in hover.
  • Rebase
Wed, Jan 15, 6:57 AM · Restricted Project
kadircet updated the diff for D72623: [clangd] Rearrange type, returntype and parameters in hover card.
  • Rebase
Wed, Jan 15, 6:57 AM · Restricted Project
kadircet updated the diff for D72622: [clangd] Add a ruler after header in hover.
  • Address comments
Wed, Jan 15, 6:50 AM · Restricted Project
kadircet added inline comments to D72500: [clangd] Show hover info for expressions.
Wed, Jan 15, 6:39 AM · Restricted Project
kadircet committed rG4d14bfaa2cb1: [clangd] Show hower info for expressions (authored by kadircet).
[clangd] Show hower info for expressions
Wed, Jan 15, 6:21 AM
kadircet closed D72500: [clangd] Show hover info for expressions.
Wed, Jan 15, 6:20 AM · Restricted Project
kadircet added inline comments to D72638: [clangd] Fix rename for explicit destructor calls.
Wed, Jan 15, 5:15 AM · Restricted Project
kadircet added inline comments to D72746: [clangd] Add a flag for implicit references in the Index.
Wed, Jan 15, 3:33 AM · Restricted Project
kadircet added inline comments to D72746: [clangd] Add a flag for implicit references in the Index.
Wed, Jan 15, 3:33 AM · Restricted Project

Tue, Jan 14

kadircet updated the diff for D72715: [clang][CodeComplete] Propogate printing policy to FunctionDecl.
  • Upload the correct diff
Tue, Jan 14, 9:55 AM · Restricted Project
kadircet added a comment to D72715: [clang][CodeComplete] Propogate printing policy to FunctionDecl.

The patch contains only tests, are we missing the actual functional change?

Tue, Jan 14, 9:55 AM · Restricted Project
kadircet updated the diff for D72500: [clangd] Show hover info for expressions.
  • Populate Name for expressions
  • Don't special case StringLiterals
Tue, Jan 14, 9:45 AM · Restricted Project
kadircet created D72715: [clang][CodeComplete] Propogate printing policy to FunctionDecl.
Tue, Jan 14, 9:18 AM · Restricted Project
kadircet updated the diff for D72622: [clangd] Add a ruler after header in hover.
  • Per offline discussions, do post processing to get rid of multiple ruler occurences.
Tue, Jan 14, 4:20 AM · Restricted Project
kadircet added a comment to D72500: [clangd] Show hover info for expressions.

ping

Tue, Jan 14, 2:09 AM · Restricted Project
kadircet added inline comments to D72623: [clangd] Rearrange type, returntype and parameters in hover card.
Tue, Jan 14, 2:09 AM · Restricted Project
kadircet updated the diff for D72623: [clangd] Rearrange type, returntype and parameters in hover card.
  • Address comments and rebase on top of ruler patch
Tue, Jan 14, 2:09 AM · Restricted Project
kadircet added inline comments to D72622: [clangd] Add a ruler after header in hover.
Tue, Jan 14, 2:09 AM · Restricted Project
kadircet updated the diff for D72622: [clangd] Add a ruler after header in hover.
  • Update comments
Tue, Jan 14, 2:00 AM · Restricted Project
kadircet updated the diff for D72622: [clangd] Add a ruler after header in hover.
  • Increase control around paddings for plaintext rendering.
  • Add another ruler before definition.
Tue, Jan 14, 2:00 AM · Restricted Project

Mon, Jan 13

kadircet committed rGf5465e74ef4c: [clangd] Include expression in DecltypeTypeLoc sourcerange while building… (authored by kadircet).
[clangd] Include expression in DecltypeTypeLoc sourcerange while building…
Mon, Jan 13, 11:41 AM
kadircet closed D72594: [clangd] Include expression in DecltypeTypeLoc sourcerange while building SelectionTree.
Mon, Jan 13, 11:41 AM · Restricted Project
kadircet added inline comments to D72594: [clangd] Include expression in DecltypeTypeLoc sourcerange while building SelectionTree.
Mon, Jan 13, 11:41 AM · Restricted Project
kadircet committed rG15078d7202b4: [clangd] Render header of hover card as a heading (authored by kadircet).
[clangd] Render header of hover card as a heading
Mon, Jan 13, 11:32 AM
kadircet closed D72625: [clangd] Render header of hover card as a heading.
Mon, Jan 13, 11:32 AM · Restricted Project
kadircet created D72625: [clangd] Render header of hover card as a heading.
Mon, Jan 13, 8:50 AM · Restricted Project
kadircet created D72623: [clangd] Rearrange type, returntype and parameters in hover card.
Mon, Jan 13, 8:31 AM · Restricted Project
kadircet created D72622: [clangd] Add a ruler after header in hover.
Mon, Jan 13, 8:22 AM · Restricted Project
kadircet added a comment to D72498: [clangd] Print underlying type for decltypes in hover.

No, I think printing *both* is at least somewhat likely to be too verbose, especially since the previous release showed no types at all.
And we're out of time to iterate on the behavior and presentation for this cycle. I think we should do something more conservative and then experiment in the next release cycle.

Mon, Jan 13, 7:25 AM · Restricted Project
kadircet updated the diff for D72500: [clangd] Show hover info for expressions.
  • Update presentation for expressions, which doesn't have Name field set.
Mon, Jan 13, 6:35 AM · Restricted Project
kadircet added a comment to D72498: [clangd] Print underlying type for decltypes in hover.

Currently, I think that in most cases, showing both expanded (canonical) and spelled types is sufficient.

This has been used in ycmd for ~4 years without complaint. https://github.com/clangd/clangd/issues/58#issuecomment-507800970

That actually doesn't look bad. Maybe let's try doing that and see whether we'll get negative feedback?
That seems to give useful information in all cases, so at least it'll cover all use-cases even it's more verbose.

What do others think?

Mon, Jan 13, 6:16 AM · Restricted Project
kadircet retitled D72500: [clangd] Show hover info for expressions from [clangd] Show hower info for expressions to [clangd] Show hover info for expressions.
Mon, Jan 13, 6:16 AM · Restricted Project
kadircet updated the diff for D72500: [clangd] Show hover info for expressions.
  • Ignore literals
Mon, Jan 13, 6:07 AM · Restricted Project
kadircet added a comment to D72500: [clangd] Show hover info for expressions.

Basing this on the hover for the type doesn't seem right. e.g. int should be the Type rather than the Name.

Rather than printing the value if evaluable, I think we should only show the hover if evaluable. There's a cost to showing it and the value of just the type doesn't seem clearly high enough.

I think we should avoid triggering for literals. Maybe some exceptions, but a hover saying that 0 is an int with value 0 seems silly.

Mon, Jan 13, 6:07 AM · Restricted Project
kadircet added a comment to D72498: [clangd] Print underlying type for decltypes in hover.

It's particularly unclear to me why typeprinter descends into auto but prints decltype, but Kadir says that seems to be intentional.

Also don't see why they choose to have this inconsistency and I haven't seen any indication it's not a coincidence.
@kadircet, why do you think it's intentional? Should we put some comments there?

Mon, Jan 13, 3:48 AM · Restricted Project