Page MenuHomePhabricator

logan-5 (Logan Smith)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 1 2019, 8:51 AM (178 w, 16 h)

Recent Activity

Jan 10 2022

logan-5 committed rG988c3f5f9692: [clang-tidy] Fix RenamerClangTidyChecks suggesting invalid macro identifiers (authored by logan-5).
[clang-tidy] Fix RenamerClangTidyChecks suggesting invalid macro identifiers
Jan 10 2022, 10:35 AM
logan-5 closed D116824: [clang-tidy] Fix RenamerClangTidyChecks suggesting invalid macro identifiers.
Jan 10 2022, 10:35 AM · Restricted Project

Jan 7 2022

logan-5 requested review of D116824: [clang-tidy] Fix RenamerClangTidyChecks suggesting invalid macro identifiers.
Jan 7 2022, 10:27 AM · Restricted Project
logan-5 committed rG7d1cd8e02636: [Support] No longer require flushing raw_string_ostream (authored by logan-5).
[Support] No longer require flushing raw_string_ostream
Jan 7 2022, 9:26 AM
logan-5 closed D115421: [Support] No longer require .flush()ing raw_string_ostream.
Jan 7 2022, 9:25 AM · Restricted Project

Dec 10 2021

logan-5 added a comment to D115421: [Support] No longer require .flush()ing raw_string_ostream.

Thanks for the guidance, it's much appreciated.

you and/or others can incrementally delete the uninteresting calls over time.

Doing it incrementally sounds much more approachable. I may indeed submit cleanup patches like this as time permits.

Dec 10 2021, 9:27 AM · Restricted Project
logan-5 updated the diff for D115421: [Support] No longer require .flush()ing raw_string_ostream.

Updated comment and added TODO.

Dec 10 2021, 9:23 AM · Restricted Project

Dec 9 2021

logan-5 added a comment to D115421: [Support] No longer require .flush()ing raw_string_ostream.

To be quite honest, in regards to the big .str() refactor (whether changing its type or deleting it), I feel I may have started to bite off more than I can chew here. There are at least a few thousand call sites of .str() throughout LLVM and its subprojects, and as just a very occasional contributor who will be a distant stranger to most of them, I don't feel equipped or qualified to tackle auditing and fixing them myself. (Not to mention that it's orders of magnitude more work than I had planned to contribute with my initial patch.) I just wanted to optimize a few returns, and now we're talking about making a huge number of changes across the entire repo. I'm happy to bring this current patch through to landing, but when it comes to the big .str() purge I might have to humbly step back.

Dec 9 2021, 4:16 PM · Restricted Project
logan-5 committed rG5336befe8c3c: [NFC][tools] Return underlying strings directly instead of OS.str() (authored by logan-5).
[NFC][tools] Return underlying strings directly instead of OS.str()
Dec 9 2021, 4:06 PM
logan-5 committed rG5276002a89b9: [NFC][Sema] Return underlying strings directly instead of OS.str() (authored by logan-5).
[NFC][Sema] Return underlying strings directly instead of OS.str()
Dec 9 2021, 4:06 PM
logan-5 committed rG0cf6f7b128dd: [NFC][clang] Return underlying strings directly instead of OS.str() (authored by logan-5).
[NFC][clang] Return underlying strings directly instead of OS.str()
Dec 9 2021, 4:06 PM
logan-5 committed rG08eb614e3090: [NFC][testing] Return underlying strings directly instead of OS.str() (authored by logan-5).
[NFC][testing] Return underlying strings directly instead of OS.str()
Dec 9 2021, 4:06 PM
logan-5 committed rGad17ea12e70a: [NFC][AST] Return underlying strings directly instead of OS.str() (authored by logan-5).
[NFC][AST] Return underlying strings directly instead of OS.str()
Dec 9 2021, 4:06 PM
logan-5 committed rG715c72b4fbf4: [NFC][analyzer] Return underlying strings directly instead of OS.str() (authored by logan-5).
[NFC][analyzer] Return underlying strings directly instead of OS.str()
Dec 9 2021, 4:06 PM
logan-5 closed D115374: [NFC][clang] Return std::strings built from raw_string_ostreams more efficiently.
Dec 9 2021, 4:06 PM · Restricted Project
logan-5 updated the diff for D115374: [NFC][clang] Return std::strings built from raw_string_ostreams more efficiently.

Removed .flush()es. Seems like this might be able to land without https://reviews.llvm.org/D115421?

Dec 9 2021, 12:59 PM · Restricted Project
logan-5 added inline comments to D115421: [Support] No longer require .flush()ing raw_string_ostream.
Dec 9 2021, 12:49 PM · Restricted Project
logan-5 updated the diff for D115421: [Support] No longer require .flush()ing raw_string_ostream.

Addressed comments

Dec 9 2021, 12:47 PM · Restricted Project
logan-5 updated the diff for D115421: [Support] No longer require .flush()ing raw_string_ostream.

Formatting.

Dec 9 2021, 10:38 AM · Restricted Project

Dec 8 2021

logan-5 updated the diff for D115421: [Support] No longer require .flush()ing raw_string_ostream.

Fixed some tests--had to add manual .flush()es back in to some tests that were testing general flushing behavior of raw_ostream, but using raw_string_ostream for convenience.

Dec 8 2021, 9:47 PM · Restricted Project
logan-5 requested review of D115421: [Support] No longer require .flush()ing raw_string_ostream.
Dec 8 2021, 8:25 PM · Restricted Project
logan-5 added a comment to D115374: [NFC][clang] Return std::strings built from raw_string_ostreams more efficiently.

To be clear, it sounds like we should either add .take() for moving the string out of raw_string_ostream's string reference, or make raw_string_ostream not need to be flushed (after which there won't be as clear a use for .take(), since you can just use the underlying string directly).

Dec 8 2021, 5:55 PM · Restricted Project
logan-5 updated the diff for D115374: [NFC][clang] Return std::strings built from raw_string_ostreams more efficiently.

Eliminate some explicit .flush()es by using temporary raw_string_ostreams where possible.

Dec 8 2021, 5:16 PM · Restricted Project
logan-5 added a comment to D115374: [NFC][clang] Return std::strings built from raw_string_ostreams more efficiently.

I don't feel strongly, but IMO the code might be a bit harder to read/maintain with the explicit flush. I worry that it'd be easy to move the flush() away from the return. Not sure I'm right; could just be familiarity with str().

I definitely hear you. I don't really mind it personally, and I did it this way because I saw precedent in a couple spots (there's one on CompilerInvocation.cpp:653, several in clangd, etc.). I definitely see how it could be a little bit spooky though.

Dec 8 2021, 4:49 PM · Restricted Project
logan-5 added inline comments to D115374: [NFC][clang] Return std::strings built from raw_string_ostreams more efficiently.
Dec 8 2021, 1:46 PM · Restricted Project
logan-5 requested review of D115374: [NFC][clang] Return std::strings built from raw_string_ostreams more efficiently.
Dec 8 2021, 12:26 PM · Restricted Project
logan-5 added a comment to D72282: [clang-tidy] Add `bugprone-unintended-adl`.

It's been a year and a half since I heard anything about this patch and I'd honestly kind of forgotten about it. I'm still around/lurking though, and would assist with getting it landed if it's still good to go.

Dec 8 2021, 9:03 AM · Restricted Project, Restricted Project, Restricted Project

May 24 2021

logan-5 committed rGa5a3efa82a77: [Sema] Always search the full function scope context if a potential… (authored by logan-5).
[Sema] Always search the full function scope context if a potential…
May 24 2021, 9:26 PM
logan-5 closed D102338: [Sema] Always search the full function scope context if a potential availability violation is encountered.
May 24 2021, 9:26 PM · Restricted Project

May 22 2021

logan-5 added a comment to D102338: [Sema] Always search the full function scope context if a potential availability violation is encountered.

Thanks very much; I look forward to any feedback!

May 22 2021, 10:12 AM · Restricted Project

May 12 2021

logan-5 requested review of D102338: [Sema] Always search the full function scope context if a potential availability violation is encountered.
May 12 2021, 10:52 AM · Restricted Project

Jan 24 2021

logan-5 added a comment to D94452: [libc++] Support immovable return types in std::function..

Thanks @Quuxplusone for working on this. I ran into this issue while trying to write real actual code in a codebase with (for better or worse) lots of noncopyable types, so this will really be a nice-to-have once it's landed.

Jan 24 2021, 9:30 AM · Restricted Project

Dec 16 2020

logan-5 added inline comments to D93095: Introduce -Wreserved-identifier.
Dec 16 2020, 9:46 AM · Restricted Project

Dec 15 2020

logan-5 added a comment to D93095: Introduce -Wreserved-identifier.

I don't have any power to actually approve this, by the way, but it's looking pretty good to me.

Dec 15 2020, 8:59 AM · Restricted Project
logan-5 added a comment to D93095: Introduce -Wreserved-identifier.

@logan-5 I forgot to update you on this: there already was a warning for marco reserved identifier, I just made it a dependency o -Wreserved-identifier

Dec 15 2020, 8:56 AM · Restricted Project

Dec 11 2020

logan-5 added a comment to D93095: Introduce -Wreserved-identifier.

Thanks for the ping. I like this as a warning a lot; I wasn't confident enough to write it myself at the time, which is why I wrote the clang-tidy check instead. :)

Dec 11 2020, 8:04 AM · Restricted Project

Jul 27 2020

logan-5 committed rGa52aea0ba624: Use INTERFACE_COMPILE_OPTIONS to disable -Wsuggest-override for any target that… (authored by logan-5).
Use INTERFACE_COMPILE_OPTIONS to disable -Wsuggest-override for any target that…
Jul 27 2020, 8:38 AM
logan-5 closed D84554: Use INTERFACE_COMPILE_OPTIONS to disable -Wsuggest-override for any target that links to gtest.
Jul 27 2020, 8:38 AM · Restricted Project, Restricted Project, Restricted Project
logan-5 added a comment to D84554: Use INTERFACE_COMPILE_OPTIONS to disable -Wsuggest-override for any target that links to gtest.

Could you elaborate on the lldb issue? I'd like to take a look at that...

Jul 27 2020, 8:32 AM · Restricted Project, Restricted Project, Restricted Project

Jul 24 2020

Herald added projects to D84554: Use INTERFACE_COMPILE_OPTIONS to disable -Wsuggest-override for any target that links to gtest: Restricted Project, Restricted Project, Restricted Project.
Jul 24 2020, 1:23 PM · Restricted Project, Restricted Project, Restricted Project
logan-5 added a comment to D84126: Enable -Wsuggest-override in the LLVM build.

Instead of adding -Wno-suggest-override to every user it might be cleaner to add the flag to the INTERFACE_COMPILE_OPTIONS property of the relevant targets (gtest, gmock, and gbenchmark ?). That way, anything which links against these will inherit it automatically.

Jul 24 2020, 10:23 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jul 23 2020

logan-5 added a comment to D84244: [clang] Disable -Wsuggest-override for unittests/.

Looks good to me so far. We haven't tried doing any full builds yet, but I checked for the specific problem I hit yesterday (building ClangApplyReplacementsTests) and that's working fine now.

Jul 23 2020, 8:51 AM · Restricted Project

Jul 22 2020

logan-5 committed rG77e0e9e17daf: Reapply "Try enabling -Wsuggest-override again, using add_compile_options… (authored by logan-5).
Reapply "Try enabling -Wsuggest-override again, using add_compile_options…
Jul 22 2020, 5:50 PM
logan-5 committed rG97a0f80c469c: Revert "Try enabling -Wsuggest-override again, using add_compile_options… (authored by logan-5).
Revert "Try enabling -Wsuggest-override again, using add_compile_options…
Jul 22 2020, 3:07 PM
logan-5 added a reverting change for rG388c9fb1af48: Try enabling -Wsuggest-override again, using add_compile_options instead of…: rG97a0f80c469c: Revert "Try enabling -Wsuggest-override again, using add_compile_options….
Jul 22 2020, 3:07 PM
logan-5 added a comment to D84244: [clang] Disable -Wsuggest-override for unittests/.

Sometimes it's OK to commit stuff an see how it goes on the buildbots - doing so out of peak times and with the intention of rolling back quickly/immediately if the buildbots report breakage is sometimes the best tool we have (not great, but such is the way of things).

In that case, I've enabled it again using add_compile_options instead of add_definitions. I've got my finger hovering over the button to revert.

Jul 22 2020, 2:22 PM · Restricted Project
logan-5 committed rG388c9fb1af48: Try enabling -Wsuggest-override again, using add_compile_options instead of… (authored by logan-5).
Try enabling -Wsuggest-override again, using add_compile_options instead of…
Jul 22 2020, 2:20 PM
logan-5 added a comment to D84244: [clang] Disable -Wsuggest-override for unittests/.

I don't really know why this doesn't happen with other warning flags, but I think it would be better to add flags like this with add_compile_options rather than add_compile_definitions. I imagine that would prevent it from reaching rc.exe.

That sounds pretty reasonable. Without any way of testing the Windows setup myself though, I don't feel comfortable making that change.

Jul 22 2020, 12:24 PM · Restricted Project
logan-5 added a comment to D84244: [clang] Disable -Wsuggest-override for unittests/.

Thanks for reverting--I agree that that's the right move at this point.

Jul 22 2020, 12:00 PM · Restricted Project
logan-5 committed rG1c7037a2a557: [clangd] Disable -Wsuggest-override for unittests/ (authored by logan-5).
[clangd] Disable -Wsuggest-override for unittests/
Jul 22 2020, 10:49 AM
logan-5 committed rG274b6b0c7a8b: Only enable -Wsuggest-override if it doesn't suggest adding override to… (authored by logan-5).
Only enable -Wsuggest-override if it doesn't suggest adding override to…
Jul 22 2020, 10:06 AM
logan-5 closed D84292: Only enable -Wsuggest-override if it doesn't suggest adding override to functions that are already final.
Jul 22 2020, 10:06 AM · Restricted Project
logan-5 added a comment to D84126: Enable -Wsuggest-override in the LLVM build.

I'd suggest disabling this unless the GCC version is >9.1.

I've got a patch addressing exactly this issue here, hoping to get it landed soon: https://reviews.llvm.org/D84292

Jul 22 2020, 9:55 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jul 21 2020

Herald added a project to D84292: Only enable -Wsuggest-override if it doesn't suggest adding override to functions that are already final: Restricted Project.
Jul 21 2020, 9:36 PM · Restricted Project
logan-5 added a comment to D84126: Enable -Wsuggest-override in the LLVM build.

All the failures related to this patch are now resolved as far as I can tell. I'm very sorry for the trouble.

Jul 21 2020, 7:01 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
logan-5 committed rG21c0b4c1e8d6: Disable -Wsuggest-override for all remaining unittests/ directories (authored by logan-5).
Disable -Wsuggest-override for all remaining unittests/ directories
Jul 21 2020, 5:49 PM
logan-5 committed rG81d68ad27b29: [lld] Disable -Wsuggest-override for unittests (authored by logan-5).
[lld] Disable -Wsuggest-override for unittests
Jul 21 2020, 5:41 PM
logan-5 added a comment to D84244: [clang] Disable -Wsuggest-override for unittests/.

Looks OK (for future reference, this sort of stuff should've been cleaned up before enabling the flag so as to avoid this kind of hurry/breakage/etc)

Jul 21 2020, 4:48 PM · Restricted Project
logan-5 committed rGa361aa524985: [clang] Disable -Wsuggest-override for unittests/ (authored by logan-5).
[clang] Disable -Wsuggest-override for unittests/
Jul 21 2020, 4:39 PM
logan-5 added a comment to D84244: [clang] Disable -Wsuggest-override for unittests/.

Committing this now to fix the bots, as per discussion in https://reviews.llvm.org/D84126. I'll happily revert and approach it differently later if anyone requests that.

Jul 21 2020, 4:37 PM · Restricted Project
logan-5 added a comment to D84126: Enable -Wsuggest-override in the LLVM build.

There is a lot of instances where this warning fires in the unit tests since gtest does not appear to use the override keyword. This in turn causes failures on bootstrap builds that use -Werror.
An example: http://lab.llvm.org:8011/builders/ppc64le-lld-multistage-test/builds/10717

Can we either get this pulled until the failures in bootstrap are fixed or quickly fix the code that causes the failures?

Jul 21 2020, 4:36 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
logan-5 added a comment to D84244: [clang] Disable -Wsuggest-override for unittests/.

For GTest and GMock specifically, it would be a good medium-term idea to try to upstream patches into those libraries. I did eventually have success upstreaming fixes for -Wdeprecated into GTest, for example: https://github.com/google/googletest/pull/2815

Nice, that's encouraging. That does sound like a good solution for slightly further down the road.

(Although I'm a bit confused; I thought -Wsuggest-override was off-by-default? Is it part of -Wall, and do unittests add -Wall to their command line or something?)

After I implemented the warning and it landed, people wanted it explicitly turned on in the LLVM build, so then I did that. This is part of the fallout from that.

Jul 21 2020, 9:43 AM · Restricted Project
logan-5 committed rGfa42b7cf2949: [clang-tools-extra] Disable -Wsuggest-override for unittests/ (authored by logan-5).
[clang-tools-extra] Disable -Wsuggest-override for unittests/
Jul 21 2020, 9:13 AM
logan-5 closed D84213: [clang-tools-extra] Disable -Wsuggest-override for unittests/.
Jul 21 2020, 9:13 AM · Restricted Project, Restricted Project
logan-5 created D84244: [clang] Disable -Wsuggest-override for unittests/.
Jul 21 2020, 9:10 AM · Restricted Project

Jul 20 2020

logan-5 committed rGa58a8c017015: [NFC] Add another missing 'override' (authored by logan-5).
[NFC] Add another missing 'override'
Jul 20 2020, 10:05 PM
logan-5 committed rG865ee64bf80c: [NFC] Add missing 'override's (authored by logan-5).
[NFC] Add missing 'override's
Jul 20 2020, 9:19 PM
logan-5 committed rG955f87f947fd: [compiler-rt] Disable -Wsuggest-override for unittests (authored by logan-5).
[compiler-rt] Disable -Wsuggest-override for unittests
Jul 20 2020, 9:19 PM
logan-5 committed rGfc24d1eaddd8: [clang][NFC] Add missing 'override's (authored by logan-5).
[clang][NFC] Add missing 'override's
Jul 20 2020, 9:19 PM
logan-5 committed rG8ed021382e6b: Fix typo causing build failure (authored by logan-5).
Fix typo causing build failure
Jul 20 2020, 9:19 PM
logan-5 committed rG8b6179f48c6c: [NFC] Add missing 'override's (authored by logan-5).
[NFC] Add missing 'override's
Jul 20 2020, 9:18 PM
logan-5 committed rG308a127a38d1: [llvm][unittest] Add -Wno-suggest-override to more infrastructure that includes… (authored by logan-5).
[llvm][unittest] Add -Wno-suggest-override to more infrastructure that includes…
Jul 20 2020, 9:18 PM
logan-5 committed rG8b16e45f66e2: Enable -Wsuggest-override in the LLVM build (authored by logan-5).
Enable -Wsuggest-override in the LLVM build
Jul 20 2020, 9:18 PM
logan-5 closed D84126: Enable -Wsuggest-override in the LLVM build.
Jul 20 2020, 9:17 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
Herald added a project to D84213: [clang-tools-extra] Disable -Wsuggest-override for unittests/: Restricted Project.
Jul 20 2020, 9:16 PM · Restricted Project, Restricted Project

Jul 19 2020

logan-5 added a comment to D82728: [clang] Add -Wsuggest-override.

Is it possible to emit fixit note with "override" ?

This is a good idea, though unfortunately (after eyeballing the implementation of modernize-use-override in clang-tidy (UseOverrideCheck.cpp)), it looks non-trivial to figure out where exactly to insert override. There's some significant logic in the clang-tidy check involving re-lexing the relevant tokens, to find the insertion point in the presence of complexity like inline definitions, = 0, = {delete|default}, function try blocks, macros, and the list goes on.

Jul 19 2020, 4:43 PM · Restricted Project
Herald added a reviewer for D84126: Enable -Wsuggest-override in the LLVM build: Restricted Project.
Jul 19 2020, 9:57 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
logan-5 committed rG19dd3712e5ae: [llvm][NFC] Add missing 'override' (authored by logan-5).
[llvm][NFC] Add missing 'override'
Jul 19 2020, 9:57 AM
logan-5 added a comment to D72282: [clang-tidy] Add `bugprone-unintended-adl`.

Pinging this. I believe all feedback from @EricWF was addressed back in my update to the patch in March.

Jul 19 2020, 9:41 AM · Restricted Project, Restricted Project, Restricted Project

Jul 17 2020

logan-5 committed rG105056045d9a: [clang][NFC] Add a missing 'override' (authored by logan-5).
[clang][NFC] Add a missing 'override'
Jul 17 2020, 5:37 PM
logan-5 committed rG3ee7fe4cfda1: [llvm][NFC] Add missing 'override's (authored by logan-5).
[llvm][NFC] Add missing 'override's
Jul 17 2020, 5:37 PM
logan-5 committed rG31eb83496fb4: [llvm][NFC] Add missing 'override's in unittests/ (authored by logan-5).
[llvm][NFC] Add missing 'override's in unittests/
Jul 17 2020, 5:37 PM

Jul 16 2020

logan-5 committed rG5d31d09f768a: [polly][NFC] Add missing 'override's (authored by logan-5).
[polly][NFC] Add missing 'override's
Jul 16 2020, 8:12 PM
logan-5 committed rG947bf0fdf6e6: [compiler-rt][NFC] Add missing 'override's (authored by logan-5).
[compiler-rt][NFC] Add missing 'override's
Jul 16 2020, 8:12 PM

Jul 15 2020

logan-5 committed rG44b43a52dc17: [lldb][NFC] Add 'override' where missing in source/ and tools/ (authored by logan-5).
[lldb][NFC] Add 'override' where missing in source/ and tools/
Jul 15 2020, 11:35 AM
logan-5 closed D83847: [lldb][NFC] Add 'override' where missing in source/ and tools/.
Jul 15 2020, 11:35 AM · Restricted Project

Jul 14 2020

logan-5 created D83847: [lldb][NFC] Add 'override' where missing in source/ and tools/.
Jul 14 2020, 10:13 PM · Restricted Project
logan-5 added a comment to D83611: [clang][NFC] Add 'override' keyword to virtual function overrides.

If you add/leave the "Differential Revision: https://reviews.llvm.org/DXXXX" line in the commit message (arc will add this line automatically) Phabricator will close the review for you automatically

Thanks--figured that out shortly after I did this one. :)

Jul 14 2020, 1:27 PM · Restricted Project
logan-5 closed D83611: [clang][NFC] Add 'override' keyword to virtual function overrides.

Committed as rG2c2a297bb6d1

Jul 14 2020, 11:59 AM · Restricted Project
logan-5 committed rGa19461d9e114: [NFC] Add 'override' keyword where missing in include/ and lib/. (authored by logan-5).
[NFC] Add 'override' keyword where missing in include/ and lib/.
Jul 14 2020, 9:49 AM
logan-5 closed D83709: [NFC] Add 'override' keyword where missing in include/ and lib/..
Jul 14 2020, 9:49 AM · Restricted Project
logan-5 committed rGfbb30c31fefc: [clang] Add 'override' to virtual function overrides generated by… (authored by logan-5).
[clang] Add 'override' to virtual function overrides generated by…
Jul 14 2020, 9:39 AM
logan-5 closed D83616: [clang] Add 'override' to virtual function overrides generated by ClangAttrEmitter.
Jul 14 2020, 9:39 AM · Restricted Project
logan-5 committed rG2c2a297bb6d1: [clang][NFC] Add 'override' keyword to virtual function overrides (authored by logan-5).
[clang][NFC] Add 'override' keyword to virtual function overrides
Jul 14 2020, 9:03 AM

Jul 13 2020

logan-5 added a comment to D83616: [clang] Add 'override' to virtual function overrides generated by ClangAttrEmitter.

Thanks! I would appreciate any help committing this.

Jul 13 2020, 3:35 PM · Restricted Project
logan-5 created D83709: [NFC] Add 'override' keyword where missing in include/ and lib/..
Jul 13 2020, 11:51 AM · Restricted Project

Jul 12 2020

logan-5 added a comment to D82728: [clang] Add -Wsuggest-override.

Looks good - thanks for the patch and all the details! Might be worth turning on by default in the LLVM build (after all the cleanup)

Thanks a lot! I don't (think I) have commit access yada yada, so I'd really appreciate any help getting this committed.

Jul 12 2020, 3:14 PM · Restricted Project

Jul 10 2020

logan-5 created D83616: [clang] Add 'override' to virtual function overrides generated by ClangAttrEmitter.
Jul 10 2020, 8:05 PM · Restricted Project
logan-5 added a reviewer for D83611: [clang][NFC] Add 'override' keyword to virtual function overrides: rsmith.
Jul 10 2020, 7:25 PM · Restricted Project
logan-5 created D83611: [clang][NFC] Add 'override' keyword to virtual function overrides.
Jul 10 2020, 7:24 PM · Restricted Project