Page MenuHomePhabricator

gamesh411 (Endre Fülöp)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 19 2016, 5:58 AM (213 w, 4 d)

Recent Activity

Nov 28 2020

gamesh411 added a comment to D92103: [ASTImporter] Import the default argument of TemplateTypeParmDecl.

On bitcoin v0.18.1, there is an assertion introduced by this change.
The TU that can be used for reproduction is src/script/interpreter.cpp.
Assertion message:

CTU loaded AST file: /home/gamesh411/bitcoin/src/script/script.cpp                                                                                                                                         
clang: /home/gamesh411/llvm-project/clang/lib/AST/ASTContext.cpp:4411: clang::QualType clang::ASTContext::getInjectedClassNameType(clang::CXXRecordDecl*, clang::QualType) const: Assertion `NeedsInjectedC
lassNameType(Decl)' failed.
Nov 28 2020, 12:15 PM · Restricted Project, Restricted Project

Nov 25 2020

gamesh411 committed rGdc96cc33c13e: [clang][test] Fix prefix operator++ signature in iterators (authored by gamesh411).
[clang][test] Fix prefix operator++ signature in iterators
Nov 25 2020, 9:07 AM
gamesh411 closed D89528: [clang][test] Fix prefix operator++ signature in iterators.
Nov 25 2020, 9:07 AM · Restricted Project
gamesh411 abandoned D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.
In D83717#2370154, @NoQ wrote:

I don't think you actually need active support for invoking exit handlers path-sensitively at the end of main() in order to implement your checker. You can still find out in a path-insensitive manner whether any given function acts as an exit handler, like you already do. Then during path-sensitive analysis of that function you can warn at any invocation of exit().

I do believe that you want to implement this check as a path-sensitive check as long as you want any sort of interprocedural analysis (i.e., warn when an exit handler calls a function that calls a function ... that calls a function that calls exit() - and you do already have such tests). This is because of the following potential situation:

void foo(bool already_exiting) {
  if (!already_exiting)
    exit();
}

void bar() {
  foo(true);
}

void baz() {
  foo(false);
}

int main() {
  atexit(bar);
  return 0;
}

In this case bar() is an exit handler that calls foo() that calls exit(). However the code is correct and no warning should be emitted, because foo() would never call exit() when called from bar() specifically. Precise reasoning about such problems requires path-sensitive analysis. Of course it's up to you to decide what to do with these false positives - whether you'll be ok with having them, or choose to suppress with an imprecise heuristic - but that's one of the possible reasons to consider reimplementing the checker via path sensitive analysis that the static analyzer provides.

We've had a similar problem with the checker that warns on calling pure virtual functions in constructors/destructors (which is undefined behavior). Such checker had to be path sensitive in order to be interprocedural for the exact same unobvious reason. We've decided to re-implement it with path-sensitive analysis and now we're pretty happy about that decision.

Nov 25 2020, 1:01 AM · Restricted Project, Restricted Project, Restricted Project
gamesh411 abandoned D87830: [clang-tidy][test] Allow empty checks in check_clang_tidy.py.
Nov 25 2020, 12:44 AM · Restricted Project

Nov 23 2020

gamesh411 retitled D91948: [WIP][analyzer][doc] Add Container- and IteratorModeling developer docs from [analyzer][doc] Add Container- and IteratorModeling developer docs to [WIP][analyzer][doc] Add Container- and IteratorModeling developer docs.
Nov 23 2020, 1:48 AM · Restricted Project
gamesh411 requested review of D91948: [WIP][analyzer][doc] Add Container- and IteratorModeling developer docs.
Nov 23 2020, 1:45 AM · Restricted Project

Oct 31 2020

gamesh411 added a comment to D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.

Just to make sure we're on the same page -- the current approach is not flow-sensitive, and so my concern is that it won't report any true positives (not that it will be prone to false positives).

Sorry about that. You are absolutely right; what I was trying to say is CallGraph-based.

Oct 31 2020, 10:29 AM · Restricted Project, Restricted Project, Restricted Project

Oct 30 2020

gamesh411 added a comment to D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.

One of the concerns I have with this not being a cfg-only check is that most of the bad situations are not going to be caught by the clang-tidy version of the check.

...

Have you run this check over any large code bases to see if it currently catches any true positive diagnostics?

Oct 30 2020, 4:03 AM · Restricted Project, Restricted Project, Restricted Project

Oct 19 2020

gamesh411 added a comment to D87830: [clang-tidy][test] Allow empty checks in check_clang_tidy.py.

Probably not quite as verbose but should do the job

// RUN: clang-tidy %s --checks=-*,my-check-to-test --warnings-as-errors=* -- -std=c++11
Oct 19 2020, 5:26 AM · Restricted Project
gamesh411 updated subscribers of D89528: [clang][test] Fix prefix operator++ signature in iterators.
Oct 19 2020, 1:07 AM · Restricted Project
gamesh411 added a comment to D89528: [clang][test] Fix prefix operator++ signature in iterators.

What is the context here? Did it cause any crash/bug or were you just reading through the code for a good night sleep? :D

Oct 19 2020, 1:01 AM · Restricted Project

Oct 16 2020

gamesh411 added a comment to D87830: [clang-tidy][test] Allow empty checks in check_clang_tidy.py.
Oct 16 2020, 1:39 AM · Restricted Project
gamesh411 requested review of D89528: [clang][test] Fix prefix operator++ signature in iterators.
Oct 16 2020, 12:36 AM · Restricted Project

Sep 28 2020

gamesh411 added a comment to D87830: [clang-tidy][test] Allow empty checks in check_clang_tidy.py.

Do you have some thoughts about this, should this be pursued, or do you think the use-case is not relevant?

Sep 28 2020, 1:45 AM · Restricted Project

Sep 17 2020

gamesh411 updated the diff for D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.

Update commit message

Sep 17 2020, 7:09 AM · Restricted Project, Restricted Project, Restricted Project
gamesh411 updated the summary of D87830: [clang-tidy][test] Allow empty checks in check_clang_tidy.py.
Sep 17 2020, 7:06 AM · Restricted Project
gamesh411 updated the diff for D87830: [clang-tidy][test] Allow empty checks in check_clang_tidy.py.

Tidy up commit message

Sep 17 2020, 7:06 AM · Restricted Project
gamesh411 updated the summary of D87830: [clang-tidy][test] Allow empty checks in check_clang_tidy.py.
Sep 17 2020, 7:03 AM · Restricted Project
gamesh411 added reviewers for D87830: [clang-tidy][test] Allow empty checks in check_clang_tidy.py: aaron.ballman, lebedev.ri, alexfh, hokein, Eugene.Zelenko.
Sep 17 2020, 7:02 AM · Restricted Project
gamesh411 updated the diff for D87830: [clang-tidy][test] Allow empty checks in check_clang_tidy.py.

Update commit msg with example

Sep 17 2020, 7:00 AM · Restricted Project
gamesh411 requested review of D87830: [clang-tidy][test] Allow empty checks in check_clang_tidy.py.
Sep 17 2020, 6:55 AM · Restricted Project
gamesh411 updated the diff for D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.

Reformat diagnostic message
Use explicit name longjmp instead of jump function
Fix liberal auto inside Collector

Sep 17 2020, 12:34 AM · Restricted Project, Restricted Project, Restricted Project
gamesh411 added a comment to D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.

Note that there are no negative test cases that assert that we do NOT report in case a custom or an anonymous namespace is used. For that I would need a small patch in the testing infrastructure.
Patch needed in check_clang_tidy.py:

--- a/clang-tools-extra/test/clang-tidy/check_clang_tidy.py
+++ b/clang-tools-extra/test/clang-tidy/check_clang_tidy.py
@@ -167,7 +167,7 @@ def run_test_once(args, extra_args):
       subprocess.check_output(
           ['FileCheck', '-input-file=' + temp_file_name, input_file_name,
            '-check-prefixes=' + ','.join(check_fixes_prefixes),
-           '-strict-whitespace'],
+           '-strict-whitespace', '--allow-empty'],
           stderr=subprocess.STDOUT)
     except subprocess.CalledProcessError as e:
       print('FileCheck failed:\n' + e.output.decode())
@@ -180,7 +180,7 @@ def run_test_once(args, extra_args):
       subprocess.check_output(
           ['FileCheck', '-input-file=' + messages_file, input_file_name,
            '-check-prefixes=' + ','.join(check_messages_prefixes),
-           '-implicit-check-not={{warning|error}}:'],
+           '-implicit-check-not={{warning|error}}:', '--allow-empty'],
           stderr=subprocess.STDOUT)
     except subprocess.CalledProcessError as e:
       print('FileCheck failed:\n' + e.output.decode())
@@ -195,7 +195,7 @@ def run_test_once(args, extra_args):
       subprocess.check_output(
           ['FileCheck', '-input-file=' + notes_file, input_file_name,
            '-check-prefixes=' + ','.join(check_notes_prefixes),
-           '-implicit-check-not={{note|warning|error}}:'],
+           '-implicit-check-not={{note|warning|error}}:', '--allow-empty'],
           stderr=subprocess.STDOUT)
     except subprocess.CalledProcessError as e:
       print('FileCheck failed:\n' + e.output.decode())
Sep 17 2020, 12:21 AM · Restricted Project, Restricted Project, Restricted Project
gamesh411 updated the diff for D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.

Add abort and terminate handling
Extend tests to cover every exit functions
Extract matcher bind labels

Sep 17 2020, 12:04 AM · Restricted Project, Restricted Project, Restricted Project

Sep 2 2020

gamesh411 updated the diff for D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.

only consider global and ::std scope handlers

Sep 2 2020, 3:46 PM · Restricted Project, Restricted Project, Restricted Project

Aug 31 2020

gamesh411 added a comment to D85424: [Analyzer] Crash fix for alpha.cplusplus.IteratorRange.

CReduce did not manage to produce any meaningful result after a week worth of runtime (more than ~2000 lines of code still remaining after reduction). We could track this down by tracing the ExprEngine code that assigns the Undefined SVal but that seems a huge effort as well. That could be done by debugging the SVal-assigning statements, and setting conditional breakpoints (ie. only break when the value is Undefined). When a breakpoint is hit, we could dump the statement that triggered it and try to reason about the conditions at that point. I also recommend using the rr tool as it allows you to use fixed pointer values while debugging.

Aug 31 2020, 9:35 AM · Restricted Project

Aug 14 2020

gamesh411 accepted D77229: [Analyzer][NFC] Avoid handling of LazyCompundVals in IteratorModeling.

Thanks! LGTM now.

Aug 14 2020, 12:36 AM · Restricted Project

Aug 13 2020

gamesh411 added a comment to D77229: [Analyzer][NFC] Avoid handling of LazyCompundVals in IteratorModeling.

Aside from infrastructural questions which I am not qualified ( nor particularly knowledgeable :3 ) to address, this looks good to me.

Aug 13 2020, 1:29 AM · Restricted Project

Aug 12 2020

gamesh411 added inline comments to D85728: [Analyzer] Support for the new variadic isa<> and isa_and_not_null<> in CastValueChecker.
Aug 12 2020, 1:10 AM · Restricted Project

Aug 4 2020

gamesh411 updated the diff for D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.

rename file name in header

Aug 4 2020, 2:13 AM · Restricted Project, Restricted Project, Restricted Project
gamesh411 committed rG141cb8a1eecc: [analyzer] Model iterator random incrementation symmetrically (authored by gamesh411).
[analyzer] Model iterator random incrementation symmetrically
Aug 4 2020, 2:04 AM
gamesh411 closed D83190: [analyzer] Model iterator random incrementation symmetrically.
Aug 4 2020, 2:04 AM · Restricted Project
gamesh411 added a comment to D84520: [Analyzer] Improve invalid dereference bug reporting in DereferenceChecker..

I would add one more test for the undefined case. Like a local array variable that is uninitialized. That could mirror some of the null-dereference cases.

Aug 4 2020, 12:46 AM · Restricted Project

Aug 3 2020

gamesh411 updated the diff for D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.

rebase

Aug 3 2020, 2:15 AM · Restricted Project, Restricted Project, Restricted Project
gamesh411 added a comment to D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.

I have updated the revision to use llvm::move algorithm (available thanks to @njames93).
Friendly ping :)

Aug 3 2020, 2:04 AM · Restricted Project, Restricted Project, Restricted Project
gamesh411 updated the diff for D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.

ensure lint in path

Aug 3 2020, 2:01 AM · Restricted Project, Restricted Project, Restricted Project
gamesh411 updated the diff for D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.

use llvm::move algorithm

Aug 3 2020, 1:58 AM · Restricted Project, Restricted Project, Restricted Project
gamesh411 abandoned D85112: use llvm::move algorithm.

arcanist misfire, see D83717

Aug 3 2020, 1:54 AM · Restricted Project
gamesh411 updated the diff for D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.

use llvm::move algorithm

Aug 3 2020, 1:52 AM · Restricted Project, Restricted Project, Restricted Project
gamesh411 requested review of D85112: use llvm::move algorithm.
Aug 3 2020, 1:50 AM · Restricted Project

Jul 21 2020

gamesh411 added inline comments to D83902: [ADT] Add a range-based version of std::move.
Jul 21 2020, 11:59 AM · Restricted Project
gamesh411 added a comment to D83190: [analyzer] Model iterator random incrementation symmetrically.

I experienced 2 crashes with and without this patch using commit 1af9fc82132da7c876e8f70c4e986cc9c59010ee on master:
I have used the clang built on that revision to analyse itself, and also used the patched version (with this current revision applied) to do the same.

Jul 21 2020, 8:25 AM · Restricted Project
gamesh411 added a comment to D83902: [ADT] Add a range-based version of std::move.

To further investigate the moving story, I also created a small example on Godbolt:
https://godbolt.org/z/5qMf1o

Jul 21 2020, 7:59 AM · Restricted Project

Jul 17 2020

gamesh411 added inline comments to D83902: [ADT] Add a range-based version of std::move.
Jul 17 2020, 5:35 PM · Restricted Project
gamesh411 added inline comments to D83902: [ADT] Add a range-based version of std::move.
Jul 17 2020, 4:35 PM · Restricted Project
gamesh411 added inline comments to D83902: [ADT] Add a range-based version of std::move.
Jul 17 2020, 4:24 PM · Restricted Project
gamesh411 accepted D83902: [ADT] Add a range-based version of std::move.

LGTM!

Jul 17 2020, 4:00 PM · Restricted Project
gamesh411 added inline comments to D83902: [ADT] Add a range-based version of std::move.
Jul 17 2020, 2:25 PM · Restricted Project
gamesh411 added a comment to D83902: [ADT] Add a range-based version of std::move.

I am happy to see this change, as I could use it inside my clang-tidy check as well!

Jul 17 2020, 12:13 PM · Restricted Project
gamesh411 updated the diff for D83190: [analyzer] Model iterator random incrementation symmetrically.

rename Offset -> Amount inside handleRandomIncrOrDecl
minor local variable renaming

Jul 17 2020, 11:37 AM · Restricted Project
gamesh411 updated the diff for D83190: [analyzer] Model iterator random incrementation symmetrically.

apply review suggestions

  • rename variables
  • remove 1 assert
  • rename tests
Jul 17 2020, 11:10 AM · Restricted Project
gamesh411 added a comment to D83190: [analyzer] Model iterator random incrementation symmetrically.

Thanks for reviewing this patch this quickly!
I have updated the diff according to your suggestions, but I will not land it till I run a llvm+clang analysis with it.
Do you think non-ctu mode is enough to test the stability?

Jul 17 2020, 11:09 AM · Restricted Project
gamesh411 added a comment to D83190: [analyzer] Model iterator random incrementation symmetrically.

It would be nice to see the measurements on llvm as this patch introduced some (IMO reasonable) asserts. Also in the unlikely case, there is an expression like 1 + iter, there could be more results.

Jul 17 2020, 6:28 AM · Restricted Project
gamesh411 updated the diff for D83190: [analyzer] Model iterator random incrementation symmetrically.

rebase upon hotfix patch

Jul 17 2020, 6:14 AM · Restricted Project
gamesh411 committed rGfd02a86260b3: [analyzer] Add system header simulator a symmetric random access iterator… (authored by gamesh411).
[analyzer] Add system header simulator a symmetric random access iterator…
Jul 17 2020, 5:39 AM
gamesh411 closed D83226: [analyzer] Add system header simulator a symmetric random access iterator operator+.
Jul 17 2020, 5:39 AM · Restricted Project
gamesh411 added inline comments to D69318: [analyzer] Add SufficientSizeArrayIndexingChecker.
Jul 17 2020, 5:07 AM · Restricted Project
gamesh411 updated the diff for D69318: [analyzer] Add SufficientSizeArrayIndexingChecker.

extend test cases
add comments to non-obvious cases

Jul 17 2020, 5:00 AM · Restricted Project
gamesh411 updated the diff for D69318: [analyzer] Add SufficientSizeArrayIndexingChecker.

move tests to one file

Jul 17 2020, 3:10 AM · Restricted Project
gamesh411 added a comment to D69318: [analyzer] Add SufficientSizeArrayIndexingChecker.

I am now experimenting with the suggestions. The other issues are on the worklist. Thanks for these so far.

Jul 17 2020, 1:36 AM · Restricted Project

Jul 16 2020

gamesh411 accepted D83295: [Analyzer] Hotfix for various crashes in iterator checkers.
Jul 16 2020, 6:09 AM · Restricted Project
gamesh411 added a comment to D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.

I have bitten the bullet, and have gone down this route. With relative numbering, the sections themselves are at least translation-invariant. Not the prettiest sight, tho.
Thanks!

I almost think it would be nice FileCheck supported some directive like:

// LINE-NAME: <LINENAME>

And corresponding check lines:

[[<LINENAME>]]
[[<LINENAME>+N]] 
[[<LINENAME>-N]]

Would result in the ability to write checks like this:

void longjmp_handler() {// LINE-NAME: LONGJMP
    longjmp(env, 255); 
}

...

void foo(){
  atexit(longjmp_handler);
   // CHECK-NOTES: :[[@LINE-1]]:3: warning: exit-handler potentially calls a jump function. Handlers should terminate by returning [cert-env32-c]
  // CHECK-NOTES: :[[LONGJMP]]:1: note: handler function declared here
  // CHECK-NOTES: :[[LONGJMP+1]]:3: note: jump function called here
}

Anyway that's a story for another day.

Jul 16 2020, 1:31 AM · Restricted Project, Restricted Project, Restricted Project

Jul 15 2020

gamesh411 added a comment to D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.

@Eugene.Zelenko I have just rebase-d, and seen that the release notes page itself was bumped to clang-tidy 12. I have added my check as a new check there. Should I also add the other subsections (like improvements in existing checks, and new check aliases), or authors will add them as needed?

No, that sections will be filled when related changes will be made. Release Notes are reset to blank state in master after branching release.

Jul 15 2020, 7:41 AM · Restricted Project, Restricted Project, Restricted Project
gamesh411 added a comment to D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.

@Eugene.Zelenko I have just rebase-d, and seen that the release notes page itself was bumped to clang-tidy 12. I have added my check as a new check there. Should I also add the other subsections (like improvements in existing checks, and new check aliases), or authors will add them as needed?

Jul 15 2020, 7:33 AM · Restricted Project, Restricted Project, Restricted Project
gamesh411 updated the diff for D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.

rebase

Jul 15 2020, 7:30 AM · Restricted Project, Restricted Project, Restricted Project
gamesh411 updated the diff for D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.

tidy up release notes, make all new check entries uniform

Jul 15 2020, 7:21 AM · Restricted Project, Restricted Project, Restricted Project
gamesh411 added inline comments to D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.
Jul 15 2020, 7:16 AM · Restricted Project, Restricted Project, Restricted Project
gamesh411 updated the diff for D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.

add missing newline in release notes

Jul 15 2020, 7:15 AM · Restricted Project, Restricted Project, Restricted Project
gamesh411 updated the diff for D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.

.

Jul 15 2020, 7:07 AM · Restricted Project, Restricted Project, Restricted Project
gamesh411 added inline comments to D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.
Jul 15 2020, 7:06 AM · Restricted Project, Restricted Project, Restricted Project
gamesh411 updated the diff for D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.

fix documentation header

Jul 15 2020, 7:06 AM · Restricted Project, Restricted Project, Restricted Project
gamesh411 added a comment to D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.

@steakhal @Eugene.Zelenko Thanks for checking this patch! I have tried my best to adhere to your suggestions.

Jul 15 2020, 2:41 AM · Restricted Project, Restricted Project, Restricted Project
gamesh411 added a comment to D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.
Jul 15 2020, 2:40 AM · Restricted Project, Restricted Project, Restricted Project
gamesh411 added inline comments to D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.
Jul 15 2020, 2:31 AM · Restricted Project, Restricted Project, Restricted Project
gamesh411 updated the diff for D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.

use move instead of copy
fix documentation issues
fix tests

Jul 15 2020, 2:23 AM · Restricted Project, Restricted Project, Restricted Project

Jul 14 2020

gamesh411 added a comment to D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.

Thanks @njames93 :) I have extended the check with notes, but I have to figure out how to appease file-check, so its still WIP until I do.

Jul 14 2020, 5:55 AM · Restricted Project, Restricted Project, Restricted Project
gamesh411 updated the diff for D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.

extend with notes
apply minor fixes
tests are WIP until I figure out how to properly use file-check

Jul 14 2020, 5:50 AM · Restricted Project, Restricted Project, Restricted Project

Jul 13 2020

gamesh411 updated the diff for D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.

mention iterator header

Jul 13 2020, 3:22 PM · Restricted Project, Restricted Project, Restricted Project
gamesh411 updated the diff for D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.

use std::copy algorithm
polish

Jul 13 2020, 3:21 PM · Restricted Project, Restricted Project, Restricted Project
gamesh411 updated the diff for D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.

fix test diag location changes resulting from autoformatting

Jul 13 2020, 3:05 PM · Restricted Project, Restricted Project, Restricted Project
gamesh411 updated the diff for D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.

simplify VisitCallExpr

Jul 13 2020, 2:38 PM · Restricted Project, Restricted Project, Restricted Project
gamesh411 updated the diff for D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.

update includes

Jul 13 2020, 2:31 PM · Restricted Project, Restricted Project, Restricted Project
gamesh411 added reviewers for D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C: aaron.ballman, dkrupp, Szelethus, steakhal, martong.
Jul 13 2020, 2:16 PM · Restricted Project, Restricted Project, Restricted Project
Herald added projects to D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C: Restricted Project, Restricted Project.
Jul 13 2020, 2:11 PM · Restricted Project, Restricted Project, Restricted Project

Jul 10 2020

gamesh411 added a comment to D83555: [analyzer] Fix ctu-on-demand-parsing: REQUIRES: linux -> REQUIRES: system-linux.

In addition, IMHO the test infra should then be extended to throw an exception, when a feature is referenced that is not mentioned anywhere. That would be helpful in the future.

Jul 10 2020, 7:36 AM · Restricted Project
gamesh411 accepted D83555: [analyzer] Fix ctu-on-demand-parsing: REQUIRES: linux -> REQUIRES: system-linux.

Good thing you were looking inside the test infra code to catch this, kudos!

Jul 10 2020, 6:58 AM · Restricted Project

Jul 9 2020

gamesh411 added a comment to D83295: [Analyzer] Hotfix for various crashes in iterator checkers.

@Szelethus thanks for being watchful, appreciated c:

Jul 9 2020, 7:25 AM · Restricted Project
gamesh411 accepted D83295: [Analyzer] Hotfix for various crashes in iterator checkers.
Jul 9 2020, 7:22 AM · Restricted Project
gamesh411 added inline comments to D83475: [analyzer] Add CTUImportCppThreshold for C++ files.
Jul 9 2020, 6:00 AM · Restricted Project
gamesh411 accepted D83475: [analyzer] Add CTUImportCppThreshold for C++ files.

It will be interesting to see how different C and C++ projects will prove in terms of AST complexity, and Decl-size, but I understand that for now, these two options are necessary to not penalize C project analysis because of C++ AST complexity.

Jul 9 2020, 5:59 AM · Restricted Project

Jul 8 2020

gamesh411 updated the diff for D69318: [analyzer] Add SufficientSizeArrayIndexingChecker.

apply review suggestions

Jul 8 2020, 2:19 AM · Restricted Project
gamesh411 added inline comments to D69318: [analyzer] Add SufficientSizeArrayIndexingChecker.
Jul 8 2020, 1:43 AM · Restricted Project

Jul 7 2020

gamesh411 updated the diff for D83190: [analyzer] Model iterator random incrementation symmetrically.

fix tidy diagnostic

Jul 7 2020, 2:20 AM · Restricted Project
gamesh411 added a comment to D69318: [analyzer] Add SufficientSizeArrayIndexingChecker.

The checker has been updated, the comments and the logic polished. I would still take a stab at this being a ClangSa checker (as opposed to being a Tidy check). What do you think?

Jul 7 2020, 1:41 AM · Restricted Project
gamesh411 added inline comments to D69318: [analyzer] Add SufficientSizeArrayIndexingChecker.
Jul 7 2020, 1:36 AM · Restricted Project
gamesh411 added inline comments to D69318: [analyzer] Add SufficientSizeArrayIndexingChecker.
Jul 7 2020, 1:35 AM · Restricted Project
gamesh411 updated the diff for D69318: [analyzer] Add SufficientSizeArrayIndexingChecker.

fix detection logic
fix license header
add missing warning to test

Jul 7 2020, 1:31 AM · Restricted Project
gamesh411 added a reviewer for D69318: [analyzer] Add SufficientSizeArrayIndexingChecker: balazske.
Jul 7 2020, 1:19 AM · Restricted Project

Jul 6 2020

gamesh411 added inline comments to D83190: [analyzer] Model iterator random incrementation symmetrically.
Jul 6 2020, 2:47 PM · Restricted Project