Page MenuHomePhabricator

gamesh411 (Endre Fülöp)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 19 2016, 5:58 AM (122 w, 12 h)

Recent Activity

Sun, Mar 31

gamesh411 added a comment to D59934: Compare SourceLocations from different TUs by FileID.

Hmm. Is your clang recent enough to contain @bruntib's patch D57892? Is it possible that this patch solves the same issue? With this patch applied, are you able to get a macro expansions from a different TU in the plist output, or does this patch only resolve the regression?

Sun, Mar 31, 6:30 AM · Restricted Project
gamesh411 added a comment to D59934: Compare SourceLocations from different TUs by FileID.

I would still like to learn more about this issue. I am somewhat afraid that the our macro expansion is faulty. Can you provide a stacktrace maybe?

Sun, Mar 31, 3:47 AM · Restricted Project

Sat, Mar 30

gamesh411 added a comment to D59934: Compare SourceLocations from different TUs by FileID.

Test?

Sat, Mar 30, 4:56 PM · Restricted Project
gamesh411 added a comment to D59934: Compare SourceLocations from different TUs by FileID.

Just have a bit more context, I have the following information from a debug session at the execution point of the unreachable:

Sat, Mar 30, 3:45 PM · Restricted Project
gamesh411 added a comment to D59934: Compare SourceLocations from different TUs by FileID.

Hi!

This issue came up during the generation BugReports of BugPaths containing macro-expansions, where the spelling location and expansion locations were in different files.
With this change, we make such SourceLocations comparable by their FileIDs.

Do you mean regular macro expansions or the one we're generating in the plist output via -analyzer-config expand-macros=true?

Sat, Mar 30, 3:41 PM · Restricted Project

Thu, Mar 28

gamesh411 added reviewers for D59934: Compare SourceLocations from different TUs by FileID: aaron.ballman, a_sidorin, xazax.hun.
Thu, Mar 28, 7:54 AM · Restricted Project
gamesh411 added a comment to D59934: Compare SourceLocations from different TUs by FileID.

This issue came up during the generation BugReports of BugPaths containing macro-expansions, where the spelling location and expansion locations were in different files.
With this change, we make such SourceLocations comparable by their FileIDs.

Thu, Mar 28, 7:53 AM · Restricted Project
gamesh411 created D59934: Compare SourceLocations from different TUs by FileID.
Thu, Mar 28, 7:40 AM · Restricted Project
gamesh411 added a comment to D59761: [ASTImporter] Convert ODR diagnostics inside ASTImporter implementation.

ping @a_sidorin @shafik

Thu, Mar 28, 7:22 AM · Restricted Project, Restricted Project
gamesh411 added a comment to D58897: [ASTImporter] Make ODR error handling configurable.

ping @a_sidorin

Thu, Mar 28, 7:18 AM · Restricted Project
gamesh411 retitled D59798: [analyzer] Add analyzer option to limit the number of imported TUs from Add analyzer option to limit the number of imported TUs to [analyzer] Add analyzer option to limit the number of imported TUs.
Thu, Mar 28, 12:41 AM · Restricted Project
gamesh411 retitled D59798: [analyzer] Add analyzer option to limit the number of imported TUs from [WIP] Add analyzer option to limit the number of imported TUs to Add analyzer option to limit the number of imported TUs.
Thu, Mar 28, 12:35 AM · Restricted Project
gamesh411 updated the diff for D59798: [analyzer] Add analyzer option to limit the number of imported TUs.

Updated option handling location to use AnalyzerOptions instead of CC1

Thu, Mar 28, 12:32 AM · Restricted Project

Mon, Mar 25

gamesh411 retitled D59761: [ASTImporter] Convert ODR diagnostics inside ASTImporter implementation from [ASTImporter] Covert ODR diagnostics inside ASTImporter implementation to [ASTImporter] Convert ODR diagnostics inside ASTImporter implementation.
Mon, Mar 25, 2:02 PM · Restricted Project, Restricted Project
gamesh411 retitled D59798: [analyzer] Add analyzer option to limit the number of imported TUs from Add analyzer option to limit the number of imported TUs to [WIP] Add analyzer option to limit the number of imported TUs.
Mon, Mar 25, 1:58 PM · Restricted Project
gamesh411 created D59798: [analyzer] Add analyzer option to limit the number of imported TUs.
Mon, Mar 25, 1:42 PM · Restricted Project
gamesh411 added a comment to D59761: [ASTImporter] Convert ODR diagnostics inside ASTImporter implementation.

During CTU analysis, not only StructuralEquivalence but the main implementation of ASTImporter can also emit ODR-related diagnostics. After some consideration, I have chosen not to make these dependent on a switch, as ASTImporter is not nearly as widely used as StructuralEquivalence (thru Sema), and it would also complicate the code unnecessarily.
What do you think?

Mon, Mar 25, 4:28 AM · Restricted Project, Restricted Project
gamesh411 added a child revision for D58897: [ASTImporter] Make ODR error handling configurable: D59761: [ASTImporter] Convert ODR diagnostics inside ASTImporter implementation.
Mon, Mar 25, 4:21 AM · Restricted Project
gamesh411 added a parent revision for D59761: [ASTImporter] Convert ODR diagnostics inside ASTImporter implementation: D58897: [ASTImporter] Make ODR error handling configurable.
Mon, Mar 25, 4:21 AM · Restricted Project, Restricted Project
gamesh411 updated subscribers of D59761: [ASTImporter] Convert ODR diagnostics inside ASTImporter implementation.
Mon, Mar 25, 4:21 AM · Restricted Project, Restricted Project
Herald added a reviewer for D59761: [ASTImporter] Convert ODR diagnostics inside ASTImporter implementation: a.sidorin.
Mon, Mar 25, 4:21 AM · Restricted Project, Restricted Project
gamesh411 added inline comments to D58897: [ASTImporter] Make ODR error handling configurable.
Mon, Mar 25, 4:11 AM · Restricted Project
gamesh411 updated the diff for D58897: [ASTImporter] Make ODR error handling configurable.
  • Revert member order to original
Mon, Mar 25, 4:11 AM · Restricted Project

Mar 7 2019

gamesh411 retitled D58897: [ASTImporter] Make ODR error handling configurable from Make ODR error handling configurable to [ASTImporter] Make ODR error handling configurable.
Mar 7 2019, 8:58 AM · Restricted Project

Mar 4 2019

gamesh411 added reviewers for D58897: [ASTImporter] Make ODR error handling configurable: a_sidorin, shafik.
Mar 4 2019, 5:45 AM · Restricted Project
gamesh411 added a comment to D58897: [ASTImporter] Make ODR error handling configurable.

This revision is the alternative of the abandoned D55646.
Now Sema uses the old behavior of emitting ODR errors while merging and importing is done in a more lenient way.

Mar 4 2019, 5:44 AM · Restricted Project
gamesh411 created D58897: [ASTImporter] Make ODR error handling configurable.
Mar 4 2019, 5:34 AM · Restricted Project

Feb 14 2019

gamesh411 abandoned D55646: [ASTImporter] Make ODR diagnostics warning by default.

I am creating a new revision that keeps the old handling of ODR violations the same when used by parts of the Sema, but emit warnings when used by the ASTImporter.

Feb 14 2019, 2:28 AM · Restricted Project
Herald added a project to D55646: [ASTImporter] Make ODR diagnostics warning by default: Restricted Project.

I am going to abandon this modification, as setting ODR violations as warnings, seems like a change that could have unforeseen consequences.

Feb 14 2019, 2:24 AM · Restricted Project

Feb 6 2019

gamesh411 updated the diff for D57740: [ASTImporter] Import every Decl in lambda record.

Remove unnecessary ToTU variable from test case.

Feb 6 2019, 1:41 AM · Restricted Project, Restricted Project

Feb 5 2019

gamesh411 created D57740: [ASTImporter] Import every Decl in lambda record.
Feb 5 2019, 2:41 AM · Restricted Project, Restricted Project

Jan 8 2019

gamesh411 added a comment to D55646: [ASTImporter] Make ODR diagnostics warning by default.

Ping.

Jan 8 2019, 1:53 AM · Restricted Project
gamesh411 added a comment to D55646: [ASTImporter] Make ODR diagnostics warning by default.

Hey Aleksei!
Thank you for the input! ODR violations being warnings would be beneficial from the code maintenance point of view, as we would not have to resort to duplicate some (if not most) of them as errors. There is also a flexibility advantage in the diagnostics, as warnings can be propagated to error level or suppressed, whereas errors cannot be "demoted" (AFAIK). So while I am not opposed to providing an error AND a warning for these kinds of violations, if the SEMA or other modules do not need them to be explicitly defined as errors (for I don't know... tooling support or other reasons), then it would be cleaner to only have warnings for these.

Jan 8 2019, 1:52 AM · Restricted Project

Dec 13 2018

gamesh411 added a comment to D55646: [ASTImporter] Make ODR diagnostics warning by default.

In order to be able to handle ODR-related diagnostics with command line options, these diagnostics were moved from Error category to Warning. What are your thoughts?

Dec 13 2018, 1:37 AM · Restricted Project
gamesh411 created D55646: [ASTImporter] Make ODR diagnostics warning by default.
Dec 13 2018, 1:33 AM · Restricted Project

Dec 10 2018

gamesh411 added a comment to D48866: [clang-tidy] Add incorrect-pointer-cast checker.

In my opinion, after migrating relevant test cases from D33826, this is ready.

Dec 10 2018, 2:58 AM · Restricted Project

Nov 5 2018

gamesh411 added a comment to D33672: [analyzer] INT50-CPP. Do not cast to an out-of-range enumeration checker.

Hi!
Thanks for your reviews, although I haven't been active for some time now.
I personally do not have commit rights, so could someone else take care of it?

Nov 5 2018, 5:32 AM

Aug 22 2017

gamesh411 updated the diff for D33672: [analyzer] INT50-CPP. Do not cast to an out-of-range enumeration checker.
Aug 22 2017, 5:19 AM
gamesh411 updated the diff for D33672: [analyzer] INT50-CPP. Do not cast to an out-of-range enumeration checker.

I have implemented the std::transform. The previous version used std::for_each because the iterator for enum declarations was not a random access iterator, but it turned out that I can solve this problem via std::distance. Thanks for sticking to your opinion on this one, because of it I could learn something new.

Aug 22 2017, 5:16 AM

Aug 20 2017

gamesh411 added a comment to D27918: [analyzer] OStreamChecker.

Ping. @NoQ would you please have a look? Thanks!

Aug 20 2017, 1:27 PM

Aug 3 2017

gamesh411 added a comment to D33672: [analyzer] INT50-CPP. Do not cast to an out-of-range enumeration checker.

As for the the loss of precision problem, in the special case of char the size of char is known. However does the analysis have the necessary information in this stage to know the size of an int for example? I found bit-width specifying information in the llvm::Type class which is used in the code generation phase. It could be done by checking on a per type basis, but then again, it could possibly lead to false positives. Correct me if I am wrong.

Aug 3 2017, 7:07 AM
gamesh411 updated the diff for D33672: [analyzer] INT50-CPP. Do not cast to an out-of-range enumeration checker.

Applied most of the suggested changes, thanks for all the insights!

Aug 3 2017, 6:52 AM

Jul 24 2017

gamesh411 updated the diff for D27918: [analyzer] OStreamChecker.
Jul 24 2017, 10:26 AM
gamesh411 updated the diff for D27918: [analyzer] OStreamChecker.
Jul 24 2017, 10:07 AM
gamesh411 added a comment to D27918: [analyzer] OStreamChecker.

After experimentation the following AST difference between the mock and the standard library implementation still stands (which necessitates the special handling of the complex manipulators). Example:

Jul 24 2017, 9:55 AM
gamesh411 added inline comments to D33672: [analyzer] INT50-CPP. Do not cast to an out-of-range enumeration checker.
Jul 24 2017, 5:12 AM
gamesh411 updated the diff for D33672: [analyzer] INT50-CPP. Do not cast to an out-of-range enumeration checker.

Fixed the naming convention issues. Also applied the suggested modifications inside the overridden checker method.

Jul 24 2017, 5:01 AM

Jun 6 2017

gamesh411 updated the diff for D27918: [analyzer] OStreamChecker.

Update diff.

Jun 6 2017, 6:11 AM
gamesh411 added a comment to D27918: [analyzer] OStreamChecker.

Update diff.

Jun 6 2017, 6:04 AM

May 30 2017

gamesh411 created D33672: [analyzer] INT50-CPP. Do not cast to an out-of-range enumeration checker.
May 30 2017, 5:25 AM

Feb 28 2017

gamesh411 added a comment to D27918: [analyzer] OStreamChecker.

Hello,
This checker was developed indeed with internal usage in mind. It should not necessary be added as a default checker. However I have run it on the boost-1.63.0 codebase, and there some some mildly interesting findings in examples and tests. There is also a true positive result in the core codebase.

Feb 28 2017, 4:58 AM

Dec 19 2016

gamesh411 retitled D27918: [analyzer] OStreamChecker from to OStreamChecker.
Dec 19 2016, 6:18 AM