Page MenuHomePhabricator
People PiotrZSL

PiotrZSL (Piotr Zegar)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 8 2015, 3:04 PM (397 w, 6 d)

Hi everyone, my name is Piotr Zegar, and I am a software engineer from Poland with over 15 years of experience in C++ language. Throughout my career, I have specialized in performance optimizations and have a knack for problem-solving. Since 2016, I have been actively involved in helping teams replace commercial products for static code analysis with Clang-tidy in projects that I work on. I have also been maintaining an internal Clang-tidy fork and have written over 150 custom Clang-tidy checks for internal use over the years. I have a deep understanding of software architecture and design, which allows me to bring a unique perspective to every project I work on. I prefer "old-style" solutions that stand the test of time, and I am committed to delivering high-quality work. I pay close attention to detail and enjoy finding efficient ways to improve software performance.

I am excited to be a part of this community of Clang-tidy enthusiasts and look forward to sharing my experience and insights with you all.
(I have write access to repository)

Recent Activity
View All

Today

PiotrZSL added a reviewer for D146842: [clang-tidy] Fix crash when handling invalid config values: carlosgalvezp.
Fri, Mar 24, 1:45 PM · Restricted Project, Restricted Project
PiotrZSL requested review of D146842: [clang-tidy] Fix crash when handling invalid config values.
Fri, Mar 24, 1:00 PM · Restricted Project, Restricted Project

Yesterday

PiotrZSL accepted D146713: [clang-tidy][NFC] Improve naming convention in google-readability-avoid-underscore-in-googletest-name.
Thu, Mar 23, 3:01 PM · Restricted Project, Restricted Project
PiotrZSL requested changes to D146712: [clang-tidy] Add portability-non-portable-integer-constant check.

Additionally, fix build.
Once you finish making changes to this review, switch it back to ready for review.

Thu, Mar 23, 3:00 PM · Restricted Project, Restricted Project
PiotrZSL planned changes to D146396: [clang-tidy] Use checks dependences for Analyzer checks.

Verify with Static Analyser developers.

Thu, Mar 23, 2:59 PM · Restricted Project, Restricted Project
PiotrZSL accepted D146713: [clang-tidy][NFC] Improve naming convention in google-readability-avoid-underscore-in-googletest-name.
Thu, Mar 23, 8:23 AM · Restricted Project, Restricted Project
PiotrZSL added inline comments to D146712: [clang-tidy] Add portability-non-portable-integer-constant check.
Thu, Mar 23, 8:21 AM · Restricted Project, Restricted Project
PiotrZSL requested changes to D145581: [clang-tidy] In C++17, callee is guaranteed to be sequenced before arguments..

Switching status of review, once you will be ready with changes (or your decision), just mark it ready for review again.

Thu, Mar 23, 12:41 AM · Restricted Project, Restricted Project
PiotrZSL added inline comments to D146655: [clang-tidy] Ignore DISABLED_ in test suite name in google-avoid-underscore-in-googletest-name.
Thu, Mar 23, 12:38 AM · Restricted Project, Restricted Project
PiotrZSL added inline comments to D130181: [clang-tidy] Add readability-use-early-exits check.
Thu, Mar 23, 12:30 AM · Restricted Project, Restricted Project

Wed, Mar 22

PiotrZSL added inline comments to D146655: [clang-tidy] Ignore DISABLED_ in test suite name in google-avoid-underscore-in-googletest-name.
Wed, Mar 22, 2:34 PM · Restricted Project, Restricted Project
PiotrZSL accepted D146655: [clang-tidy] Ignore DISABLED_ in test suite name in google-avoid-underscore-in-googletest-name.
Wed, Mar 22, 1:34 PM · Restricted Project, Restricted Project
PiotrZSL accepted D146288: clang-tidy: Detect use-after-move in CXXCtorInitializer.
Wed, Mar 22, 4:43 AM · Restricted Project, Restricted Project

Tue, Mar 21

PiotrZSL accepted D146520: [clang-tidy] Fix checks filter with warnings-as-errors.

Looks fine, and looks like it's working.

Tue, Mar 21, 1:32 PM · Restricted Project, Restricted Project
PiotrZSL added inline comments to D145581: [clang-tidy] In C++17, callee is guaranteed to be sequenced before arguments..
Tue, Mar 21, 6:00 AM · Restricted Project, Restricted Project

Mon, Mar 20

PiotrZSL accepted D146288: clang-tidy: Detect use-after-move in CXXCtorInitializer.

Overall LGTM, give it few days, maybe something will pop up.
I will try to run this change on my project and check if it finds any false-positives or real-issues.

Mon, Mar 20, 1:04 PM · Restricted Project, Restricted Project
PiotrZSL added inline comments to D146288: clang-tidy: Detect use-after-move in CXXCtorInitializer.
Mon, Mar 20, 1:00 PM · Restricted Project, Restricted Project
PiotrZSL added inline comments to D146288: clang-tidy: Detect use-after-move in CXXCtorInitializer.
Mon, Mar 20, 8:36 AM · Restricted Project, Restricted Project
PiotrZSL added inline comments to D146288: clang-tidy: Detect use-after-move in CXXCtorInitializer.
Mon, Mar 20, 8:30 AM · Restricted Project, Restricted Project
PiotrZSL added inline comments to D145581: [clang-tidy] In C++17, callee is guaranteed to be sequenced before arguments..
Mon, Mar 20, 3:17 AM · Restricted Project, Restricted Project
PiotrZSL added a comment to D146396: [clang-tidy] Use checks dependences for Analyzer checks.

I have feeling that hidden checks that none other check depend on should be enabled by default.
Also I have feeling that those hidden checks shouldn't be visible to end user.
But need to confirm this first with Static Analyser developers.

Mon, Mar 20, 3:09 AM · Restricted Project, Restricted Project

Sun, Mar 19

PiotrZSL requested review of D146396: [clang-tidy] Use checks dependences for Analyzer checks.
Sun, Mar 19, 3:18 PM · Restricted Project, Restricted Project
PiotrZSL updated the diff for D146368: [clang-tidy] Add readability-reference-to-constructed-temporary check.

Review comment fixes

Sun, Mar 19, 8:50 AM · Restricted Project, Restricted Project
PiotrZSL updated the diff for D144522: [clang-tidy] Add readability-operators-representation check.

Update documentation, changed default check configuration.

Sun, Mar 19, 8:30 AM · Restricted Project, Restricted Project
PiotrZSL added a reviewer for D146368: [clang-tidy] Add readability-reference-to-constructed-temporary check: carlosgalvezp.
Sun, Mar 19, 4:33 AM · Restricted Project, Restricted Project
PiotrZSL planned changes to D144522: [clang-tidy] Add readability-operators-representation check.

Update documentation, and config examples, add "Traditional Tokens Representation" section.

Sun, Mar 19, 3:08 AM · Restricted Project, Restricted Project

Sat, Mar 18

PiotrZSL committed rGd4cb6c208231: [clang-tidy] readability-identifier-naming: fix hungarian enum prefix in C (authored by amurzeau).
[clang-tidy] readability-identifier-naming: fix hungarian enum prefix in C
Sat, Mar 18, 11:25 PM · Restricted Project, Restricted Project
PiotrZSL closed D144912: [clang-tidy] readability-identifier-naming: fix hungarian enum prefix in C.
Sat, Mar 18, 11:25 PM · Restricted Project, Restricted Project
PiotrZSL added a comment to D146368: [clang-tidy] Add readability-reference-to-constructed-temporary check.

There are 2 issues found in llvm repository:

  • llvm/lib/Target/AMDGPU/AMDGPULibFunc.cpp:721:22: warning: reference variable 'S' extends the lifetime of a just-constructed temporary object 'const StringRef', consider changing reference to value [readability-reference-to-constructed-temporary]
  • clang/lib/Sema/SemaChecking.cpp:10096:36: warning: reference variable 'AT2' extends the lifetime of a just-constructed temporary object 'const analyze_printf::ArgType', consider changing reference to value [readability-reference-to-constructed-temporary]
Sat, Mar 18, 1:56 PM · Restricted Project, Restricted Project
PiotrZSL requested review of D146368: [clang-tidy] Add readability-reference-to-constructed-temporary check.
Sat, Mar 18, 1:55 PM · Restricted Project, Restricted Project
PiotrZSL updated the diff for D145617: [clang-tidy] Add readability-avoid-unconditional-preprocessor-if check.

Change name of isStatic* to isImmutable*

Sat, Mar 18, 11:18 AM · Restricted Project, Restricted Project
PiotrZSL added inline comments to D145617: [clang-tidy] Add readability-avoid-unconditional-preprocessor-if check.
Sat, Mar 18, 10:47 AM · Restricted Project, Restricted Project
PiotrZSL updated the diff for D145617: [clang-tidy] Add readability-avoid-unconditional-preprocessor-if check.

Removed some whitespace & added tests

Sat, Mar 18, 10:47 AM · Restricted Project, Restricted Project
PiotrZSL added inline comments to D144522: [clang-tidy] Add readability-operators-representation check.
Sat, Mar 18, 10:46 AM · Restricted Project, Restricted Project
PiotrZSL committed rG3ed40ac90ce8: [clang-tidy] Fixed an issue in readability-identifier-naming not using options… (authored by njames93).
[clang-tidy] Fixed an issue in readability-identifier-naming not using options…
Sat, Mar 18, 8:59 AM · Restricted Project, Restricted Project
PiotrZSL closed D129070: [clang-tidy] Fixed an issue in readability-identifier-naming not using options specified..
Sat, Mar 18, 8:59 AM · Restricted Project, Restricted Project
PiotrZSL committed rG113f0190dd38: [clang-tidy] Fix minor bug in bugprone-too-small-loop-variable (authored by PiotrZSL).
[clang-tidy] Fix minor bug in bugprone-too-small-loop-variable
Sat, Mar 18, 4:28 AM · Restricted Project, Restricted Project
PiotrZSL closed D145958: [clang-tidy] Fix minor bug in bugprone-too-small-loop-variable.
Sat, Mar 18, 4:28 AM · Restricted Project, Restricted Project
PiotrZSL requested changes to D146288: clang-tidy: Detect use-after-move in CXXCtorInitializer.

Requesting changes due to lack of support for base class initializes & got some concerns related lambdas used in initializers.

Sat, Mar 18, 4:26 AM · Restricted Project, Restricted Project

Fri, Mar 17

PiotrZSL added a comment to D146288: clang-tidy: Detect use-after-move in CXXCtorInitializer.

I will check this more deeply during weekend.

Fri, Mar 17, 7:58 AM · Restricted Project, Restricted Project

Thu, Mar 16

PiotrZSL added a comment to D145906: [clang-tidy] Correctly handle evaluation order of designated initializers..

Regarding release-notes:
I would probably wrote something like "fixed handling for designated initializers", nonene will understand things like "sequence point".
If you decide to change this, the just commit this as an [NFC] without review.
And checks in this section should be in alphabetical order (so this one shouldn't be at the end), but that's a different story that can be corrected later for all those entrys.

Thu, Mar 16, 1:23 AM · Restricted Project, Restricted Project

Tue, Mar 14

PiotrZSL added a reviewer for D145865: [clang-tidy] Multiple fixes to bugprone-exception-escape: LegalizeAdulthood.
Tue, Mar 14, 12:35 PM · Restricted Project, Restricted Project
PiotrZSL added a reviewer for D145617: [clang-tidy] Add readability-avoid-unconditional-preprocessor-if check: LegalizeAdulthood.
Tue, Mar 14, 12:35 PM · Restricted Project, Restricted Project
PiotrZSL added a reviewer for D144828: [clang-tidy] Add misc-header-include-cycle check: LegalizeAdulthood.
Tue, Mar 14, 12:35 PM · Restricted Project, Restricted Project
PiotrZSL added a reviewer for D145958: [clang-tidy] Fix minor bug in bugprone-too-small-loop-variable: LegalizeAdulthood.
Tue, Mar 14, 12:35 PM · Restricted Project, Restricted Project
PiotrZSL added a reviewer for D144748: [clang-tidy] Add bugprone-empty-catch check: LegalizeAdulthood.
Tue, Mar 14, 12:34 PM · Restricted Project, Restricted Project
PiotrZSL added a reviewer for D144522: [clang-tidy] Add readability-operators-representation check: LegalizeAdulthood.
Tue, Mar 14, 12:34 PM · Restricted Project, Restricted Project
PiotrZSL added a reviewer for D144429: [clang-tidy] Add bugprone-chained-comparison check: LegalizeAdulthood.
Tue, Mar 14, 12:33 PM · Restricted Project, Restricted Project
PiotrZSL added a reviewer for D144347: [clang-tidy] Add readability-forward-usage check: LegalizeAdulthood.
Tue, Mar 14, 12:33 PM · Restricted Project, Restricted Project
PiotrZSL added a reviewer for D144135: [clang-tidy] Add performance-enum-size check: LegalizeAdulthood.
Tue, Mar 14, 12:33 PM · Restricted Project, Restricted Project
PiotrZSL added a reviewer for D144036: [clang-tidy] Add bugprone-enum-to-bool-conversion check: LegalizeAdulthood.
Tue, Mar 14, 12:32 PM · Restricted Project, Restricted Project
PiotrZSL accepted D145906: [clang-tidy] Correctly handle evaluation order of designated initializers..

Looks good to me, consider adding info to Release notes, that this check has been improved/fixed support for designated initializers.

Tue, Mar 14, 7:37 AM · Restricted Project, Restricted Project

Mon, Mar 13

PiotrZSL committed rG4e901cda725b: [clang-tidy] Support readability-redundant-string-cstr.StringParameterFunctions… (authored by mikecrowe).
[clang-tidy] Support readability-redundant-string-cstr.StringParameterFunctions…
Mon, Mar 13, 11:03 AM · Restricted Project, Restricted Project
PiotrZSL closed D145885: [clang-tidy] Support readability-redundant-string-cstr.StringParameterFunctions option.
Mon, Mar 13, 11:03 AM · Restricted Project, Restricted Project
PiotrZSL added inline comments to D145906: [clang-tidy] Correctly handle evaluation order of designated initializers..
Mon, Mar 13, 10:21 AM · Restricted Project, Restricted Project
PiotrZSL requested review of D145958: [clang-tidy] Fix minor bug in bugprone-too-small-loop-variable.
Mon, Mar 13, 10:07 AM · Restricted Project, Restricted Project
PiotrZSL added a comment to D142587: [clang-tidy] Improved too-small-loop-variable with bit-field support.

Thank you for information, I will look into this....
Indeed test for this scenario is missing.

Mon, Mar 13, 2:35 AM · Restricted Project, Restricted Project
PiotrZSL accepted D145885: [clang-tidy] Support readability-redundant-string-cstr.StringParameterFunctions option.

LGTM

Mon, Mar 13, 1:24 AM · Restricted Project, Restricted Project
PiotrZSL added inline comments to D145885: [clang-tidy] Support readability-redundant-string-cstr.StringParameterFunctions option.
Mon, Mar 13, 12:26 AM · Restricted Project, Restricted Project

Sun, Mar 12

PiotrZSL added a comment to D145856: [clang-tidy] Let misc-const-correctness detect auto local variables that can be made const.

Release notes:
./clang-tools-extra/docs/ReleaseNotes.rst

Sun, Mar 12, 4:18 PM · Restricted Project, Restricted Project
PiotrZSL committed rG57b78faa9eb0: [clang-tidy] Support std::format and std::print in readability-redundant-string… (authored by mikecrowe).
[clang-tidy] Support std::format and std::print in readability-redundant-string…
Sun, Mar 12, 2:43 PM · Restricted Project, Restricted Project
PiotrZSL closed D143342: [clang-tidy] Support std::format and std::print in readability-redundant-string-cstr.
Sun, Mar 12, 2:43 PM · Restricted Project, Restricted Project
PiotrZSL requested changes to D145885: [clang-tidy] Support readability-redundant-string-cstr.StringParameterFunctions option.

My only complain is documentation, changes in code and tests are correct.
Build failed mainly due to conflicts in previous change.
It should get green once prev patch will land, and this will be re-based.

Sun, Mar 12, 2:30 PM · Restricted Project, Restricted Project
PiotrZSL added a comment to D143342: [clang-tidy] Support std::format and std::print in readability-redundant-string-cstr.

You will need to rebase this, there are conflicts...

Sun, Mar 12, 2:21 PM · Restricted Project, Restricted Project
PiotrZSL added a comment to D143342: [clang-tidy] Support std::format and std::print in readability-redundant-string-cstr.

"The dummy implementations of std::format and std::print require C++20,
so it's easier to test them in a separate
redundant-string-cstr-format.cpp check file. This also requires a small
improvement to the basic_string_view implementation in the <string>
dummy header.

Sun, Mar 12, 2:10 PM · Restricted Project, Restricted Project
PiotrZSL added inline comments to D145885: [clang-tidy] Support readability-redundant-string-cstr.StringParameterFunctions option.
Sun, Mar 12, 2:06 PM · Restricted Project, Restricted Project
PiotrZSL accepted D143342: [clang-tidy] Support std::format and std::print in readability-redundant-string-cstr.

Correct commit message and this could land.

Sun, Mar 12, 1:50 PM · Restricted Project, Restricted Project
PiotrZSL added a comment to D145865: [clang-tidy] Multiple fixes to bugprone-exception-escape.

This change obsoletes D115118 and D134588.

Sun, Mar 12, 1:14 PM · Restricted Project, Restricted Project
PiotrZSL committed rG55f8a287e9e8: [clang-tidy][NFC] Update docs/clang-tidy/checks/list.rst (authored by PiotrZSL).
[clang-tidy][NFC] Update docs/clang-tidy/checks/list.rst
Sun, Mar 12, 1:02 PM · Restricted Project, Restricted Project
PiotrZSL committed rGd5fd6a376a7c: [clang-tidy] Fix rename_check.py (authored by PiotrZSL).
[clang-tidy] Fix rename_check.py
Sun, Mar 12, 12:58 PM · Restricted Project, Restricted Project
PiotrZSL committed rGc491c9170239: [clang-tidy] Implement CppCoreGuideline F.18 (authored by ccotter).
[clang-tidy] Implement CppCoreGuideline F.18
Sun, Mar 12, 10:27 AM · Restricted Project, Restricted Project
PiotrZSL closed D141569: [clang-tidy] Implement CppCoreGuideline F.18.
Sun, Mar 12, 10:27 AM · Restricted Project, Restricted Project
PiotrZSL updated the diff for D141569: [clang-tidy] Implement CppCoreGuideline F.18.

Rebase + Fix order of checks in ReleaseNotes

Sun, Mar 12, 10:27 AM · Restricted Project, Restricted Project
PiotrZSL added inline comments to D143342: [clang-tidy] Support std::format and std::print in readability-redundant-string-cstr.
Sun, Mar 12, 10:23 AM · Restricted Project, Restricted Project
PiotrZSL updated the diff for D145865: [clang-tidy] Multiple fixes to bugprone-exception-escape.

Update documentation

Sun, Mar 12, 8:53 AM · Restricted Project, Restricted Project
PiotrZSL updated the diff for D145865: [clang-tidy] Multiple fixes to bugprone-exception-escape.

Review fixes

Sun, Mar 12, 8:48 AM · Restricted Project, Restricted Project
PiotrZSL added a reviewer for D129070: [clang-tidy] Fixed an issue in readability-identifier-naming not using options specified.: carlosgalvezp.
Sun, Mar 12, 7:09 AM · Restricted Project, Restricted Project
PiotrZSL updated the diff for D129070: [clang-tidy] Fixed an issue in readability-identifier-naming not using options specified..

Rebase on top of main + Change llvm::Optional into std::optional

Sun, Mar 12, 7:06 AM · Restricted Project, Restricted Project
PiotrZSL added a comment to D141569: [clang-tidy] Implement CppCoreGuideline F.18.

@ccotter Do we commit this, or you plan to still change something here ?

Sun, Mar 12, 6:43 AM · Restricted Project, Restricted Project
PiotrZSL added a reviewer for D145865: [clang-tidy] Multiple fixes to bugprone-exception-escape: carlosgalvezp.
Sun, Mar 12, 6:39 AM · Restricted Project, Restricted Project
PiotrZSL committed rGc4918cbf3ba3: [clang-tidy] Provide default template arguments in <string> (authored by mikecrowe).
[clang-tidy] Provide default template arguments in <string>
Sun, Mar 12, 6:35 AM · Restricted Project, Restricted Project
PiotrZSL committed rG0a93abd97658: [clang-tidy] Make readability-container-size-empty check using <string> header (authored by mikecrowe).
[clang-tidy] Make readability-container-size-empty check using <string> header
Sun, Mar 12, 6:35 AM · Restricted Project, Restricted Project
PiotrZSL committed rGf9dc14cf1f7e: [clang-tidy] Make readability-string-compare check use <string> header (authored by mikecrowe).
[clang-tidy] Make readability-string-compare check use <string> header
Sun, Mar 12, 6:35 AM · Restricted Project, Restricted Project
PiotrZSL closed D145724: [clang-tidy] Provide default template arguments in <string>.
Sun, Mar 12, 6:35 AM · Restricted Project, Restricted Project
PiotrZSL closed D145313: [clang-tidy] Make readability-container-size-empty check using <string> header.
Sun, Mar 12, 6:35 AM · Restricted Project, Restricted Project
PiotrZSL closed D145312: [clang-tidy] Make readability-string-compare check use <string> header.
Sun, Mar 12, 6:35 AM · Restricted Project, Restricted Project
PiotrZSL added a comment to D145312: [clang-tidy] Make readability-string-compare check use <string> header.
In D145312#4187195, @carlosgalvezp wrote:

@PiotrZSL I believe you have landed some patches of this chain. Would you mind sharing how you do it? I'm not an expert in Phabricator and simply doing arc patch D145312 leads to cherry-pick conflicts, and when I solve them I don't end up having this patch as HEAD. With this knowledge I will be able to help out closing these patches!

Sun, Mar 12, 6:28 AM · Restricted Project, Restricted Project
Herald added a reviewer for D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--): njames93.

This need to be rebase due to conflict to land.

Sun, Mar 12, 4:31 AM · Restricted Project, Restricted Project, Restricted Project
PiotrZSL requested review of D145865: [clang-tidy] Multiple fixes to bugprone-exception-escape.
Sun, Mar 12, 4:09 AM · Restricted Project, Restricted Project
PiotrZSL requested changes to D145856: [clang-tidy] Let misc-const-correctness detect auto local variables that can be made const.
  • Failed tests
  • Missing tests for this change
  • Missing configuration option for this change (changing default behavior)
  • Missing release notes
  • Missing documentation update
  • auto& , auto&&, auto* still wont be ignored (that's also auto type).
Sun, Mar 12, 12:21 AM · Restricted Project, Restricted Project

Sat, Mar 11

PiotrZSL added inline comments to D143342: [clang-tidy] Support std::format and std::print in readability-redundant-string-cstr.
Sat, Mar 11, 1:58 PM · Restricted Project, Restricted Project
PiotrZSL added a comment to D143342: [clang-tidy] Support std::format and std::print in readability-redundant-string-cstr.

"Do you think that the change can land like in its current state first? Or would you prefer that the configuration option is added at the same time?"

Sat, Mar 11, 10:22 AM · Restricted Project, Restricted Project
PiotrZSL committed rG988355808efc: [clang-tidy][NFC] Make abseil-redundant-strcat-calls checker use <string> header (authored by mikecrowe).
[clang-tidy][NFC] Make abseil-redundant-strcat-calls checker use <string> header
Sat, Mar 11, 9:49 AM · Restricted Project, Restricted Project
PiotrZSL closed D145311: [clang-tidy][NFC] Make abseil-redundant-strcat-calls checker use <string> header.
Sat, Mar 11, 9:49 AM · Restricted Project, Restricted Project
PiotrZSL updated the summary of D145311: [clang-tidy][NFC] Make abseil-redundant-strcat-calls checker use <string> header.
Sat, Mar 11, 9:45 AM · Restricted Project, Restricted Project
PiotrZSL retitled D145311: [clang-tidy][NFC] Make abseil-redundant-strcat-calls checker use <string> header from [clang-tidy] Make abseil-redundant-strcat-calls checker use <string> header to [clang-tidy][NFC] Make abseil-redundant-strcat-calls checker use <string> header.
Sat, Mar 11, 9:44 AM · Restricted Project, Restricted Project
PiotrZSL committed rGf1e2469edcfc: [clang-tidy] Fix false-positive in cppcoreguidelines-slicing (authored by PiotrZSL).
[clang-tidy] Fix false-positive in cppcoreguidelines-slicing
Sat, Mar 11, 9:38 AM · Restricted Project, Restricted Project
PiotrZSL closed D144206: [clang-tidy] Fix false-positive in cppcoreguidelines-slicing.
Sat, Mar 11, 9:37 AM · Restricted Project, Restricted Project
PiotrZSL added a comment to D144206: [clang-tidy] Fix false-positive in cppcoreguidelines-slicing.
Sat, Mar 11, 9:10 AM · Restricted Project, Restricted Project
PiotrZSL updated the diff for D144206: [clang-tidy] Fix false-positive in cppcoreguidelines-slicing.

Review comments fix

Sat, Mar 11, 9:10 AM · Restricted Project, Restricted Project