Page MenuHomePhabricator

ilya-biryukov (Ilya Biryukov)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 6 2017, 1:42 AM (106 w, 1 d)

Recent Activity

Tue, Apr 16

ilya-biryukov added a comment to D60510: [ADT] Fix template parameter names of llvm::{upper|lower}_bound.

Sure, happy to add some basic tests.
Unfortunately did not get to this today and I'm on vacation until next Tuesday. Will get back to this after I'm back.

Tue, Apr 16, 12:18 PM · Restricted Project
ilya-biryukov updated the diff for D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library.
  • Simplify rawByExpanded by using a helper function.
Tue, Apr 16, 11:55 AM · Restricted Project
ilya-biryukov added inline comments to D60779: [ADT] llvm::bsearch, binary search for mere mortals.
Tue, Apr 16, 9:20 AM · Restricted Project
ilya-biryukov added inline comments to D59885: [Lex] Allow to consume tokens while preprocessing.
Tue, Apr 16, 7:03 AM · Restricted Project
ilya-biryukov added a comment to D60408: [LibTooling] Extend Transformer to support multiple simultaneous changes..

Not sure if you want to land this before or after stencil. This seems useful even without the latter.

Tue, Apr 16, 6:48 AM · Restricted Project, Restricted Project
ilya-biryukov accepted D60408: [LibTooling] Extend Transformer to support multiple simultaneous changes..

LGTM!

Tue, Apr 16, 6:47 AM · Restricted Project, Restricted Project
ilya-biryukov added a comment to D60510: [ADT] Fix template parameter names of llvm::{upper|lower}_bound.

Might've made sense to separate the NFC renaming from the perfect forwarding change (& the perfect forwarding change could potentially have some matching test coverage?)

I agree, sorry about mashing them in together. That said, I was confident this wouldn't cause any trouble in practice.
What kinds of tests are you thinking about? Checking that llvm::lower_bound works on non-copyable types?

Tue, Apr 16, 4:57 AM · Restricted Project
ilya-biryukov added a comment to D60408: [LibTooling] Extend Transformer to support multiple simultaneous changes..

Thanks for the update, looks good! Just a few nits from my side.

Tue, Apr 16, 4:44 AM · Restricted Project, Restricted Project
ilya-biryukov added inline comments to D59302: [clangd] Surface diagnostics from headers inside main file.
Tue, Apr 16, 2:01 AM · Restricted Project
ilya-biryukov added a comment to D59302: [clangd] Surface diagnostics from headers inside main file.

Sorry, lost this revision. Looking now

Tue, Apr 16, 1:36 AM · Restricted Project

Mon, Apr 15

ilya-biryukov added a comment to D60408: [LibTooling] Extend Transformer to support multiple simultaneous changes..

A few quick responses, will take a closer look again tomorrow.

Mon, Apr 15, 10:25 AM · Restricted Project, Restricted Project
ilya-biryukov committed rG70921d4a86e0: Revert r358337: "[CommandLineParser] Add DefaultOption flag" (authored by ilya-biryukov).
Revert r358337: "[CommandLineParser] Add DefaultOption flag"
Mon, Apr 15, 7:46 AM
ilya-biryukov accepted D60607: [clangd] Wait for compile command in ASTWorker instead of ClangdServer.

LGTM! See the NITs, specifically about runAddDocument - those definitely look worth fixing.

Mon, Apr 15, 5:19 AM · Restricted Project
ilya-biryukov added inline comments to D60408: [LibTooling] Extend Transformer to support multiple simultaneous changes..
Mon, Apr 15, 5:07 AM · Restricted Project, Restricted Project
ilya-biryukov added a comment to D60607: [clangd] Wait for compile command in ASTWorker instead of ClangdServer.

Thanks, the change LG now. Only nits from my side!

Mon, Apr 15, 3:12 AM · Restricted Project

Fri, Apr 12

ilya-biryukov added inline comments to D60607: [clangd] Wait for compile command in ASTWorker instead of ClangdServer.
Fri, Apr 12, 10:45 AM · Restricted Project
ilya-biryukov added inline comments to D60607: [clangd] Wait for compile command in ASTWorker instead of ClangdServer.
Fri, Apr 12, 9:59 AM · Restricted Project
ilya-biryukov added a comment to D60408: [LibTooling] Extend Transformer to support multiple simultaneous changes..

I've done that as far as I can tell. Please let me know if I've missed anything.

Many thanks!

Fri, Apr 12, 9:51 AM · Restricted Project, Restricted Project
ilya-biryukov added inline comments to D60408: [LibTooling] Extend Transformer to support multiple simultaneous changes..
Fri, Apr 12, 9:51 AM · Restricted Project, Restricted Project
ilya-biryukov added inline comments to D60607: [clangd] Wait for compile command in ASTWorker instead of ClangdServer.
Fri, Apr 12, 7:12 AM · Restricted Project
ilya-biryukov added a comment to D60607: [clangd] Wait for compile command in ASTWorker instead of ClangdServer.

This is long overdue

Fri, Apr 12, 5:05 AM · Restricted Project
ilya-biryukov accepted D60560: [clangd] Enable clang-tidy by default..

Yay! LGTM

Fri, Apr 12, 2:34 AM · Restricted Project, Restricted Project
ilya-biryukov accepted D59640: [clangd] Add TemplateArgumentList into Symbol.

LGTM

Fri, Apr 12, 2:29 AM · Restricted Project, Restricted Project
ilya-biryukov added a comment to D60408: [LibTooling] Extend Transformer to support multiple simultaneous changes..

Sorry for the delay.
There seem to be a few changes that are unrelated to the actual patch. Could we separate various non-functional changes (moving code around, etc.) into a separate change to keep the diff for this one minimal?

Fri, Apr 12, 2:25 AM · Restricted Project, Restricted Project
ilya-biryukov added inline comments to D59640: [clangd] Add TemplateArgumentList into Symbol.
Fri, Apr 12, 2:11 AM · Restricted Project, Restricted Project
ilya-biryukov added inline comments to D59640: [clangd] Add TemplateArgumentList into Symbol.
Fri, Apr 12, 1:25 AM · Restricted Project, Restricted Project
ilya-biryukov accepted D59641: [clangd] Show template argument list in workspacesymbols and documentsymbols responses.
Fri, Apr 12, 1:23 AM · Restricted Project, Restricted Project

Thu, Apr 11

ilya-biryukov added a comment to D59605: [clangd] Introduce background-indexer.

To make it clear, I think the question is not just "which part of functionality is missing in BackgroundIndex", it's rather "which part of BackgroundIndex we don't need".

Thu, Apr 11, 9:16 AM · Restricted Project
ilya-biryukov updated subscribers of D59605: [clangd] Introduce background-indexer.

To reiterate the offline discussion: the tool seems useful to me, but it would be best to keep the client code simpler, it's currently fighting with BackgroundIndex because it's trying to hijack some of its functionality.
More specifically, I propose to add a function to BackgroundIndex.h that would be a one-shot update of the index, the client code would become significantly simpler and we would have more flexibility in how we move code around in BackgroundIndex.cpp to actually make this happen.

Thu, Apr 11, 9:13 AM · Restricted Project
ilya-biryukov updated the diff for D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library.
  • Store a source manager in a token buffer
Thu, Apr 11, 7:43 AM · Restricted Project
ilya-biryukov added a comment to D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library.

The new version address most of the comments, there are just a few left in the code doing the mapping from Dmitri, I'll look into simplifying and removing the possibly redundant checks.
Please take a look at this version, this is very close to the final state.

Thu, Apr 11, 7:30 AM · Restricted Project
ilya-biryukov updated the diff for D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library.
  • Fix header comments.
Thu, Apr 11, 7:30 AM · Restricted Project
ilya-biryukov updated the diff for D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library.
  • Remove a spamy debug tracing output.
  • Less debug output, move stuff around, more comments.
  • Add methods that map expanded tokens to raw tokens.
  • Rename toOffsetsRange.
  • Remove default ctor of Token.
  • Introduce a struct for storing FileID and a pair of offsets.
  • Update comments.
  • Add a test for macro expansion at the end of the file.
  • Misc fixes.
Thu, Apr 11, 7:24 AM · Restricted Project
ilya-biryukov committed rG6ef53b3bf2fc: [ADT] Fix template parameter names of llvm::{upper|lower}_bound (authored by ilya-biryukov).
[ADT] Fix template parameter names of llvm::{upper|lower}_bound
Thu, Apr 11, 2:00 AM
ilya-biryukov closed D60510: [ADT] Fix template parameter names of llvm::{upper|lower}_bound.
Thu, Apr 11, 2:00 AM · Restricted Project
ilya-biryukov added a comment to D59641: [clangd] Show template argument list in workspacesymbols and documentsymbols responses.

LG, just have a simple clarifying question.

Thu, Apr 11, 2:00 AM · Restricted Project, Restricted Project

Wed, Apr 10

ilya-biryukov updated the diff for D60510: [ADT] Fix template parameter names of llvm::{upper|lower}_bound.
  • clang-format
Wed, Apr 10, 6:34 AM · Restricted Project
ilya-biryukov updated subscribers of D60510: [ADT] Fix template parameter names of llvm::{upper|lower}_bound.
Wed, Apr 10, 6:31 AM · Restricted Project
ilya-biryukov created D60510: [ADT] Fix template parameter names of llvm::{upper|lower}_bound.
Wed, Apr 10, 6:30 AM · Restricted Project
ilya-biryukov added inline comments to D60267: [clangd] Support relatedInformation in diagnostics..
Wed, Apr 10, 3:34 AM · Restricted Project, Restricted Project
ilya-biryukov added inline comments to D60267: [clangd] Support relatedInformation in diagnostics..
Wed, Apr 10, 3:22 AM · Restricted Project, Restricted Project
ilya-biryukov added inline comments to D60267: [clangd] Support relatedInformation in diagnostics..
Wed, Apr 10, 3:20 AM · Restricted Project, Restricted Project

Sun, Apr 7

ilya-biryukov added a comment to D59605: [clangd] Introduce background-indexer.

I would propose to change the name of the tool.
The "background" part only makes sense in the context of running inside clangd, the index stored on disk is not "background" in any manner.
I'd go with something like build-clangd-index (the best option is probably clangd-indexer, but it's is already taken and we don't want to confuse the two tools).

Sun, Apr 7, 11:35 PM · Restricted Project
ilya-biryukov added inline comments to D59302: [clangd] Surface diagnostics from headers inside main file.
Sun, Apr 7, 11:24 PM · Restricted Project

Fri, Apr 5

ilya-biryukov updated the diff for D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library.

Changes:

  • Add multi-file support, record a single expanded stream and per-file-id raw token streams and mappings.
  • Rename MacroInvocation to TokenBuffer::Mapping, make it private.
  • Simplify TokenCollector, let preprocessor handle some more stuff.
Fri, Apr 5, 9:36 AM · Restricted Project
ilya-biryukov updated the diff for D59885: [Lex] Allow to consume tokens while preprocessing.

Pass an enum indicating where the token comes from.
The enum is ad-hoc at the moment, will require some thought to turn
it into a reasonable abstraction.

Fri, Apr 5, 9:32 AM · Restricted Project
ilya-biryukov accepted D60194: [Tooling] add a Heuristic field indicating that a CompileCommand was guessed..

LGTM, Manuel does not mind having this and the string heuristic does look like the easiest approach to convey this information in the API.

Fri, Apr 5, 7:54 AM · Restricted Project, Restricted Project
ilya-biryukov accepted D59376: [LibTooling] Add Transformer, a library for source-to-source transformations..

One more LGTM.

Fri, Apr 5, 2:42 AM · Restricted Project, Restricted Project
ilya-biryukov accepted D60269: [LibTooling] Add "SourceCode" library for functions relating to source-code manipulation..

Nice! A more specific name and a more specific library.
LGTM!

Fri, Apr 5, 2:42 AM · Restricted Project, Restricted Project

Thu, Apr 4

ilya-biryukov updated subscribers of D59376: [LibTooling] Add Transformer, a library for source-to-source transformations..

Per @ioeric's suggestion: why not move the helper into Tooling/Refactoring/ExtendedRange.h?
If it's in ToolingRefactoring, both stencil and transformer can access it.

Thu, Apr 4, 6:15 AM · Restricted Project, Restricted Project
ilya-biryukov added a comment to D59376: [LibTooling] Add Transformer, a library for source-to-source transformations..

I propose that I create a new library in Core with getExtendedRange() and remove it from FixIt. The other utility functions that I need will also go there. We can separately investigate moving the remaining pieces of FixIt into Core.

Thu, Apr 4, 6:06 AM · Restricted Project, Restricted Project
ilya-biryukov accepted D60258: [CodeComplete] Fix crash when completing ObjC block parameter with a broken type.

LGTM

Thu, Apr 4, 4:29 AM · Restricted Project, Restricted Project
ilya-biryukov added a comment to D60194: [Tooling] add a Heuristic field indicating that a CompileCommand was guessed..

I'll leave the LGTM to Manuel. I don't have a strong opinion here, but here are some thoughts.

Thu, Apr 4, 2:54 AM · Restricted Project, Restricted Project
ilya-biryukov added a comment to D59811: [clangd] Add fallback mode for code completion when compile command or preamble is not ready..

Sam, thanks for taking a look and the useful comments!

Thu, Apr 4, 2:45 AM · Restricted Project, Restricted Project
ilya-biryukov added a comment to D59376: [LibTooling] Add Transformer, a library for source-to-source transformations..

Keeping it only in the cpp file also LG if we don't plan to have other usages for now, but please remove the version from FixIt.h

Thu, Apr 4, 2:26 AM · Restricted Project, Restricted Project
ilya-biryukov added a comment to D59376: [LibTooling] Add Transformer, a library for source-to-source transformations..

Given that we don't any usages of getExtendedRange, could you remove it from the Fixit.h and move to a header somewhere in the clangToolingRefactoring (e.g. into Transformer.h itself)?

Thu, Apr 4, 2:26 AM · Restricted Project, Restricted Project

Wed, Apr 3

ilya-biryukov accepted D59376: [LibTooling] Add Transformer, a library for source-to-source transformations..

LGTM with the new changes. Specifying the clang::Expr type explicitly when calling change looks a bit less clear than the original approach, but also looks pretty clear to me.

Wed, Apr 3, 12:56 AM · Restricted Project, Restricted Project
ilya-biryukov committed rGd9c24dca73d1: [clangd] Return clangd::TextEdit in ClangdServer::rename. NFC (authored by ilya-biryukov).
[clangd] Return clangd::TextEdit in ClangdServer::rename. NFC
Wed, Apr 3, 12:19 AM

Tue, Apr 2

ilya-biryukov created D60179: [clangd] Return clangd::TextEdit in ClangdServer::rename. NFC.
Tue, Apr 2, 11:02 PM · Restricted Project, Restricted Project
ilya-biryukov added a comment to D59811: [clangd] Add fallback mode for code completion when compile command or preamble is not ready..

Leaving a few first comments, have to run.
Will take another look later, sorry about the delay today (also feel free to add more reviewers in case this is urgent).

Tue, Apr 2, 6:29 AM · Restricted Project, Restricted Project
ilya-biryukov added a comment to D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library.

Will address the rest of the comments later, answering a few questions that popped up first.

Tue, Apr 2, 1:45 AM · Restricted Project
ilya-biryukov committed rGbea52e5289b9: [clangd] Use capacity() instead of size() in RefSlab::bytes() (authored by ilya-biryukov).
[clangd] Use capacity() instead of size() in RefSlab::bytes()
Tue, Apr 2, 1:25 AM
ilya-biryukov accepted D59376: [LibTooling] Add Transformer, a library for source-to-source transformations..

Looks great, thanks!

Tue, Apr 2, 1:00 AM · Restricted Project, Restricted Project

Mon, Apr 1

ilya-biryukov added a comment to D59376: [LibTooling] Add Transformer, a library for source-to-source transformations..

Looks neat, thanks!
A final set of NITs from my side, I don't think any of the comments have to do with the actual design of the library, so expect LGTM in the next round.

Mon, Apr 1, 10:41 AM · Restricted Project, Restricted Project
ilya-biryukov added a comment to D60040: [clangd] Use capacity() instead of size() in RefSlab::bytes().

I'll take the courtesy and land it since @gribozavr is OOO today.

Mon, Apr 1, 2:39 AM · Restricted Project, Restricted Project

Fri, Mar 29

ilya-biryukov added a reviewer for D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library: sammccall.
Fri, Mar 29, 9:07 AM · Restricted Project
ilya-biryukov added a comment to D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library.

Still have a few comments to address in TokenCollector and wrt to naming. But apart from this revision is ready for another round.

Fri, Mar 29, 8:57 AM · Restricted Project
ilya-biryukov updated the diff for D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library.
  • Rename various things.
  • Update doc comments.
  • Search tokens in the tests by spelling, not by kind.
  • Add more tests.
  • Fix typos.
  • Address other comments.
Fri, Mar 29, 8:56 AM · Restricted Project
ilya-biryukov added a comment to D59329: [LibTooling] Add NodeId, a strong type for AST-matcher node identifiers..

Could you provide the rationale for having NodeID vs just using strings for the binds?
Is this just a more type-safe way to do the same thing or is that actually required to solve a particular problem?

Fri, Mar 29, 7:05 AM · Restricted Project
ilya-biryukov updated subscribers of D59329: [LibTooling] Add NodeId, a strong type for AST-matcher node identifiers..
Fri, Mar 29, 6:30 AM · Restricted Project
ilya-biryukov added a comment to D59376: [LibTooling] Add Transformer, a library for source-to-source transformations..

The only real question I have is about returning an error vs an empty transformation in of macros.
The rest are just NITs.

Fri, Mar 29, 6:00 AM · Restricted Project, Restricted Project
ilya-biryukov added a comment to D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library.

A few naming alternatives, will update the review after addressing other comments.

Fri, Mar 29, 1:57 AM · Restricted Project

Thu, Mar 28

ilya-biryukov added a comment to D59814: [Testing] Move clangd::Annotations to llvm testing support.

I've added a FIXME to the class.
Also want to add some basic tests before landing this.

Thu, Mar 28, 10:13 AM · Restricted Project, Restricted Project
ilya-biryukov updated the diff for D59814: [Testing] Move clangd::Annotations to llvm testing support.
  • Move Range into the body of Annotations
  • Use triple-slash comments
  • Added a FIXME that we might want to change the syntax
  • Move the doc comment to the class
Thu, Mar 28, 10:13 AM · Restricted Project, Restricted Project
ilya-biryukov updated the diff for D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library.
  • s/macroMacroInvocation/something else...
Thu, Mar 28, 9:47 AM · Restricted Project
ilya-biryukov updated the diff for D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library.
  • Rename macro expansion to macro invocation everywhere
  • Tweak comments
Thu, Mar 28, 9:47 AM · Restricted Project
ilya-biryukov accepted D59927: [clangd] Support UTF-32 (i.e. codepoint) offsets..

LGTM

Thu, Mar 28, 5:34 AM · Restricted Project, Restricted Project
ilya-biryukov added a reviewer for D59927: [clangd] Support UTF-32 (i.e. codepoint) offsets.: gribozavr.

NIT: maybe remove parentheses from the change description, they seem to only add noise.
Adding @gribozavr who definitely knows more about Unicode :-)

Thu, Mar 28, 5:26 AM · Restricted Project, Restricted Project
ilya-biryukov added a comment to D59811: [clangd] Add fallback mode for code completion when compile command or preamble is not ready..

I think this option should be configurable (and off by default) for the transition period. A few reasons to do so:

  • Before we have an actual implementation of fallback completions, the current behavior (waiting for the first preamble) actually seems like a better experience than returning empty results.
  • Some clients do this kind of fallback on their own (e.g. VSCode), so until we can provide actually semantically interesting results (anything more than identifier-based really, e.g. keyword completions) we would be better off keeping it off.
  • We can still test it if it's off by flipping the corresponding flag in the test code.
  • Would make rollout easier (clients can flip the flag back and forth and make sure it does not break stuff for them)
Thu, Mar 28, 3:16 AM · Restricted Project, Restricted Project

Wed, Mar 27

ilya-biryukov added a comment to D59376: [LibTooling] Add Transformer, a library for source-to-source transformations..

Mostly nits and small API questions form my side.
This looks very good overall! I'm planning to take a closer look at the handling of macros and various AST nodes in more detail this week, but the approach looks solid from a higher level.

Wed, Mar 27, 12:19 PM · Restricted Project, Restricted Project
ilya-biryukov added inline comments to D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library.
Wed, Mar 27, 9:55 AM · Restricted Project
ilya-biryukov added inline comments to D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library.
Wed, Mar 27, 9:49 AM · Restricted Project
ilya-biryukov added a comment to D59885: [Lex] Allow to consume tokens while preprocessing.

I'm happy to assess the performance costs of this change if needed (the function is obviously on the hot path), but I hope this won't add any significant performance costs.
Also happy to consider alternative approaches to collect the tokens when preprocessing, the current implementation is complicated (search for 'TokenCollector' in D59887) and my intuition is that moving parts of it to the preprocessor should simplify things considerably.

Wed, Mar 27, 9:28 AM · Restricted Project
ilya-biryukov added a parent revision for D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library: D59814: [Testing] Move clangd::Annotations to llvm testing support.
Wed, Mar 27, 9:27 AM · Restricted Project
ilya-biryukov added a child revision for D59814: [Testing] Move clangd::Annotations to llvm testing support: D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library.
Wed, Mar 27, 9:27 AM · Restricted Project, Restricted Project
ilya-biryukov removed a child revision for D59814: [Testing] Move clangd::Annotations to llvm testing support: D59885: [Lex] Allow to consume tokens while preprocessing.
Wed, Mar 27, 9:27 AM · Restricted Project, Restricted Project
ilya-biryukov added a parent revision for D59885: [Lex] Allow to consume tokens while preprocessing: D59814: [Testing] Move clangd::Annotations to llvm testing support.
Wed, Mar 27, 9:27 AM · Restricted Project
ilya-biryukov removed a parent revision for D59885: [Lex] Allow to consume tokens while preprocessing: D59814: [Testing] Move clangd::Annotations to llvm testing support.
Wed, Mar 27, 9:27 AM · Restricted Project
ilya-biryukov added a child revision for D59814: [Testing] Move clangd::Annotations to llvm testing support: D59885: [Lex] Allow to consume tokens while preprocessing.
Wed, Mar 27, 9:27 AM · Restricted Project, Restricted Project
ilya-biryukov added a parent revision for D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library: D59885: [Lex] Allow to consume tokens while preprocessing.
Wed, Mar 27, 9:27 AM · Restricted Project
ilya-biryukov added a child revision for D59885: [Lex] Allow to consume tokens while preprocessing: D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library.
Wed, Mar 27, 9:27 AM · Restricted Project
ilya-biryukov created D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library.
Wed, Mar 27, 9:23 AM · Restricted Project
ilya-biryukov created D59885: [Lex] Allow to consume tokens while preprocessing.
Wed, Mar 27, 9:20 AM · Restricted Project
ilya-biryukov added a reviewer for D59814: [Testing] Move clangd::Annotations to llvm testing support: sammccall.
Wed, Mar 27, 7:07 AM · Restricted Project, Restricted Project
ilya-biryukov accepted D59817: [clangd] Add activate command to the vscode extension..

LGTM! Thanks!

Wed, Mar 27, 6:22 AM · Restricted Project, Restricted Project

Tue, Mar 26

ilya-biryukov added a comment to D59814: [Testing] Move clangd::Annotations to llvm testing support.

Seeking feedback for this change, mostly interested if this a good place for test helpers like this?
I'm planning to author more tests in clangTooling using this soon, so moving it somewhere clang-specific is an option too.

Tue, Mar 26, 4:21 AM · Restricted Project, Restricted Project
ilya-biryukov created D59814: [Testing] Move clangd::Annotations to llvm testing support.
Tue, Mar 26, 4:17 AM · Restricted Project, Restricted Project
ilya-biryukov added inline comments to D59376: [LibTooling] Add Transformer, a library for source-to-source transformations..
Tue, Mar 26, 2:33 AM · Restricted Project, Restricted Project

Mon, Mar 25

ilya-biryukov committed rGec5dbf5a7b75: [clangd] Add .cu files to VSCode extension (authored by ilya-biryukov).
[clangd] Add .cu files to VSCode extension
Mon, Mar 25, 9:19 AM
ilya-biryukov updated the diff for D59759: [clangd] Add .cu files to VSCode extension.
  • Added a comments about CUDA files
Mon, Mar 25, 8:02 AM · Restricted Project