Page MenuHomePhabricator

ilya-biryukov (Ilya Biryukov)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Apr 6 2017, 1:42 AM (272 w, 6 d)
Roles
Administrator

Recent Activity

Mon, Jun 27

ilya-biryukov added a comment to D128621: [clangd] Do not try to use $0 as a placeholder in completion snippets.

My 2 cents here. We should probably try hard to keep the cursor inside braces/parentheses for those patterns.
Having

namespace foo {
  decls
}^ <- cursor here

hurts UX. It would be nice to get the old behavior back somehow.
I still have hopes for the VSCode discussion, maybe they can provide a workaround/willing to change their behavior.
@kadircet also suggested trying something like ${2:decls}$0. Could you check if that works in VSCode?

Mon, Jun 27, 3:22 AM · Restricted Project, Restricted Project
ilya-biryukov added inline comments to D128411: [syntax] Introduce a BaseToken class..
Mon, Jun 27, 2:40 AM · Restricted Project, Restricted Project
ilya-biryukov added inline comments to D128411: [syntax] Introduce a BaseToken class..
Mon, Jun 27, 1:40 AM · Restricted Project, Restricted Project

Fri, Jun 24

ilya-biryukov added inline comments to D128411: [syntax] Introduce a BaseToken class..
Fri, Jun 24, 6:15 AM · Restricted Project, Restricted Project
ilya-biryukov added inline comments to D128411: [syntax] Introduce a BaseToken class..
Fri, Jun 24, 6:10 AM · Restricted Project, Restricted Project

Thu, Jun 23

ilya-biryukov committed rG342e64979afe: [Sema] Fix assertion failure when instantiating requires expression (authored by ilya-biryukov).
[Sema] Fix assertion failure when instantiating requires expression
Thu, Jun 23, 7:21 AM · Restricted Project, Restricted Project
ilya-biryukov closed D127487: [Sema] Fix assertion failure when instantiating requires expression.
Thu, Jun 23, 7:20 AM · Restricted Project, Restricted Project

Wed, Jun 22

ilya-biryukov added inline comments to D127487: [Sema] Fix assertion failure when instantiating requires expression.
Wed, Jun 22, 8:59 AM · Restricted Project, Restricted Project
ilya-biryukov added a comment to D127487: [Sema] Fix assertion failure when instantiating requires expression.

@erichkeane could you take another look at this?

Wed, Jun 22, 4:56 AM · Restricted Project, Restricted Project
ilya-biryukov updated the diff for D127487: [Sema] Fix assertion failure when instantiating requires expression.
  • Update test, check error messages
Wed, Jun 22, 4:52 AM · Restricted Project, Restricted Project

Wed, Jun 15

ilya-biryukov accepted D127832: [clangd] Always desugar type aliases in hover.

LGTM. Please take a look the NIT about landing this as two commits.

Wed, Jun 15, 3:57 AM · Restricted Project, Restricted Project
ilya-biryukov committed rG374f938fe8f2: [libcxx] Fix allocator<void>::pointer in C++20 with removed members (authored by ilya-biryukov).
[libcxx] Fix allocator<void>::pointer in C++20 with removed members
Wed, Jun 15, 1:56 AM · Restricted Project, Restricted Project
ilya-biryukov closed D126210: [libcxx] Fix allocator<void>::pointer in C++20 with removed members.
Wed, Jun 15, 1:56 AM · Restricted Project, Restricted Project
ilya-biryukov updated the diff for D126210: [libcxx] Fix allocator<void>::pointer in C++20 with removed members.
  • Fix typos and apply suggestions in documentation and comments
Wed, Jun 15, 1:52 AM · Restricted Project, Restricted Project
ilya-biryukov updated the diff for D126210: [libcxx] Fix allocator<void>::pointer in C++20 with removed members.
  • Change test from .fail.cpp to .verify.cpp
Wed, Jun 15, 1:42 AM · Restricted Project, Restricted Project
ilya-biryukov accepted D127833: [clangd] Enable AKA type printing by default.
Wed, Jun 15, 1:34 AM · Restricted Project, Restricted Project

Fri, Jun 10

ilya-biryukov added inline comments to D127487: [Sema] Fix assertion failure when instantiating requires expression.
Fri, Jun 10, 10:35 AM · Restricted Project, Restricted Project
ilya-biryukov added inline comments to D127487: [Sema] Fix assertion failure when instantiating requires expression.
Fri, Jun 10, 9:10 AM · Restricted Project, Restricted Project
ilya-biryukov added a comment to D127487: [Sema] Fix assertion failure when instantiating requires expression.

I've checked that the change works fine on top of D126907. The bug is still there after D126907 and gets fixed by this.
Also, the merge conflict is actually minimal, no code changes intersect.

Fri, Jun 10, 8:50 AM · Restricted Project, Restricted Project
ilya-biryukov added a comment to D127487: [Sema] Fix assertion failure when instantiating requires expression.

I'm not quite understanding this yet, so I'll have to take another look early next week. However, I AM intending to get https://reviews.llvm.org/D126907 committed in the next week or so. Could you perhaps see how it interacts with that? Its a sizable, multi-month project that I'd like to make sure doesn't get stuck in a rebase-loop again.

Fri, Jun 10, 7:22 AM · Restricted Project, Restricted Project
ilya-biryukov updated the diff for D127487: [Sema] Fix assertion failure when instantiating requires expression.
  • Do not introduce empty branches on asserts
  • Test whether specialization or primary template gets picked
Fri, Jun 10, 7:20 AM · Restricted Project, Restricted Project
ilya-biryukov added a comment to D127487: [Sema] Fix assertion failure when instantiating requires expression.

Fixed issue is: 54629

Fri, Jun 10, 4:34 AM · Restricted Project, Restricted Project
ilya-biryukov updated subscribers of D127487: [Sema] Fix assertion failure when instantiating requires expression.

@saar.raz @erichkeane please let me know if you are the right people to review this.
The change might need a little more refactoring, e.g. placement new should probably move to a helper in Sema to align with what clang usually does.

Fri, Jun 10, 4:33 AM · Restricted Project, Restricted Project
ilya-biryukov requested review of D127487: [Sema] Fix assertion failure when instantiating requires expression.
Fri, Jun 10, 4:28 AM · Restricted Project, Restricted Project

Thu, Jun 9

ilya-biryukov added a comment to D125742: Minor refactor of CanonicalIncludes::addSystemHeadersMapping..

Could you commit this?

Thu, Jun 9, 3:20 AM · Restricted Project, Restricted Project
ilya-biryukov committed rGafbe3aed4986: [clangd] Minor refactor of CanonicalIncludes::addSystemHeadersMapping. (authored by ppluzhnikov).
[clangd] Minor refactor of CanonicalIncludes::addSystemHeadersMapping.
Thu, Jun 9, 3:20 AM · Restricted Project, Restricted Project
ilya-biryukov closed D125742: Minor refactor of CanonicalIncludes::addSystemHeadersMapping..
Thu, Jun 9, 3:19 AM · Restricted Project, Restricted Project

Wed, Jun 8

ilya-biryukov added a comment to D126210: [libcxx] Fix allocator<void>::pointer in C++20 with removed members.

@ldionne @philnik another friendly ping, please take a look when you have a spare minute.

Wed, Jun 8, 10:31 PM · Restricted Project, Restricted Project

Tue, Jun 7

ilya-biryukov accepted D125742: Minor refactor of CanonicalIncludes::addSystemHeadersMapping..

LGTM. Thanks for the cleanup!

Tue, Jun 7, 8:46 AM · Restricted Project, Restricted Project

Mon, Jun 6

ilya-biryukov added a comment to D125742: Minor refactor of CanonicalIncludes::addSystemHeadersMapping..

Sorry about the delay. Thanks for the cleanup! I only have a few minor comments here.

Mon, Jun 6, 11:15 PM · Restricted Project, Restricted Project

Fri, Jun 3

ilya-biryukov added a comment to D126210: [libcxx] Fix allocator<void>::pointer in C++20 with removed members.

@ldionne @philnik friendly ping, could you please take another look?

Fri, Jun 3, 6:15 AM · Restricted Project, Restricted Project

Thu, Jun 2

ilya-biryukov added a comment to D126210: [libcxx] Fix allocator<void>::pointer in C++20 with removed members.

Answering my own question here: I ended up pointing CC and CXX to Clang instead of GCC when running CMake. This makes lit add the -verify flag to tests.

Thu, Jun 2, 5:59 AM · Restricted Project, Restricted Project
ilya-biryukov updated the diff for D126210: [libcxx] Fix allocator<void>::pointer in C++20 with removed members.
  • Fix test failure
Thu, Jun 2, 3:45 AM · Restricted Project, Restricted Project
ilya-biryukov added a comment to D126210: [libcxx] Fix allocator<void>::pointer in C++20 with removed members.

I've update change description and the added test. This should fix failures on buildbots and address the comments.
PTAL.

Thu, Jun 2, 12:44 AM · Restricted Project, Restricted Project
ilya-biryukov updated the diff for D126210: [libcxx] Fix allocator<void>::pointer in C++20 with removed members.
  • Update test comment, only check in C++20 and beyond, add expected-errors
Thu, Jun 2, 12:39 AM · Restricted Project, Restricted Project
ilya-biryukov updated the summary of D126210: [libcxx] Fix allocator<void>::pointer in C++20 with removed members.
Thu, Jun 2, 12:06 AM · Restricted Project, Restricted Project
ilya-biryukov added inline comments to D126210: [libcxx] Fix allocator<void>::pointer in C++20 with removed members.
Thu, Jun 2, 12:01 AM · Restricted Project, Restricted Project

May 25 2022

ilya-biryukov added a comment to D126210: [libcxx] Fix allocator<void>::pointer in C++20 with removed members.

Thanks for the quick response. I have addressed the comments, please take another look.

May 25 2022, 9:30 AM · Restricted Project, Restricted Project
ilya-biryukov updated the diff for D126210: [libcxx] Fix allocator<void>::pointer in C++20 with removed members.
  • Add _LIBCPP_ENABLE_CXX20_REMOVED_ALLOCATOR_VOID_SPECIALIZATION
  • Document the new MACRO and add a release note
May 25 2022, 9:29 AM · Restricted Project, Restricted Project
ilya-biryukov added a comment to D126210: [libcxx] Fix allocator<void>::pointer in C++20 with removed members.

@ldionne friendly ping. Just want to make sure this does not fall off your radar.
Let me know if you need more time, no rush here from our side.

May 25 2022, 6:22 AM · Restricted Project, Restricted Project

May 23 2022

ilya-biryukov updated the diff for D126210: [libcxx] Fix allocator<void>::pointer in C++20 with removed members.
  • Move test to test/libcxx
  • Switch test to 'compile.pass' and remove 'main'
May 23 2022, 10:27 AM · Restricted Project, Restricted Project
ilya-biryukov added inline comments to D126210: [libcxx] Fix allocator<void>::pointer in C++20 with removed members.
May 23 2022, 8:23 AM · Restricted Project, Restricted Project
ilya-biryukov requested review of D126210: [libcxx] Fix allocator<void>::pointer in C++20 with removed members.
May 23 2022, 8:09 AM · Restricted Project, Restricted Project

May 20 2022

ilya-biryukov abandoned D125773: [Driver] Do not auto-enable header modules with -std=c++20.
May 20 2022, 8:41 AM · Restricted Project, Restricted Project
ilya-biryukov added a comment to D125773: [Driver] Do not auto-enable header modules with -std=c++20.

So the proposal is that -fheader-modules=parse would parse #include of header unit in the same TU, and import .pcm on import, right?

Per cpp.includep7, "If the header identified by the header-name denotes an importable header ([module.import]), it is implementation-defined whether the #include preprocessing directive is instead replaced by an import directive ([cpp.import]) of the form
import header-name ; new-line"

For Clang, I would expect the implementation-defined behavior to derive from the existence of a module map that nominates a header as being importable.

May 20 2022, 8:41 AM · Restricted Project, Restricted Project

May 19 2022

ilya-biryukov planned changes to D125773: [Driver] Do not auto-enable header modules with -std=c++20.

Richard, thanks for course correcting. I was under impression that header modules are not in the standard, my mistake.

May 19 2022, 8:16 AM · Restricted Project, Restricted Project
ilya-biryukov accepted D125952: [Serialization] Delta encode locations in expansion sloc entries.

LGTM

May 19 2022, 1:41 AM · Restricted Project, Restricted Project

May 18 2022

ilya-biryukov updated the summary of D125868: [Driver] Update set of -std values with C++20 modules enabled.
May 18 2022, 5:23 AM · Restricted Project, Restricted Project
ilya-biryukov retitled D125868: [Driver] Update set of -std values with C++20 modules enabled from [Driver] Recognize -std=gnu++20 enables C++ modules to [Driver] Update set of -std values with C++20 modules enabled.
May 18 2022, 5:23 AM · Restricted Project, Restricted Project
ilya-biryukov accepted D125403: [Serialization] Delta-encode consecutive SourceLocations in TypeLoc.

NIT: typo in the change description

Randam-access

Random

May 18 2022, 4:54 AM · Restricted Project, Restricted Project
ilya-biryukov requested review of D125868: [Driver] Update set of -std values with C++20 modules enabled.
May 18 2022, 3:12 AM · Restricted Project, Restricted Project

May 17 2022

ilya-biryukov added a reviewer for D125773: [Driver] Do not auto-enable header modules with -std=c++20: rsmith.

LG, but I think this is choosing a (new) public name for clang modules/header modules, so maybe Richard or others might want to weigh in?

May 17 2022, 7:35 AM · Restricted Project, Restricted Project
ilya-biryukov updated the diff for D125773: [Driver] Do not auto-enable header modules with -std=c++20.
  • Revert gnu++20 fix
  • Always pass -fheader-modules/-fno-header-modules when modules are enabled
May 17 2022, 7:29 AM · Restricted Project, Restricted Project
ilya-biryukov requested review of D125773: [Driver] Do not auto-enable header modules with -std=c++20.
May 17 2022, 6:27 AM · Restricted Project, Restricted Project

May 12 2022

ilya-biryukov added inline comments to D121733: Clean pathnames in FileManager..
May 12 2022, 1:26 AM · Restricted Project, Restricted Project, Restricted Project

May 11 2022

ilya-biryukov requested changes to D121733: Clean pathnames in FileManager..

Please allow some time for the clangd team to review this before landing.
Changes to filenames used to cause unintended consequences for us before. We switched to using file UIDs since then, but we're still not sure it's not going to break us.

May 11 2022, 10:37 AM · Restricted Project, Restricted Project, Restricted Project

May 9 2022

ilya-biryukov added inline comments to D125224: [CodeComplete] prototype of contextual postfix completions.
May 9 2022, 6:26 AM · Restricted Project, Restricted Project, Restricted Project
ilya-biryukov accepted D125109: [clangd] Rewrite TweakTesting helpers to avoid reparsing the same code. NFC.

LGTM.

May 9 2022, 2:35 AM · Restricted Project, Restricted Project
ilya-biryukov accepted D125169: [clangd] Skip extra round-trip in parsing args in debug builds. NFC.

LGTM

May 9 2022, 2:30 AM · Restricted Project, Restricted Project
ilya-biryukov accepted D125172: [clangd] Disable predefined macros in tests. NFC.

LGTM.

May 9 2022, 2:08 AM · Restricted Project, Restricted Project

May 6 2022

ilya-biryukov accepted D125103: [clangd] Speed up a slow sleeping testcase..

Many thanks for improving the running time, this slow test has bugged me since the day I first ran it.
I'd even be happy to remove it completely. It's slow, possibly flaky, so IMO the corresponding check does not carry its weight.

May 6 2022, 10:35 AM · Restricted Project, Restricted Project

May 5 2022

ilya-biryukov committed rG1e95d1bee638: [clang] Fix Clang release notes (authored by ilya-biryukov).
[clang] Fix Clang release notes
May 5 2022, 9:12 AM · Restricted Project, Restricted Project
ilya-biryukov added a comment to D124923: [Sema] Simplify CheckConstraintSatisfaction. NFC.

@erichkeane sure, will do.

May 5 2022, 9:04 AM · Restricted Project, Restricted Project
ilya-biryukov committed rGe13c28ec595d: [Driver] Remove -fno-concept-satisfaction-caching (authored by ilya-biryukov).
[Driver] Remove -fno-concept-satisfaction-caching
May 5 2022, 8:53 AM · Restricted Project, Restricted Project
ilya-biryukov closed D125014: [Driver] Remove -fno-concept-satisfaction-caching.
May 5 2022, 8:53 AM · Restricted Project, Restricted Project
ilya-biryukov committed rGad2263de9f75: [Sema] Replace invalid FIXME about memory leak. NFC (authored by ilya-biryukov).
[Sema] Replace invalid FIXME about memory leak. NFC
May 5 2022, 8:09 AM · Restricted Project, Restricted Project
ilya-biryukov edited reviewers for D125014: [Driver] Remove -fno-concept-satisfaction-caching, added: sammccall; removed: kadircet.
May 5 2022, 7:46 AM · Restricted Project, Restricted Project
ilya-biryukov requested review of D125014: [Driver] Remove -fno-concept-satisfaction-caching.
May 5 2022, 7:46 AM · Restricted Project, Restricted Project

May 4 2022

ilya-biryukov added inline comments to D124923: [Sema] Simplify CheckConstraintSatisfaction. NFC.
May 4 2022, 10:22 AM · Restricted Project, Restricted Project
ilya-biryukov committed rG726d7b07fcde: [Sema] Simplify CheckConstraintSatisfaction. NFC (authored by ilya-biryukov).
[Sema] Simplify CheckConstraintSatisfaction. NFC
May 4 2022, 8:54 AM · Restricted Project, Restricted Project
ilya-biryukov closed D124923: [Sema] Simplify CheckConstraintSatisfaction. NFC.
May 4 2022, 8:53 AM · Restricted Project, Restricted Project
ilya-biryukov added inline comments to D124923: [Sema] Simplify CheckConstraintSatisfaction. NFC.
May 4 2022, 8:25 AM · Restricted Project, Restricted Project
ilya-biryukov updated the diff for D124923: [Sema] Simplify CheckConstraintSatisfaction. NFC.
  • add FIXME for a memory leak
May 4 2022, 8:25 AM · Restricted Project, Restricted Project
ilya-biryukov added inline comments to D124923: [Sema] Simplify CheckConstraintSatisfaction. NFC.
May 4 2022, 7:01 AM · Restricted Project, Restricted Project
ilya-biryukov requested review of D124923: [Sema] Simplify CheckConstraintSatisfaction. NFC.
May 4 2022, 6:58 AM · Restricted Project, Restricted Project

May 2 2022

ilya-biryukov added a comment to D124606: Use `-text` git attribute instead of `text eol=...'.

LGTM

This and the commit (@MForster ) was too hasty. There should have been time for people discussing D124563 and D97625 to react, and should have been added as reviewers. I didn't even see @ilya-biryukov participating in the other discussions.

May 2 2022, 1:16 AM · Restricted Project, Restricted Project

Apr 28 2022

ilya-biryukov added a comment to D124606: Use `-text` git attribute instead of `text eol=...'.

@labath, ah, sorry, you beat me to it.

Apr 28 2022, 7:18 AM · Restricted Project, Restricted Project
ilya-biryukov added a comment to D124606: Use `-text` git attribute instead of `text eol=...'.

I think this change broke again what D97625 was trying to fix. These are text files and we want them to keep the specified line endings regardless of the local git configuration. See also @smeenai's comment D124563#3478625.

Apr 28 2022, 7:18 AM · Restricted Project, Restricted Project
ilya-biryukov added a comment to D124606: Use `-text` git attribute instead of `text eol=...'.

NIT: change the commit message to say -text instead of binary

Apr 28 2022, 5:27 AM · Restricted Project, Restricted Project
ilya-biryukov accepted D124606: Use `-text` git attribute instead of `text eol=...'.
Apr 28 2022, 5:24 AM · Restricted Project, Restricted Project
ilya-biryukov added a comment to D124606: Use `-text` git attribute instead of `text eol=...'.

LGTM

Apr 28 2022, 5:24 AM · Restricted Project, Restricted Project
ilya-biryukov accepted D124606: Use `-text` git attribute instead of `text eol=...'.
Apr 28 2022, 5:23 AM · Restricted Project, Restricted Project
ilya-biryukov committed rG2b833d4086ab: [AST] Improve traversal of concepts and concept requirements (authored by ilya-biryukov).
[AST] Improve traversal of concepts and concept requirements
Apr 28 2022, 2:38 AM · Restricted Project, Restricted Project, Restricted Project
ilya-biryukov closed D124532: [AST] Improve traversal of concept requirements.
Apr 28 2022, 2:38 AM · Restricted Project, Restricted Project, Restricted Project
ilya-biryukov updated the diff for D124532: [AST] Improve traversal of concept requirements.
  • Mention the AutoType traversal does not traverse the constrained concept decl anymore and add a test for it
Apr 28 2022, 1:37 AM · Restricted Project, Restricted Project, Restricted Project

Apr 27 2022

ilya-biryukov requested review of D124532: [AST] Improve traversal of concept requirements.
Apr 27 2022, 9:15 AM · Restricted Project, Restricted Project, Restricted Project

Apr 26 2022

ilya-biryukov committed rG75e16fd2c656: [Index] [clangd] Support for concept declarations and requires expressions (authored by ilya-biryukov).
[Index] [clangd] Support for concept declarations and requires expressions
Apr 26 2022, 6:50 AM · Restricted Project, Restricted Project, Restricted Project
ilya-biryukov closed D124441: [Index] [clangd] Support for concept declarations and requires expressions.
Apr 26 2022, 6:50 AM · Restricted Project, Restricted Project, Restricted Project
ilya-biryukov updated the diff for D124441: [Index] [clangd] Support for concept declarations and requires expressions.
  • clang-format the code
Apr 26 2022, 6:37 AM · Restricted Project, Restricted Project, Restricted Project
ilya-biryukov added inline comments to D124441: [Index] [clangd] Support for concept declarations and requires expressions.
Apr 26 2022, 3:46 AM · Restricted Project, Restricted Project, Restricted Project
ilya-biryukov updated the diff for D124441: [Index] [clangd] Support for concept declarations and requires expressions.
  • Check 'Concept auto' completion,
  • set -std=c++20 unconditionally,
  • use char instead of int.
Apr 26 2022, 3:46 AM · Restricted Project, Restricted Project, Restricted Project
ilya-biryukov added a comment to D124441: [Index] [clangd] Support for concept declarations and requires expressions.

This looks great!

Only thing I'm uncomfortable with is the lack of test coverage outside clangd.
I think the most valuable thing would be to have some direct testing of how RecursiveASTVisitor behaves.

Just to be clear, I feel it is not RecursiveASTVisitor that's at fault here. It's rather design of the Index library that splits work into multiple visitors.
Requires expression is produces a template parameter list that suddenly appears out of nowhere in the BodyVisitor, whereas the code to handle it is in the DeclVisitor.

Apr 26 2022, 3:04 AM · Restricted Project, Restricted Project, Restricted Project
ilya-biryukov added a comment to D124422: [Serialization] Improve encoding of small SourceRanges..

Yeah, that sounds promising. Various source locations inside the same nodes are probably very close. Probably even across nodes.
If we are willing to take on a bit more complexity, we could probably get even bigger wins by storing all source locations in a single array having indices into that array in the actual positions where we need the source locations. That way we can have:

  • get the benefits of delta-encoding in the source locations array, probably even across nodes,
  • probably still get quite good encoding for indices inside this array inside the actual AST nodes. Will definitely get those if we delta-encode the indices inside the same node.

I suspect there are requirements that will force us to store the array in chunks and allow searching for a particular chunk.

Apr 26 2022, 2:32 AM · Restricted Project, Restricted Project
ilya-biryukov requested review of D124441: [Index] [clangd] Support for concept declarations and requires expressions.
Apr 26 2022, 2:12 AM · Restricted Project, Restricted Project, Restricted Project
ilya-biryukov accepted D124422: [Serialization] Improve encoding of small SourceRanges..

Overall LGTM, but I didn't look closely if there are cases that break now.
Do we have any tests to check this?

Apr 26 2022, 1:33 AM · Restricted Project, Restricted Project
ilya-biryukov added inline comments to D124420: [Serialization] Compress serialized macro expansion SLocEntries.
Apr 26 2022, 1:20 AM · Restricted Project, Restricted Project

Apr 25 2022

ilya-biryukov accepted D124250: [Serialization] write expr dependence bits as a single integer.

LGTM. Nice savings

Apr 25 2022, 2:43 AM · Restricted Project, Restricted Project

Jun 8 2020

ilya-biryukov committed rG9982d48a92be: Updates to the 'CLion Integration' section in ClangFormat docs (authored by ilya-biryukov).
Updates to the 'CLion Integration' section in ClangFormat docs
Jun 8 2020, 9:57 AM
ilya-biryukov closed D80721: Updates to the 'CLion Integration' section in ClangFormat docs.
Jun 8 2020, 9:57 AM · Restricted Project
ilya-biryukov added a comment to D80721: Updates to the 'CLion Integration' section in ClangFormat docs.

Added a few minor changes before committing:

  • surround names of .clang-format files with double backticks
  • ensure no lines are longer than 80 characters
Jun 8 2020, 9:56 AM · Restricted Project