Page MenuHomePhabricator

alexfh (Alexander Kornienko)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 10 2012, 10:35 AM (336 w, 16 h)

Recent Activity

Yesterday

alexfh added inline comments to D54945: This commit adds a chapter about clang-tidy integrations.
Tue, Dec 18, 8:23 AM · Restricted Project
alexfh accepted D55765: Fix use-after-free bug in Tooling..

LG

Tue, Dec 18, 6:58 AM

Mon, Dec 17

alexfh added inline comments to D55765: Fix use-after-free bug in Tooling..
Mon, Dec 17, 6:06 PM

Thu, Dec 6

alexfh requested changes to D49890: Clang-Tidy Export Problem.

Could you describe the specific problem you're solving and provide an example? As mentioned by others, a test would be very welcome as well.

Sorry for so much delay, @alexfh. I didn't see your comment. I will describe in detail:
I wanted to do a source to source transformation on MPlayer-1.3.0 source code. The transformation may require modification of many files and possibly repeated modifications in the headers files included in multiple .c files. Therefore, the changes should be serialized for each translation unit and stored in a YAML file. At the end, clang-apply-replacements will be called and transform the entire source code.
The problem is that clang-tidy expects a limited format for the compilation database. This is the format typically used when the build system generating the compilation database is CMAKE. But MPlayer uses Makefile. Therefore, I had to use an external database generator, Bear. In this case, the contents of the YAML files are OK. But it is not what is expected by clang-tidy. clang-tidy requires every file path to be absolute, even the header files.
The problem (i.e., using relative paths) only arises when the fixes are exported. Not when they are applied in-place. I reused some of the code for the in-place case and did some modifications to it. The code is OK, at least for my case with MPlayer. A small change is still needed to support merge conflicts which can be brought from the in-place fix stuff. It seems that at the end the commanlities of the two cases should be put in a function. Then this function can be called from both places (i.e., the in-place fix and the export fix).
I am new to Clang and do not know what is needed for tests. I am looking forward to your reply.
Regards.

Thu, Dec 6, 8:20 AM · Restricted Project
alexfh accepted D54401: [analyzer] Prefer returns values to out-params in CheckerRegistry.cpp.
In D54401#1315354, @NoQ wrote:

The code looks good, but i vaguely remember that we might accidentally break clang-tidy integration that uses this API to enable/disable specific checkers via -checks=-analyzer-....

*summons @alexfh*

It's hard to tell without trying. Could you build and test clang-tools-extra with this patch? There should be a test for the relevant functionality in clang-tidy.

It compiles without problem, and check-all doesn't produce a single clang-tools-extra failure. Yay!

Thu, Dec 6, 6:43 AM
alexfh edited reviewers for D54945: This commit adds a chapter about clang-tidy integrations, added: ilya-biryukov; removed: asl.
Thu, Dec 6, 6:13 AM · Restricted Project
alexfh added a comment to D54945: This commit adds a chapter about clang-tidy integrations.

@alexfh Thanks a lot for your patience and help. I've made another revision, now with the diff made by 'git show HEAD -U999999' to have the full context availlable.

I don't know how this happened, but the diff is still almost empty.

Thu, Dec 6, 6:11 AM · Restricted Project
alexfh added a comment to D54945: This commit adds a chapter about clang-tidy integrations.

@alexfh Thanks a lot for your patience and help. I've made another revision, now with the diff made by 'git show HEAD -U999999' to have the full context availlable.

Thu, Dec 6, 6:08 AM · Restricted Project
alexfh added a reviewer for D55346: [clang-tidy] check for using declaration qualification: astrelni.
Thu, Dec 6, 6:02 AM · Restricted Project
alexfh added inline comments to D55346: [clang-tidy] check for using declaration qualification.
Thu, Dec 6, 6:01 AM · Restricted Project
alexfh requested changes to D55346: [clang-tidy] check for using declaration qualification.

Could you send each check in a separate patch, please? This makes the review much more straightforward and I'm sure it will be faster too.

Thu, Dec 6, 6:00 AM · Restricted Project

Tue, Dec 4

alexfh added a comment to D54945: This commit adds a chapter about clang-tidy integrations.

Fixes:

  • empty line before 'Standalone tool'
  • table columns with '+/-' aligned
  • line width limited to 80 (except for the table)

    Additions:
  • clang-tidy-vs plugin
  • Clangd in the intro, the table, and CLion's paragraph

Did you forget to add a new file to the patch?

Please also include full context into the diff. See https://llvm.org/docs/Phabricator.html

Sorry but the new diff was included to the patch.. I can see the updates as Diff 176328. Could you please check and let me know if it does not work? Thank you.

Tue, Dec 4, 4:13 AM · Restricted Project
alexfh added inline comments to D55125: [clang-tidy] Fix a false positive in misc-redundant-expression check.
Tue, Dec 4, 4:02 AM · Restricted Project
alexfh added a comment to D54401: [analyzer] Prefer returns values to out-params in CheckerRegistry.cpp.
In D54401#1315354, @NoQ wrote:

The code looks good, but i vaguely remember that we might accidentally break clang-tidy integration that uses this API to enable/disable specific checkers via -checks=-analyzer-....

*summons @alexfh*

Tue, Dec 4, 3:46 AM
alexfh added a comment to D54945: This commit adds a chapter about clang-tidy integrations.

Fixes:

  • empty line before 'Standalone tool'
  • table columns with '+/-' aligned
  • line width limited to 80 (except for the table)

    Additions:
  • clang-tidy-vs plugin
  • Clangd in the intro, the table, and CLion's paragraph
Tue, Dec 4, 3:37 AM · Restricted Project
alexfh accepted D55255: Fix a false positive in misplaced-widening-cast.

LG in general, but a few comments re: test.

Tue, Dec 4, 3:27 AM · Restricted Project

Tue, Nov 27

alexfh added a comment to D54945: This commit adds a chapter about clang-tidy integrations.

Should this chapter be a separate page linked from index.md?

Tue, Nov 27, 7:58 AM · Restricted Project
alexfh accepted D54941: [clang-tidy] Ignore bool -> single bit bitfield conversion in readability-implicit-bool-conversion.

LG

Tue, Nov 27, 7:56 AM
alexfh committed rL347652: [clang-tidy] Avoid inconsistent notes in readability-container-size-empty.
[clang-tidy] Avoid inconsistent notes in readability-container-size-empty
Tue, Nov 27, 2:56 AM
alexfh committed rL347651: [clang-tidy] Minor fixes in a test.
[clang-tidy] Minor fixes in a test
Tue, Nov 27, 2:56 AM
alexfh committed rCTE347652: [clang-tidy] Avoid inconsistent notes in readability-container-size-empty.
[clang-tidy] Avoid inconsistent notes in readability-container-size-empty
Tue, Nov 27, 2:56 AM
alexfh committed rCTE347651: [clang-tidy] Minor fixes in a test.
[clang-tidy] Minor fixes in a test
Tue, Nov 27, 2:56 AM

Mon, Nov 26

alexfh committed rCTE347546: [clang-tidy] PrintStackTraceOnErrorSignal.
[clang-tidy] PrintStackTraceOnErrorSignal
Mon, Nov 26, 3:14 AM
alexfh committed rL347546: [clang-tidy] PrintStackTraceOnErrorSignal.
[clang-tidy] PrintStackTraceOnErrorSignal
Mon, Nov 26, 3:14 AM

Sat, Nov 24

alexfh committed rCTE347520: A bit of AST matcher cleanup, NFC..
A bit of AST matcher cleanup, NFC.
Sat, Nov 24, 6:45 PM
alexfh committed rL347520: A bit of AST matcher cleanup, NFC..
A bit of AST matcher cleanup, NFC.
Sat, Nov 24, 6:44 PM

Fri, Nov 23

alexfh committed rCTE347495: [clang-tidy] Ignore matches in template instantiations (cert-dcl21-cpp).
[clang-tidy] Ignore matches in template instantiations (cert-dcl21-cpp)
Fri, Nov 23, 6:33 AM
alexfh committed rL347495: [clang-tidy] Ignore matches in template instantiations (cert-dcl21-cpp).
[clang-tidy] Ignore matches in template instantiations (cert-dcl21-cpp)
Fri, Nov 23, 6:33 AM

Thu, Nov 22

alexfh committed rL347470: [clang-tidy] Ignore template instantiations in modernize-use-using.
[clang-tidy] Ignore template instantiations in modernize-use-using
Thu, Nov 22, 8:13 AM
alexfh committed rCTE347470: [clang-tidy] Ignore template instantiations in modernize-use-using.
[clang-tidy] Ignore template instantiations in modernize-use-using
Thu, Nov 22, 8:13 AM

Tue, Nov 20

alexfh committed rL347373: [clang-tidy] Add a test for proper handling of locations in scratch space..
[clang-tidy] Add a test for proper handling of locations in scratch space.
Tue, Nov 20, 5:14 PM
alexfh committed rCTE347373: [clang-tidy] Add a test for proper handling of locations in scratch space..
[clang-tidy] Add a test for proper handling of locations in scratch space.
Tue, Nov 20, 5:14 PM
alexfh committed rL347372: clang::tooling::Diagnostic: Don't store offset in the scratch space..
clang::tooling::Diagnostic: Don't store offset in the scratch space.
Tue, Nov 20, 5:12 PM
alexfh committed rC347372: clang::tooling::Diagnostic: Don't store offset in the scratch space..
clang::tooling::Diagnostic: Don't store offset in the scratch space.
Tue, Nov 20, 5:11 PM
alexfh committed rC347371: Implement YAML serialization of notes in clang::tooling::Diagnostic..
Implement YAML serialization of notes in clang::tooling::Diagnostic.
Tue, Nov 20, 5:09 PM
alexfh committed rL347371: Implement YAML serialization of notes in clang::tooling::Diagnostic..
Implement YAML serialization of notes in clang::tooling::Diagnostic.
Tue, Nov 20, 5:09 PM

Nov 16 2018

alexfh committed rCTE347053: [clang-tidy] Expanded a test NFC.
[clang-tidy] Expanded a test NFC
Nov 16 2018, 7:00 AM
alexfh committed rL347053: [clang-tidy] Expanded a test NFC.
[clang-tidy] Expanded a test NFC
Nov 16 2018, 7:00 AM
alexfh accepted D53830: [clang-tidy]: Abseil: new check 'abseil-upgrade-duration-conversions'.

LG with one more comment. Please address other reviewers' comments though.

Nov 16 2018, 1:51 AM · Restricted Project

Nov 14 2018

alexfh added inline comments to D53427: [clangd] Replace StringRef in SymbolLocation with a char pointer..
Nov 14 2018, 6:10 AM
alexfh added inline comments to D53427: [clangd] Replace StringRef in SymbolLocation with a char pointer..
Nov 14 2018, 5:31 AM

Nov 13 2018

alexfh committed rL346761: Fix uninitialized variable..
Fix uninitialized variable.
Nov 13 2018, 8:43 AM
alexfh added inline comments to rL346718: [MachineOutliner][NFC] Change getMachineOutlinerMBBFlags to….
Nov 13 2018, 7:58 AM
alexfh added a comment to D54453: Remove myself as owner of clang-query..

Thanks Aaron for volunteering, I'm very thankful for all your work on the reviews, it's much appreciated :D

Nov 13 2018, 3:52 AM

Nov 12 2018

alexfh committed rLLDB346651: Fix an unused variable warning. NFC.
Fix an unused variable warning. NFC
Nov 12 2018, 5:45 AM
alexfh committed rL346651: Fix an unused variable warning. NFC.
Fix an unused variable warning. NFC
Nov 12 2018, 5:45 AM
alexfh added inline comments to D53830: [clang-tidy]: Abseil: new check 'abseil-upgrade-duration-conversions'.
Nov 12 2018, 2:35 AM · Restricted Project
alexfh added inline comments to D54395: [clang-tidy] implement utility-function to add 'const' to variables.
Nov 12 2018, 2:00 AM

Nov 2 2018

alexfh committed rCTE345984: [clang-tidy] Fixed code sample in a comment. NFC.
[clang-tidy] Fixed code sample in a comment. NFC
Nov 2 2018, 8:32 AM
alexfh committed rL345984: [clang-tidy] Fixed code sample in a comment. NFC.
[clang-tidy] Fixed code sample in a comment. NFC
Nov 2 2018, 8:31 AM
alexfh committed rCTE345979: [clang-tidy] .reset(new X) -> make_unique<X>() in a comment. NFC.
[clang-tidy] .reset(new X) -> make_unique<X>() in a comment. NFC
Nov 2 2018, 8:06 AM
alexfh committed rL345979: [clang-tidy] .reset(new X) -> make_unique<X>() in a comment. NFC.
[clang-tidy] .reset(new X) -> make_unique<X>() in a comment. NFC
Nov 2 2018, 8:06 AM

Oct 31 2018

alexfh added a comment to D53950: Fix clang -Wimplicit-fallthrough warnings across llvm, NFC.

Great! Thanks for picking this up and pushing forward!

Oct 31 2018, 5:10 PM
alexfh accepted D53953: [clang-tidy] Get ClangTidyContext out of the business of storing diagnostics. NFC.

LG

Oct 31 2018, 4:55 PM
alexfh added inline comments to D53830: [clang-tidy]: Abseil: new check 'abseil-upgrade-duration-conversions'.
Oct 31 2018, 4:50 PM · Restricted Project
alexfh accepted D53953: [clang-tidy] Get ClangTidyContext out of the business of storing diagnostics. NFC.

LG with a nit.

Oct 31 2018, 4:23 PM
alexfh added inline comments to D53936: [clang-tidy] More clearly separate public, check-facing APIs from internal ones..
Oct 31 2018, 4:18 PM · Restricted Project
alexfh added a reviewer for D53953: [clang-tidy] Get ClangTidyContext out of the business of storing diagnostics. NFC: alexfh.
Oct 31 2018, 3:52 PM
alexfh added a comment to D53953: [clang-tidy] Get ClangTidyContext out of the business of storing diagnostics. NFC.

error: unable to handle compilation, expected exactly one compiler job in '' [clang-diagnostic-error]
Suppressed 1 warnings (1 with check filters).
Found compiler error(s).

Oct 31 2018, 3:52 PM
alexfh added a comment to D53953: [clang-tidy] Get ClangTidyContext out of the business of storing diagnostics. NFC.

LG in general.

Oct 31 2018, 3:46 PM
alexfh added inline comments to D53882: [clang-tidy] Adding Zircon checker for std namespace.
Oct 31 2018, 5:34 AM · Restricted Project

Oct 24 2018

alexfh added a comment to D53339: [clang-tidy] Add the abseil-duration-factory-float check.

@JonasToth I don't actually have commit privileges, so somebody else will have to commit for me. :)

Oct 24 2018, 11:32 AM · Restricted Project
alexfh added inline comments to D53339: [clang-tidy] Add the abseil-duration-factory-float check.
Oct 24 2018, 8:42 AM · Restricted Project
alexfh added a comment to D48866: [clang-tidy] Add incorrect-pointer-cast checker.

Warning messages changed.
Tests updated.
Comments changed based on the recommendations.
Documentation refactored and reformatted.

Oct 24 2018, 8:29 AM

Oct 23 2018

alexfh committed rL345049: [clang-tidy] Add a separate section for NOLINT(NEXTLINE)? doc..
[clang-tidy] Add a separate section for NOLINT(NEXTLINE)? doc.
Oct 23 2018, 9:50 AM
alexfh committed rCTE345049: [clang-tidy] Add a separate section for NOLINT(NEXTLINE)? doc..
[clang-tidy] Add a separate section for NOLINT(NEXTLINE)? doc.
Oct 23 2018, 9:50 AM

Oct 16 2018

alexfh edited reviewers for D53339: [clang-tidy] Add the abseil-duration-factory-float check, added: hokein, aaron.ballman; removed: alexfh_.
Oct 16 2018, 4:53 PM · Restricted Project
alexfh added a comment to D53339: [clang-tidy] Add the abseil-duration-factory-float check.

LG In general, but see a few comments inline.

Oct 16 2018, 4:52 PM · Restricted Project

Oct 12 2018

alexfh accepted D53217: [clang-tidy] add IgnoreMacros option to modernize-use-equals-delete.

LG with a nit.

Oct 12 2018, 5:50 PM · Restricted Project

Oct 9 2018

alexfh committed rCTE344058: [clang-tidy] Fix handling of parens around new expressions in make_<smartptr>….
[clang-tidy] Fix handling of parens around new expressions in make_<smartptr>…
Oct 9 2018, 9:00 AM
alexfh committed rL344058: [clang-tidy] Fix handling of parens around new expressions in make_<smartptr>….
[clang-tidy] Fix handling of parens around new expressions in make_<smartptr>…
Oct 9 2018, 9:00 AM
alexfh closed D52989: [clang-tidy] Fix handling of parens around new expressions in make_<smartptr> checks..
Oct 9 2018, 9:00 AM
alexfh added inline comments to D52989: [clang-tidy] Fix handling of parens around new expressions in make_<smartptr> checks..
Oct 9 2018, 8:58 AM
alexfh updated the diff for D52989: [clang-tidy] Fix handling of parens around new expressions in make_<smartptr> checks..
  • Remove recursion, use auto.
Oct 9 2018, 8:58 AM

Oct 8 2018

alexfh created D52989: [clang-tidy] Fix handling of parens around new expressions in make_<smartptr> checks..
Oct 8 2018, 9:36 AM
alexfh removed a reviewer for D52690: [clang-tidy] NFC use CHECK-NOTES in tests for misc-misplaced-const: alexfh. alexfh added 1 blocking reviewer(s) for D52690: [clang-tidy] NFC use CHECK-NOTES in tests for misc-misplaced-const: aaron.ballman.
Oct 8 2018, 5:10 AM
alexfh accepted D52971: [clang-tidy] Customize FileCheck prefix in check_clang-tidy.py to support multiple prefixes.

Looks good with a comment.

Oct 8 2018, 5:08 AM · Restricted Project

Oct 5 2018

alexfh accepted D52684: [clang-tidy] NFC refactor lexer-utils to be usable without ASTContext.

This patch is related to https://reviews.llvm.org/D51949

To isolate variable declarations (split int * p, v; up) it is necessary to do a lot of work with source location and requires some forward and backwards lexing. The functions there just use the LangOpts and the SourceManager and don't have a ASTContext available, that why I changed this interface.

Oct 5 2018, 7:09 AM · Restricted Project

Oct 4 2018

alexfh accepted D51332: [clang-tidy] Replace deprecated std::ios_base aliases.

LG once other comments are addressed.

Oct 4 2018, 8:02 AM
alexfh accepted D52688: [clang-tidy] NFC use CHECK-NOTES in tests for fuchsia-default-arguments.

LG

Oct 4 2018, 7:56 AM
alexfh accepted D52882: [clang-tidy] Added pointer types to clang-tidy readability-identifier-naming check..

LG

Oct 4 2018, 7:55 AM
alexfh accepted D52691: [clang-tidy] NFC use CHECK-NOTES in tests for performance-move-constructor-init.

LG. Thanks

Oct 4 2018, 7:52 AM
alexfh accepted D52880: [clang-tidy] fix PR39167, bugprone-exception-escape hangs-up.

Have you figured out why exactly does the check hang? Disabling it for -fno-exceptions may just hide a logical problem in the check.

Oct 4 2018, 7:52 AM
alexfh added a comment to D52880: [clang-tidy] fix PR39167, bugprone-exception-escape hangs-up.

Have you figured out why exactly does the check hang? Disabling it for -fno-exceptions may just hide a logical problem in the check.

Oct 4 2018, 7:48 AM

Oct 2 2018

alexfh committed rL343578: [clang-tidy] Ignore singe bit bitfield -> bool conversion in readability….
[clang-tidy] Ignore singe bit bitfield -> bool conversion in readability…
Oct 2 2018, 4:41 AM
alexfh committed rCTE343578: [clang-tidy] Ignore singe bit bitfield -> bool conversion in readability….
[clang-tidy] Ignore singe bit bitfield -> bool conversion in readability…
Oct 2 2018, 4:41 AM

Oct 1 2018

alexfh requested changes to D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--).
Oct 1 2018, 8:17 AM · Restricted Project
alexfh requested changes to D36836: [clang-tidy] Implement sonarsource-function-cognitive-complexity check.

Anything new here? Is there a LLVM foundation lawyer or something like that we can ask?

Oct 1 2018, 6:19 AM · Restricted Project
alexfh added inline comments to D52690: [clang-tidy] NFC use CHECK-NOTES in tests for misc-misplaced-const.
Oct 1 2018, 6:16 AM
alexfh accepted D52687: [clang-tidy] NFC use CHECK-NOTES in tests for cppcoreguidelines-owning-memory.

LG

Oct 1 2018, 5:28 AM
alexfh added inline comments to D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--).
Oct 1 2018, 5:14 AM · Restricted Project
alexfh requested changes to D52684: [clang-tidy] NFC refactor lexer-utils to be usable without ASTContext.

So far the change doesn't look really helpful. Are you going to use the function from code where no ASTContext is available? Can you give an example?

Oct 1 2018, 5:12 AM · Restricted Project
alexfh accepted D52686: [clang-tidy] NFC use CHECK-NOTES in test for cppgoreguidelines-avoid-goto.

LG

Oct 1 2018, 5:06 AM
alexfh requested changes to D52690: [clang-tidy] NFC use CHECK-NOTES in tests for misc-misplaced-const.
Oct 1 2018, 5:05 AM
alexfh requested changes to D52691: [clang-tidy] NFC use CHECK-NOTES in tests for performance-move-constructor-init.
Oct 1 2018, 5:00 AM
alexfh added inline comments to D52691: [clang-tidy] NFC use CHECK-NOTES in tests for performance-move-constructor-init.
Oct 1 2018, 4:59 AM

Sep 27 2018

alexfh added a comment to rL343198: [clang-tidy] use CHECK-NOTES in tests for bugprone-forward-declaration-namespace.

I commit the patches for CHECK-NOTES assuming the LG to https://reviews.llvm.org/D52230 includes the LG to the question, if i can commit all these patches. If this is not the case, i will of course revert/adjust accordingly.

Sep 27 2018, 7:49 AM

Sep 24 2018

alexfh added inline comments to D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--).
Sep 24 2018, 7:20 AM · Restricted Project
alexfh requested changes to D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--).
Sep 24 2018, 7:20 AM · Restricted Project
alexfh added a comment to D52334: [clang-tidy] Build it even without static analyzer.

! In D52334#1242955, @JonasToth wrote:
... to me it makes sense to have clang-tidy without CSA.

Sep 24 2018, 7:20 AM · Restricted Project