Page MenuHomePhabricator

alexfh (Alexander Kornienko)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 10 2012, 10:35 AM (345 w, 1 d)

Recent Activity

Today

alexfh added a comment to D58278: Prepare ground for re-lexing modular headers..

Friendly ping.

Wed, Feb 20, 2:50 AM · Restricted Project

Mon, Feb 18

alexfh edited reviewers for D58278: Prepare ground for re-lexing modular headers., added: sammccall; removed: klimek.
Mon, Feb 18, 8:08 AM · Restricted Project
alexfh committed rCTE354266: [clang-tidy] Fix links in docs..
[clang-tidy] Fix links in docs.
Mon, Feb 18, 4:51 AM
alexfh committed rG958837c6409c: [clang-tidy] Fix links in docs. (authored by alexfh).
[clang-tidy] Fix links in docs.
Mon, Feb 18, 4:51 AM
alexfh committed rL354266: [clang-tidy] Fix links in docs..
[clang-tidy] Fix links in docs.
Mon, Feb 18, 4:51 AM

Fri, Feb 15

alexfh added inline comments to D57662: [clang-tidy] Parallelise clang-tidy-diff.py .
Fri, Feb 15, 3:16 PM · Restricted Project, Restricted Project
alexfh added a comment to D57112: [ASTTypeTraits] OMPClause handling.

Ping @hokein / @alexfh (as per git blame).
Not sure who is best suited to review this.

Fri, Feb 15, 3:11 PM · Restricted Project, Restricted Project
alexfh committed rG027f5f56839f: clang-format with UseTab: Always sometimes doesn't insert the right amount of… (authored by alexfh).
clang-format with UseTab: Always sometimes doesn't insert the right amount of…
Fri, Feb 15, 3:08 PM
alexfh committed rC354183: clang-format with UseTab: Always sometimes doesn't insert the right amount of….
clang-format with UseTab: Always sometimes doesn't insert the right amount of…
Fri, Feb 15, 3:07 PM
alexfh committed rL354183: clang-format with UseTab: Always sometimes doesn't insert the right amount of….
clang-format with UseTab: Always sometimes doesn't insert the right amount of…
Fri, Feb 15, 3:07 PM
alexfh closed D57655: clang-format with UseTab: Always sometimes doesn't insert the right amount of tabs..
Fri, Feb 15, 3:07 PM · Restricted Project
Herald added a project to D56644: [clang-tidy] readability-container-size-empty handle std::string length(): Restricted Project.
Fri, Feb 15, 6:30 AM · Restricted Project, Restricted Project
alexfh added inline comments to D57662: [clang-tidy] Parallelise clang-tidy-diff.py .
Fri, Feb 15, 6:22 AM · Restricted Project, Restricted Project
alexfh requested changes to D57087: [clang-tidy] add OverrideMacro to modernize-use-override check.
Fri, Feb 15, 5:51 AM · Restricted Project
alexfh created D58278: Prepare ground for re-lexing modular headers..
Fri, Feb 15, 4:04 AM · Restricted Project

Wed, Feb 13

alexfh accepted D57655: clang-format with UseTab: Always sometimes doesn't insert the right amount of tabs..

Seems reasonable. LG with a couple of nits. Please let me know if you need to commit this for you.

Wed, Feb 13, 2:00 AM · Restricted Project

Mon, Feb 11

alexfh committed rG9a857d207598: Fixed header underline in docs. (authored by alexfh).
Fixed header underline in docs.
Mon, Feb 11, 7:18 AM
alexfh committed rC353711: Fixed header underline in docs..
Fixed header underline in docs.
Mon, Feb 11, 7:17 AM
alexfh committed rL353711: Fixed header underline in docs..
Fixed header underline in docs.
Mon, Feb 11, 7:17 AM

Thu, Feb 7

alexfh committed rG68d5652380b7: [clang-tidy] Expand and clarify the NOLINT documentation a bit. (authored by alexfh).
[clang-tidy] Expand and clarify the NOLINT documentation a bit.
Thu, Feb 7, 2:35 AM
alexfh committed rL353382: [clang-tidy] Expand and clarify the NOLINT documentation a bit..
[clang-tidy] Expand and clarify the NOLINT documentation a bit.
Thu, Feb 7, 2:34 AM
alexfh committed rCTE353382: [clang-tidy] Expand and clarify the NOLINT documentation a bit..
[clang-tidy] Expand and clarify the NOLINT documentation a bit.
Thu, Feb 7, 2:34 AM

Sat, Feb 2

alexfh added a comment to D57573: Disable tidy checks with too many hits.

I wonder whether a list of specific checks (without wildcards) would make more sense for llvm?

Sat, Feb 2, 3:26 PM · Restricted Project, Restricted Project

Thu, Jan 31

alexfh added a comment to rC352284: [analyzer] Fix an bug where statically linked, but not registered checkers….

Hmm. This must mean that listing statically linked, non-tblgen-registered checkers in -analyzer-checker-help was never supported, as checkerRegistrationFns was never supplied to ento::printCheckerHelp (lib/StaticAnalyzer/Frontend/CheckerRegistration.cpp:46 in this commit).

Thu, Jan 31, 6:04 AM

Mon, Jan 28

alexfh added inline comments to D56851: [ASTMatchers] Adds `CXXMemberCallExpr` matcher `invokedAtType`..
Mon, Jan 28, 8:02 AM

Fri, Jan 25

alexfh added inline comments to D56851: [ASTMatchers] Adds `CXXMemberCallExpr` matcher `invokedAtType`..
Fri, Jan 25, 6:00 AM

Thu, Jan 24

alexfh added a comment to D55523: [clang-tidy] Linting .rst documentation.

A few questions:

  1. why do we want to lint just clang-tidy docs and not all LLVM's .rst files?
  2. did you try the existing tools to lint rst, for example https://github.com/twolfson/restructuredtext-lint?
  3. maybe there are some automated formatters for rst out there?
Thu, Jan 24, 8:14 AM · Restricted Project

Wed, Jan 23

alexfh added inline comments to D55125: [clang-tidy] Fix a false positive in misc-redundant-expression check.
Wed, Jan 23, 5:17 AM · Restricted Project
alexfh removed a reviewer for D56661: [clang-tidy] Fix incorrect array name generation in cppcoreguidelines-pro-bounds-constant-array-index: alexfh.
Wed, Jan 23, 5:00 AM
alexfh accepted D56849: [ASTMatchers][NFC] Update comments on assorted `CXXMemberCallExpr` matchers..

LG

Wed, Jan 23, 4:59 AM · Restricted Project
alexfh removed a reviewer for D55640: [clang-tidy] Implement a check for large Objective-C type encodings 🔍: alexfh.
Wed, Jan 23, 4:59 AM · Restricted Project
alexfh added inline comments to D56303: [clang-tidy] Handle case/default statements when simplifying boolean expressions.
Wed, Jan 23, 4:56 AM · Restricted Project
alexfh requested changes to D57087: [clang-tidy] add OverrideMacro to modernize-use-override check.

I tend to think that a better migration strategy is to change the compiler to a C++11-compatible one first, and then turn on C++11 mode and migrate the code (possibly file-by-file or with a different granularity). But if you observe a situation where compatibility macros for C++11 constructs are actually a better way to migrate, then the proposed functionality makes sense.

Wed, Jan 23, 4:50 AM · Restricted Project

Tue, Jan 22

alexfh accepted D56849: [ASTMatchers][NFC] Update comments on assorted `CXXMemberCallExpr` matchers..

Thanks for tidying up the docs. LG with one nit.

Tue, Jan 22, 7:12 AM · Restricted Project
alexfh committed rCTE351814: [clang-tidy] Fix whitespace in docs. NFC.
[clang-tidy] Fix whitespace in docs. NFC
Tue, Jan 22, 4:59 AM
alexfh committed rL351814: [clang-tidy] Fix whitespace in docs. NFC.
[clang-tidy] Fix whitespace in docs. NFC
Tue, Jan 22, 4:59 AM

Jan 21 2019

alexfh committed rCTE351751: [clang-tidy] Work around http://llvm.org/PR40392.
[clang-tidy] Work around http://llvm.org/PR40392
Jan 21 2019, 8:27 AM
alexfh committed rL351751: [clang-tidy] Work around http://llvm.org/PR40392.
[clang-tidy] Work around http://llvm.org/PR40392
Jan 21 2019, 8:27 AM

Jan 18 2019

alexfh added a comment to D56901: [Support] Fix Windows Command Shell Command line parsing for quoted arguments.

Where does this problem come from?

https://bugs.llvm.org/show_bug.cgi?id=38471 (in case you didn't see that)

Jan 18 2019, 7:00 AM
alexfh added a comment to D56901: [Support] Fix Windows Command Shell Command line parsing for quoted arguments.

This is not in any way specific to clang-tidy. Since it will affect the behavior of Clang on Windows, I'd like Reid or someone else who's familiar with the topic to have a look.

Jan 18 2019, 6:01 AM
alexfh accepted D56902: [clang-tidy] Use getStripPluginsAdjuster.

LG

Jan 18 2019, 5:49 AM · Restricted Project
alexfh added a reviewer for D56901: [Support] Fix Windows Command Shell Command line parsing for quoted arguments: rnk.
Jan 18 2019, 5:23 AM

Jan 15 2019

alexfh committed rL351196: Reduce ASTMatchers stack footprint. Addresses http://llvm.org/PR38851.
Reduce ASTMatchers stack footprint. Addresses http://llvm.org/PR38851
Jan 15 2019, 7:38 AM
alexfh committed rC351196: Reduce ASTMatchers stack footprint. Addresses http://llvm.org/PR38851.
Reduce ASTMatchers stack footprint. Addresses http://llvm.org/PR38851
Jan 15 2019, 7:38 AM

Jan 11 2019

alexfh accepted D54945: This commit adds a chapter about clang-tidy integrations.

Awesome! Thanks a lot ! LG

Jan 11 2019, 2:50 PM · Restricted Project

Jan 9 2019

alexfh committed rL350727: Remove dependency-related arguments in clang-check..
Remove dependency-related arguments in clang-check.
Jan 9 2019, 7:04 AM
alexfh committed rC350727: Remove dependency-related arguments in clang-check..
Remove dependency-related arguments in clang-check.
Jan 9 2019, 7:04 AM
alexfh committed rL350700: Make the write_cmake_config.py script python3-compatible.
Make the write_cmake_config.py script python3-compatible
Jan 9 2019, 2:54 AM

Jan 8 2019

alexfh committed rC350638: Fix use-after-free bug in Tooling..
Fix use-after-free bug in Tooling.
Jan 8 2019, 9:00 AM
alexfh committed rL350638: Fix use-after-free bug in Tooling..
Fix use-after-free bug in Tooling.
Jan 8 2019, 9:00 AM
alexfh closed D55765: Fix use-after-free bug in Tooling..
Jan 8 2019, 8:59 AM

Jan 7 2019

alexfh added a comment to D56012: [clang-tidy] Be more liberal about literal zeroes in abseil checks.

One random late comment.

Jan 7 2019, 8:14 AM · Restricted Project
alexfh added a comment to D54945: This commit adds a chapter about clang-tidy integrations.

@alexfh Just for me to be sure, should there be the following structure in http://clang.llvm.org/extra/index.html: ...

Jan 7 2019, 8:08 AM · Restricted Project

Dec 20 2018

alexfh committed rCTE349758: [clang-tidy] Use translationUnitDecl() instead of a custom matcher..
[clang-tidy] Use translationUnitDecl() instead of a custom matcher.
Dec 20 2018, 5:53 AM
alexfh committed rL349758: [clang-tidy] Use translationUnitDecl() instead of a custom matcher..
[clang-tidy] Use translationUnitDecl() instead of a custom matcher.
Dec 20 2018, 5:53 AM

Dec 18 2018

alexfh added inline comments to D54945: This commit adds a chapter about clang-tidy integrations.
Dec 18 2018, 8:23 AM · Restricted Project
alexfh accepted D55765: Fix use-after-free bug in Tooling..

LG

Dec 18 2018, 6:58 AM

Dec 17 2018

alexfh added inline comments to D55765: Fix use-after-free bug in Tooling..
Dec 17 2018, 6:06 PM

Dec 6 2018

alexfh requested changes to D49890: Clang-Tidy Export Problem.

Could you describe the specific problem you're solving and provide an example? As mentioned by others, a test would be very welcome as well.

Sorry for so much delay, @alexfh. I didn't see your comment. I will describe in detail:
I wanted to do a source to source transformation on MPlayer-1.3.0 source code. The transformation may require modification of many files and possibly repeated modifications in the headers files included in multiple .c files. Therefore, the changes should be serialized for each translation unit and stored in a YAML file. At the end, clang-apply-replacements will be called and transform the entire source code.
The problem is that clang-tidy expects a limited format for the compilation database. This is the format typically used when the build system generating the compilation database is CMAKE. But MPlayer uses Makefile. Therefore, I had to use an external database generator, Bear. In this case, the contents of the YAML files are OK. But it is not what is expected by clang-tidy. clang-tidy requires every file path to be absolute, even the header files.
The problem (i.e., using relative paths) only arises when the fixes are exported. Not when they are applied in-place. I reused some of the code for the in-place case and did some modifications to it. The code is OK, at least for my case with MPlayer. A small change is still needed to support merge conflicts which can be brought from the in-place fix stuff. It seems that at the end the commanlities of the two cases should be put in a function. Then this function can be called from both places (i.e., the in-place fix and the export fix).
I am new to Clang and do not know what is needed for tests. I am looking forward to your reply.
Regards.

Dec 6 2018, 8:20 AM · Restricted Project
alexfh accepted D54401: [analyzer] Prefer returns values to out-params in CheckerRegistry.cpp.
In D54401#1315354, @NoQ wrote:

The code looks good, but i vaguely remember that we might accidentally break clang-tidy integration that uses this API to enable/disable specific checkers via -checks=-analyzer-....

*summons @alexfh*

It's hard to tell without trying. Could you build and test clang-tools-extra with this patch? There should be a test for the relevant functionality in clang-tidy.

It compiles without problem, and check-all doesn't produce a single clang-tools-extra failure. Yay!

Dec 6 2018, 6:43 AM
alexfh edited reviewers for D54945: This commit adds a chapter about clang-tidy integrations, added: ilya-biryukov; removed: asl.
Dec 6 2018, 6:13 AM · Restricted Project
alexfh added a comment to D54945: This commit adds a chapter about clang-tidy integrations.

@alexfh Thanks a lot for your patience and help. I've made another revision, now with the diff made by 'git show HEAD -U999999' to have the full context availlable.

I don't know how this happened, but the diff is still almost empty.

Dec 6 2018, 6:11 AM · Restricted Project
alexfh added a comment to D54945: This commit adds a chapter about clang-tidy integrations.

@alexfh Thanks a lot for your patience and help. I've made another revision, now with the diff made by 'git show HEAD -U999999' to have the full context availlable.

Dec 6 2018, 6:08 AM · Restricted Project
alexfh added a reviewer for D55346: [clang-tidy] check for using declaration qualification: astrelni.
Dec 6 2018, 6:02 AM · Restricted Project
alexfh added inline comments to D55346: [clang-tidy] check for using declaration qualification.
Dec 6 2018, 6:01 AM · Restricted Project
alexfh requested changes to D55346: [clang-tidy] check for using declaration qualification.

Could you send each check in a separate patch, please? This makes the review much more straightforward and I'm sure it will be faster too.

Dec 6 2018, 6:00 AM · Restricted Project

Dec 4 2018

alexfh added a comment to D54945: This commit adds a chapter about clang-tidy integrations.

Fixes:

  • empty line before 'Standalone tool'
  • table columns with '+/-' aligned
  • line width limited to 80 (except for the table)

    Additions:
  • clang-tidy-vs plugin
  • Clangd in the intro, the table, and CLion's paragraph

Did you forget to add a new file to the patch?

Please also include full context into the diff. See https://llvm.org/docs/Phabricator.html

Sorry but the new diff was included to the patch.. I can see the updates as Diff 176328. Could you please check and let me know if it does not work? Thank you.

Dec 4 2018, 4:13 AM · Restricted Project
alexfh added inline comments to D55125: [clang-tidy] Fix a false positive in misc-redundant-expression check.
Dec 4 2018, 4:02 AM · Restricted Project
alexfh added a comment to D54401: [analyzer] Prefer returns values to out-params in CheckerRegistry.cpp.
In D54401#1315354, @NoQ wrote:

The code looks good, but i vaguely remember that we might accidentally break clang-tidy integration that uses this API to enable/disable specific checkers via -checks=-analyzer-....

*summons @alexfh*

Dec 4 2018, 3:46 AM
alexfh added a comment to D54945: This commit adds a chapter about clang-tidy integrations.

Fixes:

  • empty line before 'Standalone tool'
  • table columns with '+/-' aligned
  • line width limited to 80 (except for the table)

    Additions:
  • clang-tidy-vs plugin
  • Clangd in the intro, the table, and CLion's paragraph
Dec 4 2018, 3:37 AM · Restricted Project
alexfh accepted D55255: Fix a false positive in misplaced-widening-cast.

LG in general, but a few comments re: test.

Dec 4 2018, 3:27 AM · Restricted Project

Nov 27 2018

alexfh added a comment to D54945: This commit adds a chapter about clang-tidy integrations.

Should this chapter be a separate page linked from index.md?

Nov 27 2018, 7:58 AM · Restricted Project
alexfh accepted D54941: [clang-tidy] Ignore bool -> single bit bitfield conversion in readability-implicit-bool-conversion.

LG

Nov 27 2018, 7:56 AM
alexfh committed rL347652: [clang-tidy] Avoid inconsistent notes in readability-container-size-empty.
[clang-tidy] Avoid inconsistent notes in readability-container-size-empty
Nov 27 2018, 2:56 AM
alexfh committed rL347651: [clang-tidy] Minor fixes in a test.
[clang-tidy] Minor fixes in a test
Nov 27 2018, 2:56 AM
alexfh committed rCTE347652: [clang-tidy] Avoid inconsistent notes in readability-container-size-empty.
[clang-tidy] Avoid inconsistent notes in readability-container-size-empty
Nov 27 2018, 2:56 AM
alexfh committed rCTE347651: [clang-tidy] Minor fixes in a test.
[clang-tidy] Minor fixes in a test
Nov 27 2018, 2:56 AM

Nov 26 2018

alexfh committed rCTE347546: [clang-tidy] PrintStackTraceOnErrorSignal.
[clang-tidy] PrintStackTraceOnErrorSignal
Nov 26 2018, 3:14 AM
alexfh committed rL347546: [clang-tidy] PrintStackTraceOnErrorSignal.
[clang-tidy] PrintStackTraceOnErrorSignal
Nov 26 2018, 3:14 AM

Nov 24 2018

alexfh committed rCTE347520: A bit of AST matcher cleanup, NFC..
A bit of AST matcher cleanup, NFC.
Nov 24 2018, 6:45 PM
alexfh committed rL347520: A bit of AST matcher cleanup, NFC..
A bit of AST matcher cleanup, NFC.
Nov 24 2018, 6:44 PM

Nov 23 2018

alexfh committed rCTE347495: [clang-tidy] Ignore matches in template instantiations (cert-dcl21-cpp).
[clang-tidy] Ignore matches in template instantiations (cert-dcl21-cpp)
Nov 23 2018, 6:33 AM
alexfh committed rL347495: [clang-tidy] Ignore matches in template instantiations (cert-dcl21-cpp).
[clang-tidy] Ignore matches in template instantiations (cert-dcl21-cpp)
Nov 23 2018, 6:33 AM

Nov 22 2018

alexfh committed rL347470: [clang-tidy] Ignore template instantiations in modernize-use-using.
[clang-tidy] Ignore template instantiations in modernize-use-using
Nov 22 2018, 8:13 AM
alexfh committed rCTE347470: [clang-tidy] Ignore template instantiations in modernize-use-using.
[clang-tidy] Ignore template instantiations in modernize-use-using
Nov 22 2018, 8:13 AM

Nov 20 2018

alexfh committed rL347373: [clang-tidy] Add a test for proper handling of locations in scratch space..
[clang-tidy] Add a test for proper handling of locations in scratch space.
Nov 20 2018, 5:14 PM
alexfh committed rCTE347373: [clang-tidy] Add a test for proper handling of locations in scratch space..
[clang-tidy] Add a test for proper handling of locations in scratch space.
Nov 20 2018, 5:14 PM
alexfh committed rL347372: clang::tooling::Diagnostic: Don't store offset in the scratch space..
clang::tooling::Diagnostic: Don't store offset in the scratch space.
Nov 20 2018, 5:12 PM
alexfh committed rC347372: clang::tooling::Diagnostic: Don't store offset in the scratch space..
clang::tooling::Diagnostic: Don't store offset in the scratch space.
Nov 20 2018, 5:11 PM
alexfh committed rC347371: Implement YAML serialization of notes in clang::tooling::Diagnostic..
Implement YAML serialization of notes in clang::tooling::Diagnostic.
Nov 20 2018, 5:09 PM
alexfh committed rL347371: Implement YAML serialization of notes in clang::tooling::Diagnostic..
Implement YAML serialization of notes in clang::tooling::Diagnostic.
Nov 20 2018, 5:09 PM

Nov 16 2018

alexfh committed rCTE347053: [clang-tidy] Expanded a test NFC.
[clang-tidy] Expanded a test NFC
Nov 16 2018, 7:00 AM
alexfh committed rL347053: [clang-tidy] Expanded a test NFC.
[clang-tidy] Expanded a test NFC
Nov 16 2018, 7:00 AM
alexfh accepted D53830: [clang-tidy]: Abseil: new check 'abseil-upgrade-duration-conversions'.

LG with one more comment. Please address other reviewers' comments though.

Nov 16 2018, 1:51 AM · Restricted Project

Nov 14 2018

alexfh added inline comments to D53427: [clangd] Replace StringRef in SymbolLocation with a char pointer..
Nov 14 2018, 6:10 AM
alexfh added inline comments to D53427: [clangd] Replace StringRef in SymbolLocation with a char pointer..
Nov 14 2018, 5:31 AM

Nov 13 2018

alexfh committed rL346761: Fix uninitialized variable..
Fix uninitialized variable.
Nov 13 2018, 8:43 AM
alexfh added inline comments to rL346718: [MachineOutliner][NFC] Change getMachineOutlinerMBBFlags to….
Nov 13 2018, 7:58 AM
alexfh added a comment to D54453: Remove myself as owner of clang-query..

Thanks Aaron for volunteering, I'm very thankful for all your work on the reviews, it's much appreciated :D

Nov 13 2018, 3:52 AM

Nov 12 2018

alexfh committed rLLDB346651: Fix an unused variable warning. NFC.
Fix an unused variable warning. NFC
Nov 12 2018, 5:45 AM