alexfh (Alexander Kornienko)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 10 2012, 10:35 AM (288 w, 4 d)

Recent Activity

Wed, Jan 17

alexfh added a comment to D41708: [clang-tidy] Update fuchsia-overloaded-operator to check for valid loc.
In D41708#977000, @hans wrote:

Alex, do you think the fix is still OK for the 6.0 branch? Let me know, and I'll merge it.

Wed, Jan 17, 3:21 AM · Restricted Project

Thu, Jan 11

alexfh committed rCTE322274: [clang-tidy] Fix google-readability-namespace-comments handling of C++17 nested….
[clang-tidy] Fix google-readability-namespace-comments handling of C++17 nested…
Thu, Jan 11, 5:02 AM
alexfh committed rL322274: [clang-tidy] Fix google-readability-namespace-comments handling of C++17 nested….
[clang-tidy] Fix google-readability-namespace-comments handling of C++17 nested…
Thu, Jan 11, 5:01 AM
alexfh closed D38284: [clang-tidy] Fix google-readability-namespace-comments handling of C++17 nested namespaces.
Thu, Jan 11, 5:01 AM · Restricted Project

Wed, Jan 10

alexfh reopened D38284: [clang-tidy] Fix google-readability-namespace-comments handling of C++17 nested namespaces.
Wed, Jan 10, 8:31 AM · Restricted Project
alexfh added a comment to D38284: [clang-tidy] Fix google-readability-namespace-comments handling of C++17 nested namespaces.

It looks like the latest patch was lost. I'll see whether it still applies cleanly...

Wed, Jan 10, 8:31 AM · Restricted Project

Tue, Jan 9

alexfh added reviewers for D41326: [clang-tidy] Added diagnostics about incorrect usage of NOLINT comment: hokein, ilya-biryukov.
Tue, Jan 9, 8:28 AM · Restricted Project
alexfh added a comment to D41326: [clang-tidy] Added diagnostics about incorrect usage of NOLINT comment.

A high-level comment: NOLINT category parsing and warning on incorrect NOLINT categories makes it more difficult for code to comply both with clang-tidy and cpplint (https://github.com/cpplint/cpplint), since:

  1. the category names in these tools are different,
  2. cpplint currently doesn't support more than one category with the // NOLINT(category) syntax,
  3. cpplint complains on // NOLINT directives with an unknown category.
Tue, Jan 9, 8:27 AM · Restricted Project
alexfh added inline comments to D40478: Added control flow architecture protection Flag.
Tue, Jan 9, 7:06 AM
alexfh committed rL322082: Explicitly specify output file..
Explicitly specify output file.
Tue, Jan 9, 7:06 AM
alexfh committed rC322082: Explicitly specify output file..
Explicitly specify output file.
Tue, Jan 9, 7:06 AM
alexfh added inline comments to D40478: Added control flow architecture protection Flag.
Tue, Jan 9, 6:36 AM

Fri, Jan 5

alexfh added a comment to D41720: [clang-tidy] Add a -show-color flag..

Clang supports -fcolor-diagnostics. I guess, we could use it, e.g. via -extra-arg=-fcolor-diagnostics.

Fri, Jan 5, 6:50 AM · Restricted Project
alexfh edited reviewers for D35787: [clang-tidy] Ignore vector<bool> in inefficient-vector-operation., added: ilya-biryukov; removed: alexfh.
Fri, Jan 5, 6:33 AM
alexfh added a comment to D35787: [clang-tidy] Ignore vector<bool> in inefficient-vector-operation..

Should we look at whether the size is statically known?

Do you mean the size of the template type T in vector<T>? STL only provides a template specialization for std::vector<bool>, so I think excluding vector<bool> is probably enough, or am I missing anything here?

Fri, Jan 5, 6:33 AM
alexfh requested changes to D15032: [clang-tidy] new checker cppcoreguidelines-pro-lifetime.

D15031 has landed quite a while ago. Could you rebase the patch?

Fri, Jan 5, 6:28 AM
alexfh requested changes to D20689: [clang-tidy] Suspicious Call Argument checker.
Fri, Jan 5, 6:25 AM · Restricted Project
alexfh added a reviewer for D40580: [clang-tidy] Adding Fuchsia checker for multiple inheritance: ilya-biryukov.
Fri, Jan 5, 6:25 AM · Restricted Project
alexfh accepted D41716: clang-tidy: add IgnoreMacros option to readability-inconsistent-declaration-parameter-name.

Thus, looks good. Thanks!

Fri, Jan 5, 6:23 AM
alexfh added a comment to D41716: clang-tidy: add IgnoreMacros option to readability-inconsistent-declaration-parameter-name.

That changes the defaults though. I thought clang-tidy *tried* to produce the same results
on different clang-tidy versions with the same .clang-tidy config? Or is there no such guarantees?

Hmm, I see this as a trade-off between backwards compatibility and consistency. Here I went for consistency, so that all of readability-inconsistent-declaration-parameter-name, modernize-use-default-member-init and modernize-use-using default to IgnoreMacros=1. But I don't have a too strong opinion on that, can change the default to 0 if really wanted,

Fri, Jan 5, 6:22 AM
alexfh added a reviewer for D41720: [clang-tidy] Add a -show-color flag.: ilya-biryukov.
Fri, Jan 5, 6:07 AM · Restricted Project
alexfh requested changes to D41720: [clang-tidy] Add a -show-color flag..

Clang supports -fcolor-diagnostics. I guess, we could use it, e.g. via -extra-arg=-fcolor-diagnostics.

Fri, Jan 5, 6:06 AM · Restricted Project

Thu, Jan 4

alexfh added a reviewer for D41546: [clang-tidy] Adding Fuchsia checker for statically constructed objects: ilya-biryukov.
Thu, Jan 4, 5:19 AM · Restricted Project
alexfh added reviewers for D41655: [clang-tidy] New check bugprone-unused-return-value: ilya-biryukov, hokein.
Thu, Jan 4, 2:59 AM · Restricted Project
alexfh added reviewers for D41716: clang-tidy: add IgnoreMacros option to readability-inconsistent-declaration-parameter-name: hokein, ilya-biryukov.
Thu, Jan 4, 2:17 AM

Wed, Jan 3

alexfh added inline comments to D41708: [clang-tidy] Update fuchsia-overloaded-operator to check for valid loc.
Wed, Jan 3, 3:14 PM · Restricted Project

Dec 19 2017

alexfh added a comment to D41077: [analyser] different.CallArgsOrder checker implementation.
  1. FYI: There is a similar check under review which uses only the AST provided information and implemented as a tidy-checker: https://reviews.llvm.org/D20689 (As I see your checker does not uses symbolic execution provided features. So, it would probably worth thinking about if the analyzer is the project where the checker should be implemented. However, @dcoughlin and @alexfh have more insight on the answer to this question. What do you think? )
Dec 19 2017, 7:41 AM · Restricted Project
alexfh added a comment to D20689: [clang-tidy] Suspicious Call Argument checker.

Sorry, I lost this patch. I've looked at the results and it still seems that the signal-to-noise ratio is quite low. There's definitely potential in using parameter name and argument spelling to detect possibly swapped arguments, and there's a recent research on this topic, where authors claim to have reached the true positive rate of 85% with decent recall. See https://research.google.com/pubs/pub46317.html. If you're interested in working on this check, I would suggest at least looking at the techniques described in that paper.

Dec 19 2017, 5:58 AM · Restricted Project
alexfh added a reviewer for D20689: [clang-tidy] Suspicious Call Argument checker: ilya-biryukov.
Dec 19 2017, 5:38 AM · Restricted Project

Dec 15 2017

alexfh added a comment to D40671: [clang-tidy] Support specific checks for NOLINT directive.
In D40671#954906, @xgsa wrote:

FWIW, I think we should do something about unknown check names in NOLINT comments, but that can be done as a follow-up patch. If we're ignoring the comment, we might want to diagnose that fact so users have an idea what's going on.

IIUC, cpplint can output a diagnostic about unknown categories inside NOLINT and about NOLINT directives that happen on lines where no warning is emitted. Both would be useful in clang-tidy, IMO.

I agree with your statements and I think there should be the following diagnostics about NOLINT usage:

  • as you described, using of NOLINT with unknown check names;
  • using of NOLINT for the line, on which there is no diagnostics (at all with NOLINT and for the swpecified diagnostics); this should help to detect dangling NOLINT comments, that have no meaning anymore.

    Moreover, there should be a way to turn on/off these diagnostics, so possibily they should be a separate checks. What do you think? Is there a way for a check to collect the emitted diagnostics?
Dec 15 2017, 7:56 AM · Restricted Project

Dec 13 2017

alexfh accepted D40671: [clang-tidy] Support specific checks for NOLINT directive.
In D40671#949732, @xgsa wrote:

How are unknown check names handled? More specifically: will the // NOLINT(runtime/explicit) comment disable all clang-tidy checks or none?

None. If comment is syntactically correct and contains parenthesis, it works only for the known checks inside.

Still, I don't think it worth mentioning all the corner cases in documentation to keep things simple.

Dec 13 2017, 4:22 PM · Restricted Project

Dec 12 2017

alexfh added a comment to D39815: [clang-tidy] Improve the commented out variable in UnusedParametersCheck.
In D39815#948308, @oleg wrote:
In D39815#926427, @oleg wrote:

Sure, running clang-format makes complete sense, yet does it touch stuff inside the comments? AFAIK it leaves commented out blocks be...

Hmm, I thought it did touch comments (I thought it could re-flow comments for you, but I might have been dreaming that). If it doesn't, I would still rather see this be handled there rather than altering this fix-it to pick a different stylistic choice.

If you consider this formatting change to be important for a non-trivial amount of users, my first preference would be to implement an option in clang-format, and only this proposal gets rejected by clang-format maintainers, adding an option here.

Let me clarify - we are discussing a potential clang-format feature that would find these kinds of things:

void f(int a, int, int /*thing*/, int other /*some comment */) {

...

}

and then just fix arg #3? The problem would be quite different to that of clang-tidy which knows that it is commenting out an arg.

Dec 12 2017, 9:26 AM · Restricted Project

Dec 11 2017

alexfh committed rCTE320406: [clang-tidy] Correctly classify constant arrays and constant strings as….
[clang-tidy] Correctly classify constant arrays and constant strings as…
Dec 11 2017, 11:06 AM
alexfh committed rL320406: [clang-tidy] Correctly classify constant arrays and constant strings as….
[clang-tidy] Correctly classify constant arrays and constant strings as…
Dec 11 2017, 11:03 AM
alexfh closed D39363: [clang-tidy] Correctly classify constant arrays and constant strings as constants when checking identifiers naming by committing rL320406: [clang-tidy] Correctly classify constant arrays and constant strings as….
Dec 11 2017, 11:03 AM
alexfh added a comment to D41056: [clang-tidy] New check misc-uniqueptr-release-unused-retval.

May be bugprone is better module then misc?

Maybe. I can move it if all the reviewers think that it would be better suited there.

Dec 11 2017, 8:09 AM · Restricted Project

Dec 8 2017

alexfh accepted D39363: [clang-tidy] Correctly classify constant arrays and constant strings as constants when checking identifiers naming.

Looks good!

Dec 8 2017, 9:54 AM
alexfh added inline comments to D40625: Harmonizing attribute GNU/C++ spellings.
Dec 8 2017, 9:30 AM
alexfh added a comment to D40671: [clang-tidy] Support specific checks for NOLINT directive.
In D40671#945158, @xgsa wrote:

BTW, how will this feature interact with cpplint.py's way of handling specific NOLINT directives that use different lint rule names, which sometimes refer to the same rule (e.g. // NOLINT(runtime/explicit) suppresses the runtime/explicit cpplint rule that enforces the same style rule as the google-runtime-explicit check)?

This feature accepts only full check names.

Dec 8 2017, 9:19 AM · Restricted Project

Dec 7 2017

alexfh added a comment to D39815: [clang-tidy] Improve the commented out variable in UnusedParametersCheck.
In D39815#926427, @oleg wrote:

Sure, running clang-format makes complete sense, yet does it touch stuff inside the comments? AFAIK it leaves commented out blocks be...

Hmm, I thought it did touch comments (I thought it could re-flow comments for you, but I might have been dreaming that). If it doesn't, I would still rather see this be handled there rather than altering this fix-it to pick a different stylistic choice.

Dec 7 2017, 8:45 AM · Restricted Project
alexfh requested changes to D39815: [clang-tidy] Improve the commented out variable in UnusedParametersCheck.
Dec 7 2017, 8:42 AM · Restricted Project
alexfh added a comment to D39815: [clang-tidy] Improve the commented out variable in UnusedParametersCheck.

I would be against make this the default. Maybe provide it as an option?

Dec 7 2017, 8:41 AM · Restricted Project
alexfh added a comment to D39363: [clang-tidy] Correctly classify constant arrays and constant strings as constants when checking identifiers naming.

One nit. Otherwise seems fine.

Dec 7 2017, 7:15 AM
alexfh added a comment to D39363: [clang-tidy] Correctly classify constant arrays and constant strings as constants when checking identifiers naming.

Sorry for the delay. I missed this revision somehow. Please add cfe-commits to the subscribers list so that others can chime in.

Dec 7 2017, 7:11 AM
alexfh updated subscribers of D39363: [clang-tidy] Correctly classify constant arrays and constant strings as constants when checking identifiers naming.
Dec 7 2017, 7:10 AM

Dec 6 2017

alexfh requested changes to D39285: [clang-tidy] Misc redundant expression checker updated for ineffective bitwise operator expressions.
Dec 6 2017, 12:10 PM

Dec 5 2017

alexfh added a comment to D40671: [clang-tidy] Support specific checks for NOLINT directive.

BTW, how will this feature interact with cpplint.py's way of handling specific NOLINT directives that use different lint rule names, which sometimes refer to the same rule (e.g. // NOLINT(runtime/explicit) suppresses the runtime/explicit cpplint rule that enforces the same style rule as the google-runtime-explicit check)?

Dec 5 2017, 4:31 AM · Restricted Project

Dec 4 2017

alexfh added inline comments to D40671: [clang-tidy] Support specific checks for NOLINT directive.
Dec 4 2017, 2:45 AM · Restricted Project
alexfh added inline comments to D40671: [clang-tidy] Support specific checks for NOLINT directive.
Dec 4 2017, 2:38 AM · Restricted Project

Nov 30 2017

alexfh added inline comments to D40580: [clang-tidy] Adding Fuchsia checker for multiple inheritance.
Nov 30 2017, 9:33 AM · Restricted Project

Nov 29 2017

alexfh committed rCTE319325: [clang-tidy] make readability-simplify-bool-expr completely ignore macros.
[clang-tidy] make readability-simplify-bool-expr completely ignore macros
Nov 29 2017, 9:16 AM
alexfh committed rL319325: [clang-tidy] make readability-simplify-bool-expr completely ignore macros.
[clang-tidy] make readability-simplify-bool-expr completely ignore macros
Nov 29 2017, 9:16 AM
alexfh added a comment to D40108: [clang-tidy] Adding Fuchsia checkers to clang-tidy.

A couple of late comments.

Nov 29 2017, 6:40 AM · Restricted Project
alexfh requested changes to D40580: [clang-tidy] Adding Fuchsia checker for multiple inheritance.
Nov 29 2017, 6:11 AM · Restricted Project

Nov 28 2017

alexfh committed rL319183: [clang-tidy] Move more checks from misc- to performance-.
[clang-tidy] Move more checks from misc- to performance-
Nov 28 2017, 8:42 AM
alexfh committed rCTE319183: [clang-tidy] Move more checks from misc- to performance-.
[clang-tidy] Move more checks from misc- to performance-
Nov 28 2017, 8:41 AM
alexfh closed D40507: [clang-tidy] Move more checks from misc- to performance- by committing rCTE319183: [clang-tidy] Move more checks from misc- to performance-.
Nov 28 2017, 8:41 AM
alexfh added inline comments to D40507: [clang-tidy] Move more checks from misc- to performance-.
Nov 28 2017, 8:18 AM
alexfh updated the diff for D40507: [clang-tidy] Move more checks from misc- to performance-.
  • Add dependencies to prevent a link error
Nov 28 2017, 8:17 AM
alexfh updated the diff for D40507: [clang-tidy] Move more checks from misc- to performance-.
  • Reverted formatting in tests.
Nov 28 2017, 5:39 AM
alexfh updated the diff for D40507: [clang-tidy] Move more checks from misc- to performance-.
  • clang-format -style=llvm
Nov 28 2017, 5:34 AM

Nov 27 2017

alexfh committed rL319062: [clang-tidy] Rename qualified references to check class + support inconsistent….
[clang-tidy] Rename qualified references to check class + support inconsistent…
Nov 27 2017, 9:59 AM
alexfh committed rCTE319062: [clang-tidy] Rename qualified references to check class + support inconsistent….
[clang-tidy] Rename qualified references to check class + support inconsistent…
Nov 27 2017, 9:59 AM
alexfh created D40507: [clang-tidy] Move more checks from misc- to performance-.
Nov 27 2017, 9:58 AM
alexfh added a comment to D39803: [analyzer] pr34766: Fix a crash on explicit construction of std::initializer_list..

Is anything holding this patch?

Nov 27 2017, 7:25 AM
alexfh added a comment to D39800: [analyzer] pr34404: Fix a crash on pointers to members in nested anonymous structures..

Is anything holding this patch?

Nov 27 2017, 7:22 AM
alexfh committed rL319034: [clang-tidy] Fix link error in clang-tidy after the recent check renames..
[clang-tidy] Fix link error in clang-tidy after the recent check renames.
Nov 27 2017, 7:17 AM
alexfh committed rCTE319034: [clang-tidy] Fix link error in clang-tidy after the recent check renames..
[clang-tidy] Fix link error in clang-tidy after the recent check renames.
Nov 27 2017, 7:17 AM
alexfh committed rL319023: [clang-tidy] Move checks from misc- to performance-.
[clang-tidy] Move checks from misc- to performance-
Nov 27 2017, 5:07 AM
alexfh committed rCTE319023: [clang-tidy] Move checks from misc- to performance-.
[clang-tidy] Move checks from misc- to performance-
Nov 27 2017, 5:07 AM
alexfh closed D40487: [clang-tidy] Move checks from misc- to performance- by committing rCTE319023: [clang-tidy] Move checks from misc- to performance-.
Nov 27 2017, 5:07 AM
alexfh created D40487: [clang-tidy] Move checks from misc- to performance-.
Nov 27 2017, 4:52 AM
alexfh committed rCTE319021: [clang-tidy] readability-non-const-parameter fixes should update all….
[clang-tidy] readability-non-const-parameter fixes should update all…
Nov 27 2017, 4:46 AM
alexfh accepted D37482: run-clang-tidy: Use check_call instead of check_output.

LG, if this still works under Python 2.

Nov 27 2017, 4:46 AM
alexfh committed rL319021: [clang-tidy] readability-non-const-parameter fixes should update all….
[clang-tidy] readability-non-const-parameter fixes should update all…
Nov 27 2017, 4:42 AM

Nov 25 2017

alexfh committed rL318972: [clang-tidy] Fix link error (http://llvm.org/PR35417)..
[clang-tidy] Fix link error (http://llvm.org/PR35417).
Nov 25 2017, 12:53 AM
alexfh committed rCTE318972: [clang-tidy] Fix link error (http://llvm.org/PR35417)..
[clang-tidy] Fix link error (http://llvm.org/PR35417).
Nov 25 2017, 12:53 AM
alexfh committed rCTE318971: [clang-tidy] Actually fix header guard handling in scripts.
[clang-tidy] Actually fix header guard handling in scripts
Nov 25 2017, 12:50 AM
alexfh committed rL318971: [clang-tidy] Actually fix header guard handling in scripts.
[clang-tidy] Actually fix header guard handling in scripts
Nov 25 2017, 12:49 AM

Nov 24 2017

alexfh committed rL318951: [clang-tidy] rename_check.py: fix header guard handling.
[clang-tidy] rename_check.py: fix header guard handling
Nov 24 2017, 6:33 AM
alexfh committed rCTE318951: [clang-tidy] rename_check.py: fix header guard handling.
[clang-tidy] rename_check.py: fix header guard handling
Nov 24 2017, 6:33 AM
alexfh committed rCTE318950: [clang-tidy] Move a few more checks from misc to bugprone..
[clang-tidy] Move a few more checks from misc to bugprone.
Nov 24 2017, 6:18 AM
alexfh committed rL318950: [clang-tidy] Move a few more checks from misc to bugprone..
[clang-tidy] Move a few more checks from misc to bugprone.
Nov 24 2017, 6:17 AM
alexfh closed D40426: [clang-tidy] Move a few more checks from misc to bugprone. by committing rL318950: [clang-tidy] Move a few more checks from misc to bugprone..
Nov 24 2017, 6:16 AM
alexfh created D40426: [clang-tidy] Move a few more checks from misc to bugprone..
Nov 24 2017, 4:39 AM
alexfh committed rCTE318941: [clang-tidy] rename_check.py misc-dangling-handle bugprone-dangling-handle.
[clang-tidy] rename_check.py misc-dangling-handle bugprone-dangling-handle
Nov 24 2017, 1:54 AM
alexfh committed rL318941: [clang-tidy] rename_check.py misc-dangling-handle bugprone-dangling-handle.
[clang-tidy] rename_check.py misc-dangling-handle bugprone-dangling-handle
Nov 24 2017, 1:53 AM
alexfh closed D40389: [clang-tidy] rename_check.py misc-dangling-handle bugprone-dangling-handle by committing rL318941: [clang-tidy] rename_check.py misc-dangling-handle bugprone-dangling-handle.
Nov 24 2017, 1:53 AM

Nov 23 2017

alexfh committed rCTE318926: [clang-tidy] rename_check.py misc-argument-comment bugprone-argument-comment.
[clang-tidy] rename_check.py misc-argument-comment bugprone-argument-comment
Nov 23 2017, 9:03 AM
alexfh committed rL318926: [clang-tidy] rename_check.py misc-argument-comment bugprone-argument-comment.
[clang-tidy] rename_check.py misc-argument-comment bugprone-argument-comment
Nov 23 2017, 9:03 AM
alexfh closed D40392: [clang-tidy] rename_check.py misc-argument-comment bugprone-argument-comment by committing rL318926: [clang-tidy] rename_check.py misc-argument-comment bugprone-argument-comment.
Nov 23 2017, 9:03 AM
alexfh created D40392: [clang-tidy] rename_check.py misc-argument-comment bugprone-argument-comment.
Nov 23 2017, 7:05 AM
alexfh committed rL318922: [clang-tidy] rename_check.py: fix a bug in check presence detection.
[clang-tidy] rename_check.py: fix a bug in check presence detection
Nov 23 2017, 7:01 AM
alexfh committed rCTE318922: [clang-tidy] rename_check.py: fix a bug in check presence detection.
[clang-tidy] rename_check.py: fix a bug in check presence detection
Nov 23 2017, 7:00 AM
alexfh committed rL318918: [clang-tidy] rename_check.py: Update '=====...' line in the docs..
[clang-tidy] rename_check.py: Update '=====...' line in the docs.
Nov 23 2017, 6:06 AM
alexfh committed rCTE318918: [clang-tidy] rename_check.py: Update '=====...' line in the docs..
[clang-tidy] rename_check.py: Update '=====...' line in the docs.
Nov 23 2017, 6:06 AM
alexfh created D40389: [clang-tidy] rename_check.py misc-dangling-handle bugprone-dangling-handle.
Nov 23 2017, 6:04 AM
alexfh committed rCTE318916: [clang-tidy] rename_check.py misc-string-constructor bugprone-string-constructor.
[clang-tidy] rename_check.py misc-string-constructor bugprone-string-constructor
Nov 23 2017, 5:50 AM
alexfh committed rL318916: [clang-tidy] rename_check.py misc-string-constructor bugprone-string-constructor.
[clang-tidy] rename_check.py misc-string-constructor bugprone-string-constructor
Nov 23 2017, 5:50 AM
alexfh closed D40388: [clang-tidy] rename_check.py misc-string-constructor bugprone-string-constructor by committing rL318916: [clang-tidy] rename_check.py misc-string-constructor bugprone-string-constructor.
Nov 23 2017, 5:50 AM