Page MenuHomePhabricator

alexfh (Alexander Kornienko)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 10 2012, 10:35 AM (458 w, 6 h)

Recent Activity

Mon, Apr 12

alexfh committed rG8a944d82cd14: [clang-tidy] Add option to ignore macros in readability-function-cognitive… (authored by massberg).
[clang-tidy] Add option to ignore macros in readability-function-cognitive…
Mon, Apr 12, 9:47 AM
alexfh committed rG8883cb3e4004: Fix nits. (authored by alexfh).
Fix nits.
Mon, Apr 12, 9:47 AM
alexfh closed D98070: [clang-tidy] Add option to ignore macros in readability-function-cognitive-complexity check..
Mon, Apr 12, 9:46 AM · Restricted Project, Restricted Project
alexfh accepted D98070: [clang-tidy] Add option to ignore macros in readability-function-cognitive-complexity check..

LG with a couple of nits.

Mon, Apr 12, 9:13 AM · Restricted Project, Restricted Project

Mar 10 2021

alexfh committed rG481079e2841f: [NFC] Unify FIME with FIXME in comments (authored by b1f6c1c4).
[NFC] Unify FIME with FIXME in comments
Mar 10 2021, 5:13 AM
alexfh closed D98321: [NFC] Unify FIME with FIXME in comments.
Mar 10 2021, 5:12 AM · Restricted Project, Restricted Project
alexfh accepted D98321: [NFC] Unify FIME with FIXME in comments.

Looks good. Thanks for the fix! I'll get it landed for you.

Mar 10 2021, 4:57 AM · Restricted Project, Restricted Project

Feb 23 2021

alexfh added a comment to D97288: Added `Follow` parameter to llvm::vfs::FileSystem::status().

How strong is the need for this?
This adds complexity to a widely implemented and used interface, and the combination of virtual + default parameters can be at least a little confusing.

Feb 23 2021, 4:44 PM · Restricted Project, Restricted Project
alexfh requested review of D97288: Added `Follow` parameter to llvm::vfs::FileSystem::status().
Feb 23 2021, 7:00 AM · Restricted Project, Restricted Project

Feb 17 2021

alexfh accepted D96874: tsan: fix mmap_lots test.

LG. Thanks for the fix!

Feb 17 2021, 9:48 AM

Feb 13 2021

alexfh added inline comments to D96281: [clang-tidy] Add options to describe individual core increments to readability-function-cognitive-complexity check..
Feb 13 2021, 5:12 PM · Restricted Project, Restricted Project
alexfh added inline comments to D96542: [clang-tidy] Fix `TransformerClangTidyCheck`'s handling of include insertions..
Feb 13 2021, 4:58 PM · Restricted Project, Restricted Project

Feb 10 2021

alexfh added inline comments to D96281: [clang-tidy] Add options to describe individual core increments to readability-function-cognitive-complexity check..
Feb 10 2021, 7:50 AM · Restricted Project, Restricted Project

Feb 3 2021

alexfh added inline comments to D90851: [clang-tidy] Extending bugprone-signal-handler with POSIX functions..
Feb 3 2021, 4:25 PM · Restricted Project, Restricted Project
alexfh added a comment to D95403: [clang-tidy][analyzer][WIP] Clang-tidy reverse integration into Static Analyzer..

Artem, could you set the repository to rG LLVM Github Monorepo when uploading patches as mentioned in https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface ? This way you'll allow pre-merge checks to run.

Feb 3 2021, 3:37 PM · Restricted Project

Jan 29 2021

alexfh set the repository for D95403: [clang-tidy][analyzer][WIP] Clang-tidy reverse integration into Static Analyzer. to rG LLVM Github Monorepo.
Jan 29 2021, 5:59 AM · Restricted Project
alexfh set the repository for D94476: [analyzer] Implement conversion from Clang diagnostics to PathDiagnostics. to rG LLVM Github Monorepo.
Jan 29 2021, 5:59 AM · Restricted Project

Jan 28 2021

alexfh added inline comments to D95403: [clang-tidy][analyzer][WIP] Clang-tidy reverse integration into Static Analyzer..
Jan 28 2021, 6:50 PM · Restricted Project
alexfh accepted D95515: [clang-tidy] bugprone-assert-side-effect: Improve warning message..

Thanks, looks good!

Jan 28 2021, 5:58 PM · Restricted Project
alexfh requested changes to D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--).

Apologies again for the long delay.

Jan 28 2021, 5:57 PM · Restricted Project, Restricted Project
alexfh requested changes to D89380: [clang-tidy] Fix for cppcoreguidelines-prefer-member-initializer to handle classes declared in macros.
Jan 28 2021, 5:45 PM · Restricted Project, Restricted Project
alexfh accepted D94420: [clang-tooling] Prevent llvm::fatal_error on invalid CLI option.

Thanks! Looks good now.

Jan 28 2021, 5:34 PM · Restricted Project
alexfh accepted D95562: [ASTMatchers] Fix traversal below range-for elements.

Looks good!

Jan 28 2021, 5:31 PM · Restricted Project
alexfh accepted D95607: Fix traversal with hasDescendant into lambdas.

Looks good!

Jan 28 2021, 5:26 PM · Restricted Project
alexfh committed rGab2d3ce47d6f: [clang-tidy] Applied clang-tidy fixes. NFC (authored by alexfh).
[clang-tidy] Applied clang-tidy fixes. NFC
Jan 28 2021, 4:01 PM
alexfh closed D95614: [clang-tidy] Applied clang-tidy fixes. NFC.
Jan 28 2021, 4:01 PM · Restricted Project
alexfh updated the diff for D95614: [clang-tidy] Applied clang-tidy fixes. NFC.

Trying to upload complete patch.

Jan 28 2021, 3:57 PM · Restricted Project
alexfh added inline comments to D95614: [clang-tidy] Applied clang-tidy fixes. NFC.
Jan 28 2021, 3:51 PM · Restricted Project
alexfh updated the diff for D95614: [clang-tidy] Applied clang-tidy fixes. NFC.

Manually cleaned up suboptimal fixes.

Jan 28 2021, 3:51 PM · Restricted Project
alexfh requested review of D95614: [clang-tidy] Applied clang-tidy fixes. NFC.
Jan 28 2021, 6:42 AM · Restricted Project
alexfh committed rGdfd2374ab6c3: [clang-tidy] Remove unnecessary #ifdef (authored by alexfh).
[clang-tidy] Remove unnecessary #ifdef
Jan 28 2021, 6:00 AM
alexfh added a comment to D95573: [ASTMatchers] Avoid pathological traversal over nested lambdas.

Thanks for the prompt fix, btw!

Jan 28 2021, 4:09 AM · Restricted Project
alexfh accepted D95573: [ASTMatchers] Avoid pathological traversal over nested lambdas.

This fixes the issue with exponential traversal times for deeply nested lambdas. Please add a test though. For example, this one:

Jan 28 2021, 4:06 AM · Restricted Project

Jan 27 2021

alexfh added a comment to D93688: [ASTMatchers] Ensure that we can match inside lambdas.

This patch causes practically infinite traversal times on code that contains deeply nested lambdas. I'll try to get a suitable repro, but could you maybe revert this in the meantime?

Jan 27 2021, 2:36 PM · Restricted Project
alexfh added a comment to D93688: [ASTMatchers] Ensure that we can match inside lambdas.

This patch causes practically infinite traversal times on code that contains deeply nested lambdas. I'll try to get a suitable repro, but could you maybe revert this in the meantime?

Jan 27 2021, 11:07 AM · Restricted Project

Jan 19 2021

alexfh added inline comments to D91303: [clang-tidy] readability-container-size-empty: simplify implementation.
Jan 19 2021, 6:02 PM · Restricted Project
alexfh accepted D91303: [clang-tidy] readability-container-size-empty: simplify implementation.

LG

Jan 19 2021, 5:58 PM · Restricted Project
alexfh requested changes to D94420: [clang-tooling] Prevent llvm::fatal_error on invalid CLI option.

This is quite a bit of extra boilerplate, but it results in a more transparent error handling. However, the documentation would need to be changed (clang/docs/LibASTMatchersTutorial.rst). And what about other tools (e.g. clang-tools-extra/clang-include-fixer/tool/ClangIncludeFixer.cpp, clang-tools-extra/clang-include-fixer/find-all-symbols/tool/FindAllSymbolsMain.cpp, etc.)?

Jan 19 2021, 5:51 PM · Restricted Project

Dec 14 2020

alexfh requested changes to D91303: [clang-tidy] readability-container-size-empty: simplify implementation.

Pre-merge builder can't apply this patch: https://buildkite.com/llvm-project/diff-checks/builds/18651
Is it based on https://reviews.llvm.org/D91302 ? Do we need the intermediate state? Maybe squash the two patches together for simplicity?

Dec 14 2020, 5:29 PM · Restricted Project
alexfh requested changes to D91302: Handle template instantiations better in clang-tidy check.

Please fix the typo that results in a compile error.

Dec 14 2020, 5:24 PM · Restricted Project
alexfh committed rG9c49b0bba0fc: Remove the ast_type_traits namespace. (authored by alexfh).
Remove the ast_type_traits namespace.
Dec 14 2020, 5:16 PM
alexfh closed D93244: Remove the ast_type_traits namespace..
Dec 14 2020, 5:16 PM · Restricted Project
alexfh requested review of D93244: Remove the ast_type_traits namespace..
Dec 14 2020, 2:09 PM · Restricted Project

Dec 11 2020

alexfh committed rG4c5e0c7fd801: Remove references to the ast_type_traits namespace (authored by alexfh).
Remove references to the ast_type_traits namespace
Dec 11 2020, 3:41 AM

Dec 10 2020

alexfh committed rG027899dab6ac: Remove references to the ast_type_traits namespace (authored by alexfh).
Remove references to the ast_type_traits namespace
Dec 10 2020, 3:59 PM
alexfh closed D92994: Remove references to the ast_type_traits namespace.
Dec 10 2020, 3:59 PM · Restricted Project
alexfh updated the diff for D92994: Remove references to the ast_type_traits namespace.

Removed unrelated whitespace changes.

Dec 10 2020, 3:56 PM · Restricted Project
alexfh added a reviewer for D92994: Remove references to the ast_type_traits namespace: sammccall.
Dec 10 2020, 4:36 AM · Restricted Project

Dec 9 2020

alexfh requested review of D92994: Remove references to the ast_type_traits namespace.
Dec 9 2020, 7:45 PM · Restricted Project

Nov 12 2020

alexfh committed rG76b6cb515b2f: Fix unused variable warning in release builds (authored by alexfh).
Fix unused variable warning in release builds
Nov 12 2020, 9:14 AM
alexfh committed rGa196e8092a9e: [lld] Use temporary directory to create test outputs (authored by alexfh).
[lld] Use temporary directory to create test outputs
Nov 12 2020, 5:24 AM

Oct 26 2020

alexfh added a comment to D80499: Remove obsolete ignore*() matcher uses.

@alexfh This change is based on the behavior of AST Matchers being changed to ignore invisible/implicit AST nodes by default. As the default was not changed in the end, this patch would need to be updated to add traverse(TK_IgnoreUnlessSpelledInSource) wrapping around the matchers.

Before I update the patch to add that, do you have any feedback?

Oct 26 2020, 4:04 AM · Restricted Project

Oct 22 2020

alexfh accepted D89886: [clang-tidy] Fix redefinition of module in the same module.modulemap file.

Ah, btw, any chance of adding a test for this?

Oh, I was not able to create small reproducer that without including large Apple Frameworks with modules :( My hypothesis that it is side effect of module cache that triggers module load before it is referenced from sources. I tested it on reproducer from PR47839 + my real internal example.

Oct 22 2020, 3:06 PM · Restricted Project, Restricted Project
alexfh committed rG37558fd29ee0: [clang-tidy] Add links to check docs in comments (authored by alexfh).
[clang-tidy] Add links to check docs in comments
Oct 22 2020, 4:31 AM
alexfh added inline comments to D89380: [clang-tidy] Fix for cppcoreguidelines-prefer-member-initializer to handle classes declared in macros.
Oct 22 2020, 4:23 AM · Restricted Project, Restricted Project
alexfh added a comment to D89886: [clang-tidy] Fix redefinition of module in the same module.modulemap file.

Ah, btw, any chance of adding a test for this?

Oct 22 2020, 4:12 AM · Restricted Project, Restricted Project
alexfh accepted D89886: [clang-tidy] Fix redefinition of module in the same module.modulemap file.

Looks good!

Oct 22 2020, 4:11 AM · Restricted Project, Restricted Project

Oct 15 2020

alexfh committed rGcc175c2cc8e6: Support ObjC in IncludeInserter (authored by alexfh).
Support ObjC in IncludeInserter
Oct 15 2020, 7:15 PM
alexfh closed D89276: Support ObjC in IncludeInserter.
Oct 15 2020, 7:15 PM · Restricted Project, Restricted Project, Restricted Project
alexfh accepted D89276: Support ObjC in IncludeInserter.

LG

Oct 15 2020, 11:46 AM · Restricted Project, Restricted Project, Restricted Project

Oct 14 2020

alexfh requested changes to D89380: [clang-tidy] Fix for cppcoreguidelines-prefer-member-initializer to handle classes declared in macros.
Oct 14 2020, 7:08 AM · Restricted Project, Restricted Project
alexfh added a comment to D89380: [clang-tidy] Fix for cppcoreguidelines-prefer-member-initializer to handle classes declared in macros.

Thanks for the fix! However, I'm not sure it's possible to correctly rewrite code in all cases where macros are involved. See a couple of motivating examples in the comment.

Oct 14 2020, 7:06 AM · Restricted Project, Restricted Project

Oct 13 2020

alexfh added reviewers for D89276: Support ObjC in IncludeInserter: ymandel, gribozavr2.
Oct 13 2020, 5:58 AM · Restricted Project, Restricted Project, Restricted Project

Oct 12 2020

alexfh abandoned D2660: Store warning option for custom diagnostic messages..
Oct 12 2020, 7:26 AM
alexfh abandoned D5602: [clang-tidy] Add support for boolean check options..
Oct 12 2020, 7:08 AM
alexfh abandoned D5830: [clang-tidy] Alternative approach to OptionsView::get.
Oct 12 2020, 7:07 AM
alexfh abandoned D6580: Add a way to tell MatchFinder not to visit template instantiations and implicit code..
Oct 12 2020, 6:59 AM
alexfh abandoned D31763: TEST git+phab+binary files.
Oct 12 2020, 6:58 AM
alexfh requested changes to D55346: [clang-tidy] check for using declaration qualification.
Oct 12 2020, 6:57 AM · Restricted Project
alexfh requested changes to D48866: [clang-tidy] Add incorrect-pointer-cast checker.
Oct 12 2020, 6:57 AM · Restricted Project
alexfh requested changes to D42682: [clang-tidy] Add io-functions-misused checker.
Oct 12 2020, 6:56 AM · Restricted Project
alexfh requested changes to D33841: [clang-tidy] redundant 'extern' keyword check.
Oct 12 2020, 6:55 AM · Restricted Project
alexfh requested changes to D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--).
Oct 12 2020, 6:42 AM · Restricted Project, Restricted Project
alexfh added a comment to D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--).

Sorry for the delay. This patch fell through the cracks. If you're still interested, could you rebase it on top of current HEAD and upload a full diff? Or use the arcanist tool, see https://llvm.org/docs/Phabricator.html.

Oct 12 2020, 6:41 AM · Restricted Project, Restricted Project
alexfh accepted D82089: [clang-tidy] modernize-loop-convert reverse iteration support.

Looks good!

Oct 12 2020, 6:36 AM · Restricted Project
alexfh added a comment to D79674: [clang-tidy] Better support for Override function in RenamerClangTidy based checks.

Feel free to ping patches every week or so. It looks like in this case all the reviewers were swamped with something else at the time.

Oct 12 2020, 6:32 AM · Restricted Project
alexfh accepted D79674: [clang-tidy] Better support for Override function in RenamerClangTidy based checks.

Looks good! Thanks for the fix! IIUC, this is related to https://bugs.llvm.org/show_bug.cgi?id=34879? Makes sense to specify this in the patch description.

Oct 12 2020, 6:31 AM · Restricted Project
alexfh committed rG1968a6155fd5: [clang-tidy] Fix IncludeInserter usage example in a comment. (authored by alexfh).
[clang-tidy] Fix IncludeInserter usage example in a comment.
Oct 12 2020, 6:06 AM

Oct 9 2020

alexfh committed rGfe4715c47f9c: Remove old create(MainFile)?IncludeInsertion overloads (authored by alexfh).
Remove old create(MainFile)?IncludeInsertion overloads
Oct 9 2020, 6:25 AM
alexfh closed D89117: Remove old create(MainFile)?IncludeInsertion overloads.
Oct 9 2020, 6:25 AM · Restricted Project
alexfh requested review of D89117: Remove old create(MainFile)?IncludeInsertion overloads.
Oct 9 2020, 4:50 AM · Restricted Project

Sep 28 2020

alexfh committed rGfdfe324da195: [clang-tidy] IncludeInserter: allow <> in header name (authored by alexfh).
[clang-tidy] IncludeInserter: allow <> in header name
Sep 28 2020, 6:14 AM
alexfh closed D85666: [clang-tidy] IncludeInserter: allow <> in header name.
Sep 28 2020, 6:14 AM · Restricted Project
alexfh updated the diff for D85666: [clang-tidy] IncludeInserter: allow <> in header name.
  • Updated release notes and default option values in docs
Sep 28 2020, 5:59 AM · Restricted Project
alexfh added inline comments to D85666: [clang-tidy] IncludeInserter: allow <> in header name.
Sep 28 2020, 5:18 AM · Restricted Project
alexfh updated the diff for D85666: [clang-tidy] IncludeInserter: allow <> in header name.
  • clang-format
  • addressed review comments
Sep 28 2020, 5:18 AM · Restricted Project

Sep 14 2020

alexfh accepted D83144: Allow to specify macro names for android-comparison-in-temp-failure-retry..

Looks good modulo comment.

Sep 14 2020, 1:15 AM · Restricted Project

Aug 10 2020

alexfh added inline comments to D82089: [clang-tidy] modernize-loop-convert reverse iteration support.
Aug 10 2020, 10:24 AM · Restricted Project
alexfh requested review of D85666: [clang-tidy] IncludeInserter: allow <> in header name.
Aug 10 2020, 10:23 AM · Restricted Project
alexfh removed a reviewer for D81254: [analyzer] Produce symbolic values for C-array elements: alexfh.
Aug 10 2020, 8:48 AM · Restricted Project
alexfh accepted D85218: In clang-tidy base checks prevent anonymous functions from triggering assertions.

LG with a couple of comments. Do you need someone to land the patch for you?

Aug 10 2020, 8:45 AM · Restricted Project, Restricted Project
alexfh requested changes to D82089: [clang-tidy] modernize-loop-convert reverse iteration support.

Thanks for the patch! Looks generally good. A few comments inline.

Aug 10 2020, 6:29 AM · Restricted Project

Jul 21 2020

alexfh added a comment to D83223: [clang-tidy] Header guard check can skip past license comment.
 // This is not identified as a license comment as the
// block is followed by code.
void foo();

FWIW: https://github.com/GrammaTech/gtirb-pprinter/blob/master/include/gtirb_pprinter/AttPrettyPrinter.hpp or https://github.com/GrammaTech/gtirb/blob/master/include/gtirb/AuxData.hpp (so there are projects which do not put a newline between the license and code).

Short of creating an AI that understands context it won't be possible to determine the difference between license and general documentation, in any case I feel this heuristic is the safest way to ensure good coverage with minimised risk of inserting the guard in the middle of documentation,

My instinct is that we shouldn't be trying to play those games in the first place and should consider *all* leading comments and empty (whitespace-only) lines as part of the "license" and expect the first significant token to be the header guard. e.g., this isn't about the license at all, it's about whether you can have prose before the header guard or not. It's not uncommon for projects to put prose before header guards, nor is it uncommon for it to go after the header guards. tbh, that feels a bit like an option for the feature rather than an automatic behavior because I could also see a project wanting to enforce a consistent style.

Jul 21 2020, 2:15 AM · Restricted Project

Apr 13 2020

alexfh added inline comments to D77983: clang-tidy doc: add a note for every checker with an autofix.
Apr 13 2020, 5:52 AM · Restricted Project, Restricted Project
alexfh accepted D75184: [clang-tidy] Optional inheritance of file configs from parent directories .

Apologies for the delay! It's sort of a crazy time now =\

Apr 13 2020, 5:20 AM · Restricted Project, Restricted Project

Apr 12 2020

alexfh committed rG8dda0f919959: Remove dependency between test files. (authored by alexfh).
Remove dependency between test files.
Apr 12 2020, 9:23 PM

Mar 19 2020

alexfh added a comment to D75184: [clang-tidy] Optional inheritance of file configs from parent directories .

You are absolutely right about current behaviour. Thank you for catching this odd behaviour. I'm not 100% confident what is the right behaviour but my guess is that overriding local option from parent config with global from child folder is better so I implemented it and added corresponding test.

It's a tricky one that, but I thing overriding the local option with the global in the sub directory is the correct way to go about this as well.

Mar 19 2020, 9:22 PM · Restricted Project, Restricted Project

Mar 12 2020

alexfh added inline comments to D75911: [clang-tidy] Added hasAnyListedName matcher.
Mar 12 2020, 4:51 PM · Restricted Project, Restricted Project
alexfh added inline comments to D76083: [clang-tidy] Expand the list of functions in bugprone-unused-return-value.
Mar 12 2020, 3:12 PM · Restricted Project

Mar 5 2020

alexfh added inline comments to D75538: [clang-tidy] Updated language supported restrictions on some checks.
Mar 5 2020, 4:56 AM · Restricted Project