- User Since
- Jul 10 2012, 10:35 AM (458 w, 6 h)
Mon, Apr 12
LG with a couple of nits.
Mar 10 2021
Looks good. Thanks for the fix! I'll get it landed for you.
Feb 23 2021
Feb 17 2021
Feb 13 2021
Feb 10 2021
Feb 3 2021
Artem, could you set the repository to rG LLVM Github Monorepo when uploading patches as mentioned in https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface ? This way you'll allow pre-merge checks to run.
Jan 29 2021
Jan 28 2021
Thanks, looks good!
Apologies again for the long delay.
Thanks! Looks good now.
Trying to upload complete patch.
Manually cleaned up suboptimal fixes.
Thanks for the prompt fix, btw!
This fixes the issue with exponential traversal times for deeply nested lambdas. Please add a test though. For example, this one:
Jan 27 2021
This patch causes practically infinite traversal times on code that contains deeply nested lambdas. I'll try to get a suitable repro, but could you maybe revert this in the meantime?
Jan 19 2021
This is quite a bit of extra boilerplate, but it results in a more transparent error handling. However, the documentation would need to be changed (clang/docs/LibASTMatchersTutorial.rst). And what about other tools (e.g. clang-tools-extra/clang-include-fixer/tool/ClangIncludeFixer.cpp, clang-tools-extra/clang-include-fixer/find-all-symbols/tool/FindAllSymbolsMain.cpp, etc.)?
Dec 14 2020
Pre-merge builder can't apply this patch: https://buildkite.com/llvm-project/diff-checks/builds/18651
Is it based on https://reviews.llvm.org/D91302 ? Do we need the intermediate state? Maybe squash the two patches together for simplicity?
Please fix the typo that results in a compile error.
Dec 11 2020
Dec 10 2020
Removed unrelated whitespace changes.
Dec 9 2020
Nov 12 2020
Oct 26 2020
Oct 22 2020
Ah, btw, any chance of adding a test for this?
Oct 15 2020
Oct 14 2020
Thanks for the fix! However, I'm not sure it's possible to correctly rewrite code in all cases where macros are involved. See a couple of motivating examples in the comment.
Oct 13 2020
Oct 12 2020
Sorry for the delay. This patch fell through the cracks. If you're still interested, could you rebase it on top of current HEAD and upload a full diff? Or use the arcanist tool, see https://llvm.org/docs/Phabricator.html.
Feel free to ping patches every week or so. It looks like in this case all the reviewers were swamped with something else at the time.
Looks good! Thanks for the fix! IIUC, this is related to https://bugs.llvm.org/show_bug.cgi?id=34879? Makes sense to specify this in the patch description.
Oct 9 2020
Sep 28 2020
- Updated release notes and default option values in docs
- addressed review comments
Sep 14 2020
Looks good modulo comment.
Aug 10 2020
LG with a couple of comments. Do you need someone to land the patch for you?
Thanks for the patch! Looks generally good. A few comments inline.
Jul 21 2020
Apr 13 2020
Apologies for the delay! It's sort of a crazy time now =\