- User Since
- Jul 10 2012, 10:35 AM (245 w, 4 d)
Fri, Mar 24
FWIW, I'm pretty sure this can and should be done on the lexer level - it will be faster and more universal.
So I would propose to keep the features as-is for now,
change the name to readability-operators-representation, and then later (someone else?) might also add an option
for making this work the other way around. Would that be ok for you?
Thu, Mar 23
Krystyna, do you need help committing the patch after you address the outstanding comments?
Do you have commit rights?
Wed, Mar 22
A late comment here: the check seems to suit better readability module instead of misc. Could you move it there?
There's one more trim() you missed. And the test needs to be updated (s/\\n/ /).
A couple of nits, otherwise looks good. Do you need me to commit the patch for you?
Mon, Mar 20
Sat, Mar 18
Fri, Mar 17
Could you generate a diff with full context (http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface)?
Do you have commit rights?
Thu, Mar 16
Thank you for the fix! One comment inline.
Tue, Mar 14
BTW, next time please add cfe-commits to subscribers when you create the patch to get it sent properly to the mailing list.
I understand your use case, but this patch makes the check's behavior more confusing: having both "any case" and "ignore case" with subtle differences in behavior seems very misleading. The problem seems to be coming from the usage of CT_AnyCase to denote uninitialized style. Should we just remove NamingStyle::isSet and use llvm::Optional<NamingStyle> instead of NamingStyle where appropriate?
Sun, Mar 12
Sat, Mar 11
Thu, Mar 9
Wed, Mar 8
Mon, Mar 6
LG. So you won the flappy column game? ;)
Sun, Mar 5
Actually, I'm not sure why we need groups in that regex. We can instead try replacing re.compile('(' + ')|('.join(args.files) + ')') with re.compile('|'.join(args.files)).
https://docs.python.org/2/howto/regex.html#introduction says "The regex module was removed completely in Python 2.5.". Why would we want to switch to it?
Fri, Mar 3
What's the practical use of newlines and tab characters in the glob list?
Apply changes even when formatting fails.
Clarify the 'file' option a bit.
Expanded -format-style option description. Run cleanup tests with different format styles, just in case.
Replace the separate -format and -style options with -format-style (default is
'none', which means no formatting).
Pacify llvm::Expected<> debug checks.
Thu, Mar 2
Do you need someone to commit the patch for you?
LG unless Etienne has any concerns.
Wed, Mar 1
I think, we decided to extend the AST instead of working around its incompleteness.
This patch is superseded by D26137.
This was committed a while ago as r290340.