alexfh (Alexander Kornienko)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 10 2012, 10:35 AM (327 w, 2 d)

Recent Activity

Tue, Oct 16

alexfh edited reviewers for D53339: [clang-tidy] Add the abseil-duration-factory-float check, added: hokein, aaron.ballman; removed: alexfh_.
Tue, Oct 16, 4:53 PM · Restricted Project
alexfh added a comment to D53339: [clang-tidy] Add the abseil-duration-factory-float check.

LG In general, but see a few comments inline.

Tue, Oct 16, 4:52 PM · Restricted Project

Fri, Oct 12

alexfh accepted D53217: [clang-tidy] add IgnoreMacros option to modernize-use-equals-delete.

LG with a nit.

Fri, Oct 12, 5:50 PM · Restricted Project

Tue, Oct 9

alexfh committed rCTE344058: [clang-tidy] Fix handling of parens around new expressions in make_<smartptr>….
[clang-tidy] Fix handling of parens around new expressions in make_<smartptr>…
Tue, Oct 9, 9:00 AM
alexfh committed rL344058: [clang-tidy] Fix handling of parens around new expressions in make_<smartptr>….
[clang-tidy] Fix handling of parens around new expressions in make_<smartptr>…
Tue, Oct 9, 9:00 AM
alexfh closed D52989: [clang-tidy] Fix handling of parens around new expressions in make_<smartptr> checks..
Tue, Oct 9, 9:00 AM
alexfh added inline comments to D52989: [clang-tidy] Fix handling of parens around new expressions in make_<smartptr> checks..
Tue, Oct 9, 8:58 AM
alexfh updated the diff for D52989: [clang-tidy] Fix handling of parens around new expressions in make_<smartptr> checks..
  • Remove recursion, use auto.
Tue, Oct 9, 8:58 AM

Mon, Oct 8

alexfh created D52989: [clang-tidy] Fix handling of parens around new expressions in make_<smartptr> checks..
Mon, Oct 8, 9:36 AM
alexfh removed a reviewer for D52690: [clang-tidy] NFC use CHECK-NOTES in tests for misc-misplaced-const: alexfh. alexfh added 1 blocking reviewer(s) for D52690: [clang-tidy] NFC use CHECK-NOTES in tests for misc-misplaced-const: aaron.ballman.
Mon, Oct 8, 5:10 AM
alexfh accepted D52971: [clang-tidy] Customize FileCheck prefix in check_clang-tidy.py to support multiple prefixes.

Looks good with a comment.

Mon, Oct 8, 5:08 AM · Restricted Project

Fri, Oct 5

alexfh accepted D52684: [clang-tidy] NFC refactor lexer-utils to be usable without ASTContext.

This patch is related to https://reviews.llvm.org/D51949

To isolate variable declarations (split int * p, v; up) it is necessary to do a lot of work with source location and requires some forward and backwards lexing. The functions there just use the LangOpts and the SourceManager and don't have a ASTContext available, that why I changed this interface.

Fri, Oct 5, 7:09 AM · Restricted Project

Thu, Oct 4

alexfh accepted D51332: [clang-tidy] Replace deprecated std::ios_base aliases.

LG once other comments are addressed.

Thu, Oct 4, 8:02 AM
alexfh accepted D52688: [clang-tidy] NFC use CHECK-NOTES in tests for fuchsia-default-arguments.

LG

Thu, Oct 4, 7:56 AM
alexfh accepted D52882: [clang-tidy] Added pointer types to clang-tidy readability-identifier-naming check..

LG

Thu, Oct 4, 7:55 AM
alexfh accepted D52691: [clang-tidy] NFC use CHECK-NOTES in tests for performance-move-constructor-init.

LG. Thanks

Thu, Oct 4, 7:52 AM
alexfh accepted D52880: [clang-tidy] fix PR39167, bugprone-exception-escape hangs-up.

Have you figured out why exactly does the check hang? Disabling it for -fno-exceptions may just hide a logical problem in the check.

Thu, Oct 4, 7:52 AM
alexfh added a comment to D52880: [clang-tidy] fix PR39167, bugprone-exception-escape hangs-up.

Have you figured out why exactly does the check hang? Disabling it for -fno-exceptions may just hide a logical problem in the check.

Thu, Oct 4, 7:48 AM

Tue, Oct 2

alexfh committed rL343578: [clang-tidy] Ignore singe bit bitfield -> bool conversion in readability….
[clang-tidy] Ignore singe bit bitfield -> bool conversion in readability…
Tue, Oct 2, 4:41 AM
alexfh committed rCTE343578: [clang-tidy] Ignore singe bit bitfield -> bool conversion in readability….
[clang-tidy] Ignore singe bit bitfield -> bool conversion in readability…
Tue, Oct 2, 4:41 AM

Mon, Oct 1

alexfh requested changes to D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--).
Mon, Oct 1, 8:17 AM · Restricted Project
alexfh requested changes to D36836: [clang-tidy] Implement sonarsource-function-cognitive-complexity check.

Anything new here? Is there a LLVM foundation lawyer or something like that we can ask?

Mon, Oct 1, 6:19 AM · Restricted Project
alexfh added inline comments to D52690: [clang-tidy] NFC use CHECK-NOTES in tests for misc-misplaced-const.
Mon, Oct 1, 6:16 AM
alexfh accepted D52687: [clang-tidy] NFC use CHECK-NOTES in tests for cppcoreguidelines-owning-memory.

LG

Mon, Oct 1, 5:28 AM
alexfh added inline comments to D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--).
Mon, Oct 1, 5:14 AM · Restricted Project
alexfh requested changes to D52684: [clang-tidy] NFC refactor lexer-utils to be usable without ASTContext.

So far the change doesn't look really helpful. Are you going to use the function from code where no ASTContext is available? Can you give an example?

Mon, Oct 1, 5:12 AM · Restricted Project
alexfh accepted D52686: [clang-tidy] NFC use CHECK-NOTES in test for cppgoreguidelines-avoid-goto.

LG

Mon, Oct 1, 5:06 AM
alexfh requested changes to D52690: [clang-tidy] NFC use CHECK-NOTES in tests for misc-misplaced-const.
Mon, Oct 1, 5:05 AM
alexfh requested changes to D52691: [clang-tidy] NFC use CHECK-NOTES in tests for performance-move-constructor-init.
Mon, Oct 1, 5:00 AM
alexfh added inline comments to D52691: [clang-tidy] NFC use CHECK-NOTES in tests for performance-move-constructor-init.
Mon, Oct 1, 4:59 AM

Thu, Sep 27

alexfh added a comment to rL343198: [clang-tidy] use CHECK-NOTES in tests for bugprone-forward-declaration-namespace.

I commit the patches for CHECK-NOTES assuming the LG to https://reviews.llvm.org/D52230 includes the LG to the question, if i can commit all these patches. If this is not the case, i will of course revert/adjust accordingly.

Thu, Sep 27, 7:49 AM

Mon, Sep 24

alexfh added inline comments to D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--).
Mon, Sep 24, 7:20 AM · Restricted Project
alexfh requested changes to D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--).
Mon, Sep 24, 7:20 AM · Restricted Project
alexfh added a comment to D52334: [clang-tidy] Build it even without static analyzer.

! In D52334#1242955, @JonasToth wrote:
... to me it makes sense to have clang-tidy without CSA.

Mon, Sep 24, 7:20 AM · Restricted Project

Sep 18 2018

alexfh requested changes to D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--).
Sep 18 2018, 8:14 AM · Restricted Project
alexfh added a comment to D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--).

This is intended, IIUC. The syntax of the clang-tidy-diff.py mirrors the syntax of clang-tidy itself, and the -- option is used in the same way as in clang-tidy - to denote the start of compiler arguments (and switch to the fixed compilation database). Do you have a use case that would require passing clang-tidy options beyond the list already supported by clang-tidy-diff.py?

Sep 18 2018, 8:14 AM · Restricted Project
alexfh committed rL342463: Remove trailing whitespace introduced in r342440..
Remove trailing whitespace introduced in r342440.
Sep 18 2018, 3:57 AM
alexfh accepted D52178: [clang-tidy] use CHECK-NOTES in tests for bugprone-argument-comment.

LG

Sep 18 2018, 2:29 AM
alexfh accepted D52186: [clang-tidy] use CHECK-NOTES in bugprone-forwarding-reference-overload.

LG

Sep 18 2018, 2:24 AM
alexfh accepted D52187: [clang-tidy] use CHECK-NOTES in bugprone-unused-return-value.

LG with a comment.

Sep 18 2018, 2:23 AM
alexfh removed a reviewer for D51575: [clang-tidy] Implement a clang-tidy check to verify Google Objective-C function naming conventions 📜: alexfh.
Sep 18 2018, 2:17 AM · Restricted Project

Sep 17 2018

alexfh committed rL342399: Revert "[DWARF] reposting r342048, which was reverted in r342056 due to….
Revert "[DWARF] reposting r342048, which was reverted in r342056 due to…
Sep 17 2018, 8:41 AM
alexfh accepted D48714: [clang-tidy] fix PR37913, templated exception factory diagnosed correctly.

LG

Sep 17 2018, 6:35 AM
alexfh committed rL342386: Use createTemporaryFile in SampleProfTest.
Use createTemporaryFile in SampleProfTest
Sep 17 2018, 5:12 AM
alexfh added inline comments to D52136: [clang-tidy] Add modernize-concat-nested-namespaces check.
Sep 17 2018, 2:52 AM · Restricted Project

Aug 10 2018

alexfh added a comment to D49800: [clang-tidy: modernize] modernize-redundant-void-arg crashes when a function body is in a macro.

I've fixed the comments and committed the patch myself. Hope that's fine by you.

Aug 10 2018, 7:01 AM
alexfh committed rCTE339433: [clang-tidy: modernize] modernize-redundant-void-arg crashes when a function….
[clang-tidy: modernize] modernize-redundant-void-arg crashes when a function…
Aug 10 2018, 7:00 AM
alexfh committed rL339433: [clang-tidy: modernize] modernize-redundant-void-arg crashes when a function….
[clang-tidy: modernize] modernize-redundant-void-arg crashes when a function…
Aug 10 2018, 7:00 AM
alexfh closed D49800: [clang-tidy: modernize] modernize-redundant-void-arg crashes when a function body is in a macro.
Aug 10 2018, 7:00 AM
alexfh accepted D49800: [clang-tidy: modernize] modernize-redundant-void-arg crashes when a function body is in a macro.

LG with a couple of nits. Do you need someone to commit the patch for you?

Aug 10 2018, 5:56 AM
alexfh added inline comments to D50542: [clang-tidy] Add abseil-no-internal-deps check.
Aug 10 2018, 5:54 AM · Restricted Project

Aug 9 2018

alexfh accepted D36892: [clang-tidy] check_clang_tidy.py: support CHECK-NOTES prefix.

@lebedev.ri and @alexfh i would change the tests in https://reviews.llvm.org/D48714 to use CHECK-NOTES. Is it ok, to commit this one?

For testing purposes, you could change a single line of hicpp-exception-baseclass.cpp to use the CHECK-NOTES. I do the rest :)

Aug 9 2018, 3:46 PM · Restricted Project
alexfh accepted D49851: [clang-tidy] run-clang-tidy add synchronisation to the output.

LG

Aug 9 2018, 3:39 PM · Restricted Project
alexfh accepted D50447: [clang-tidy] Omit cases where loop variable is not used in loop body in performance-for-range-copy..

LG

Aug 9 2018, 3:37 PM
alexfh added inline comments to D49800: [clang-tidy: modernize] modernize-redundant-void-arg crashes when a function body is in a macro.
Aug 9 2018, 3:34 PM
alexfh added inline comments to D50389: [clang-tidy] Abseil: integral division of Duration check.
Aug 9 2018, 3:25 PM · Restricted Project

Aug 3 2018

alexfh accepted D49918: [clang-tidy] Sequence init statements, declarations, and conditions correctly in if, switch, and while.

Still LG

Aug 3 2018, 8:52 AM · Restricted Project

Jul 31 2018

alexfh added a comment to D49890: Clang-Tidy Export Problem.

Could you describe the specific problem you're solving and provide an example? As mentioned by others, a test would be very welcome as well.

Jul 31 2018, 8:42 AM · Restricted Project
alexfh accepted D50060: [clang-tidy] add all clang-tidy modules to plugin.

LG

Jul 31 2018, 8:07 AM
alexfh added a reviewer for D49911: Summary:Add clang::reinitializes attribute: rsmith.
Jul 31 2018, 5:08 AM
alexfh accepted D49918: [clang-tidy] Sequence init statements, declarations, and conditions correctly in if, switch, and while.

LG modulo outstanding comments.

Jul 31 2018, 5:02 AM · Restricted Project

Jul 26 2018

alexfh requested changes to D49800: [clang-tidy: modernize] modernize-redundant-void-arg crashes when a function body is in a macro.

Thank you for working on this!

Jul 26 2018, 7:06 AM
alexfh committed rCTE338025: [clang-tidy] Fix llvm.org/PR38315 (support type aliases in modernize-shrink-to….
[clang-tidy] Fix llvm.org/PR38315 (support type aliases in modernize-shrink-to…
Jul 26 2018, 6:14 AM
alexfh committed rL338025: [clang-tidy] Fix llvm.org/PR38315 (support type aliases in modernize-shrink-to….
[clang-tidy] Fix llvm.org/PR38315 (support type aliases in modernize-shrink-to…
Jul 26 2018, 6:14 AM

Jul 12 2018

alexfh added a comment to D49213: [analyzer] pr38072: Suppress an assertion failure for eliding the same destructor twice due to the default argument problem..

FTR, this is http://llvm.org/PR38072

Jul 12 2018, 5:02 AM

Jul 11 2018

alexfh requested changes to D42682: [clang-tidy] Add io-functions-misused checker.

(removing from my dashboard)

Jul 11 2018, 8:58 AM · Restricted Project
alexfh accepted D33537: [clang-tidy] Exception Escape Checker.

Looks good with one comment.

Jul 11 2018, 8:57 AM · Restricted Project
alexfh requested changes to D36892: [clang-tidy] check_clang_tidy.py: support CHECK-NOTES prefix.

As per the previous comment: I have no concerns as long as the documentation is updated and at least one existing test is changed to use this feature (see the list in the previous comment).

Jul 11 2018, 8:51 AM · Restricted Project
alexfh added a comment to D49167: [frontend] [analyzer] Provide an option to load a checker from a declarative file.

That's an awesome idea! Did you think about supporting automated fix-it suggestions?

Jul 11 2018, 8:36 AM

Jul 4 2018

alexfh added a comment to D48866: [clang-tidy] Add incorrect-pointer-cast checker.

Some patterns are covered by compiler diagnostics: https://godbolt.org/g/HvsjnP. Is there any benefit in re-implementing them?

Jul 4 2018, 9:53 AM
alexfh committed rCTE336283: [clang-tidy] Fix http://llvm.org/PR38055.
[clang-tidy] Fix http://llvm.org/PR38055
Jul 4 2018, 8:24 AM
alexfh committed rL336283: [clang-tidy] Fix http://llvm.org/PR38055.
[clang-tidy] Fix http://llvm.org/PR38055
Jul 4 2018, 8:24 AM
alexfh accepted D48910: [ASTMatchers] A matcher for Objective-C @autoreleasepool.

LG

Jul 4 2018, 7:12 AM

Jun 29 2018

alexfh added a comment to D48759: [ASTMatchers] add matcher for decltypeType and its underlyingType.

Please add a test.

Jun 29 2018, 5:05 AM

Jun 28 2018

alexfh committed rCTE335863: [clang-tidy] misc-unused-parameters - retain old behavior under StrictMode.
[clang-tidy] misc-unused-parameters - retain old behavior under StrictMode
Jun 28 2018, 8:26 AM
alexfh committed rL335863: [clang-tidy] misc-unused-parameters - retain old behavior under StrictMode.
[clang-tidy] misc-unused-parameters - retain old behavior under StrictMode
Jun 28 2018, 8:26 AM
alexfh closed D46951: [clang-tidy] misc-unused-parameters - retain old behavior under StrictMode.
Jun 28 2018, 8:26 AM
alexfh added inline comments to D46951: [clang-tidy] misc-unused-parameters - retain old behavior under StrictMode.
Jun 28 2018, 8:17 AM
alexfh updated the diff for D46951: [clang-tidy] misc-unused-parameters - retain old behavior under StrictMode.
  • Addressed review comments.
Jun 28 2018, 8:17 AM
alexfh added inline comments to D48714: [clang-tidy] fix PR37913, templated exception factory diagnosed correctly.
Jun 28 2018, 7:09 AM
alexfh requested changes to D48708: NFC Build fix in RegisterCustomCheckersTest.cpp.
Jun 28 2018, 6:52 AM
alexfh accepted D48717: [clang-tidy] fix PR36489 - respect deduced pointer types from auto as well.

LG

Jun 28 2018, 6:45 AM
alexfh added inline comments to D48717: [clang-tidy] fix PR36489 - respect deduced pointer types from auto as well.
Jun 28 2018, 6:44 AM
alexfh committed rL335846: Remove explicit type from an initializer list. NFC..
Remove explicit type from an initializer list. NFC.
Jun 28 2018, 5:24 AM
alexfh committed rCTE335846: Remove explicit type from an initializer list. NFC..
Remove explicit type from an initializer list. NFC.
Jun 28 2018, 5:24 AM
alexfh committed rCTE335845: Fix formatting. NFC..
Fix formatting. NFC.
Jun 28 2018, 5:20 AM
alexfh committed rL335845: Fix formatting. NFC..
Fix formatting. NFC.
Jun 28 2018, 5:20 AM
alexfh added inline comments to D45679: [clang-tidy] Add ExprMutationAnalyzer, that analyzes whether an expression is mutated within a statement..
Jun 28 2018, 5:14 AM · Restricted Project

Jun 27 2018

alexfh committed rL335740: [analyzer] Allow registering custom statically-linked analyzer checkers.
[analyzer] Allow registering custom statically-linked analyzer checkers
Jun 27 2018, 8:01 AM
alexfh committed rC335740: [analyzer] Allow registering custom statically-linked analyzer checkers.
[analyzer] Allow registering custom statically-linked analyzer checkers
Jun 27 2018, 8:01 AM
alexfh closed D45718: [analyzer] Allow registering custom statically-linked analyzer checkers.
Jun 27 2018, 8:01 AM
alexfh added a comment to D46951: [clang-tidy] misc-unused-parameters - retain old behavior under StrictMode.

Ping.

Jun 27 2018, 7:43 AM
alexfh edited reviewers for D48523: [clang-tidy] Update run-clang-tidy.py with vfsoverlay arg, added: ilya-biryukov; removed: alexfh.
Jun 27 2018, 7:38 AM
alexfh committed rL335736: [clang-tidy] Add ExprMutationAnalyzer, that analyzes whether an expression is….
[clang-tidy] Add ExprMutationAnalyzer, that analyzes whether an expression is…
Jun 27 2018, 7:35 AM
alexfh committed rCTE335736: [clang-tidy] Add ExprMutationAnalyzer, that analyzes whether an expression is….
[clang-tidy] Add ExprMutationAnalyzer, that analyzes whether an expression is…
Jun 27 2018, 7:35 AM
alexfh closed D45679: [clang-tidy] Add ExprMutationAnalyzer, that analyzes whether an expression is mutated within a statement..
Jun 27 2018, 7:35 AM · Restricted Project

Jun 21 2018

alexfh committed rL335252: [clang-tidy] Remove the google-readability-redundant-smartptr-get alias.
[clang-tidy] Remove the google-readability-redundant-smartptr-get alias
Jun 21 2018, 9:19 AM
alexfh committed rCTE335252: [clang-tidy] Remove the google-readability-redundant-smartptr-get alias.
[clang-tidy] Remove the google-readability-redundant-smartptr-get alias
Jun 21 2018, 9:19 AM
alexfh added a comment to D45718: [analyzer] Allow registering custom statically-linked analyzer checkers.

Please take another look.

Jun 21 2018, 8:58 AM
alexfh updated the diff for D45718: [analyzer] Allow registering custom statically-linked analyzer checkers.
  • Added a test.
Jun 21 2018, 8:57 AM