- User Since
- Jul 10 2012, 10:35 AM (363 w, 10 h)
May 20 2019
That's a quite impressive amount of work. Thanks! Looks good.
May 14 2019
May 9 2019
May 8 2019
LG. Thank you!
May 7 2019
May 6 2019
May 3 2019
Apart from NOLINT handling there's more logic in ClangTidyDiagnosticConsumer::HandleDiagnostic, which isn't properly transferred to ClangTidyContext::diag in this patch. The logic that is transferred seems to change the behavior w.r.t. notes that can "unmute" ignored warnings (see https://reviews.llvm.org/D59135#1456108). I suspect that we're missing proper test coverage here. Another issue is that compiler diagnostics don't pass ClangTidyContext::diag in the non-plugin use case. Do all the existing tests pass with your patch?
Please regenerate the HTML docs using clang/docs/tools/dump_ast_matchers.py.
Apr 24 2019
LG. Thanks for the fix!
Apr 23 2019
LG with a comment.
Apr 18 2019
There's one more nit. Otherwise good to go.
Apr 17 2019
LG with a couple of nits.
A few post-commit comments.
Artem, I'd appreciate, if you found time to finish this fix. The bug is causing most failures in our setup. Thanks!
Apr 16 2019
Apr 15 2019
Thanks! The change looks good now.
Apr 10 2019
Thanks for the useful check! I have a few comments, see inline.
Apr 8 2019
It looks like there's a number of users of this function beyond what you've mentioned:
Apr 5 2019
Looks like this check would fit better into the bugprone module.
Can you give a specific example of how this problem manifests?
Thanks, looks better now, but still a few comments, mostly nits.
Apr 4 2019
Apr 3 2019
Thanks for addressing this! Please add the test cases from https://bugs.llvm.org/show_bug.cgi?id=41185
This looks like a more promising direction. Thanks for the readiness to experiment with this.
Can you verify that the add_new_check.py script works fine with this new module?
The change looks fine, but I don't understand the description of this revision. Could you clarify which checkers you're talking about and which bug you observe?
Apr 2 2019
Apr 1 2019
Mar 29 2019
Looks reasonable in general, but we usually add modules with at least one check. Let's do the same here.
Mar 28 2019
I've posted another test case to https://bugs.llvm.org/show_bug.cgi?id=41239. It may already be covered by the fix. Could you check?
Mar 27 2019
Mar 25 2019
LG. This fixes (at least, most of) the crashes we observe.