- User Since
- Jul 10 2012, 10:35 AM (353 w, 3 d)
Thu, Apr 18
There's one more nit. Otherwise good to go.
Wed, Apr 17
LG with a couple of nits.
A few post-commit comments.
Artem, I'd appreciate, if you found time to finish this fix. The bug is causing most failures in our setup. Thanks!
Tue, Apr 16
Mon, Apr 15
Thanks! The change looks good now.
Wed, Apr 10
Thanks for the useful check! I have a few comments, see inline.
Mon, Apr 8
It looks like there's a number of users of this function beyond what you've mentioned:
Fri, Apr 5
Looks like this check would fit better into the bugprone module.
Can you give a specific example of how this problem manifests?
Thanks, looks better now, but still a few comments, mostly nits.
Thu, Apr 4
Wed, Apr 3
Thanks for addressing this! Please add the test cases from https://bugs.llvm.org/show_bug.cgi?id=41185
This looks like a more promising direction. Thanks for the readiness to experiment with this.
Can you verify that the add_new_check.py script works fine with this new module?
The change looks fine, but I don't understand the description of this revision. Could you clarify which checkers you're talking about and which bug you observe?
Tue, Apr 2
Mon, Apr 1
Fri, Mar 29
Looks reasonable in general, but we usually add modules with at least one check. Let's do the same here.
Thu, Mar 28
I've posted another test case to https://bugs.llvm.org/show_bug.cgi?id=41239. It may already be covered by the fix. Could you check?
Wed, Mar 27
Mon, Mar 25
LG. This fixes (at least, most of) the crashes we observe.
Fri, Mar 22
- Reverted the <Switch checks to include "ClangTidyCheck.h"> part to simplify the review.
LG. Thanks for improving the check!