alexfh (Alexander Kornienko)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 10 2012, 10:35 AM (318 w, 15 h)

Recent Activity

Fri, Aug 10

alexfh added a comment to D49800: [clang-tidy: modernize] modernize-redundant-void-arg crashes when a function body is in a macro.

I've fixed the comments and committed the patch myself. Hope that's fine by you.

Fri, Aug 10, 7:01 AM
alexfh committed rCTE339433: [clang-tidy: modernize] modernize-redundant-void-arg crashes when a function….
[clang-tidy: modernize] modernize-redundant-void-arg crashes when a function…
Fri, Aug 10, 7:00 AM
alexfh committed rL339433: [clang-tidy: modernize] modernize-redundant-void-arg crashes when a function….
[clang-tidy: modernize] modernize-redundant-void-arg crashes when a function…
Fri, Aug 10, 7:00 AM
alexfh closed D49800: [clang-tidy: modernize] modernize-redundant-void-arg crashes when a function body is in a macro.
Fri, Aug 10, 7:00 AM
alexfh accepted D49800: [clang-tidy: modernize] modernize-redundant-void-arg crashes when a function body is in a macro.

LG with a couple of nits. Do you need someone to commit the patch for you?

Fri, Aug 10, 5:56 AM
alexfh added inline comments to D50542: [clang-tidy] Add abseil-no-internal-deps check.
Fri, Aug 10, 5:54 AM · Restricted Project

Thu, Aug 9

alexfh accepted D36892: [clang-tidy] check_clang_tidy.py: support CHECK-NOTES prefix.

@lebedev.ri and @alexfh i would change the tests in https://reviews.llvm.org/D48714 to use CHECK-NOTES. Is it ok, to commit this one?

For testing purposes, you could change a single line of hicpp-exception-baseclass.cpp to use the CHECK-NOTES. I do the rest :)

Thu, Aug 9, 3:46 PM · Restricted Project
alexfh accepted D49851: [clang-tidy] run-clang-tidy add synchronisation to the output.

LG

Thu, Aug 9, 3:39 PM · Restricted Project
alexfh accepted D50447: [clang-tidy] Omit cases where loop variable is not used in loop body in performance-for-range-copy..

LG

Thu, Aug 9, 3:37 PM
alexfh added inline comments to D49800: [clang-tidy: modernize] modernize-redundant-void-arg crashes when a function body is in a macro.
Thu, Aug 9, 3:34 PM
alexfh added inline comments to D50389: [clang-tidy] Abseil: integral division of Duration check.
Thu, Aug 9, 3:25 PM · Restricted Project

Fri, Aug 3

alexfh accepted D49918: [clang-tidy] Sequence init statements, declarations, and conditions correctly in if, switch, and while.

Still LG

Fri, Aug 3, 8:52 AM · Restricted Project

Tue, Jul 31

alexfh added a comment to D49890: Clang-Tidy Export Problem.

Could you describe the specific problem you're solving and provide an example? As mentioned by others, a test would be very welcome as well.

Tue, Jul 31, 8:42 AM · Restricted Project
alexfh accepted D50060: [clang-tidy] add all clang-tidy modules to plugin.

LG

Tue, Jul 31, 8:07 AM
alexfh added a reviewer for D49911: Summary:Add clang::reinitializes attribute: rsmith.
Tue, Jul 31, 5:08 AM
alexfh accepted D49918: [clang-tidy] Sequence init statements, declarations, and conditions correctly in if, switch, and while.

LG modulo outstanding comments.

Tue, Jul 31, 5:02 AM · Restricted Project

Thu, Jul 26

alexfh requested changes to D49800: [clang-tidy: modernize] modernize-redundant-void-arg crashes when a function body is in a macro.

Thank you for working on this!

Thu, Jul 26, 7:06 AM
alexfh committed rCTE338025: [clang-tidy] Fix llvm.org/PR38315 (support type aliases in modernize-shrink-to….
[clang-tidy] Fix llvm.org/PR38315 (support type aliases in modernize-shrink-to…
Thu, Jul 26, 6:14 AM
alexfh committed rL338025: [clang-tidy] Fix llvm.org/PR38315 (support type aliases in modernize-shrink-to….
[clang-tidy] Fix llvm.org/PR38315 (support type aliases in modernize-shrink-to…
Thu, Jul 26, 6:14 AM

Jul 12 2018

alexfh added a comment to D49213: [analyzer] pr38072: Suppress an assertion failure for eliding the same destructor twice due to the default argument problem..

FTR, this is http://llvm.org/PR38072

Jul 12 2018, 5:02 AM

Jul 11 2018

alexfh requested changes to D42682: [clang-tidy] Add io-functions-misused checker.

(removing from my dashboard)

Jul 11 2018, 8:58 AM · Restricted Project
alexfh accepted D33537: [clang-tidy] Exception Escape Checker.

Looks good with one comment.

Jul 11 2018, 8:57 AM · Restricted Project
alexfh requested changes to D36892: [clang-tidy] check_clang_tidy.py: support CHECK-NOTES prefix.

As per the previous comment: I have no concerns as long as the documentation is updated and at least one existing test is changed to use this feature (see the list in the previous comment).

Jul 11 2018, 8:51 AM · Restricted Project
alexfh added a comment to D49167: [frontend] [analyzer] Provide an option to load a checker from a declarative file.

That's an awesome idea! Did you think about supporting automated fix-it suggestions?

Jul 11 2018, 8:36 AM

Jul 4 2018

alexfh added a comment to D48866: [clang-tidy] Add incorrect-pointer-cast checker.

Some patterns are covered by compiler diagnostics: https://godbolt.org/g/HvsjnP. Is there any benefit in re-implementing them?

Jul 4 2018, 9:53 AM
alexfh committed rCTE336283: [clang-tidy] Fix http://llvm.org/PR38055.
[clang-tidy] Fix http://llvm.org/PR38055
Jul 4 2018, 8:24 AM
alexfh committed rL336283: [clang-tidy] Fix http://llvm.org/PR38055.
[clang-tidy] Fix http://llvm.org/PR38055
Jul 4 2018, 8:24 AM
alexfh accepted D48910: [ASTMatchers] A matcher for Objective-C @autoreleasepool.

LG

Jul 4 2018, 7:12 AM

Jun 29 2018

alexfh added a comment to D48759: [ASTMatchers] add matcher for decltypeType and its underlyingType.

Please add a test.

Jun 29 2018, 5:05 AM

Jun 28 2018

alexfh committed rCTE335863: [clang-tidy] misc-unused-parameters - retain old behavior under StrictMode.
[clang-tidy] misc-unused-parameters - retain old behavior under StrictMode
Jun 28 2018, 8:26 AM
alexfh committed rL335863: [clang-tidy] misc-unused-parameters - retain old behavior under StrictMode.
[clang-tidy] misc-unused-parameters - retain old behavior under StrictMode
Jun 28 2018, 8:26 AM
alexfh closed D46951: [clang-tidy] misc-unused-parameters - retain old behavior under StrictMode.
Jun 28 2018, 8:26 AM
alexfh added inline comments to D46951: [clang-tidy] misc-unused-parameters - retain old behavior under StrictMode.
Jun 28 2018, 8:17 AM
alexfh updated the diff for D46951: [clang-tidy] misc-unused-parameters - retain old behavior under StrictMode.
  • Addressed review comments.
Jun 28 2018, 8:17 AM
alexfh added inline comments to D48714: [clang-tidy] fix PR37913, templated exception factory diagnosed correctly.
Jun 28 2018, 7:09 AM
alexfh requested changes to D48708: NFC Build fix in RegisterCustomCheckersTest.cpp.
Jun 28 2018, 6:52 AM
alexfh accepted D48717: [clang-tidy] fix PR36489 - respect deduced pointer types from auto as well.

LG

Jun 28 2018, 6:45 AM
alexfh added inline comments to D48717: [clang-tidy] fix PR36489 - respect deduced pointer types from auto as well.
Jun 28 2018, 6:44 AM
alexfh committed rL335846: Remove explicit type from an initializer list. NFC..
Remove explicit type from an initializer list. NFC.
Jun 28 2018, 5:24 AM
alexfh committed rCTE335846: Remove explicit type from an initializer list. NFC..
Remove explicit type from an initializer list. NFC.
Jun 28 2018, 5:24 AM
alexfh committed rCTE335845: Fix formatting. NFC..
Fix formatting. NFC.
Jun 28 2018, 5:20 AM
alexfh committed rL335845: Fix formatting. NFC..
Fix formatting. NFC.
Jun 28 2018, 5:20 AM
alexfh added inline comments to D45679: [clang-tidy] Add ExprMutationAnalyzer, that analyzes whether an expression is mutated within a statement..
Jun 28 2018, 5:14 AM · Restricted Project

Jun 27 2018

alexfh committed rL335740: [analyzer] Allow registering custom statically-linked analyzer checkers.
[analyzer] Allow registering custom statically-linked analyzer checkers
Jun 27 2018, 8:01 AM
alexfh committed rC335740: [analyzer] Allow registering custom statically-linked analyzer checkers.
[analyzer] Allow registering custom statically-linked analyzer checkers
Jun 27 2018, 8:01 AM
alexfh closed D45718: [analyzer] Allow registering custom statically-linked analyzer checkers.
Jun 27 2018, 8:01 AM
alexfh added a comment to D46951: [clang-tidy] misc-unused-parameters - retain old behavior under StrictMode.

Ping.

Jun 27 2018, 7:43 AM
alexfh edited reviewers for D48523: [clang-tidy] Update run-clang-tidy.py with vfsoverlay arg, added: ilya-biryukov; removed: alexfh.
Jun 27 2018, 7:38 AM
alexfh committed rL335736: [clang-tidy] Add ExprMutationAnalyzer, that analyzes whether an expression is….
[clang-tidy] Add ExprMutationAnalyzer, that analyzes whether an expression is…
Jun 27 2018, 7:35 AM
alexfh committed rCTE335736: [clang-tidy] Add ExprMutationAnalyzer, that analyzes whether an expression is….
[clang-tidy] Add ExprMutationAnalyzer, that analyzes whether an expression is…
Jun 27 2018, 7:35 AM
alexfh closed D45679: [clang-tidy] Add ExprMutationAnalyzer, that analyzes whether an expression is mutated within a statement..
Jun 27 2018, 7:35 AM · Restricted Project

Jun 21 2018

alexfh committed rL335252: [clang-tidy] Remove the google-readability-redundant-smartptr-get alias.
[clang-tidy] Remove the google-readability-redundant-smartptr-get alias
Jun 21 2018, 9:19 AM
alexfh committed rCTE335252: [clang-tidy] Remove the google-readability-redundant-smartptr-get alias.
[clang-tidy] Remove the google-readability-redundant-smartptr-get alias
Jun 21 2018, 9:19 AM
alexfh added a comment to D45718: [analyzer] Allow registering custom statically-linked analyzer checkers.

Please take another look.

Jun 21 2018, 8:58 AM
alexfh updated the diff for D45718: [analyzer] Allow registering custom statically-linked analyzer checkers.
  • Added a test.
Jun 21 2018, 8:57 AM

Jun 19 2018

alexfh added a comment to D47670: [analyzer] [NFC] Remove unused Extensive diagnostic setting, rename AlternateExtensive to Extensive..

@alexfh apologies, fixed.

Jun 19 2018, 2:41 AM

Jun 18 2018

alexfh added inline comments to D47670: [analyzer] [NFC] Remove unused Extensive diagnostic setting, rename AlternateExtensive to Extensive..
Jun 18 2018, 8:33 AM

Jun 14 2018

alexfh added a comment to D45679: [clang-tidy] Add ExprMutationAnalyzer, that analyzes whether an expression is mutated within a statement..

It might be the case, that the test is run with -no-stdinc (or similar),
so the standard library is not available.

Jun 14 2018, 6:24 AM · Restricted Project

Jun 13 2018

alexfh added inline comments to D47554: [analyzer] Check for dead/impossible status checks.
Jun 13 2018, 3:27 AM

Jun 11 2018

alexfh added a comment to D45706: [CFG] [analyzer] Add construction contexts for loop condition variables..

This commit seems to have introduced https://bugs.llvm.org/show_bug.cgi?id=37769. Could you take a look?

Jun 11 2018, 9:30 AM
alexfh committed rCTE334400: Add support for arrays in performance-implicit-conversion-in-loop.
Add support for arrays in performance-implicit-conversion-in-loop
Jun 11 2018, 5:57 AM
alexfh committed rL334400: Add support for arrays in performance-implicit-conversion-in-loop.
Add support for arrays in performance-implicit-conversion-in-loop
Jun 11 2018, 5:51 AM
alexfh closed D47945: Add support for arrays in performance-implicit-conversion-in-loop.
Jun 11 2018, 5:51 AM

Jun 8 2018

alexfh accepted D47945: Add support for arrays in performance-implicit-conversion-in-loop.

LG

Jun 8 2018, 2:41 PM
alexfh committed rL334295: commandLineFitsWithinSystemLimits Overestimates System Limits.
commandLineFitsWithinSystemLimits Overestimates System Limits
Jun 8 2018, 8:23 AM

Jun 7 2018

alexfh added a reviewer for D47577: [clang-format] Separate block comments with CRLF correctly: djasper.
Jun 7 2018, 7:24 AM
alexfh edited reviewers for D47577: [clang-format] Separate block comments with CRLF correctly, added: krasimir; removed: alexfh.
Jun 7 2018, 7:19 AM
alexfh accepted D47704: [clang-tidy] Improve string type matcher for abseil-string-find-starts-with check..

LG

Jun 7 2018, 7:18 AM
alexfh removed a reviewer for D47267: [UnrollAndJam] Add unroll_and_jam pragma handling: alexfh.
Jun 7 2018, 7:12 AM

Jun 6 2018

alexfh requested changes to D33537: [clang-tidy] Exception Escape Checker.
Jun 6 2018, 8:12 AM · Restricted Project
alexfh accepted D45927: [clang-tidy] [modernize-use-auto] Correct way to calculate a type name length for multi-token types.

LG

Jun 6 2018, 8:00 AM · Restricted Project
alexfh accepted D46602: [clang-tidy] Store checks profiling info as JSON files.

LG

Jun 6 2018, 7:55 AM · Restricted Project

May 17 2018

alexfh added a comment to D45177: CStringChecker, check strlcpy/strlcat.

I was unable to reproduce both FreeBSD and Linux. Plus my changes come after checkNonNull.

May 17 2018, 3:23 PM
alexfh added a comment to D45177: CStringChecker, check strlcpy/strlcat.

See https://bugs.llvm.org/show_bug.cgi?id=37503 for a test case.

May 17 2018, 8:31 AM
alexfh committed rCTE332609: [clang-tidy] Add a flag to enable alpha checkers.
[clang-tidy] Add a flag to enable alpha checkers
May 17 2018, 7:08 AM
alexfh committed rL332609: [clang-tidy] Add a flag to enable alpha checkers.
[clang-tidy] Add a flag to enable alpha checkers
May 17 2018, 7:08 AM
alexfh closed D46159: [clang-tidy] Add a flag to enable alpha checkers.
May 17 2018, 7:08 AM
alexfh added a comment to D45177: CStringChecker, check strlcpy/strlcat.

This is reproducible in r332425.

May 17 2018, 4:27 AM
alexfh added a comment to D45177: CStringChecker, check strlcpy/strlcat.

This patch seems to cause an assertion failure:

May 17 2018, 4:24 AM

May 16 2018

alexfh accepted D46980: [ASTMatchers] Introduce a blockDecl matcher for matching block declarations.

LG

May 16 2018, 3:24 PM
alexfh added a comment to D46602: [clang-tidy] Store checks profiling info as JSON files.

A couple of comments from a cursory look. I'll try to look closer later this week.

May 16 2018, 9:50 AM · Restricted Project
alexfh accepted D46659: [clang-tidy/google-readability-casting] Disable check for Objective-C++.

LG

May 16 2018, 9:39 AM
alexfh accepted D46936: [Timers] TimerGroup::printJSONValues(): print mem timer with .mem suffix.

LG

May 16 2018, 9:36 AM
alexfh accepted D46938: [Timers] TimerGroup: make printJSONValues() method public.

LG

May 16 2018, 9:33 AM
alexfh accepted D46939: [Timers] TimerGroup: add constructor from StringMap<TimeRecord>.

LG

May 16 2018, 9:31 AM
alexfh added a comment to D33440: clang-format: better handle statement macros.

There are still outstanding comments.

May 16 2018, 9:27 AM
alexfh created D46951: [clang-tidy] misc-unused-parameters - retain old behavior under StrictMode.
May 16 2018, 8:31 AM

May 14 2018

alexfh added a comment to D46602: [clang-tidy] Store checks profiling info as JSON files.

Roman, it looks to me that a simpler storage scheme would be sufficient. For example, YYYYMMDDhhmmss-InputFileName.cpp.csv.
Main things are:

  1. include a timestamp, so there's no need to overwrite old results,

Of the input source file?

No, current timestamp, when each profile gets dumped.

Ah.
Then i don't understand this at all. Why would we want to do that, exactly?
Just so that we can avoid creating directory structure? Why do we want to avoid that?

If clang-tidy is invoked manually, a simpler naming scheme with less configuration options would be easier to use, in particular:

  1. no the need to specify the -store-check-profile-elide-prefix= option;
  2. it's easier to see all results (no need to use find, just ls /output/directory or ls /output/directory/20180514* to see today's results, for example);
  3. no chance of filename collision, and thus no chance of losing older results by just running clang-tidy again.

How do i reflect that in tests? The output name will basically be random.

May 14 2018, 9:24 AM · Restricted Project
alexfh added a comment to D46159: [clang-tidy] Add a flag to enable alpha checkers.

Is someone able to merge in my changes?

Will do.

May 14 2018, 8:34 AM
alexfh added a comment to D46159: [clang-tidy] Add a flag to enable alpha checkers.

Is someone able to merge in my changes?

May 14 2018, 8:32 AM
alexfh requested changes to D46602: [clang-tidy] Store checks profiling info as JSON files.

Roman, it looks to me that a simpler storage scheme would be sufficient. For example, YYYYMMDDhhmmss-InputFileName.cpp.csv.
Main things are:

  1. include a timestamp, so there's no need to overwrite old results,

Of the input source file?

No, current timestamp, when each profile gets dumped.

Ah.
Then i don't understand this at all. Why would we want to do that, exactly?
Just so that we can avoid creating directory structure? Why do we want to avoid that?

May 14 2018, 7:20 AM · Restricted Project

May 11 2018

alexfh added a comment to D46602: [clang-tidy] Store checks profiling info as JSON files.

Roman, it looks to me that a simpler storage scheme would be sufficient. For example, YYYYMMDDhhmmss-InputFileName.cpp.csv.
Main things are:

  1. include a timestamp, so there's no need to overwrite old results,

Of the input source file?

May 11 2018, 7:34 AM · Restricted Project
alexfh accepted D33844: [clang-tidy] terminating continue check.

Which comments do you think are still relevant?

May 11 2018, 7:30 AM · Restricted Project

May 9 2018

alexfh added inline comments to D45927: [clang-tidy] [modernize-use-auto] Correct way to calculate a type name length for multi-token types.
May 9 2018, 8:00 AM · Restricted Project
alexfh added a comment to D46603: [Support] TimerGroup changes.

I wonder why JSON? What kind of a tool do folks use to process the outputs of printJSONValue? Is there anything existing or is JSON used "just in case"? I personally use either spreadsheets, python or shell when I deal with this kind of data, and all three of them can work reasonably well with CSV (plus the data is pretty simple).

May 9 2018, 7:44 AM
alexfh added a comment to D46602: [clang-tidy] Store checks profiling info as JSON files.

Roman, it looks to me that a simpler storage scheme would be sufficient. For example, YYYYMMDDhhmmss-InputFileName.cpp.csv. Main things are: 1. include a timestamp, so there's no need to overwrite old results, 2. include just the name of the file without any parent directories, 3. put all outputs into the same directory. This way we wouldn't have to create a directory structure and think about stripping a certain prefix (btw, utilities like patch just specify the number of path components to remove from the start, not the actual substring). WDYT?

May 9 2018, 7:34 AM · Restricted Project
alexfh added a comment to D46602: [clang-tidy] Store checks profiling info as JSON files.
In D46602#1092111, @rja wrote:

+1 for JSON

May 9 2018, 7:22 AM · Restricted Project
alexfh committed rC331870: Fixes issue introduced by r331556..
Fixes issue introduced by r331556.
May 9 2018, 5:31 AM
alexfh committed rL331870: Fixes issue introduced by r331556..
Fixes issue introduced by r331556.
May 9 2018, 5:31 AM
alexfh closed D46633: [analyzer] add range check for InitList lookup.
May 9 2018, 5:31 AM