Page MenuHomePhabricator

alexfh (Alexander Kornienko)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 10 2012, 10:35 AM (379 w, 1 d)

Recent Activity

Today

alexfh accepted D69036: [libTooling] Fix r374962: add more Transformer forwarding decls..

LG.

Wed, Oct 16, 7:21 AM · Restricted Project

Mon, Oct 14

alexfh added a comment to D68682: Clang-tidy fix removals removing all non-blank text from a line should remove the line.

Thanks, from the name that sounds like the perfect place to do it. If cleanupAroundReplacements also is used by clang-format, would we want to make the functionality optional, e.g. via a new bool parameter to cleanupAroundReplacements, a new option in FormatStyle, etc.?

Mon, Oct 14, 1:16 AM · Restricted Project, Restricted Project

Fri, Oct 11

alexfh accepted D68807: [ClangTidy] Separate tests for infrastructure and checkers.

I agree that the test/clang-tidy directory has become hard to navigate. Splitting tests for checks and for infrastructure seems reasonable to me. I personally don't care about specific directory names and file moves/renames are also not a concern, since git is rather good at handling those. I personally strongly prefer long-term improvements over desire to minimize churn.

Fri, Oct 11, 4:51 AM · Restricted Project

Thu, Sep 26

alexfh edited reviewers for D67865: [clang-tidy] Finds uses of OSRead* calls on macOS that may mask unexpected behavior due to unaligned reads, added: gribozavr; removed: alexfh.
Thu, Sep 26, 2:07 AM · Restricted Project

Mon, Sep 23

alexfh added a comment to D67501: [clang-tidy] Fix relative path in header-filter..

Sorry, I reverted this patch in r372601.

Unfortunately, it makes paths printed in clang-tidy'd diagnostics inconsistent with what -header-filter operates on.

For example, imagine that file-filter.cpp includes header_alias.h, which is a symlink to header.h. The diagnostics printed by clang-tidy refer to header_alias.h, however, after this patch, -header-filter logic calls realpath() and operates on header.h -- making it very difficult for users to understand how exactly to set up filters.

Also, note that paths in diagnostics don't collapse foo/.. or symlinks.

We should only change both sides of path handling simultaneously (paths in diagnostics and paths in filters). However, since getting the user's preferred path is potentially very difficult when symlinks are present, I'm not sure if anything can be done here. Maybe only collapsing foo/.. would be viable?

Mon, Sep 23, 6:51 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Sep 18

alexfh edited reviewers for D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage, added: gribozavr; removed: alexfh.
Wed, Sep 18, 6:30 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Sep 17

alexfh added a comment to D45050: [clang-tidy] New checker for not null-terminated result caused by strlen(), size() or equal length.

A couple of drive-by comments.

Tue, Sep 17, 6:42 AM · Restricted Project, Restricted Project
alexfh removed a reviewer for D65917: [clang-tidy] Added check for the Google style guide's category method naming rule.: alexfh.
Tue, Sep 17, 5:32 AM · Restricted Project, Restricted Project

Sep 5 2019

alexfh committed rG30424e4268e2: [clang-tidy] Make most ArgumentCommentCheck options local, as they should be (authored by alexfh).
[clang-tidy] Make most ArgumentCommentCheck options local, as they should be
Sep 5 2019, 7:49 AM
alexfh committed rG42443e50cedd: Add a bugprone-argument-comment option: IgnoreSingleArgument. (authored by alexfh).
Add a bugprone-argument-comment option: IgnoreSingleArgument.
Sep 5 2019, 7:49 AM
alexfh committed rL371076: [clang-tidy] Make most ArgumentCommentCheck options local, as they should be.
[clang-tidy] Make most ArgumentCommentCheck options local, as they should be
Sep 5 2019, 7:48 AM
alexfh committed rL371075: Add a bugprone-argument-comment option: IgnoreSingleArgument..
Add a bugprone-argument-comment option: IgnoreSingleArgument.
Sep 5 2019, 7:48 AM
alexfh closed D67056: Add a bugprone-argument-comment option: IgnoreSingleArgument..
Sep 5 2019, 7:48 AM · Restricted Project, Restricted Project
alexfh committed rGb6d9703050d0: [clang-tidy] Fix bugprone-argument-comment bug: negative literal number is not… (authored by alexfh).
[clang-tidy] Fix bugprone-argument-comment bug: negative literal number is not…
Sep 5 2019, 7:15 AM
alexfh committed rL371072: [clang-tidy] Fix bugprone-argument-comment bug: negative literal number is not….
[clang-tidy] Fix bugprone-argument-comment bug: negative literal number is not…
Sep 5 2019, 7:15 AM
alexfh closed D67084: [clang-tidy] Fix bugprone-argument-comment bug: negative literal number is not checked..
Sep 5 2019, 7:15 AM · Restricted Project, Restricted Project, Restricted Project

Sep 4 2019

alexfh added a comment to D67084: [clang-tidy] Fix bugprone-argument-comment bug: negative literal number is not checked..
In D67084#1657534, @xyb wrote:

Thanks. BTW, I can't commit the patch by myself.

Sep 4 2019, 9:50 AM · Restricted Project, Restricted Project, Restricted Project
alexfh added inline comments to D67056: Add a bugprone-argument-comment option: IgnoreSingleArgument..
Sep 4 2019, 9:50 AM · Restricted Project, Restricted Project
alexfh committed rG240a2e25c6de: [clang-tidy] Fix bugprone-argument-comment bug if there are marcos. (authored by alexfh).
[clang-tidy] Fix bugprone-argument-comment bug if there are marcos.
Sep 4 2019, 9:21 AM
alexfh committed rL370919: [clang-tidy] Fix bugprone-argument-comment bug if there are marcos..
[clang-tidy] Fix bugprone-argument-comment bug if there are marcos.
Sep 4 2019, 9:21 AM
alexfh closed D67080: [clang-tidy] Fix bugprone-argument-comment bug if there are marcos..
Sep 4 2019, 9:20 AM · Restricted Project, Restricted Project, Restricted Project
alexfh added a comment to D67056: Add a bugprone-argument-comment option: IgnoreSingleArgument..
In D67056#1657540, @xyb wrote:

Thanks. BTW, I can't commit the patch by myself.

Sep 4 2019, 8:55 AM · Restricted Project, Restricted Project
alexfh accepted D67084: [clang-tidy] Fix bugprone-argument-comment bug: negative literal number is not checked..

LG if there are no other concerns.

Sep 4 2019, 7:01 AM · Restricted Project, Restricted Project, Restricted Project
alexfh accepted D67056: Add a bugprone-argument-comment option: IgnoreSingleArgument..

LG with a comment.

Sep 4 2019, 6:58 AM · Restricted Project, Restricted Project
alexfh accepted D67080: [clang-tidy] Fix bugprone-argument-comment bug if there are marcos..

LG. Thanks!

Sep 4 2019, 6:54 AM · Restricted Project, Restricted Project, Restricted Project
alexfh added a comment to D67084: [clang-tidy] Fix bugprone-argument-comment bug: negative literal number is not checked..

Please add full context to the diff. See https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface

Sep 4 2019, 6:44 AM · Restricted Project, Restricted Project, Restricted Project
alexfh added a reviewer for D67140: [analyzer][NFC] Fix inconsistent references to checkers as "checks": aaron.ballman.

Thanks! Yay consistency.

I prefer the term "checker" to refer to individual modules because I feel it is more precise and less ambiguous. In phrases like "malloc check", "make_unique check", it is unclear what does the check -- malloc itself, the caller of malloc, or something else. Therefore, I would be supportive of repainting ClangTidy to also use "checker", but I would want to know what @alexfh thinks about it before we do it in ClangTidy.

Sep 4 2019, 6:24 AM · Restricted Project, Restricted Project

Aug 30 2019

alexfh added a comment to D66505: Make add_new_check.py's insertion of registerCheck<> match the sort order.

Mostly LG, if you've verified that this works. A couple of comments below.

Aug 30 2019, 4:51 AM · Restricted Project, Restricted Project

Aug 23 2019

alexfh added a comment to D66505: Make add_new_check.py's insertion of registerCheck<> match the sort order.

Given that the alphabetization we want really is based on the string literal, would it make sense to look for that rather than the check name? Adding a few more reviewers for a better mix of opinions.

Ideally, it would be nice to sort the list of registrations by the check name. But given that the call can span two lines, that may be slightly trickier to implement. It's worth giving it a try though ;)

Aug 23 2019, 3:14 AM · Restricted Project, Restricted Project

Aug 20 2019

alexfh added inline comments to D62829: [clang-tidy] Check for dynamically initialized statics in headers..
Aug 20 2019, 6:57 AM · Restricted Project, Restricted Project, Restricted Project

Aug 16 2019

alexfh added a comment to D65065: [clang-tidy] Possibility of displaying duplicate warnings.

Just FYI, https://bugs.llvm.org/show_bug.cgi?id=43019 is relevant.

Aug 16 2019, 6:32 AM · Restricted Project, Restricted Project
alexfh accepted D65065: [clang-tidy] Possibility of displaying duplicate warnings.

LG. Thanks!

Aug 16 2019, 6:32 AM · Restricted Project, Restricted Project

Aug 14 2019

alexfh added a comment to D66042: [analyzer] Analysis: Silence checkers.
In D66042#1627760, @NoQ wrote:

But without this patch clang seems to have the same two ANALYZE log lines regardless of whether I enable core checkers or not

Yup, it seems as if clang-tidy enables core as long as at least one Static Analyzer checker is enabled (even if it's path-insensitive).

Aug 14 2019, 4:11 AM · Restricted Project, Restricted Project

Aug 13 2019

alexfh added a comment to D66042: [analyzer] Analysis: Silence checkers.
In D66042#1625898, @NoQ wrote:

While we're here: i poked your silencing mechanism a little bit and even though i'm still pretty sure you couldn't have done it perfectly without our help, it sounds as if the only problem you have with it is that the path-sensitive checkers keep running even if only path-insensitive checkers are enabled:

$ clang-tidy test.c -checks=-*,clang-analyzer-unix.cstring.BadSizeArg -- -Xclang -analyzer-display-progress

ANALYZE (Syntax): /Users/adergachev/test/test.c foo                         // <== only this part will actually influence
                                                                            //     the results of analysis in this invocation
ANALYZE (Path,  Inline_Regular): /Users/adergachev/test/test.c foo          // <== however this part is sloooooow

This may be a performance issue for users who want fast analysis but are interested in some path-insensitive Static Analyzer checks (and they don't seem to have a way around that when they limit themselves to clang-tidy's own CLI), but apart from that you indeed seem to be fine.

Aug 13 2019, 8:31 AM · Restricted Project, Restricted Project

Aug 12 2019

alexfh added a reviewer for D66042: [analyzer] Analysis: Silence checkers: gribozavr.
Aug 12 2019, 7:34 AM · Restricted Project, Restricted Project
alexfh added a comment to D66042: [analyzer] Analysis: Silence checkers.
In D66042#1624081, @NoQ wrote:

+@alexfh because clang-tidy now finally has a way of safely disabling core checkers without causing crashes all over the place! Would you like to take the same approach as we picked in scan-build, i.e. when the user asks to disable a core checker, silence it instead?

Aug 12 2019, 7:32 AM · Restricted Project, Restricted Project
alexfh added a comment to D55125: [clang-tidy] Fix a false positive in misc-redundant-expression check.

One more nit.

Aug 12 2019, 7:19 AM · Restricted Project

Aug 7 2019

alexfh added a comment to D65065: [clang-tidy] Possibility of displaying duplicate warnings.

This suggestion would result another strange behavior: if the user disables cert-err09-cpp because he or she doesn't want to see its reports, the other one (cert-err61-cpp) will still report the issue. So he or she has to disable both (or as many aliases it has).

That seems to be the case regardless of the implementation strategy in this patch.

Aug 7 2019, 8:12 AM · Restricted Project, Restricted Project

Jul 26 2019

alexfh added a comment to D64671: [clang-tidy] New check: misc-init-local-variables.

A general comment: "misc" is a sort of a heap of checks that otherwise don't have a good home. This one would probably better go to bugprone (or maybe there's a relevant CERT or C++ Core Guidelines rule?).

Jul 26 2019, 5:26 PM · Restricted Project
alexfh added a comment to D65065: [clang-tidy] Possibility of displaying duplicate warnings.

I think it will be a strict improvement to include the check name into the deduplication key (probably after the file and offset and before the message). I don't see any reason to hide this behind a flag or otherwise retain the old behavior. As for expanding the key to include notes and fixes - it's probably good to do this either, and this may help uncover incorrect behavior of some checks. I'd suggest to start with the check name though.

Jul 26 2019, 5:20 PM · Restricted Project, Restricted Project

Jul 22 2019

alexfh added a comment to D65065: [clang-tidy] Possibility of displaying duplicate warnings.

LessClangTidyError only compares location and message, but it could also compare other things like notes, fixes, etc. For the problem outlined in the description of this patch we can probably include the checker name into the key. WDYT?

Jul 22 2019, 4:43 PM · Restricted Project, Restricted Project

Jul 18 2019

alexfh added inline comments to D64671: [clang-tidy] New check: misc-init-local-variables.
Jul 18 2019, 5:14 AM · Restricted Project

Jul 17 2019

alexfh added a comment to D55044: [clang-tidy] check for Abseil make_unique.

Seems good now. Haojian, do you have any concerns?

Jul 17 2019, 7:50 AM · Restricted Project
alexfh accepted D64861: [clang-tidy] Adjust location of namespace comment diagnostic.

LG. Thanks!

Jul 17 2019, 6:52 AM · Restricted Project, Restricted Project
alexfh added inline comments to D64671: [clang-tidy] New check: misc-init-local-variables.
Jul 17 2019, 6:48 AM · Restricted Project
alexfh added inline comments to D33841: [clang-tidy] redundant 'extern' keyword check.
Jul 17 2019, 5:56 AM · Restricted Project
alexfh added a comment to D33841: [clang-tidy] redundant 'extern' keyword check.

Hi, do you have any additional comments?

Jul 17 2019, 5:43 AM · Restricted Project

Jul 16 2019

alexfh added inline comments to D64671: [clang-tidy] New check: misc-init-local-variables.
Jul 16 2019, 5:18 AM · Restricted Project

Jul 15 2019

alexfh added inline comments to D64671: [clang-tidy] New check: misc-init-local-variables.
Jul 15 2019, 6:49 AM · Restricted Project
alexfh added inline comments to D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files.
Jul 15 2019, 3:13 AM · Restricted Project

Jul 1 2019

alexfh committed rGb101c39f5877: Fixed two issues in clang-tidy -help. (authored by alexfh).
Fixed two issues in clang-tidy -help.
Jul 1 2019, 11:56 AM
alexfh committed rL364837: Fixed two issues in clang-tidy -help..
Fixed two issues in clang-tidy -help.
Jul 1 2019, 11:56 AM

May 20 2019

alexfh accepted D62125: Run ClangTidy tests in all C++ language modes.

That's a quite impressive amount of work. Thanks! Looks good.

May 20 2019, 2:16 AM · Restricted Project, Restricted Project

May 14 2019

alexfh added a reviewer for D60543: [clang] Update isDerivedFrom to support Objective-C classes 🔍: gribozavr.
May 14 2019, 3:15 PM · Restricted Project, Restricted Project

May 9 2019

alexfh accepted D61739: check_clang_tidy.py now passes `-format-style=none` to clang_tidy.

LG, thanks!

May 9 2019, 9:20 AM · Restricted Project, Restricted Project

May 8 2019

alexfh accepted D61644: Documentation for bugprone-inaccurate-erase: added an example of a bug that this checker catches.

LG. Thank you!

May 8 2019, 4:31 AM · Restricted Project

May 7 2019

alexfh edited reviewers for D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule., added: ilya-biryukov, gribozavr; removed: alexfh, hokein.
May 7 2019, 7:50 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
alexfh edited reviewers for D61350: [clang-tidy] New check calling out uses of +new in Objective-C code, added: gribozavr, ilya-biryukov; removed: hokein, alexfh.
May 7 2019, 5:51 AM · Restricted Project, Restricted Project

May 6 2019

alexfh committed rLLD360040: [lld] A better version of the fix in r359942..
[lld] A better version of the fix in r359942.
May 6 2019, 5:14 AM
alexfh committed rG8b92ec521dec: [lld] A better version of the fix in r359942. (authored by alexfh).
[lld] A better version of the fix in r359942.
May 6 2019, 5:12 AM
alexfh committed rL360040: [lld] A better version of the fix in r359942..
[lld] A better version of the fix in r359942.
May 6 2019, 5:11 AM
alexfh added a comment to rL359942: [lld] Specify output file explicitly.

Perhaps even better would be to not create output at all. I.e -o /dev/null.

May 6 2019, 5:11 AM

May 3 2019

alexfh committed rG3f796f974d75: [lld] Specify output file explicitly (authored by alexfh).
[lld] Specify output file explicitly
May 3 2019, 4:10 PM
alexfh committed rLLD359942: [lld] Specify output file explicitly.
[lld] Specify output file explicitly
May 3 2019, 4:10 PM
alexfh committed rL359942: [lld] Specify output file explicitly.
[lld] Specify output file explicitly
May 3 2019, 4:10 PM
alexfh added a reviewer for D61487: [clang-tidy] Make the plugin honor NOLINT: gribozavr.
May 3 2019, 4:52 AM · Restricted Project, Restricted Project
alexfh added a comment to D61487: [clang-tidy] Make the plugin honor NOLINT.

Apart from NOLINT handling there's more logic in ClangTidyDiagnosticConsumer::HandleDiagnostic, which isn't properly transferred to ClangTidyContext::diag in this patch. The logic that is transferred seems to change the behavior w.r.t. notes that can "unmute" ignored warnings (see https://reviews.llvm.org/D59135#1456108). I suspect that we're missing proper test coverage here. Another issue is that compiler diagnostics don't pass ClangTidyContext::diag in the non-plugin use case. Do all the existing tests pass with your patch?

May 3 2019, 4:52 AM · Restricted Project, Restricted Project
alexfh added a comment to D61480: Added an AST matcher for declarations that are in the `std` namespace.

Please regenerate the HTML docs using clang/docs/tools/dump_ast_matchers.py.

May 3 2019, 1:59 AM · Restricted Project

Apr 24 2019

alexfh accepted D61106: [analyzer][UninitializedObjectChecker] PR41590: Regard _Atomic types as primitive.

LG. Thanks for the fix!

Apr 24 2019, 5:40 PM · Restricted Project
alexfh accepted D61060: [analyzer] ConditionBRVisitor: Test 'add-pop-up-notes=false'.

LG

Apr 24 2019, 5:53 AM · Restricted Project, Restricted Project

Apr 23 2019

alexfh added inline comments to D60629: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_check'.
Apr 23 2019, 4:05 PM · Restricted Project, Restricted Project
alexfh added a comment to D60670: [analyzer] [NFC] PathDiagnostic: Create PathDiagnosticPopUpPiece.

Can we add an option to enable or disable these notes similar to Clang's -fdiagnostics-show-option, -fdiagnostics-show-note-include-stack, etc?

@alexfh, add them as a Clang option with -f? I do not know how Clang Tidy would use that, so that I am not sure. I would create an AnalyzerOptions option as I see that far only.

Apr 23 2019, 8:37 AM · Restricted Project
alexfh accepted D59977: [Lexer] Fix an off-by-one bug in Lexer::getAsCharRange() - NFC..

LG with a comment.

Apr 23 2019, 3:30 AM · Restricted Project, Restricted Project

Apr 18 2019

alexfh created D60868: [clang-format] Fix an assertion failure.
Apr 18 2019, 7:36 AM · Restricted Project, Restricted Project
alexfh accepted D60857: [clang-tidy] Address post-commit comments.

There's one more nit. Otherwise good to go.

Apr 18 2019, 6:31 AM · Restricted Project
alexfh added inline comments to D60857: [clang-tidy] Address post-commit comments.
Apr 18 2019, 5:51 AM · Restricted Project

Apr 17 2019

alexfh committed rG68be3229879e: [clang-format] Remove unused Environment constructor. (authored by alexfh).
[clang-format] Remove unused Environment constructor.
Apr 17 2019, 5:40 PM
alexfh committed rC358630: [clang-format] Remove unused Environment constructor..
[clang-format] Remove unused Environment constructor.
Apr 17 2019, 5:40 PM
alexfh committed rL358630: [clang-format] Remove unused Environment constructor..
[clang-format] Remove unused Environment constructor.
Apr 17 2019, 5:39 PM
alexfh committed rG4c177038e096: [clang-tidy] Don't issue cppcoreguidelines-macro-usage on builtin macros (authored by alexfh).
[clang-tidy] Don't issue cppcoreguidelines-macro-usage on builtin macros
Apr 17 2019, 3:36 PM
alexfh committed rL358621: [clang-tidy] Don't issue cppcoreguidelines-macro-usage on builtin macros.
[clang-tidy] Don't issue cppcoreguidelines-macro-usage on builtin macros
Apr 17 2019, 3:36 PM
alexfh committed rCTE358621: [clang-tidy] Don't issue cppcoreguidelines-macro-usage on builtin macros.
[clang-tidy] Don't issue cppcoreguidelines-macro-usage on builtin macros
Apr 17 2019, 3:36 PM
alexfh accepted D60808: [analyzer] pr41335: NoStoreFuncVisitor: Fix crash when no-store event is in a body-farmed function..

LG with a couple of nits.

Apr 17 2019, 2:58 PM · Restricted Project
alexfh added a comment to D60670: [analyzer] [NFC] PathDiagnostic: Create PathDiagnosticPopUpPiece.
In D60670#1469494, @NoQ wrote:

Let's decide whether we want to display the new notes in the text output. @alexfh: Given that clang-tidy is the primary consumer of the analyzer's text output mode, would you rather have or rather not have these new note:s in the text output? (scroll to the bottom of D53076 to see how they look). In my opinion, i'd rather have them in text output (because text output is hard to navigate, and having the necessary information exactly where you need it would probably be helpful), but rather not have them in tools that parse clang-tidy notes and stuff them into a source code view in some GUI (such tools do exist, right?), so im confused. I'd also prefer to have them be off in text output in tests, because such tests usually test checker-specific notes and having more checker-inspecific notes in the tests is more annoying than useful. But that's pretty minor; i'll be happy to write them down every time i write a test if they are believed to be a good thing in text output in general.

Apr 17 2019, 2:52 PM · Restricted Project
alexfh added inline comments to D60629: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_check'.
Apr 17 2019, 12:41 PM · Restricted Project, Restricted Project
alexfh accepted D59812: [analyzer] PR41185: Fix regression where __builtin_* functions weren't recognized.

Awesome, thanks!
LG

Apr 17 2019, 12:21 PM · Restricted Project, Restricted Project
alexfh added a comment to rL358576: [clang-tidy] Add fix descriptions to clang-tidy checks..

A few post-commit comments.

Apr 17 2019, 10:45 AM
alexfh added a comment to D59812: [analyzer] PR41185: Fix regression where __builtin_* functions weren't recognized.

Artem, I'd appreciate, if you found time to finish this fix. The bug is causing most failures in our setup. Thanks!

Apr 17 2019, 10:03 AM · Restricted Project, Restricted Project
alexfh committed rGe31fe508e890: [clang-tidy] Fix invalid location in readability-misleading-indentation… (authored by alexfh).
[clang-tidy] Fix invalid location in readability-misleading-indentation…
Apr 17 2019, 9:24 AM
alexfh committed rCTE358589: [clang-tidy] Fix invalid location in readability-misleading-indentation….
[clang-tidy] Fix invalid location in readability-misleading-indentation…
Apr 17 2019, 9:18 AM
alexfh committed rL358589: [clang-tidy] Fix invalid location in readability-misleading-indentation….
[clang-tidy] Fix invalid location in readability-misleading-indentation…
Apr 17 2019, 9:18 AM

Apr 16 2019

alexfh added inline comments to D60629: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_check'.
Apr 16 2019, 1:35 PM · Restricted Project, Restricted Project
alexfh requested changes to D60776: [clang-tidy] Add test support for the fix description..
Apr 16 2019, 1:07 PM · Restricted Project

Apr 15 2019

alexfh accepted D59932: [clang-tidy] Add fix descriptions to clang-tidy checks..

Thanks! The change looks good now.

Apr 15 2019, 7:51 AM · Restricted Project, Restricted Project

Apr 10 2019

alexfh committed rG8eae988b89a1: Fix a typo (authored by alexfh).
Fix a typo
Apr 10 2019, 8:42 AM
alexfh committed rL358092: Fix a typo.
Fix a typo
Apr 10 2019, 8:41 AM
alexfh added a comment to D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.

Thanks for the useful check! I have a few comments, see inline.

Apr 10 2019, 6:15 AM · Restricted Project, Restricted Project, Restricted Project

Apr 8 2019

alexfh committed rG10d6008f8523: Remove a bogus sed option in test. (authored by alexfh).
Remove a bogus sed option in test.
Apr 8 2019, 9:37 AM
alexfh committed rC357922: Remove a bogus sed option in test..
Remove a bogus sed option in test.
Apr 8 2019, 9:37 AM
alexfh committed rL357922: Remove a bogus sed option in test..
Remove a bogus sed option in test.
Apr 8 2019, 9:37 AM