Page MenuHomePhabricator

alexfh (Alexander Kornienko)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 10 2012, 10:35 AM (393 w, 5 d)

Recent Activity

Thu, Jan 23

alexfh accepted D73236: [clang-tidy] Add clang-tidy headers to clang distribution.

LG with an outstanding comment.

Thu, Jan 23, 3:43 PM · Restricted Project, Restricted Project

Tue, Jan 21

alexfh added a reviewer for D72242: Fix crash on value dependent bitfields in if conditions in templates: gribozavr2.
Tue, Jan 21, 1:35 AM

Mon, Jan 13

alexfh added a comment to D72527: [clang-tidy] adjust scripts to subsubsections in Release Notes.

Both scripts works fine. However rename script should also sort entries alphabetically, but probably this should be separate patch.

Mon, Jan 13, 10:25 AM · Restricted Project, Restricted Project
alexfh added a comment to D72527: [clang-tidy] adjust scripts to subsubsections in Release Notes.

LG with a nit, if this works.

Mon, Jan 13, 6:07 AM · Restricted Project, Restricted Project

Thu, Jan 9

alexfh accepted D72421: [clang-tidy] Refresh the add_new_check.py now that we use a table + autofix.

Awesome! Thanks for updating the script! A few nits, otherwise LG, if this works.

Thu, Jan 9, 7:43 AM · Restricted Project, Restricted Project

Wed, Jan 8

alexfh added a comment to D71594: testing clang-tidy.

What version of clang-tidy and clang-format does this run? Whatever is available in Debian packages?

Wed, Jan 8, 8:28 AM · Restricted Project, Restricted Project

Fri, Jan 3

alexfh added a comment to D36051: Move from a long list of checkers to tables.

This list used to be automatically updated by the clang-tools-extra/clang-tidy/add_new_check.py script. I suppose, this is broken now?

Fri, Jan 3, 11:50 AM · Restricted Project

Dec 12 2019

alexfh committed rG65996c302a44: [clang-tidy] Use early returns to make the code easier to read and potentially… (authored by alexfh).
[clang-tidy] Use early returns to make the code easier to read and potentially…
Dec 12 2019, 8:05 AM
alexfh committed rG2b09390c1362: Fix naming style. NFC. (authored by alexfh).
Fix naming style. NFC.
Dec 12 2019, 8:05 AM

Dec 10 2019

alexfh requested changes to D69782: Summary: Instead of dropping all the ranges associated with a Diagnostic when converting them to a ClangTidy error, instead attach them to the ClangTidyError, so they can be consumed by other APIs..
Dec 10 2019, 5:43 AM · Restricted Project

Dec 6 2019

alexfh committed rGfac4e3c5f8a0: [clang-tidy] Fix PR26274 (authored by alexfh).
[clang-tidy] Fix PR26274
Dec 6 2019, 1:13 AM
alexfh closed D70974: [clang-tidy] Fix PR26274.
Dec 6 2019, 1:13 AM · Restricted Project

Dec 5 2019

alexfh added inline comments to D70974: [clang-tidy] Fix PR26274.
Dec 5 2019, 3:16 AM · Restricted Project
alexfh updated the diff for D70974: [clang-tidy] Fix PR26274.
  • Added a test with an empty attribute list.
Dec 5 2019, 3:16 AM · Restricted Project

Dec 4 2019

alexfh added a comment to D70974: [clang-tidy] Fix PR26274.

I'm not convinced this feature is worth implementing at all, because there's a good alternative to a macro here -- a namespace alias. What is the reason to use a macro instead of a namespace alias?

While I think that's a superior solution to using macros, some users have macros instead. This fixes a bug reported in https://bugs.llvm.org/show_bug.cgi?id=26274 and I agree that the behavior described in that bug is not what I would expect it to be.

I mean, it is possible to break pretty much any ClangTidy check with sneaky code. But there's a limit to which we should try to make things work in tricky corner cases. For example, the fix in this patch does not handle function-like macros (namespace MY_LIBRARY_NAMESPACE_FOR_VERSION(42) {).

LGTM if we must... but I don't think we should.

Dec 4 2019, 9:32 AM · Restricted Project
alexfh updated the diff for D70974: [clang-tidy] Fix PR26274.
  • Added support for inline namespaces and namespace attributes, fixed a typo, added tests.
Dec 4 2019, 8:17 AM · Restricted Project

Dec 3 2019

alexfh committed rGc375dc230d16: Revert "Fix llvm-namespace-comment for macro expansions" (authored by alexfh).
Revert "Fix llvm-namespace-comment for macro expansions"
Dec 3 2019, 11:38 AM
alexfh added a reverting change for rG4736d63f752f: Fix llvm-namespace-comment for macro expansions: rGc375dc230d16: Revert "Fix llvm-namespace-comment for macro expansions".
Dec 3 2019, 11:38 AM
alexfh created D70974: [clang-tidy] Fix PR26274.
Dec 3 2019, 11:38 AM · Restricted Project
alexfh added a comment to D69855: [clang-tidy] Fix llvm-namespace-comment for macro expansions.

There's a problem with this patch. Consider the following code:

// In some remote header:
#define SOME_RANDOM_MACRO internal
Dec 3 2019, 7:27 AM · Restricted Project, Restricted Project

Nov 28 2019

alexfh added inline comments to D68682: format::cleanupAroundReplacements removes whole line when Removals leave previously non-blank line blank.
Nov 28 2019, 8:17 AM · Restricted Project, Restricted Project

Nov 27 2019

alexfh added a comment to D69746: [analyzer] FixItHint: Apply and test hints with the Clang Tidy's script.

The only way I know people apply fixits is with the help of IDEs.

Nov 27 2019, 11:23 AM · Restricted Project
alexfh accepted D46027: [clang-tidy] Fix PR35824.

This approach will also introduce false negatives.

Nov 27 2019, 10:45 AM · Restricted Project

Nov 26 2019

alexfh committed rGaa0e92e1f706: [clang-tidy] Use range-for for check registration. NFC (authored by alexfh).
[clang-tidy] Use range-for for check registration. NFC
Nov 26 2019, 7:48 AM

Nov 14 2019

alexfh added a comment to D70165: clang-tidy: modernize-use-override new option AllowOverrideAndFinal.

While I have no objections against this patch, I wonder whether someone had a chance to ask GCC developers about this? Is it a conscious choice to suggest override when final is present? What's the argument for doing so?

Nov 14 2019, 5:02 AM · Restricted Project

Oct 18 2019

alexfh added inline comments to D68885: Add a Ranges field to Diagnostic struct.
Oct 18 2019, 7:13 AM · Restricted Project, Restricted Project

Oct 16 2019

alexfh accepted D69036: [libTooling] Fix r374962: add more Transformer forwarding decls..

LG.

Oct 16 2019, 7:21 AM · Restricted Project

Oct 14 2019

alexfh added a comment to D68682: format::cleanupAroundReplacements removes whole line when Removals leave previously non-blank line blank.

Thanks, from the name that sounds like the perfect place to do it. If cleanupAroundReplacements also is used by clang-format, would we want to make the functionality optional, e.g. via a new bool parameter to cleanupAroundReplacements, a new option in FormatStyle, etc.?

Oct 14 2019, 1:16 AM · Restricted Project, Restricted Project

Oct 11 2019

alexfh accepted D68807: [ClangTidy] Separate tests for infrastructure and checkers.

I agree that the test/clang-tidy directory has become hard to navigate. Splitting tests for checks and for infrastructure seems reasonable to me. I personally don't care about specific directory names and file moves/renames are also not a concern, since git is rather good at handling those. I personally strongly prefer long-term improvements over desire to minimize churn.

Oct 11 2019, 4:51 AM · Restricted Project

Sep 26 2019

alexfh edited reviewers for D67865: [clang-tidy] Finds uses of OSRead* calls on macOS that may mask unexpected behavior due to unaligned reads, added: gribozavr; removed: alexfh.
Sep 26 2019, 2:07 AM · Restricted Project

Sep 23 2019

alexfh added a comment to D67501: [clang-tidy] Fix relative path in header-filter..

Sorry, I reverted this patch in r372601.

Unfortunately, it makes paths printed in clang-tidy'd diagnostics inconsistent with what -header-filter operates on.

For example, imagine that file-filter.cpp includes header_alias.h, which is a symlink to header.h. The diagnostics printed by clang-tidy refer to header_alias.h, however, after this patch, -header-filter logic calls realpath() and operates on header.h -- making it very difficult for users to understand how exactly to set up filters.

Also, note that paths in diagnostics don't collapse foo/.. or symlinks.

We should only change both sides of path handling simultaneously (paths in diagnostics and paths in filters). However, since getting the user's preferred path is potentially very difficult when symlinks are present, I'm not sure if anything can be done here. Maybe only collapsing foo/.. would be viable?

Sep 23 2019, 6:51 AM · Restricted Project, Restricted Project, Restricted Project

Sep 18 2019

alexfh edited reviewers for D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage, added: gribozavr; removed: alexfh.
Sep 18 2019, 6:30 AM · Restricted Project, Restricted Project, Restricted Project

Sep 17 2019

alexfh added a comment to D45050: [clang-tidy] New checker for not null-terminated result caused by strlen(), size() or equal length.

A couple of drive-by comments.

Sep 17 2019, 6:42 AM · Restricted Project, Restricted Project
alexfh removed a reviewer for D65917: [clang-tidy] Added check for the Google style guide's category method naming rule.: alexfh.
Sep 17 2019, 5:32 AM · Restricted Project, Restricted Project

Sep 5 2019

alexfh committed rG30424e4268e2: [clang-tidy] Make most ArgumentCommentCheck options local, as they should be (authored by alexfh).
[clang-tidy] Make most ArgumentCommentCheck options local, as they should be
Sep 5 2019, 7:49 AM
alexfh committed rG42443e50cedd: Add a bugprone-argument-comment option: IgnoreSingleArgument. (authored by alexfh).
Add a bugprone-argument-comment option: IgnoreSingleArgument.
Sep 5 2019, 7:49 AM
alexfh committed rL371076: [clang-tidy] Make most ArgumentCommentCheck options local, as they should be.
[clang-tidy] Make most ArgumentCommentCheck options local, as they should be
Sep 5 2019, 7:48 AM
alexfh committed rL371075: Add a bugprone-argument-comment option: IgnoreSingleArgument..
Add a bugprone-argument-comment option: IgnoreSingleArgument.
Sep 5 2019, 7:48 AM
alexfh closed D67056: Add a bugprone-argument-comment option: IgnoreSingleArgument..
Sep 5 2019, 7:48 AM · Restricted Project, Restricted Project
alexfh committed rGb6d9703050d0: [clang-tidy] Fix bugprone-argument-comment bug: negative literal number is not… (authored by alexfh).
[clang-tidy] Fix bugprone-argument-comment bug: negative literal number is not…
Sep 5 2019, 7:15 AM
alexfh committed rL371072: [clang-tidy] Fix bugprone-argument-comment bug: negative literal number is not….
[clang-tidy] Fix bugprone-argument-comment bug: negative literal number is not…
Sep 5 2019, 7:15 AM
alexfh closed D67084: [clang-tidy] Fix bugprone-argument-comment bug: negative literal number is not checked..
Sep 5 2019, 7:15 AM · Restricted Project, Restricted Project, Restricted Project

Sep 4 2019

alexfh added a comment to D67084: [clang-tidy] Fix bugprone-argument-comment bug: negative literal number is not checked..
In D67084#1657534, @xyb wrote:

Thanks. BTW, I can't commit the patch by myself.

Sep 4 2019, 9:50 AM · Restricted Project, Restricted Project, Restricted Project
alexfh added inline comments to D67056: Add a bugprone-argument-comment option: IgnoreSingleArgument..
Sep 4 2019, 9:50 AM · Restricted Project, Restricted Project
alexfh committed rG240a2e25c6de: [clang-tidy] Fix bugprone-argument-comment bug if there are marcos. (authored by alexfh).
[clang-tidy] Fix bugprone-argument-comment bug if there are marcos.
Sep 4 2019, 9:21 AM
alexfh committed rL370919: [clang-tidy] Fix bugprone-argument-comment bug if there are marcos..
[clang-tidy] Fix bugprone-argument-comment bug if there are marcos.
Sep 4 2019, 9:21 AM
alexfh closed D67080: [clang-tidy] Fix bugprone-argument-comment bug if there are marcos..
Sep 4 2019, 9:20 AM · Restricted Project, Restricted Project, Restricted Project
alexfh added a comment to D67056: Add a bugprone-argument-comment option: IgnoreSingleArgument..
In D67056#1657540, @xyb wrote:

Thanks. BTW, I can't commit the patch by myself.

Sep 4 2019, 8:55 AM · Restricted Project, Restricted Project
alexfh accepted D67084: [clang-tidy] Fix bugprone-argument-comment bug: negative literal number is not checked..

LG if there are no other concerns.

Sep 4 2019, 7:01 AM · Restricted Project, Restricted Project, Restricted Project
alexfh accepted D67056: Add a bugprone-argument-comment option: IgnoreSingleArgument..

LG with a comment.

Sep 4 2019, 6:58 AM · Restricted Project, Restricted Project
alexfh accepted D67080: [clang-tidy] Fix bugprone-argument-comment bug if there are marcos..

LG. Thanks!

Sep 4 2019, 6:54 AM · Restricted Project, Restricted Project, Restricted Project
alexfh added a comment to D67084: [clang-tidy] Fix bugprone-argument-comment bug: negative literal number is not checked..

Please add full context to the diff. See https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface

Sep 4 2019, 6:44 AM · Restricted Project, Restricted Project, Restricted Project
alexfh added a reviewer for D67140: [analyzer][NFC] Fix inconsistent references to checkers as "checks": aaron.ballman.

Thanks! Yay consistency.

I prefer the term "checker" to refer to individual modules because I feel it is more precise and less ambiguous. In phrases like "malloc check", "make_unique check", it is unclear what does the check -- malloc itself, the caller of malloc, or something else. Therefore, I would be supportive of repainting ClangTidy to also use "checker", but I would want to know what @alexfh thinks about it before we do it in ClangTidy.

Sep 4 2019, 6:24 AM · Restricted Project, Restricted Project

Aug 30 2019

alexfh added a comment to D66505: Make add_new_check.py's insertion of registerCheck<> match the sort order.

Mostly LG, if you've verified that this works. A couple of comments below.

Aug 30 2019, 4:51 AM · Restricted Project, Restricted Project

Aug 23 2019

alexfh added a comment to D66505: Make add_new_check.py's insertion of registerCheck<> match the sort order.

Given that the alphabetization we want really is based on the string literal, would it make sense to look for that rather than the check name? Adding a few more reviewers for a better mix of opinions.

Ideally, it would be nice to sort the list of registrations by the check name. But given that the call can span two lines, that may be slightly trickier to implement. It's worth giving it a try though ;)

Aug 23 2019, 3:14 AM · Restricted Project, Restricted Project

Aug 20 2019

alexfh added inline comments to D62829: [clang-tidy] Check for dynamically initialized statics in headers..
Aug 20 2019, 6:57 AM · Restricted Project, Restricted Project, Restricted Project

Aug 16 2019

alexfh added a comment to D65065: [clang-tidy] Possibility of displaying duplicate warnings.

Just FYI, https://bugs.llvm.org/show_bug.cgi?id=43019 is relevant.

Aug 16 2019, 6:32 AM · Restricted Project, Restricted Project
alexfh accepted D65065: [clang-tidy] Possibility of displaying duplicate warnings.

LG. Thanks!

Aug 16 2019, 6:32 AM · Restricted Project, Restricted Project

Aug 14 2019

alexfh added a comment to D66042: [analyzer] Analysis: Silence checkers.
In D66042#1627760, @NoQ wrote:

But without this patch clang seems to have the same two ANALYZE log lines regardless of whether I enable core checkers or not

Yup, it seems as if clang-tidy enables core as long as at least one Static Analyzer checker is enabled (even if it's path-insensitive).

Aug 14 2019, 4:11 AM · Restricted Project, Restricted Project

Aug 13 2019

alexfh added a comment to D66042: [analyzer] Analysis: Silence checkers.
In D66042#1625898, @NoQ wrote:

While we're here: i poked your silencing mechanism a little bit and even though i'm still pretty sure you couldn't have done it perfectly without our help, it sounds as if the only problem you have with it is that the path-sensitive checkers keep running even if only path-insensitive checkers are enabled:

$ clang-tidy test.c -checks=-*,clang-analyzer-unix.cstring.BadSizeArg -- -Xclang -analyzer-display-progress

ANALYZE (Syntax): /Users/adergachev/test/test.c foo                         // <== only this part will actually influence
                                                                            //     the results of analysis in this invocation
ANALYZE (Path,  Inline_Regular): /Users/adergachev/test/test.c foo          // <== however this part is sloooooow

This may be a performance issue for users who want fast analysis but are interested in some path-insensitive Static Analyzer checks (and they don't seem to have a way around that when they limit themselves to clang-tidy's own CLI), but apart from that you indeed seem to be fine.

Aug 13 2019, 8:31 AM · Restricted Project, Restricted Project

Aug 12 2019

alexfh added a reviewer for D66042: [analyzer] Analysis: Silence checkers: gribozavr.
Aug 12 2019, 7:34 AM · Restricted Project, Restricted Project
alexfh added a comment to D66042: [analyzer] Analysis: Silence checkers.
In D66042#1624081, @NoQ wrote:

+@alexfh because clang-tidy now finally has a way of safely disabling core checkers without causing crashes all over the place! Would you like to take the same approach as we picked in scan-build, i.e. when the user asks to disable a core checker, silence it instead?

Aug 12 2019, 7:32 AM · Restricted Project, Restricted Project
alexfh added a comment to D55125: [clang-tidy] Fix a false positive in misc-redundant-expression check.

One more nit.

Aug 12 2019, 7:19 AM · Restricted Project

Aug 7 2019

alexfh added a comment to D65065: [clang-tidy] Possibility of displaying duplicate warnings.

This suggestion would result another strange behavior: if the user disables cert-err09-cpp because he or she doesn't want to see its reports, the other one (cert-err61-cpp) will still report the issue. So he or she has to disable both (or as many aliases it has).

That seems to be the case regardless of the implementation strategy in this patch.

Aug 7 2019, 8:12 AM · Restricted Project, Restricted Project

Jul 26 2019

alexfh added a comment to D64671: [clang-tidy] New check: misc-init-local-variables.

A general comment: "misc" is a sort of a heap of checks that otherwise don't have a good home. This one would probably better go to bugprone (or maybe there's a relevant CERT or C++ Core Guidelines rule?).

Jul 26 2019, 5:26 PM · Restricted Project
alexfh added a comment to D65065: [clang-tidy] Possibility of displaying duplicate warnings.

I think it will be a strict improvement to include the check name into the deduplication key (probably after the file and offset and before the message). I don't see any reason to hide this behind a flag or otherwise retain the old behavior. As for expanding the key to include notes and fixes - it's probably good to do this either, and this may help uncover incorrect behavior of some checks. I'd suggest to start with the check name though.

Jul 26 2019, 5:20 PM · Restricted Project, Restricted Project

Jul 22 2019

alexfh added a comment to D65065: [clang-tidy] Possibility of displaying duplicate warnings.

LessClangTidyError only compares location and message, but it could also compare other things like notes, fixes, etc. For the problem outlined in the description of this patch we can probably include the checker name into the key. WDYT?

Jul 22 2019, 4:43 PM · Restricted Project, Restricted Project

Jul 18 2019

alexfh added inline comments to D64671: [clang-tidy] New check: misc-init-local-variables.
Jul 18 2019, 5:14 AM · Restricted Project

Jul 17 2019

alexfh added a comment to D55044: [clang-tidy] check for Abseil make_unique.

Seems good now. Haojian, do you have any concerns?

Jul 17 2019, 7:50 AM · Restricted Project
alexfh accepted D64861: [clang-tidy] Adjust location of namespace comment diagnostic.

LG. Thanks!

Jul 17 2019, 6:52 AM · Restricted Project, Restricted Project
alexfh added inline comments to D64671: [clang-tidy] New check: misc-init-local-variables.
Jul 17 2019, 6:48 AM · Restricted Project
alexfh added inline comments to D33841: [clang-tidy] redundant 'extern' keyword check.
Jul 17 2019, 5:56 AM · Restricted Project
alexfh added a comment to D33841: [clang-tidy] redundant 'extern' keyword check.

Hi, do you have any additional comments?

Jul 17 2019, 5:43 AM · Restricted Project

Jul 16 2019

alexfh added inline comments to D64671: [clang-tidy] New check: misc-init-local-variables.
Jul 16 2019, 5:18 AM · Restricted Project

Jul 15 2019

alexfh added inline comments to D64671: [clang-tidy] New check: misc-init-local-variables.
Jul 15 2019, 6:49 AM · Restricted Project
alexfh added inline comments to D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files.
Jul 15 2019, 3:13 AM · Restricted Project

Jul 1 2019

alexfh committed rGb101c39f5877: Fixed two issues in clang-tidy -help. (authored by alexfh).
Fixed two issues in clang-tidy -help.
Jul 1 2019, 11:56 AM
alexfh committed rL364837: Fixed two issues in clang-tidy -help..
Fixed two issues in clang-tidy -help.
Jul 1 2019, 11:56 AM

May 20 2019

alexfh accepted D62125: Run ClangTidy tests in all C++ language modes.

That's a quite impressive amount of work. Thanks! Looks good.

May 20 2019, 2:16 AM · Restricted Project, Restricted Project

May 14 2019

alexfh added a reviewer for D60543: [clang] Update isDerivedFrom to support Objective-C classes 🔍: gribozavr.
May 14 2019, 3:15 PM · Restricted Project, Restricted Project

May 9 2019

alexfh accepted D61739: check_clang_tidy.py now passes `-format-style=none` to clang_tidy.

LG, thanks!

May 9 2019, 9:20 AM · Restricted Project, Restricted Project

May 8 2019

alexfh accepted D61644: Documentation for bugprone-inaccurate-erase: added an example of a bug that this checker catches.

LG. Thank you!

May 8 2019, 4:31 AM · Restricted Project

May 7 2019

alexfh edited reviewers for D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule., added: ilya-biryukov, gribozavr; removed: alexfh, hokein.
May 7 2019, 7:50 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
alexfh edited reviewers for D61350: [clang-tidy] New check calling out uses of +new in Objective-C code, added: gribozavr, ilya-biryukov; removed: hokein, alexfh.
May 7 2019, 5:51 AM · Restricted Project, Restricted Project

May 6 2019

alexfh committed rLLD360040: [lld] A better version of the fix in r359942..
[lld] A better version of the fix in r359942.
May 6 2019, 5:14 AM
alexfh committed rG8b92ec521dec: [lld] A better version of the fix in r359942. (authored by alexfh).
[lld] A better version of the fix in r359942.
May 6 2019, 5:12 AM
alexfh committed rL360040: [lld] A better version of the fix in r359942..
[lld] A better version of the fix in r359942.
May 6 2019, 5:11 AM
alexfh added a comment to rL359942: [lld] Specify output file explicitly.

Perhaps even better would be to not create output at all. I.e -o /dev/null.

May 6 2019, 5:11 AM

May 3 2019

alexfh committed rG3f796f974d75: [lld] Specify output file explicitly (authored by alexfh).
[lld] Specify output file explicitly
May 3 2019, 4:10 PM
alexfh committed rLLD359942: [lld] Specify output file explicitly.
[lld] Specify output file explicitly
May 3 2019, 4:10 PM
alexfh committed rL359942: [lld] Specify output file explicitly.
[lld] Specify output file explicitly
May 3 2019, 4:10 PM
alexfh added a reviewer for D61487: [clang-tidy] Make the plugin honor NOLINT: gribozavr.
May 3 2019, 4:52 AM · Restricted Project, Restricted Project
alexfh added a comment to D61487: [clang-tidy] Make the plugin honor NOLINT.

Apart from NOLINT handling there's more logic in ClangTidyDiagnosticConsumer::HandleDiagnostic, which isn't properly transferred to ClangTidyContext::diag in this patch. The logic that is transferred seems to change the behavior w.r.t. notes that can "unmute" ignored warnings (see https://reviews.llvm.org/D59135#1456108). I suspect that we're missing proper test coverage here. Another issue is that compiler diagnostics don't pass ClangTidyContext::diag in the non-plugin use case. Do all the existing tests pass with your patch?

May 3 2019, 4:52 AM · Restricted Project, Restricted Project
alexfh added a comment to D61480: Added an AST matcher for declarations that are in the `std` namespace.

Please regenerate the HTML docs using clang/docs/tools/dump_ast_matchers.py.

May 3 2019, 1:59 AM · Restricted Project

Apr 24 2019

alexfh accepted D61106: [analyzer][UninitializedObjectChecker] PR41590: Regard _Atomic types as primitive.

LG. Thanks for the fix!

Apr 24 2019, 5:40 PM · Restricted Project
alexfh accepted D61060: [analyzer] ConditionBRVisitor: Test 'add-pop-up-notes=false'.

LG

Apr 24 2019, 5:53 AM · Restricted Project, Restricted Project

Apr 23 2019

alexfh added inline comments to D60629: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_check'.
Apr 23 2019, 4:05 PM · Restricted Project, Restricted Project
alexfh added a comment to D60670: [analyzer] [NFC] PathDiagnostic: Create PathDiagnosticPopUpPiece.

Can we add an option to enable or disable these notes similar to Clang's -fdiagnostics-show-option, -fdiagnostics-show-note-include-stack, etc?

@alexfh, add them as a Clang option with -f? I do not know how Clang Tidy would use that, so that I am not sure. I would create an AnalyzerOptions option as I see that far only.

Apr 23 2019, 8:37 AM · Restricted Project
alexfh accepted D59977: [Lexer] Fix an off-by-one bug in Lexer::getAsCharRange() - NFC..

LG with a comment.

Apr 23 2019, 3:30 AM · Restricted Project, Restricted Project

Apr 18 2019

alexfh created D60868: [clang-format] Fix an assertion failure.
Apr 18 2019, 7:36 AM · Restricted Project, Restricted Project