alexfh (Alexander Kornienko)
User

Projects

User does not belong to any projects.
User Since
Jul 10 2012, 10:35 AM (245 w, 4 d)

Recent Activity

Fri, Mar 24

alexfh added a comment to D31308: [clang-tidy] new check readability-no-alternative-tokens.

FWIW, I'm pretty sure this can and should be done on the lexer level - it will be faster and more universal.

Fri, Mar 24, 4:33 AM
alexfh added a comment to D31308: [clang-tidy] new check readability-no-alternative-tokens.

So I would propose to keep the features as-is for now,
change the name to readability-operators-representation, and then later (someone else?) might also add an option
for making this work the other way around. Would that be ok for you?

Fri, Mar 24, 4:31 AM
alexfh added a comment to D31308: [clang-tidy] new check readability-no-alternative-tokens.

Thanks for your feedback, Eugene!

I'm not sure if it would be helpful to have this check in both ways. I did a code search for "not_eq", "bitand" and "and_eq"
on github, and their usage seems to be a clear minority.

So I would propose to keep the features as-is for now,
change the name to readability-operators-representation, and then later (someone else?) might also add an option
for making this work the other way around. Would that be ok for you?

Were you refering to https://reviews.llvm.org/D25195 ("[lit] Fix FormatError on individual test timeout")?

Fri, Mar 24, 4:28 AM
alexfh added a comment to D29262: Fixes to modernize-use-using.

I have plan to finish this patch next week, when I finish academic year at my school. If I will have any issues with submitting, Prazek offered to help me.

Fri, Mar 24, 4:08 AM

Thu, Mar 23

alexfh committed rL298619: [clang-tidy] Don't use groups in the big regexy filter.
[clang-tidy] Don't use groups in the big regexy filter
Thu, Mar 23, 9:42 AM
alexfh added a comment to D29262: Fixes to modernize-use-using.

Krystyna, do you need help committing the patch after you address the outstanding comments?

Thu, Mar 23, 8:33 AM
alexfh committed rL298608: [clang-tidy] Fix diag message for catch-by-value.
[clang-tidy] Fix diag message for catch-by-value
Thu, Mar 23, 8:30 AM
alexfh closed D30592: [clang-tidy] Fix diag message for catch-by-value by committing rL298608: [clang-tidy] Fix diag message for catch-by-value.
Thu, Mar 23, 8:30 AM
alexfh added a comment to D29858: [clang-tidy] Catch trivially true statements like a != 1 || a != 3.

Following up. Was this checked in? Do I need to do anything further?

Thu, Mar 23, 8:28 AM
alexfh committed rL298607: [clang-tidy] Catch trivially true statements like a != 1 || a != 3.
[clang-tidy] Catch trivially true statements like a != 1 || a != 3
Thu, Mar 23, 8:26 AM
alexfh closed D29858: [clang-tidy] Catch trivially true statements like a != 1 || a != 3 by committing rL298607: [clang-tidy] Catch trivially true statements like a != 1 || a != 3.
Thu, Mar 23, 8:26 AM
alexfh accepted D30567: [clang-tidy] Fix treating non-space whitespaces in checks list..

Do you have commit rights?

Thu, Mar 23, 8:25 AM
alexfh removed reviewers for D15797: [clang-tidy] Fix readability-braces-around-statements assert failure: aaron.ballman, alexfh.
Thu, Mar 23, 7:39 AM
alexfh requested changes to D31252: [clang-tidy] add readability-compound-statement-size check..

Hi Roman,

Thu, Mar 23, 7:28 AM · Restricted Project

Wed, Mar 22

alexfh added a comment to D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy.

A late comment here: the check seems to suit better readability module instead of misc. Could you move it there?

Wed, Mar 22, 9:38 AM
alexfh added inline comments to D30567: [clang-tidy] Fix treating non-space whitespaces in checks list..
Wed, Mar 22, 7:53 AM
alexfh added a comment to D30567: [clang-tidy] Fix treating non-space whitespaces in checks list..

There's one more trim() you missed. And the test needs to be updated (s/\\n/ /).

Wed, Mar 22, 7:53 AM
alexfh added a comment to D31130: B32239 clang-tidy should not warn about array to pointer decay on system macros.

This change was reverted in r298470. The use of the <assert.h> include is a problem because this is not a clang-supplied header file. Also, there's a (good) question about what array decay is happening in the assert(false) test case.

Wed, Mar 22, 6:04 AM
alexfh committed rL298500: [clang-tidy] clang-format the last patch. NFC.
[clang-tidy] clang-format the last patch. NFC
Wed, Mar 22, 6:02 AM
alexfh committed rL298501: [clang-tidy] Tests should not rely on STL headers being available..
[clang-tidy] Tests should not rely on STL headers being available.
Wed, Mar 22, 6:02 AM
alexfh committed rL298499: [clang-tidy] modified identifier naming case to use CT_AnyCase for ignoring….
[clang-tidy] modified identifier naming case to use CT_AnyCase for ignoring…
Wed, Mar 22, 6:02 AM
alexfh closed D30931: [clang-tidy] modified identifier naming case to use CT_AnyCase for ignoring case style by committing rL298499: [clang-tidy] modified identifier naming case to use CT_AnyCase for ignoring….
Wed, Mar 22, 6:02 AM
alexfh added a comment to D30567: [clang-tidy] Fix treating non-space whitespaces in checks list..

Hi Alex and sorry for the late reply.

The main use case is a more readable .clang-tidy configuration checks.
Before this correction one can use something like this:

---
Checks: '
    ,*,
    ,-cert-dcl03-c,
'
...

It works, but is hardly comprehensible to a newbie (the strange use of addtional commas).
Since the spaces are ignored (since a recent commit of yours) we can add spaces after the leading comma and hope that no user uses a tab...

After applying this patch, we can just write (with tabs or spaces and as many newlines as we want - used for grouping for instance):

---
Checks: '
    *,
    -cert-dcl03-c,
'
...

Additionaly, you can sometimes accidentally issue a tabulator on the command line and that's just nice to ignore it.

Wed, Mar 22, 3:38 AM
alexfh accepted D30931: [clang-tidy] modified identifier naming case to use CT_AnyCase for ignoring case style.

A couple of nits, otherwise looks good. Do you need me to commit the patch for you?

Wed, Mar 22, 3:11 AM

Mon, Mar 20

alexfh created D31160: [clang-tidy] Fix misc-move-const-arg for move-only types..
Mon, Mar 20, 4:33 PM
alexfh committed rL298316: [clang-tidy] readability-container-size-empty fix for (*x).size().
[clang-tidy] readability-container-size-empty fix for (*x).size()
Mon, Mar 20, 3:27 PM
alexfh committed rL298315: [clang-tidy] Small cleanup. NFC..
[clang-tidy] Small cleanup. NFC.
Mon, Mar 20, 3:27 PM

Sat, Mar 18

alexfh added a comment to D31097: [clang-tidy] don't warn about implicit widening casts in function calls.

I wonder whether warning on implicit casts still makes sense for example in mission critical code. So maybe it is worth to have a configuration option with the default setting being less strict and chatty. What do you think?

But it's not about "misplaced casts", it's about implicit conversions and -Wconversion diagnostic can take care of this.

Sat, Mar 18, 2:47 AM
alexfh added a comment to D31097: [clang-tidy] don't warn about implicit widening casts in function calls.

I wonder whether warning on implicit casts still makes sense for example in mission critical code. So maybe it is worth to have a configuration option with the default setting being less strict and chatty. What do you think?

Sat, Mar 18, 2:38 AM

Fri, Mar 17

alexfh added a comment to D30931: [clang-tidy] modified identifier naming case to use CT_AnyCase for ignoring case style.

Could you generate a diff with full context (http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface)?

Fri, Mar 17, 10:33 AM
alexfh committed rL298101: [Clang-tidy] Fix for misc-noexcept-move-constructor false triggers on defaulted….
[Clang-tidy] Fix for misc-noexcept-move-constructor false triggers on defaulted…
Fri, Mar 17, 9:52 AM
alexfh closed D31049: [Clang-tidy] Fix for misc-noexcept-move-constructor false triggers on defaulted declarations by committing rL298101: [Clang-tidy] Fix for misc-noexcept-move-constructor false triggers on defaulted….
Fri, Mar 17, 9:52 AM · Restricted Project
alexfh added a comment to D31049: [Clang-tidy] Fix for misc-noexcept-move-constructor false triggers on defaulted declarations.

Do you have commit rights?

Fri, Mar 17, 6:07 AM · Restricted Project
alexfh accepted D31049: [Clang-tidy] Fix for misc-noexcept-move-constructor false triggers on defaulted declarations.

LG

Fri, Mar 17, 6:06 AM · Restricted Project
alexfh committed rL298060: [clang-tidy] Added a test with a different format..
[clang-tidy] Added a test with a different format.
Fri, Mar 17, 3:17 AM
alexfh committed rL298059: [clang-tidy] readability-misleading-indentation: fix chained if.
[clang-tidy] readability-misleading-indentation: fix chained if
Fri, Mar 17, 3:10 AM
alexfh closed D30841: [clang-tidy] readability-misleading-indentation: fix chained if by committing rL298059: [clang-tidy] readability-misleading-indentation: fix chained if.
Fri, Mar 17, 3:10 AM
alexfh committed rL298057: [clang-tidy] Verify some conditions in a matcher instead of check(). NFC.
[clang-tidy] Verify some conditions in a matcher instead of check(). NFC
Fri, Mar 17, 2:59 AM
alexfh accepted D30841: [clang-tidy] readability-misleading-indentation: fix chained if.

Now using ASTContext::getParents instead of ChainedIfs map.

For some reason I thought of getParents as an expensive function to call...

Fri, Mar 17, 2:50 AM
alexfh committed rL298052: [clang-tidy] Ignore deleted members in google-explicit-constructor..
[clang-tidy] Ignore deleted members in google-explicit-constructor.
Fri, Mar 17, 1:52 AM

Thu, Mar 16

alexfh added inline comments to D30841: [clang-tidy] readability-misleading-indentation: fix chained if.
Thu, Mar 16, 7:42 AM
alexfh requested changes to D30841: [clang-tidy] readability-misleading-indentation: fix chained if.

Thank you for the fix! One comment inline.

Thu, Mar 16, 7:36 AM
alexfh requested changes to D30931: [clang-tidy] modified identifier naming case to use CT_AnyCase for ignoring case style.
Thu, Mar 16, 7:13 AM
alexfh requested changes to D30748: [Lexer] Finding beginning of token with escaped new line.
Thu, Mar 16, 6:00 AM
alexfh added a comment to D30931: [clang-tidy] modified identifier naming case to use CT_AnyCase for ignoring case style.

You are right, it does look misleading. I'll try to modify it the way you suggest (though I'm new to LLVM, so be ready to give me more comments;)

Thu, Mar 16, 2:37 AM

Tue, Mar 14

alexfh added a comment to D30931: [clang-tidy] modified identifier naming case to use CT_AnyCase for ignoring case style.

BTW, next time please add cfe-commits to subscribers when you create the patch to get it sent properly to the mailing list.

Tue, Mar 14, 9:49 AM
alexfh updated subscribers of D30931: [clang-tidy] modified identifier naming case to use CT_AnyCase for ignoring case style.
Tue, Mar 14, 9:48 AM
alexfh edited reviewers for D30931: [clang-tidy] modified identifier naming case to use CT_AnyCase for ignoring case style, added: berenm; removed: rsmith.
Tue, Mar 14, 9:47 AM
alexfh added a comment to D30931: [clang-tidy] modified identifier naming case to use CT_AnyCase for ignoring case style.

I understand your use case, but this patch makes the check's behavior more confusing: having both "any case" and "ignore case" with subtle differences in behavior seems very misleading. The problem seems to be coming from the usage of CT_AnyCase to denote uninitialized style. Should we just remove NamingStyle::isSet and use llvm::Optional<NamingStyle> instead of NamingStyle where appropriate?

Tue, Mar 14, 9:46 AM

Sun, Mar 12

alexfh added inline comments to D30610: [clang-tidy] Added options to cppcoreguidelines-special-member-functions check.
Sun, Mar 12, 4:11 PM

Sat, Mar 11

alexfh added a reviewer for D30748: [Lexer] Finding beginning of token with escaped new line: rsmith.
Sat, Mar 11, 6:54 AM

Thu, Mar 9

alexfh requested changes to D30748: [Lexer] Finding beginning of token with escaped new line.
Thu, Mar 9, 3:30 AM

Wed, Mar 8

alexfh committed rL297311: [clang-tidy] readability-function-size: remove default param count threshold.
[clang-tidy] readability-function-size: remove default param count threshold
Wed, Mar 8, 2:31 PM

Mon, Mar 6

alexfh added a comment to D30650: [clang-tidy] misc-use-after-move: Fix failing assertion.

I think we should refactor this check as part of Static Analyzer, since it's path-sensitive.

Mon, Mar 6, 1:52 PM
alexfh added inline comments to D30639: [clang-tidy] Ignore substituted template types in modernize-use-nullptr check..
Mon, Mar 6, 8:21 AM
alexfh accepted D30650: [clang-tidy] misc-use-after-move: Fix failing assertion.

LG. So you won the flappy column game? ;)

Mon, Mar 6, 7:23 AM
alexfh accepted D30639: [clang-tidy] Ignore substituted template types in modernize-use-nullptr check..

LG

Mon, Mar 6, 6:29 AM

Sun, Mar 5

alexfh added a comment to D30607: Replace re module by regex module in run-clang-tidy script .

Actually, I'm not sure why we need groups in that regex. We can instead try replacing re.compile('(' + ')|('.join(args.files) + ')') with re.compile('|'.join(args.files)).

Sun, Mar 5, 2:04 AM
alexfh requested changes to D30607: Replace re module by regex module in run-clang-tidy script .
Sun, Mar 5, 1:53 AM
alexfh added a comment to D30607: Replace re module by regex module in run-clang-tidy script .

https://docs.python.org/2/howto/regex.html#introduction says "The regex module was removed completely in Python 2.5.". Why would we want to switch to it?

Sun, Mar 5, 1:53 AM

Fri, Mar 3

alexfh added inline comments to D30569: [clang-tidy] misc-use-after-move: Fix failing assertion.
Fri, Mar 3, 6:08 AM
alexfh added a comment to D30567: [clang-tidy] Fix treating non-space whitespaces in checks list..

What's the practical use of newlines and tab characters in the glob list?

Fri, Mar 3, 5:29 AM
alexfh accepted D30569: [clang-tidy] misc-use-after-move: Fix failing assertion.

LG. Thanks!

Fri, Mar 3, 5:27 AM
alexfh added inline comments to D30383: [clang-tidy] aliases for safety module from section 8 to 12 done.
Fri, Mar 3, 5:24 AM
alexfh added a reviewer for D30383: [clang-tidy] aliases for safety module from section 8 to 12 done: dberlin.
Fri, Mar 3, 4:53 AM
alexfh committed rL296864: [clang-tidy] Format code around applied fixes.
[clang-tidy] Format code around applied fixes
Fri, Mar 3, 3:28 AM
alexfh closed D30564: [clang-tidy] Format code around applied fixes by committing rL296864: [clang-tidy] Format code around applied fixes.
Fri, Mar 3, 3:28 AM
alexfh updated the diff for D30564: [clang-tidy] Format code around applied fixes.

Apply changes even when formatting fails.

Fri, Mar 3, 3:24 AM
alexfh added a comment to D30564: [clang-tidy] Format code around applied fixes.

PTAL

Fri, Mar 3, 3:12 AM
alexfh updated the diff for D30564: [clang-tidy] Format code around applied fixes.

Clarify the 'file' option a bit.

Fri, Mar 3, 3:11 AM
alexfh added a comment to D30564: [clang-tidy] Format code around applied fixes.

Replace the separate -format and -style options with -format-style (default is
'none', which means no formatting).

Is there a style that means use my .clang-format file?

Fri, Mar 3, 3:07 AM
alexfh updated the diff for D30564: [clang-tidy] Format code around applied fixes.

Expanded -format-style option description. Run cleanup tests with different format styles, just in case.

Fri, Mar 3, 3:06 AM
alexfh updated the diff for D30564: [clang-tidy] Format code around applied fixes.

Replace the separate -format and -style options with -format-style (default is
'none', which means no formatting).

Fri, Mar 3, 2:26 AM
alexfh added inline comments to D30564: [clang-tidy] Format code around applied fixes.
Fri, Mar 3, 1:53 AM
alexfh added inline comments to D30564: [clang-tidy] Format code around applied fixes.
Fri, Mar 3, 1:46 AM
alexfh updated the diff for D30564: [clang-tidy] Format code around applied fixes.

Pacify llvm::Expected<> debug checks.

Fri, Mar 3, 1:44 AM
alexfh created D30564: [clang-tidy] Format code around applied fixes.
Fri, Mar 3, 1:22 AM
alexfh committed rL296858: [clang-tidy] google-readability-casting: don't use constructor call syntax for….
[clang-tidy] google-readability-casting: don't use constructor call syntax for…
Fri, Mar 3, 12:30 AM

Thu, Mar 2

alexfh added a comment to D29858: [clang-tidy] Catch trivially true statements like a != 1 || a != 3.

Do you need someone to commit the patch for you?

Thu, Mar 2, 8:35 AM
alexfh committed rL296755: [clang-tidy] google-readability-casting: detect redundant casts with top-level….
[clang-tidy] google-readability-casting: detect redundant casts with top-level…
Thu, Mar 2, 7:59 AM
alexfh committed rL296753: [clang-tidy] Fix a few more issues in google-readability-casting.
[clang-tidy] Fix a few more issues in google-readability-casting
Thu, Mar 2, 7:39 AM
alexfh accepted D29858: [clang-tidy] Catch trivially true statements like a != 1 || a != 3.

LG unless Etienne has any concerns.

Thu, Mar 2, 12:43 AM
alexfh committed rL296734: [clang-tidy] Function names configurable for cppcoreguidelines-nomalloc….
[clang-tidy] Function names configurable for cppcoreguidelines-nomalloc…
Thu, Mar 2, 12:40 AM
alexfh closed D28239: [clang-tidy] Function names configurable for cppcoreguidelines-nomalloc - checker by committing rL296734: [clang-tidy] Function names configurable for cppcoreguidelines-nomalloc….
Thu, Mar 2, 12:40 AM · Restricted Project
alexfh accepted D28239: [clang-tidy] Function names configurable for cppcoreguidelines-nomalloc - checker.

Thanks! LG

Thu, Mar 2, 12:36 AM · Restricted Project

Wed, Mar 1

alexfh committed rL296627: [clang-tidy] Attempt to fix the test where exceptions are disabled by default..
[clang-tidy] Attempt to fix the test where exceptions are disabled by default.
Wed, Mar 1, 6:53 AM
alexfh requested changes to D30034: [clang-tidy] Fix a false positive for explicit template instantiations in misc-unused-using-decls..

I think, we decided to extend the AST instead of working around its incompleteness.

Wed, Mar 1, 2:35 AM
alexfh abandoned D16183: Added CheckName field to YAML report.
Wed, Mar 1, 2:32 AM
alexfh commandeered D16183: Added CheckName field to YAML report.
Wed, Mar 1, 2:32 AM
alexfh added a comment to D16183: Added CheckName field to YAML report.

This patch is superseded by D26137.

Wed, Mar 1, 2:31 AM
alexfh committed rL296599: [clang-tidy] Add parametercount for readibility-function-size.
[clang-tidy] Add parametercount for readibility-function-size
Wed, Mar 1, 2:29 AM
alexfh closed D29561: [clang-tidy] Add parametercount for readibility-function-size by committing rL296599: [clang-tidy] Add parametercount for readibility-function-size.
Wed, Mar 1, 2:29 AM
alexfh committed rL296598: [clang-tidy] Fix handling of methods with try-statement as a body in modernize….
[clang-tidy] Fix handling of methods with try-statement as a body in modernize…
Wed, Mar 1, 2:28 AM
alexfh closed D30002: [clang-tidy] Fix handling of methods with try-statement as a body in modernize-use-override by committing rL296598: [clang-tidy] Fix handling of methods with try-statement as a body in modernize….
Wed, Mar 1, 2:28 AM · Restricted Project
alexfh requested changes to D28239: [clang-tidy] Function names configurable for cppcoreguidelines-nomalloc - checker.
Wed, Mar 1, 2:22 AM · Restricted Project
alexfh closed D27212: [clang-tidy] cppcoreguidelines-slicing: display discarded state in bits.

This was committed a while ago as r290340.

Wed, Mar 1, 2:12 AM

Tue, Feb 28

alexfh committed rL296472: Misspelled checker description (argument comment).
Misspelled checker description (argument comment)
Tue, Feb 28, 6:25 AM
alexfh closed D24137: Misspelled checker description (argument comment) by committing rL296472: Misspelled checker description (argument comment).
Tue, Feb 28, 6:25 AM · Restricted Project
alexfh requested changes to D30383: [clang-tidy] aliases for safety module from section 8 to 12 done.
Tue, Feb 28, 3:22 AM
alexfh added inline comments to D30383: [clang-tidy] aliases for safety module from section 8 to 12 done.
Tue, Feb 28, 3:21 AM