- User Since
- Jul 10 2012, 10:35 AM (318 w, 15 h)
Fri, Aug 10
I've fixed the comments and committed the patch myself. Hope that's fine by you.
LG with a couple of nits. Do you need someone to commit the patch for you?
Thu, Aug 9
Fri, Aug 3
Tue, Jul 31
Could you describe the specific problem you're solving and provide an example? As mentioned by others, a test would be very welcome as well.
LG modulo outstanding comments.
Thu, Jul 26
Thank you for working on this!
Jul 12 2018
FTR, this is http://llvm.org/PR38072
Jul 11 2018
(removing from my dashboard)
Looks good with one comment.
As per the previous comment: I have no concerns as long as the documentation is updated and at least one existing test is changed to use this feature (see the list in the previous comment).
That's an awesome idea! Did you think about supporting automated fix-it suggestions?
Jul 4 2018
Some patterns are covered by compiler diagnostics: https://godbolt.org/g/HvsjnP. Is there any benefit in re-implementing them?
Jun 29 2018
Please add a test.
Jun 28 2018
- Addressed review comments.
Jun 27 2018
Jun 21 2018
Please take another look.
- Added a test.
Jun 19 2018
Jun 18 2018
Jun 14 2018
Jun 13 2018
Jun 11 2018
This commit seems to have introduced https://bugs.llvm.org/show_bug.cgi?id=37769. Could you take a look?
Jun 8 2018
Jun 7 2018
Jun 6 2018
May 17 2018
See https://bugs.llvm.org/show_bug.cgi?id=37503 for a test case.
This is reproducible in r332425.
This patch seems to cause an assertion failure:
May 16 2018
A couple of comments from a cursory look. I'll try to look closer later this week.
There are still outstanding comments.
May 14 2018
May 11 2018
May 9 2018
I wonder why JSON? What kind of a tool do folks use to process the outputs of printJSONValue? Is there anything existing or is JSON used "just in case"? I personally use either spreadsheets, python or shell when I deal with this kind of data, and all three of them can work reasonably well with CSV (plus the data is pretty simple).
Roman, it looks to me that a simpler storage scheme would be sufficient. For example, YYYYMMDDhhmmss-InputFileName.cpp.csv. Main things are: 1. include a timestamp, so there's no need to overwrite old results, 2. include just the name of the file without any parent directories, 3. put all outputs into the same directory. This way we wouldn't have to create a directory structure and think about stripping a certain prefix (btw, utilities like patch just specify the number of path components to remove from the start, not the actual substring). WDYT?