Page MenuHomePhabricator

hokein (Haojian Wu)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 19 2015, 3:38 AM (231 w, 2 d)

Recent Activity

Today

hokein accepted D73346: [clangd] Rename DiagnosticsConsumer -> ClangdServer::Callbacks, and make it optional.
Fri, Jan 24, 5:46 AM · Restricted Project
hokein accepted D73334: [Format] Fix 'auto x(T&&, T &&)->F' with PAS_Left..
Fri, Jan 24, 1:51 AM · Restricted Project
hokein added a comment to D67537: [clangd] Client-side support for inactive regions.

Do you mean naming the scope something like clangd.meta.disable to make it clear it's a clangd extension?

(In that case, we might as well make it something more descriptive, like clangd.preprocessor.inactive. meta doesn't convey much information.)

Fri, Jan 24, 1:41 AM · Restricted Project

Wed, Jan 22

hokein added a comment to D67537: [clangd] Client-side support for inactive regions.

sorry for the looong delay, I was OOO for a few weeks before.

Wed, Jan 22, 8:12 AM · Restricted Project
hokein added inline comments to D72746: [clangd] Add a flag for implicit references in the Index.
Wed, Jan 22, 7:18 AM · Restricted Project
hokein added inline comments to D72746: [clangd] Add a flag for implicit references in the Index.
Wed, Jan 22, 3:04 AM · Restricted Project
hokein added a comment to D72746: [clangd] Add a flag for implicit references in the Index.

the scope of this patch is not very clear, the changes touch two different code parts SymbolCollector, and Rename, and we are lacking tests for SymbolCollector. I'd suggest spliting this patch into smaller patches:

Wed, Jan 22, 1:45 AM · Restricted Project
hokein committed rG5d4e89975714: [clangd] Handle the missing injectedClassNameType in targetDecl. (authored by hokein).
[clangd] Handle the missing injectedClassNameType in targetDecl.
Wed, Jan 22, 1:18 AM
hokein closed D73102: [clangd] Handle the missing injectedClassNameType in targetDecl..
Wed, Jan 22, 1:18 AM · Restricted Project
hokein committed rGa133cbaad5b2: [clang][index] Index the injected class name types. (authored by hokein).
[clang][index] Index the injected class name types.
Wed, Jan 22, 1:09 AM
hokein closed D73109: [clang][index] Index the injected class name types..
Wed, Jan 22, 1:09 AM · Restricted Project
hokein updated the diff for D73109: [clang][index] Index the injected class name types..

clang-format the code.

Wed, Jan 22, 12:51 AM · Restricted Project
hokein added a comment to D73109: [clang][index] Index the injected class name types..

Have you checked if this class is missing any other typelocs?

Wed, Jan 22, 12:51 AM · Restricted Project

Tue, Jan 21

hokein accepted D73101: [clangd] Do not duplicate TemplatedDecls in findExplicitReferences.
Tue, Jan 21, 8:12 AM · Restricted Project
hokein created D73109: [clang][index] Index the injected class name types..
Tue, Jan 21, 7:44 AM · Restricted Project
hokein added inline comments to D73101: [clangd] Do not duplicate TemplatedDecls in findExplicitReferences.
Tue, Jan 21, 6:48 AM · Restricted Project
hokein created D73102: [clangd] Handle the missing injectedClassNameType in targetDecl..
Tue, Jan 21, 6:39 AM · Restricted Project
hokein committed rGf651c402a221: [clangd] Capture the missing injected class names in findExplicitReferences. (authored by hokein).
[clangd] Capture the missing injected class names in findExplicitReferences.
Tue, Jan 21, 6:13 AM
hokein closed D73088: [clangd] Capture the missing injected class names in findExplicitReferences..
Tue, Jan 21, 6:13 AM · Restricted Project
hokein added a comment to D73088: [clangd] Capture the missing injected class names in findExplicitReferences..

It would also be great to have the original rename test from the linked issue since something might potentially go wrong in-between findExplicitReferences.

Tue, Jan 21, 6:12 AM · Restricted Project
hokein updated the diff for D73088: [clangd] Capture the missing injected class names in findExplicitReferences..
  • add fixme
  • add rename test
Tue, Jan 21, 6:12 AM · Restricted Project
hokein created D73088: [clangd] Capture the missing injected class names in findExplicitReferences..
Tue, Jan 21, 2:56 AM · Restricted Project

Mon, Jan 20

hokein committed rG3de9a5db629a: [clangd] Avoid redundant testcases in rename unittest, NFC. (authored by hokein).
[clangd] Avoid redundant testcases in rename unittest, NFC.
Mon, Jan 20, 8:04 AM
hokein closed D73035: [clangd] Avoid redundant testcases in rename unittest, NFC..
Mon, Jan 20, 8:04 AM · Restricted Project
hokein created D73035: [clangd] Avoid redundant testcases in rename unittest, NFC..
Mon, Jan 20, 5:21 AM · Restricted Project
hokein accepted D72638: [clangd] Fix rename for explicit destructor calls.

looks good, thanks.

Mon, Jan 20, 3:49 AM · Restricted Project
hokein committed rG61b563408012: [clangd] Remove a stale FIXME, NFC. (authored by hokein).
[clangd] Remove a stale FIXME, NFC.
Mon, Jan 20, 3:12 AM
hokein accepted D72715: [clang][CodeComplete] Propogate printing policy to FunctionDecl.

@kuhnel, I think we should exclude from running clang-format on lint test files.

Mon, Jan 20, 3:03 AM · Restricted Project

Fri, Jan 17

hokein added a comment to D72746: [clangd] Add a flag for implicit references in the Index.

The patch could be shorter and slightly less confusing if I preserved 1:1 RefKind::Implicit <-> index::SymbolKind::Implicit relation, but I thought we might want to keep RefKind being 1 byte so that we don't waste unnecessary memory.

Fri, Jan 17, 5:41 AM · Restricted Project
hokein added inline comments to D72638: [clangd] Fix rename for explicit destructor calls.
Fri, Jan 17, 5:03 AM · Restricted Project

Dec 17 2019

hokein added a comment to D71598: [clangd] Filter implicit references from index while renaming.

(apologies, the FIXME may imply this approach...)

Dec 17 2019, 6:12 AM · Restricted Project
hokein added a comment to D71406: [clangd] Add xref for macros to FileIndex..

@ilya-biryukov thanks for taking it during my OOO, just a drive-by comment :)

Dec 17 2019, 5:42 AM · Restricted Project

Dec 11 2019

hokein committed rGf0004aad5565: [clangd] Deduplicate refs from index for cross-file rename. (authored by hokein).
[clangd] Deduplicate refs from index for cross-file rename.
Dec 11 2019, 1:53 AM
hokein closed D71300: [clangd] Deduplicate refs from index for cross-file rename..
Dec 11 2019, 1:52 AM · Restricted Project
hokein updated the diff for D71300: [clangd] Deduplicate refs from index for cross-file rename..

address review comment -- simplify the unittest code.

Dec 11 2019, 12:04 AM · Restricted Project
hokein added a comment to D71300: [clangd] Deduplicate refs from index for cross-file rename..

thanks for the fast review.

Dec 11 2019, 12:04 AM · Restricted Project

Dec 10 2019

hokein created D71300: [clangd] Deduplicate refs from index for cross-file rename..
Dec 10 2019, 1:42 PM · Restricted Project
hokein committed rGa2602bdd7316: [clangd] Fix an incorrect expectedResult usage in rename test. (authored by hokein).
[clangd] Fix an incorrect expectedResult usage in rename test.
Dec 10 2019, 12:28 PM
hokein accepted D68261: [clangd] Add "inline" keyword to prevent ODR-violations in DefineInline.

I think we probably want to do the vice-versa thing (remove the inline keyword) in define-outline.

Dec 10 2019, 12:10 PM · Restricted Project

Dec 9 2019

hokein committed rGff4dceef9201: Fix the compiler warnings: "-Winconsistent-missing-override", "-Wunused… (authored by hokein).
Fix the compiler warnings: "-Winconsistent-missing-override", "-Wunused…
Dec 9 2019, 8:15 AM
hokein committed rG891f82222bb8: [clangd] Implement range patching heuristics for cross-file rename. (authored by hokein).
[clangd] Implement range patching heuristics for cross-file rename.
Dec 9 2019, 8:06 AM
hokein closed D70594: [clangd] Implement range patching heuristics for cross-file rename..
Dec 9 2019, 8:06 AM · Restricted Project
hokein committed rGdecdbc1155f5: [clangd] Use expansion location when the ref is inside macros. (authored by hokein).
[clangd] Use expansion location when the ref is inside macros.
Dec 9 2019, 7:38 AM
hokein closed D70480: [clangd] Use expansion location when the ref is inside macros..
Dec 9 2019, 7:38 AM · Restricted Project
hokein updated the diff for D70480: [clangd] Use expansion location when the ref is inside macros..

add a fixme.

Dec 9 2019, 7:29 AM · Restricted Project
hokein accepted D71188: [clangd] Delete ctor initializers while moving functions out-of-line.
Dec 9 2019, 7:28 AM · Restricted Project
hokein accepted D71187: [clangd] Delete default arguments while moving functions out-of-line.
Dec 9 2019, 7:19 AM · Restricted Project
hokein added inline comments to D70594: [clangd] Implement range patching heuristics for cross-file rename..
Dec 9 2019, 7:02 AM · Restricted Project
hokein updated the diff for D70594: [clangd] Implement range patching heuristics for cross-file rename..

address comments:

  • don't emit the internal messages to users, llvm::Expected => llvm::Optional
  • use the index of lexed array to calculate the adjustment cost.
Dec 9 2019, 7:00 AM · Restricted Project
hokein added inline comments to D71188: [clangd] Delete ctor initializers while moving functions out-of-line.
Dec 9 2019, 5:04 AM · Restricted Project
hokein added inline comments to D71187: [clangd] Delete default arguments while moving functions out-of-line.
Dec 9 2019, 4:46 AM · Restricted Project
hokein committed rG6d5c273500ad: Reland "[AST] Traverse the class type loc inside the member type loc."" (authored by hokein).
Reland "[AST] Traverse the class type loc inside the member type loc.""
Dec 9 2019, 2:24 AM
hokein closed D71186: Reland "[AST] Traverse the class type loc inside the member type loc."".
Dec 9 2019, 2:23 AM · Restricted Project
hokein added inline comments to D71186: Reland "[AST] Traverse the class type loc inside the member type loc."".
Dec 9 2019, 2:21 AM · Restricted Project
hokein updated the diff for D71186: Reland "[AST] Traverse the class type loc inside the member type loc."".

address the review comment.

Dec 9 2019, 2:21 AM · Restricted Project
hokein created D71186: Reland "[AST] Traverse the class type loc inside the member type loc."".
Dec 9 2019, 1:44 AM · Restricted Project

Dec 8 2019

hokein added inline comments to D70594: [clangd] Implement range patching heuristics for cross-file rename..
Dec 8 2019, 1:11 PM · Restricted Project
hokein updated the diff for D70594: [clangd] Implement range patching heuristics for cross-file rename..

some minor fixes.

Dec 8 2019, 1:11 PM · Restricted Project
hokein updated the diff for D70594: [clangd] Implement range patching heuristics for cross-file rename..

address reveiw comments.

Dec 8 2019, 12:53 PM · Restricted Project

Dec 6 2019

hokein updated subscribers of D71110: [clangd] A tool to evaluate cross-file rename..
Dec 6 2019, 7:15 AM · Restricted Project
hokein updated the diff for D71110: [clangd] A tool to evaluate cross-file rename..

Fix empty lines.

Dec 6 2019, 7:15 AM · Restricted Project
hokein updated the diff for D71110: [clangd] A tool to evaluate cross-file rename..

add more symbols.

Dec 6 2019, 7:15 AM · Restricted Project
hokein added inline comments to D70849: [AST] Traverse the class type loc inside the member pointer type loc..
Dec 6 2019, 4:38 AM · Restricted Project
hokein created D71110: [clangd] A tool to evaluate cross-file rename..
Dec 6 2019, 4:02 AM · Restricted Project

Dec 5 2019

hokein committed rG01e5290b49bd: [clangd] Simplify the code, NFC. (authored by hokein).
[clangd] Simplify the code, NFC.
Dec 5 2019, 6:33 AM
hokein committed rG7f93cb62280a: [AST] Traverse the class type loc inside the member type loc. (authored by hokein).
[AST] Traverse the class type loc inside the member type loc.
Dec 5 2019, 6:20 AM
hokein closed D70849: [AST] Traverse the class type loc inside the member pointer type loc..
Dec 5 2019, 6:20 AM · Restricted Project
hokein added inline comments to D70849: [AST] Traverse the class type loc inside the member pointer type loc..
Dec 5 2019, 5:28 AM · Restricted Project
hokein updated the diff for D70849: [AST] Traverse the class type loc inside the member pointer type loc..

use the assertion.

Dec 5 2019, 5:26 AM · Restricted Project
hokein committed rG158356b82b8a: [clangd] More unittests for cross-file rename. (authored by hokein).
[clangd] More unittests for cross-file rename.
Dec 5 2019, 3:16 AM
hokein closed D71050: [clangd] More unittests for cross-file rename..
Dec 5 2019, 3:16 AM · Restricted Project
hokein committed rG60d7e723e3ac: [clangd] Fix an incorrect comment, NFC. (authored by hokein).
[clangd] Fix an incorrect comment, NFC.
Dec 5 2019, 1:45 AM
hokein created D71050: [clangd] More unittests for cross-file rename..
Dec 5 2019, 1:43 AM · Restricted Project

Dec 4 2019

hokein accepted D70489: [clangd] Add xref for macro to static index..

thanks, looks good with a few nits. I think the benchmark data doesn't correct any more with the latest patch, we don't increase number of symbols.

Dec 4 2019, 7:12 AM · Restricted Project
hokein added inline comments to D70489: [clangd] Add xref for macro to static index..
Dec 4 2019, 6:25 AM · Restricted Project
hokein committed rG689c11486396: [clangd] register cuda language activation event and activate for .cuh files (authored by ptaylor).
[clangd] register cuda language activation event and activate for .cuh files
Dec 4 2019, 6:16 AM
hokein closed D70041: register cuda language activation event and activate for .cuh files.
Dec 4 2019, 6:16 AM · Restricted Project
hokein added inline comments to D70594: [clangd] Implement range patching heuristics for cross-file rename..
Dec 4 2019, 5:57 AM · Restricted Project
hokein updated the diff for D70594: [clangd] Implement range patching heuristics for cross-file rename..

address comments

  • re-define the concept of a near miss
  • add metric for evaluate how good a near miss is
Dec 4 2019, 5:57 AM · Restricted Project
hokein committed rGcb9be3fa551b: [clangd] Remove the hanging lit exit-signal.test. (authored by hokein).
[clangd] Remove the hanging lit exit-signal.test.
Dec 4 2019, 3:39 AM

Dec 3 2019

hokein added a comment to D70489: [clangd] Add xref for macro to static index..

thanks, mostly good, my main concern is that the patch still relies on the CollectMacro and CollectMainFileSymbols option, see my comments below.

Dec 3 2019, 1:40 PM · Restricted Project
hokein accepted D70943: [NFC] Slightly improve wording in the comments.

thanks.

Dec 3 2019, 1:05 AM · Restricted Project

Dec 2 2019

hokein accepted D70656: [clangd] Define out-of-line qualify function name.
Dec 2 2019, 12:27 PM · Restricted Project
hokein accepted D70535: [clangd] Define out-of-line qualify return value.
Dec 2 2019, 12:25 PM · Restricted Project
hokein added a comment to D70489: [clangd] Add xref for macro to static index..

btw, could you measure the increasing size of the index with this patch?

Dec 2 2019, 8:08 AM · Restricted Project
hokein added inline comments to D70849: [AST] Traverse the class type loc inside the member pointer type loc..
Dec 2 2019, 7:49 AM · Restricted Project
hokein updated the diff for D70849: [AST] Traverse the class type loc inside the member pointer type loc..

address review comments.

Dec 2 2019, 2:05 AM · Restricted Project
hokein committed rG902dc6c69ce7: [clangd] Fix a regression issue in local rename. (authored by hokein).
[clangd] Fix a regression issue in local rename.
Dec 2 2019, 1:38 AM
hokein closed D70853: [clangd] Fix a regression issue in local rename..
Dec 2 2019, 1:37 AM · Restricted Project

Nov 29 2019

hokein updated the diff for D70594: [clangd] Implement range patching heuristics for cross-file rename..

rebase

Nov 29 2019, 7:36 AM · Restricted Project
hokein created D70853: [clangd] Fix a regression issue in local rename..
Nov 29 2019, 6:03 AM · Restricted Project
hokein added a comment to D70727: [clangd] Keep go-to-definition working at the end of an identifier (fixes #194).

By the way, may I get permissions to assign issues to myself (and make other such metadata changes to issues) on github?

Nov 29 2019, 5:04 AM · Restricted Project
hokein retitled D70849: [AST] Traverse the class type loc inside the member pointer type loc. from [AST] Traverse the class type loc inside the member type loc. to [AST] Traverse the class type loc inside the member pointer type loc..
Nov 29 2019, 4:40 AM · Restricted Project
hokein created D70849: [AST] Traverse the class type loc inside the member pointer type loc..
Nov 29 2019, 4:17 AM · Restricted Project
hokein added inline comments to D70656: [clangd] Define out-of-line qualify function name.
Nov 29 2019, 2:22 AM · Restricted Project
hokein added inline comments to D70535: [clangd] Define out-of-line qualify return value.
Nov 29 2019, 2:19 AM · Restricted Project
hokein committed rG66ab932fcc10: [clangd] Correct the file path in Edit::replacements when generating the rename… (authored by hokein).
[clangd] Correct the file path in Edit::replacements when generating the rename…
Nov 29 2019, 1:21 AM
hokein closed D70828: [clangd] Correct the file path in Edit::replacements when generating the rename edit..
Nov 29 2019, 1:21 AM · Restricted Project

Nov 28 2019

hokein created D70828: [clangd] Correct the file path in Edit::replacements when generating the rename edit..
Nov 28 2019, 7:55 AM · Restricted Project
hokein committed rG3c3aca245e67: [clangd] Don't perform rename when the refs result from index is incomplete. (authored by hokein).
[clangd] Don't perform rename when the refs result from index is incomplete.
Nov 28 2019, 5:01 AM