hokein (Haojian Wu)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 19 2015, 3:38 AM (147 w, 5 d)

Recent Activity

Fri, Jun 15

hokein committed rL334812: [clangd] Fix buildbot error..
[clangd] Fix buildbot error.
Fri, Jun 15, 2:37 AM
hokein committed rCTE334812: [clangd] Fix buildbot error..
[clangd] Fix buildbot error.
Fri, Jun 15, 2:37 AM

Fri, Jun 8

hokein committed rCTE334270: [clang-tidy] Improve string type matcher for abseil-string-find-starts-with….
[clang-tidy] Improve string type matcher for abseil-string-find-starts-with…
Fri, Jun 8, 1:24 AM
hokein committed rL334270: [clang-tidy] Improve string type matcher for abseil-string-find-starts-with….
[clang-tidy] Improve string type matcher for abseil-string-find-starts-with…
Fri, Jun 8, 1:23 AM
hokein closed D47704: [clang-tidy] Improve string type matcher for abseil-string-find-starts-with check..
Fri, Jun 8, 1:23 AM

Thu, Jun 7

hokein committed rL334176: [clangd] Fix using the incorrect Index for go-to-definition..
[clangd] Fix using the incorrect Index for go-to-definition.
Thu, Jun 7, 1:54 AM
hokein committed rCTE334176: [clangd] Fix using the incorrect Index for go-to-definition..
[clangd] Fix using the incorrect Index for go-to-definition.
Thu, Jun 7, 1:54 AM
hokein closed D47869: [clangd] Fix using the incorrect Index for go-to-definition..
Thu, Jun 7, 1:54 AM
hokein updated the diff for D47869: [clangd] Fix using the incorrect Index for go-to-definition..

this->Index => Index.

Thu, Jun 7, 1:52 AM
hokein created D47869: [clangd] Fix using the incorrect Index for go-to-definition..
Thu, Jun 7, 1:14 AM

Wed, Jun 6

hokein accepted D47821: [clangd] Make workspace/symbols actually rank its results..

LGTM.

Wed, Jun 6, 8:10 AM

Mon, Jun 4

hokein abandoned D46684: [Frontend] Don't skip function body when the return type is dependent on the template parameter..

Abandon this, since @ilya-biryukov has fixed it in D44480.

Mon, Jun 4, 4:42 AM
hokein created D47704: [clang-tidy] Improve string type matcher for abseil-string-find-starts-with check..
Mon, Jun 4, 4:31 AM
hokein committed rCTE333882: [clangd] Remove the dead offset fields in Symbol..
[clangd] Remove the dead offset fields in Symbol.
Mon, Jun 4, 3:48 AM
hokein committed rL333882: [clangd] Remove the dead offset fields in Symbol..
[clangd] Remove the dead offset fields in Symbol.
Mon, Jun 4, 3:48 AM
hokein closed D47699: [clangd] Remove the dead offset fields in Symbol..
Mon, Jun 4, 3:48 AM
hokein created D47699: [clangd] Remove the dead offset fields in Symbol..
Mon, Jun 4, 3:01 AM

May 10 2018

hokein created D46684: [Frontend] Don't skip function body when the return type is dependent on the template parameter..
May 10 2018, 3:26 AM

Apr 30 2018

hokein committed rL331189: [clangd] Using index for GoToDefinition..
[clangd] Using index for GoToDefinition.
Apr 30 2018, 8:27 AM
hokein committed rCTE331189: [clangd] Using index for GoToDefinition..
[clangd] Using index for GoToDefinition.
Apr 30 2018, 8:27 AM
hokein closed D45717: [clangd] Using index for GoToDefinition..
Apr 30 2018, 8:27 AM
hokein added a comment to D45717: [clangd] Using index for GoToDefinition..

Thanks for the review!

Apr 30 2018, 8:07 AM
hokein updated the diff for D45717: [clangd] Using index for GoToDefinition..

Address review comments.

Apr 30 2018, 8:06 AM
hokein committed rCTE331168: [clangd] Also use UTF-16 in index position..
[clangd] Also use UTF-16 in index position.
Apr 30 2018, 4:43 AM
hokein committed rL331168: [clangd] Also use UTF-16 in index position..
[clangd] Also use UTF-16 in index position.
Apr 30 2018, 4:43 AM
hokein closed D46258: [clangd] Also use UTF-16 in index position..
Apr 30 2018, 4:43 AM
hokein updated the diff for D46258: [clangd] Also use UTF-16 in index position..

Add a test.

Apr 30 2018, 4:41 AM
hokein created D46258: [clangd] Also use UTF-16 in index position..
Apr 30 2018, 3:13 AM

Apr 25 2018

hokein committed rCTE330835: [clangd] Add "str()" method to SymbolID..
[clangd] Add "str()" method to SymbolID.
Apr 25 2018, 8:30 AM
hokein committed rL330835: [clangd] Add "str()" method to SymbolID..
[clangd] Add "str()" method to SymbolID.
Apr 25 2018, 8:30 AM
hokein closed D46065: [clangd] Add "str()" method to SymbolID..
Apr 25 2018, 8:30 AM
hokein added inline comments to D46065: [clangd] Add "str()" method to SymbolID..
Apr 25 2018, 8:30 AM
hokein created D46065: [clangd] Add "str()" method to SymbolID..
Apr 25 2018, 8:14 AM
hokein accepted D46035: [clangd] Fix unicode handling, using UTF-16 where LSP requires it..

Cool, the code looks good to me (just a few nits), thanks for the descriptive comments!

Apr 25 2018, 2:31 AM

Apr 24 2018

hokein added a comment to D45717: [clangd] Using index for GoToDefinition..

Thanks for the useful comments! I refined the patch, and it becomes a bit larger (including some moving stuff).

Apr 24 2018, 6:31 AM
hokein updated the diff for D45717: [clangd] Using index for GoToDefinition..

Address review comments:

Apr 24 2018, 6:29 AM

Apr 23 2018

hokein added a comment to D45717: [clangd] Using index for GoToDefinition..

I have updated the patch according to offline discussion -- for each symbol, we will return both decl and def locations (if available, def first) as they seems to be most sensible to users. We always prefer location from AST over Index when conflicts.

Apr 23 2018, 2:16 AM
hokein updated the diff for D45717: [clangd] Using index for GoToDefinition..

Refine the patch and address all review comments.

Apr 23 2018, 2:15 AM

Apr 19 2018

hokein committed rCTE330327: [clang-tidy] Fix unused-variable warning..
[clang-tidy] Fix unused-variable warning.
Apr 19 2018, 6:37 AM
hokein committed rL330327: [clang-tidy] Fix unused-variable warning..
[clang-tidy] Fix unused-variable warning.
Apr 19 2018, 6:37 AM

Apr 18 2018

hokein added inline comments to D44882: [clangd] Implementation of workspace/symbol request.
Apr 18 2018, 8:02 AM
hokein committed rCTE330245: [clang-tidy] Fix clang-tidy doesn't read .clangtidy configuration file..
[clang-tidy] Fix clang-tidy doesn't read .clangtidy configuration file.
Apr 18 2018, 2:00 AM
hokein committed rL330245: [clang-tidy] Fix clang-tidy doesn't read .clangtidy configuration file..
[clang-tidy] Fix clang-tidy doesn't read .clangtidy configuration file.
Apr 18 2018, 2:00 AM
hokein closed D45697: [clang-tidy] Fix clang-tidy doesn't read .clangtidy configuration file..
Apr 18 2018, 2:00 AM

Apr 17 2018

hokein updated the diff for D45697: [clang-tidy] Fix clang-tidy doesn't read .clangtidy configuration file..

Make grep pattern more obvious.

Apr 17 2018, 12:42 PM
hokein added inline comments to D45697: [clang-tidy] Fix clang-tidy doesn't read .clangtidy configuration file..
Apr 17 2018, 4:36 AM
hokein updated the diff for D45697: [clang-tidy] Fix clang-tidy doesn't read .clangtidy configuration file..

Add one more test to ensure the test code triggering "clang-analyzer-*" checks.

Apr 17 2018, 4:35 AM
hokein added inline comments to D45697: [clang-tidy] Fix clang-tidy doesn't read .clangtidy configuration file..
Apr 17 2018, 1:58 AM
hokein committed rCTE330182: [clangd] Fix "fail to create file URI" warnings in FileIndexTest..
[clangd] Fix "fail to create file URI" warnings in FileIndexTest.
Apr 17 2018, 1:38 AM
hokein committed rL330182: [clangd] Fix "fail to create file URI" warnings in FileIndexTest..
[clangd] Fix "fail to create file URI" warnings in FileIndexTest.
Apr 17 2018, 1:38 AM
hokein closed D45692: [clangd] Fix "fail to create file URI" warnings in FileIndexTest..
Apr 17 2018, 1:38 AM
hokein created D45717: [clangd] Using index for GoToDefinition..
Apr 17 2018, 1:36 AM

Apr 16 2018

hokein created D45697: [clang-tidy] Fix clang-tidy doesn't read .clangtidy configuration file..
Apr 16 2018, 11:53 AM
hokein created D45692: [clangd] Fix "fail to create file URI" warnings in FileIndexTest..
Apr 16 2018, 8:35 AM

Apr 13 2018

hokein added a comment to D44882: [clangd] Implementation of workspace/symbol request.

@malaperle, what's your plan of this patch? Are you going to land it before D45513? With the Line&Column info in the index, this patch could be simplified.

I'll address the last comment and wait for review. Probably at least another day of delay. So if that ends up after D45513 then I'll update it to simplify. Sounds good?

Apr 13 2018, 1:38 AM
hokein committed rL329997: [clangd] Add line and column number to the index symbol..
[clangd] Add line and column number to the index symbol.
Apr 13 2018, 1:34 AM
hokein committed rCTE329997: [clangd] Add line and column number to the index symbol..
[clangd] Add line and column number to the index symbol.
Apr 13 2018, 1:33 AM
hokein closed D45513: [clangd] Add line and column number to the index symbol..
Apr 13 2018, 1:33 AM
hokein added inline comments to D45513: [clangd] Add line and column number to the index symbol..
Apr 13 2018, 1:10 AM

Apr 12 2018

hokein added a comment to D44882: [clangd] Implementation of workspace/symbol request.

@malaperle, what's your plan of this patch? Are you going to land it before D45513? With the Line&Column info in the index, this patch could be simplified.

Apr 12 2018, 8:57 AM
hokein added inline comments to D45513: [clangd] Add line and column number to the index symbol..
Apr 12 2018, 8:50 AM
hokein updated the diff for D45513: [clangd] Add line and column number to the index symbol..

Update the patch, address remaining issues.

Apr 12 2018, 8:50 AM
hokein added inline comments to D45513: [clangd] Add line and column number to the index symbol..
Apr 12 2018, 7:21 AM
hokein updated the diff for D45513: [clangd] Add line and column number to the index symbol..

Address review comments.

Apr 12 2018, 7:21 AM

Apr 11 2018

hokein committed rC329786: [Tooling] Correct the "-std" compile command option..
[Tooling] Correct the "-std" compile command option.
Apr 11 2018, 2:21 AM
hokein committed rL329786: [Tooling] Correct the "-std" compile command option..
[Tooling] Correct the "-std" compile command option.
Apr 11 2018, 2:21 AM
hokein closed D45512: [Tooling] Correct the "-std" compile command option..
Apr 11 2018, 2:21 AM
hokein created D45513: [clangd] Add line and column number to the index symbol..
Apr 11 2018, 2:19 AM
hokein created D45512: [Tooling] Correct the "-std" compile command option..
Apr 11 2018, 1:42 AM
hokein committed rL329784: [Tooling] Optimize memory usage in InMemoryToolResults..
[Tooling] Optimize memory usage in InMemoryToolResults.
Apr 11 2018, 1:16 AM
hokein committed rC329784: [Tooling] Optimize memory usage in InMemoryToolResults..
[Tooling] Optimize memory usage in InMemoryToolResults.
Apr 11 2018, 1:16 AM
hokein closed D45479: [Tooling] Optimize memory usage in InMemoryToolResults..
Apr 11 2018, 1:16 AM

Apr 10 2018

hokein updated the diff for D45479: [Tooling] Optimize memory usage in InMemoryToolResults..

Add a comment.

Apr 10 2018, 7:22 AM
hokein retitled D45479: [Tooling] Optimize memory usage in InMemoryToolResults. from [Tooling] Optmized memory usage in InMemoryToolResults. to [Tooling] Optimize memory usage in InMemoryToolResults..
Apr 10 2018, 4:11 AM
hokein updated the diff for D45479: [Tooling] Optimize memory usage in InMemoryToolResults..

Update.

Apr 10 2018, 4:07 AM
hokein created D45479: [Tooling] Optimize memory usage in InMemoryToolResults..
Apr 10 2018, 2:55 AM
hokein added a comment to D45478: [clangd] Merge symbols in global-sym-builder on the go.

Thanks for digging it out!

Apr 10 2018, 2:53 AM

Apr 9 2018

hokein committed rCTE329583: [clangd] Bump v0.0.6 for vscode-clangd..
[clangd] Bump v0.0.6 for vscode-clangd.
Apr 9 2018, 8:40 AM
hokein committed rL329583: [clangd] Bump v0.0.6 for vscode-clangd..
[clangd] Bump v0.0.6 for vscode-clangd.
Apr 9 2018, 8:40 AM
hokein committed rL329578: [clangd] Allow using customized include path in URI..
[clangd] Allow using customized include path in URI.
Apr 9 2018, 8:13 AM
hokein committed rCTE329578: [clangd] Allow using customized include path in URI..
[clangd] Allow using customized include path in URI.
Apr 9 2018, 8:13 AM
hokein closed D45426: [clangd] Allow using customized include path in URI..
Apr 9 2018, 8:12 AM
hokein updated the diff for D45426: [clangd] Allow using customized include path in URI..

includeSpelling

Apr 9 2018, 8:09 AM
hokein added inline comments to D45426: [clangd] Allow using customized include path in URI..
Apr 9 2018, 7:56 AM
hokein updated the diff for D45426: [clangd] Allow using customized include path in URI..

Address review comments.

Apr 9 2018, 7:52 AM
hokein added a comment to D45285: [clangd-vscode] Update VScode dependencies.

Do we need to bump the version of the extension and do a new release or anything like that? Or leave this for later?

We should bump the version and republish the extension into VSCode marketplace.
@hokein has more context on how to properly do that.

Apr 9 2018, 3:09 AM
hokein added inline comments to D45405: [clang-tidy] [modernize-use-auto] Add a threshold for minimal type name length to be replaced with 'auto'.
Apr 9 2018, 2:32 AM · Restricted Project
hokein created D45426: [clangd] Allow using customized include path in URI..
Apr 9 2018, 2:24 AM

Apr 3 2018

hokein committed rCTE329073: [clang-tidy] Check for sizeof that call functions.
[clang-tidy] Check for sizeof that call functions
Apr 3 2018, 8:13 AM
hokein added a comment to D44231: [clang-tidy] Check for sizeof that call functions.

Thanks, I have committed for you.

Apr 3 2018, 8:13 AM · Restricted Project
hokein committed rL329073: [clang-tidy] Check for sizeof that call functions.
[clang-tidy] Check for sizeof that call functions
Apr 3 2018, 8:13 AM
hokein closed D44231: [clang-tidy] Check for sizeof that call functions.
Apr 3 2018, 8:13 AM · Restricted Project
hokein added inline comments to D44882: [clangd] Implementation of workspace/symbol request.
Apr 3 2018, 8:12 AM
hokein abandoned D44732: [clangd] Set CLANGD_EDITOR environment variable in vscode extension..

As discussed, we infer the editor from process tree which won't require changes in all clients.

Apr 3 2018, 6:05 AM
hokein added a comment to D44231: [clang-tidy] Check for sizeof that call functions.

pfultz2@, could you rebase this patch? The check has been moved to bugprone.

Apr 3 2018, 2:16 AM · Restricted Project
hokein added a comment to D44231: [clang-tidy] Check for sizeof that call functions.

Sorry for the delay -- everyone was out because of the long Easter weekend. I'll commit for you.

Apr 3 2018, 1:28 AM · Restricted Project

Mar 21 2018

hokein created D44732: [clangd] Set CLANGD_EDITOR environment variable in vscode extension..
Mar 21 2018, 6:05 AM

Mar 19 2018

hokein committed rCTE327887: [clang-move] Fix the failing test caused by changes in clang-format..
[clang-move] Fix the failing test caused by changes in clang-format.
Mar 19 2018, 12:15 PM
hokein committed rL327887: [clang-move] Fix the failing test caused by changes in clang-format..
[clang-move] Fix the failing test caused by changes in clang-format.
Mar 19 2018, 12:15 PM

Mar 16 2018

hokein added a comment to D44231: [clang-tidy] Check for sizeof that call functions.

As this patch can catch some mistakes, I'm fine with checking it in. I agree that it is reasonable to write normal code like sizeof(func_call()) (not false positive), maybe set the option to false by default?

Mar 16 2018, 4:24 AM · Restricted Project