Page MenuHomePhabricator
People hokein

hokein (Haojian Wu)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 19 2015, 3:38 AM (396 w, 3 d)

Recent Activity
View All

Fri, Mar 24

hokein accepted D146732: [include-cleaner] Attribute references to explicit specializations.
Fri, Mar 24, 2:14 AM · Restricted Project, Restricted Project
hokein added a comment to D146244: [clangd] Show used symbols on #include line hover..

thanks, the implementation looks good. I left some comments around the test.

Fri, Mar 24, 1:59 AM · Restricted Project, Restricted Project

Thu, Mar 23

hokein requested review of D146717: [clangd] Handle the C++2b elifdef and elindef PP structure in CollectMainFileMacros..
Thu, Mar 23, 5:51 AM · Restricted Project, Restricted Project
hokein added a comment to D143974: [clangd] Inactive regions support via dedicated protocol.

Thanks, and sorry for late response.

Thu, Mar 23, 5:05 AM · Restricted Project, Restricted Project
hokein committed rG002c4b7b955b: [clangd] Extend CollectMainFileMacros. (authored by hokein).
[clangd] Extend CollectMainFileMacros.
Thu, Mar 23, 4:01 AM · Restricted Project, Restricted Project
hokein closed D146279: [clangd] Extend CollectMainFileMacros..
Thu, Mar 23, 4:01 AM · Restricted Project, Restricted Project
hokein accepted D146406: [IncludeCleaner][clangd] Mark umbrella headers as users of private.
Thu, Mar 23, 3:58 AM · Restricted Project, Restricted Project, Restricted Project
hokein added inline comments to D146279: [clangd] Extend CollectMainFileMacros..
Thu, Mar 23, 3:44 AM · Restricted Project, Restricted Project
hokein updated the diff for D146279: [clangd] Extend CollectMainFileMacros..

address comments

Thu, Mar 23, 3:44 AM · Restricted Project, Restricted Project
hokein added inline comments to D146244: [clangd] Show used symbols on #include line hover..
Thu, Mar 23, 2:23 AM · Restricted Project, Restricted Project
hokein accepted D144976: [clangd] Add provider info on symbol hover..

Thanks, this looks great! Please fix the code style of the unit-test (see my other comment) before landing it.

Thu, Mar 23, 1:46 AM · Restricted Project, Restricted Project

Mon, Mar 20

hokein accepted D146417: [clangd] Fix AddUsing in the face of typo-correction.

Thanks!

Mon, Mar 20, 6:29 AM · Restricted Project, Restricted Project
hokein added inline comments to D146406: [IncludeCleaner][clangd] Mark umbrella headers as users of private.
Mon, Mar 20, 6:15 AM · Restricted Project, Restricted Project, Restricted Project
hokein added inline comments to D146244: [clangd] Show used symbols on #include line hover..
Mon, Mar 20, 5:14 AM · Restricted Project, Restricted Project
hokein added a comment to D144976: [clangd] Add provider info on symbol hover..

Thanks, this looks great, some more comments (most are nits)

Mon, Mar 20, 3:57 AM · Restricted Project, Restricted Project
hokein accepted D146377: [clangd] Remove reundant use of getSpellingLoc().

Thanks!

Mon, Mar 20, 1:36 AM · Restricted Project, Restricted Project

Fri, Mar 17

hokein requested review of D146279: [clangd] Extend CollectMainFileMacros..
Fri, Mar 17, 2:43 AM · Restricted Project, Restricted Project

Thu, Mar 16

hokein added a comment to D144976: [clangd] Add provider info on symbol hover..

Thanks, left some comments on the unittest, I think we can make it simpler.

Thu, Mar 16, 9:20 AM · Restricted Project, Restricted Project
hokein committed rG1f5fdc22a26c: [clang] Fix a UsingTemplate regression after… (authored by hokein).
[clang] Fix a UsingTemplate regression after…
Thu, Mar 16, 5:00 AM · Restricted Project, Restricted Project, Restricted Project
hokein closed D146202: [clang] Fix a UsingTemplate regression after 3e78fa860235431323aaf08c8fa922d75a7cfffa.
Thu, Mar 16, 4:59 AM · Restricted Project, Restricted Project, Restricted Project
hokein added a comment to D146202: [clang] Fix a UsingTemplate regression after 3e78fa860235431323aaf08c8fa922d75a7cfffa.

Thanks for the review.

Thu, Mar 16, 4:27 AM · Restricted Project, Restricted Project, Restricted Project
hokein requested review of D146202: [clang] Fix a UsingTemplate regression after 3e78fa860235431323aaf08c8fa922d75a7cfffa.
Thu, Mar 16, 2:20 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Mar 15

hokein accepted D146116: [clangd] Respect WantDiags when emitting diags from possibly stale preambles.
Wed, Mar 15, 3:28 AM · Restricted Project, Restricted Project
hokein added inline comments to D144976: [clangd] Add provider info on symbol hover..
Wed, Mar 15, 3:26 AM · Restricted Project, Restricted Project
hokein accepted D146026: [clangd] Patch PragmaMarks in preamble section of the file.
Wed, Mar 15, 12:36 AM · Restricted Project, Restricted Project

Tue, Mar 14

hokein accepted D146028: [clangd] Patch main file macros in preamble.
Tue, Mar 14, 6:48 AM · Restricted Project, Restricted Project
hokein added inline comments to D146026: [clangd] Patch PragmaMarks in preamble section of the file.
Tue, Mar 14, 6:46 AM · Restricted Project, Restricted Project
hokein committed rGca431a4fcbec: Remove an extra `//` in the IWYU pragma for gtest-matchers.h (authored by hokein).
Remove an extra `//` in the IWYU pragma for gtest-matchers.h
Tue, Mar 14, 5:12 AM · Restricted Project
hokein closed D146022: Remove an extra `//` in the IWYU pragma for gtest-matchers.h.
Tue, Mar 14, 5:12 AM · Restricted Project, Restricted Project
hokein committed rG586e497f7985: [Tooling/Inclusion] Index more sub std namespace symbols. (authored by hokein).
[Tooling/Inclusion] Index more sub std namespace symbols.
Tue, Mar 14, 5:09 AM · Restricted Project, Restricted Project
hokein closed D146021: [Tooling/Inclusion] Index more sub std namespace symbols..
Tue, Mar 14, 5:09 AM · Restricted Project, Restricted Project
hokein accepted D146024: [clangd] Drop stale macro and mark ranges.
Tue, Mar 14, 5:08 AM · Restricted Project, Restricted Project
hokein added inline comments to D144976: [clangd] Add provider info on symbol hover..
Tue, Mar 14, 1:58 AM · Restricted Project, Restricted Project
hokein requested review of D146022: Remove an extra `//` in the IWYU pragma for gtest-matchers.h.
Tue, Mar 14, 1:39 AM · Restricted Project, Restricted Project
hokein requested review of D146021: [Tooling/Inclusion] Index more sub std namespace symbols..
Tue, Mar 14, 1:35 AM · Restricted Project, Restricted Project
hokein requested review of D146017: [clangd][wip] Get rid of the include-cleaner hacky macro-reference implementation.
Tue, Mar 14, 12:45 AM · Restricted Project, Restricted Project

Mon, Mar 13

hokein committed rGfd299a7880ae: [clangd] Remove the IncludeStructure::isSelfContained API. (authored by hokein).
[clangd] Remove the IncludeStructure::isSelfContained API.
Mon, Mar 13, 4:42 AM · Restricted Project, Restricted Project
hokein closed D145917: [clangd] Remove the IncludeStructure::isSelfContained API..
Mon, Mar 13, 4:42 AM · Restricted Project, Restricted Project
hokein committed rGbe39daea846e: [clangd] Remove IWYU handling code that is used only for the old unused-include… (authored by hokein).
[clangd] Remove IWYU handling code that is used only for the old unused-include…
Mon, Mar 13, 4:37 AM · Restricted Project, Restricted Project
hokein closed D145916: [clangd] Remove IWYU handling code that is used only for the old unused-include feature..
Mon, Mar 13, 4:36 AM · Restricted Project, Restricted Project
hokein added inline comments to D145921: [clangd] Add missing unittests to build graph.
Mon, Mar 13, 4:10 AM · Restricted Project, Restricted Project
hokein abandoned D145922: [clangd] Include SpecialMembersTests.cpp to the unittest..

I didn't notice https://reviews.llvm.org/D145921, let's deprecate this one.

Mon, Mar 13, 4:10 AM · Restricted Project, Restricted Project
hokein requested review of D145922: [clangd] Include SpecialMembersTests.cpp to the unittest..
Mon, Mar 13, 4:05 AM · Restricted Project, Restricted Project
hokein accepted D144453: [clangd] Fix a bug in TweakTest::decorate().

Good catch, thanks!

Mon, Mar 13, 3:39 AM · Restricted Project, Restricted Project
hokein requested review of D145917: [clangd] Remove the IncludeStructure::isSelfContained API..
Mon, Mar 13, 2:54 AM · Restricted Project, Restricted Project
hokein requested review of D145916: [clangd] Remove IWYU handling code that is used only for the old unused-include feature..
Mon, Mar 13, 2:46 AM · Restricted Project, Restricted Project

Fri, Mar 10

hokein planned changes to D145782: [clangd] Don't ignore headers with IWYU export pragmas for unused-include analysis..

It appears that there is an issue with this patch, so please hold on for review.

Fri, Mar 10, 4:12 AM · Restricted Project, Restricted Project
hokein requested review of D145782: [clangd] Don't ignore headers with IWYU export pragmas for unused-include analysis..
Fri, Mar 10, 3:44 AM · Restricted Project, Restricted Project
hokein committed rG7ab16be4c030: [clangd] UnusedIncludes: Strict config now uses the include-cleaner-library… (authored by hokein).
[clangd] UnusedIncludes: Strict config now uses the include-cleaner-library…
Fri, Mar 10, 2:56 AM · Restricted Project, Restricted Project
hokein closed D145773: [clangd] UnusedIncludes: Strict config now uses the include-cleaner-library implementation..
Fri, Mar 10, 2:56 AM · Restricted Project, Restricted Project
hokein updated the summary of D145773: [clangd] UnusedIncludes: Strict config now uses the include-cleaner-library implementation..
Fri, Mar 10, 2:45 AM · Restricted Project, Restricted Project
hokein abandoned D145776: [clangd] Remove the classical clangd-own unsued-include implementation..

Merge the change in https://reviews.llvm.org/D145773 per the review comment.

Fri, Mar 10, 2:44 AM · Restricted Project, Restricted Project
hokein updated the diff for D145773: [clangd] UnusedIncludes: Strict config now uses the include-cleaner-library implementation..

add the removal of the clangd-own implementation.

Fri, Mar 10, 2:39 AM · Restricted Project, Restricted Project
hokein added inline comments to D145773: [clangd] UnusedIncludes: Strict config now uses the include-cleaner-library implementation..
Fri, Mar 10, 2:32 AM · Restricted Project, Restricted Project
hokein updated the diff for D145773: [clangd] UnusedIncludes: Strict config now uses the include-cleaner-library implementation..

Add diagnostic for Experiment flag usage.

Fri, Mar 10, 2:32 AM · Restricted Project, Restricted Project
hokein requested review of D145776: [clangd] Remove the classical clangd-own unsued-include implementation..
Fri, Mar 10, 1:56 AM · Restricted Project, Restricted Project
hokein requested review of D145773: [clangd] UnusedIncludes: Strict config now uses the include-cleaner-library implementation..
Fri, Mar 10, 1:36 AM · Restricted Project, Restricted Project

Thu, Mar 9

hokein committed rGfbcca1bc03d3: [bazel] Port for 0aac9a2875bad4f065367e4a6553fad78605f895 (authored by hokein).
[bazel] Port for 0aac9a2875bad4f065367e4a6553fad78605f895
Thu, Mar 9, 2:38 AM · Restricted Project
hokein committed rG22c0ce96912f: [Tooling/Inclusion] Add atomic family symbols (authored by hokein).
[Tooling/Inclusion] Add atomic family symbols
Thu, Mar 9, 12:22 AM · Restricted Project, Restricted Project
hokein closed D145557: [Tooling/Inclusion] Add atomic family symbols.
Thu, Mar 9, 12:22 AM · Restricted Project, Restricted Project
hokein committed rG404b1b2ed42f: [Tooling/Inclusion] Add missing placerholder _1 symbols. (authored by hokein).
[Tooling/Inclusion] Add missing placerholder _1 symbols.
Thu, Mar 9, 12:21 AM · Restricted Project, Restricted Project
hokein closed D145553: [Tooling/Inclusion] Add missing placerholder _1 symbols..
Thu, Mar 9, 12:20 AM · Restricted Project, Restricted Project
hokein updated the diff for D145553: [Tooling/Inclusion] Add missing placerholder _1 symbols..

address comment: add more _N symbol up to _29.

Thu, Mar 9, 12:08 AM · Restricted Project, Restricted Project

Wed, Mar 8

hokein added inline comments to D143496: [clangd] Add support for missing includes analysis..
Wed, Mar 8, 2:52 AM · Restricted Project, Restricted Project
hokein requested review of D145557: [Tooling/Inclusion] Add atomic family symbols.
Wed, Mar 8, 1:53 AM · Restricted Project, Restricted Project
hokein requested review of D145553: [Tooling/Inclusion] Add missing placerholder _1 symbols..
Wed, Mar 8, 12:51 AM · Restricted Project, Restricted Project

Mon, Mar 6

hokein committed rG7eb36f5d87a6: [Tooling/Inclusion] Add missing index_sequence symbols. (authored by hokein).
[Tooling/Inclusion] Add missing index_sequence symbols.
Mon, Mar 6, 5:10 AM · Restricted Project, Restricted Project
hokein closed D145365: [Tooling/Inclusion] Add missing index_sequence symbols..
Mon, Mar 6, 5:09 AM · Restricted Project, Restricted Project
hokein added inline comments to D145365: [Tooling/Inclusion] Add missing index_sequence symbols..
Mon, Mar 6, 4:37 AM · Restricted Project, Restricted Project
hokein committed rGb2897ad70301: [include-cleaner] Fix a crash on non-identifier-name symbols. (authored by hokein).
[include-cleaner] Fix a crash on non-identifier-name symbols.
Mon, Mar 6, 4:25 AM · Restricted Project, Restricted Project
hokein closed D145364: [include-cleaner] Fix a crash on non-identifier-name symbols..
Mon, Mar 6, 4:25 AM · Restricted Project, Restricted Project
hokein added inline comments to D145365: [Tooling/Inclusion] Add missing index_sequence symbols..
Mon, Mar 6, 3:09 AM · Restricted Project, Restricted Project
hokein requested review of D145365: [Tooling/Inclusion] Add missing index_sequence symbols..
Mon, Mar 6, 3:08 AM · Restricted Project, Restricted Project
hokein added inline comments to D145364: [include-cleaner] Fix a crash on non-identifier-name symbols..
Mon, Mar 6, 2:53 AM · Restricted Project, Restricted Project
hokein requested review of D145364: [include-cleaner] Fix a crash on non-identifier-name symbols..
Mon, Mar 6, 2:48 AM · Restricted Project, Restricted Project
hokein committed rGaa3e85a812a0: [include-fixer] Add the missing optional header to the STL header list. (authored by hokein).
[include-fixer] Add the missing optional header to the STL header list.
Mon, Mar 6, 1:35 AM · Restricted Project, Restricted Project

Thu, Mar 2

hokein committed rG5e6428b00393: [clangd] Use the normalized file path to do the filtering. (authored by hokein).
[clangd] Use the normalized file path to do the filtering.
Thu, Mar 2, 4:37 AM · Restricted Project, Restricted Project
hokein committed rGf75e45093d3d: [bazel] Add missing dep for llvm-c-test (authored by hokein).
[bazel] Add missing dep for llvm-c-test
Thu, Mar 2, 2:02 AM · Restricted Project
hokein committed rG91676abf6aeb: [bazel] Port for f7ca01333214f934c580c162afdee933e7430b6c (authored by hokein).
[bazel] Port for f7ca01333214f934c580c162afdee933e7430b6c
Thu, Mar 2, 1:40 AM · Restricted Project
hokein added a comment to D144976: [clangd] Add provider info on symbol hover..

Thanks, left a few comments on the implementation.

Thu, Mar 2, 1:33 AM · Restricted Project, Restricted Project

Tue, Feb 28

hokein committed rG06faa47ecc56: [mlir] Fix the missing mlir test BUILD.bazel for… (authored by hokein).
[mlir] Fix the missing mlir test BUILD.bazel for…
Tue, Feb 28, 1:17 AM · Restricted Project
hokein committed rG639fc00b2ddc: [mlir] Port bazel for 3948f0a0b5e5fecddf315b8de321c6a44ee7ff5c (authored by hokein).
[mlir] Port bazel for 3948f0a0b5e5fecddf315b8de321c6a44ee7ff5c
Tue, Feb 28, 12:33 AM · Restricted Project

Mon, Feb 27

hokein committed rG779d54fd75c1: [mlir] Fix a -Wunused-variable warning, NFC (authored by hokein).
[mlir] Fix a -Wunused-variable warning, NFC
Mon, Feb 27, 8:11 AM · Restricted Project, Restricted Project
hokein committed rG8877d8f5caac: [mlir] Port bazel for 115711c19cd287c098a872c63a00478ca635f642 (authored by hokein).
[mlir] Port bazel for 115711c19cd287c098a872c63a00478ca635f642
Mon, Feb 27, 7:51 AM · Restricted Project
hokein committed rG0264ca431de8: [bazel] Port Bazel for e7950fceb1e7f82370f6cff80b258e552eb410a6 (authored by hokein).
[bazel] Port Bazel for e7950fceb1e7f82370f6cff80b258e552eb410a6
Mon, Feb 27, 2:35 AM · Restricted Project
hokein committed rGb6f48341c595: [include-cleaner] Fix an unintended early return when checking the (authored by hokein).
[include-cleaner] Fix an unintended early return when checking the
Mon, Feb 27, 1:13 AM · Restricted Project, Restricted Project

Fri, Feb 24

hokein committed rG4416e4a9ed06: [Tooling/Inclusion] Add the generic abs symbol to the table. (authored by hokein).
[Tooling/Inclusion] Add the generic abs symbol to the table.
Fri, Feb 24, 4:57 AM · Restricted Project, Restricted Project
hokein closed D144721: [Tooling/Inclusion] Add the generic abs symbol to the table..
Fri, Feb 24, 4:56 AM · Restricted Project, Restricted Project
hokein added a comment to D144721: [Tooling/Inclusion] Add the generic abs symbol to the table..
In D144721#4150122, @kadircet wrote:

this fixes the abs in the mentioned issue, but leaves the friends out :( those are specifically std::labs, std::llabs, std::imaxabs

Fri, Feb 24, 4:39 AM · Restricted Project, Restricted Project
hokein requested review of D144722: [Tooling/Inclusion] Get rid of the "None" magic string for empty namespace symbols..
Fri, Feb 24, 4:22 AM · Restricted Project, Restricted Project
hokein requested review of D144721: [Tooling/Inclusion] Add the generic abs symbol to the table..
Fri, Feb 24, 4:19 AM · Restricted Project, Restricted Project
hokein committed rGc86f05dd48d2: [Tooling/Inclusion] Add the missing NULL symbol to the table. (authored by hokein).
[Tooling/Inclusion] Add the missing NULL symbol to the table.
Fri, Feb 24, 4:00 AM · Restricted Project, Restricted Project
hokein closed D144713: [Tooling/Includsion] Add the missing NULL symbol to the table..
Fri, Feb 24, 4:00 AM · Restricted Project, Restricted Project
hokein updated the diff for D144713: [Tooling/Includsion] Add the missing NULL symbol to the table..

oops, fix the patch

Fri, Feb 24, 3:12 AM · Restricted Project, Restricted Project
hokein requested review of D144713: [Tooling/Includsion] Add the missing NULL symbol to the table..
Fri, Feb 24, 2:48 AM · Restricted Project, Restricted Project

Feb 24 2023

hokein accepted D144703: [clangd] Avoid using CompletionItemKind.Text for macro completions.

Thanks, this looks an improvement to me!

Feb 24 2023, 1:29 AM · Restricted Project, Restricted Project
hokein accepted D144708: [clangd] Fix UB in scanPreamble.
Feb 24 2023, 1:12 AM · Restricted Project, Restricted Project
hokein accepted D144646: [Tooling][Inclusions] Add c-header and global namespace alternatives for size_t.

Thanks!

Feb 24 2023, 12:21 AM · Restricted Project, Restricted Project

Feb 23 2023

hokein accepted D144641: [clangd] Set diag data before emitting.
Feb 23 2023, 6:21 AM · Restricted Project, Restricted Project
hokein committed rGcbcb3eef70de: [Tooling/Inclusion] Handle std::get symbol. (authored by hokein).
[Tooling/Inclusion] Handle std::get symbol.
Feb 23 2023, 1:27 AM · Restricted Project, Restricted Project, Restricted Project