Page MenuHomePhabricator

hokein (Haojian Wu)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 19 2015, 3:38 AM (191 w, 2 d)

Recent Activity

Thu, Apr 18

hokein accepted D60871: [CodeComplete] Remove obsolete isOutputBinary()..

I don't know the original motivation of this code. Since we never use it, so LGTM :)

Thu, Apr 18, 8:06 AM · Restricted Project, Restricted Project
hokein added inline comments to D60827: [rename] Deduplicate symbol occurrences.
Thu, Apr 18, 7:44 AM · Restricted Project
hokein committed rG8bbbd31cdd4a: [clang-tidy] Address post-commit comments (authored by hokein).
[clang-tidy] Address post-commit comments
Thu, Apr 18, 7:17 AM
hokein committed rCTE358666: [clang-tidy] Address post-commit comments.
[clang-tidy] Address post-commit comments
Thu, Apr 18, 7:16 AM
hokein committed rL358666: [clang-tidy] Address post-commit comments.
[clang-tidy] Address post-commit comments
Thu, Apr 18, 7:16 AM
hokein committed rC358666: [clang-tidy] Address post-commit comments.
[clang-tidy] Address post-commit comments
Thu, Apr 18, 7:16 AM
hokein closed D60857: [clang-tidy] Address post-commit comments.
Thu, Apr 18, 7:16 AM · Restricted Project
hokein updated the diff for D60857: [clang-tidy] Address post-commit comments.

fix doxygen comment.

Thu, Apr 18, 7:14 AM · Restricted Project
hokein added inline comments to D60857: [clang-tidy] Address post-commit comments.
Thu, Apr 18, 6:09 AM · Restricted Project
hokein updated the diff for D60857: [clang-tidy] Address post-commit comments.

Use check_clang_tidy.

Thu, Apr 18, 6:09 AM · Restricted Project
hokein committed rG0842daf5ba75: [clangd] Emit better error messages when rename fails. (authored by hokein).
[clangd] Emit better error messages when rename fails.
Thu, Apr 18, 4:34 AM
hokein committed rL358658: [clangd] Emit better error messages when rename fails..
[clangd] Emit better error messages when rename fails.
Thu, Apr 18, 4:34 AM
hokein committed rCTE358658: [clangd] Emit better error messages when rename fails..
[clangd] Emit better error messages when rename fails.
Thu, Apr 18, 4:34 AM
hokein closed D60821: [clangd] Emit better error messages when rename fails..
Thu, Apr 18, 4:33 AM · Restricted Project
hokein updated the diff for D60821: [clangd] Emit better error messages when rename fails..

Simplify the code further.

Thu, Apr 18, 4:28 AM · Restricted Project
hokein added inline comments to D60821: [clangd] Emit better error messages when rename fails..
Thu, Apr 18, 2:52 AM · Restricted Project
hokein updated the diff for D60821: [clangd] Emit better error messages when rename fails..

Address comments.

Thu, Apr 18, 2:52 AM · Restricted Project
hokein updated the diff for D60857: [clang-tidy] Address post-commit comments.

Cleanup.

Thu, Apr 18, 2:15 AM · Restricted Project
hokein created D60857: [clang-tidy] Address post-commit comments.
Thu, Apr 18, 2:15 AM · Restricted Project

Wed, Apr 17

hokein added a comment to rL358576: [clang-tidy] Add fix descriptions to clang-tidy checks..

A few post-commit comments.

Wed, Apr 17, 10:57 AM
hokein created D60827: [rename] Deduplicate symbol occurrences.
Wed, Apr 17, 7:55 AM · Restricted Project
hokein created D60821: [clangd] Emit better error messages when rename fails..
Wed, Apr 17, 6:26 AM · Restricted Project
hokein committed rGf2879d8a4877: [clang-tidy] Add fix descriptions to clang-tidy checks. (authored by hokein).
[clang-tidy] Add fix descriptions to clang-tidy checks.
Wed, Apr 17, 5:58 AM
hokein committed rCTE358576: [clang-tidy] Add fix descriptions to clang-tidy checks..
[clang-tidy] Add fix descriptions to clang-tidy checks.
Wed, Apr 17, 5:58 AM
hokein committed rL358576: [clang-tidy] Add fix descriptions to clang-tidy checks..
[clang-tidy] Add fix descriptions to clang-tidy checks.
Wed, Apr 17, 5:57 AM
hokein committed rC358576: [clang-tidy] Add fix descriptions to clang-tidy checks..
[clang-tidy] Add fix descriptions to clang-tidy checks.
Wed, Apr 17, 5:57 AM
hokein closed D59932: [clang-tidy] Add fix descriptions to clang-tidy checks..
Wed, Apr 17, 5:57 AM · Restricted Project, Restricted Project

Tue, Apr 16

hokein updated the diff for D60776: [clang-tidy] Add test support for the fix description..

cleanup

Tue, Apr 16, 7:54 AM · Restricted Project
hokein created D60776: [clang-tidy] Add test support for the fix description..
Tue, Apr 16, 7:53 AM · Restricted Project
hokein retitled D59932: [clang-tidy] Add fix descriptions to clang-tidy checks. from [clang-tidy] **Prototype**: Add fix description to clang-tidy checks. to [clang-tidy] Add fix descriptions to clang-tidy checks..
Tue, Apr 16, 7:32 AM · Restricted Project, Restricted Project

Fri, Apr 12

hokein accepted D60257: [Lookup] Invisible decls should not be ambiguous when renaming..
Fri, Apr 12, 6:42 AM · Restricted Project
hokein committed rG6460883312aa: [clangd] Enable clang-tidy by default. (authored by hokein).
[clangd] Enable clang-tidy by default.
Fri, Apr 12, 6:09 AM
hokein committed rCTE358282: [clangd] Enable clang-tidy by default..
[clangd] Enable clang-tidy by default.
Fri, Apr 12, 6:09 AM
hokein committed rL358282: [clangd] Enable clang-tidy by default..
[clangd] Enable clang-tidy by default.
Fri, Apr 12, 6:09 AM
hokein closed D60560: [clangd] Enable clang-tidy by default..
Fri, Apr 12, 6:09 AM · Restricted Project, Restricted Project
hokein added inline comments to D60257: [Lookup] Invisible decls should not be ambiguous when renaming..
Fri, Apr 12, 2:11 AM · Restricted Project
hokein added inline comments to D59932: [clang-tidy] Add fix descriptions to clang-tidy checks..
Fri, Apr 12, 1:52 AM · Restricted Project, Restricted Project
hokein updated the diff for D59932: [clang-tidy] Add fix descriptions to clang-tidy checks..

Update and rebase.

Fri, Apr 12, 1:52 AM · Restricted Project, Restricted Project
hokein added a comment to D55044: [clang-tidy] check for Abseil make_unique.

Thanks, looks better now.
I saw there are still a few undone comments, please mark them done when you address them.

Fri, Apr 12, 1:44 AM · Restricted Project

Thu, Apr 11

hokein created D60560: [clangd] Enable clang-tidy by default..
Thu, Apr 11, 3:48 AM · Restricted Project, Restricted Project

Mon, Apr 8

hokein accepted D60323: [clangd] Include compile command inference in fileStatus API.
Mon, Apr 8, 2:39 AM · Restricted Project

Fri, Apr 5

hokein added inline comments to D59932: [clang-tidy] Add fix descriptions to clang-tidy checks..
Fri, Apr 5, 6:07 AM · Restricted Project, Restricted Project
hokein added inline comments to D59932: [clang-tidy] Add fix descriptions to clang-tidy checks..
Fri, Apr 5, 5:17 AM · Restricted Project, Restricted Project
hokein added a comment to D59932: [clang-tidy] Add fix descriptions to clang-tidy checks..

This looks like a more promising direction. Thanks for the readiness to experiment with this.

See the comments inline.

Fri, Apr 5, 5:06 AM · Restricted Project, Restricted Project
hokein updated the diff for D59932: [clang-tidy] Add fix descriptions to clang-tidy checks..

Remove a stale comment.

Fri, Apr 5, 5:06 AM · Restricted Project, Restricted Project
hokein updated the diff for D59932: [clang-tidy] Add fix descriptions to clang-tidy checks..

Fix apply-replacements, and address comments.

Fri, Apr 5, 5:02 AM · Restricted Project, Restricted Project

Wed, Apr 3

hokein added a comment to D59932: [clang-tidy] Add fix descriptions to clang-tidy checks..

Running out of time today, the patch is not finished yet, but it should be good for another initial review/comments.

Wed, Apr 3, 8:26 AM · Restricted Project, Restricted Project
hokein updated the diff for D59932: [clang-tidy] Add fix descriptions to clang-tidy checks..

Emit the check fix description via diagnostic::note.

Wed, Apr 3, 8:20 AM · Restricted Project, Restricted Project
hokein accepted D60197: [clang-tidy] Remove the old ClangTidyCheck::registerPPCallbacks method.
Wed, Apr 3, 6:53 AM · Restricted Project
hokein added a comment to D59932: [clang-tidy] Add fix descriptions to clang-tidy checks..

As discussed offline, the current approach only works for checks provide a single fix, providing such API is somehow misleading.

Wed, Apr 3, 2:41 AM · Restricted Project, Restricted Project

Tue, Apr 2

hokein added inline comments to D59932: [clang-tidy] Add fix descriptions to clang-tidy checks..
Tue, Apr 2, 6:19 AM · Restricted Project, Restricted Project

Mon, Apr 1

hokein added a comment to D59932: [clang-tidy] Add fix descriptions to clang-tidy checks..

I think the idea is good and implementation, too. If we iterate all checks anyway (probably?) we could think about adding a severity to the checks, too?

I know that code-checker and code-compass have something like this to signal importance of problems (say bugprone and cert differ from readability for example).

Mon, Apr 1, 5:46 AM · Restricted Project, Restricted Project
hokein updated the diff for D59932: [clang-tidy] Add fix descriptions to clang-tidy checks..

Update the patch:

Mon, Apr 1, 5:46 AM · Restricted Project, Restricted Project

Thu, Mar 28

hokein accepted D59935: Disable warnings when indexing as a standalone action..
Thu, Mar 28, 9:21 AM · Restricted Project, Restricted Project
hokein added inline comments to D59935: Disable warnings when indexing as a standalone action..
Thu, Mar 28, 8:04 AM · Restricted Project, Restricted Project
hokein added a comment to D59932: [clang-tidy] Add fix descriptions to clang-tidy checks..

This is my first attempt, still missing tests, but it should be in a shape to get early feedbacks.

Thu, Mar 28, 7:23 AM · Restricted Project, Restricted Project
hokein retitled D59932: [clang-tidy] Add fix descriptions to clang-tidy checks. from [clang-tidy] **Prototype**: Add fix descrption to clang-tidy checks. to [clang-tidy] **Prototype**: Add fix description to clang-tidy checks..
Thu, Mar 28, 7:22 AM · Restricted Project, Restricted Project
hokein created D59932: [clang-tidy] Add fix descriptions to clang-tidy checks..
Thu, Mar 28, 7:14 AM · Restricted Project, Restricted Project

Wed, Mar 27

hokein committed rG566fba03de5a: [clangd] Bump vscode-clangd v0.0.12. (authored by hokein).
[clangd] Bump vscode-clangd v0.0.12.
Wed, Mar 27, 9:01 AM
hokein committed rL357082: [clangd] Bump vscode-clangd v0.0.12..
[clangd] Bump vscode-clangd v0.0.12.
Wed, Mar 27, 9:00 AM
hokein committed rCTE357082: [clangd] Bump vscode-clangd v0.0.12..
[clangd] Bump vscode-clangd v0.0.12.
Wed, Mar 27, 9:00 AM
hokein committed rG55beb2f54970: [clangd] Fix the inconsistent code indent in vscode extension, NFC. (authored by hokein).
[clangd] Fix the inconsistent code indent in vscode extension, NFC.
Wed, Mar 27, 8:51 AM
hokein committed rCTE357078: [clangd] Fix the inconsistent code indent in vscode extension, NFC..
[clangd] Fix the inconsistent code indent in vscode extension, NFC.
Wed, Mar 27, 8:49 AM
hokein committed rL357078: [clangd] Fix the inconsistent code indent in vscode extension, NFC..
[clangd] Fix the inconsistent code indent in vscode extension, NFC.
Wed, Mar 27, 8:49 AM
hokein committed rGd44e2013766b: [clangd] Add activate command to the vscode extension. (authored by hokein).
[clangd] Add activate command to the vscode extension.
Wed, Mar 27, 8:43 AM
hokein committed rCTE357075: [clangd] Add activate command to the vscode extension..
[clangd] Add activate command to the vscode extension.
Wed, Mar 27, 8:43 AM
hokein committed rL357075: [clangd] Add activate command to the vscode extension..
[clangd] Add activate command to the vscode extension.
Wed, Mar 27, 8:43 AM
hokein closed D59817: [clangd] Add activate command to the vscode extension..
Wed, Mar 27, 8:43 AM · Restricted Project, Restricted Project

Tue, Mar 26

hokein created D59817: [clangd] Add activate command to the vscode extension..
Tue, Mar 26, 5:34 AM · Restricted Project, Restricted Project

Mon, Mar 25

hokein added a comment to D59627: [clang-format] Keep protobuf "package" statement on one line.

This patch has caused a regression issue, see the test:

Mon, Mar 25, 8:45 AM · Restricted Project, Restricted Project
hokein committed rGae3fefe39782: Revert "[clang-format] Keep protobuf "package" statement on one line" (authored by hokein).
Revert "[clang-format] Keep protobuf "package" statement on one line"
Mon, Mar 25, 8:45 AM
hokein committed rC356912: Revert "[clang-format] Keep protobuf "package" statement on one line".
Revert "[clang-format] Keep protobuf "package" statement on one line"
Mon, Mar 25, 8:45 AM
hokein committed rL356912: Revert "[clang-format] Keep protobuf "package" statement on one line".
Revert "[clang-format] Keep protobuf "package" statement on one line"
Mon, Mar 25, 8:44 AM
hokein accepted D59759: [clangd] Add .cu files to VSCode extension.
Mon, Mar 25, 7:47 AM · Restricted Project
hokein added a comment to D59759: [clangd] Add .cu files to VSCode extension.

Do we need to add an entry "onLanguage:cuda" for cuda in the extension package.json?

Yeah, sounds reasonable, but I don't see cuda in the list of languages in VSCode, nor does it auto-detect a language for .cu files for me.
Can those added by extensions (that I might be missing)? What would be the correct way to lookup all available languages?

Mon, Mar 25, 6:59 AM · Restricted Project
hokein committed rG3c488d7eb346: [clangd] Add std subnamespace symbols to the symbol map. (authored by hokein).
[clangd] Add std subnamespace symbols to the symbol map.
Mon, Mar 25, 6:15 AM
hokein committed rL356894: [clangd] Add std subnamespace symbols to the symbol map..
[clangd] Add std subnamespace symbols to the symbol map.
Mon, Mar 25, 6:13 AM
hokein committed rCTE356894: [clangd] Add std subnamespace symbols to the symbol map..
[clangd] Add std subnamespace symbols to the symbol map.
Mon, Mar 25, 6:13 AM
hokein closed D59364: [clangd] Add std subnamespace symbols to the symbol map..
Mon, Mar 25, 6:13 AM · Restricted Project
hokein committed rG9ac2859cf2f2: [pp-trace] Use ClangTool in pp-trace, NFC (authored by hokein).
[pp-trace] Use ClangTool in pp-trace, NFC
Mon, Mar 25, 5:50 AM
hokein committed rL356893: [pp-trace] Use ClangTool in pp-trace, NFC.
[pp-trace] Use ClangTool in pp-trace, NFC
Mon, Mar 25, 5:49 AM
hokein committed rCTE356893: [pp-trace] Use ClangTool in pp-trace, NFC.
[pp-trace] Use ClangTool in pp-trace, NFC
Mon, Mar 25, 5:48 AM
hokein closed D59764: [pp-trace] Use ClangTool in pp-trace, NFC.
Mon, Mar 25, 5:48 AM · Restricted Project
hokein added a comment to D59759: [clangd] Add .cu files to VSCode extension.

Do we need to add an entry "onLanguage:cuda" for cuda in the extension package.json?

Mon, Mar 25, 5:31 AM · Restricted Project
hokein created D59764: [pp-trace] Use ClangTool in pp-trace, NFC.
Mon, Mar 25, 5:28 AM · Restricted Project
hokein added a comment to D59364: [clangd] Add std subnamespace symbols to the symbol map..

friendly ping ;)

Mon, Mar 25, 3:29 AM · Restricted Project
hokein committed rGa5a4bb69c16f: Add llvm:: qualifer to make_unique, NFC (authored by hokein).
Add llvm:: qualifer to make_unique, NFC
Mon, Mar 25, 2:53 AM
hokein committed rCTE356878: Add llvm:: qualifer to make_unique, NFC.
Add llvm:: qualifer to make_unique, NFC
Mon, Mar 25, 2:53 AM
hokein committed rL356878: Add llvm:: qualifer to make_unique, NFC.
Add llvm:: qualifer to make_unique, NFC
Mon, Mar 25, 2:53 AM
hokein accepted D59757: [clangd] Send empty diagnostics when a file is closed.
Mon, Mar 25, 2:47 AM · Restricted Project
hokein added inline comments to D59757: [clangd] Send empty diagnostics when a file is closed.
Mon, Mar 25, 2:27 AM · Restricted Project
hokein accepted D59714: [clang-tidy] Separate the check-facing interface.

LGTM

Mon, Mar 25, 2:04 AM · Restricted Project, Restricted Project

Mar 14 2019

hokein created D59364: [clangd] Add std subnamespace symbols to the symbol map..
Mar 14 2019, 7:18 AM · Restricted Project
hokein committed rG7f51b5dc3271: [clangd] Using symbol name to map includes for STL symbols. (authored by hokein).
[clangd] Using symbol name to map includes for STL symbols.
Mar 14 2019, 4:26 AM
hokein committed rL356134: [clangd] Using symbol name to map includes for STL symbols..
[clangd] Using symbol name to map includes for STL symbols.
Mar 14 2019, 4:25 AM
hokein committed rCTE356134: [clangd] Using symbol name to map includes for STL symbols..
[clangd] Using symbol name to map includes for STL symbols.
Mar 14 2019, 4:25 AM
hokein closed D58345: [clangd] Using symbol name to map includes for STL symbols..
Mar 14 2019, 4:25 AM · Restricted Project, Restricted Project
hokein updated the diff for D58345: [clangd] Using symbol name to map includes for STL symbols..

One more comment.

Mar 14 2019, 4:18 AM · Restricted Project, Restricted Project
hokein updated the diff for D58345: [clangd] Using symbol name to map includes for STL symbols..

Address comments

Mar 14 2019, 4:01 AM · Restricted Project, Restricted Project
hokein added inline comments to D58345: [clangd] Using symbol name to map includes for STL symbols..
Mar 14 2019, 4:01 AM · Restricted Project, Restricted Project