Page MenuHomePhabricator

hokein (Haojian Wu)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 19 2015, 3:38 AM (270 w, 2 d)

Recent Activity

Today

hokein accepted D89785: [clangd] Add basic support for attributes (selection, hover).
Fri, Oct 23, 1:04 AM · Restricted Project
hokein added inline comments to D89946: [clang] Suppress "follow-up" diagnostics on recovery call expressions..
Fri, Oct 23, 1:00 AM · Restricted Project
hokein updated the diff for D89946: [clang] Suppress "follow-up" diagnostics on recovery call expressions..

address comments and add AST tests.

Fri, Oct 23, 1:00 AM · Restricted Project
hokein added inline comments to D89785: [clangd] Add basic support for attributes (selection, hover).
Fri, Oct 23, 12:02 AM · Restricted Project

Yesterday

hokein added inline comments to D89946: [clang] Suppress "follow-up" diagnostics on recovery call expressions..
Thu, Oct 22, 3:46 AM · Restricted Project
hokein requested review of D89946: [clang] Suppress "follow-up" diagnostics on recovery call expressions..
Thu, Oct 22, 3:40 AM · Restricted Project

Wed, Oct 21

hokein added a comment to D87349: [clang] adapt c++17 behavior for dependent decltype-specifiers.

friendly ping @rsmith :)

Wed, Oct 21, 10:51 AM · Restricted Project
hokein added a comment to D84637: [AST] Enhance the const expression evaluator to support error-dependent exprs..

friendly ping @rsmith :)

Wed, Oct 21, 10:51 AM · Restricted Project

Tue, Oct 20

hokein accepted D89743: Support Attr in DynTypedNode and ASTMatchers..
Tue, Oct 20, 7:09 AM · Restricted Project
hokein requested review of D89790: [clangd] Add basic conflict detection for the rename..
Tue, Oct 20, 7:02 AM · Restricted Project
hokein committed rG84048e234f8f: [format] foo.<name>.h should be the main-header for foo.<name>.cc (authored by hokein).
[format] foo.<name>.h should be the main-header for foo.<name>.cc
Tue, Oct 20, 4:34 AM
hokein closed D89783: [format] foo.<name>.h should be the main-header for foo.<name>.cc.
Tue, Oct 20, 4:34 AM · Restricted Project
hokein updated the diff for D89783: [format] foo.<name>.h should be the main-header for foo.<name>.cc.

address comment.

Tue, Oct 20, 4:26 AM · Restricted Project
hokein added a comment to D89743: Support Attr in DynTypedNode and ASTMatchers..

Looks like there are some failing tests in premerge bots, e.g. https://reviews.llvm.org/harbormaster/unit/view/185822/

Tue, Oct 20, 2:39 AM · Restricted Project
hokein requested review of D89783: [format] foo.<name>.h should be the main-header for foo.<name>.cc.
Tue, Oct 20, 2:35 AM · Restricted Project
hokein added a comment to D88640: [Format] Don't treat compound extension headers (foo.proto.h) as foo.cc main file..

It looks like this fix caused a different regression in not accepting name.<x>.h as the main header for name.<x>.cc, e.g.:

$ cat /tmp/foo.bar.cc
#include "a.h"
#include "z.h"
#include "foo.bar.h"

$ clang-format /tmp/foo.bar.cc  # Before
#include "foo.bar.h"

#include "a.h"
#include "z.h"

$ clang-format /tmp/foo.bar.cc  # After
#include "a.h"
#include "foo.bar.h"
#include "z.h"
Tue, Oct 20, 1:47 AM · Restricted Project

Mon, Oct 19

hokein committed rG1e32df2f91f1: [clang-rename] Fix rename on variable templates. (authored by hokein).
[clang-rename] Fix rename on variable templates.
Mon, Oct 19, 12:45 AM
hokein closed D89300: [clang-rename] Fix rename on variable templates..
Mon, Oct 19, 12:45 AM · Restricted Project
hokein committed rG45a15dc682c0: [clang-rename] Fix rename on function template specializations. (authored by hokein).
[clang-rename] Fix rename on function template specializations.
Mon, Oct 19, 12:32 AM
hokein closed D89221: [clang-rename] Fix rename on function template specializations..
Mon, Oct 19, 12:32 AM · Restricted Project

Wed, Oct 14

hokein added inline comments to D89220: [clang-rename] Simplify the code of handling class paritial specializations, NFC..
Wed, Oct 14, 6:16 AM · Restricted Project
hokein committed rGe6b4179c5d28: Fix a broken build for gcc <= 7.1 (authored by hokein).
Fix a broken build for gcc <= 7.1
Wed, Oct 14, 6:16 AM
hokein committed rG3fcca804b291: [clangd] Refine recoveryAST flags in clangd (authored by hokein).
[clangd] Refine recoveryAST flags in clangd
Wed, Oct 14, 4:42 AM
hokein closed D89233: [clangd] Refine recoveryAST flags in clangd.
Wed, Oct 14, 4:42 AM · Restricted Project
hokein updated the diff for D89233: [clangd] Refine recoveryAST flags in clangd.

address comments.

Wed, Oct 14, 4:40 AM · Restricted Project
hokein added inline comments to D89233: [clangd] Refine recoveryAST flags in clangd.
Wed, Oct 14, 4:40 AM · Restricted Project
hokein added inline comments to D89300: [clang-rename] Fix rename on variable templates..
Wed, Oct 14, 1:04 AM · Restricted Project
hokein added a comment to D89221: [clang-rename] Fix rename on function template specializations..

@kbobyrev you may miss this patch, this is a separate patch from D89300.

Wed, Oct 14, 1:02 AM · Restricted Project
hokein updated the diff for D89221: [clang-rename] Fix rename on function template specializations..

update

Wed, Oct 14, 1:01 AM · Restricted Project
hokein committed rG27c691cf62a9: [clang-rename] Simplify the code of handling class paritial specializations… (authored by hokein).
[clang-rename] Simplify the code of handling class paritial specializations…
Wed, Oct 14, 12:58 AM
hokein closed D89220: [clang-rename] Simplify the code of handling class paritial specializations, NFC..
Wed, Oct 14, 12:58 AM · Restricted Project

Tue, Oct 13

hokein requested review of D89300: [clang-rename] Fix rename on variable templates..
Tue, Oct 13, 1:05 AM · Restricted Project

Mon, Oct 12

hokein accepted D89238: [clangd] Go-to-definition from non-renaming alias is unambiguous..

Thanks!

Mon, Oct 12, 11:55 PM · Restricted Project
hokein committed rG16a4b0f0e36c: [clangd] Disable a failure TopLevelDecls test. (authored by hokein).
[clangd] Disable a failure TopLevelDecls test.
Mon, Oct 12, 7:09 AM
hokein committed rGb144cd867b6f: Dump decl when the test matcher fails. (authored by hokein).
Dump decl when the test matcher fails.
Mon, Oct 12, 6:42 AM
hokein accepted D88469: [clangd] Heuristic resolution for dependent type and template names.

thanks.

Mon, Oct 12, 6:35 AM · Restricted Project
hokein updated subscribers of D89098: [clang] Fix returning the underlying VarDecl as top-level decl for VarTemplateDecl..

Is this https://github.com/clangd/clangd/issues/554 ? :-)

Mon, Oct 12, 6:31 AM · Restricted Project
hokein added a comment to D89131: [clangd] Validate optional fields more strictly..

ah, I thought I clicked the accepted button.

Mon, Oct 12, 5:04 AM · Restricted Project
hokein requested review of D89233: [clangd] Refine recoveryAST flags in clangd.
Mon, Oct 12, 4:26 AM · Restricted Project
hokein committed rGf1bf41e433e1: Fix buildbot failure for 702529d899c87e9268bb33d836dbc91b6bce0b16. (authored by hokein).
Fix buildbot failure for 702529d899c87e9268bb33d836dbc91b6bce0b16.
Mon, Oct 12, 3:06 AM
hokein committed rG8852d30b1c1b: [AST][RecoveryExpr] Don't perform early typo correction in C. (authored by hokein).
[AST][RecoveryExpr] Don't perform early typo correction in C.
Mon, Oct 12, 2:28 AM
hokein closed D89045: [AST][RecoveryExpr] Don't perform early typo correction in C..
Mon, Oct 12, 2:28 AM · Restricted Project
hokein committed rGbb406f36dca3: [AST][RecoveryExpr] Build dependent callexpr in C for error-recovery. (authored by hokein).
[AST][RecoveryExpr] Build dependent callexpr in C for error-recovery.
Mon, Oct 12, 2:18 AM
hokein closed D84304: [AST][RecoveryExpr] Part 2: Build dependent callexpr in C for error-recovery..
Mon, Oct 12, 2:18 AM · Restricted Project
hokein committed rG702529d899c8: [clang] Fix returning the underlying VarDecl as top-level decl for… (authored by hokein).
[clang] Fix returning the underlying VarDecl as top-level decl for…
Mon, Oct 12, 2:06 AM
hokein closed D89098: [clang] Fix returning the underlying VarDecl as top-level decl for VarTemplateDecl..
Mon, Oct 12, 2:06 AM · Restricted Project
hokein added inline comments to D89131: [clangd] Validate optional fields more strictly..
Mon, Oct 12, 2:05 AM · Restricted Project
hokein accepted D89128: [JSON] Add ObjectMapper::mapOptional to validate optional data..
Mon, Oct 12, 1:56 AM · Restricted Project
hokein updated the diff for D89098: [clang] Fix returning the underlying VarDecl as top-level decl for VarTemplateDecl..

address review comments.

Mon, Oct 12, 1:45 AM · Restricted Project
hokein requested review of D89221: [clang-rename] Fix rename on function template specializations..
Mon, Oct 12, 12:48 AM · Restricted Project
hokein requested review of D89220: [clang-rename] Simplify the code of handling class paritial specializations, NFC..
Mon, Oct 12, 12:43 AM · Restricted Project

Fri, Oct 9

hokein accepted D89117: Remove old create(MainFile)?IncludeInsertion overloads.
Fri, Oct 9, 5:16 AM · Restricted Project
hokein requested review of D89098: [clang] Fix returning the underlying VarDecl as top-level decl for VarTemplateDecl..
Fri, Oct 9, 12:27 AM · Restricted Project

Thu, Oct 8

hokein committed rGefd8c9ed726d: [clangd] Add more incomplete_type diagnostics that could be fixed by include… (authored by hokein).
[clangd] Add more incomplete_type diagnostics that could be fixed by include…
Thu, Oct 8, 11:52 PM
hokein closed D89036: [clangd] Add more incomplete_type diagnostics that could be fixed by include-fixer..
Thu, Oct 8, 11:51 PM · Restricted Project
hokein added a reviewer for D89046: [AST] Build recovery expression by default for all language.: sammccall.
Thu, Oct 8, 7:38 AM · Restricted Project
hokein updated the diff for D89046: [AST] Build recovery expression by default for all language..

fix unexpected format changes.

Thu, Oct 8, 7:23 AM · Restricted Project
hokein requested review of D89046: [AST] Build recovery expression by default for all language..
Thu, Oct 8, 7:09 AM · Restricted Project
hokein requested review of D89045: [AST][RecoveryExpr] Don't perform early typo correction in C..
Thu, Oct 8, 7:07 AM · Restricted Project
hokein added a comment to D89036: [clangd] Add more incomplete_type diagnostics that could be fixed by include-fixer..
Thu, Oct 8, 7:05 AM · Restricted Project
hokein updated the diff for D89036: [clangd] Add more incomplete_type diagnostics that could be fixed by include-fixer..

Fix the test.

Thu, Oct 8, 7:05 AM · Restricted Project
hokein requested review of D89036: [clangd] Add more incomplete_type diagnostics that could be fixed by include-fixer..
Thu, Oct 8, 4:57 AM · Restricted Project
hokein committed rGa4e27220c2a1: [clangd] Add a missing include-fixer test for incomplete_type, NFC. (authored by hokein).
[clangd] Add a missing include-fixer test for incomplete_type, NFC.
Thu, Oct 8, 4:35 AM
hokein closed D88964: [clangd] Add a missing include-fixer test for incomplete_type, NFC..
Thu, Oct 8, 4:35 AM · Restricted Project
hokein added inline comments to D88964: [clangd] Add a missing include-fixer test for incomplete_type, NFC..
Thu, Oct 8, 4:28 AM · Restricted Project
hokein updated the diff for D84304: [AST][RecoveryExpr] Part 2: Build dependent callexpr in C for error-recovery..

rebase

Thu, Oct 8, 1:12 AM · Restricted Project
hokein committed rGa96bcfb19674: [AST][RecoveryExpr] Support dependent cast-expr in C for error-recovery. (authored by hokein).
[AST][RecoveryExpr] Support dependent cast-expr in C for error-recovery.
Thu, Oct 8, 1:04 AM
hokein closed D84387: [AST][RecoveryExpr] Part4: Support dependent cast-expr in C for error-recovery..
Thu, Oct 8, 1:03 AM · Restricted Project
hokein retitled D84387: [AST][RecoveryExpr] Part4: Support dependent cast-expr in C for error-recovery. from [AST][RecoveryExpr] Part4: Suppress spurious "err_typecheck_expect_scalar_operand" diagnostic to [AST][RecoveryExpr] Part4: Support dependent cast-expr in C for error-recovery..
Thu, Oct 8, 12:44 AM · Restricted Project
hokein added inline comments to D88881: [clangd] Add a NewName optional parameter to clangdServer::prepareRename..
Thu, Oct 8, 12:36 AM · Restricted Project
hokein committed rGba268d2fb09c: [clangd] Fix a typo, NFC. (authored by hokein).
[clangd] Fix a typo, NFC.
Thu, Oct 8, 12:36 AM

Wed, Oct 7

hokein committed rG9c09e2055ee4: [clangd] Add a NewName optional parameter to clangdServer::prepareRename. (authored by hokein).
[clangd] Add a NewName optional parameter to clangdServer::prepareRename.
Wed, Oct 7, 12:19 PM
hokein closed D88881: [clangd] Add a NewName optional parameter to clangdServer::prepareRename..
Wed, Oct 7, 12:19 PM · Restricted Project
hokein updated the diff for D88964: [clangd] Add a missing include-fixer test for incomplete_type, NFC..

update: don't change the order in test.

Wed, Oct 7, 12:10 PM · Restricted Project
hokein added inline comments to D88964: [clangd] Add a missing include-fixer test for incomplete_type, NFC..
Wed, Oct 7, 11:05 AM · Restricted Project
hokein requested review of D88964: [clangd] Add a missing include-fixer test for incomplete_type, NFC..
Wed, Oct 7, 6:30 AM · Restricted Project
hokein added inline comments to D84304: [AST][RecoveryExpr] Part 2: Build dependent callexpr in C for error-recovery..
Wed, Oct 7, 3:22 AM · Restricted Project
hokein updated the diff for D84304: [AST][RecoveryExpr] Part 2: Build dependent callexpr in C for error-recovery..

fix format.

Wed, Oct 7, 3:21 AM · Restricted Project
hokein updated the diff for D84304: [AST][RecoveryExpr] Part 2: Build dependent callexpr in C for error-recovery..

address comments.

Wed, Oct 7, 3:20 AM · Restricted Project
hokein updated the summary of D88881: [clangd] Add a NewName optional parameter to clangdServer::prepareRename..
Wed, Oct 7, 2:05 AM · Restricted Project
hokein updated the summary of D88881: [clangd] Add a NewName optional parameter to clangdServer::prepareRename..
Wed, Oct 7, 2:05 AM · Restricted Project
hokein added a comment to D88881: [clangd] Add a NewName optional parameter to clangdServer::prepareRename..

Can you add a bit more context to the commit message?

And should we expose this as an extension on textDocument/prepareRename?

Wed, Oct 7, 2:04 AM · Restricted Project
hokein updated the diff for D88881: [clangd] Add a NewName optional parameter to clangdServer::prepareRename..

make NewName optional.

Wed, Oct 7, 2:03 AM · Restricted Project
hokein committed rGf24649b77d85: [clangd] Don't set the Underlying bit on targets of UsingDecls. (authored by hokein).
[clangd] Don't set the Underlying bit on targets of UsingDecls.
Wed, Oct 7, 1:04 AM
hokein closed D88472: [clangd] Don't set the Underlying bit on targets of UsingDecls..
Wed, Oct 7, 1:04 AM · Restricted Project
hokein added inline comments to D88472: [clangd] Don't set the Underlying bit on targets of UsingDecls..
Wed, Oct 7, 1:00 AM · Restricted Project
hokein updated the diff for D88472: [clangd] Don't set the Underlying bit on targets of UsingDecls..

address comments.

Wed, Oct 7, 12:59 AM · Restricted Project
hokein committed rG31dc90801746: [clang] Use isCompoundAssignmentOp to simplify the code, NFC. (authored by hokein).
[clang] Use isCompoundAssignmentOp to simplify the code, NFC.
Wed, Oct 7, 12:52 AM
hokein added a comment to D84387: [AST][RecoveryExpr] Part4: Support dependent cast-expr in C for error-recovery..

I'm not sure I love having the assertion for contains-errors every place that handles dependent code in C.

Wed, Oct 7, 12:42 AM · Restricted Project
hokein updated the diff for D84387: [AST][RecoveryExpr] Part4: Support dependent cast-expr in C for error-recovery..

rebase

Wed, Oct 7, 12:39 AM · Restricted Project
hokein committed rG334ec6f807fa: [AST][RecoveryExpr] Support dependent conditional operators in C for error… (authored by hokein).
[AST][RecoveryExpr] Support dependent conditional operators in C for error…
Wed, Oct 7, 12:34 AM
hokein closed D84322: [AST][RecoveryExpr] Part3: Support dependent conditional operators in C for error recovery..
Wed, Oct 7, 12:34 AM · Restricted Project
hokein added inline comments to D84322: [AST][RecoveryExpr] Part3: Support dependent conditional operators in C for error recovery..
Wed, Oct 7, 12:26 AM · Restricted Project
hokein updated the diff for D84322: [AST][RecoveryExpr] Part3: Support dependent conditional operators in C for error recovery..

address comments

Wed, Oct 7, 12:26 AM · Restricted Project
hokein retitled D84322: [AST][RecoveryExpr] Part3: Support dependent conditional operators in C for error recovery. from [AST][RecoveryExpr] Part3: Suppress spurious "typecheck_cond_expect_scalar" diagnostic to [AST][RecoveryExpr] Part3: Support dependent conditional operators in C for error recovery..
Wed, Oct 7, 12:25 AM · Restricted Project

Tue, Oct 6

hokein committed rG8a3cbb1535a9: [clangd] Add basic keyword-name-validation in rename. (authored by hokein).
[clangd] Add basic keyword-name-validation in rename.
Tue, Oct 6, 6:48 AM
hokein closed D88875: [clangd] Add basic keyword-name-validation in rename..
Tue, Oct 6, 6:48 AM · Restricted Project
hokein added inline comments to D88875: [clangd] Add basic keyword-name-validation in rename..
Tue, Oct 6, 6:42 AM · Restricted Project
hokein added inline comments to D88875: [clangd] Add basic keyword-name-validation in rename..
Tue, Oct 6, 6:30 AM · Restricted Project
hokein updated the diff for D88875: [clangd] Add basic keyword-name-validation in rename..

address comments.

Tue, Oct 6, 6:23 AM · Restricted Project