Page MenuHomePhabricator

hokein (Haojian Wu)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 19 2015, 3:38 AM (200 w, 6 d)

Recent Activity

Today

hokein added a comment to D63559: [clangd] Added functionality for getting semantic highlights for variable and function declarations.

the test looks better now, another round of reviews, most are nits.

Tue, Jun 25, 7:54 AM · Restricted Project
hokein added inline comments to D63759: [clangd] Don't rename the namespace..
Tue, Jun 25, 7:04 AM · Restricted Project
hokein updated the diff for D63759: [clangd] Don't rename the namespace..

Verify the error message in the test.

Tue, Jun 25, 7:03 AM · Restricted Project
hokein added inline comments to D63759: [clangd] Don't rename the namespace..
Tue, Jun 25, 4:31 AM · Restricted Project
hokein updated the diff for D63759: [clangd] Don't rename the namespace..

Address review comments.

Tue, Jun 25, 4:31 AM · Restricted Project
hokein created D63759: [clangd] Don't rename the namespace..
Tue, Jun 25, 3:43 AM · Restricted Project
hokein committed rG7276a446cec8: [clangd] Narrow rename to local symbols. (authored by hokein).
[clangd] Narrow rename to local symbols.
Tue, Jun 25, 1:53 AM
hokein committed rL364283: [clangd] Narrow rename to local symbols..
[clangd] Narrow rename to local symbols.
Tue, Jun 25, 1:52 AM
hokein closed D63426: [clangd] Narrow rename to local symbols..
Tue, Jun 25, 1:52 AM · Restricted Project, Restricted Project
hokein added inline comments to D63559: [clangd] Added functionality for getting semantic highlights for variable and function declarations.
Tue, Jun 25, 1:36 AM · Restricted Project
hokein committed rL364280: [clangd] Cleanup the duplicated getTokenRange..
[clangd] Cleanup the duplicated getTokenRange.
Tue, Jun 25, 1:09 AM
hokein committed rG92c325747714: [clangd] Cleanup the duplicated getTokenRange. (authored by hokein).
[clangd] Cleanup the duplicated getTokenRange.
Tue, Jun 25, 1:08 AM
hokein closed D63714: [clangd] Cleanup the duplicated getTokenRange..
Tue, Jun 25, 1:06 AM · Restricted Project, Restricted Project
hokein updated the diff for D63714: [clangd] Cleanup the duplicated getTokenRange..

Address review comments.

Tue, Jun 25, 1:00 AM · Restricted Project, Restricted Project

Yesterday

hokein added inline comments to D63559: [clangd] Added functionality for getting semantic highlights for variable and function declarations.
Mon, Jun 24, 7:32 AM · Restricted Project
hokein created D63714: [clangd] Cleanup the duplicated getTokenRange..
Mon, Jun 24, 7:05 AM · Restricted Project, Restricted Project
hokein updated the diff for D63426: [clangd] Narrow rename to local symbols..

More cleanups.

Mon, Jun 24, 4:08 AM · Restricted Project, Restricted Project
hokein updated the diff for D63426: [clangd] Narrow rename to local symbols..

Address review comments.

Mon, Jun 24, 4:08 AM · Restricted Project, Restricted Project

Fri, Jun 21

hokein committed rG34f5188d0f27: [clangd] Add include-mapping for C symbols. (authored by hokein).
[clangd] Add include-mapping for C symbols.
Fri, Jun 21, 6:32 AM
hokein committed rL364044: [clangd] Add include-mapping for C symbols..
[clangd] Add include-mapping for C symbols.
Fri, Jun 21, 6:32 AM
hokein closed D63270: [clangd] Add include-mapping for C symbols..
Fri, Jun 21, 6:31 AM · Restricted Project, Restricted Project
hokein updated the diff for D63426: [clangd] Narrow rename to local symbols..

Improve the tests.

Fri, Jun 21, 4:02 AM · Restricted Project, Restricted Project
hokein added a comment to D63559: [clangd] Added functionality for getting semantic highlights for variable and function declarations.

Thanks, I think we can simplify the interface further, see my comments inline.

Fri, Jun 21, 1:54 AM · Restricted Project
hokein committed rG38a2f5007023: [clang-tidy] Fix a typo in the doc. (authored by hokein).
[clang-tidy] Fix a typo in the doc.
Fri, Jun 21, 12:56 AM
hokein committed rL364010: [clang-tidy] Fix a typo in the doc..
[clang-tidy] Fix a typo in the doc.
Fri, Jun 21, 12:56 AM

Wed, Jun 19

hokein committed rG982a1cf028d4: [clangd] Correct the MessageType enum values. (authored by hokein).
[clangd] Correct the MessageType enum values.
Wed, Jun 19, 6:13 AM
hokein committed rL363798: [clangd] Correct the MessageType enum values..
[clangd] Correct the MessageType enum values.
Wed, Jun 19, 6:11 AM
hokein added a comment to D63426: [clangd] Narrow rename to local symbols..

Use the hybrid approach based on our discussion, the implementation should be fine to review, I'm still working on adding more tests.

Wed, Jun 19, 4:03 AM · Restricted Project, Restricted Project
hokein updated the diff for D63426: [clangd] Narrow rename to local symbols..

Remove the unrelated changes.

Wed, Jun 19, 4:03 AM · Restricted Project, Restricted Project
hokein updated the diff for D63426: [clangd] Narrow rename to local symbols..

Switch to a hybrid solution (language semantic + index) to detect "symbol local".

Wed, Jun 19, 3:59 AM · Restricted Project, Restricted Project

Tue, Jun 18

hokein added inline comments to D63426: [clangd] Narrow rename to local symbols..
Tue, Jun 18, 8:00 AM · Restricted Project, Restricted Project
hokein updated the diff for D63426: [clangd] Narrow rename to local symbols..

Address review comments

Tue, Jun 18, 8:00 AM · Restricted Project, Restricted Project
hokein committed rG9483bcf78151: [clangd] Remove the extra ";", NFC (authored by hokein).
[clangd] Remove the extra ";", NFC
Tue, Jun 18, 6:49 AM
hokein committed rL363681: [clangd] Remove the extra ";", NFC.
[clangd] Remove the extra ";", NFC
Tue, Jun 18, 6:48 AM
hokein committed rG8ddf31bc33e6: [clangd] Parse files without extensions if we don't have a compile command. (authored by hokein).
[clangd] Parse files without extensions if we don't have a compile command.
Tue, Jun 18, 4:54 AM
hokein added a comment to D63331: [clangd] WIP/RFC: Prototype for semantic highlighting proposal.
In D63331#1548020, @nik wrote:

Yeah, we definitely have interest in this feature, and our intern @jvikstrom will work on this feature this summer.

"this summer" depends on the location, so can you concretize this? :)

Tue, Jun 18, 4:54 AM · Restricted Project
hokein committed rL363663: [clangd] Parse files without extensions if we don't have a compile command..
[clangd] Parse files without extensions if we don't have a compile command.
Tue, Jun 18, 4:51 AM
hokein closed D63481: [clangd] Parse files without extensions if we don't have a compile command..
Tue, Jun 18, 4:51 AM · Restricted Project, Restricted Project
hokein committed rG40fdd7a643b5: [clangd] Detect C++ language based on well-known file path in vscode extension (authored by hokein).
[clangd] Detect C++ language based on well-known file path in vscode extension
Tue, Jun 18, 4:50 AM
hokein committed rL363662: [clangd] Detect C++ language based on well-known file path in vscode extension.
[clangd] Detect C++ language based on well-known file path in vscode extension
Tue, Jun 18, 4:50 AM
hokein closed D63483: [clangd] Detect C++ language based on well-known file path in vscode extension.
Tue, Jun 18, 4:50 AM · Restricted Project, Restricted Project
hokein created D63483: [clangd] Detect C++ language based on well-known file path in vscode extension.
Tue, Jun 18, 4:30 AM · Restricted Project, Restricted Project
hokein created D63481: [clangd] Parse files without extensions if we don't have a compile command..
Tue, Jun 18, 2:59 AM · Restricted Project, Restricted Project

Mon, Jun 17

hokein committed rGb5ce4e5ea3e1: [clangd] Perform merge for main file symbols. (authored by hokein).
[clangd] Perform merge for main file symbols.
Mon, Jun 17, 7:47 AM
hokein committed rL363568: [clangd] Perform merge for main file symbols..
[clangd] Perform merge for main file symbols.
Mon, Jun 17, 7:46 AM
hokein closed D63425: [clangd] Perform merge for main file symbols..
Mon, Jun 17, 7:46 AM · Restricted Project, Restricted Project
hokein added a comment to D63425: [clangd] Perform merge for main file symbols..

We also make use of PickOne in updatePreamble shouldn't that also cause similar troubles?

Mon, Jun 17, 6:39 AM · Restricted Project, Restricted Project
hokein committed rG7dc917603be4: [clangd] Bump vscode-clangd v0.0.15. (authored by hokein).
[clangd] Bump vscode-clangd v0.0.15.
Mon, Jun 17, 6:16 AM
hokein committed rL363555: [clangd] Bump vscode-clangd v0.0.15..
[clangd] Bump vscode-clangd v0.0.15.
Mon, Jun 17, 6:15 AM
hokein created D63426: [clangd] Narrow rename to local symbols..
Mon, Jun 17, 6:04 AM · Restricted Project, Restricted Project
hokein committed rGd53027697ca2: [clangd] Detect C++ for extension-less source files in vscode extension (authored by hokein).
[clangd] Detect C++ for extension-less source files in vscode extension
Mon, Jun 17, 6:01 AM
hokein committed rL363554: [clangd] Detect C++ for extension-less source files in vscode extension.
[clangd] Detect C++ for extension-less source files in vscode extension
Mon, Jun 17, 5:56 AM
hokein closed D63397: [clangd] Detect C++ for extension-less source files in vscode extension.
Mon, Jun 17, 5:56 AM · Restricted Project, Restricted Project
hokein created D63425: [clangd] Perform merge for main file symbols..
Mon, Jun 17, 5:52 AM · Restricted Project, Restricted Project
hokein updated the summary of D63397: [clangd] Detect C++ for extension-less source files in vscode extension.
Mon, Jun 17, 1:22 AM · Restricted Project, Restricted Project
hokein updated the diff for D63397: [clangd] Detect C++ for extension-less source files in vscode extension.

Address comments.

Mon, Jun 17, 1:22 AM · Restricted Project, Restricted Project
hokein created D63397: [clangd] Detect C++ for extension-less source files in vscode extension.
Mon, Jun 17, 12:58 AM · Restricted Project, Restricted Project

Sat, Jun 15

sanaanajjar231288 awarded rL363375: [clangd] Bump vscode-clangd v0.0.14 a Burninate token.
Sat, Jun 15, 12:58 PM

Fri, Jun 14

hokein updated subscribers of D63331: [clangd] WIP/RFC: Prototype for semantic highlighting proposal.

Yeah, we definitely have interest in this feature, and our intern @jvikstrom will work on this feature this summer.

Fri, Jun 14, 5:56 AM · Restricted Project
hokein committed rGf907849e2e46: [clangd] Bump vscode-clangd v0.0.14 (authored by hokein).
[clangd] Bump vscode-clangd v0.0.14
Fri, Jun 14, 5:08 AM
hokein committed rL363375: [clangd] Bump vscode-clangd v0.0.14.
[clangd] Bump vscode-clangd v0.0.14
Fri, Jun 14, 5:08 AM
hokein committed rG30557ace0f6e: [clangd] Don't maintain a list of c-family extensions in vscode extension. (authored by hokein).
[clangd] Don't maintain a list of c-family extensions in vscode extension.
Fri, Jun 14, 4:54 AM
hokein committed rL363372: [clangd] Don't maintain a list of c-family extensions in vscode extension..
[clangd] Don't maintain a list of c-family extensions in vscode extension.
Fri, Jun 14, 4:54 AM
hokein closed D63323: [clangd] Don't maintain a list of c-family extensions in vscode extension..
Fri, Jun 14, 4:54 AM · Restricted Project, Restricted Project
hokein added a comment to D63323: [clangd] Don't maintain a list of c-family extensions in vscode extension..

could you also bump the version numbers?

Fri, Jun 14, 4:54 AM · Restricted Project, Restricted Project
hokein added inline comments to D63270: [clangd] Add include-mapping for C symbols..
Fri, Jun 14, 3:12 AM · Restricted Project, Restricted Project
hokein updated the diff for D63270: [clangd] Add include-mapping for C symbols..

Address review comments.

Fri, Jun 14, 3:12 AM · Restricted Project, Restricted Project
hokein created D63323: [clangd] Don't maintain a list of c-family extensions in vscode extension..
Fri, Jun 14, 2:16 AM · Restricted Project, Restricted Project

Thu, Jun 13

hokein created D63270: [clangd] Add include-mapping for C symbols..
Thu, Jun 13, 7:43 AM · Restricted Project, Restricted Project
hokein accepted D63253: [clang-tidy] Made abseil-faster-strsplit-delimiter tests pass on C++17.

looks good.

Thu, Jun 13, 5:18 AM · Restricted Project, Restricted Project
hokein accepted D63149: Added AST matcher for ignoring elidable constructors.

thanks, looks good to me. I'll commit for you. @gribozavr do you want to take another look on the patch?

Thu, Jun 13, 2:20 AM · Restricted Project, Restricted Project
hokein added a comment to D63149: Added AST matcher for ignoring elidable constructors.

looks most good to me, a few nits.

Thu, Jun 13, 1:18 AM · Restricted Project, Restricted Project

Wed, Jun 12

hokein accepted D63140: [clangd] Return TextEdits from ClangdServer::applyTweak.

looks good.

Wed, Jun 12, 4:49 AM · Restricted Project, Restricted Project
hokein added inline comments to D63149: Added AST matcher for ignoring elidable constructors.
Wed, Jun 12, 2:34 AM · Restricted Project, Restricted Project

Tue, Jun 11

hokein added a comment to D63127: [clang-tidy] Fixed checker for abseil to work in C++17 mode.

Thanks for investigating these, nice work!

Tue, Jun 11, 4:42 AM · Restricted Project
hokein created D63126: [clangd] Implement "prepareRename".
Tue, Jun 11, 2:33 AM · Restricted Project
hokein committed rGb011ee8ae862: [clangd] Add missing header guard. (authored by hokein).
[clangd] Add missing header guard.
Tue, Jun 11, 1:49 AM
hokein committed rL363037: [clangd] Add missing header guard..
[clangd] Add missing header guard.
Tue, Jun 11, 1:49 AM

Fri, Jun 7

hokein added inline comments to D62808: [clangd] Print the ignored variant symbols.
Fri, Jun 7, 3:10 AM · Restricted Project
hokein abandoned D62958: [clang-tidy] Fix descriptions for modernize-make-unique/shared checks..

As discussed offline, we don't need a separate fix description for this check, as the check warning message clearly implies what the fix will do.

Fri, Jun 7, 2:10 AM · Restricted Project

Thu, Jun 6

hokein created D62958: [clang-tidy] Fix descriptions for modernize-make-unique/shared checks..
Thu, Jun 6, 8:08 AM · Restricted Project
hokein abandoned D60776: [clang-tidy] Add test support for the fix description..
Thu, Jun 6, 8:08 AM · Restricted Project
hokein committed rGa4f5a2ad1f03: [clang-tidy] Another attempt to fix misc-redundant-expression check. (authored by hokein).
[clang-tidy] Another attempt to fix misc-redundant-expression check.
Thu, Jun 6, 6:44 AM
hokein committed rL362706: [clang-tidy] Another attempt to fix misc-redundant-expression check..
[clang-tidy] Another attempt to fix misc-redundant-expression check.
Thu, Jun 6, 6:44 AM
hokein committed rGdf95e6109e1c: [clang-tidy] Fix an assertion failure in misc-redundant-expression. (authored by hokein).
[clang-tidy] Fix an assertion failure in misc-redundant-expression.
Thu, Jun 6, 5:58 AM
hokein committed rL362701: [clang-tidy] Fix an assertion failure in misc-redundant-expression..
[clang-tidy] Fix an assertion failure in misc-redundant-expression.
Thu, Jun 6, 5:55 AM
hokein closed D62947: [clang-tidy] Fix an assertion failure in misc-redundant-expression..
Thu, Jun 6, 5:55 AM · Restricted Project, Restricted Project
hokein added a comment to D62437: [clang-tidy] Splits fuchsia-default-arguments.

@juliehockett could you take a look on this patch? I think you have the best knowledge about this check and fuchsia stuff.

Thu, Jun 6, 5:53 AM · Restricted Project, Restricted Project, Restricted Project
hokein created D62947: [clang-tidy] Fix an assertion failure in misc-redundant-expression..
Thu, Jun 6, 4:27 AM · Restricted Project, Restricted Project
hokein committed rG448acbc06feb: [clang-tidy] Fix make-unique tests on C++2a. (authored by hokein).
[clang-tidy] Fix make-unique tests on C++2a.
Thu, Jun 6, 12:46 AM
hokein committed rL362679: [clang-tidy] Fix make-unique tests on C++2a..
[clang-tidy] Fix make-unique tests on C++2a.
Thu, Jun 6, 12:46 AM
hokein closed D62845: [clang-tidy] Fix make-unique tests on C++2a..
Thu, Jun 6, 12:45 AM · Restricted Project, Restricted Project

Tue, Jun 4

hokein added a comment to D62845: [clang-tidy] Fix make-unique tests on C++2a..

I think we should be looking at the intent of the test rather than its name.

The intent looks like testing how the check works when std::make_unique is available from the standard library (as opposed to some kind of replacement like absl::make_unique). See the patch that introduced it: https://reviews.llvm.org/D43766

So modernize-make-unique-cxx14 is actually "C++14 or later". (Probably it should be renamed.)

yeap, it seems to me that "modernize-make-unique-cxx14" is redundant, "modernize-make-unique" should cover what it tests, I believe. We also have "modernize-make-unique-cxx11" which runs on C++11 mode only, maybe we just repurpose the modernize-make-unique-cxx14, what do you think?

Fair enough.

I see. Assuming it is desired behavior, I'd say for these cases we should create separate files that are specifically run in C++14 and 17, and another one for C++2a onward.

But is it desired behavior? That is, can we generate a call to std::make_unique in C++14 in practice -- would it compile?

The fix is compilable for C++14, but it is tricky to support it:

  1. new NoCopyMoveCtor{}: the make_unique fix is compilable
  2. new NoCopyMoveCtor{1, 2}: the make_unique fix is not compilable

    The AST for case 1) and 2) are the same in C++14, supporting that would introduce hacky change to the logic here. I'd leave it as-is now.

Indeed, this is complicated. Could you add tests for new NoCopyMoveCtor{1, 2} with TODOs (the message suggests the user to do the impossible).

Tue, Jun 4, 7:51 AM · Restricted Project, Restricted Project
hokein updated the diff for D62845: [clang-tidy] Fix make-unique tests on C++2a..

address review comments.

Tue, Jun 4, 7:51 AM · Restricted Project, Restricted Project
hokein added a comment to D62845: [clang-tidy] Fix make-unique tests on C++2a..

I think we should be looking at the intent of the test rather than its name.

The intent looks like testing how the check works when std::make_unique is available from the standard library (as opposed to some kind of replacement like absl::make_unique). See the patch that introduced it: https://reviews.llvm.org/D43766

So modernize-make-unique-cxx14 is actually "C++14 or later". (Probably it should be renamed.)

Tue, Jun 4, 6:29 AM · Restricted Project, Restricted Project
hokein updated the diff for D62845: [clang-tidy] Fix make-unique tests on C++2a..

Tests for C++2a.

Tue, Jun 4, 6:27 AM · Restricted Project, Restricted Project
hokein added a comment to D62845: [clang-tidy] Fix make-unique tests on C++2a..

I'd suggest to add a separate file that covers the exact language modes needed.

The C++14 test that we have right now is about C++14-or-later, testing the availability of std::make_unique.

Tue, Jun 4, 2:46 AM · Restricted Project, Restricted Project
hokein accepted D62476: [clangd] Support offsets for parameters in signatureHelp.

nice, looks good

Tue, Jun 4, 1:58 AM · Restricted Project, Restricted Project
hokein created D62845: [clang-tidy] Fix make-unique tests on C++2a..
Tue, Jun 4, 1:44 AM · Restricted Project, Restricted Project

Mon, Jun 3

hokein created D62808: [clangd] Print the ignored variant symbols.
Mon, Jun 3, 5:29 AM · Restricted Project