Page MenuHomePhabricator

hokein (Haojian Wu)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 19 2015, 3:38 AM (209 w, 3 d)

Recent Activity

Yesterday

hokein added a comment to D66219: [clangd] Added a colorizer to the vscode extension..

thanks, looks better now. Some more comments on the test code.

Fri, Aug 23, 5:49 AM · Restricted Project
hokein committed rGbc01f48da37e: [clangd] Link more clang-tidy modules to clangd (authored by hokein).
[clangd] Link more clang-tidy modules to clangd
Fri, Aug 23, 2:14 AM
hokein committed rL369741: [clangd] Link more clang-tidy modules to clangd.
[clangd] Link more clang-tidy modules to clangd
Fri, Aug 23, 2:14 AM
hokein closed D66632: [clangd] Link more clang-tidy modules to clangd.
Fri, Aug 23, 2:14 AM · Restricted Project, Restricted Project
hokein committed rGc4905a232c9b: [clang-tidy] Don't emit google-runtime-references warning for functions defined… (authored by hokein).
[clang-tidy] Don't emit google-runtime-references warning for functions defined…
Fri, Aug 23, 1:50 AM
hokein committed rL369739: [clang-tidy] Don't emit google-runtime-references warning for functions defined….
[clang-tidy] Don't emit google-runtime-references warning for functions defined…
Fri, Aug 23, 1:49 AM
hokein closed D66631: [clang-tidy] Don't emit google-runtime-references warning for functions defined in macros..
Fri, Aug 23, 1:49 AM · Restricted Project, Restricted Project
hokein updated the diff for D66631: [clang-tidy] Don't emit google-runtime-references warning for functions defined in macros..

Add the missing back newline.

Fri, Aug 23, 1:45 AM · Restricted Project, Restricted Project
hokein created D66632: [clangd] Link more clang-tidy modules to clangd.
Fri, Aug 23, 1:44 AM · Restricted Project, Restricted Project
hokein created D66631: [clang-tidy] Don't emit google-runtime-references warning for functions defined in macros..
Fri, Aug 23, 1:12 AM · Restricted Project, Restricted Project

Thu, Aug 22

hokein committed rG08d93f1ed3b6: [clangd] Send suppported codeActionKinds to the client. (authored by hokein).
[clangd] Send suppported codeActionKinds to the client.
Thu, Aug 22, 7:56 AM
hokein committed rL369656: [clangd] Send suppported codeActionKinds to the client..
[clangd] Send suppported codeActionKinds to the client.
Thu, Aug 22, 7:53 AM
hokein closed D66592: [clangd] Send suppported codeActionKinds to the client..
Thu, Aug 22, 7:53 AM · Restricted Project, Restricted Project
hokein updated the diff for D66592: [clangd] Send suppported codeActionKinds to the client..

Fix the comment.

Thu, Aug 22, 7:51 AM · Restricted Project, Restricted Project
hokein created D66592: [clangd] Send suppported codeActionKinds to the client..
Thu, Aug 22, 7:25 AM · Restricted Project, Restricted Project
hokein added inline comments to D66541: [clangd] Send highlighting diff beyond the end of the file..
Thu, Aug 22, 2:53 AM · Restricted Project
hokein committed rG35038c914c18: [clangd] The ClangdServer::EnableHiddenFeatures is not used any more. (authored by hokein).
[clangd] The ClangdServer::EnableHiddenFeatures is not used any more.
Thu, Aug 22, 2:02 AM
hokein committed rL369631: [clangd] The ClangdServer::EnableHiddenFeatures is not used any more..
[clangd] The ClangdServer::EnableHiddenFeatures is not used any more.
Thu, Aug 22, 2:02 AM
hokein committed rGfcedc6a61bd1: Remove an unused function, suppress -Wunused-function warning. (authored by hokein).
Remove an unused function, suppress -Wunused-function warning.
Thu, Aug 22, 1:53 AM
hokein committed rL369629: Remove an unused function, suppress -Wunused-function warning..
Remove an unused function, suppress -Wunused-function warning.
Thu, Aug 22, 1:53 AM

Wed, Aug 21

hokein created D66541: [clangd] Send highlighting diff beyond the end of the file..
Wed, Aug 21, 9:11 AM · Restricted Project
hokein created D66530: [clangd] Don't collect locations that implicitly refer to the target decl..
Wed, Aug 21, 6:46 AM · Restricted Project
hokein committed rG65c58a902d00: [clangd] Ignore implicit conversion-operator nodes in find refs. (authored by hokein).
[clangd] Ignore implicit conversion-operator nodes in find refs.
Wed, Aug 21, 3:55 AM
hokein committed rL369514: [clangd] Ignore implicit conversion-operator nodes in find refs..
[clangd] Ignore implicit conversion-operator nodes in find refs.
Wed, Aug 21, 3:54 AM
hokein closed D66478: [clangd] Ignore implicit conversion-operator nodes in find refs..
Wed, Aug 21, 3:54 AM · Restricted Project, Restricted Project
hokein added inline comments to D66219: [clangd] Added a colorizer to the vscode extension..
Wed, Aug 21, 3:46 AM · Restricted Project

Tue, Aug 20

hokein created D66478: [clangd] Ignore implicit conversion-operator nodes in find refs..
Tue, Aug 20, 7:57 AM · Restricted Project, Restricted Project
hokein committed rG0e8e4b09d2ff: [clangd] Fix one testcase in XRefsTests. (authored by hokein).
[clangd] Fix one testcase in XRefsTests.
Tue, Aug 20, 7:07 AM
hokein committed rL369387: [clangd] Fix one testcase in XRefsTests..
[clangd] Fix one testcase in XRefsTests.
Tue, Aug 20, 7:07 AM
hokein closed D66349: [clangd] Fix one testcase in XRefsTests..
Tue, Aug 20, 7:06 AM · Restricted Project, Restricted Project
hokein updated the diff for D66349: [clangd] Fix one testcase in XRefsTests..

Address review comments.

Tue, Aug 20, 6:43 AM · Restricted Project, Restricted Project
hokein added inline comments to D66349: [clangd] Fix one testcase in XRefsTests..
Tue, Aug 20, 3:36 AM · Restricted Project, Restricted Project
hokein added inline comments to D66349: [clangd] Fix one testcase in XRefsTests..
Tue, Aug 20, 1:24 AM · Restricted Project, Restricted Project

Mon, Aug 19

hokein added a comment to D66406: [clangd] Update themeRuleMatcher when color theme changes in vscode extension..

the change looks good, but I'd wait until D66219 is finished.

Mon, Aug 19, 3:08 AM · Restricted Project
hokein added inline comments to D66219: [clangd] Added a colorizer to the vscode extension..
Mon, Aug 19, 3:06 AM · Restricted Project
hokein added inline comments to D66349: [clangd] Fix one testcase in XRefsTests..
Mon, Aug 19, 1:48 AM · Restricted Project, Restricted Project
hokein added inline comments to D66349: [clangd] Fix one testcase in XRefsTests..
Mon, Aug 19, 1:29 AM · Restricted Project, Restricted Project

Fri, Aug 16

hokein created D66349: [clangd] Fix one testcase in XRefsTests..
Fri, Aug 16, 7:35 AM · Restricted Project, Restricted Project
hokein committed rG427762f03d7f: [clangd] suppress -Wparentheses warning: suggest parentheses around ‘&&’ within… (authored by hokein).
[clangd] suppress -Wparentheses warning: suggest parentheses around ‘&&’ within…
Fri, Aug 16, 6:24 AM
hokein committed rL369105: [clangd] suppress -Wparentheses warning: suggest parentheses around ‘&&’ within….
[clangd] suppress -Wparentheses warning: suggest parentheses around ‘&&’ within…
Fri, Aug 16, 6:19 AM
hokein accepted D66343: [clangd] Simplify code of ClangdLSPServer::onCommand.

thanks.

Fri, Aug 16, 5:39 AM · Restricted Project, Restricted Project

Wed, Aug 14

hokein committed rGbcd4d59a148a: [clangd][vscode] Surface the error when applying tweaks fails (authored by hokein).
[clangd][vscode] Surface the error when applying tweaks fails
Wed, Aug 14, 6:39 AM
hokein committed rL368851: [clangd][vscode] Surface the error when applying tweaks fails.
[clangd][vscode] Surface the error when applying tweaks fails
Wed, Aug 14, 6:37 AM
hokein closed D66211: [clangd][vscode] Surface the error when applying tweaks fails.
Wed, Aug 14, 6:37 AM · Restricted Project, Restricted Project
hokein added inline comments to D66211: [clangd][vscode] Surface the error when applying tweaks fails.
Wed, Aug 14, 6:34 AM · Restricted Project, Restricted Project
hokein updated the diff for D66211: [clangd][vscode] Surface the error when applying tweaks fails.

avoid re-implementing of the method.

Wed, Aug 14, 6:33 AM · Restricted Project, Restricted Project
hokein added a comment to D66211: [clangd][vscode] Surface the error when applying tweaks fails.

How do they look in practice? In particular, should we add more context information (either in clangd or in the VSCode extension) to those errors, now that we know they are shown to the users?
Something like Failed to apply a fix: input range is invalid vs input range is invalid.

Wed, Aug 14, 5:45 AM · Restricted Project, Restricted Project
hokein accepted D66215: [clangd] Print qualifiers of out-of-line definitions in document outline.
Wed, Aug 14, 5:30 AM · Restricted Project, Restricted Project
hokein accepted D65856: [clangd] Added class for mapping TokenColorRules to their associated clangd TextMate scope.

thanks, looks good.

Wed, Aug 14, 5:08 AM · Restricted Project, Restricted Project
hokein created D66211: [clangd][vscode] Surface the error when applying tweaks fails.
Wed, Aug 14, 4:17 AM · Restricted Project, Restricted Project
hokein accepted D66209: Improved the doc comment for getCommentsInFile.

thanks!

Wed, Aug 14, 3:55 AM · Restricted Project, Restricted Project
hokein added inline comments to D65856: [clangd] Added class for mapping TokenColorRules to their associated clangd TextMate scope.
Wed, Aug 14, 2:14 AM · Restricted Project, Restricted Project
hokein committed rGec25edc17a45: Fix the -Wunused-variable warning. (authored by hokein).
Fix the -Wunused-variable warning.
Wed, Aug 14, 1:22 AM
hokein committed rL368808: Fix the -Wunused-variable warning..
Fix the -Wunused-variable warning.
Wed, Aug 14, 1:22 AM

Tue, Aug 13

hokein added inline comments to D65856: [clangd] Added class for mapping TokenColorRules to their associated clangd TextMate scope.
Tue, Aug 13, 8:09 AM · Restricted Project, Restricted Project
hokein added inline comments to D65856: [clangd] Added class for mapping TokenColorRules to their associated clangd TextMate scope.
Tue, Aug 13, 6:47 AM · Restricted Project, Restricted Project
hokein added a comment to D66074: [clangd] Drop diags from non-written #include..

thanks for the information, I suspect that this patch may depend on rL367303 (which is not merged in the release), I will double check.

Yes, that seems to be it. I've merged that, and then I could merge this one in r368683.

Tue, Aug 13, 5:58 AM · Restricted Project, Restricted Project
hokein added a comment to D66074: [clangd] Drop diags from non-written #include..

@hans is there still any chance to merge this patch into the release?

I tried to merge this to release_90, but I got a test failure. Does this rely on more patches that need merging? Can you try applying it to the release branch in the monorepo and see what needs fixing?

$ ninja check-clangd
[7/8] Running the Clangd regression tests
llvm-lit: /work/llvm-9/llvm/utils/lit/lit/llvm/config.py:340: note: using clang: /work/llvm-9/build.release/bin/clang
FAIL: Clangd Unit Tests :: ./ClangdTests/IgnoreDiags.FromNonWrittenInclude (368 of 573)
******************** TEST 'Clangd Unit Tests :: ./ClangdTests/IgnoreDiags.FromNonWrittenInclude' FAILED ********************
Note: Google Test filter = IgnoreDiags.FromNonWrittenInclude
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from IgnoreDiags
[ RUN      ] IgnoreDiags.FromNonWrittenInclude
/work/llvm-9/llvm/tools/clang/tools/extra/clangd/unittests/DiagnosticsTests.cpp:945: Failure
Value of: TU.build().getDiagnostics()
Expected: is empty
  Actual: { [./a.h:0:0-0:4] 'main' must return 'int' }, which has 1 element
[  FAILED  ] IgnoreDiags.FromNonWrittenInclude (20 ms)
[----------] 1 test from IgnoreDiags (20 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (21 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] IgnoreDiags.FromNonWrittenInclude

 1 FAILED TEST
Preamble for file /clangd-test/TestTU.cpp cannot be reused. Attempting to rebuild it.
Built preamble of size 201076 for file /clangd-test/TestTU.cpp

********************
Testing Time: 3.92s
********************
Failing Tests (1):
    Clangd Unit Tests :: ./ClangdTests/IgnoreDiags.FromNonWrittenInclude

  Expected Passes    : 569
  Unsupported Tests  : 3
  Unexpected Failures: 1
FAILED: tools/clang/tools/extra/clangd/test/CMakeFiles/check-clangd
Tue, Aug 13, 4:51 AM · Restricted Project, Restricted Project
hokein added a comment to D65856: [clangd] Added class for mapping TokenColorRules to their associated clangd TextMate scope.

I think we could make the layering clearer:

Tue, Aug 13, 3:55 AM · Restricted Project, Restricted Project

Mon, Aug 12

hokein accepted D65998: [clangd] Added the vscode SemanticHighlighting feature code but did not enable it in the client..

mostly good with a few nits.

Mon, Aug 12, 6:20 AM · Restricted Project, Restricted Project
hokein accepted D66083: [clangd] Remove highlightings coming from non topLevelDecls from included files..
Mon, Aug 12, 5:30 AM · Restricted Project, Restricted Project
hokein added inline comments to D65998: [clangd] Added the vscode SemanticHighlighting feature code but did not enable it in the client..
Mon, Aug 12, 5:11 AM · Restricted Project, Restricted Project
hokein updated subscribers of D66074: [clangd] Drop diags from non-written #include..

@hans is there still any chance to merge this patch into the release?

Mon, Aug 12, 2:40 AM · Restricted Project, Restricted Project
hokein committed rGd614a65d85c1: [clangd] Drop diags from non-written #include. (authored by hokein).
[clangd] Drop diags from non-written #include.
Mon, Aug 12, 2:37 AM
hokein committed rL368549: [clangd] Drop diags from non-written #include..
[clangd] Drop diags from non-written #include.
Mon, Aug 12, 2:37 AM
hokein closed D66074: [clangd] Drop diags from non-written #include..
Mon, Aug 12, 2:37 AM · Restricted Project, Restricted Project
hokein updated the diff for D66074: [clangd] Drop diags from non-written #include..

Add a comment.

Mon, Aug 12, 2:31 AM · Restricted Project, Restricted Project
hokein created D66074: [clangd] Drop diags from non-written #include..
Mon, Aug 12, 1:46 AM · Restricted Project, Restricted Project

Fri, Aug 9

hokein accepted D65996: [clangd] Highlighting auto variables as the deduced type..
Fri, Aug 9, 7:11 AM · Restricted Project, Restricted Project
hokein added inline comments to D65996: [clangd] Highlighting auto variables as the deduced type..
Fri, Aug 9, 5:46 AM · Restricted Project, Restricted Project
hokein added inline comments to D65998: [clangd] Added the vscode SemanticHighlighting feature code but did not enable it in the client..
Fri, Aug 9, 4:54 AM · Restricted Project, Restricted Project
hokein accepted D66001: [clangd] Added highlighting for constructor initializers..
Fri, Aug 9, 4:29 AM · Restricted Project, Restricted Project
hokein committed rG8b49173a8232: [clangd] Use raw rename functions to implement the rename. (authored by hokein).
[clangd] Use raw rename functions to implement the rename.
Fri, Aug 9, 3:56 AM
hokein committed rL368429: [clangd] Use raw rename functions to implement the rename..
[clangd] Use raw rename functions to implement the rename.
Fri, Aug 9, 3:56 AM
hokein closed D65936: [clangd] Use raw rename functions to implement the rename..
Fri, Aug 9, 3:56 AM · Restricted Project, Restricted Project
hokein updated the diff for D65936: [clangd] Use raw rename functions to implement the rename..

Add a comment.

Fri, Aug 9, 3:56 AM · Restricted Project, Restricted Project

Thu, Aug 8

hokein accepted D65926: [clangd] Fixed printTemplateSpecializationArgs not printing partial variable specialization arguments..
Thu, Aug 8, 7:01 AM · Restricted Project, Restricted Project
hokein added inline comments to D65936: [clangd] Use raw rename functions to implement the rename..
Thu, Aug 8, 6:48 AM · Restricted Project, Restricted Project
hokein accepted D65943: [clangd] Added semantic highlighting support for primitives..

nice, just a nit.

Thu, Aug 8, 5:48 AM · Restricted Project, Restricted Project
hokein accepted D65938: [AST] No longer visiting CXXMethodDecl bodies created by compiler when method was default created..

looks good from my side.

Thu, Aug 8, 5:42 AM · Restricted Project, Restricted Project
hokein committed rGbdc022a695e0: [clangd] Don't include internal gtest header. (authored by hokein).
[clangd] Don't include internal gtest header.
Thu, Aug 8, 5:34 AM
hokein committed rL368283: [clangd] Don't include internal gtest header..
[clangd] Don't include internal gtest header.
Thu, Aug 8, 5:32 AM
hokein committed rG34166ec80bca: [clangd] Remove a function accidently being added in rL368261. (authored by hokein).
[clangd] Remove a function accidently being added in rL368261.
Thu, Aug 8, 5:22 AM
hokein committed rL368282: [clangd] Remove a function accidently being added in rL368261..
[clangd] Remove a function accidently being added in rL368261.
Thu, Aug 8, 5:22 AM
hokein added inline comments to D65926: [clangd] Fixed printTemplateSpecializationArgs not printing partial variable specialization arguments..
Thu, Aug 8, 5:22 AM · Restricted Project, Restricted Project
hokein added a comment to D65928: [clangd] Added an early return from VisitMemberExpr in SemanticHighlighting if the MemberLoc is invalid..

please update the patch description.

Thu, Aug 8, 5:06 AM · Restricted Project, Restricted Project
hokein accepted D65928: [clangd] Added an early return from VisitMemberExpr in SemanticHighlighting if the MemberLoc is invalid..
Thu, Aug 8, 5:06 AM · Restricted Project, Restricted Project
hokein added inline comments to D65936: [clangd] Use raw rename functions to implement the rename..
Thu, Aug 8, 4:44 AM · Restricted Project, Restricted Project
hokein updated the diff for D65936: [clangd] Use raw rename functions to implement the rename..

Address comments.

Thu, Aug 8, 4:41 AM · Restricted Project, Restricted Project
hokein added inline comments to D65928: [clangd] Added an early return from VisitMemberExpr in SemanticHighlighting if the MemberLoc is invalid..
Thu, Aug 8, 4:38 AM · Restricted Project, Restricted Project
hokein committed rG1c0c7ed6af81: [clangd] Correct the documentation, NFC. (authored by hokein).
[clangd] Correct the documentation, NFC.
Thu, Aug 8, 4:00 AM
hokein committed rL368277: [clangd] Correct the documentation, NFC..
[clangd] Correct the documentation, NFC.
Thu, Aug 8, 4:00 AM
hokein created D65936: [clangd] Use raw rename functions to implement the rename..
Thu, Aug 8, 3:53 AM · Restricted Project, Restricted Project
hokein added inline comments to D65928: [clangd] Added an early return from VisitMemberExpr in SemanticHighlighting if the MemberLoc is invalid..
Thu, Aug 8, 2:23 AM · Restricted Project, Restricted Project

Wed, Aug 7

hokein accepted D65738: [clangd] Added a TextMate theme parser to the vscode extension..

mostly good, please update the patch description.

Wed, Aug 7, 1:18 AM · Restricted Project, Restricted Project

Tue, Aug 6

hokein added a comment to D65738: [clangd] Added a TextMate theme parser to the vscode extension..

thanks, looks simpler now, just a few more nits.

Tue, Aug 6, 6:45 AM · Restricted Project, Restricted Project
hokein added inline comments to D65738: [clangd] Added a TextMate theme parser to the vscode extension..
Tue, Aug 6, 1:52 AM · Restricted Project, Restricted Project

Mon, Aug 5

hokein added a comment to D65738: [clangd] Added a TextMate theme parser to the vscode extension..

Haven't looked at the patch in details.

Mon, Aug 5, 8:08 AM · Restricted Project, Restricted Project
hokein committed rGf25163498b3d: [clangd] Add a callback mechanism for handling responses from client. (authored by hokein).
[clangd] Add a callback mechanism for handling responses from client.
Mon, Aug 5, 5:49 AM
hokein committed rL367845: [clangd] Add a callback mechanism for handling responses from client..
[clangd] Add a callback mechanism for handling responses from client.
Mon, Aug 5, 5:49 AM