User Details
- User Since
- Aug 19 2015, 3:38 AM (396 w, 3 d)
Fri, Mar 24
thanks, the implementation looks good. I left some comments around the test.
Thu, Mar 23
Thanks, and sorry for late response.
address comments
Thanks, this looks great! Please fix the code style of the unit-test (see my other comment) before landing it.
Mon, Mar 20
Thanks!
Thanks, this looks great, some more comments (most are nits)
Thanks!
Fri, Mar 17
Thu, Mar 16
Thanks, left some comments on the unittest, I think we can make it simpler.
Thanks for the review.
Wed, Mar 15
Tue, Mar 14
Mon, Mar 13
I didn't notice https://reviews.llvm.org/D145921, let's deprecate this one.
Good catch, thanks!
Fri, Mar 10
It appears that there is an issue with this patch, so please hold on for review.
Merge the change in https://reviews.llvm.org/D145773 per the review comment.
add the removal of the clangd-own implementation.
Add diagnostic for Experiment flag usage.
Thu, Mar 9
address comment: add more _N symbol up to _29.
Wed, Mar 8
Mon, Mar 6
Thu, Mar 2
Thanks, left a few comments on the implementation.
Tue, Feb 28
Mon, Feb 27
Fri, Feb 24
oops, fix the patch
Feb 24 2023
Thanks, this looks an improvement to me!
Thanks!