- User Since
- Aug 19 2015, 3:38 AM (183 w, 9 h)
Mon, Feb 18
I think we need to update the comment in the SymbolLocation::Column.
I wonder how does merge work with Sema results? See the case below, IIUC our indexer has one symbol for this using decl, but the code completion result from Sema contains two symbols. The symbol ids of these 3 symbols are different, so we will end up with 3 completion results.
Fri, Feb 15
The code looks good. For this protocol extension, we need supports from other LSP clients, I think we may want to propose this extension to the LSP specification, so that all LSP servers/clients respect it.
Mon, Feb 11
This is an intriguing idea, and is at least useful to prototype new tweaks.
I'm not sure whether clang-tidy is the ultimately right API to write tweaks:
it doesn't have the needed constraints to ensure prepare() is fast (e.g. it emits diagnostics and fixes eagerly)
the exact set of nodes that it will trigger on may or may not match what we want
it doesn't produce context-sensitive titles
Update the comments
Address review comment.
- [clangd] Re-submit format replacement for tweaks.
Fri, Feb 8
The change looks reasonable, I'd wait for a few days before commit in case anyone has concerns.
This is my experiment of playing around tweaks, I think we'll need this.
Thu, Feb 7
Remove an unexpected change.
Add reproduce testcase.
You'd need to rebase this patch, D57739 had some changes to the Tweak API.
Committed in rL353306.
Wed, Feb 6
Remove accident change.
Add missing file.
Address review comments.
This patch updates dev dependencies, please correct the commit title to avoid confusion :)
Move format to the tweak.
Set the flag to false by default.
Tue, Feb 5
Adress review comments.
Mon, Feb 4
The code looks good, but I have a concern about the check name -- double seems a confusing word, see my comment.
Fri, Feb 1
I'm +1 on disabling these checks as they add too much noise in editors (even though the naming check is correct, we can't do a global cleanup on the codebase). Let's commit it, we could revert it if someone has other concerns.
Wed, Jan 30
Looks good overall, most are nits.
Tue, Jan 29
Mon, Jan 28
Measured this patch on LLVM, the increasing number of symbols is reasonable (from 422 K to 425 K).