User Details
- User Since
- Aug 19 2015, 3:38 AM (353 w, 2 d)
Today
This patch might cover too many things (at least we could split the guide/glr implementation bit), but want to give you an overview of the picture first.
Wed, May 25
Thanks for the fix!
Thanks!
Tue, May 24
rebase, and emit string chunks rather than a long raw string literal (to make msvc happy)
Mon, May 23
Fri, May 20
Thanks, this looks a good start version!
Thu, May 19
add addPayload method, and share payload in cook as well
Wed, May 18
format fix
Address comments:
sorry, I might be lack of the context, where is the user complaint? I'm not sure which cases are improved with this patch.
Tue, May 17
Mon, May 16
move the findNonterminal to Grammar.
This is a revised version of D125231, based on our discussion. It has a narrow scope: only nonterminals of the grammar are compiled; and it mainly focuses on interfaces;
Thu, May 12
Wed, May 11
Would including *every* nonterminal as a start symbol would blow the size up a bit?
This would eliminate some complexity in the interface.
add a comment in cxx.bnf explaining why not making all nonterminals as start symbol by default.
Tue, May 10
- adress comments
- rename TargetSymbol -> StartSymbol
- don't use StartSymbol for "_", rename and update a few occurrences
- move findNonterminal to Grammar.h since it is used in various places
Thanks!
address comments
Mon, May 9
This is just a prototype, wanting some early feedback before making further progress:
- compiling the generated Cxx.cpp is very slow (took minutes, mostly due to the LRTable::Actions);
- layering (location of the generated header file) is not super clear;
Fri, May 6
This looks a reasonable split to me!
Thu, May 5
Nice!
I think "// FOO_BAR_H" in your message should be "// FOO_BAR_H" (two space).
Thanks!
Tue, May 3
would be nice to land it in some of form.
rebase
fix a dangling reference of the source text in clang-pseudo.
address remaining comments:
- return GSS::node in the NewHeadCallback, rather the fields of GSS::Node;
- remove the unncessary NewHeadResult structure in unittest;
Mon, May 2
Fix the bad format from lint.
- a derived version of D122408 and D121368;
- refine the APIs, getting rid of the GLR parser, and providing fine-grained pieces to allow writing tests easier;
- add unittests for the algorithm and a simple smoke lit test;
- when we fail to parse the input, we return an opaque forest node rather than a nullptr;
- rebase to the main branch;
Apr 27 2022
Fix the broken test.
Apr 26 2022
Apr 25 2022
Apr 22 2022
address comments