address comments.

address remaining nits.

address comments.

address comments:

• remove the confusing IsDeclRef
• use getQualifier from AST.h

more static_cast

fix a missing static_cast.

address comments.

address comments.

update a style comment.

thanks, looks great now!

In D67536#1697533, @nridge wrote:

How would one even measure the line length? SourceManager doesn't sem to have a method like getLineLength() or similar.

Could you add tests for this?

In D67901#1687308, @nridge wrote:

I do feel strongly that types and non-types should be highlighted differently, so the updated patch adds two new dependent highlightings, one for types and one for variables/functions.

add one more testcase.

looks good.

address comments.

address comments.

address comments.

address review comments.

The implementation looks good, just have some questions on the API.

format the testcases.

address review comments.

In D66647#1684046, @ilya-biryukov wrote:

We also need to rename parameters sometimes, right?

// Sometimes we need to rename parameters.
void usages(int decl_param, int);

void usages(int def_param, int now_named) {
  llvm::errs() << def_param + now_named;
}

// And template parameters! (these are even more interesting)
template <class T>
struct Foo {
  template <class U, class>
  void usages();
};
template <class L>
template <class R, class NowNamed>
void Foo<L>::usages() {
  llvm::errs() << L() + R() + NowNamed();
}

Upload correct diff.

Simplify the logic.