address comments and add AST tests.

friendly ping @rsmith :)

friendly ping @rsmith :)

address comment.

Looks like there are some failing tests in premerge bots, e.g. https://reviews.llvm.org/harbormaster/unit/view/185822/

In D88640#2339349, @rupprecht wrote:

It looks like this fix caused a different regression in not accepting name.<x>.h as the main header for name.<x>.cc, e.g.:

$ cat /tmp/foo.bar.cc
#include "a.h"
#include "z.h"
#include "foo.bar.h"

$ clang-format /tmp/foo.bar.cc  # Before
#include "foo.bar.h"

#include "a.h"
#include "z.h"

$ clang-format /tmp/foo.bar.cc  # After
#include "a.h"
#include "foo.bar.h"
#include "z.h"

address comments.

@kbobyrev you may miss this patch, this is a separate patch from D89300.

update

Thanks!

thanks.

Is this https://github.com/clangd/clangd/issues/554 ? :-)

ah, I thought I clicked the accepted button.

address review comments.

fix unexpected format changes.

In D89036#2319320, @kadircet wrote:

Tests seem to be failing on premerge bots:

• https://reviews.llvm.org/harbormaster/unit/view/177841/
• https://reviews.llvm.org/harbormaster/unit/view/177842/

Fix the test.

rebase

update: don't change the order in test.

fix format.

address comments.

In D88881#2313863, @sammccall wrote:

Can you add a bit more context to the commit message?

And should we expose this as an extension on textDocument/prepareRename?

make NewName optional.

address comments.

I'm not sure I love having the assertion for contains-errors every place that handles dependent code in C.

rebase

address comments

address comments.