We need to update the documentation http://clang.llvm.org/extra/clang-tidy/checks/objc-property-declaration.html as well.

Fix code style.

Thanks, LGTM, ship it!

Rebase to master.

In D50438#1224287, @ilya-biryukov wrote:

@hokein, would it be fine if I submit this change for you?
It would be nice to get this fix in before you get back from vacation.

Thanks, looks good from my side.

In D50958#1222249, @sammccall wrote:

Looking forward to using this!

Unless you object, I'd like to address the remaining comments (and get a review), so you can make the most of your leave!

LGTM, thanks!

Thanks for cleaning it up! I admit that SymbolOccurrences is a loong name. A few nits.

Nice! looks mostly good to me.

Rebase

address review comments:

• build memindex with symbol slab and occurrence slab
• remove withAllCode in TestTU

Minor cleanup.

• rebase
• address review comments

Committed in rL341208.

Sorry! Just realised I messed up this patch with D50385 (mostly SymbolCollector changes), all the comments about SymbolCollector are fixed in D50385.

Address review comments in D51279.

Thanks @aaron.ballman. I'm closing it now as it is committed in rL340915.

LGTM, note that this change will break our next internal integration.

Sorry, I just realized I didn't reply the comments in the first review (they were in my draft).

Address review comments, return deterministic results.

In D51360#1219024, @kbobyrev wrote:

Ah, correct. I totally forgot about the ^string$ for the exact match.

This should not change behavior now. I believe what you propose would make the code easier (there'd only be AbseilLibraries = {"absl/algorithm", ...} and the final return std::any_of(..., [](...) { return Path.find(Library) != StringRef::npos; }); but the performance would be worse (because of the presence of the absl/ prefix in each entry). Would you consider this less efficient but easier-to-follow approach better?

• address review comments
• rescope the patch only focus on findReferences implementation.

Thanks very much for improving it!

Thanks for the comments.

Address review comments.

Minor cleanup.

LGTM with a nit, thanks for your work.

Minor cleanup.

Address review comments and fix code style.

Please rebase your patch, since the absl matcher patch is submitted. Thanks.

I have committed the patch for you, rL340800.

In D51279#1214268, @ilya-biryukov wrote:

Just noticed I'm not on the reviewers list, sorry for chiming in without invitation. Was really excited about the change :-)

Thanks for the comments.

Some numbers of memory usage from running this on my machine:

Update the patch based on our new discussion

• SymbolOccurrenceSlab for storing underlying occurrence data
• reuse SymbolCollector to collect symbol occurrences

still LG.

Looks good.

Thanks, LGTM.

Add one more comment.

Address review comments.

Committed in rL340411.

LGTM.

Looks good mostly, a few nits. We should make sure all related comments are updated accordingly

Update the patch based on our offline discussion

Thanks! Looks good.

Please make sure the code follows the LLVM code style, e.g. the variable name format "CamelName".

Remove redundant CPlusPlus2a.

Use the std::equal to replace the memcmp.

Thanks for the updates. Looks mostly good, a few nits.

Your patch seems have some comments unaddressed but you marked done.

The patch looks good. I'll commit for you once @JonasToth has no further comments.

Correct the fix.

I think it is reasonable to make Sema support suggesting override methods, instead of implementing it in clangd side?

committed in rL340161.

The interfaces look mostly good to me.