User Details
- User Since
- Aug 19 2015, 3:38 AM (294 w, 4 d)
Fri, Apr 9
thanks, looks good!
Wed, Apr 7
Wed, Mar 24
- jrefine the fix of the crash: if the element type of an variable-length array
is incomplete, the array type is incomplete;
- simplify the testcase
Tue, Mar 23
Thanks!
Mon, Mar 22
Wed, Mar 17
Fri, Mar 12
hi @stefanp, this patch caused an asan error when running on ninja check-llvm-codegen-powerpc.
This looks like a reasonable solution to me -- if we don't know the function call result type (e.g. dependent-type callExpr in template context), modeling it as a dependent type.
Mar 8 2021
The code looks good, but I don't have a very strong opinion of making the resource-dir as a config option. Do we have a motivation (e.g. user request?) now?
Mar 7 2021
Thanks!
Mar 1 2021
Feb 28 2021
thanks, this looks great.
Feb 25 2021
Feb 24 2021
Feb 18 2021
address review comments
Feb 17 2021
Feb 16 2021
Feb 15 2021
Fix and simplify the test.
Feb 12 2021
Thanks, the fix looks good.
address review comment.
Feb 11 2021
fix failure tests.
address comment, add more tests.
maybe add some data (improvement DecisionForest vs heuristic) in the patch description.
Feb 10 2021
thanks! this looks like a nice improvement!
Feb 8 2021
Thanks for the quick fix.
Feb 5 2021
Feb 4 2021
Thanks!
Looks good, thanks!
Feb 3 2021
thanks, looks better now, just some nits to improve the code readability.
Thanks!
Thanks, this looks right to me.
Feb 2 2021
Feb 1 2021
Thanks, this looks great.
address comments.
Jan 31 2021
Thanks for fixing this!
Jan 29 2021
address comment.
Jan 28 2021
Jan 27 2021
I assume you'll handle the internal integration part ;)
address comments.
Jan 26 2021
Jan 25 2021
Thanks.