Page MenuHomePhabricator

mclow.lists (Marshall Clow)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 16 2012, 3:06 PM (457 w, 1 d)

Recent Activity

Mar 1 2021

mclow.lists added a comment to D96786: Including <ciso646> should result in an #error since C++17.

(2.3) — a #include of <ciso646>, <cstdalign>, or <cstdbool> can simply be removed.

This makes me think that it maybe better to generate #error instead of trying to workaround MSVC problem.

@mclow.lists, @ldionne, what do you think?

Mar 1 2021, 3:17 PM · Restricted Project

Feb 16 2021

mclow.lists added a comment to D96786: Including <ciso646> should result in an #error since C++17.

That cppreference page you quote says:

The same words are defined in the C programming language in the include file <iso646.h> as macros. Because in C++ these are built into the language, the C++ version of <iso646.h>, as well as <ciso646>, does not define anything.

Feb 16 2021, 7:09 AM · Restricted Project

Feb 7 2021

mclow.lists added a comment to D96221: [libc++] Implement base 10 itoa functions..

There's no 128 bit integral support, which I'd like to have in std::format, I can add a __u128toa to fix this.

If you really want to support 128 bit integers (it's optional), I'd suggest thinking about extending to_chars

Feb 7 2021, 11:31 AM · Restricted Project
mclow.lists added a comment to D96221: [libc++] Implement base 10 itoa functions..

There's no 128 bit integral support, which I'd like to have in std::format, I can add a __u128toa to fix this.

Feb 7 2021, 11:28 AM · Restricted Project
mclow.lists added a comment to D96221: [libc++] Implement base 10 itoa functions..

Why do we need *another* integer to string conversion function in libc++?

Feb 7 2021, 10:37 AM · Restricted Project

Jan 22 2021

mclow.lists added a comment to D95251: Remove noexcept from basic_string::find and implementation functions..

In the issue, I'll ask for clarification and propose either that all these find-like members are marked noexcept or none of them are. The thing that's really making me uneasy is that two of them are and the rest aren't.

It's probably a wide vs. narrow contract thing. The find overloads that take const char*, for example, have a precondition that the pointer is non-null. Under the so-called "Lakos rule" they would/could/should be "Throws: Nothing" but not noexcept.

Jan 22 2021, 2:39 PM · Restricted Project
mclow.lists added a comment to D95251: Remove noexcept from basic_string::find and implementation functions..
  • If the standard says they should be noexecpt, we should keep them noexcept.
  • Yes, file an LWG issue.
Jan 22 2021, 11:23 AM · Restricted Project

Jan 18 2021

mclow.lists added a comment to D93912: [libc++][P1679] add string contains.

Ok, I take it back. __str_find calls Traits::find, which is NOT always noexcept. (It *is* for all the specializations of std::char_traits, but that's not enough). So we can't slap NOEXCEPT here; in fact, we should revisit __str_find, and remove some of the NOEXCEPTs that are already there.

Jan 18 2021, 2:52 PM · Restricted Project
mclow.lists added inline comments to D93912: [libc++][P1679] add string contains.
Jan 18 2021, 2:45 PM · Restricted Project

Jan 14 2021

mclow.lists added a comment to D56692: More calendar bits for <chrono>.

Shouldn't this patch implement also the renames of leap and link?

Jan 14 2021, 7:48 AM · Restricted Project

Jan 13 2021

mclow.lists added a comment to D94569: [libcxx] Wipe some more macros that do not belong in C++ forwarding headers.

The C11 standard states (in section 7.21.7.5 The getc function):

Jan 13 2021, 7:43 AM · Restricted Project

Jan 7 2021

mclow.lists added a comment to D93912: [libc++][P1679] add string contains.

This looks like WAY too much code for "add string contains".

Jan 7 2021, 2:45 PM · Restricted Project

Dec 18 2020

mclow.lists added a comment to D93542: [SystemZ][ZOS] Provide CLOCK_MONOTONIC alternative.

If you don't have a steady clock, then none of the timed synchronization calls can work.

Dec 18 2020, 8:48 AM · Restricted Project
mclow.lists added a comment to D93542: [SystemZ][ZOS] Provide CLOCK_MONOTONIC alternative.

Starting in C++11, the standard library requires a monotonic clock.

Dec 18 2020, 7:38 AM · Restricted Project

Dec 17 2020

mclow.lists added inline comments to D93414: [libc++] Adds a make_string test helper function..
Dec 17 2020, 10:01 AM · Restricted Project

Dec 16 2020

mclow.lists added a comment to D93414: [libc++] Adds a make_string test helper function..

How about something more like:

make_string<char>(
                  " !\"#$%&'()*+,-./0123456789:;<=>?@ABCDEFGHIJKLMN"
                          "OPQRSTUVWXYZ[\\]^_`abcdefghijklmnopqrstuvwxyz{|}~")
      ==          " !\"#$%&'()*+,-./0123456789:;<=>?@ABCDEFGHIJKLMN"
                          "OPQRSTUVWXYZ[\\]^_`abcdefghijklmnopqrstuvwxyz{|}~");
Dec 16 2020, 12:01 PM · Restricted Project
mclow.lists requested changes to D93383: [libc++] Use c++20 instead of c++2a consistently..
Dec 16 2020, 7:34 AM · Restricted Project
mclow.lists added a comment to D93383: [libc++] Use c++20 instead of c++2a consistently..

You need to bump the TEST_STD_VER too - see test/support/test_macros.h

Dec 16 2020, 7:34 AM · Restricted Project

Dec 15 2020

mclow.lists added inline comments to D67086: Implement syncstream (p0053).
Dec 15 2020, 7:32 AM · Restricted Project

Dec 14 2020

mclow.lists added a comment to D93233: [libc++] Replaces std::sort by Bitset sorting algorithm..

IMHO bitset sort is not a standard term, so it needs some clarification. From a glance this uses a bitset partition and needs temporary storage (heap memory allocation?). Does the original algorithm have heap memory allocation?

Dec 14 2020, 11:02 AM · Restricted Project, Restricted Project

Dec 10 2020

mclow.lists added a comment to D93071: [libc++] NFCI: Implement make_shared as allocate_shared with std::allocator.

Indeed, however std::allocator is specified to use operator new and operator delete.

Dec 10 2020, 4:27 PM · Restricted Project
mclow.lists added a comment to D93071: [libc++] NFCI: Implement make_shared as allocate_shared with std::allocator.

if you allocate memory with an allocator, you need to deallocate it with the same allocator. Not with operator delete

Dec 10 2020, 3:25 PM · Restricted Project
mclow.lists added a comment to D93071: [libc++] NFCI: Implement make_shared as allocate_shared with std::allocator.

if you allocate memory with an allocator, you need to deallocate it with the same allocator. Not with operator delete

Dec 10 2020, 3:22 PM · Restricted Project
mclow.lists added a comment to D93025: [libc++] Remove invalid use of `#if _LIBCPP_STD_VER >= 11`, as `_LIBCPP_STD_VER` can never be less than 11..

if you need to remove something for C++03, then the test would be:
#ifndef _LIBCPP_CXX03_LANG

Dec 10 2020, 6:41 AM · Restricted Project

Dec 9 2020

mclow.lists added a comment to D92790: [libc++][P0053R7] Add <syncstream> header and implement std::basic_syncbuf.

I'm not seeing any coordination between different syncbufs on the same stream here.
My impression was that implementing this required a global registry of streams that had syscstreams associated with them.

Dec 9 2020, 4:48 PM · Restricted Project

Dec 3 2020

mclow.lists added inline comments to D91133: [2/N] [libcxx] [test] Add a test for conversions between wchar_t, utf8, char16_t, char32_t and windows native narrow code pages.
Dec 3 2020, 10:42 AM · Restricted Project

Dec 2 2020

mclow.lists added a comment to D92212: Make libcxx work according to Clang C++ Status if -fchar8_t is passed.

Consider the following program:

Dec 2 2020, 3:16 PM · Restricted Project
mclow.lists added inline comments to D92325: Add std::hash<char8_t> specialization if char8_t is enabled.
Dec 2 2020, 9:17 AM · Restricted Project
mclow.lists added a comment to D92212: Make libcxx work according to Clang C++ Status if -fchar8_t is passed.

I think this is the wrong direction - getting rid of _LIBCPP_NO_HAS_CHAR8_T
We're making the feature macro __cpp_lib_char8_t always match __cpp_char8_t
There are two macros for a reason.

Dec 2 2020, 6:01 AM · Restricted Project

Dec 1 2020

mclow.lists added inline comments to D92250: [libc++] Consistently replace `std::` qualification with `_VSTD::` or nothing. NFCI..
Dec 1 2020, 7:26 PM · Restricted Project

Nov 30 2020

mclow.lists added a comment to D92212: Make libcxx work according to Clang C++ Status if -fchar8_t is passed.

And we should be careful to define __cpp_lib_char8_t only when we provide the feature (which we do, based on _LIBCPP_NO_HAS_CHAR8_T)

Nov 30 2020, 12:00 PM · Restricted Project
mclow.lists added a comment to D92212: Make libcxx work according to Clang C++ Status if -fchar8_t is passed.

(reading back)

Nov 30 2020, 11:57 AM · Restricted Project
mclow.lists added a comment to D92212: Make libcxx work according to Clang C++ Status if -fchar8_t is passed.

Could you elaborate / invent artificial scenario when such logic is necessary?

I don't have to invent any such logic. It's right there in the existing code.

Nov 30 2020, 11:49 AM · Restricted Project
mclow.lists added inline comments to D92212: Make libcxx work according to Clang C++ Status if -fchar8_t is passed.
Nov 30 2020, 10:04 AM · Restricted Project
mclow.lists added a comment to D92325: Add std::hash<char8_t> specialization if char8_t is enabled.

Commented there.
For the record, the link is https://reviews.llvm.org/D92212 (without the trailing slash.
Alternately, you can just write D92212 and Phab will figure it out.

Nov 30 2020, 8:39 AM · Restricted Project
mclow.lists added inline comments to D92212: Make libcxx work according to Clang C++ Status if -fchar8_t is passed.
Nov 30 2020, 8:38 AM · Restricted Project
mclow.lists added inline comments to D92325: Add std::hash<char8_t> specialization if char8_t is enabled.
Nov 30 2020, 8:12 AM · Restricted Project

Nov 27 2020

mclow.lists added a comment to D92229: [libc++] Add format check to CI.

Has clang-format been improved enough that it will not "wreck" std::less<void>? Last time I tried it on that code, it pessimized it pretty thoroughly.
Code pasted here for reference:

#if _LIBCPP_STD_VER > 11
template <>
struct _LIBCPP_TEMPLATE_VIS less<void>
{
    template <class _T1, class _T2>
    _LIBCPP_CONSTEXPR_AFTER_CXX11 _LIBCPP_INLINE_VISIBILITY
    auto operator()(_T1&& __t, _T2&& __u) const
    _NOEXCEPT_(noexcept(_VSTD::forward<_T1>(__t) < _VSTD::forward<_T2>(__u)))
    -> decltype        (_VSTD::forward<_T1>(__t) < _VSTD::forward<_T2>(__u))
        { return        _VSTD::forward<_T1>(__t) < _VSTD::forward<_T2>(__u); }
    typedef void is_transparent;
};
#endif
Nov 27 2020, 7:32 AM · Restricted Project

Nov 26 2020

mclow.lists added a comment to D92190: [libc++] fix std::sort(T**, T**).

It would be nice if the test had a reference to the bug report.

Nov 26 2020, 9:57 AM · Restricted Project

Nov 10 2020

mclow.lists added a comment to D63744: In the libc++ unstable ABI, use [[no_unique_address]] instead of __compressed_pair when available..

Hm, that might indeed be feasible. We'll need to potentially insert padding both before the first type and after the second type, but we can static_assert the correctness against the old layout, so that's not _too_ scary.

If we go this route, it will mean that libc++ is only usable in an ABI-stable manner on Clang 9+ or GCC 9+. On earlier compilers, and on MSVC, the attribute is ignored, and the layout will thus be incorrect/incompatible. Is it viable to require those compiler versions to both build and use libc++? The LLVM build itself only requires GCC 5+/Clang 3.5 at the moment, so that would mean we'd need to start requiring the use of the 2-stage "runtimes" build in order to build libc++, at the least.

Nov 10 2020, 7:20 AM · Restricted Project

Nov 5 2020

mclow.lists added a comment to D87697: Do not construct std::string from nullptr.

I'm fine with this.
This is not how I'd write it, but that's ok :-)

Nov 5 2020, 11:40 AM · Restricted Project

Nov 3 2020

mclow.lists added a comment to D56692: More calendar bits for <chrono>.

I'm fine with rebasing and committing this.

Nov 3 2020, 7:17 AM · Restricted Project
mclow.lists added a comment to D87697: Do not construct std::string from nullptr.

LGTM

Nov 3 2020, 5:43 AM · Restricted Project

Oct 16 2020

mclow.lists added inline comments to D89057: Add the C++17 <memory_resource> header (mono-patch).
Oct 16 2020, 4:22 PM · Restricted Project
mclow.lists added inline comments to D88599: [SystemZ][ZOS] Porting pthread_t related functionality within libc++ to z/OS.
Oct 16 2020, 3:55 PM · Restricted Project
mclow.lists added inline comments to D88599: [SystemZ][ZOS] Porting pthread_t related functionality within libc++ to z/OS.
Oct 16 2020, 12:31 PM · Restricted Project
mclow.lists added inline comments to D88599: [SystemZ][ZOS] Porting pthread_t related functionality within libc++ to z/OS.
Oct 16 2020, 12:17 PM · Restricted Project

Oct 14 2020

mclow.lists added a comment to D88727: vector (iterator,iterator) constructor doesn't deduce second arg.
  • Make all the containers do resolve this the same way.
Oct 14 2020, 9:18 AM · Restricted Project
mclow.lists added a comment to D88727: vector (iterator,iterator) constructor doesn't deduce second arg.

So the goals of this patch should be:

  • Resolve the original problem,
  • Decide if the problem shown in D1723 is real, and if so, make sure that still works, and
  • Make all the containers do resolve this the same way.
Oct 14 2020, 9:16 AM · Restricted Project
mclow.lists added a comment to D88727: vector (iterator,iterator) constructor doesn't deduce second arg.

Looks like because of this patch vector deviated from other container implementation.
http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20130916/089030.html

Oct 14 2020, 9:14 AM · Restricted Project
mclow.lists added a comment to D88727: vector (iterator,iterator) constructor doesn't deduce second arg.

Is this a problem unique to vector? Do the other containers have the same constructor? Do those constructors have the same issue?
Checking ... list does not seem to have this problem. deque does not either. forward_list does not either.

Oct 14 2020, 8:49 AM · Restricted Project

Oct 2 2020

mclow.lists added a comment to D88718: [libcxx] Port to NuttX(https://nuttx.apache.org/) RTOS.

A general comment - is someone going to run a libc++ test bot for NuttX? Otherwise, how will we know when changes that we make to libc++ break NuttX support?

Oct 2 2020, 9:13 AM · Restricted Project
mclow.lists added inline comments to D88718: [libcxx] Port to NuttX(https://nuttx.apache.org/) RTOS.
Oct 2 2020, 9:12 AM · Restricted Project
mclow.lists requested changes to D88727: vector (iterator,iterator) constructor doesn't deduce second arg.
Oct 2 2020, 6:56 AM · Restricted Project

Sep 30 2020

mclow.lists requested changes to D88599: [SystemZ][ZOS] Porting pthread_t related functionality within libc++ to z/OS.
Sep 30 2020, 11:04 AM · Restricted Project

Sep 25 2020

mclow.lists added inline comments to D87697: Do not construct std::string from nullptr.
Sep 25 2020, 2:23 PM · Restricted Project
mclow.lists added a comment to D87697: Do not construct std::string from nullptr.

I would rather see:

llvm_unreachable("unexpected type");
return ""; // or string()
Sep 25 2020, 1:32 PM · Restricted Project

Sep 5 2020

mclow.lists added a comment to D87185: Do not construct string from nullptr.

LGTM.

Sep 5 2020, 9:00 AM · Restricted Project

Aug 6 2020

mclow.lists added a comment to D85466: [libcxx] Add C++20 source_location header.

A couple of quick comments, more to come.

Aug 6 2020, 1:05 PM · Restricted Project

Jul 30 2020

mclow.lists added inline comments to D84943: [libc++] Remove workarounds for missing rvalue references.
Jul 30 2020, 6:52 AM · Restricted Project

Jul 21 2020

mclow.lists added a comment to D84275: [Libcxx] Finish implementing Paper 0202R3.

I see no tests.

Jul 21 2020, 4:49 PM · Restricted Project

Jul 18 2020

mclow.lists added a comment to D82627: Fix CFI issues in <future>.

You are right. CFI also checks reinterpret_casts even if they are not UB, because they are just as likely to be a source of type confusion bugs. So, the choice here is between this change, and _LIBCPP_NO_CFI attribute. The attribute change would ideally move the casts into a helper function to avoid suppressing too much checking.

Jul 18 2020, 6:41 AM · Restricted Project

Jun 30 2020

mclow.lists added a comment to D82810: [libc++abi] Remove unused include of <sys/types.h>.

Might be useful to just run IWYU over the tree at some point to remove extraneous headers.

Jun 30 2020, 9:11 AM · Restricted Project

Jun 29 2020

mclow.lists added a comment to D82809: Optimize vector push_back for hot loops / push_back fill invocations.

General comment: would it not be better to make the compiler smarter to solve this (and reap the benefits for vector and other code)?

Jun 29 2020, 2:58 PM · Restricted Project

Jun 16 2020

mclow.lists added inline comments to D81954: Remove the try/catch codepath if `swap` is `noexcept`..
Jun 16 2020, 11:33 AM · Restricted Project
mclow.lists added a comment to D81425: [libc++] Don't force a conversion to difference_type in std::advance.

I wouldn't change the __advance definitions. That's just spreading the pain around. Convert from Distance to iterator_traits<...>::difference_type in advance

Jun 16 2020, 7:42 AM · Restricted Project

Jun 15 2020

mclow.lists added a comment to D81425: [libc++] Don't force a conversion to difference_type in std::advance.

I think it's weird to have a wide open template parameter like this in std::distance, but it appears to be what the Standard wants.

Jun 15 2020, 5:08 PM · Restricted Project

Jun 4 2020

mclow.lists added inline comments to D81133: Use allocator_traits to consistently allocate/deallocate/construct/destroy objects in std::any.
Jun 4 2020, 8:44 AM · Restricted Project
mclow.lists added inline comments to D81133: Use allocator_traits to consistently allocate/deallocate/construct/destroy objects in std::any.
Jun 4 2020, 8:11 AM · Restricted Project
mclow.lists updated the summary of D81133: Use allocator_traits to consistently allocate/deallocate/construct/destroy objects in std::any.
Jun 4 2020, 8:11 AM · Restricted Project
mclow.lists added a comment to D81133: Use allocator_traits to consistently allocate/deallocate/construct/destroy objects in std::any.

So I don't understand what the observable difference is here. Could you add a test?

Jun 4 2020, 7:38 AM · Restricted Project

Jun 3 2020

mclow.lists added a reviewer for D81133: Use allocator_traits to consistently allocate/deallocate/construct/destroy objects in std::any: tkoeppe.
Jun 3 2020, 11:57 PM · Restricted Project
mclow.lists created D81133: Use allocator_traits to consistently allocate/deallocate/construct/destroy objects in std::any.
Jun 3 2020, 11:57 PM · Restricted Project
mclow.lists updated the summary of D81133: Use allocator_traits to consistently allocate/deallocate/construct/destroy objects in std::any.
Jun 3 2020, 11:57 PM · Restricted Project
mclow.lists added a comment to D80743: (PR46111) Properly handle elaborated types in an implicit deduction guide.

I've got nothing to say here.

Jun 3 2020, 10:25 AM · Restricted Project

May 21 2020

mclow.lists accepted D80379: [libc++] Mark __u64toa and __u32toa as noexcept.

LGTM. Feel free to ignore the clang-format whining.

May 21 2020, 4:16 PM · Restricted Project
mclow.lists requested changes to D80379: [libc++] Mark __u64toa and __u32toa as noexcept.

This is not sufficient; it just "moves the pain" from the callers code into the dylib. All the functions in charconv.cpp need to be marked as noexcept.

May 21 2020, 8:03 AM · Restricted Project

May 6 2020

mclow.lists added a comment to D79427: [libcxx] Explicitly mark erroneous string_view ctors as deleted.

BTW, string(nullptr, 0) is a valid call. The range [nullptr, nullptr) is valid.

May 6 2020, 7:30 AM

May 5 2020

mclow.lists added a comment to D79427: [libcxx] Explicitly mark erroneous string_view ctors as deleted.

You're not really solving the problem you're talking about.

May 5 2020, 3:08 PM

Feb 24 2020

mclow.lists accepted D75074: [libc++] Proper fix for libc++'s modulemap after D68480.

This looks fine to me.

Feb 24 2020, 12:57 PM · Restricted Project

Feb 16 2020

mclow.lists committed rG8424789eecd7: Update last-mod date for libcxx status page (authored by mclow.lists).
Update last-mod date for libcxx status page
Feb 16 2020, 10:00 AM
mclow.lists committed rG1a07084f6d05: Updated with list of papers and issues adopted in Prague (authored by mclow.lists).
Updated with list of papers and issues adopted in Prague
Feb 16 2020, 10:00 AM

Feb 5 2020

mclow.lists added inline comments to D74105: [asan] Adhere to AddressSanitizer's alignment requirements for the end of a region..
Feb 5 2020, 7:34 PM

Jan 23 2020

mclow.lists requested changes to D70754: [libcxx] Add support for std::reinterpret_pointer_cast.

Still no tests. This will not be committed w/o tests.

Jan 23 2020, 7:16 AM · Restricted Project, Restricted Project

Jan 20 2020

mclow.lists requested changes to D70754: [libcxx] Add support for std::reinterpret_pointer_cast.
Jan 20 2020, 8:13 PM · Restricted Project, Restricted Project
mclow.lists added a comment to D70754: [libcxx] Add support for std::reinterpret_pointer_cast.

You have no tests.
If you had tests, you would probably have noticed that you typed _UP when you meant _Up

Jan 20 2020, 8:13 PM · Restricted Project, Restricted Project

Jan 4 2020

mclow.lists added a comment to D71994: SFINAE span default constructor on Extent == 0.

Also if we would not remove the default constructor span<T, 2> would fulfill the`default_constructible` concept although it does not.

Jan 4 2020, 9:22 PM · Restricted Project

Jan 2 2020

mclow.lists added a comment to D71994: SFINAE span default constructor on Extent == 0.

What is the benefit to the user to have this constructor SFINAE away?
With static_assert we can craft an error message.

Jan 2 2020, 5:47 PM · Restricted Project
mclow.lists added inline comments to D72036: [libcxx] span: Cleanup includes.
Jan 2 2020, 1:27 PM · Restricted Project

Jan 1 2020

mclow.lists added inline comments to D72036: [libcxx] span: Cleanup includes.
Jan 1 2020, 7:53 AM · Restricted Project
mclow.lists requested changes to D72036: [libcxx] span: Cleanup includes.

I'm fine with the other changes here, but not the array change.

Jan 1 2020, 7:49 AM · Restricted Project

Dec 29 2019

mclow.lists accepted D69603: [libcxx] Add deduction guides for shared_ptr and weak_ptr.

This looks good to me now.
You need to update www/cxx17_status.html appropriately as well.

Dec 29 2019, 8:46 PM · Restricted Project

Dec 26 2019

mclow.lists accepted D71908: [libcxx] [test] Include missing <limits> header..

LGTM

Dec 26 2019, 4:32 PM · Restricted Project

Dec 17 2019

mclow.lists added a comment to D71459: [libcxx] Fix include paths in fuzzing/partial_sort.pass.cpp.

Please don't commit to libc++ w/o approval from one of the "approvers": @mclow.lists, @EricWF or @ldionne .

Dec 17 2019, 9:45 AM · Restricted Project

Dec 16 2019

mclow.lists added a comment to D69466: Guard against overflow in span::subspan.

If the tests are calling operator[] on a span<T, 0>, then they are incorrect and should be changed.

Dec 16 2019, 9:29 AM · Restricted Project
mclow.lists added a comment to D69466: Guard against overflow in span::subspan.

I also believe that we should add a static assert to operator[] similar to front() and back(). Unfortunately there are multiple tests that rely on operator[] of a statically empty span. Thoughts?

Dec 16 2019, 8:34 AM · Restricted Project
mclow.lists added a comment to D69466: Guard against overflow in span::subspan.

There's at least three things going on in this patch; and that makes it harder to review:

  • Rename all the index_types to size_type.
  • Add static_assert to several cases
  • Guard against overflow in span::subspan (ostensibly the purpose of this patch).
Dec 16 2019, 8:34 AM · Restricted Project
mclow.lists accepted D71525: [libc++] Fix typo in std::midpoint.

Huh. I thought I fixed that typo. Anyway this LGTM.

Dec 16 2019, 8:25 AM · Restricted Project

Dec 12 2019

mclow.lists added a comment to D71395: [libc++] Fix -Wdeprecated-copy warnings in __bit_reference.

It appears that we have multiple things in review here.
See also D71096.
Also, is this in response to https://bugs.llvm.org/show_bug.cgi?id=44145 ? (which was closed as 'works for me')

Dec 12 2019, 7:27 AM · Restricted Project
mclow.lists added a comment to D71096: __bit_reference: fix -Wdeprecated-copy warnings.

Is this related to https://bugs.llvm.org/show_bug.cgi?id=44145 ?

Dec 12 2019, 7:20 AM · Restricted Project