mclow.lists (Marshall Clow)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 16 2012, 3:06 PM (270 w, 5 d)

Recent Activity

Tue, Sep 19

mclow.lists accepted D37955: [libcxx] Fix invert negative bracket match..

All the tests pass now (on Mac OS) Thanks!

Tue, Sep 19, 12:41 PM
mclow.lists requested changes to D37955: [libcxx] Fix invert negative bracket match..

When I applied this patch locally, some of the other tests started failing.
Specifically:

Tue, Sep 19, 7:06 AM

Mon, Sep 18

mclow.lists accepted D37997: [libcxx / lit] Make libcxx work correctly with the new testing workflow.

Seems to work fine here! LGTM.

Mon, Sep 18, 3:50 PM
mclow.lists updated the diff for D35472: Implement P0463R1: "Endian just Endian".

Fixed test and #ifdef guard

Mon, Sep 18, 1:57 PM
mclow.lists created D37994: Implement LWG2946: More ambiguity in `string` vs. `string_view`.
Mon, Sep 18, 1:43 PM

Thu, Sep 14

mclow.lists added a comment to D37871: [ASAN] Add macro denoting availability of new `__asan_handle_no_return()` function..

This looks fine to me (along with D37872)

Thu, Sep 14, 3:15 PM

Wed, Sep 13

mclow.lists added a comment to D37830: [libcxx] ABI: Fix for undefined "___cxa_deleted_virtual" symbol in MacOSX.

I agree with what @EricWF said - needs a test.
Also you should probably close D36870 with a note that this supersedes that one.

Wed, Sep 13, 5:03 PM

Tue, Sep 12

mclow.lists closed D28224: [libcxx, regex] Throw exception after too many steps..
Tue, Sep 12, 10:59 AM
mclow.lists accepted D28224: [libcxx, regex] Throw exception after too many steps..

Applied as revision 313056 (with minor editing)

Tue, Sep 12, 10:59 AM

Tue, Sep 5

mclow.lists accepted D35802: XFAIL tests on SLES11.

LGTM. Thanks!

Tue, Sep 5, 7:34 AM

Thu, Aug 31

mclow.lists added inline comments to D35802: XFAIL tests on SLES11.
Thu, Aug 31, 9:42 AM
mclow.lists added inline comments to D37104: [libc++] PR34298: Change std::function constructor and move assignment operator SFINAE checks to allow std::function with an incomplete return type .
Thu, Aug 31, 9:39 AM
mclow.lists added a comment to D35470: [libcxx] Implement pointer_traits::to_address as in P0653R0 .

This feature has not been added to the draft standard yet, so I'm reluctant to add it to libc++.

Thu, Aug 31, 7:39 AM
mclow.lists added a comment to D35802: XFAIL tests on SLES11.

Can you give an example of linux distro names with spaces in it?
Other than that, this looks fine to me.

Thu, Aug 31, 7:37 AM
mclow.lists added inline comments to D35732: Update system_error tests for more platforms..
Thu, Aug 31, 7:37 AM
mclow.lists added a comment to D36720: [libc++] Prevent stale site configuration headers.

This looks reasonable to me.

Thu, Aug 31, 7:32 AM
mclow.lists added a comment to D36870: [libcxx] Add missing __cxa_deleted_virtual.

In an ideal world, your example would fail to compile. However, we don't live in that world. (yet) :-(
This looks reasonable to me - but I didn't write these files - @EricWF - what do you think?

Thu, Aug 31, 7:26 AM
mclow.lists accepted D37024: [libcxx] [test] Cleanup nullopt_t tests.

LGTM.

Thu, Aug 31, 7:06 AM
mclow.lists accepted D37318: [libcxx] [www] Cleanup links to be https..

LGTM; thanks!

Thu, Aug 31, 6:59 AM

Wed, Aug 30

mclow.lists added a comment to D37182: [libcxx] Special visibility macros for the experimental library.

The reason for building the filesystem library as a statically linked lib (instead of dynamic) is that for quite a while it was changing significantly. Having people link statically means that we can make changes w/o worrying (as much) about people using the library - they can pick up new features /changes when they re-link their programs. Once we change to a dylib (and we will, but not yet), then we have to worry about ABI changes affecting programs in the field.

Wed, Aug 30, 8:36 AM

Mon, Aug 28

mclow.lists added a comment to D32788: Fix std::inplace_merge to be stable for all inputs.

I committed as r311952 which fixes this - based on Jan's suggestion, but not quite the same as this patch.

Mon, Aug 28, 4:19 PM
mclow.lists added inline comments to D37104: [libc++] PR34298: Change std::function constructor and move assignment operator SFINAE checks to allow std::function with an incomplete return type .
Mon, Aug 28, 10:39 AM
mclow.lists added inline comments to D37104: [libc++] PR34298: Change std::function constructor and move assignment operator SFINAE checks to allow std::function with an incomplete return type .
Mon, Aug 28, 10:39 AM

Sun, Aug 27

mclow.lists added a comment to D32788: Fix std::inplace_merge to be stable for all inputs.

Note: I suspect that the proposed change to <algorithm> fixes the problem, but the new tests don't check that.

Sun, Aug 27, 9:15 PM
mclow.lists added a comment to D32788: Fix std::inplace_merge to be stable for all inputs.

I applied the test change, but not the algorithm change, and the tests passed.

Sun, Aug 27, 9:15 PM

Aug 14 2017

mclow.lists added a comment to D36713: [libc++] Add a persistent way to disable availability.

What's the use case here? What are you trying to accomplish?

Aug 14 2017, 4:01 PM

Jul 17 2017

mclow.lists added inline comments to D35472: Implement P0463R1: "Endian just Endian".
Jul 17 2017, 8:46 AM

Jul 16 2017

mclow.lists created D35472: Implement P0463R1: "Endian just Endian".
Jul 16 2017, 8:08 PM

Jul 5 2017

mclow.lists added a comment to D32411: [libcxx] Provide #include_next alternative for MSVC.

@smeenai wrote:

This is kinda ugly, but I can't think of a better way to do it. I'm fine with this, but given that it's a pretty invasive change, I'm not comfortable accepting. You may wanna ping @EricWF and @mclow.lists directly.

Jul 5 2017, 11:21 AM
mclow.lists added a comment to D34574: [Sema] Disable c++17 aligned new and delete operators if not implemented in the deployment target's c++ standard library.

This commit breaks all the libc++ aligned new/delete tests on Mac OS. Was that deliberate?

Jul 5 2017, 10:02 AM
mclow.lists added a comment to D34556: [libcxx] Annotate c++17 aligned new/delete operators with availability attribute.

I'm not exactly sure why the test failed, but the patch was reverted in r306859.

Jul 5 2017, 10:01 AM
mclow.lists added a comment to D34556: [libcxx] Annotate c++17 aligned new/delete operators with availability attribute.

This doesn't work when running the libc++ tests against a non-system libc++. (which is what all the libc++ developers and AND all the test bots do)

Jul 5 2017, 9:10 AM

Jun 19 2017

mclow.lists added inline comments to D34249: [libc++] Don't use UTIME_OMIT to detect utimensat on Apple.
Jun 19 2017, 6:23 AM

Jun 15 2017

mclow.lists added a comment to D34157: [llvm-stress] Use C++11 mersenne_twister_engine random device instead of our own (PR32585).

my only concern is I have no idea if uniform_int_distribution guarantees the same behaviour on different targets as mersene does

Jun 15 2017, 10:07 AM
mclow.lists created D34237: Mark the operations of __wrap_iter as constexpr.
Jun 15 2017, 6:53 AM

Jun 14 2017

mclow.lists accepted D34224: [NFC] remove trailing WS.
Jun 14 2017, 5:57 PM
mclow.lists added a comment to D34176: [cmake] Make sure that -Wcast-qual is not a error in preparation for clang's -Wcast-qual for C++.

As of r305410, libc++ passes all the tests w/ -Wcast-qual enabled.

Jun 14 2017, 1:04 PM
mclow.lists added a comment to D33102: [clang] Implement -Wcast-qual for C++.

As of r305410, libc++ passes all the tests w/ -Wcast-qual enabled.

Jun 14 2017, 1:03 PM
mclow.lists created D34211: Implement the non-execution policy versions of `inclusive_scan` and `transform_ inclusive_scan` for C++17.
Jun 14 2017, 9:18 AM

Jun 13 2017

mclow.lists added a comment to D34111: Add an `__is_inplace_index` metafunction..

LGTM!

Jun 13 2017, 11:01 PM
mclow.lists added a comment to D34089: [llvm-stress] Ensure that the C++11 random device respects its min/max values (PR32585).

Is there a C++11 random class that covers the features we need (same results on different targets, drivable by input seed)?

Jun 13 2017, 11:01 AM
mclow.lists added a comment to D34089: [llvm-stress] Ensure that the C++11 random device respects its min/max values (PR32585).

After thinking about this, I agree with @bogner 's comment that we should just remove the whole Random class, and use the C++11 random number facilities instead.

Jun 13 2017, 9:01 AM
mclow.lists closed D34038: Implement the non-parallel versions of exclusive_scan and transform_exclusive_scan.
Jun 13 2017, 7:24 AM
mclow.lists accepted D34038: Implement the non-parallel versions of exclusive_scan and transform_exclusive_scan.

This was committed as r305136

Jun 13 2017, 7:24 AM
mclow.lists added a comment to D32146: PR32476: __nop_locale_mgmt.h not needed with newlib 2.5+.

This change looks fine to me - but I don't have the different newlib versions to test against.
Once everyone else is happy with the version detection, then I'm good with this.

Jun 13 2017, 7:23 AM
mclow.lists added a comment to D34111: Add an `__is_inplace_index` metafunction..

I could add some. Where do you think they should live?

Jun 13 2017, 7:20 AM

Jun 12 2017

mclow.lists accepted D34111: Add an `__is_inplace_index` metafunction..

LGTM. Do we need any tests?

Jun 12 2017, 7:27 PM

Jun 10 2017

mclow.lists added inline comments to D33997: Implement the non-execution policy versions of `reduce` and `transform_reduce` for C++17.
Jun 10 2017, 1:52 PM
mclow.lists updated the diff for D33997: Implement the non-execution policy versions of `reduce` and `transform_reduce` for C++17.

Rebased now that D34038 has landed; address Richard and Bryce's comments

Jun 10 2017, 1:51 PM

Jun 9 2017

mclow.lists updated the diff for D34038: Implement the non-parallel versions of exclusive_scan and transform_exclusive_scan.

Previous update was br0ken. This is better. :-)
Add a test to ensure that the calculations are done using the correct type.

Jun 9 2017, 5:06 PM
mclow.lists updated the diff for D34038: Implement the non-parallel versions of exclusive_scan and transform_exclusive_scan.

Add extra tests to make sure that the calculations are not done using the source sequence value_type.

Jun 9 2017, 4:41 PM

Jun 8 2017

mclow.lists updated the diff for D34038: Implement the non-parallel versions of exclusive_scan and transform_exclusive_scan.

Turn the for loops into do-while loops, saving a comparison.

Jun 8 2017, 8:08 PM
mclow.lists updated the diff for D34038: Implement the non-parallel versions of exclusive_scan and transform_exclusive_scan.

Added a _VSTD::, made some assertions static_assert, and addressed Bryce's concerns about doing an init when the input range is empty.

Jun 8 2017, 8:01 PM
mclow.lists added a comment to D33997: Implement the non-execution policy versions of `reduce` and `transform_reduce` for C++17.

Should the non-parallel implementation of reduce static_assert or SFINAE away when these requirements are not met?

Jun 8 2017, 7:47 PM
mclow.lists created D34038: Implement the non-parallel versions of exclusive_scan and transform_exclusive_scan.
Jun 8 2017, 9:16 AM

Jun 7 2017

mclow.lists abandoned D34007: Implement inclusive_scan and transform_inclusive_scan.

I don't think that this is a correct implementation. Also, I need tests for when the result overwrites the source.
As they say .. I'll be back :-)

Jun 7 2017, 3:51 PM
mclow.lists added a comment to D34007: Implement inclusive_scan and transform_inclusive_scan.

Re-reading this, I may have implemented exclusive_scan instead of inclusive_scan here.

Jun 7 2017, 1:14 PM
mclow.lists created D34007: Implement inclusive_scan and transform_inclusive_scan.
Jun 7 2017, 12:16 PM
mclow.lists closed D33588: Fix two sources of UB in __next_hash_pow2 (from __hash_table).
Jun 7 2017, 9:31 AM
mclow.lists closed D31956: Implement (part of) LWG2857: `{variant,optional,any}::emplace` should return the constructed value.

Landed as r300123

Jun 7 2017, 9:30 AM
mclow.lists added inline comments to D33997: Implement the non-execution policy versions of `reduce` and `transform_reduce` for C++17.
Jun 7 2017, 9:28 AM
mclow.lists created D33997: Implement the non-execution policy versions of `reduce` and `transform_reduce` for C++17.
Jun 7 2017, 9:27 AM

Jun 2 2017

mclow.lists accepted D33588: Fix two sources of UB in __next_hash_pow2 (from __hash_table).
Jun 2 2017, 5:09 PM

May 26 2017

mclow.lists added a comment to D33588: Fix two sources of UB in __next_hash_pow2 (from __hash_table).

I can reproduce this, but I'd rather figure out why we're calling __next_hash_pow2(0) or (1) before deciding how to fix it.

May 26 2017, 8:20 AM

May 25 2017

mclow.lists added inline comments to D33550: Make __wrap_iter constexpr.
May 25 2017, 7:29 AM
mclow.lists created D33550: Make __wrap_iter constexpr.
May 25 2017, 7:28 AM

May 24 2017

mclow.lists added a comment to D33424: Lexer: allow imaginary constants in GNU mode (only)..

More. Trying the above code on godbolt.org, gcc 6.1/6.2/6.3/7.1 all reject it (with -std=c++14 and -std=c++1z) with the error message:

May 24 2017, 3:32 PM
mclow.lists added a comment to D33424: Lexer: allow imaginary constants in GNU mode (only)..

This broke a libc++ test. The following is expected to fail to compile:

May 24 2017, 2:35 PM

May 10 2017

mclow.lists added a comment to D33021: [libcxx] [test] libc++ test changes for CWG 2094.

In general, I prefer having the space between static_assert( and the condition.

May 10 2017, 6:15 AM
mclow.lists accepted D33033: [libc++] Fix PR32979 - types with a private std::enable_shared_from_this base break shared_ptr.

LGTM

May 10 2017, 6:09 AM

Apr 20 2017

mclow.lists accepted D32307: [libcxx] [test] Resolve everyone's favorite warning, unused local typedef.
Apr 20 2017, 5:45 PM

Apr 18 2017

mclow.lists added inline comments to D31561: cmath: Skip Libc for integral types in isinf, etc..
Apr 18 2017, 4:44 PM
mclow.lists accepted D29351: [libcxx] [test] Update locale names for Windows, future_error error_code constructor, and future move count..

Other than that, this looks fine to me. In an

Apr 18 2017, 10:07 AM

Apr 13 2017

mclow.lists closed D31769: Remove the binders `bind1st`, `bind2nd`,`men_fun`, etc from C++17.

committed as revision 300232

Apr 13 2017, 11:38 AM

Apr 12 2017

mclow.lists accepted D31966: [libcxx] [test] Avoid Clang's -Wunused-const-variable in is_constructible.pass.cpp..

LGTM

Apr 12 2017, 8:47 AM

Apr 11 2017

mclow.lists added a comment to D31738: Don't prohibit conditional noexcept hash for unique_ptr and optional.

would you prefer I move that assert into the 11+ block here or do you have another suggestion?

Apr 11 2017, 1:59 PM
mclow.lists created D31956: Implement (part of) LWG2857: `{variant,optional,any}::emplace` should return the constructed value.
Apr 11 2017, 12:57 PM
mclow.lists added a comment to D29877: Warn about unused static file scope function template declarations..

Complete reproducer:

Apr 11 2017, 8:35 AM
mclow.lists added a comment to D29877: Warn about unused static file scope function template declarations..

The following idiom for detecting member typedefs now throws an warning:

Apr 11 2017, 8:07 AM

Apr 6 2017

mclow.lists created D31769: Remove the binders `bind1st`, `bind2nd`,`men_fun`, etc from C++17.
Apr 6 2017, 9:23 AM
mclow.lists accepted D16541: [libc++] Renable test/std/re/re.alg/re.alg.match/awk.pass.cpp.

committed as revision 299652

Apr 6 2017, 7:45 AM
mclow.lists accepted D31515: [libc++] Implement LWG 2911 - add an is_aggregate type-trait.

LGTM

Apr 6 2017, 6:49 AM
mclow.lists accepted D31738: Don't prohibit conditional noexcept hash for unique_ptr and optional.

This looks good to me - though an extra comment would help in the future.

Apr 6 2017, 6:47 AM

Mar 23 2017

mclow.lists closed D20660: Remove `auto_ptr` in C++17..
Mar 23 2017, 11:02 PM
mclow.lists closed D30045: Remove `std::random_shuffle` in C++17.

Committed as revision 298597

Mar 23 2017, 11:01 PM
mclow.lists closed D31163: Implement Pp0156r2 "Variadic Lock Guard, version 5".

Committed as revision 298681.

Mar 23 2017, 11:00 PM
mclow.lists closed D31022: Implement P0298R3: `std::byte`.

Committed as revision 298689

Mar 23 2017, 10:58 PM
mclow.lists added inline comments to D31163: Implement Pp0156r2 "Variadic Lock Guard, version 5".
Mar 23 2017, 8:44 PM
mclow.lists updated the diff for D31163: Implement Pp0156r2 "Variadic Lock Guard, version 5".

Removed the deduction guides. Guarded the tests for the deduction guides with #ifdefs.

Mar 23 2017, 8:42 PM

Mar 22 2017

mclow.lists closed D31234: Implement P0599 - noexcept for hash functions.

Committed as revision 298573

Mar 22 2017, 7:52 PM
mclow.lists added inline comments to D31163: Implement Pp0156r2 "Variadic Lock Guard, version 5".
Mar 22 2017, 4:29 PM
mclow.lists updated the diff for D31234: Implement P0599 - noexcept for hash functions.

Add missing include to the thread::id test and mark unique_ptrs hash as not noexcept.

Mar 22 2017, 9:38 AM

Mar 21 2017

mclow.lists created D31234: Implement P0599 - noexcept for hash functions.
Mar 21 2017, 10:38 PM

Mar 20 2017

mclow.lists created D31163: Implement Pp0156r2 "Variadic Lock Guard, version 5".
Mar 20 2017, 7:10 PM
mclow.lists updated the diff for D31022: Implement P0298R3: `std::byte`.

Put the std::byte type in the unadorned namespace std, rather than the versioned one. This matches the behavior of other types that the compiler "knows about", like initializer_list, type_info, bad_alloc and so on.

Mar 20 2017, 12:22 PM

Mar 15 2017

mclow.lists added inline comments to D31022: Implement P0298R3: `std::byte`.
Mar 15 2017, 8:25 PM
mclow.lists created D31022: Implement P0298R3: `std::byte`.
Mar 15 2017, 8:23 PM

Mar 13 2017

mclow.lists accepted D30924: Fix assignment-in-conditional in "extending memory management tools" algorithms.

LGTM!

Mar 13 2017, 6:46 PM

Feb 21 2017

mclow.lists added a comment to D30035: Add const to function parameters.

Absent I good motivation (i.e, a documented, significant performance change), I don't think we want this - not because it's not a reasonable change (it is!), but because it's an ABI break.

Feb 21 2017, 6:09 AM

Feb 16 2017

mclow.lists created D30045: Remove `std::random_shuffle` in C++17.
Feb 16 2017, 7:13 AM