Page MenuHomePhabricator

mclow.lists (Marshall Clow)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 16 2012, 3:06 PM (362 w, 1 d)

Recent Activity

Today

mclow.lists closed D58987: Make underlying_type SFINAE-friendly.

I forgot about this patch, and went off and implemented this myself. Sorry about that.

Tue, Jun 25, 7:42 PM
mclow.lists updated the diff for D51262: Implement P0553 and P0556.

Address a couple of review comments. Added a few more uint128_t rotation tests

Tue, Jun 25, 6:22 PM
mclow.lists added a comment to D51262: Implement P0553 and P0556.

I should also mention that as a conforming extension, I have implemented the non-numeric bit operations for std::byte

I thought there was a DR or proposal to enable that, but I don't see one now.

Tue, Jun 25, 6:18 AM

Yesterday

mclow.lists added inline comments to D51262: Implement P0553 and P0556.
Mon, Jun 24, 8:25 PM
mclow.lists added inline comments to D51262: Implement P0553 and P0556.
Mon, Jun 24, 8:23 PM
mclow.lists added inline comments to D51262: Implement P0553 and P0556.
Mon, Jun 24, 8:23 PM
mclow.lists added inline comments to D51262: Implement P0553 and P0556.
Mon, Jun 24, 7:40 PM
mclow.lists added inline comments to D51262: Implement P0553 and P0556.
Mon, Jun 24, 7:32 PM
mclow.lists added inline comments to D51262: Implement P0553 and P0556.
Mon, Jun 24, 7:23 PM
mclow.lists added a comment to D51262: Implement P0553 and P0556.

Also are the unsigned types that aren't integral?

Mon, Jun 24, 6:22 PM
mclow.lists added inline comments to D51262: Implement P0553 and P0556.
Mon, Jun 24, 5:47 PM
mclow.lists updated the diff for D51262: Implement P0553 and P0556.

Update this patch to implement P1355R2 which makes out-of-bound inputs for ceil2UB. This was easy for integer types that are at least as big as int, but harder for smaller ones.

Mon, Jun 24, 5:30 PM
mclow.lists added a comment to D63744: In the libc++ unstable ABI, use [[no_unique_address]] instead of __compressed_pair when available..

A couple of general comments; still working through all the bits.

Mon, Jun 24, 4:59 PM · Restricted Project

Fri, Jun 21

mclow.lists committed rG410b650e6744: Implement P0340R3: Make 'underlying_type' SFINAE-friendly. Reviewed as https… (authored by mclow.lists).
Implement P0340R3: Make 'underlying_type' SFINAE-friendly. Reviewed as https…
Fri, Jun 21, 11:56 AM
mclow.lists closed D63574: Implement P0340R3: Make `underlying_type` SFINAE-friendly.

Committed as revision 364094

Fri, Jun 21, 11:55 AM

Thu, Jun 20

mclow.lists updated the diff for D63574: Implement P0340R3: Make `underlying_type` SFINAE-friendly.

Use an 'impl' class to prevent a name mangling change.

Thu, Jun 20, 5:44 PM
mclow.lists updated the diff for D63574: Implement P0340R3: Make `underlying_type` SFINAE-friendly.

Update based on Richard's comments.

Thu, Jun 20, 10:44 AM
mclow.lists updated the diff for D63574: Implement P0340R3: Make `underlying_type` SFINAE-friendly.

Some test cleanup.; add notes to the failing test to say why the other cases don't fail.

Thu, Jun 20, 8:47 AM
mclow.lists added a comment to D63574: Implement P0340R3: Make `underlying_type` SFINAE-friendly.

How many of these should fail?

Thu, Jun 20, 7:01 AM

Wed, Jun 19

mclow.lists added a comment to D63574: Implement P0340R3: Make `underlying_type` SFINAE-friendly.

How many of these should fail?

enum E1                   { E1Zero, E1One, E1Two = sizeof(std::underlying_type<E1>::type) };
enum E2 : char            { E2Zero, E2One, E2Two = sizeof(std::underlying_type<E2>::type) };
enum class E3             { E3Zero, E3One, E3Two = sizeof(std::underlying_type<E3>::type) };
enum struct E4 : unsigned { E4Zero, E4One, E4Two = sizeof(std::underlying_type<E4>::type) };
enum struct E5            { E5Zero, E5One, E5Two = sizeof(std::underlying_type<E5>::type) };
enum class E6 : unsigned  { E6Zero, E6One, E6Two = sizeof(std::underlying_type<E6>::type) };

@rsmith ?

Wed, Jun 19, 4:47 PM
mclow.lists added a comment to D63574: Implement P0340R3: Make `underlying_type` SFINAE-friendly.

Note: There is no feature test macro for this.

Wed, Jun 19, 2:34 PM
mclow.lists created D63574: Implement P0340R3: Make `underlying_type` SFINAE-friendly.
Wed, Jun 19, 2:27 PM
mclow.lists added a comment to D59886: Heterogeneous lookup for unordered containers (P0919R3).

Here's a few nits; I'm still working on the code.

Wed, Jun 19, 9:43 AM
mclow.lists added a comment to D59886: Heterogeneous lookup for unordered containers (P0919R3).

Friendly ping. I am waiting on this patch to get done before I submit a patch for precalculated hashes (which is mostly done).

Wed, Jun 19, 9:34 AM
mclow.lists committed rGd72ebeef2cdc: Mark papers P1458, P1459, P1462 and P1464 as complete. No changed needed to… (authored by mclow.lists).
Mark papers P1458, P1459, P1462 and P1464 as complete. No changed needed to…
Wed, Jun 19, 9:30 AM

Tue, Jun 18

mclow.lists committed rG2184374d9482: Disable the 'nextafter' portions of these tests on PPC when using 128-bit… (authored by mclow.lists).
Disable the 'nextafter' portions of these tests on PPC when using 128-bit…
Tue, Jun 18, 2:17 PM
mclow.lists accepted D62384: [libcxx][tests]Skip checking midpoint of adjacent values for PPC double-double.

I was updating this test this morning to add constexpr tests, so I just committed this as revision 363740.

Tue, Jun 18, 2:17 PM · Restricted Project
mclow.lists added a comment to D63328: [libc++] Avoid using timespec when it might not be available.

In 2019, do we really care about pre-C11 libraries?

Tue, Jun 18, 11:23 AM · Restricted Project, Restricted Project
mclow.lists committed rG8dc6840f1c91: Fix the floating point version of midpoint. It wasn't constexpr, among other… (authored by mclow.lists).
Fix the floating point version of midpoint. It wasn't constexpr, among other…
Tue, Jun 18, 11:13 AM
mclow.lists accepted D44865: [libc++] Implement P0608R3 - A sane variant converting constructor.

This looks good to me. Thanks!

Tue, Jun 18, 6:44 AM · Restricted Project

Mon, Jun 17

mclow.lists committed rG546006b64ea6: Update status of issue 3209 (authored by mclow.lists).
Update status of issue 3209
Mon, Jun 17, 11:27 AM
mclow.lists committed rG2e550cabead6: Add tests for LWG 3206. NFC (authored by mclow.lists).
Add tests for LWG 3206. NFC
Mon, Jun 17, 11:06 AM
mclow.lists committed rGa8dcd4768876: Update the meeting page with papers/issues that are ready for Cologne (authored by mclow.lists).
Update the meeting page with papers/issues that are ready for Cologne
Mon, Jun 17, 9:19 AM
mclow.lists added a comment to D58879: Implement uses-allocator (P0591R4).

Please make sure that you implement LWG 3185 as part of this patch

Mon, Jun 17, 8:55 AM
mclow.lists committed rG2dda1ff03805: Fix a '>= 0' test on unsigned that I inadvertantly introduced. Now correctly '! (authored by mclow.lists).
Fix a '>= 0' test on unsigned that I inadvertantly introduced. Now correctly '!
Mon, Jun 17, 6:40 AM

Thu, Jun 13

mclow.lists closed D61869: Fix PR41843 - std::is_base_of should give correct result for incomplete unions.

This has been committed; it broke the bots using "apple-clang-9.1", which I didn't even know existed.

Thu, Jun 13, 7:57 AM

Tue, Jun 11

mclow.lists committed rG903d3db59347: Mark CTAD fail tests for set/multiset as XFAIL for older compilers that give… (authored by mclow.lists).
Mark CTAD fail tests for set/multiset as XFAIL for older compilers that give…
Tue, Jun 11, 1:34 PM
mclow.lists committed rG1dc3c9aa8f7a: XFAIL a couple of tests on apple-clang-9.1, which is a compiler that I didn't… (authored by mclow.lists).
XFAIL a couple of tests on apple-clang-9.1, which is a compiler that I didn't…
Tue, Jun 11, 1:12 PM

Mon, Jun 10

mclow.lists committed rG2efd2957efac: Add a test for is_base_of and incomplete types. Because this trait uses a… (authored by mclow.lists).
Add a test for is_base_of and incomplete types. Because this trait uses a…
Mon, Jun 10, 8:37 PM
mclow.lists committed rGd40807c6bb7a: XFAIL a couple of CTAD tests on clang-6; it gives different error messages than… (authored by mclow.lists).
XFAIL a couple of CTAD tests on clang-6; it gives different error messages than…
Mon, Jun 10, 5:21 PM
mclow.lists committed rG141c2b768db0: Recommit r362649, which was reverted in r262680 because of bugs in std… (authored by mclow.lists).
Recommit r362649, which was reverted in r262680 because of bugs in std…
Mon, Jun 10, 4:17 PM
mclow.lists added a comment to D59178: [libc++] Speedup to_string and to_wstring for integers using stack buffer and SSO.

Recommitted as revision 363003

Mon, Jun 10, 4:17 PM · Restricted Project
mclow.lists added a comment to D44865: [libc++] Implement P0608R3 - A sane variant converting constructor.

The patch looks fine to me, but I think you should consider making a couple of T.fail.cpp tests, and check to make sure you get the "right error".

Mon, Jun 10, 3:26 PM · Restricted Project
mclow.lists added a comment to D44865: [libc++] Implement P0608R3 - A sane variant converting constructor.

This LGTM.

Also I would like @mclow.lists input about applying this DR early since LWG
hasn't commented on it yet.

Mon, Jun 10, 2:47 PM · Restricted Project
mclow.lists committed rGedfe8525de1f: Implement deduction guides for map/multimap. Reviewed as https://reviews.llvm. (authored by mclow.lists).
Implement deduction guides for map/multimap. Reviewed as https://reviews.llvm.
Mon, Jun 10, 2:26 PM
mclow.lists closed D58587: Implement P0433: deduction guides for <map>.

Committed as revision 362986

Mon, Jun 10, 2:25 PM · Restricted Project
mclow.lists accepted D63053: Add nullptr output operator overload (2221).

Once you fix the nits, I think this is good to go.
Be sure to update www/cxx1z_status.html as well.

Mon, Jun 10, 2:09 PM
mclow.lists accepted D63047: [libc++] Fix leading zeros in std::to_chars.

LGTM, thanks. I have more tests that I'll be adding in the next week or so, but no reason to hold this up for them.

Mon, Jun 10, 8:35 AM · Restricted Project
mclow.lists added a comment to D63047: [libc++] Fix leading zeros in std::to_chars.

Ping @mclow.lists
Do you plan to do a final scan before I merging this?

Mon, Jun 10, 7:52 AM · Restricted Project
mclow.lists added inline comments to D63053: Add nullptr output operator overload (2221).
Mon, Jun 10, 6:53 AM

Sun, Jun 9

mclow.lists added a comment to D44865: [libc++] Implement P0608R3 - A sane variant converting constructor.

Ping @mclow.lists @EricWF ; the patch still applies, is there any other thing I need to address?

Sun, Jun 9, 9:26 PM · Restricted Project
mclow.lists requested changes to D63063: Bug 42208: speeding up std::merge.

Thanks, but no.
Because of the gotos, we can't make this constexpr, and we need to do that.

Sun, Jun 9, 7:57 PM

Thu, Jun 6

mclow.lists added a comment to D59178: [libc++] Speedup to_string and to_wstring for integers using stack buffer and SSO.

I tested the following change and verified that it works for the numeric example above, but don't have time to write a test and monitor for build failures so I'm going to revert this change for now. Leaving it here for whoever wants to pick it up:

Thu, Jun 6, 3:13 PM · Restricted Project
mclow.lists added a comment to D59178: [libc++] Speedup to_string and to_wstring for integers using stack buffer and SSO.

I have replicated this problem with to_chars. https://bugs.llvm.org/show_bug.cgi?id=42166

Thu, Jun 6, 8:47 AM · Restricted Project
mclow.lists added inline comments to D58587: Implement P0433: deduction guides for <map>.
Thu, Jun 6, 6:37 AM · Restricted Project

Wed, Jun 5

mclow.lists added a comment to D62384: [libcxx][tests]Skip checking midpoint of adjacent values for PPC double-double.

In svn 360673 we changed this call from "nextoward` to nextafter because NetBSD 8 doesn't implement the former.

Wed, Jun 5, 3:01 PM · Restricted Project
mclow.lists added a comment to D62384: [libcxx][tests]Skip checking midpoint of adjacent values for PPC double-double.

I'd like to understand what's going on with nextafter when you say "is unreliable". Is there a link describing this behavior?

Wed, Jun 5, 3:00 PM · Restricted Project
mclow.lists committed rG5347024e283c: Update issue statuses. Reviewed as https://reviews.llvm.org/D62932 (authored by mclow.lists).
Update issue statuses. Reviewed as https://reviews.llvm.org/D62932
Wed, Jun 5, 2:51 PM
mclow.lists closed D62932: Update status.

Committed as revision 362659

Wed, Jun 5, 2:49 PM
mclow.lists added a comment to D62932: Update status.

2750 nothing to do because std::experimental::optional no longer exists.

This is correct, however the current wording for optional::optional(U&&) does NOT have a condition like !std::is_same<T, std::remove_reference_t<U>>::value. Was it "forgotten" when we Standardized std::optional? If so, then maybe we need to create a LWG issue.

Wed, Jun 5, 2:45 PM
mclow.lists committed rG7ce7110e6d96: Speedup to_string and to_wstring for integers using stack buffer and SSO. (authored by mclow.lists).
Speedup to_string and to_wstring for integers using stack buffer and SSO.
Wed, Jun 5, 2:02 PM
mclow.lists closed D59178: [libc++] Speedup to_string and to_wstring for integers using stack buffer and SSO.

Committed as revision 362649

Wed, Jun 5, 2:01 PM · Restricted Project
mclow.lists accepted D59178: [libc++] Speedup to_string and to_wstring for integers using stack buffer and SSO.

This looks good to me.
One of these days, we'll have to_chars for floating point as well, and we can clean this up some more.

Wed, Jun 5, 12:15 PM · Restricted Project
mclow.lists accepted D62618: [libcxx] Make std::tuple<> trivially constructible.

Just to confirm, @mclow.lists are we OK with this since the LWG issue has been filed?

Wed, Jun 5, 8:58 AM · Restricted Project, Restricted Project
mclow.lists accepted D62868: [libc++] Always build with -fvisibility=hidden.

I'm fine with this.

Wed, Jun 5, 8:58 AM · Restricted Project

Tue, Jun 4

mclow.lists added a comment to D62868: [libc++] Always build with -fvisibility=hidden.

This is in response to https://bugs.llvm.org/show_bug.cgi?id=38138, correct?

Tue, Jun 4, 10:46 AM · Restricted Project
mclow.lists committed rG605d62e9de00: No longer reject inputs when using a locale that has grouping information _and_… (authored by mclow.lists).
No longer reject inputs when using a locale that has grouping information _and_…
Tue, Jun 4, 8:18 AM

Mon, Jun 3

mclow.lists committed rGf67524d4006c: We had a _LIBCPP_ASSERT commented out because gcc 4.9 didn't like it. We (LLVM)… (authored by mclow.lists).
We had a _LIBCPP_ASSERT commented out because gcc 4.9 didn't like it. We (LLVM)…
Mon, Jun 3, 7:06 PM
mclow.lists accepted D43226: __threading_support: Remove (void) in favor of ()..

This looks fine to me.

Mon, Jun 3, 5:54 PM
mclow.lists added a comment to D62782: Fix -Wdouble-promotion warnings..

This looks fine to me; but where were you getting these warnings?

Mon, Jun 3, 6:55 AM
mclow.lists added a comment to D62719: A hot fix for exclusive_scan.

Actually, we should probably get a test of some sort here before accepting the change. Yes, it's fairly obviously wrong and the fix is fairly obviously correct, but it's a regression and we should provide tests for regressions, lest certain standard library maintainers ask uncomfortable questions.

Do you mean a test should we added which will coverage the fixed error? In other words we need a test which checks following thing:

"Parallel algorithms shall not participate in overload resolution unless is_execution_policy_v<decay_-
t<ExecutionPolicy>> is true."

Right?

Mon, Jun 3, 6:36 AM

Sun, Jun 2

mclow.lists added a comment to D62770: [libcxx] Use libtool when merging archives on Apple platforms.

This looks fine to me, but I'd like @ldionne to weigh in on this.

Sun, Jun 2, 2:17 PM · Restricted Project

Sat, Jun 1

mclow.lists added a comment to D43159: Modernize: Use nullptr more..

Can we revive this review? I'd still like to land this ...

Sat, Jun 1, 6:30 AM

Fri, May 31

mclow.lists added a comment to D62719: A hot fix for exclusive_scan.

Actually, we should probably get a test of some sort here before accepting the change. Yes, it's fairly obviously wrong and the fix is fairly obviously correct, but it's a regression and we should provide tests for regressions, lest certain standard library maintainers ask uncomfortable questions.

Fri, May 31, 12:24 PM
mclow.lists accepted D62428: [libcxx] Slightly improved policy for handling experimental features.

Folks, I just spoke to Marshall over the phone and I believe one of the reasons for the opposition is that I didn't make it clear we were not warning on ALL uses of experimental features. The new proposal only adds deprecation warnings when we standardize a feature and we know FOR SURE we're going to remove the experimental version in the near future. I didn't make that change from the initial proposal clear, and I apologize for that. With that thing being clear, the proposal seemed to be more reasonable.

Fri, May 31, 12:23 PM · Restricted Project, Restricted Project
mclow.lists committed rG7fc6a55688c8: Add include for 'test_macros.h' to all the tests that were missing them. Thanks… (authored by mclow.lists).
Add include for 'test_macros.h' to all the tests that were missing them. Thanks…
Fri, May 31, 11:36 AM
mclow.lists added a comment to D62428: [libcxx] Slightly improved policy for handling experimental features.
In D62428#1519664, @jfb wrote:

The deletions are fine, the doc updates are good, but I think deprecation warnings are not.
Things that are going to happen in the future (a year from now, say) or never (if people don't update their tools) don't belong in the warning spew for every single build

Similar deprecation warnings are pretty common coming from clang (both for standard things as well as extensions / builtins). What Louis proposes seems consistent with what the compiler does. Do you think there's a better approach that libc++ could take?

Fri, May 31, 8:46 AM · Restricted Project, Restricted Project

Thu, May 30

mclow.lists added inline comments to D58587: Implement P0433: deduction guides for <map>.
Thu, May 30, 7:02 AM · Restricted Project
mclow.lists added a comment to D62654: [Docs] Modernize references to macOS.

I'm fine with the libc++ changes.

Thu, May 30, 6:30 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Wed, May 29

mclow.lists added inline comments to D62618: [libcxx] Make std::tuple<> trivially constructible.
Wed, May 29, 2:55 PM · Restricted Project, Restricted Project
mclow.lists added a comment to D62618: [libcxx] Make std::tuple<> trivially constructible.

I have no problems with the code, btw.

Wed, May 29, 12:29 PM · Restricted Project, Restricted Project
mclow.lists added a comment to D62618: [libcxx] Make std::tuple<> trivially constructible.

Other than the "this is not standard behavior", and my general feeling about "things that everyone does, but aren't in the standard", I'm fine with this.
Once we get an LWG issue open on this behavior, I'll be strongly in favor of this.

Wed, May 29, 12:29 PM · Restricted Project, Restricted Project
mclow.lists added inline comments to D58587: Implement P0433: deduction guides for <map>.
Wed, May 29, 11:03 AM · Restricted Project
mclow.lists added a comment to D58587: Implement P0433: deduction guides for <map>.

Almost there - and I'm on the hook for comments on the reference stuff.

Wed, May 29, 10:49 AM · Restricted Project
mclow.lists committed rG6b03a1b42352: Add additional constraints on midpoint(pointer, pointer). Fixes PR#42037. (authored by mclow.lists).
Add additional constraints on midpoint(pointer, pointer). Fixes PR#42037.
Wed, May 29, 8:16 AM

Tue, May 28

mclow.lists committed rG41d5fdfa9140: Fix test that used raw string literals. Doesn't work in C++03 (authored by mclow.lists).
Fix test that used raw string literals. Doesn't work in C++03
Tue, May 28, 4:12 PM
mclow.lists added a comment to D62554: [builtins] Move the compare2f definition outside of the macro.

This seems to have resolved my problem with apple-clang-8. Thanks!

Tue, May 28, 4:01 PM · Restricted Project, Restricted Project
mclow.lists committed rG1efbe67414fd: Fix an incorrect 'Throws' in the regex code. Add a test for the new behavior. (authored by mclow.lists).
Fix an incorrect 'Throws' in the regex code. Add a test for the new behavior.
Tue, May 28, 3:40 PM
mclow.lists closed D61828: Throw the proper exception on a regex range error.

Landed as revision 361887.

Tue, May 28, 3:39 PM · Restricted Project
mclow.lists added a comment to D58582: Implement P0433: deduction guides for <set>.

Almost there. A couple nits, a few consts, and landing D58587, and we're done.

Tue, May 28, 11:04 AM · Restricted Project
mclow.lists added inline comments to D58587: Implement P0433: deduction guides for <map>.
Tue, May 28, 10:05 AM · Restricted Project
mclow.lists added a comment to D58587: Implement P0433: deduction guides for <map>.

This looks good to me, with a few nits.

Tue, May 28, 10:05 AM · Restricted Project

Mon, May 27

mclow.lists added a comment to D62428: [libcxx] Slightly improved policy for handling experimental features.

The deletions are fine, the doc updates are good, but I think deprecation warnings are not.
Things that are going to happen in the future (a year from now, say) or never (if people don't update their tools) don't belong in the warning spew for every single build

Mon, May 27, 2:27 PM · Restricted Project, Restricted Project

May 23 2019

mclow.lists added a comment to D62336: [CMake] Fixing errors in r361513.

This change fixed my broken build on Ubuntu.

May 23 2019, 11:56 AM · Restricted Project
mclow.lists added inline comments to D59253: [AIX][libcxx] AIX system headers need stdint.h and inttypes.h to be re-enterable when macro _STD_TYPES_T is defined.
May 23 2019, 9:55 AM · Restricted Project, Restricted Project, Restricted Project
mclow.lists added inline comments to D60491: Fix fpos requirements & cleanup .
May 23 2019, 9:21 AM
mclow.lists added a comment to D62228: Make `vector` unconditionally move elements when exceptions are disabled..

I'm not particularly in favor of this patch.
There was a discussion on the mailing list that (to my mind) petered out with no particular conclusion as to whether or not this was a good idea.

Louis and I talked more offline and there was some consensus that this minimal change was more acceptable.
But if there are additional concerns they can be raised here.

I not that fond of -fno-exceptions in general, and I think that special-casing vector here is the wrong approach.
If we really want to embrace this (and I don't), I think we should change move_if_noexcept (and the other noexcept type traits) to return true when exceptions are disabled.

You're proposing a non-standard and non-conforming extension. This change is not an extension. It is a conforming implementation of vector that is better optimized.
This change is orthogonal to the suggested non-conforming extension, and discussion about the extension is better had elsewhere.

May 23 2019, 9:04 AM · Restricted Project
mclow.lists accepted D61828: Throw the proper exception on a regex range error.

LGTM - thanks!
Do you need me to commit this?

May 23 2019, 9:04 AM · Restricted Project
mclow.lists requested changes to D62103: Update shared_ptr tests to match the standard.

I should have flagged this before.

May 23 2019, 8:57 AM
mclow.lists added inline comments to D62103: Update shared_ptr tests to match the standard.
May 23 2019, 8:30 AM