This is an archive of the discontinued LLVM Phabricator instance.

Differential D155774

[NFC] Remove needless nullchecks.
ClosedPublic

Authored by schittir on Jul 19 2023, 8:06 PM.

Details

Reviewers
aaron.ballman
tahonermann
Commits
rG2ce662c5d596: [NFC] Remove needless nullchecks.

Diff Detail

Event Timeline

schittir created this revision.Jul 19 2023, 8:06 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 19 2023, 8:06 PM
schittir requested review of this revision.Jul 19 2023, 8:06 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 19 2023, 8:06 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
aaron.ballman accepted this revision.Jul 20 2023, 11:22 AM

LGTM!

This revision is now accepted and ready to land.Jul 20 2023, 11:22 AM
This revision was landed with ongoing or failed builds.Jul 20 2023, 11:33 PM
Closed by commit rG2ce662c5d596: [NFC] Remove needless nullchecks. (authored by schittir). · Explain Why
This revision was automatically updated to reflect the committed changes.
schittir added a commit: rG2ce662c5d596: [NFC] Remove needless nullchecks..

Revision Contents

PathSize
clang/
lib/
CodeGen/
2 lines
Lex/
2 lines
Sema/
8 lines

Diff 542772

clang/lib/CodeGen/CodeGenModule.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 5,228 Lines • ▼ Show 20 Lines#endif
// CUDA B.2.1 "The __device__ qualifier declares a variable that resides on // CUDA B.2.1 "The __device__ qualifier declares a variable that resides on
// the device. [...]" // the device. [...]"
// CUDA B.2.2 "The __constant__ qualifier, optionally used together with // CUDA B.2.2 "The __constant__ qualifier, optionally used together with
// __device__, declares a variable that: [...] // __device__, declares a variable that: [...]
// Is accessible from all the threads within the grid and from the host // Is accessible from all the threads within the grid and from the host
// through the runtime library (cudaGetSymbolAddress() / cudaGetSymbolSize() // through the runtime library (cudaGetSymbolAddress() / cudaGetSymbolSize()
// / cudaMemcpyToSymbol() / cudaMemcpyFromSymbol())." // / cudaMemcpyToSymbol() / cudaMemcpyFromSymbol())."
if (GV && LangOpts.CUDA) { if (LangOpts.CUDA) {
if (LangOpts.CUDAIsDevice) { if (LangOpts.CUDAIsDevice) {
if (Linkage != llvm::GlobalValue::InternalLinkage && if (Linkage != llvm::GlobalValue::InternalLinkage &&
(D->hasAttr<CUDADeviceAttr>() || D->hasAttr<CUDAConstantAttr>() || (D->hasAttr<CUDADeviceAttr>() || D->hasAttr<CUDAConstantAttr>() ||
D->getType()->isCUDADeviceBuiltinSurfaceType() || D->getType()->isCUDADeviceBuiltinSurfaceType() ||
D->getType()->isCUDADeviceBuiltinTextureType())) D->getType()->isCUDADeviceBuiltinTextureType()))
GV->setExternallyInitialized(true); GV->setExternallyInitialized(true);
} else { } else {
getCUDARuntime().internalizeDeviceSideVar(D, Linkage); getCUDARuntime().internalizeDeviceSideVar(D, Linkage);
▲ Show 20 Lines • Show All 2,232 Lines • Show Last 20 Lines

clang/lib/Lex/ModuleMap.cpp

Show First 20 Lines • Show All 2,469 Lines • ▼ Show 20 Lines else {
Diags.Report(LBraceLoc, diag::note_mmap_lbrace_match); Diags.Report(LBraceLoc, diag::note_mmap_lbrace_match);
HadError = true; HadError = true;
} }
} }
bool NeedsFramework = false; bool NeedsFramework = false;
Map.addUnresolvedHeader(ActiveModule, std::move(Header), NeedsFramework); Map.addUnresolvedHeader(ActiveModule, std::move(Header), NeedsFramework);
if (NeedsFramework && ActiveModule) if (NeedsFramework)
Diags.Report(CurrModuleDeclLoc, diag::note_mmap_add_framework_keyword) Diags.Report(CurrModuleDeclLoc, diag::note_mmap_add_framework_keyword)
<< ActiveModule->getFullModuleName() << ActiveModule->getFullModuleName()
<< FixItHint::CreateReplacement(CurrModuleDeclLoc, "framework module"); << FixItHint::CreateReplacement(CurrModuleDeclLoc, "framework module");
} }
static int compareModuleHeaders(const Module::Header *A, static int compareModuleHeaders(const Module::Header *A,
const Module::Header *B) { const Module::Header *B) {
return A->NameAsWritten.compare(B->NameAsWritten); return A->NameAsWritten.compare(B->NameAsWritten);
▲ Show 20 Lines • Show All 641 Lines • Show Last 20 Lines

clang/lib/Sema/SemaExpr.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 10,920 Lines • ▼ Show 20 Lines if (ScalarTy->isRealFloatingType()) {
ScalarCast = CK_IntegralToFloating; ScalarCast = CK_IntegralToFloating;
} else } else
return true; return true;
} else if (ScalarTy->isEnumeralType()) } else if (ScalarTy->isEnumeralType())
return true; return true;
// Adjust scalar if desired. // Adjust scalar if desired.
if (Scalar) {
if (ScalarCast != CK_NoOp) if (ScalarCast != CK_NoOp)
*Scalar = S.ImpCastExprToType(Scalar->get(), VectorEltTy, ScalarCast); *Scalar = S.ImpCastExprToType(Scalar->get(), VectorEltTy, ScalarCast);
*Scalar = S.ImpCastExprToType(Scalar->get(), VectorTy, CK_VectorSplat); *Scalar = S.ImpCastExprToType(Scalar->get(), VectorTy, CK_VectorSplat);
}
return false; return false;
} }
QualType Sema::CheckVectorOperands(ExprResult &LHS, ExprResult &RHS, QualType Sema::CheckVectorOperands(ExprResult &LHS, ExprResult &RHS,
SourceLocation Loc, bool IsCompAssign, SourceLocation Loc, bool IsCompAssign,
bool AllowBothBool, bool AllowBothBool,
bool AllowBoolConversions, bool AllowBoolConversions,
bool AllowBoolOperation, bool AllowBoolOperation,
▲ Show 20 Lines • Show All 10,813 Lines • Show Last 20 Lines