Page MenuHomePhabricator

schittir (Sindhu Chittireddy)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 4 2021, 4:02 PM (95 w, 5 d)

Recent Activity

Dec 11 2022

schittir updated the diff for D139148: Fix nullptr dereference found by Coverity static analysis tool.

Fix typos

Dec 11 2022, 8:07 PM · Restricted Project, Restricted Project
schittir updated the diff for D139148: Fix nullptr dereference found by Coverity static analysis tool.

Fixed typo. Sorry!

Dec 11 2022, 7:13 PM · Restricted Project, Restricted Project

Dec 9 2022

schittir updated the diff for D139148: Fix nullptr dereference found by Coverity static analysis tool.

Add (Initializer && and assert to else branch per Tom's comments.

Dec 9 2022, 12:56 PM · Restricted Project, Restricted Project

Dec 8 2022

schittir updated the diff for D139148: Fix nullptr dereference found by Coverity static analysis tool.

Add assert at the beginning of blocks pointed out by Coverity

Dec 8 2022, 4:56 PM · Restricted Project, Restricted Project

Dec 6 2022

schittir added a comment to D139148: Fix nullptr dereference found by Coverity static analysis tool.
Dec 6 2022, 4:21 PM · Restricted Project, Restricted Project

Dec 5 2022

schittir added a comment to D139148: Fix nullptr dereference found by Coverity static analysis tool.

When committing changes to address Coverity reported issues, I think it would be useful to include the Coverity analysis in the commit message. A textual representation can be obtained using cov-format-errors --emacs-style from the command line with access to the intermediate directory. I'm not sure if a textual representation can be obtained through the Coverity UI though.

Dec 5 2022, 1:11 PM · Restricted Project, Restricted Project
schittir added a comment to D139148: Fix nullptr dereference found by Coverity static analysis tool.

Perhaps the` assert` should be added after line 5926 above.

Done.

I think the checks for Initializer being non-null following the addition of an assert should be removed.

I don't see any after this point.

Dec 5 2022, 1:09 PM · Restricted Project, Restricted Project
schittir updated the diff for D139148: Fix nullptr dereference found by Coverity static analysis tool.

Move the assert to after the branches that handle the cases where Initializer may be null

Dec 5 2022, 1:07 PM · Restricted Project, Restricted Project

Dec 2 2022

schittir updated the diff for D139148: Fix nullptr dereference found by Coverity static analysis tool.

Add assert instead of multiple checks in if conditions.

Dec 2 2022, 1:28 PM · Restricted Project, Restricted Project
schittir added inline comments to D139148: Fix nullptr dereference found by Coverity static analysis tool.
Dec 2 2022, 12:02 PM · Restricted Project, Restricted Project
schittir updated the diff for D139148: Fix nullptr dereference found by Coverity static analysis tool.

Add more nullptr checks per Shafik's comments

Dec 2 2022, 12:43 AM · Restricted Project, Restricted Project

Dec 1 2022

schittir added a comment to D139148: Fix nullptr dereference found by Coverity static analysis tool.

This looks like the correct thing to do but I see further down there are also unconditional uses of Initializer that should also be guarded with a check. It would be good to fix those as well since we are here.

Yes, it does make sense.

I am guessing the answer is no since this was found using a static analysis tool but do you have a test case that triggers this failure?

Indeed, the answer is no.

Dec 1 2022, 8:23 PM · Restricted Project, Restricted Project
schittir added a reviewer for D139148: Fix nullptr dereference found by Coverity static analysis tool: Restricted Project.
Dec 1 2022, 2:51 PM · Restricted Project, Restricted Project
schittir requested review of D139148: Fix nullptr dereference found by Coverity static analysis tool.
Dec 1 2022, 2:50 PM · Restricted Project, Restricted Project

Dec 15 2021

schittir added a comment to D115320: Avoid setting tbaa information on store of return type of call to inline assember.

I've gone ahead and added the REQUIRES myself.

Dec 15 2021, 9:35 AM · Restricted Project

Dec 14 2021

schittir committed rG4706a297fb9e: Avoid setting tbaa on the store of return type of call to inline assembler. (authored by schittir).
Avoid setting tbaa on the store of return type of call to inline assembler.
Dec 14 2021, 5:46 PM
schittir closed D115320: Avoid setting tbaa information on store of return type of call to inline assember.
Dec 14 2021, 5:45 PM · Restricted Project
schittir updated the diff for D115320: Avoid setting tbaa information on store of return type of call to inline assember.

Change CHECK-LABEL to STORE-LINE-LABEL

Dec 14 2021, 1:17 AM · Restricted Project
schittir updated the diff for D115320: Avoid setting tbaa information on store of return type of call to inline assember.

Rebasing patch to see if the test failure will go away.

Dec 14 2021, 12:56 AM · Restricted Project
schittir added a comment to D115320: Avoid setting tbaa information on store of return type of call to inline assember.

https://reviews.llvm.org/harbormaster/unit/view/1536685/
Test failure seems unrelated to this patch. Unable to reproduce locally.

Dec 14 2021, 12:07 AM · Restricted Project

Dec 13 2021

schittir updated the diff for D115320: Avoid setting tbaa information on store of return type of call to inline assember.

Fix test format

Dec 13 2021, 9:54 AM · Restricted Project
schittir updated the diff for D115320: Avoid setting tbaa information on store of return type of call to inline assember.

Changing test's CHECK lines

Dec 13 2021, 9:50 AM · Restricted Project

Dec 10 2021

schittir updated the diff for D115320: Avoid setting tbaa information on store of return type of call to inline assember.
  1. Removed returnNullTBAA() method
  2. Add NO-TBAA check-prefix to the test
Dec 10 2021, 5:48 PM · Restricted Project

Dec 9 2021

schittir added a comment to D115320: Avoid setting tbaa information on store of return type of call to inline assember.

When I try out the example on llvm-13, I get a 'omnipotent char' tbaa description. That should be ok in general. When I replace the 'float _Complex' with 'double', I do get the 'double' tbaa. That might be a better example for the testcase ?

Dec 9 2021, 11:28 PM · Restricted Project
schittir updated the diff for D115320: Avoid setting tbaa information on store of return type of call to inline assember.

Updated test per Jeroen's suggestion

Dec 9 2021, 11:28 PM · Restricted Project

Dec 8 2021

schittir added reviewers for D115320: Avoid setting tbaa information on store of return type of call to inline assember: andrew.w.kaylor, mikerice.
Dec 8 2021, 11:18 AM · Restricted Project
schittir retitled D115320: Avoid setting tbaa information on store of return type of call to inline assember from Avoid setting tbaa information on return type of call to inline assember to Avoid setting tbaa information on store of return type of call to inline assember.
Dec 8 2021, 11:14 AM · Restricted Project
schittir added a comment to D115320: Avoid setting tbaa information on store of return type of call to inline assember.

Do you have a testcase ?

Dec 8 2021, 11:13 AM · Restricted Project
schittir updated the diff for D115320: Avoid setting tbaa information on store of return type of call to inline assember.

Add test case
Fix formatting

Dec 8 2021, 11:12 AM · Restricted Project

Dec 7 2021

schittir updated subscribers of D115320: Avoid setting tbaa information on store of return type of call to inline assember.
Dec 7 2021, 11:12 PM · Restricted Project
schittir requested review of D115320: Avoid setting tbaa information on store of return type of call to inline assember.
Dec 7 2021, 11:09 PM · Restricted Project

Aug 25 2021

schittir added a comment to D108712: Avoid nullptr dereferencing of 'SubExpr'; NFC.

LGTM! There is no way for this to be null because emitRethrow() is what should be called in that case.

I'll land this on your behalf sometime shortly (perhaps as late as tomorrow).

Aug 25 2021, 11:32 AM · Restricted Project
schittir requested review of D108712: Avoid nullptr dereferencing of 'SubExpr'; NFC.
Aug 25 2021, 10:24 AM · Restricted Project

Aug 23 2021

schittir added a comment to D108481: Avoid nullptr dereferencing of 'Constraint'.

LGTM, thanks for the cleanup! Do you need someone to commit on your behalf? If so, what name and email address would you like me to use for patch attribution?

Aug 23 2021, 1:02 PM · Restricted Project
schittir updated the diff for D108481: Avoid nullptr dereferencing of 'Constraint'.
  1. Removed the useless assert on TC.
  2. Retained the change from cast_or_null to cast
Aug 23 2021, 12:55 PM · Restricted Project

Aug 20 2021

schittir requested review of D108481: Avoid nullptr dereferencing of 'Constraint'.
Aug 20 2021, 12:49 PM · Restricted Project