For more details about this instruction, please refer to the latest ISE document: https://www.intel.com/content/www/us/en/develop/download/intel-architecture-instruction-set-extensions-programming-reference.html
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
clang/lib/Headers/CMakeLists.txt | ||
---|---|---|
208 | alphabetical order | |
llvm/include/llvm/IR/IntrinsicsX86.td | ||
5112 | DefaultAttrsIntrinsic | |
5114 | ditto. | |
5116 | ditto. | |
llvm/test/CodeGen/X86/sha512-intrinsics.ll | ||
3 | X64,CHECK | |
3 | No need O0 | |
4 | X86,CHECK | |
4 | ditto. | |
llvm/test/MC/Disassembler/X86/sha512-64.txt | ||
2–3 | This can be merged with sha512-32.txt | |
llvm/test/MC/X86/sha512-att-64.s | ||
1 ↗ | (On Diff #539826) | ditto. |
llvm/test/MC/X86/sha512-intel-64.s | ||
1 ↗ | (On Diff #539826) | ditto. |
llvm/lib/Target/X86/X86.td | ||
---|---|---|
243 | AVX2 like other integer features? | |
llvm/lib/Target/X86/X86InstrSSE.td | ||
8304 | This paren should be indented 1 more space so that it's not at the same column as the one above it. | |
8310 | ditto | |
8316 | ditto | |
llvm/lib/TargetParser/X86TargetParser.cpp | ||
214 | Unnecessary line break | |
658 | Should this be AVX2 like all the other integer features? |
llvm/lib/Target/X86/X86.td | ||
---|---|---|
243 | ISE says it only requires AVX |
LGTM - but I'd prefer more complete 32-bit vs 64-bit test coverage (similar to the SM3/SM4 patches) if its possible.
alphabetical order