This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Remove overly restrictive assert from negateFMAOpcode.
ClosedPublic

Authored by craig.topper on Jun 6 2023, 11:52 AM.

Details

Summary

It's possible that both multiplicands are being negated. This won't
change the opcode, but we can delete the two negates. Allow this
case to get through negateFMAOpcode.

I think D152260 will also fix this test case, but in the future
it may be possible for an fneg to appear after we've already converted
to RISCVISD opcodes in which case D152260 won't help.

Diff Detail

Event Timeline

craig.topper created this revision.Jun 6 2023, 11:52 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 6 2023, 11:52 AM
craig.topper requested review of this revision.Jun 6 2023, 11:52 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 6 2023, 11:52 AM
This revision is now accepted and ready to land.Jun 6 2023, 4:52 PM