Differential D142068

[CostModel][RISCV] Model code size cost for reduction
ClosedPublic
Actions

Authored by arcbbb on Jan 18 2023, 6:07 PM.

Details

Reviewers

craig.topper
asb
frasercrmck
reames

Commits

rGfb661e255439: [CostModel][RISCV] Model code size cost for reduction

Summary

Since code-size cost doesn't scale linearly with LMUL,
this change is to separate it from throughput.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

arcbbb created this revision.Jan 18 2023, 6:07 PM

Herald added a project: Restricted Project. · View Herald TranscriptJan 18 2023, 6:07 PM

Herald added subscribers: luke, VincentWu, vkmr and 28 others. · View Herald Transcript

arcbbb requested review of this revision.Jan 18 2023, 6:07 PM

Herald added a project: Restricted Project. · View Herald TranscriptJan 18 2023, 6:07 PM

Herald added subscribers: llvm-commits, pcwang-thead, eopXD, MaskRay. · View Herald Transcript

arcbbb added reviewers: craig.topper, asb, frasercrmck, reames.Jan 18 2023, 6:12 PM

Harbormaster completed remote builds in B208631: Diff 490342.Jan 18 2023, 6:58 PM

LGTM w/change applied.

Sorry for the delay, I missed this when first posted.

llvm/lib/Target/RISCV/RISCVTargetTransformInfo.cpp
1021	This should still be LT.first - 1
1054	Same here

This revision is now accepted and ready to land.Fri, Feb 24, 7:44 AM

Address @reames's comments

Update tests

This revision was landed with ongoing or failed builds.Sun, Mar 5, 5:59 PM

Closed by commit rGfb661e255439: [CostModel][RISCV] Model code size cost for reduction (authored by arcbbb). · Explain Why

This revision was automatically updated to reflect the committed changes.

arcbbb added a commit: rGfb661e255439: [CostModel][RISCV] Model code size cost for reduction.

Harbormaster completed remote builds in B217474: Diff 502495.Sun, Mar 5, 6:43 PM

Revision Contents
Changeset List

Path

Size

llvm/

lib/

Target/

RISCV/

RISCVTargetTransformInfo.cpp

8 lines

test/

Analysis/

CostModel/

RISCV/

57 lines

60 lines

67 lines

112 lines

112 lines

60 lines

reduce-scalable-fp.ll

282 lines

reduce-scalable-int.ll

476 lines

reduce-xor.ll

57 lines

Diff 502496

View Options

llvm/lib/Target/RISCV/RISCVTargetTransformInfo.cpp

View Options

llvm/test/Analysis/CostModel/RISCV/reduce-add.ll

View Options

llvm/test/Analysis/CostModel/RISCV/reduce-and.ll

View Options

llvm/test/Analysis/CostModel/RISCV/reduce-fadd.ll

View Options

llvm/test/Analysis/CostModel/RISCV/reduce-max.ll

View Options

llvm/test/Analysis/CostModel/RISCV/reduce-min.ll

View Options

llvm/test/Analysis/CostModel/RISCV/reduce-or.ll

View Options

llvm/test/Analysis/CostModel/RISCV/reduce-scalable-fp.ll

View Options

llvm/test/Analysis/CostModel/RISCV/reduce-scalable-int.ll

View Options

llvm/test/Analysis/CostModel/RISCV/reduce-xor.ll

[CostModel][RISCV] Model code size cost for reductionClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 502496

llvm/lib/Target/RISCV/RISCVTargetTransformInfo.cpp

llvm/test/Analysis/CostModel/RISCV/reduce-add.ll

llvm/test/Analysis/CostModel/RISCV/reduce-and.ll

llvm/test/Analysis/CostModel/RISCV/reduce-fadd.ll

llvm/test/Analysis/CostModel/RISCV/reduce-max.ll

llvm/test/Analysis/CostModel/RISCV/reduce-min.ll

llvm/test/Analysis/CostModel/RISCV/reduce-or.ll

llvm/test/Analysis/CostModel/RISCV/reduce-scalable-fp.ll

llvm/test/Analysis/CostModel/RISCV/reduce-scalable-int.ll

llvm/test/Analysis/CostModel/RISCV/reduce-xor.ll

[CostModel][RISCV] Model code size cost for reduction
ClosedPublic
Actions

Revision Contents
Changeset List