This is an archive of the discontinued LLVM Phabricator instance.

[NFC] Fix "form/from" typos
ClosedPublic

Authored by pfusik on Jan 18 2023, 3:59 AM.

Details

Reviewers
NoQ
ributzka
nicolasvasilache
ldionne
Group Reviewers
Restricted Project
Commits
rG898b5c9f5e77: [NFC] Fix "form/from" typos

Diff Detail

Event Timeline

pfusik created this revision.Jan 18 2023, 3:59 AM
Herald added a reviewer: ributzka. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
pfusik requested review of this revision.Jan 18 2023, 3:59 AM
Herald added projects: Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project. · View Herald Transcript
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.Jan 18 2023, 7:08 AM
ldionne added a subscriber: ldionne.

LGTM, thanks! I don't think you need to wait for other owners to approve before landing this, this is pretty clearly an improvement.

This revision is now accepted and ready to land.Jan 18 2023, 7:08 AM

LGTM, thanks! I don't think you need to wait for other owners to approve before landing this, this is pretty clearly an improvement.

I have no commit access, could you please commit this for me?

@ldionne Can you check it in?

@ldionne Can you check it in?

Can you provide your name and email address to we can attribute the patch to you?

Can you provide your name and email address to we can attribute the patch to you?

Piotr Fusik <fox AT scene.pl>

This revision was landed with ongoing or failed builds.Jan 22 2023, 11:06 AM
Closed by commit rG898b5c9f5e77: [NFC] Fix "form/from" typos (authored by pfusik, committed by Mordante). · Explain Why
This revision was automatically updated to reflect the committed changes.

Thanks for your contribution, I just landed this patch on your behalf.