Page MenuHomePhabricator

labath (Pavel Labath)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 4 2013, 6:02 AM (328 w, 14 h)

Recent Activity

Today

labath added a comment to D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.
In D67390#1672210, @kwk wrote:

So my point of this whole question is: What makes a symbol unique in the sense that it shouldn't be added to the symtab if it is already there?

Tue, Sep 17, 2:38 AM · Restricted Project, Restricted Project
labath accepted D67625: [lldb] [Process/gdb-remote] Fix defaulting signal to invalid in action list.
Tue, Sep 17, 2:26 AM · Restricted Project

Yesterday

labath added a comment to D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.
In D67390#1667270, @kwk wrote:

@labath how shall we go about this? We do have the situation that when you lookup a symbol you might find it twice if it is in .dynsym and in .symtab. Shall I adjust the test expectation to that or change my implementation?

Mon, Sep 16, 2:27 AM · Restricted Project, Restricted Project
labath added a reviewer for D67589: Fix crash on SBCommandReturnObject & assignment: jingham.

+ Jim for SB API.

Mon, Sep 16, 2:01 AM · Restricted Project
labath accepted D66654: 2/2: Process formatters in reverse-chronological order.

lgtm

Mon, Sep 16, 1:32 AM · Restricted Project
labath added a comment to D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans.

Sorry for the delay, I was OOO. I haven't yet read through all of the discussion, but I wanted to plug into this part.

Mon, Sep 16, 1:17 AM · Restricted Project, Restricted Project
labath added a comment to D67472: [Target] Move InferiorCall to Process.

cool

Mon, Sep 16, 12:32 AM · Restricted Project, Restricted Project
labath added a comment to D67523: [Reproducer] Move GDB Remote Packet into Utility. (NFC).

*Maybe* this is fine for now, but I also don't like moving the gdb-remote reproducer stuff out of the gdb plugin. If you want an inspection command to access those (which sounds like a useful thing btw), then the right way to handle that would be to have some sort of an abstraction/plugin mechanism for various reproducers. For instance, the reproducers could register themselves somewhere (if they don't do that already), so we get a list of all of them, similar to how we handle "plugins" now. Then the inspection command could iterate over that list and ask each reproducer component to do its thing. This may be clunky, or it may not, depending on what exactly this "thing" is.

Mon, Sep 16, 12:31 AM · Restricted Project, Restricted Project
labath added a comment to D67520: Add pretty printing of Clang "bitfield" enums.

This looks like a really useful feature. The code seems fine, but I am wondering if we should really bail out when encountering a zero enumerator. It is not uncommon to use a special enumerator to mean "none of the above". Lldb does that occasionally (eEmulateInstructionOptionNone), and other APIs do that too (PROT_NONE, PROT_READ, PROT_WRITE, PROT_EXEC in mmap(2) for instance). I am guessing this practice is even more common for "class" enums, as those can't be implicitly constructed from integer constants.

Mon, Sep 16, 12:18 AM

Sun, Sep 15

labath added inline comments to D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect..
Sun, Sep 15, 11:48 PM · Restricted Project, Restricted Project

Wed, Sep 11

labath accepted D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect..

This looks great now. Thank you for your patience. Just make sure to deal with the breakages from the other patch first. If the fix is non trivial, or if it's going to take a while, then please revert to unbreak the bots.

Wed, Sep 11, 6:15 AM · Restricted Project, Restricted Project
labath added inline comments to D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.
Wed, Sep 11, 6:06 AM · Restricted Project, Restricted Project
labath added a comment to D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.

It broke on linux too. You did run the tests before committing, did you?

Wed, Sep 11, 6:02 AM · Restricted Project, Restricted Project
labath added inline comments to D67376: [DWARF] Evaluate DW_OP_entry_value.
Wed, Sep 11, 5:56 AM · Restricted Project
labath added a comment to D67369: Implement DW_OP_convert.

The yaml object file is pretty impressive, but I am wondering if it is really necessary. Have you looked if it would be possible to reuse the existing TestFile::fromYaml functionality? I think it should be possible to reuse that by just inserting some MachO yaml blurbs around the dwarf yaml (elf yaml2obj doesn't support embedding dwarf yaml, but that's just because nobody enabled that yet).

Wed, Sep 11, 5:48 AM · Restricted Project, Restricted Project
labath added a comment to D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans.

It's a good point, thank you! I had the same thoughts when I done it, but I'm not completely sure. The problem is that an object file can't be completely responsible for choosing an unwind plan, because some plans are produced by symbol files (and an object file knows nothing about that, if I understand right). So we can move only a part of the plan-choosing-functionality from FuncUnwinders to ObjectFiles, but will it be better? In that case both FuncUnwinders and ObjectFiles will be responsible for managing plans, won't it add an additional complexity to the solution?

Wed, Sep 11, 5:36 AM · Restricted Project, Restricted Project
labath accepted D67022: Enhance SymbolFileDWARF::ParseDeclsForContext performance.

looks fine to me

Wed, Sep 11, 2:42 AM · Restricted Project
labath accepted D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.

lgtm. The reason I requested this to be put separately, is because it is implemented in a way that kicks in even without minidebuginfo. I think this is fine, because entries can be removed from the symtab even without the whole minidebuginfo business. While this format will likely be the only real user of these partial symtabs, in theory, there isn't anything stopping someone from removing symtab entries independently of that. While unlikely, I see no harm in supporting that, if it does not incur any extra maintenance costs.

Wed, Sep 11, 2:33 AM · Restricted Project, Restricted Project
labath added a comment to D67343: [DebugInfo] Change object::RelocationResolver to return Expected<uint64_t>.

I believe error handling is important. And even more important is testing of that error handling -- as I'm trying to use llvm dwarf parser in lldb I keep finding new ways to crash it with invalid input.

Wed, Sep 11, 2:06 AM · Restricted Project
labath accepted D66654: 2/2: Process formatters in reverse-chronological order.

I think this looks great. Some operations may get less efficient with this, but OTOH, some will get actually faster. And it is definitely the most understandable solution out of everything we had so far.

Wed, Sep 11, 1:10 AM · Restricted Project
labath added a comment to D67230: Remove call to obsolete gethostbyname, using getaddrinfo.

@davezarzycki I tend to agree with you. We can just remove 35:44 and just keep the hostname.

Wed, Sep 11, 12:52 AM · Restricted Project, Restricted Project

Fri, Sep 6

labath added a comment to D65677: [VirtualFileSystem] Make the RedirectingFileSystem hold on to its own working directory..

Thanks Jonas. This looks fine to me, but someone who actually works on VFS (/me looks at @sammccall) will need to ack that.

Fri, Sep 6, 5:36 AM · Restricted Project, Restricted Project
labath updated the diff for D66638: Unwind: Add a stack scanning mechanism to support win32 unwinding.
  • s/FoundHeuristically/RaSearch
  • max_iterations:=256
  • tweak the handling of "own frame size" instead of having the unwinder ask for it, it is now embedded directly into the unwind plan. This automatically makes it possible to have different frame sizes at different points in the function, and also reduces the api surface a bit. The "parameter size" is still in a separate function, because that belongs to a different frame/function/module.
Fri, Sep 6, 5:29 AM · Restricted Project
labath added inline comments to D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect..
Fri, Sep 6, 5:21 AM · Restricted Project, Restricted Project
labath added inline comments to D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect..
Fri, Sep 6, 4:55 AM · Restricted Project, Restricted Project
labath added a comment to D66638: Unwind: Add a stack scanning mechanism to support win32 unwinding.

Thanks for the quick reply. My responses are inline:

Fri, Sep 6, 4:19 AM · Restricted Project
labath added a comment to D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect..

Thank you for adding the tests, and for adding the xz detection to lit in particular. We're getting _reaally_ close now. I have a bunch more comments, including highlighting some you seems to have missed from earlier, but they are all just about polishing. The only somewhat larger comment is about the minidebuginfo-set-and-hit-breakpoint.test test. I'd like to understand what exactly is the scenario you are intending to test there, because I have a feeling it's not testing what you want it to test...

Fri, Sep 6, 2:49 AM · Restricted Project, Restricted Project
labath removed projects from D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.: Restricted Project, Restricted Project, Restricted Project, Restricted Project.
Fri, Sep 6, 2:25 AM · Restricted Project, Restricted Project
labath removed reviewers for D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.: martong, shafik, rupprecht, jdoerfert, jhenderson.
Fri, Sep 6, 2:22 AM · Restricted Project, Restricted Project
labath accepted D67230: Remove call to obsolete gethostbyname, using getaddrinfo.

Sounds like a good idea, particularly as gethostbyname is not thread safe. It seems getaddrinfo is already used in lldb, so it should be supported by all OSs that we care about.

Fri, Sep 6, 1:46 AM · Restricted Project, Restricted Project

Thu, Sep 5

labath added a comment to D67022: Enhance SymbolFileDWARF::ParseDeclsForContext performance.

Thanks. The code looks fine to me. Losing the ability to unit test is a bit of a pity, but since test was pretty icky to begin with, I can't say I'm going to miss it too much...
One way we could possibly test this is with a full scale test via the "target modules dump ast" command. So, the idea would be to run to process to some point, evaluate some expressions, run "target modules dump ast" and check the things are in the output (or that they are *not* there).

Thu, Sep 5, 4:56 AM · Restricted Project
labath retitled D66638: Unwind: Add a stack scanning mechanism to support win32 unwinding from WIP/Breakpad: Add support for stack unwinding on windows to Unwind: Add a stack scanning mechanism to support win32 unwinding.
Thu, Sep 5, 4:35 AM · Restricted Project
labath updated the diff for D66638: Unwind: Add a stack scanning mechanism to support win32 unwinding.

Rebase on master. Should be ready for review now.

Thu, Sep 5, 4:29 AM · Restricted Project
labath added a comment to D67090: [llvm-objcopy][llvm-strip] Support --only-keep-debug.

Thanks for working on it. Have you tested if Linux perf can symbolize the perf traces using the split debug files especially with large binaries?

Meanwhile, I'll try the patch on Chrome OS to verify that gdb and perf still work.

I've learned that @manojgupta actually has a different use case: symbolization without requiring access to the stripped binary.

Thu, Sep 5, 4:05 AM · Restricted Project
labath added a comment to D66994: [lldb][CMake] Fix windows-x86-debug compilation with python enabled using multi-target generator.

Thanks. The new version seems fine to me. I'll leave it for the windows folks to have the final say on this..

Thu, Sep 5, 3:56 AM · Restricted Project, Restricted Project
labath committed rG35dfb2e8d748: [dotest] Remove top-level Makefile (authored by labath).
[dotest] Remove top-level Makefile
Thu, Sep 5, 12:38 AM
labath committed rL371020: [dotest] Remove top-level Makefile.
[dotest] Remove top-level Makefile
Thu, Sep 5, 12:38 AM
labath committed rG45e3ce8d7653: [dotest] Centralize initialization commands even more (authored by labath).
[dotest] Centralize initialization commands even more
Thu, Sep 5, 12:38 AM
labath committed rL371019: [dotest] Centralize initialization commands even more.
[dotest] Centralize initialization commands even more
Thu, Sep 5, 12:35 AM
labath closed D67173: [dotest] Centralize initialization commands even more.
Thu, Sep 5, 12:35 AM · Restricted Project
labath added inline comments to D67173: [dotest] Centralize initialization commands even more.
Thu, Sep 5, 12:31 AM · Restricted Project
labath added a comment to D65677: [VirtualFileSystem] Make the RedirectingFileSystem hold on to its own working directory..

Though I am not very familiar VFS, this seems like the most intuitive solution out of everything that we had so far. But... shouldn't you also check that the directory you're chdir-ing into "exists" before you actually change the cwd? Also, the chdir operation should probably follow the usual semantics of a non-absolute chdir path being treated as relative to the previous cwd. And lastly :), what is the initial cwd value? Since previously the class shared the cwd with the underlying filesystem, one option might be to fetch the initial cwd from there (though I don't know if that is actually desired). Another option might be to just pick the first directory in the yaml file or something...

Thu, Sep 5, 12:26 AM · Restricted Project, Restricted Project
labath committed rG7790858b00de: Obliterate LLDB_CONFIGURATION_BUILDANDINTEGRATION (authored by labath).
Obliterate LLDB_CONFIGURATION_BUILDANDINTEGRATION
Thu, Sep 5, 12:11 AM
labath committed rL371018: Obliterate LLDB_CONFIGURATION_BUILDANDINTEGRATION.
Obliterate LLDB_CONFIGURATION_BUILDANDINTEGRATION
Thu, Sep 5, 12:11 AM
labath closed D66742: Obliterate LLDB_CONFIGURATION_BUILDANDINTEGRATION.
Thu, Sep 5, 12:11 AM · Restricted Project
labath committed rGc3bea40bf751: Breakpad: Basic support for STACK WIN unwinding (authored by labath).
Breakpad: Basic support for STACK WIN unwinding
Thu, Sep 5, 12:05 AM
labath committed rL371017: Breakpad: Basic support for STACK WIN unwinding.
Breakpad: Basic support for STACK WIN unwinding
Thu, Sep 5, 12:05 AM
labath closed D67067: Breakpad: Basic support for STACK WIN unwinding.
Thu, Sep 5, 12:05 AM · Restricted Project
labath added inline comments to D67067: Breakpad: Basic support for STACK WIN unwinding.
Thu, Sep 5, 12:05 AM · Restricted Project

Wed, Sep 4

labath committed rG59a1d998d97d: [dotest] Delete trivial inline test makefiles (authored by labath).
[dotest] Delete trivial inline test makefiles
Wed, Sep 4, 11:56 PM
labath committed rL371015: [dotest] Delete trivial inline test makefiles.
[dotest] Delete trivial inline test makefiles
Wed, Sep 4, 11:56 PM
labath added inline comments to D67168: [Windows] Add support of watchpoints to `ProcessWindows`.
Wed, Sep 4, 11:22 PM · Restricted Project, Restricted Project
labath added a comment to D67022: Enhance SymbolFileDWARF::ParseDeclsForContext performance.

Great idea, but this idea gave me the idea to use "m_decl_ctx_to_die" as is, and just remove the entry once we have parse all decls. Then we free the memory and don't need a bit. If there is no entry in the m_decl_ctx_to_die map, then ForEachDIEInDeclContext will just not iterate at all?

Wed, Sep 4, 11:21 AM · Restricted Project
labath created D67173: [dotest] Centralize initialization commands even more.
Wed, Sep 4, 7:30 AM · Restricted Project
labath added a comment to D67090: [llvm-objcopy][llvm-strip] Support --only-keep-debug.

@labath to confirm whether it works on lldb if the separate debug file (created by --only-keep-debug) has no program header.

I played with some executable and it appears to work.

Wed, Sep 4, 6:49 AM · Restricted Project
labath committed rG052297524624: disassemble command: fix error message when disassembly fails (authored by labath).
disassemble command: fix error message when disassembly fails
Wed, Sep 4, 6:27 AM
labath committed rL370898: disassemble command: fix error message when disassembly fails.
disassemble command: fix error message when disassembly fails
Wed, Sep 4, 6:25 AM
labath created D67154: MCRegisterInfo: Merge getLLVMRegNum and getLLVMRegNumFromEH.
Wed, Sep 4, 5:06 AM · Restricted Project
labath committed rG98634c2e11d8: Fix address sizes in the dwarfdump-debug-loc-error-cases test (authored by labath).
Fix address sizes in the dwarfdump-debug-loc-error-cases test
Wed, Sep 4, 4:48 AM
labath committed rL370882: Fix address sizes in the dwarfdump-debug-loc-error-cases test.
Fix address sizes in the dwarfdump-debug-loc-error-cases test
Wed, Sep 4, 4:46 AM
labath added a comment to D66742: Obliterate LLDB_CONFIGURATION_BUILDANDINTEGRATION.

Any thoughts on this one?

Wed, Sep 4, 3:58 AM · Restricted Project
labath added a comment to D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect..

I think we're getting pretty close. I have a couple of extra comments inline, but they're all pretty minor, I hope. I'd just like to add some more tests, per our discussion on the IRC, and I have some doubts about what exactly is the test you've written actually testing, which I'd like to clarify...

Wed, Sep 4, 3:55 AM · Restricted Project, Restricted Project
labath committed rG88b4e28a679a: DWARF: Fix a regression in location list dumping (authored by labath).
DWARF: Fix a regression in location list dumping
Wed, Sep 4, 3:09 AM
labath committed rL370868: DWARF: Fix a regression in location list dumping.
DWARF: Fix a regression in location list dumping
Wed, Sep 4, 3:07 AM
labath closed D67102: DWARF: Fix a regression in location list dumping.
Wed, Sep 4, 3:07 AM · Restricted Project
labath committed rG84542187ee8c: Port TestBatchMode to PExpectTest class (authored by labath).
Port TestBatchMode to PExpectTest class
Wed, Sep 4, 2:20 AM
labath committed rL370858: Port TestBatchMode to PExpectTest class.
Port TestBatchMode to PExpectTest class
Wed, Sep 4, 2:20 AM
labath closed D67082: Port TestBatchMode to PExpectTest class.
Wed, Sep 4, 2:20 AM · Restricted Project
labath added a comment to D67067: Breakpad: Basic support for STACK WIN unwinding.

We always need more tests. I've now added more tests for various boundary conditions.

Wed, Sep 4, 1:53 AM · Restricted Project
labath updated the diff for D67067: Breakpad: Basic support for STACK WIN unwinding.

add more tests

Wed, Sep 4, 1:53 AM · Restricted Project
labath accepted D67123: [lldb] Early exit in RangeDataVector:FindEntryIndexesThatContain.

lgtm

Wed, Sep 4, 1:00 AM · Restricted Project, Restricted Project
labath committed rL370845: [dotest] Avoid the need for LEVEL= makefile boilerplate.
[dotest] Avoid the need for LEVEL= makefile boilerplate
Wed, Sep 4, 12:54 AM
labath committed rG418a272f4ab4: [dotest] Avoid the need for LEVEL= makefile boilerplate (authored by labath).
[dotest] Avoid the need for LEVEL= makefile boilerplate
Wed, Sep 4, 12:50 AM
labath closed D67083: [dotest] Avoid the need for LEVEL= makefile boilerplate.
Wed, Sep 4, 12:48 AM · Restricted Project
labath added inline comments to D67083: [dotest] Avoid the need for LEVEL= makefile boilerplate.
Wed, Sep 4, 12:25 AM · Restricted Project
labath added a comment to D67022: Enhance SymbolFileDWARF::ParseDeclsForContext performance.

Thanks for the clarification Greg.

Wed, Sep 4, 12:14 AM · Restricted Project

Tue, Sep 3

labath added a comment to D67123: [lldb] Early exit in RangeDataVector:FindEntryIndexesThatContain.

I remember seeing this inefficiency when looking at this class some time ago, but it was not clear to me what should be done about that. This is still an improvement, as it will reduce the time by 50% on average, but it is still going to be O(n). If this is really a performance bottleneck, then we will need to come up with some better data structure for storing this, or put some restrictions on the kind of entries that we can have in the map...

Tue, Sep 3, 11:39 PM · Restricted Project, Restricted Project
labath committed rL370787: Pass -DLLDB_DISABLE_CURSES to the lldb-x86_64-debian bot.
Pass -DLLDB_DISABLE_CURSES to the lldb-x86_64-debian bot
Tue, Sep 3, 10:16 AM
labath closed D67075: Pass -DLLDB_DISABLE_CURSES to the lldb-x86_64-debian bot.
Tue, Sep 3, 10:16 AM · Restricted Project
labath accepted D67099: [zorg] [LLDB] Add lldb-s390x-fedora, lldb-ppc64le-fedora.

Looks fine to me. I believe these bots will be a very useful addition. I have one random idea you can consider if you'd like: I believe there is a way to mark (I think it involves setting flunkOnFailure=False) a particular step so that it is still run, but it does not fail the overall build. That way, you might be able to mark these bots "stable" and get breakage notifications if the build breaks, but still leave open the possibility for manual inspection of test results.

Tue, Sep 3, 10:00 AM · Restricted Project
labath added inline comments to D67083: [dotest] Avoid the need for LEVEL= makefile boilerplate.
Tue, Sep 3, 9:51 AM · Restricted Project
labath created D67102: DWARF: Fix a regression in location list dumping.
Tue, Sep 3, 8:14 AM · Restricted Project
labath edited reviewers for D67083: [dotest] Avoid the need for LEVEL= makefile boilerplate, added: JDevlieghere; removed: espindola, jfb.
Tue, Sep 3, 12:14 AM · Restricted Project

Mon, Sep 2

labath created D67083: [dotest] Avoid the need for LEVEL= makefile boilerplate.
Mon, Sep 2, 10:43 AM · Restricted Project
labath created D67082: Port TestBatchMode to PExpectTest class.
Mon, Sep 2, 10:14 AM · Restricted Project
labath added inline comments to D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect..
Mon, Sep 2, 10:09 AM · Restricted Project, Restricted Project
labath added a comment to D67022: Enhance SymbolFileDWARF::ParseDeclsForContext performance.

I am not very familiar with this code, but I don't see a reason why what you're doing could not work. However, it looks like the implementation of it could be done in a better way. For instance, this function seems to be the only caller of GetDIEForDeclContext. So, we could replace it with something like ast_parser->ParseAllDiesForContext(decl_ctx). This would avoid materializing the std::vector, and the ast parser could store the list of processed dies in a more intelligent (memory friendly) fashion.

Mon, Sep 2, 7:08 AM · Restricted Project
labath added a comment to D66654: 2/2: Process formatters in reverse-chronological order.

Hm... "summarizing" might not have been the best word here. I have "summarized" what *I* said over IRC, but I did not mean to imply that Jan agreed with my position (and he didn't, not yet anyway..)

Mon, Sep 2, 6:42 AM · Restricted Project
labath added a comment to D66654: 2/2: Process formatters in reverse-chronological order.

Summarizing our discussion on IRC:
While I think that this version of the patch is definitely better than the previous ones, I still feel that the two container solution is unnecessarily complicated. I think using llvm::MapVector or even std::vector would be sufficient. While this may be optimal in terms of performance (not memory), I don't think that is really important in this case. The only place where the std::list solution is better than a std::vector is the removal of an arbitrary element in the list. However, I would stipulate that this is a very uncommon operation. The most common operations are lookup (which are linear in any case), and insertion (constant).

Mon, Sep 2, 6:39 AM · Restricted Project
labath committed rGeafede2afeb4: [dotest] Add @skipIfCursesSupportMissing and annotate the new gui test (authored by labath).
[dotest] Add @skipIfCursesSupportMissing and annotate the new gui test
Mon, Sep 2, 6:33 AM
labath committed rL370658: [dotest] Add @skipIfCursesSupportMissing and annotate the new gui test.
[dotest] Add @skipIfCursesSupportMissing and annotate the new gui test
Mon, Sep 2, 6:32 AM
labath closed D67073: [dotest] Add @skipIfCursesSupportMissing and annotate the new gui test.
Mon, Sep 2, 6:32 AM · Restricted Project
labath accepted D67049: 1/2: Code cleanup: Change FormattersContainer::KeyType from SP to rvalue.
Mon, Sep 2, 5:57 AM · Restricted Project, Restricted Project
labath updated the diff for D67073: [dotest] Add @skipIfCursesSupportMissing and annotate the new gui test.

Rename the function to _get_bool_config_skip_if_decorator

Mon, Sep 2, 5:51 AM · Restricted Project
labath committed rG3f3673ead99c: NativeProcessLinux: Remove some register context boilerplate (authored by labath).
NativeProcessLinux: Remove some register context boilerplate
Mon, Sep 2, 5:50 AM
labath committed rL370653: NativeProcessLinux: Remove some register context boilerplate.
NativeProcessLinux: Remove some register context boilerplate
Mon, Sep 2, 5:49 AM
labath closed D66744: NativeProcessLinux: Remove some register context boilerplate.
Mon, Sep 2, 5:49 AM · Restricted Project
labath added inline comments to D67073: [dotest] Add @skipIfCursesSupportMissing and annotate the new gui test.
Mon, Sep 2, 5:41 AM · Restricted Project
labath created D67075: Pass -DLLDB_DISABLE_CURSES to the lldb-x86_64-debian bot.
Mon, Sep 2, 5:30 AM · Restricted Project
labath created D67073: [dotest] Add @skipIfCursesSupportMissing and annotate the new gui test.
Mon, Sep 2, 5:27 AM · Restricted Project