labath (Pavel Labath)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 4 2013, 6:02 AM (202 w, 6 d)

Recent Activity

Today

labath updated the diff for D32441: Remove the home-grown android toolchain file and all references to it.

Address Tamas's comments.

Tue, Apr 25, 12:53 AM
labath added inline comments to D32441: Remove the home-grown android toolchain file and all references to it.
Tue, Apr 25, 12:53 AM

Yesterday

labath added a comment to D32434: ObjectFileELF: Fix symbol lookup in bss section.

We don't support running the test suite on Windows with MSVC. We run it
with clang targeting windows instead. So anyone running the test suite on
Windows is already using clang, and we can just specify a linux triple to
get an ELF binary.

Mon, Apr 24, 3:09 PM
labath added a comment to D32434: ObjectFileELF: Fix symbol lookup in bss section.

Is it really necessary to check in binary ELF files?
I understand that we don't always have a C compiler capable of producing ELF files, but maybe it's ok to skip this test on those platforms.

Mon, Apr 24, 2:29 PM
labath created D32441: Remove the home-grown android toolchain file and all references to it.
Mon, Apr 24, 10:12 AM
labath committed rL301186: Update two android XFAILS.
Update two android XFAILS
Mon, Apr 24, 8:36 AM
labath created D32434: ObjectFileELF: Fix symbol lookup in bss section.
Mon, Apr 24, 7:48 AM
labath committed rL301179: Fix the new SocketAddressTest on Windows.
Fix the new SocketAddressTest on Windows
Mon, Apr 24, 6:47 AM
labath added a comment to D32366: Set "success" status correctly.

Thanks for the patch. Could you please also add an appropriate test for it? Doing something similar to what packages/Python/lldbsuite/test/functionalities/frame_var/TestFrameVar.py does should be the easiest way to test this.

Mon, Apr 24, 3:43 AM · Restricted Project
labath committed rL301168: Add more arguments to SocketAddress::GetAddressInfo.
Add more arguments to SocketAddress::GetAddressInfo
Mon, Apr 24, 3:02 AM
labath closed D32357: Add more arguments to SocketAddress::GetAddressInfo by committing rL301168: Add more arguments to SocketAddress::GetAddressInfo.
Mon, Apr 24, 3:02 AM

Fri, Apr 21

labath created D32357: Add more arguments to SocketAddress::GetAddressInfo.
Fri, Apr 21, 9:41 AM
labath accepted D32340: [LLDB][MIPS] Fix TestMiExec.py failure.

sounds reasonable

Fri, Apr 21, 2:10 AM
labath added a comment to D32022: Fix backtrace of noreturn functions situated at the end of a module.

Thank you for looking at this. My response is below.

Fri, Apr 21, 2:04 AM
labath accepted D32306: Remove lock from ConstString::GetLength.

Looks good, thank you.

Fri, Apr 21, 1:36 AM

Thu, Apr 20

labath created D32295: [RFC] Fix crash in expression evaluation.
Thu, Apr 20, 7:24 AM
labath added a comment to D32022: Fix backtrace of noreturn functions situated at the end of a module.

Jim, Jason, could one of you take a look at this please?

Thu, Apr 20, 6:52 AM
labath resigned from D24013: Removed the `GetStringRef()` functions of `StringExtractor`.
Thu, Apr 20, 6:15 AM
labath resigned from D18481: Add argument to expectedFailureAll decorator to xfail for environment variables, and xfail tests for hard float abi and -mthumb on android arm.
Thu, Apr 20, 6:13 AM
labath resigned from D17716: Add complex and aggregate with vector types return value test cases.
Thu, Apr 20, 6:13 AM
labath added a comment to D32149: Correct handling NetBSD core(5) files with threads.

A test would infinitely times more valuable then a demo script. What is the tiniest core file you can produce on NetBSD? (on linux we've gotten them down to about 20K) Then we could check that in and write a test for it...

This is something I wanted to bring to the dev mailing list.

I wanted to prepare at least three tests, if possible four:

  • one thread (if possible two variations: signal to one particular thread + signal to all threads)
  • multiple threads (signal to one particular thread + signal to all threads)

    And this in combination of all supported targets (x86_64, i386, etc).

    Emitting SIGABRT for such program gives core of size 97kilobytes:

    ` int main(){for(;;);} `

    I will write assembly programs for the above cases, without libc.
Thu, Apr 20, 6:09 AM · Restricted Project
labath committed rL300836: Recompute ArchSpec core after MergeFrom.
Recompute ArchSpec core after MergeFrom
Thu, Apr 20, 5:45 AM
labath committed rL300837: Skip TestLibCxxAtomic with gcc.
Skip TestLibCxxAtomic with gcc
Thu, Apr 20, 5:45 AM
labath closed D32221: Recompute ArchSpec core after MergeFrom by committing rL300836: Recompute ArchSpec core after MergeFrom.
Thu, Apr 20, 5:45 AM
labath committed rL300834: Make TestStaticVariables XFAIL more specific.
Make TestStaticVariables XFAIL more specific
Thu, Apr 20, 4:41 AM
labath committed rL300833: Add libc++ category the three more tests.
Add libc++ category the three more tests
Thu, Apr 20, 4:41 AM
labath added a comment to D32149: Correct handling NetBSD core(5) files with threads.

A test would infinitely times more valuable then a demo script. What is the tiniest core file you can produce on NetBSD? (on linux we've gotten them down to about 20K) Then we could check that in and write a test for it...

Thu, Apr 20, 4:07 AM · Restricted Project
labath added a comment to D32137: [Utility] Placate another GCC warning.

Thanks for digging into this, I've learned something new today. Fixing this with a cast seems reasonable then.

Thu, Apr 20, 1:59 AM
labath updated subscribers of D32271: Patch to Attach pid successfully from different dir.
Thu, Apr 20, 1:55 AM
labath added a reviewer for D32271: Patch to Attach pid successfully from different dir: emaste.
Thu, Apr 20, 1:55 AM

Wed, Apr 19

labath accepted D32184: Teach RenderScriptRuntime about changed context representation..

lgtm. You might consider using llvm::formatv instead of the raw snprintf -- it would make the PRIx64 macros more readable.

Wed, Apr 19, 5:39 AM
labath updated the diff for D32221: Recompute ArchSpec core after MergeFrom.

Also remove the skipIfDarwin decorators, as they should work now -- there was
nothing darwin-specific about them, just our bots don't run assert builds at the
moment.

Wed, Apr 19, 5:34 AM
labath created D32221: Recompute ArchSpec core after MergeFrom.
Wed, Apr 19, 5:30 AM
labath requested changes to D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5.

This is the list I am getting when using ToT clang targetting x86_64 linux.

Wed, Apr 19, 3:57 AM
labath added a comment to D31823: Update LLDB Host to support IPv6 over TCP.

It looks like you had a fun day yesterday. :) Unfortunately, I have to add to your problems, as I've had to revert your commit due to a fairly big problem.

Wed, Apr 19, 3:46 AM
labath committed rL300669: Revert yesterdays IPv6 patches.
Revert yesterdays IPv6 patches
Wed, Apr 19, 3:26 AM
labath committed rL300670: Fix TestRegisterVariables for clang/arm.
Fix TestRegisterVariables for clang/arm
Wed, Apr 19, 3:26 AM

Tue, Apr 18

labath added a comment to D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5.

Yeah, I was having trouble getting a real read on what was failing due to a non Ubuntu setup at work for me. Is there any way to run a patch on one of the buildbots? If not, can you email me the list of what is failing?

Tue, Apr 18, 1:18 PM
labath added a comment to D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5.

The new tests which are not passing need to be disabled -- we cannot have a red tree while this is being developed.

Tue, Apr 18, 10:17 AM
labath added a comment to D32137: [Utility] Placate another GCC warning.

I am confused. m_registers_count is declared as uint8_t at RegisterContextPOSIX_mips64.h:67...

Tue, Apr 18, 3:52 AM
labath accepted D32080: Introduce FPR and Debug Registers/NetBSD/amd64 support.

lgtm

Tue, Apr 18, 2:53 AM · Restricted Project

Sat, Apr 15

labath accepted D31823: Update LLDB Host to support IPv6 over TCP.

Thank you for taking the time to do this.

Sat, Apr 15, 8:06 AM
labath accepted D32087: Modify GDBRemoteCommunication::ScopedTimeout to not ever decrease a timeout.

looks good, thank you.

Sat, Apr 15, 3:34 AM

Thu, Apr 13

labath created D32022: Fix backtrace of noreturn functions situated at the end of a module.
Thu, Apr 13, 8:51 AM

Wed, Apr 12

labath committed rL300054: Add libc++ category to the remaining libc++ data formatters.
Add libc++ category to the remaining libc++ data formatters
Wed, Apr 12, 5:45 AM
labath committed rL300048: Fix TestCppIncompleteTypes for android/clang.
Fix TestCppIncompleteTypes for android/clang
Wed, Apr 12, 4:12 AM
labath committed rL300047: Fix libc++ vector<bool> data formatter (bug #32553).
Fix libc++ vector<bool> data formatter (bug #32553)
Wed, Apr 12, 4:12 AM
labath closed D31880: Fix libc++ vector<bool> data formatter (bug #32553) by committing rL300047: Fix libc++ vector<bool> data formatter (bug #32553).
Wed, Apr 12, 4:12 AM
labath added a comment to D31823: Update LLDB Host to support IPv6 over TCP.

@labath, I could adapt this into the MainLoop class, but I would actually want to change how that class hierarchy is implemented. Regardless of the event handling/polling model you use much of the code is identical between the classes. I'd rather get rid of MainLoopPosix and MainLoopBase and instead just implement a portable MainLoop class.

In particular the difference between Windows WSAPoll and posix poll(2) is the name of two functions, which makes the idea of having separate Windows and Posix implementations just seem overly complicated to me, although neither Darwin nor Windows have ppoll because it isn't POSIX, and Windows doesn't have pselect, so there isn't a remotely portable way to wait on file descriptors and signals... This is why we can't have nice things.

One extra thing you should be aware of is that unlike poll(2), WSAPoll only works on sockets. We currently have pieces of code ifdef-ed out on windows because we have no way to wait on pipes, and eventually I'd like to teach the MainLoop to do that as well. I'm not saying we should do that now, just pointing out that the implementations are likely to diverge in the future.

Wed, Apr 12, 3:54 AM
labath accepted D31969: [CMake] Support generating Config.h.

Thank you very much. I am soo happy that these files are going away.

Wed, Apr 12, 3:38 AM
labath committed rL300046: Fix TestGuessLanguage for gcc.
Fix TestGuessLanguage for gcc
Wed, Apr 12, 3:26 AM
labath committed rL300045: Android.rules: setup correct objcopy path.
Android.rules: setup correct objcopy path
Wed, Apr 12, 3:26 AM

Tue, Apr 11

labath updated the diff for D31880: Fix libc++ vector<bool> data formatter (bug #32553).

Address review comments.

Tue, Apr 11, 5:57 AM
labath added inline comments to D31880: Fix libc++ vector<bool> data formatter (bug #32553).
Tue, Apr 11, 5:50 AM
labath accepted D31357: Support Unit Testing debugserver.

This is fine, as far as i am concerned.

Tue, Apr 11, 5:44 AM
labath committed rL299934: Add missing annotation to TestDataFormatterUnordered.
Add missing annotation to TestDataFormatterUnordered
Tue, Apr 11, 5:39 AM
labath committed rL299933: Remove Plugins/Process/POSIX from include_directories.
Remove Plugins/Process/POSIX from include_directories
Tue, Apr 11, 5:39 AM
labath closed D31877: Remove Plugins/Process/POSIX from include_directories by committing rL299933: Remove Plugins/Process/POSIX from include_directories.
Tue, Apr 11, 5:39 AM
labath added a comment to D31823: Update LLDB Host to support IPv6 over TCP.

When I created the MainLoop class, i was hoping it would become the central place for all select-like functionality. Currently it uses pselect, but i don't see a reason we couldn't switch it to ppoll (but we actually don't have to, as the current implementation should work just fine for your use case). We also can-but-don't-have-to provide a specialized kevent-based implementation for mac&freebsd (afaict, kevent also supports listening for signals, but i would be fine with leaving that out even, as we don't need that functionality on these platforms). So all that needs to be added is a WSAPoll-based MainLoopWindows.

Tue, Apr 11, 5:19 AM
labath requested changes to D31825: Fix loading core(5) files from NetBSD 7.99.67.

This makes all sorts of tests fail. Regardless of your platform you should at least be able to reproduce the following failures:

FAIL: test_FPR_SSE (functionalities/postmortem/elf-core/TestLinuxCore.py)
FAIL: test_image_list_shows_multiple_architectures (functionalities/object-file/TestImageListMultiArchitecture.py)
FAIL: test_local_variables_in_minidump (functionalities/postmortem/minidump-new/TestMiniDumpNew.py)
ERROR: test_deeper_stack_in_minidump (functionalities/postmortem/minidump-new/TestMiniDumpNew.py)
ERROR: test_deeper_stack_in_minidump_with_same_pid_running (functionalities/postmortem/minidump-new/TestMiniDumpNew.py)
ERROR: test_two_cores_same_pid (functionalities/postmortem/minidump-new/TestMiniDumpNew.py)
Tue, Apr 11, 4:15 AM · Restricted Project

Mon, Apr 10

labath updated the diff for D31880: Fix libc++ vector<bool> data formatter (bug #32553).

Remove the vector<bool> summary provider as well (picked up from Tamas's version of the patch).

Mon, Apr 10, 7:15 AM
labath created D31880: Fix libc++ vector<bool> data formatter (bug #32553).
Mon, Apr 10, 4:03 AM
labath created D31877: Remove Plugins/Process/POSIX from include_directories.
Mon, Apr 10, 2:37 AM

Wed, Apr 5

labath committed rL299588: Annotate some more libc++ tests with the new category.
Annotate some more libc++ tests with the new category
Wed, Apr 5, 1:47 PM

Fri, Mar 31

labath accepted D31451: New C++ function name parsing logic.

Thank you

Fri, Mar 31, 1:58 PM
labath added a comment to D31451: New C++ function name parsing logic.

I did some micro-benchmarking and on average new parser is ~3 time slower than the old one. (new parser - ~200k string/s, old parser - ~700k string/s)
clang::Lexer appears to be the slowest part of it.

On the clang breakpoint benchmark you proposed, it is hard to notice much of a difference. clang binary has about 500k functions.
With new parser it takes about 11s to try to set a breakpoint, on the old one it's about 10s. (release version of LLDB, debug static version of clang)

I decided to use a hybrid approach, when we use old parsing code for simple cases and call new parser only when it fails.
80% of clang functions are simple enough that we don't really need the new parser, so it helped to bring clang breakpoint test back to 10s.
I think it's reasonable to assume that similar distribution is true for most programs, and most of their functions can be parsed with the old code.

I don't think we can really improve performance of a new parser without giving up on clang::Lexer, and I'm reluctant to do it.
So I propose to keep hybrid approach and call a new parser only for complicated cases.

Fri, Mar 31, 9:12 AM
labath accepted D31485: Verify memory address range validity in GDBRemoteCommunicationClient.

Thank you for adding the test. Lgtm, assuming the second getmemoryregioninfo call is accidental.

Fri, Mar 31, 3:00 AM

Thu, Mar 30

labath accepted D31450: Battery of NetBSD support improvements.

Thank you. Keep up the good work.

Thu, Mar 30, 1:22 PM · Restricted Project
labath added a comment to D31451: New C++ function name parsing logic.

I cant help but feel that this could have been done in a simpler way, but then again, some of the cases you have dug up are quite tricky.
I think we should do some performance measurements to see whether this needs more optimising or it's fine as is.

Thu, Mar 30, 9:38 AM
labath added a comment to D31485: Verify memory address range validity in GDBRemoteCommunicationClient.

The additional check sounds fine. There's a test for this class in unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp where you can add a test for this behavior.

Thu, Mar 30, 8:43 AM

Wed, Mar 29

labath committed rL299028: Centralize libc++ test skipping logic.
Centralize libc++ test skipping logic
Wed, Mar 29, 2:14 PM
labath closed D30984: Centralize libc++ test skipping logic by committing rL299028: Centralize libc++ test skipping logic.
Wed, Mar 29, 2:13 PM
labath added a comment to D30984: Centralize libc++ test skipping logic.

I don't see anything wrong with this, but I only know libc++ and not LLDB.

I'm not sure why you ended up here. I think you have too wide phabricator filter somewhere. :)

Wed, Mar 29, 1:24 PM
labath added a comment to D31367: Expression: add missing linkage to RuntimeDyld component.

We don't depend on the RuntimeDyld component of llvm directy -- we only use it indirectly through the ExecutionEngine component. Shouldn't that be reflected as a dependency in the build system somehow, so that the former can be pulled in directly ?
RuntimeDyld is listed as a dependency of ExecutionEngine in lib/ExecutionEngine/LLVMBuild.txt, but that does not seem to be reflected in the cmake? Is that a bug on the llvm side?

Wed, Mar 29, 1:11 PM · Restricted Project
labath added inline comments to D31450: Battery of NetBSD support improvements.
Wed, Mar 29, 1:04 PM · Restricted Project
labath accepted D31461: Add NetBSD path for Debugging Information in Separate Files.
Wed, Mar 29, 1:00 PM · Restricted Project
labath added inline comments to D31450: Battery of NetBSD support improvements.
Wed, Mar 29, 6:39 AM · Restricted Project

Tue, Mar 28

labath added a comment to D31374: Add support for tracing hello-world application on NetBSD.

I wasn't able to go into this too deeply, but here is what I have after a quick pass. I won't be able to review this thoroughly that soon, but I think it can go in after you take my comments into consideration.

Tue, Mar 28, 9:40 AM · Restricted Project
labath added a comment to D31357: Support Unit Testing debugserver.

I am afraid I will be away for two weeks as well.. :(

Tue, Mar 28, 9:21 AM
labath added inline comments to D31131: [LLDB] OpenBSD support.
Tue, Mar 28, 9:00 AM · Restricted Project

Sun, Mar 26

labath added a comment to D31335: Allow getCompiler to return None in the test suite.

This doesn't bother me too much, but i'm curious about how are you getting anything reasonable out of the test suite without a working compiler (?)

Sun, Mar 26, 11:11 AM
labath accepted D31298: Bypass GetNormalizedFile when not necessary....

Seems legit.

Sun, Mar 26, 11:09 AM · Restricted Project

Mar 23 2017

labath added a comment to D30984: Centralize libc++ test skipping logic.

Does anyone object to me landing this? I am going to be careful and wait for the change to trickle through CI before submitting any followup changes.

Mar 23 2017, 9:37 AM
labath accepted D30457: [LLDB][MIPS] Core Dump Support.

Thank you.

Mar 23 2017, 9:26 AM
labath accepted D31280: [LLDB][MIPS] Fix Core file Architecture and OS information.

Ah, that explains it, thanks.

Mar 23 2017, 9:25 AM
labath added a comment to D31280: [LLDB][MIPS] Fix Core file Architecture and OS information.

Thank you for that.

Mar 23 2017, 8:58 AM
labath added inline comments to D31280: [LLDB][MIPS] Fix Core file Architecture and OS information.
Mar 23 2017, 7:25 AM
labath added inline comments to D31280: [LLDB][MIPS] Fix Core file Architecture and OS information.
Mar 23 2017, 4:28 AM
labath added a comment to D31280: [LLDB][MIPS] Fix Core file Architecture and OS information.

BTW, thank you for adding the test. It's not obvious from the patch: how big are the core files?

Mar 23 2017, 3:54 AM
labath added inline comments to D31280: [LLDB][MIPS] Fix Core file Architecture and OS information.
Mar 23 2017, 3:52 AM
labath accepted D31279: Fix warnings from clang build on macOS..
Mar 23 2017, 2:13 AM

Mar 22 2017

labath committed rL298509: Revert "Delete the remainder of platform specific code in FileSpec.".
Revert "Delete the remainder of platform specific code in FileSpec."
Mar 22 2017, 7:17 AM
labath accepted D31231: Reuse appropriate Launch and Attach on NetBSD.
Mar 22 2017, 6:59 AM · Restricted Project

Mar 21 2017

labath accepted D31192: Create instance of DynamicLoaderPOSIXDYLD on NetBSD.

I think you should group these "add netbsd to a list" type of changes into single diff. There's not point in reviewing each separately.

Mar 21 2017, 9:43 AM · Restricted Project
labath accepted D31138: Add stub for PluginProcessNetBSD.

Heh... I did not expect it would get this small, but ok. :)

Mar 21 2017, 9:20 AM · Restricted Project
labath accepted D31191: Enable ProcessPOSIXLog on NetBSD.
Mar 21 2017, 9:18 AM · Restricted Project
labath committed rL298375: Replace std::ofstream with llvm::raw_fd_ostream.
Replace std::ofstream with llvm::raw_fd_ostream
Mar 21 2017, 7:02 AM
labath closed D31079: Replace std::ofstream with llvm::raw_fd_ostream by committing rL298375: Replace std::ofstream with llvm::raw_fd_ostream.
Mar 21 2017, 7:02 AM
labath committed rL298374: Remove ProcFileReader.
Remove ProcFileReader
Mar 21 2017, 7:02 AM
labath added a comment to D31146: Enable AUXV and QPassSignals in gdb-remote for NetBSD.

I'm still evaluating whether to implement on the kernel side PT_SET_SIGPASS/PT_GET_SIGPASS. Some software like floating point can use it heavily.

Mar 21 2017, 5:33 AM · Restricted Project