labath (Pavel Labath)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 4 2013, 6:02 AM (285 w, 1 d)

Recent Activity

Yesterday

labath added a comment to D54731: [lit] Enable the use of custom user-defined lit commands.

I'd go with the "conservative" approach first. The idea of having lldb loaded inside a lit process does not excite me. One of the problems we have with dotest is that when lldb crashes during the test, it takes a part of the test driver with it which causes some tests to be skipped and the complicates the reporting of the result of the crashed test. It's not as bad right now, as there is still the main process left to report some kind of an error (back in the days when tests were run sequentially in a single process, the entire test suite would just stop), but I still think it would be nice to avoid these issues in the new framework.

Wed, Nov 21, 12:59 PM
labath added a comment to D54731: [lit] Enable the use of custom user-defined lit commands.

I think that something like this would go a long way towards solving the problems with lit tests we're having in lldb.

Wed, Nov 21, 4:52 AM

Mon, Nov 19

labath added a comment to D54617: [wip][Reproducers] Add file provider.

I am confused by differing scopes of various objects that are interacting here. It seems you are implementing capture/replay as something that can be flicked on/off at any point during a debug session (Debugger lifetime). However, you are modifying global state (the filesystem singleton, at least), which is shared by all debug sessions. If multiple debug sessions try to enable capture/replay (or even access the filesystem concurrently, as none of this is synchronized in any way), things will break horribly. This seems like a bad starting point in implementing a feature, as I don't see any way to fix incrementally in the future.

Maybe I should've added a comment (I didn't want to litter the code with design goals) but the goal of the commands is not really to enable/disable the reproducer feature. I'm currently abusing the commands to do that, but the long term goal is that you can enable/disable part of the reproducer. For example, you could say only capture GDB packets or capture only files. It makes testing a lot easier if you can isolate a single source of information. Since there's currently only GDB packets I didn't split it up (yet).

Also I piggy-backed off this to enable/disable the feature as a whole because I needed to go through the debugger. See my reply below on why and how that'll be fixed by the next patch :-)

Mon, Nov 19, 6:23 AM
labath added inline comments to D54616: [Reproducers] Improve reproducer API and add unit tests..
Mon, Nov 19, 6:01 AM · Restricted Project
labath added a comment to D54682: [Driver] Extract option parsing and option processing..

If by "it would cause errors to no longer appear in the same order as specified by the user, but in an arbitrary order specified by the driver implementation", you mean that now for a command line like:

$ new/lldb -S /tmp/sadg --file /tmp/qwr

I get

error: file specified in --file (-f) option doesn't exist: '/tmp/qwr'

instead of

error: file specified in --source (-s) option doesn't exist: '/tmp/sadg'

then that's something I really don't care about.

Mon, Nov 19, 5:46 AM · Restricted Project

Sun, Nov 18

labath added a comment to D54617: [wip][Reproducers] Add file provider.

I am confused by differing scopes of various objects that are interacting here. It seems you are implementing capture/replay as something that can be flicked on/off at any point during a debug session (Debugger lifetime). However, you are modifying global state (the filesystem singleton, at least), which is shared by all debug sessions. If multiple debug sessions try to enable capture/replay (or even access the filesystem concurrently, as none of this is synchronized in any way), things will break horribly. This seems like a bad starting point in implementing a feature, as I don't see any way to fix incrementally in the future.

Sun, Nov 18, 10:40 AM

Thu, Nov 15

labath added inline comments to D54476: [CMake] Streamline code signing for debugserver.
Thu, Nov 15, 9:09 AM

Wed, Nov 14

labath committed rL346867: Move DataExtractorTest to unittests/Utility.
Move DataExtractorTest to unittests/Utility
Wed, Nov 14, 7:01 AM
labath committed rLLDB346867: Move DataExtractorTest to unittests/Utility.
Move DataExtractorTest to unittests/Utility
Wed, Nov 14, 7:01 AM
labath committed rLLDB346849: Fix a crash when parsing incorrect DWARF.
Fix a crash when parsing incorrect DWARF
Wed, Nov 14, 3:15 AM
labath committed rL346849: Fix a crash when parsing incorrect DWARF.
Fix a crash when parsing incorrect DWARF
Wed, Nov 14, 3:15 AM
labath closed D54417: Fix a crash when parsing incorrect DWARF.
Wed, Nov 14, 3:15 AM

Mon, Nov 12

labath created D54417: Fix a crash when parsing incorrect DWARF.
Mon, Nov 12, 2:00 AM

Sat, Nov 10

labath accepted D54272: Extract construction of DataBufferLLVM into FileSystem.

Looks fine to me, I'd just ask you to consider shortening the method names a bit.

Sat, Nov 10, 1:50 AM · Restricted Project
labath added a comment to D54221: Add setting to require hardware breakpoints..

I recall something about linux on arm having a magic unmodifiable (even by ptrace) page of memory, so this could be useful there too. However, it's not clear to me how a user is going to figure out that he needs to enable this setting. Would it make sense to automatically try setting a hardware breakpoint if software breakpoint fails?

My main concern would be that hardware breakpoints are a limited resource and not something we want to make transparent to the user, because it's only a matter of time before it fails.

Sat, Nov 10, 1:32 AM · Restricted Project

Wed, Nov 7

labath added a comment to D54221: Add setting to require hardware breakpoints..

I recall something about linux on arm having a magic unmodifiable (even by ptrace) page of memory, so this could be useful there too. However, it's not clear to me how a user is going to figure out that he needs to enable this setting. Would it make sense to automatically try setting a hardware breakpoint if software breakpoint fails?

Wed, Nov 7, 12:52 PM · Restricted Project
labath added a comment to D53094: [pecoff] Implement ObjectFilePECOFF::GetDependedModules().

Could we reverse the dependencies between the two? I.e., first add the necessary functionality to lldb-test and then write the test using that? Or just merge that into a single patch?

Wed, Nov 7, 12:34 PM

Tue, Nov 6

labath committed rLLDB346233: CPlusPlusLanguage: Use new demangler API to implement type substitution.
CPlusPlusLanguage: Use new demangler API to implement type substitution
Tue, Nov 6, 7:44 AM
labath committed rL346233: CPlusPlusLanguage: Use new demangler API to implement type substitution.
CPlusPlusLanguage: Use new demangler API to implement type substitution
Tue, Nov 6, 7:44 AM
labath closed D54074: CPlusPlusLanguage: Use new demangler API to implement type substitution.
Tue, Nov 6, 7:43 AM
labath updated the diff for D54074: CPlusPlusLanguage: Use new demangler API to implement type substitution.

Thanks for the review. I have added some comments, and moved appending of the unmodified portion of the name into a separate function to aid readability.

Tue, Nov 6, 6:57 AM

Mon, Nov 5

labath updated the diff for D54074: CPlusPlusLanguage: Use new demangler API to implement type substitution.

Thanks for the review.

Mon, Nov 5, 6:55 AM
labath added a comment to D54072: Add a command to dump a module's clang ast..

If it comes down to choosing between colored output going to stderr and plain output going where it should, i'd go with the second option.

Mon, Nov 5, 6:21 AM

Sun, Nov 4

labath added a comment to D54072: Add a command to dump a module's clang ast..

Unfortunately then color output is impossible. Where else would the output
be expected to go?

Sun, Nov 4, 5:38 AM
labath committed rLLDB346094: Fix log statement in r346093.
Fix log statement in r346093
Sun, Nov 4, 4:58 AM
labath committed rL346094: Fix log statement in r346093.
Fix log statement in r346093
Sun, Nov 4, 4:58 AM
labath committed rLLDB346093: NativeProcessProtocol: Simplify breakpoint setting code.
NativeProcessProtocol: Simplify breakpoint setting code
Sun, Nov 4, 3:02 AM
labath committed rL346093: NativeProcessProtocol: Simplify breakpoint setting code.
NativeProcessProtocol: Simplify breakpoint setting code
Sun, Nov 4, 3:02 AM
labath closed D52941: NativeProcessProtocol: Simplify breakpoint setting code.
Sun, Nov 4, 3:01 AM
labath added a comment to D52941: NativeProcessProtocol: Simplify breakpoint setting code.

thanks.

Sun, Nov 4, 3:01 AM
labath added inline comments to D54072: Add a command to dump a module's clang ast..
Sun, Nov 4, 2:23 AM

Sat, Nov 3

labath created D54074: CPlusPlusLanguage: Use new demangler API to implement type substitution.
Sat, Nov 3, 11:31 AM
labath added a comment to D52941: NativeProcessProtocol: Simplify breakpoint setting code.

Kamil, I think you're the best qualified person to look at the lldb-server changes right now, so I'd like to hear your opinion on the other changes too. Otherwise, I'll just commit this some time next week.

Sat, Nov 3, 6:41 AM
labath accepted D52461: [PDB] Introduce `MSVCUndecoratedNameParser`.

Thanks for your patience. This looks good to me now.

Sat, Nov 3, 3:40 AM · Restricted Project
labath added a comment to D54053: [NativePDB] Add the ability to create clang record decls from mangled names..

A very nice use of the structured demangler.

Sat, Nov 3, 3:33 AM
labath added a comment to D53989: Fix formatting of wchar, char16, and char32.

lldb-server is used on architectures that don't have python (readily) available, and it uses the same codebase as the rest of lldb. (Granted, it only needs a small subset of that codebase, and this subset doesn't/shouldn't care about python, but we aren't able to split out that part cleanly (yet)). So I don't think requiring python is a good idea.

Sat, Nov 3, 3:11 AM

Fri, Nov 2

labath accepted D54020: [FileSystem] Open File instances through the FileSystem..

I am not sure what do you mean by "translating paths" in the VFS. If you mean something like "return a FILE * for /whatever/my_reproducer/vfs/bin/ls when I ask for /bin/ls", then I think that's a good idea, as it's most likely to work with all of our existing code (e.g. mmapping). Although, in this case, i am not sure how much benefit will the llvm VFS bring to the game, as most of the operations could then be implemented by plainly prepending some prefix to a given path.

Let me try to explain this better. This is mostly a question about what kind of API the VFS (which lives in LLVM) provides to deal with files in lldb (i.e. through FILE* and file descriptors).

The first possibility is providing a method in the VFS that takes a "virtual" path and returns the "underlying" path. Something like Optional<path> vfs::getUnderlyingPath(path). This doesn't just have to be a prefix thing but you are right that it's mostly going to be just that. The problem is that this method wouldn't work for virtual file systems that don't have files on disk. Hence the lack of generality.

Fri, Nov 2, 11:54 AM · Restricted Project
labath added a comment to D54020: [FileSystem] Open File instances through the FileSystem..

I am not sure what do you mean by "translating paths" in the VFS. If you mean something like "return a FILE * for /whatever/my_reproducer/vfs/bin/ls when I ask for /bin/ls", then I think that's a good idea, as it's most likely to work with all of our existing code (e.g. mmapping). Although, in this case, i am not sure how much benefit will the llvm VFS bring to the game, as most of the operations could then be implemented by plainly prepending some prefix to a given path.

Fri, Nov 2, 12:59 AM · Restricted Project

Thu, Nov 1

labath added a comment to D52461: [PDB] Introduce `MSVCUndecoratedNameParser`.

It's not fully clear to me from the previous comments if you are proceeding with this or not, but in case you are, I have made comments inline. I see that you've added some lit tests, but I also think you it would be good add some unit tests for the name parser functionality per-se (similar to the existing name parsing tests), as it is much easier to see what is going on from those.

Thu, Nov 1, 12:30 AM · Restricted Project

Wed, Oct 31

labath accepted D53915: [FileSystem] Move resolve logic out of FileSpec.
Wed, Oct 31, 11:50 PM · Restricted Project
labath accepted D53532: [FileSystem] Extend file system and have it use the VFS..

Thanks for bearing with me. I am very happy with how this turned out in the end. I have more suggestion on how to clean up the initialization, which you can incorporate if you like it, but I don't want to hold up the patch over that.

Wed, Oct 31, 2:16 AM · Restricted Project
labath accepted D53845: [FileSystem] Remove Exists() from FileSpec.
Wed, Oct 31, 1:12 AM · Restricted Project
labath added a comment to D53834: [FileSystem] Remove ResolveExecutableLocation() from FileSpec.

Why did you change the function name? I think it would be nice to keep "executable" or something to that effect in the name (e.g. the llvm function has "program"), given that the underlying function checks for the executable bit, and so it cannot be used for general searches.

Wed, Oct 31, 1:09 AM · Restricted Project
labath accepted D53831: [FileSystem] Remove GetPermissions() and Readable() from FileSpec.
Wed, Oct 31, 1:03 AM · Restricted Project

Tue, Oct 30

labath added a comment to D53532: [FileSystem] Extend file system and have it use the VFS..

Address Pavel's feedback:

  • Change to Initialize method which can only be called once.

I suppose this is slightly better, but what I meant was to have a static (like all other functions with the same name) Initialize function, which has to be called before the first call to Instance(). During normal startup, this could be called from SystemInitializer, but I am not sure how would that work for record/replay (that's why I was asking how you planned to initialize those). It would require to setup the record/replay machinery very early on, which may be tricky. But on the other hand, you probably want to initialize these as early as possible anyway.

Do you think something like that would be possible?

Alright, I see what you mean. You know more about the architecture, but it looks like we initialize the system before even reading the command line arguments in the driver. I have to read the reproducer before I can set the appropriate file system, so I'm not sure if this is possible.

Tue, Oct 30, 12:18 PM · Restricted Project
labath added a comment to D52618: [Windows] A basic implementation of memory allocations in a debuggee process.

Ok, if that's how you guys feel, then I won't stand in your way. I am fine with this patch then.

Tue, Oct 30, 9:22 AM · Restricted Project
labath added a comment to D53532: [FileSystem] Extend file system and have it use the VFS..

Address Pavel's feedback:

  • Change to Initialize method which can only be called once.
Tue, Oct 30, 12:21 AM · Restricted Project
labath accepted D53785: [FileSystem] Move EnumerateDirectory from FileSpec to FileSystem..

lgtm

Tue, Oct 30, 12:12 AM · Restricted Project

Mon, Oct 29

labath added a comment to D53538: NFC: Reorganize the demangler a bit.

I like this change a lot. I was hoping something like this could be done, when I saw that we were copying patches around.

Mon, Oct 29, 6:19 AM
labath accepted D53677: Fix a bug PlatformDarwin::SDKSupportsModule.

lgtm. Sorry about the trouble.

Mon, Oct 29, 3:38 AM
labath added a comment to D53094: [pecoff] Implement ObjectFilePECOFF::GetDependedModules().

It sounds like at least part of this could be tested by adding the ability to dump dependent modules to lldb-test object-file (which I think would fit very nicely within the current information printed by that command). I seem to recall seeing code like that in some patch but it seems to be missing here now.

Mon, Oct 29, 3:27 AM

Sun, Oct 28

labath added a comment to D53511: [NativePDB] Support type lookup by name.

For the purposes of testing I decided to bypass lldb-test and go with a scripted lldbinit file. I'm sticking with this approach wherever possible to prove that this is "true" cross-platform debugger functionality. However, there are definite limitations. For example, the output format of type lookup has some limitations. It doesn't print the layout of the type in any kind of detail (e.g. field offsets), it doesn't support lookup by regex, it doesn't print the underlying type of an enumeration, it doesn't support limiting the scope of the search to specific kinds of types, so there is definitely room for lldb-test to come into the picture here to expand the coverage since we have full control over the output format.

Sun, Oct 28, 8:42 AM

Sat, Oct 27

labath added a comment to D53532: [FileSystem] Extend file system and have it use the VFS..

Now that I know your use case (I forgot that you're working on the replay now, and the mention of VFS threw me off in a completely different direction), I agree that having a single global filesystem is fine. As for the increased verbosity, I wonder if we should make the fs accessor a free function instead of a member (so that you write something like hostFS().Symlink(..) instead of FileSystem::instance().Symlink(...).

Sat, Oct 27, 2:09 AM · Restricted Project

Thu, Oct 25

labath added a comment to D53532: [FileSystem] Extend file system and have it use the VFS..

I also think it we should try to keep FileSpec in the Utility module. We should be able to do that by deleting the "utility" functions in the FileSpec class, and updating everything to go through the FileSystem class.

Thu, Oct 25, 12:22 AM · Restricted Project

Tue, Oct 23

labath added a comment to D53532: [FileSystem] Extend file system and have it use the VFS..

Back when the FileSystem class was introduced, the idea was that *it* would eventually become the gateway to the real filesystem, and FileSpec would just deal with abstract path manipulation.

Tue, Oct 23, 11:05 AM · Restricted Project

Oct 19 2018

labath added a comment to D53086: [PDB] Fix flaky `variables-locations.test` after PR38857.

Yes it sounds like the situation is very much similar here as it is in dwarf land -- the compilers there also don't tend to emit unwind info for prologues and epilogues.

Oct 19 2018, 12:12 PM · Restricted Project

Oct 17 2018

labath added a comment to D53086: [PDB] Fix flaky `variables-locations.test` after PR38857.

That's an interesting code snippet. Thanks for sharing that.

Oct 17 2018, 1:02 PM · Restricted Project
labath committed rL344703: Port libcxxabi r344607 into llvm.
Port libcxxabi r344607 into llvm
Oct 17 2018, 11:52 AM
labath closed D53300: Port libcxxabi D52992 into llvm.
Oct 17 2018, 11:52 AM
labath added a comment to D53255: Fix: Assertion failed: (!m_first_die || m_first_die == m_die_array.front()), function ExtractDIEsRWLocked.

It looks like it should be easy to write a test for this by hand-crafting a minimal .s file and feeding it to lldb-test.

Oct 17 2018, 8:58 AM · Restricted Project

Oct 16 2018

labath added a comment to D52461: [PDB] Introduce `MSVCUndecoratedNameParser`.
`operator<<A>'::`2'::B::operator>
Oct 16 2018, 7:49 AM · Restricted Project
labath committed rCXXA344607: cxa_demangle: make demangler's parsing functions overridable.
cxa_demangle: make demangler's parsing functions overridable
Oct 16 2018, 7:31 AM
labath committed rL344607: cxa_demangle: make demangler's parsing functions overridable.
cxa_demangle: make demangler's parsing functions overridable
Oct 16 2018, 7:31 AM
labath closed D52992: cxa_demangle: make demangler's parsing functions overridable.
Oct 16 2018, 7:31 AM
labath added inline comments to D53300: Port libcxxabi D52992 into llvm.
Oct 16 2018, 7:26 AM
labath added a comment to D52992: cxa_demangle: make demangler's parsing functions overridable.

Thanks for the review.

Oct 16 2018, 7:22 AM

Oct 15 2018

labath created D53300: Port libcxxabi D52992 into llvm.
Oct 15 2018, 1:00 PM
labath updated the diff for D52992: cxa_demangle: make demangler's parsing functions overridable.
  • rename Db into (Abstract)ManglingParser
  • revert Allocator changes
  • re-clang-format
Oct 15 2018, 12:22 PM
labath added a comment to D53086: [PDB] Fix flaky `variables-locations.test` after PR38857.

As for aligned stack cross-platform problems, I mean also problems with stack unwinding. They seem to appear on non-Windows too. It's because x86AssemblyInspectionEngine doesn't support stack alignment now. I've made some changes locally to fix it, but they are still raw to publish. The main idea is to save one more frame address (along with CFA) for every row of an unwind plan (I've called this AFA - aligned frame address), and add an analysis for and esp, ... etc. to x86AssemblyInspectionEngine. What do you think about a such approach?

Oct 15 2018, 12:15 PM · Restricted Project
labath added inline comments to D52992: cxa_demangle: make demangler's parsing functions overridable.
Oct 15 2018, 12:03 PM
labath added a comment to D53090: [Windows] Fix a bug that causes lldb to freeze.

Do we have a test for this? It sounds like it shouldn't be hard to replicate the dependent library load failure in a test...

Oct 15 2018, 11:39 AM

Oct 10 2018

labath committed rCXXA344121: Port llvm r342166 to libcxxabi demangler.
Port llvm r342166 to libcxxabi demangler
Oct 10 2018, 1:42 AM
labath committed rL344121: Port llvm r342166 to libcxxabi demangler.
Port llvm r342166 to libcxxabi demangler
Oct 10 2018, 1:42 AM
labath closed D53063: Port llvm r342166 to libcxxabi demangler.
Oct 10 2018, 1:42 AM
labath created D53063: Port llvm r342166 to libcxxabi demangler.
Oct 10 2018, 12:50 AM
labath added inline comments to D53002: Create a new symbol file plugin for cross-platform PDB symbolization.
Oct 10 2018, 12:11 AM

Oct 8 2018

labath added a comment to D53002: Create a new symbol file plugin for cross-platform PDB symbolization.

I can't say I have done a particularly thorough review, but code seems well structured, and it looks like I could make sense of it if I went through the effort of figuring out what various pdb record types mean. These are the things that came to mind while looking at this.

Oct 8 2018, 11:09 PM
labath created D52992: cxa_demangle: make demangler's parsing functions overridable.
Oct 8 2018, 10:20 AM

Oct 7 2018

labath added a comment to D52404: Prevent double import of _lldb module.

Thanks,
What changed in SWIG 3.0.11?

Oct 7 2018, 1:52 AM · Restricted Project

Oct 6 2018

labath accepted D52404: Prevent double import of _lldb module.

Sorry for the delay. I *think* this should be fine, but with these things its hard to tell whether it won't break someone's build/release setup. However, it does solve a real problem (I've hit this issue myself a couple of times on windows), so I think we should give it a try.

Oct 6 2018, 11:34 PM · Restricted Project

Oct 5 2018

labath created D52941: NativeProcessProtocol: Simplify breakpoint setting code.
Oct 5 2018, 12:37 PM

Oct 3 2018

labath committed rLLDB343683: Pull FixupBreakpointPCAsNeeded into base class.
Pull FixupBreakpointPCAsNeeded into base class
Oct 3 2018, 5:32 AM
labath committed rL343683: Pull FixupBreakpointPCAsNeeded into base class.
Pull FixupBreakpointPCAsNeeded into base class
Oct 3 2018, 5:32 AM
labath closed D52719: Pull FixupBreakpointPCAsNeeded into base class.
Oct 3 2018, 5:31 AM

Oct 2 2018

labath added a comment to D52618: [Windows] A basic implementation of memory allocations in a debuggee process.

One idea would be to define some lit substitutions like %debuginfo. It’s
true you can produce a gcc style command line that will be equivalent to a
clang-cl invocation but it won’t be easy. eg you’ll needing to pass
-fms-compatibility as well as various -I for includes.

It may be easier to have substitutions instead

Oct 2 2018, 5:38 AM · Restricted Project

Oct 1 2018

labath added a comment to D52461: [PDB] Introduce `MSVCUndecoratedNameParser`.

I've tried to parse with it a name like

N0::`unnamed namespase'::Name

and it can't parse it correctly. May be it just can't parse MSVC demangled names?

Oct 1 2018, 5:05 AM · Restricted Project
labath added inline comments to D52618: [Windows] A basic implementation of memory allocations in a debuggee process.
Oct 1 2018, 4:54 AM · Restricted Project
labath created D52719: Pull FixupBreakpointPCAsNeeded into base class.
Oct 1 2018, 4:48 AM

Sep 30 2018

labath added a comment to D52461: [PDB] Introduce `MSVCUndecoratedNameParser`.

It seems that CPlusPlusLanguage::MethodName is backed by LLDB CPlusPlusNameParser, which can't parse demangled names...

Sep 30 2018, 11:13 AM · Restricted Project
labath added inline comments to D46810: 3/3: Fix DWARFUnit::GetUnitDIEPtrOnly stale pointer.
Sep 30 2018, 10:22 AM
labath committed rL343411: Fix NetBSD build for r343409.
Fix NetBSD build for r343409
Sep 30 2018, 9:13 AM
labath committed rLLDB343411: Fix NetBSD build for r343409.
Fix NetBSD build for r343409
Sep 30 2018, 9:13 AM
labath committed rLLDB343409: Pull GetSoftwareBreakpointPCOffset into base class.
Pull GetSoftwareBreakpointPCOffset into base class
Sep 30 2018, 9:01 AM
labath committed rL343409: Pull GetSoftwareBreakpointPCOffset into base class.
Pull GetSoftwareBreakpointPCOffset into base class
Sep 30 2018, 9:00 AM
labath closed D52532: Pull GetSoftwareBreakpointPCOffset into base class.
Sep 30 2018, 9:00 AM
labath added a comment to D52532: Pull GetSoftwareBreakpointPCOffset into base class.

I was wondering whether we want to normalize this inside the kernel and always advance the Program Counter.. but it's easier to manage it in userland.

Sep 30 2018, 8:58 AM

Sep 26 2018

labath created D52532: Pull GetSoftwareBreakpointPCOffset into base class.
Sep 26 2018, 12:51 AM
labath committed rLLDB343076: Fix a memory read bug in lldb-server.
Fix a memory read bug in lldb-server
Sep 26 2018, 12:33 AM
labath committed rL343076: Fix a memory read bug in lldb-server.
Fix a memory read bug in lldb-server
Sep 26 2018, 12:33 AM

Sep 25 2018

labath accepted D52516: [lldbinline] Set directory attribute on test-specific classes.

Ooh, nice catch. This must have been fun to debug.

Sep 25 2018, 1:13 PM