Page MenuHomePhabricator

labath (Pavel Labath)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 4 2013, 6:02 AM (302 w, 6 d)

Recent Activity

Today

labath accepted D59779: [Args] Handle backticks.
Mon, Mar 25, 10:24 AM · Restricted Project
labath added a comment to D59779: [Args] Handle backticks.

Given the current way lldb command interpreter parser does things (which tries to model a posix shell), (one of) the correct ways to do '-quoting would be to replace each ' char by '\''.

Mon, Mar 25, 10:15 AM · Restricted Project
labath added a parent revision for D59775: Minidump: Add support for reading/writing strings: D59634: Add minidump support to obj2yaml.
Mon, Mar 25, 9:12 AM · Restricted Project
labath created D59775: Minidump: Add support for reading/writing strings.
Mon, Mar 25, 9:12 AM · Restricted Project
labath added a child revision for D59634: Add minidump support to obj2yaml: D59775: Minidump: Add support for reading/writing strings.
Mon, Mar 25, 9:12 AM · Restricted Project
labath committed rGc5f7905e9326: MinidumpYAML.cpp: Fix some code standard violations missed during review (authored by labath).
MinidumpYAML.cpp: Fix some code standard violations missed during review
Mon, Mar 25, 7:45 AM
labath committed rL356901: MinidumpYAML.cpp: Fix some code standard violations missed during review.
MinidumpYAML.cpp: Fix some code standard violations missed during review
Mon, Mar 25, 7:45 AM
labath committed rGd2b488886780: Minidump: Use minidump constants defined in llvm (authored by labath).
Minidump: Use minidump constants defined in llvm
Mon, Mar 25, 7:09 AM
labath committed rL356898: Minidump: Use minidump constants defined in llvm.
Minidump: Use minidump constants defined in llvm
Mon, Mar 25, 7:09 AM
labath committed rLLDB356898: Minidump: Use minidump constants defined in llvm.
Minidump: Use minidump constants defined in llvm
Mon, Mar 25, 7:09 AM
labath committed rG2ef15d82e908: Reapply minidump changes reverted in r356806 (authored by labath).
Reapply minidump changes reverted in r356806
Mon, Mar 25, 7:02 AM
labath committed rLLDB356896: Reapply minidump changes reverted in r356806.
Reapply minidump changes reverted in r356806
Mon, Mar 25, 7:01 AM
labath committed rL356896: Reapply minidump changes reverted in r356806.
Reapply minidump changes reverted in r356806
Mon, Mar 25, 7:01 AM
labath accepted D59582: Python 2/3 compat: StringIO.

I have a feeling most of these files should be just deleted, but since you went through the trouble of creating this patch, I see no reason why to not accept it.

Mon, Mar 25, 5:20 AM · Restricted Project, Restricted Project
labath accepted D59586: Python 2/3 compat: tkinter.

LGTM, although this is looks like another piece of unmaintained code.

Mon, Mar 25, 5:16 AM · Restricted Project
labath added a reviewer for D59589: Python 2/3 compat: str vs basestring: davide.
Mon, Mar 25, 5:14 AM · Restricted Project
labath accepted D59590: Python 2/3 compat: queue vs Queue.

It looks like this code hasn't been touched since 2013, so who knows if it even works. But fixing this should be fine anyway.

Mon, Mar 25, 5:13 AM · Restricted Project, Restricted Project
labath resigned from D59581: Python 2/3 compat: urllib.

Someone from the LLD(not B) project should review this.

Mon, Mar 25, 5:09 AM · Restricted Project, Restricted Project
labath accepted D59591: Python 2/3 compat: unichr vs chr.
Mon, Mar 25, 5:07 AM · Restricted Project
labath added a comment to D59719: [ScriptInterpreter] Make sure that PYTHONHOME is right..

It sounds to me like you could achieve the same thing by generalizing the LLDB_PYTHON_HOME logic in LLDBConfig.cmake. This would have the advantage of centralizing the way we manage python-finding logic (instead of each OS doing it's own thing) and also enable those users, who know what they are doing, to override this logic and point lldb to a different python. (I don't know if there are any such users, but it does not sounds like an impossible scenario).

Mon, Mar 25, 5:07 AM · Restricted Project, Restricted Project

Fri, Mar 22

labath committed rG4c2ef9a02be0: Revert "Move the rest of the sections over to DWARFContext." (authored by labath).
Revert "Move the rest of the sections over to DWARFContext."
Fri, Mar 22, 9:09 AM
labath committed rL356773: Revert "Move the rest of the sections over to DWARFContext.".
Revert "Move the rest of the sections over to DWARFContext."
Fri, Mar 22, 9:08 AM
labath added a comment to D59611: Move the rest of the section loading over to DWARFContext.

This broke the DWO flavours of some tests:

lldb-Suite :: lang/c/const_variables/TestConstVariables.py
lldb-Suite :: lang/c/local_variables/TestLocalVariables.py
lldb-Suite :: lang/c/vla/TestVLA.py
Fri, Mar 22, 9:08 AM · Restricted Project
labath committed rLLDB356773: Revert "Move the rest of the sections over to DWARFContext.".
Revert "Move the rest of the sections over to DWARFContext."
Fri, Mar 22, 9:08 AM
labath committed rG69de7a955e8a: [ObjectYAML] Add basic minidump generation support (authored by labath).
[ObjectYAML] Add basic minidump generation support
Fri, Mar 22, 7:48 AM
labath committed rL356753: [ObjectYAML] Add basic minidump generation support.
[ObjectYAML] Add basic minidump generation support
Fri, Mar 22, 7:48 AM
labath closed D59482: [ObjectYAML] Add basic minidump generation support.
Fri, Mar 22, 7:47 AM · Restricted Project
labath committed rG3285c0f065ec: Extend r356573 (minidump UUID handling) to cover elf build-ids too (authored by labath).
Extend r356573 (minidump UUID handling) to cover elf build-ids too
Fri, Mar 22, 7:03 AM
labath committed rLLDB356751: Extend r356573 (minidump UUID handling) to cover elf build-ids too.
Extend r356573 (minidump UUID handling) to cover elf build-ids too
Fri, Mar 22, 7:03 AM
labath committed rL356751: Extend r356573 (minidump UUID handling) to cover elf build-ids too.
Extend r356573 (minidump UUID handling) to cover elf build-ids too
Fri, Mar 22, 7:02 AM

Thu, Mar 21

labath accepted D59606: [lldb] Add missing EINTR handling.
Thu, Mar 21, 10:41 AM · Restricted Project, Restricted Project
labath added a comment to D59291: [Object] Add basic minidump support.
Thu, Mar 21, 10:29 AM · Restricted Project
labath abandoned D58972: Introduce the "Formats" module and move LinuxProcMaps parser to it.

minidump parser will go into llvm, which removes the main incentive for creating this new module. It's possible we may need something like this in the future, but should wait until there is a real use case for it.

Thu, Mar 21, 3:57 AM
labath abandoned D58976: Introduce core2yaml tool.

instead of a fresh tool, minidump support will be added to obj2yaml.

Thu, Mar 21, 3:57 AM
labath abandoned D58973: Move the minidump parser into the Formats module.

minidump parser will go into llvm/Object instead.

Thu, Mar 21, 3:57 AM
labath abandoned D58975: Introduce MinidumpEnums.def textual header.

This code will be in llvm now, so this cl is dead.

Thu, Mar 21, 3:54 AM
labath added a parent revision for D59634: Add minidump support to obj2yaml: D59482: [ObjectYAML] Add basic minidump generation support.
Thu, Mar 21, 3:52 AM · Restricted Project
labath added a child revision for D59482: [ObjectYAML] Add basic minidump generation support: D59634: Add minidump support to obj2yaml.
Thu, Mar 21, 3:52 AM · Restricted Project
labath created D59634: Add minidump support to obj2yaml.
Thu, Mar 21, 3:51 AM · Restricted Project
labath updated the diff for D59482: [ObjectYAML] Add basic minidump generation support.

It occurred to me that the "invalid input" test cases could be easily rewritten
in lit, as they don't require parsing of the generated binary (because there
isn't one).

Thu, Mar 21, 3:45 AM · Restricted Project
labath committed rG045b8544fd2c: Fix two more issues with r356652 (authored by labath).
Fix two more issues with r356652
Thu, Mar 21, 3:22 AM
labath committed rL356655: Fix two more issues with r356652.
Fix two more issues with r356652
Thu, Mar 21, 3:20 AM
labath committed rG7da2de698fdb: Attempt to fix modules build for r356652 (authored by labath).
Attempt to fix modules build for r356652
Thu, Mar 21, 2:43 AM
labath committed rL356653: Attempt to fix modules build for r356652.
Attempt to fix modules build for r356652
Thu, Mar 21, 2:43 AM
labath committed rG581d79a440a6: [Object] Add basic minidump support (authored by labath).
[Object] Add basic minidump support
Thu, Mar 21, 2:18 AM
labath committed rL356652: [Object] Add basic minidump support.
[Object] Add basic minidump support
Thu, Mar 21, 2:18 AM
labath closed D59291: [Object] Add basic minidump support.
Thu, Mar 21, 2:18 AM · Restricted Project
labath updated the diff for D59548: [Sanitizer] Add interceptor for wctomb.

avoid heap allocations by using a stack buffer of fixed size which "should be enough for everyone".

Thu, Mar 21, 1:50 AM · Restricted Project, Restricted Project
labath added inline comments to D59606: [lldb] Add missing EINTR handling.
Thu, Mar 21, 1:43 AM · Restricted Project, Restricted Project
labath added a comment to D59606: [lldb] Add missing EINTR handling.

I think this is fine, except for the things I pointed out inline. As for SafelyCloseFileDescriptor (wow) thing, I think we should use that, given that it's already there. I suggest making a separate patch for that.

Thu, Mar 21, 1:07 AM · Restricted Project, Restricted Project
labath added inline comments to D59606: [lldb] Add missing EINTR handling.
Thu, Mar 21, 1:03 AM · Restricted Project, Restricted Project

Wed, Mar 20

labath added a comment to D59606: [lldb] Add missing EINTR handling.

The "problem" I have with this is that (IIRC) retrying close(2) on EINTR is the *wrong* thing to do on linux (because the fd will be closed anyway, and so we may end up closing someone else's file the second time around). I'll try to dig up more info about that tomorrow.

Wed, Mar 20, 11:47 AM · Restricted Project, Restricted Project
labath updated the diff for D59482: [ObjectYAML] Add basic minidump generation support.
  • rename Text/Hex streams
  • fix Hex stream size handling and add some tests for it
Wed, Mar 20, 8:59 AM · Restricted Project
labath added inline comments to D59482: [ObjectYAML] Add basic minidump generation support.
Wed, Mar 20, 8:59 AM · Restricted Project
labath added inline comments to D59433: Fix UUID decoding from minidump files..
Wed, Mar 20, 8:17 AM · Restricted Project
labath added inline comments to D59562: [SymbolFileDWARF] Introduce DWARFContext.
Wed, Mar 20, 7:45 AM · Restricted Project
labath added a reviewer for D59548: [Sanitizer] Add interceptor for wctomb: vitalybuka.
Wed, Mar 20, 6:42 AM · Restricted Project, Restricted Project
labath updated the diff for D59548: [Sanitizer] Add interceptor for wctomb.
  • add sanitizer_common test
  • fix the "write to freed memory" issue by redirecting the function call to a local buffer. To know the size of the buffer I need to allocate, I needed to add a new "platform limits" constant for the value of MB_LEN_MAX (another option would be to use some upper bound which is large enough for all reasonable platforms, such as 32).
Wed, Mar 20, 6:41 AM · Restricted Project, Restricted Project
labath added reviewers for D59482: [ObjectYAML] Add basic minidump generation support: markmentovai, amccarth.

Thanks for the review.

Wed, Mar 20, 5:50 AM · Restricted Project
labath added inline comments to D59562: [SymbolFileDWARF] Introduce DWARFContext.
Wed, Mar 20, 5:45 AM · Restricted Project
labath accepted D59588: Python 2/3 compat: iteritems vs items.
Wed, Mar 20, 5:34 AM · Restricted Project
labath accepted D59587: Use explicit loop instead of map for Python 2/3 compat.
Wed, Mar 20, 5:34 AM · Restricted Project, Restricted Project
labath accepted D59585: python 2/3 compat: int vs long.
Wed, Mar 20, 5:30 AM · Restricted Project
labath accepted D59583: python2/3 compat: exceptions.
Wed, Mar 20, 5:29 AM · Restricted Project, Restricted Project
labath updated subscribers of D59581: Python 2/3 compat: urllib.
Wed, Mar 20, 5:28 AM · Restricted Project, Restricted Project
labath accepted D59579: Use list comprehension instead of map/filter to prepare Python2/3 compat.

I think this should be fine, modulo the typo. TBH, I was not even aware some of these files existed. The ones that are already used by people on a daily basis should by already python3-ready.

Wed, Mar 20, 5:25 AM · Restricted Project

Tue, Mar 19

labath created D59548: [Sanitizer] Add interceptor for wctomb.
Tue, Mar 19, 8:37 AM · Restricted Project, Restricted Project
labath committed rG06453b0619e2: Fix a "memset clearing an object of non-trivial type" warning in… (authored by labath).
Fix a "memset clearing an object of non-trivial type" warning in…
Tue, Mar 19, 8:07 AM
labath committed rL356459: Fix a "memset clearing an object of non-trivial type" warning in….
Fix a "memset clearing an object of non-trivial type" warning in…
Tue, Mar 19, 8:04 AM
labath committed rLLDB356459: Fix a "memset clearing an object of non-trivial type" warning in….
Fix a "memset clearing an object of non-trivial type" warning in…
Tue, Mar 19, 8:04 AM
labath added a comment to D59427: [lldb] [Reproducer] Move SBRegistry registration into declaring files.

The direction looks good to me too.

Tue, Mar 19, 5:19 AM · Restricted Project

Mon, Mar 18

labath committed rG0e5012eac35b: Skip TestVSCode_setFunctionBreakpoints on linux (authored by labath).
Skip TestVSCode_setFunctionBreakpoints on linux
Mon, Mar 18, 9:06 AM
labath committed rG370e5dbacdc7: Fix some "variable 'foo' set but not used" warnings (authored by labath).
Fix some "variable 'foo' set but not used" warnings
Mon, Mar 18, 9:06 AM
labath committed rL356379: Skip TestVSCode_setFunctionBreakpoints on linux.
Skip TestVSCode_setFunctionBreakpoints on linux
Mon, Mar 18, 9:05 AM
labath committed rLLDB356379: Skip TestVSCode_setFunctionBreakpoints on linux.
Skip TestVSCode_setFunctionBreakpoints on linux
Mon, Mar 18, 9:05 AM
labath committed rLLDB356378: Fix some "variable 'foo' set but not used" warnings.
Fix some "variable 'foo' set but not used" warnings
Mon, Mar 18, 9:05 AM
labath committed rL356378: Fix some "variable 'foo' set but not used" warnings.
Fix some "variable 'foo' set but not used" warnings
Mon, Mar 18, 9:05 AM
labath created D59495: Fix an out-of-bounds error in RegisterContextDarwin_arm64.
Mon, Mar 18, 8:50 AM
labath committed rG22457e66c51f: Fix libstdc++ data formatters for python3 (authored by labath).
Fix libstdc++ data formatters for python3
Mon, Mar 18, 8:41 AM
labath committed rL356377: Fix libstdc++ data formatters for python3.
Fix libstdc++ data formatters for python3
Mon, Mar 18, 8:41 AM
labath committed rLLDB356377: Fix libstdc++ data formatters for python3.
Fix libstdc++ data formatters for python3
Mon, Mar 18, 8:41 AM
labath committed rG58e9ef139ddf: Fix TestCommandScriptImmediateOutput for python3 (authored by labath).
Fix TestCommandScriptImmediateOutput for python3
Mon, Mar 18, 7:15 AM
labath committed rLLDB356370: Fix TestCommandScriptImmediateOutput for python3.
Fix TestCommandScriptImmediateOutput for python3
Mon, Mar 18, 7:14 AM
labath committed rL356370: Fix TestCommandScriptImmediateOutput for python3.
Fix TestCommandScriptImmediateOutput for python3
Mon, Mar 18, 7:14 AM
labath updated the diff for D59482: [ObjectYAML] Add basic minidump generation support.

Updating to address review comments (thank you for the super quick turnaround).

Mon, Mar 18, 6:53 AM · Restricted Project
labath added inline comments to D59482: [ObjectYAML] Add basic minidump generation support.
Mon, Mar 18, 6:53 AM · Restricted Project
labath committed rGf92ddfed5a3d: Fix "type qualifiers ignored on cast result type" warnings (authored by labath).
Fix "type qualifiers ignored on cast result type" warnings
Mon, Mar 18, 3:51 AM
labath committed rL356362: Fix "type qualifiers ignored on cast result type" warnings.
Fix "type qualifiers ignored on cast result type" warnings
Mon, Mar 18, 3:51 AM
labath committed rLLDB356362: Fix "type qualifiers ignored on cast result type" warnings.
Fix "type qualifiers ignored on cast result type" warnings
Mon, Mar 18, 3:51 AM
labath committed rLLDB356361: Reinitialize UnwindTable when the SymbolFile changes.
Reinitialize UnwindTable when the SymbolFile changes
Mon, Mar 18, 3:47 AM
labath committed rGdec963921b68: Reinitialize UnwindTable when the SymbolFile changes (authored by labath).
Reinitialize UnwindTable when the SymbolFile changes
Mon, Mar 18, 3:45 AM
labath committed rL356361: Reinitialize UnwindTable when the SymbolFile changes.
Reinitialize UnwindTable when the SymbolFile changes
Mon, Mar 18, 3:44 AM
labath closed D58347: Reinitialize UnwindTable when the SymbolFile changes.
Mon, Mar 18, 3:44 AM · Restricted Project
labath added a parent revision for D59482: [ObjectYAML] Add basic minidump generation support: D59291: [Object] Add basic minidump support.
Mon, Mar 18, 3:09 AM · Restricted Project
labath added a child revision for D59291: [Object] Add basic minidump support: D59482: [ObjectYAML] Add basic minidump generation support.
Mon, Mar 18, 3:09 AM · Restricted Project
labath created D59482: [ObjectYAML] Add basic minidump generation support.
Mon, Mar 18, 3:09 AM · Restricted Project
labath accepted D59433: Fix UUID decoding from minidump files..

Looks good to me. I have some comments inline and below, but none of them is really substantial.

Mon, Mar 18, 1:38 AM · Restricted Project
labath added a comment to D59427: [lldb] [Reproducer] Move SBRegistry registration into declaring files.

I like the fact that we're moving the register methods into the respective class files. Among other things, this should make it easier for the instrumentation tool to insert register calls as well. However, I am not fond of introducing a public SB API call for something that should really be a private matter. One way to fix that would be to make the Initialize function private and make the SBReproducer class a friend, but perhaps it would be even better to not put this function into the public headers at all.

Mon, Mar 18, 1:23 AM · Restricted Project

Fri, Mar 15

labath committed rG230837c662b9: YAMLIO: Improve endian type support (authored by labath).
YAMLIO: Improve endian type support
Fri, Mar 15, 8:35 AM
labath committed rL356269: YAMLIO: Improve endian type support.
YAMLIO: Improve endian type support
Fri, Mar 15, 8:34 AM