labath (Pavel Labath)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 4 2013, 6:02 AM (236 w, 1 d)

Recent Activity

Today

labath added a comment to D40291: [Support] Add WritableMemoryBuffer class.

As there aren't any strong opinions objections to the present implementation (I haven't registered any, at least), and it solves an existing problem in lldb, could we land this soon-ish?

Wed, Dec 13, 10:11 AM
labath created D41169: ObjectFile: remove ReadSectionData/MemoryMapSectionData mutual recursion.
Wed, Dec 13, 4:08 AM
labath committed rL320561: [Testing/Support] Make the HasValue matcher composable.
[Testing/Support] Make the HasValue matcher composable
Wed, Dec 13, 2:01 AM
labath closed D41065: [Testing/Support] Make the HasValue matcher composable.
Wed, Dec 13, 2:01 AM

Yesterday

labath added inline comments to D41070: llgs: Propagate the environment when launching the inferior from command line.
Tue, Dec 12, 8:56 AM
labath added a comment to D40616: ObjectFileELF: Add support for compressed sections.

Does that sound right?

Tue, Dec 12, 8:45 AM
labath added a comment to D40616: ObjectFileELF: Add support for compressed sections.

I think GetFileSize() should remain the number of bytes of the section on disk and we should add new API if we need to figure out the decompressed size. Or maybe when we get bytes from a compressed section we are expected to always just get the raw bytes, then we check of the section is compressed, and if so, then we call another API on ObjectFile to decompress the data. So I would prefer GetFileSize() to return the file size of the section size in the file and not the decompressed size. Is there a way to make this work?

Tue, Dec 12, 6:10 AM
labath added a comment to D40947: [cmake] Make setting of CMAKE_C(XX)_COMPILER flags overridable for cross-builds.

Did this fix an existing problem?

Tue, Dec 12, 5:12 AM

Mon, Dec 11

labath added a comment to D40616: ObjectFileELF: Add support for compressed sections.

@davide: Any thoughts on .yaml as a test file suffix?

Mon, Dec 11, 9:47 AM
labath updated the diff for D41069: NPL: Clean up handling of inferior exit.

apply clang-format

Mon, Dec 11, 9:43 AM
labath added a comment to D41069: NPL: Clean up handling of inferior exit.

Is the lldb_private::Process we have an exit status in the class itself. The first person to set the exit status wins and no one can set it twice. Doesn't look like what we are doing here. I am not able to tell what actually fixes things here?

Mon, Dec 11, 9:37 AM
labath added a dependent revision for D41069: NPL: Clean up handling of inferior exit: D41070: llgs: Propagate the environment when launching the inferior from command line.
Mon, Dec 11, 7:54 AM
labath added a dependent revision for D41065: [Testing/Support] Make the HasValue matcher composable: D41070: llgs: Propagate the environment when launching the inferior from command line.
Mon, Dec 11, 7:54 AM
labath added dependencies for D41070: llgs: Propagate the environment when launching the inferior from command line: D41069: NPL: Clean up handling of inferior exit, D41065: [Testing/Support] Make the HasValue matcher composable.
Mon, Dec 11, 7:54 AM
labath created D41070: llgs: Propagate the environment when launching the inferior from command line.
Mon, Dec 11, 7:53 AM
labath added a dependent revision for D41067: llgs-tests: Add support for "exit" stop-reply packets: D41069: NPL: Clean up handling of inferior exit.
Mon, Dec 11, 7:40 AM
labath added a dependency for D41069: NPL: Clean up handling of inferior exit: D41067: llgs-tests: Add support for "exit" stop-reply packets.
Mon, Dec 11, 7:40 AM
labath created D41069: NPL: Clean up handling of inferior exit.
Mon, Dec 11, 7:39 AM
labath committed rL320377: dotest.py: Correctly annotate lldbinline tests with debug info categories.
dotest.py: Correctly annotate lldbinline tests with debug info categories
Mon, Dec 11, 7:29 AM
labath committed rL320366: Add a StringList constructor to Args class.
Add a StringList constructor to Args class
Mon, Dec 11, 6:23 AM
labath added a dependent revision for D41066: llgs-tests: Make addition of new tests easier: D41067: llgs-tests: Add support for "exit" stop-reply packets.
Mon, Dec 11, 6:12 AM
labath added a dependency for D41067: llgs-tests: Add support for "exit" stop-reply packets: D41066: llgs-tests: Make addition of new tests easier.
Mon, Dec 11, 6:12 AM
labath created D41067: llgs-tests: Add support for "exit" stop-reply packets.
Mon, Dec 11, 6:11 AM
labath created D41066: llgs-tests: Make addition of new tests easier.
Mon, Dec 11, 5:54 AM
labath created D41065: [Testing/Support] Make the HasValue matcher composable.
Mon, Dec 11, 4:43 AM
labath committed rL320349: Fix osx build broken in r320346.
Fix osx build broken in r320346
Mon, Dec 11, 3:13 AM
labath committed rL320346: Move PseudoTerminal to the lldb_private namespace.
Move PseudoTerminal to the lldb_private namespace
Mon, Dec 11, 2:10 AM
labath committed rL320345: MainLoop: avoid infinite loop when pty slave gets closed.
MainLoop: avoid infinite loop when pty slave gets closed
Mon, Dec 11, 1:34 AM
labath closed D41008: MainLoop: avoid infinite loop when pty slave gets closed by committing rL320345: MainLoop: avoid infinite loop when pty slave gets closed.
Mon, Dec 11, 1:34 AM

Fri, Dec 8

labath added a comment to D41008: MainLoop: avoid infinite loop when pty slave gets closed.

Darwin uses a kqueue-based implementation of this, so it definitely won't *break* anything, although I'd appreciate it if you can check whether the test passes there. My cursory reading of the kqueue man page makes me believe it should not be affected by this.

Fri, Dec 8, 11:34 AM
labath created D41008: MainLoop: avoid infinite loop when pty slave gets closed.
Fri, Dec 8, 7:23 AM
labath committed rL320138: [cmake] Make setting of CMAKE_C(XX)_COMPILER flags overridable for cross-builds.
[cmake] Make setting of CMAKE_C(XX)_COMPILER flags overridable for cross-builds
Fri, Dec 8, 2:00 AM
labath closed D40947: [cmake] Make setting of CMAKE_C(XX)_COMPILER flags overridable for cross-builds by committing rL320138: [cmake] Make setting of CMAKE_C(XX)_COMPILER flags overridable for cross-builds.
Fri, Dec 8, 2:00 AM

Thu, Dec 7

labath added inline comments to D40947: [cmake] Make setting of CMAKE_C(XX)_COMPILER flags overridable for cross-builds.
Thu, Dec 7, 7:25 AM
labath added inline comments to D40947: [cmake] Make setting of CMAKE_C(XX)_COMPILER flags overridable for cross-builds.
Thu, Dec 7, 6:32 AM
labath added a comment to D40229: [cmake] Remove redundant call to cmake when building host tools..

I'm getting a similar problem where passing in CMAKE_CXX_COMPILER breaks my native build, except it's harder to work around because I don't specify CROSS_TOOLCHAIN_FLAGS. I'm building for a device, and specify a C++ compiler for that build, but that compiler isn't the correct one for building my native tools. When no compiler was specified on the cross-compile-native cmake invocation, this worked, but now this ends up using the wrong compiler and failing.

Actually, ignore this for now. This isn't exactly what's going wrong and I need to look at it a bit more.

Thu, Dec 7, 3:17 AM
labath created D40947: [cmake] Make setting of CMAKE_C(XX)_COMPILER flags overridable for cross-builds.
Thu, Dec 7, 3:11 AM
labath committed rL320025: [Testing/Support] Make matchers work with Expected<T&>.
[Testing/Support] Make matchers work with Expected<T&>
Thu, Dec 7, 2:55 AM
labath closed D40904: [Testing/Support] Make matchers work with Expected<T&> by committing rL320025: [Testing/Support] Make matchers work with Expected<T&>.
Thu, Dec 7, 2:54 AM
labath committed rL320021: Variable: Fix usage of uninitialised value.
Variable: Fix usage of uninitialised value
Thu, Dec 7, 2:39 AM
labath closed D40557: Variable: Fix usage of uninitialised value by committing rL320021: Variable: Fix usage of uninitialised value.
Thu, Dec 7, 2:39 AM
labath added a comment to D40930: Don't add a dependency on the backtrace library if it can't be found..

The change makes sense, we just need to make the check cleaner.

Thu, Dec 7, 2:21 AM
labath accepted D40757: Disable warnings related to anonymous types in the ObjC plugin.

Cool. Thanks.

Thu, Dec 7, 1:57 AM

Wed, Dec 6

labath created D40904: [Testing/Support] Make matchers work with Expected<T&>.
Wed, Dec 6, 8:41 AM
labath accepted D40896: [cmake] Move CMAKE_(C|CXX)_COMPILER variables before CROSS_TOOLCHAIN_FLAGS so they can be overridden when cross compiling..
Wed, Dec 6, 7:17 AM
labath added a comment to D40896: [cmake] Move CMAKE_(C|CXX)_COMPILER variables before CROSS_TOOLCHAIN_FLAGS so they can be overridden when cross compiling..

Thank you for fixing this on such a short notice.

Wed, Dec 6, 7:17 AM
labath added a comment to D40557: Variable: Fix usage of uninitialised value.

Jim, could you have a quick look at this?

Wed, Dec 6, 4:11 AM
labath added a comment to D40229: [cmake] Remove redundant call to cmake when building host tools..

I think this breaks any non-trivial cross-compilation scenario.

Wed, Dec 6, 3:34 AM

Tue, Dec 5

labath accepted D40757: Disable warnings related to anonymous types in the ObjC plugin.
In D40757#944293, @vsk wrote:

I'd like to make this a narrower change as well, but unfortunately, I haven't found a way to add in extra CXX flags through the add_library or llvm_add_library utilities. Somebody tried to do this once in AddLLDB.cmake (see "set(CMAKE_CXX_FLAGS ...)"), but it's busted, and does not do anything, AFAICT.

Tue, Dec 5, 2:52 AM
labath added inline comments to D40779: [cmake] Fix zlib library detection.
Tue, Dec 5, 2:28 AM
labath committed rL319751: Re-commit "[cmake] Enable zlib support on windows".
Re-commit "[cmake] Enable zlib support on windows"
Tue, Dec 5, 2:24 AM
labath closed D40779: [cmake] Fix zlib library detection by committing rL319751: Re-commit "[cmake] Enable zlib support on windows".
Tue, Dec 5, 2:24 AM
labath updated the diff for D40291: [Support] Add WritableMemoryBuffer class.

I've added a MemoryBufferRef (which is what most APIs accept) constructor that
takes a WritableMemoryBuffer. Since MemoryBufferRef (as well as MemoryBuffer)
operates with StringRefs, but WritableMemoryBuffer uses
(Mutable)ArrayRef<uint8_t> (I think was done because there is no equivalent to
MutableStringRef and having MutableArrayRef+StringRef combo would be weird),
I've also added a WritableMemoryBuffer::getBufferAsStringRef().

Tue, Dec 5, 2:10 AM

Mon, Dec 4

labath added a comment to D40291: [Support] Add WritableMemoryBuffer class.

Hi David,

Mon, Dec 4, 9:00 AM
labath committed rL319663: Revert "[cmake] Enable zlib support on windows".
Revert "[cmake] Enable zlib support on windows"
Mon, Dec 4, 8:46 AM
labath committed rL319653: Makefile.rules: compile all tests with -fno-limit-debug-info.
Makefile.rules: compile all tests with -fno-limit-debug-info
Mon, Dec 4, 5:32 AM
labath closed D40717: Makefile.rules: compile all tests with -fno-limit-debug-info by committing rL319653: Makefile.rules: compile all tests with -fno-limit-debug-info.
Mon, Dec 4, 5:32 AM
labath added a comment to D40757: Disable warnings related to anonymous types in the ObjC plugin.

If the "excuse" for not following llvm here is that these structs mirror apple headers, should we restrict these warnings only to the relevant files (e.g. everything in source/Plugins/Language/ObjC)?

Mon, Dec 4, 4:56 AM
labath created D40779: [cmake] Fix zlib library detection.
Mon, Dec 4, 3:33 AM

Fri, Dec 1

labath added inline comments to D40616: ObjectFileELF: Add support for compressed sections.
Fri, Dec 1, 7:12 AM
labath created D40717: Makefile.rules: compile all tests with -fno-limit-debug-info.
Fri, Dec 1, 5:22 AM
labath updated the diff for D40616: ObjectFileELF: Add support for compressed sections.

Rebase on master and update the test.

Fri, Dec 1, 4:43 AM
labath added inline comments to D40616: ObjectFileELF: Add support for compressed sections.
Fri, Dec 1, 4:42 AM
labath committed rL319536: Kill struct IOVEC.
Kill struct IOVEC
Fri, Dec 1, 4:05 AM
labath committed rL319533: [cmake] Enable zlib support on windows.
[cmake] Enable zlib support on windows
Fri, Dec 1, 3:41 AM
labath closed D40655: [cmake] Enable zlib support on windows by committing rL319533: [cmake] Enable zlib support on windows.
Fri, Dec 1, 3:41 AM

Thu, Nov 30

labath created D40655: [cmake] Enable zlib support on windows.
Thu, Nov 30, 8:44 AM
labath committed rL319443: Add a test case for open bug 35480.
Add a test case for open bug 35480
Thu, Nov 30, 7:40 AM
labath added inline comments to D40616: ObjectFileELF: Add support for compressed sections.
Thu, Nov 30, 7:28 AM
labath added a comment to D40475: DWZ 12/12: DWZ test mode.

you will probably be the only person who will be able to run these tests and verify dwz functionality.

OK; really nobody runs RHEL/CentOS/Fedora? :-)

There aren't that many lldb developers... I wouldn't be surprised if the number of them having access to a red-hat machine is 1 (you).

Thu, Nov 30, 6:57 AM
labath updated the diff for D40616: ObjectFileELF: Add support for compressed sections.

This rewrites the test in terms on the new lldb-test utility. It should be applied on top of D40636.

Thu, Nov 30, 6:02 AM
labath added a comment to D40636: Create a trivial lldb-test program.

I feel this is reimplementing llvm-readobj, but maybe that's appropriate as we are reimplementing object file readers as well (my original patch wouldn't be necessary if we were using the llvm object library). Minor comments below, but I actually quite like this approach. It's also much less code than I expected this will need.

Thu, Nov 30, 2:31 AM
labath committed rL319414: Fix assertion in ClangASTContext.
Fix assertion in ClangASTContext
Thu, Nov 30, 2:17 AM
labath closed D40615: Fix assertion in ClangASTContext by committing rL319414: Fix assertion in ClangASTContext.
Thu, Nov 30, 2:17 AM
labath added inline comments to D40615: Fix assertion in ClangASTContext.
Thu, Nov 30, 1:59 AM

Wed, Nov 29

labath created D40616: ObjectFileELF: Add support for compressed sections.
Wed, Nov 29, 10:52 AM
labath created D40615: Fix assertion in ClangASTContext.
Wed, Nov 29, 10:41 AM
labath accepted D40587: [lldb] Minor fixes in TaskPool.
Wed, Nov 29, 1:26 AM
labath added a comment to D40587: [lldb] Minor fixes in TaskPool.

Looks good, thanks.

Wed, Nov 29, 1:26 AM

Tue, Nov 28

labath created D40557: Variable: Fix usage of uninitialised value.
Tue, Nov 28, 7:14 AM
labath committed rL319162: elf-core: Convert remaining register context to use register set maps.
elf-core: Convert remaining register context to use register set maps
Tue, Nov 28, 3:10 AM
labath closed D40133: elf-core: Convert remaining register context to use register set maps by committing rL319162: elf-core: Convert remaining register context to use register set maps.
Tue, Nov 28, 3:10 AM
labath committed rL319161: Fix floating point register write on new x86 linux kernels.
Fix floating point register write on new x86 linux kernels
Tue, Nov 28, 2:57 AM
labath closed D40434: Fix floating point register write on new x86 linux kernels by committing rL319161: Fix floating point register write on new x86 linux kernels.
Tue, Nov 28, 2:57 AM
labath added a comment to D40539: Allow using the object file name for debug symbol resolution.

On 28 November 2017 at 06:12, Zachary Turner via lldb-commits <lldb-commits@lists.llvm.org> wrote:

yaml2core would be an excellent idea for a tool.

Tue, Nov 28, 2:48 AM
labath added a comment to D40366: [Support][Parallel] ThreadPoolExecutor fixes for Windows.

I absolutely do not want to disable support for ConcRT under any circumstances unless we find that it is a completely broken library, which I highly doubt. Even then, I would want to ask Microsoft to fix it.

What is the exact problem you're running into?

Hi, sorry, I thought that this would be a "private" patch. Don't worry, I do not intend to make any changes without proper review!

I created this patch to see if it might help with a problem being seen on Linux, in the message thread "std::thread::detach() rarely crashes in Parallel.cpp".

Tue, Nov 28, 12:55 AM

Mon, Nov 27

labath committed rL319048: Remove custom TimePoint-formatting code.
Remove custom TimePoint-formatting code
Mon, Nov 27, 9:07 AM
labath committed rL319028: dotest: Mark more android targets as chatty.
dotest: Mark more android targets as chatty
Mon, Nov 27, 5:47 AM
labath added a comment to D40475: DWZ 12/12: DWZ test mode.

The thing to be aware of with this testing strategy is that you will probably be the only person who will be able to run these tests and verify dwz functionality. If you don't setup a buildbot testing this then other developers will never even know if they have broken any dwz functionality in the future. While end-to-end tests are great and we need them, I think it would be worthwhile to think about other testing strategies. These can range from checking in a couple of siple dwz files and making sure we can extract information from them (see unittests/SymbolFile/PDB for code that does something similar) to reimplementing/upstreaming the utilities necessary to build dwz files ourselves (I am not sure what the dwz tool does, but the eu-strip and sepdebugcrcfix tools sound like they would be fairly easy to implement on top of existing llvm libraries).

Mon, Nov 27, 3:04 AM
labath added a comment to D40474: DWZ 11/12: Main functionality.

I am only commenting on the c++14 stuff. I think all of the things you need here are available to us already through various llvm utilities. See inline comments for details.

Mon, Nov 27, 2:31 AM

Fri, Nov 24

labath created D40434: Fix floating point register write on new x86 linux kernels.
Fri, Nov 24, 6:04 AM

Thu, Nov 23

labath updated the diff for D40133: elf-core: Convert remaining register context to use register set maps.

This is a slight deviation from the initial approach. What I've done here is
that I've kept the register set indices in an os-specific form. I've done this
because it enables the parsing code in ProcessElfCore to be
architecture-agnostic -- it can just deal with OS specifics, and can just shove
any note it does not recognise to the side. These will be then parsed in the
corresponding register contexts, which can only deal with architecture
specifics, and ignore OS details, as the translation of os-specific note types
is provided by a separate lookup table.

Thu, Nov 23, 4:10 AM
labath committed rL318903: elf-core: Split up parsing code into os-specific functions.
elf-core: Split up parsing code into os-specific functions
Thu, Nov 23, 2:51 AM
labath closed D40311: elf-core: Split up parsing code into os-specific functions by committing rL318903: elf-core: Split up parsing code into os-specific functions.
Thu, Nov 23, 2:50 AM
labath added a reviewer for D40291: [Support] Add WritableMemoryBuffer class: dblaikie.

Adding David Blaikie as a reviewer, as suggested by Rafael.

Thu, Nov 23, 1:49 AM
labath updated the diff for D40291: [Support] Add WritableMemoryBuffer class.

remove unbuffered=true from the test

Thu, Nov 23, 1:46 AM

Wed, Nov 22

labath added inline comments to D40311: elf-core: Split up parsing code into os-specific functions.
Wed, Nov 22, 3:58 AM
labath updated the diff for D40311: elf-core: Split up parsing code into os-specific functions.

Update comments.

Wed, Nov 22, 3:58 AM
labath updated the diff for D40291: [Support] Add WritableMemoryBuffer class.

Remove the RequiresNullTerminator flag

Wed, Nov 22, 2:49 AM

Tue, Nov 21

labath added inline comments to D40311: elf-core: Split up parsing code into os-specific functions.
Tue, Nov 21, 9:13 AM