Page MenuHomePhabricator

jingham (Jim Ingham)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 23 2014, 5:24 PM (405 w, 2 d)

Recent Activity

Yesterday

jingham committed rG38ca754eb08b: Apparently you need a special makefile flag to use threads on Linux. (authored by jingham).
Apparently you need a special makefile flag to use threads on Linux.
Thu, Jun 30, 12:11 PM · Restricted Project
jingham committed rGb8e0b5a07160: Threads which hit a breakpoint but fail the condition are considered (authored by jingham).
Threads which hit a breakpoint but fail the condition are considered
Thu, Jun 30, 11:44 AM · Restricted Project
jingham closed D128776: Handle a stop when another thread has hit a breakpoint with a failed condition.
Thu, Jun 30, 11:44 AM · Restricted Project, Restricted Project

Wed, Jun 29

jingham updated the diff for D128776: Handle a stop when another thread has hit a breakpoint with a failed condition.

Use sleep_for instead of usleep. Man, that API isn't winning any beauty contests!

Wed, Jun 29, 5:51 PM · Restricted Project, Restricted Project
jingham added a comment to D128775: [trace] Fix errors when handling command arguments.

Thanks for doing this. The test suite was clean after my original changes, which means whatever is using CommandObjectMultipleThreads must not have had any tests where arguments were passed to it? Ditto for the trace command. Might be good to add those as well.

Wed, Jun 29, 9:51 AM · Restricted Project, Restricted Project

Tue, Jun 28

jingham requested review of D128776: Handle a stop when another thread has hit a breakpoint with a failed condition.
Tue, Jun 28, 6:15 PM · Restricted Project, Restricted Project
jingham committed rGf7bf9d13d50d: TestIgnoredExceptions.py needs support from debugserver, so it (authored by jingham).
TestIgnoredExceptions.py needs support from debugserver, so it
Tue, Jun 28, 11:50 AM · Restricted Project

Mon, Jun 27

jingham committed rGc1b07d617705: Have CommandObjectParsed check for "commands that take no arguments". (authored by jingham).
Have CommandObjectParsed check for "commands that take no arguments".
Mon, Jun 27, 3:15 PM · Restricted Project
jingham closed D128453: Automate checking for "command that takes no arguments" being passed arguments in CommandObjectParsed.
Mon, Jun 27, 3:15 PM · Restricted Project, Restricted Project

Fri, Jun 24

jingham accepted D50304: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers.

For some reason I'm not getting mail notifications for review changes, sorry about that.

This is certainly better than the original implementation. Among other things, if we find an exact match, we really shouldn't be doing any more inexact matches, so after the first exact hit it should have switched exact to true.

But if you had line tables laid out like (this is in increasing order of address:

10
20
30
10
16

and you did "thread until 15", this would find the inexact match at 20, switch to an exact match for line 20 and find no other matches. But the gap between 10 & 16 in the line table is maybe an even more plausible place to put the line 15 until breakpoint, so maybe we did want to throw a breakpoint there as well?

@jingham
Nope, with the current patch, we would find the inexact match at 16.

Fri, Jun 24, 10:46 AM · Restricted Project, Restricted Project
jingham updated subscribers of D128504: debugserver: spawn process in its own process group.

Why is it desirable to have the debugger not see signals sent to the process?

Fri, Jun 24, 9:14 AM · Restricted Project, Restricted Project

Thu, Jun 23

jingham added a comment to D128477: [trace] Add a flag to the decoder to output the instruction type.

This categorization seems like it is relevant for any instruction, not just instructions found in a trace buffer. Is there any reason why this isn't just an annotation added by the standard instruction printer, that you then turn on with the -k flag to thread trace dump (but which might also be useful for the regular disassemble command)?

Thu, Jun 23, 4:38 PM · Restricted Project, Restricted Project
jingham committed rGa1f20da315c8: The help string for stop-on-shared-library-load was copied to stop-on-exec. (authored by jingham).
The help string for stop-on-shared-library-load was copied to stop-on-exec.
Thu, Jun 23, 1:55 PM · Restricted Project
jingham updated the summary of D128453: Automate checking for "command that takes no arguments" being passed arguments in CommandObjectParsed.
Thu, Jun 23, 10:09 AM · Restricted Project, Restricted Project
jingham requested review of D128453: Automate checking for "command that takes no arguments" being passed arguments in CommandObjectParsed.
Thu, Jun 23, 10:08 AM · Restricted Project, Restricted Project

Wed, Jun 22

jingham committed rGbae10a6bbb1e: Fix a bug with "process continue -b" when no breakpoints are (authored by jingham).
Fix a bug with "process continue -b" when no breakpoints are
Wed, Jun 22, 12:18 PM · Restricted Project
jingham committed rG4298b1b8d137: Add a "-b" option to "process continue" to run to a set of breakpoints, (authored by jingham).
Add a "-b" option to "process continue" to run to a set of breakpoints,
Wed, Jun 22, 9:55 AM · Restricted Project
jingham closed D126513: Add -b (--continue-to-breakpoint) option to the "process continue" command.
Wed, Jun 22, 9:55 AM · Restricted Project, Restricted Project

Tue, Jun 21

jingham updated the diff for D126513: Add -b (--continue-to-breakpoint) option to the "process continue" command.

Address review comments

Tue, Jun 21, 5:40 PM · Restricted Project, Restricted Project

Thu, Jun 16

jingham committed rGf22db1fabfa1: Fix StopInfoBreakpoint::ShouldNotify when a callback deletes the site we hit. (authored by jingham).
Fix StopInfoBreakpoint::ShouldNotify when a callback deletes the site we hit.
Thu, Jun 16, 11:54 AM · Restricted Project
jingham closed D127997: Remember whether all owners of the site we hit were internal in StopInfoBreakpoint.
Thu, Jun 16, 11:54 AM · Restricted Project, Restricted Project
jingham requested review of D127997: Remember whether all owners of the site we hit were internal in StopInfoBreakpoint.
Thu, Jun 16, 11:33 AM · Restricted Project, Restricted Project
jingham added a comment to D127605: [lldb] Support non-pointer implicit this/self in GetValueForVariableExpressionPath.

This is good, but it also illustrates how the strings "->" and ".'" should actually come from the typesystem and not be hardcoded. We're just lucky that all languages have a "." operator.

More elegant would be to just add an API to TypeSystem to get the operator to access ivars.

Initially I was thinking along these lines. But I became less sure. The "variable expression path" syntax is C-like but independent of the source language. For example, in Swift, there is no ->. So my rhetorical question is, should the Language or TypeSystem, etc, know about "variable expression path" syntax, as you suggest? Or should we rely on there being a shared subset between source language and variable expression path syntax, and allow the two subsystems to think they're speaking the same language even though we know they're each actually speaking a different but partially compatible language (source vs variable expression path).

I decided to keep the ->/. choice inside GetValueForVariableExpressionPath because I feel that kind of logic belongs closer to other variable expression path code.

Thu, Jun 16, 7:35 AM · Restricted Project, Restricted Project

Wed, Jun 15

jingham added a comment to D50304: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers.

For some reason I'm not getting mail notifications for review changes, sorry about that.

Wed, Jun 15, 12:24 PM · Restricted Project, Restricted Project
jingham added a comment to D126513: Add -b (--continue-to-breakpoint) option to the "process continue" command.

ping

Wed, Jun 15, 9:40 AM · Restricted Project, Restricted Project

Tue, Jun 14

jingham accepted D48865: [LLDB] CommandObjectThreadUntil::DoExecute() sets the wrong selected thread ID.

Sorry, I missed the "ping" notification. Still LGTM.

Tue, Jun 14, 5:13 PM · Restricted Project, Restricted Project

Fri, Jun 10

jingham accepted D127458: [lldb][bindings] Implement __repr__ instead of __str__.

This looks good to me as well. The job of "recreating the object from an eval of the repr output" is not even possible for many SB objects, by the time the object was made it's lost the factory invocation that produced it. And anyway, I also can't see a good use case for this. The fact that this gives us good output in lists of objects is also pretty persuasive.

Fri, Jun 10, 2:36 PM · Restricted Project, Restricted Project

Thu, Jun 9

jingham accepted D127410: [lldb] Add table with custom LLDB asserts.

Excellent, thanks for doing this, these are really handy asserts!

Thu, Jun 9, 9:04 AM · Restricted Project, Restricted Project

Wed, Jun 8

jingham committed rGaaaf8e4c409f: Add help text for "breakpoint name", describing the feature more fully. (authored by jingham).
Add help text for "breakpoint name", describing the feature more fully.
Wed, Jun 8, 4:56 PM · Restricted Project
jingham updated the diff for D126513: Add -b (--continue-to-breakpoint) option to the "process continue" command.

Fixed the option definition to specify this is a bkpt_id_list not a breakpoint id (since that's what it is now that we're using the breakpoint id list parser), and removed the verbiage that that made redundant.

Wed, Jun 8, 10:44 AM · Restricted Project, Restricted Project
jingham accepted D127252: [lldb] Use objc_getRealizedClassList_trylock if available.

One grammatical correction and a couple of questions. But I'm also fine with the way it is.

Wed, Jun 8, 9:45 AM · Restricted Project, Restricted Project

Tue, Jun 7

jingham added a comment to D126513: Add -b (--continue-to-breakpoint) option to the "process continue" command.

I have to fix the doc string for the -b option since it's now a bkpt_id_list. But that won't affect the logic so I'll do that and update the patch tomorrow.

Tue, Jun 7, 6:11 PM · Restricted Project, Restricted Project
jingham added a comment to D126513: Add -b (--continue-to-breakpoint) option to the "process continue" command.

Added the ability to specify breakpoint locations to run to as well as breakpoints and breakpoint names.

Tue, Jun 7, 6:08 PM · Restricted Project, Restricted Project
jingham added a comment to D126513: Add -b (--continue-to-breakpoint) option to the "process continue" command.

I noticed that the example python command and this feature don't support specifying breakpoint locations. Should it?

Tue, Jun 7, 6:08 PM · Restricted Project, Restricted Project
jingham updated the diff for D126513: Add -b (--continue-to-breakpoint) option to the "process continue" command.

Allow for specifying breakpoint locations as well as breakpoints.
Also fix the sync setting & resetting.

Tue, Jun 7, 6:06 PM · Restricted Project, Restricted Project

Fri, Jun 3

jingham added a comment to D127038: Add some documentation for the "breakpoint name" feature.

Mostly reworking the paragraph on breakpoint hiding.

Fri, Jun 3, 6:04 PM · Restricted Project, Restricted Project
jingham updated the diff for D127038: Add some documentation for the "breakpoint name" feature.

Address review comments.

Fri, Jun 3, 6:02 PM · Restricted Project, Restricted Project
jingham added a comment to D127016: [lldb] Prevent crash due to reading memory from page zero..

More generally, you can tell which elements of the exe_ctx you need to check in any given command by looking at requirements for the command which are passed into the constructor for the command. Any entity that's required there, you don't need to check for, but otherwise, you do have to check. "CommandObjectMemoryRead" has:

Fri, Jun 3, 5:34 PM · Restricted Project, Restricted Project
jingham requested review of D127038: Add some documentation for the "breakpoint name" feature.
Fri, Jun 3, 5:12 PM · Restricted Project, Restricted Project
jingham committed rG8cc8b36f24d6: CommandObjectRegexCommand shouldn't put two commands on the history stack. (authored by jingham).
CommandObjectRegexCommand shouldn't put two commands on the history stack.
Fri, Jun 3, 11:35 AM · Restricted Project
jingham closed D126789: Stop regex commands from double entry into the history.
Fri, Jun 3, 11:35 AM · Restricted Project, Restricted Project
jingham updated the diff for D126789: Stop regex commands from double entry into the history.

Fix a comment that hadn't been correct for a while...

Fri, Jun 3, 11:32 AM · Restricted Project, Restricted Project
jingham added inline comments to D126789: Stop regex commands from double entry into the history.
Fri, Jun 3, 11:29 AM · Restricted Project, Restricted Project
jingham added inline comments to D126789: Stop regex commands from double entry into the history.
Fri, Jun 3, 11:26 AM · Restricted Project, Restricted Project

Wed, Jun 1

jingham added a comment to D126789: Stop regex commands from double entry into the history.

thank you for fixing!

Q: why does this test have this thin test_X/do_x_test separation?

Wed, Jun 1, 3:29 PM · Restricted Project, Restricted Project

Jun 1 2022

jingham added a comment to D126789: Stop regex commands from double entry into the history.

Note, the original code tries to finesse this by passing eLazyBoolCalculate, which then resolves to a check against the current command depth. But that check was wrong for SBDebugger.HandleCommand, which is considered at depth 0, and anyway, I don't think it ever makes sense to have the regex command add the resolved command to the history.

Jun 1 2022, 9:06 AM · Restricted Project, Restricted Project
jingham updated the summary of D126789: Stop regex commands from double entry into the history.
Jun 1 2022, 9:02 AM · Restricted Project, Restricted Project
jingham requested review of D126789: Stop regex commands from double entry into the history.
Jun 1 2022, 9:02 AM · Restricted Project, Restricted Project

May 31 2022

jingham committed rGd92f7f790c8e: Fix a copy-paste error in "br com add -s py -o 'some_python' BKPT_NAME" (authored by jingham).
Fix a copy-paste error in "br com add -s py -o 'some_python' BKPT_NAME"
May 31 2022, 5:24 PM · Restricted Project
jingham closed D126730: Fix a bug where `break com add -s py -o "some_python" BKPT_NAME` only added the command to the first breakpoint.
May 31 2022, 5:24 PM · Restricted Project, Restricted Project
jingham requested review of D126730: Fix a bug where `break com add -s py -o "some_python" BKPT_NAME` only added the command to the first breakpoint.
May 31 2022, 3:51 PM · Restricted Project, Restricted Project

May 26 2022

jingham requested review of D126513: Add -b (--continue-to-breakpoint) option to the "process continue" command.
May 26 2022, 6:37 PM · Restricted Project, Restricted Project
jingham committed rG134d7f9a4b97: Store a by name list of signals with their actions in the Target (authored by jingham).
Store a by name list of signals with their actions in the Target
May 26 2022, 2:51 PM · Restricted Project
jingham closed D126259: Add the ability to specify signal actions (pass, stop or notify) for a signal before a process is created.
May 26 2022, 2:50 PM · Restricted Project, Restricted Project
jingham added inline comments to D126259: Add the ability to specify signal actions (pass, stop or notify) for a signal before a process is created.
May 26 2022, 2:40 PM · Restricted Project, Restricted Project
Herald added a project to D68671: Add the ability to pass extra args to a Python breakpoint command function: Restricted Project.

Just for history's sake, this change was committed (738af7a6241c9). I put in the Differential Revision line in the changelog, so I'm not sure why this didn't get marked as closed...

May 26 2022, 10:51 AM · Restricted Project, Restricted Project

May 25 2022

jingham added inline comments to D126259: Add the ability to specify signal actions (pass, stop or notify) for a signal before a process is created.
May 25 2022, 4:17 PM · Restricted Project, Restricted Project
jingham updated the diff for D126259: Add the ability to specify signal actions (pass, stop or notify) for a signal before a process is created.

Address Jonas' review comments

May 25 2022, 4:16 PM · Restricted Project, Restricted Project

May 24 2022

jingham added a comment to D125148: Add an example command that runs to one of a set of breakpoints.

The patch gets a little hard to read with all the no-longer in the right places comments, but I think I addressed everything.

May 24 2022, 4:43 PM · Restricted Project, Restricted Project
jingham updated the diff for D125148: Add an example command that runs to one of a set of breakpoints.

Added support for breakpoint names as well as ID's.
Addressed other review comments.

May 24 2022, 4:39 PM · Restricted Project, Restricted Project
jingham added a comment to D126259: Add the ability to specify signal actions (pass, stop or notify) for a signal before a process is created.

Don't allow setting signal actions by signal number before you have a process.

I understand

We don't know what signal 20 is going to end up being till we have a process, so allowing this by number doesn't make sense.

I am saying that it would be a good idea to make sure an error is returned when you do try and set a signal by number before a process exists and make sure there is a test that covers this if it isn't already in the current patch.

May 24 2022, 3:44 PM · Restricted Project, Restricted Project
jingham added a comment to D126259: Add the ability to specify signal actions (pass, stop or notify) for a signal before a process is created.

So the "process handle" command allows us to set signals by signal number as well. Does this patch support this? It seems like it wouldn't be too hard to do if we wanted to handle this. Lemme know what you think, other than that LGTM.

Ah, I forgot about specifying the signal by number. Before you have a process I don't think we should allow signals by number. The mapping signal number -> "signal name for any platform" is not 1-1 so we couldn't guarantee we were doing the right thing here. I'll put in a check for "specified by number with no process" and error out.

I would add a test for this and make sure it fails gracefully in that case

May 24 2022, 12:09 PM · Restricted Project, Restricted Project
jingham updated the diff for D126259: Add the ability to specify signal actions (pass, stop or notify) for a signal before a process is created.

Don't allow setting signal actions by signal number before you have a process.

May 24 2022, 12:07 PM · Restricted Project, Restricted Project
jingham added a comment to D126259: Add the ability to specify signal actions (pass, stop or notify) for a signal before a process is created.

So the "process handle" command allows us to set signals by signal number as well. Does this patch support this? It seems like it wouldn't be too hard to do if we wanted to handle this. Lemme know what you think, other than that LGTM.

May 24 2022, 11:30 AM · Restricted Project, Restricted Project
jingham added a comment to D126259: Add the ability to specify signal actions (pass, stop or notify) for a signal before a process is created.

This patch treats the Signal structure held in the target differently from UnixSignals::Signal. The latter always has to have values for all three actions and needs to have a signal number. The former doesn't actually claim to know a signal number. After all, it might get set before we can know what signal number a given signal string has (signals with the same name do have different numbers on different platforms). So pretending it knows a signal number would just be confusing. Also, it doesn't record actual values, it records user intents, so it needs to be tri-state - thus the LazyBools.

May 24 2022, 10:00 AM · Restricted Project, Restricted Project

May 23 2022

jingham requested review of D126259: Add the ability to specify signal actions (pass, stop or notify) for a signal before a process is created.
May 23 2022, 5:21 PM · Restricted Project, Restricted Project

May 20 2022

jingham committed rGb369762beb70: Convert the test file for TestIgnoredExceptions.py to the mach_vm API. (authored by jingham).
Convert the test file for TestIgnoredExceptions.py to the mach_vm API.
May 20 2022, 3:16 PM · Restricted Project
jingham committed rG9385a6d6eaa3: Add some diagnostics to diagnose bot-only failures for TestIgnoredExceptions.py (authored by jingham).
Add some diagnostics to diagnose bot-only failures for TestIgnoredExceptions.py
May 20 2022, 11:39 AM · Restricted Project
jingham accepted D126057: [lldb] Fix that empty target.run-args are not actually used when launching process.

GetPropertyAtIndexAsArg isn't actually documented, so we don't know what the original intent for the return value was. But in almost all the cases where we look up a property using this function, when we use the enum directly we discard the result. In the only other case (GetUserSpecifiedTrapHandlerNames) were we do return the result of the GetProperty... function, the return result of the GetUser... function is always discarded. So it seems pretty clear that the result was just supposed to be "couldn't find the property". It's also weird to conflate "couldn't find property" with "property has an empty value".

May 20 2022, 9:36 AM · Restricted Project, Restricted Project

May 18 2022

jingham committed rGbff4673b4178: Add a darwin platform setting to specify which exceptions debugserver (authored by jingham).
Add a darwin platform setting to specify which exceptions debugserver
May 18 2022, 10:16 AM · Restricted Project
jingham closed D125434: Make a more convenient way to allow Darwin users to ignore certain Mach Exceptions.
May 18 2022, 10:16 AM · Restricted Project, Restricted Project
jingham updated the diff for D125434: Make a more convenient way to allow Darwin users to ignore certain Mach Exceptions.

Address review comments

May 18 2022, 10:13 AM · Restricted Project, Restricted Project
jingham added a comment to D125434: Make a more convenient way to allow Darwin users to ignore certain Mach Exceptions.

Addressed review comments.

May 18 2022, 10:13 AM · Restricted Project, Restricted Project

May 17 2022

jingham committed rG7afd257ff8a4: Fix the std::string formatter to report errors in the case where the (authored by jingham).
Fix the std::string formatter to report errors in the case where the
May 17 2022, 8:22 AM · Restricted Project
jingham closed D108228: Fix error handling in the libcxx std::string formatter.
May 17 2022, 8:22 AM · Restricted Project, Restricted Project

May 12 2022

jingham committed rG2a21700bc5be: In 92eaad2dd7adb5ee92f397cef85ab11f2612294e I made it possible to run (authored by jingham).
In 92eaad2dd7adb5ee92f397cef85ab11f2612294e I made it possible to run
May 12 2022, 5:11 PM · Restricted Project
jingham closed D124947: Allow `target create` with no local file.
May 12 2022, 5:11 PM · Restricted Project, Restricted Project
jingham requested changes to D125505: Cache tilde expansions to avoid redundant lookups.

I don't think the cache belongs in a global in the TildeExpressionResolver class. The derived ExpressionResolvers might very well resolve the same ~foo to different paths (e.g. if there were a RemoteTildeExpressionResolver.) So the cache needs to be kept in the derived class rather than in a global object. Maybe just add an abstract GetTildeCache method to TildeExpressionResolver to fetch the cache from the subclass?

May 12 2022, 4:17 PM · Restricted Project, Restricted Project
jingham committed rGc6799d98435d: Revision 3339000e0bda696c2e29173d15958c0a4978a143 caused the Language (authored by jingham).
Revision 3339000e0bda696c2e29173d15958c0a4978a143 caused the Language
May 12 2022, 2:32 PM · Restricted Project
jingham accepted D125437: [lldb/API] Add SBCompileUnit::GetIndexForLineEntry method to SB API.

LGTM

May 12 2022, 12:42 PM · Restricted Project, Restricted Project
jingham committed rG3339000e0bda: We don't require users to type out the full context of a function, for (authored by jingham).
We don't require users to type out the full context of a function, for
May 12 2022, 12:40 PM · Restricted Project
jingham closed D124579: Make partial function name matching match on context boundaries.
May 12 2022, 12:39 PM · Restricted Project, Restricted Project

May 11 2022

jingham requested changes to D125437: [lldb/API] Add SBCompileUnit::GetIndexForLineEntry method to SB API.

This needs a doctoring for the API and some test.

May 11 2022, 5:37 PM · Restricted Project, Restricted Project
jingham updated the summary of D125434: Make a more convenient way to allow Darwin users to ignore certain Mach Exceptions.
May 11 2022, 5:24 PM · Restricted Project, Restricted Project
jingham requested review of D125434: Make a more convenient way to allow Darwin users to ignore certain Mach Exceptions.
May 11 2022, 4:58 PM · Restricted Project, Restricted Project
jingham added a comment to D125325: Pass plugin_name in SBProcess::SaveCore.

Hi Greg.

Thanks for the review.
I fixed the feedback.
I forgot the default initialization of plugin_name parameter in SBProcess.i in previous version, but I assume it's still better to explicitly create a separate method.

May 11 2022, 9:12 AM · Restricted Project, Restricted Project

May 10 2022

jingham committed rG63865e1fce62: Add the "sent break" message to the "gdb-remote packets" channel (authored by jingham).
Add the "sent break" message to the "gdb-remote packets" channel
May 10 2022, 1:29 PM · Restricted Project

May 6 2022

jingham requested review of D125148: Add an example command that runs to one of a set of breakpoints.
May 6 2022, 5:05 PM · Restricted Project, Restricted Project

May 5 2022

jingham requested changes to D124731: [lldb] Consider binary as module of last resort.

This seems like a reasonable fallback, and the implementation looks fine.
You need to add a test case setting an address breakpoint in the executable and making sure that works. Should be easy, set a line breakpoint in the main executable, get the resolved address and set an address breakpoint with that and make sure that breakpoint got a location.
You should also add some words to the "break set" command help saying that this is the fallback behavior.

May 5 2022, 11:28 AM · Restricted Project, Restricted Project

May 4 2022

jingham requested review of D124947: Allow `target create` with no local file.
May 4 2022, 10:33 AM · Restricted Project, Restricted Project

Apr 29 2022

jingham added inline comments to D124579: Make partial function name matching match on context boundaries.
Apr 29 2022, 2:59 PM · Restricted Project, Restricted Project
jingham updated the diff for D124579: Make partial function name matching match on context boundaries.

Address review comments.

Apr 29 2022, 2:51 PM · Restricted Project, Restricted Project
Herald added a project to D119997: Add a little test for simple breaking on overloaded functions by name: Restricted Project.

This was submitted (dd8490d207d3a1612091abbea04bf660f133a89f) but I neglected to put the "Differential Revision" tag in the commit message so automation didn't pick that up...

Apr 29 2022, 11:14 AM · Restricted Project, Restricted Project
jingham committed rGaa7470a1b313: Add a paragraph showing how to use container commands. (authored by jingham).
Add a paragraph showing how to use container commands.
Apr 29 2022, 11:12 AM · Restricted Project
jingham closed D124028: Add some docs on how to use container commands to the python reference doc.
Apr 29 2022, 11:12 AM · Restricted Project, Restricted Project
jingham committed rGdca2bc408186: Add a mutex to the ThreadPlanStackMap class. (authored by jingham).
Add a mutex to the ThreadPlanStackMap class.
Apr 29 2022, 11:09 AM · Restricted Project
jingham closed D124029: Add a mutex to the ThreadPlanStackMap to prevent it getting corrupted.
Apr 29 2022, 11:08 AM · Restricted Project, Restricted Project
jingham accepted D124597: Select the correct DWARF location list entry when looking for variable locations.

The change seems correct. Since the test only requires -01, and the test code is quite straightforward, the test seems fine.

Apr 29 2022, 11:03 AM · Restricted Project, Restricted Project
Herald added a project to D117383: [lldb] Expose std::pair children for unordered_map: Restricted Project.

Sorry for the delay here.

Apr 29 2022, 10:53 AM · Restricted Project, Restricted Project
jingham accepted D123204: [lldb] Fix initialization of LazyBool/bool variables m_overwrite/m_overwrite_lazy. NFCI..

Thanks for these cleanups. In actual fact, the values set for options in the constructor for CommandOptions are never used, only the values in OptionParsingStarted matter. But it's still confusing to have them be wrong...

Apr 29 2022, 10:34 AM · Restricted Project, Restricted Project