Page MenuHomePhabricator

yinghuitan (jeffrey tan)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 11 2016, 4:06 PM (258 w, 5 d)

Recent Activity

Aug 3 2021

yinghuitan committed rGb9139acb85a4: Fix expression evaluation result expansion in lldb-vscode (authored by yinghuitan).
Fix expression evaluation result expansion in lldb-vscode
Aug 3 2021, 3:32 PM
yinghuitan closed D105166: Fix expression evaluation result expansion in lldb-vscode.
Aug 3 2021, 3:32 PM · Restricted Project

Jul 26 2021

yinghuitan added inline comments to D105166: Fix expression evaluation result expansion in lldb-vscode.
Jul 26 2021, 2:52 PM · Restricted Project
yinghuitan updated the diff for D105166: Fix expression evaluation result expansion in lldb-vscode.

Fix the issue in setVariable request.

Jul 26 2021, 2:52 PM · Restricted Project

Jul 23 2021

yinghuitan added inline comments to D105166: Fix expression evaluation result expansion in lldb-vscode.
Jul 23 2021, 6:18 PM · Restricted Project

Jul 20 2021

yinghuitan added inline comments to D105166: Fix expression evaluation result expansion in lldb-vscode.
Jul 20 2021, 6:57 PM · Restricted Project
yinghuitan added a comment to D105166: Fix expression evaluation result expansion in lldb-vscode.

Debug console and VScode UI synchronization is a much bigger topic than instruction level stepping so I do not plan to fix in this patch. For example, if user change value via lldb comamnd, the watch/locals won't change. If user switch stack frames/threads, it won't reflect in VScode UI. It needs a thorough discussion to cover all the synchronization issues.

Jul 20 2021, 6:51 PM · Restricted Project
yinghuitan updated the diff for D105166: Fix expression evaluation result expansion in lldb-vscode.

Last push failed to include the changes due to git issue. Push including the real changes.

Jul 20 2021, 6:46 PM · Restricted Project
yinghuitan added inline comments to D105166: Fix expression evaluation result expansion in lldb-vscode.
Jul 20 2021, 2:39 PM · Restricted Project
yinghuitan updated the diff for D105166: Fix expression evaluation result expansion in lldb-vscode.

Address review comments.

Jul 20 2021, 2:39 PM · Restricted Project

Jul 1 2021

yinghuitan updated the diff for D105166: Fix expression evaluation result expansion in lldb-vscode.

Address review comments and add testcase.

Jul 1 2021, 10:52 AM · Restricted Project

Jun 30 2021

yinghuitan added inline comments to D105166: Fix expression evaluation result expansion in lldb-vscode.
Jun 30 2021, 2:49 PM · Restricted Project

Jun 29 2021

yinghuitan updated the diff for D105166: Fix expression evaluation result expansion in lldb-vscode.

rebase to latest master

Jun 29 2021, 8:54 PM · Restricted Project
yinghuitan updated the diff for D105166: Fix expression evaluation result expansion in lldb-vscode.

Rerun linter

Jun 29 2021, 8:50 PM · Restricted Project
yinghuitan updated the diff for D105166: Fix expression evaluation result expansion in lldb-vscode.

Address review comments

Jun 29 2021, 8:40 PM · Restricted Project
yinghuitan requested review of D105166: Fix expression evaluation result expansion in lldb-vscode.
Jun 29 2021, 6:34 PM · Restricted Project

Mar 29 2021

yinghuitan added inline comments to D99401: Fix .debug_aranges parsing issues introduced with llvm error handling in LLDB.
Mar 29 2021, 3:48 PM · Restricted Project

Feb 12 2021

yinghuitan requested review of D96623: [lldb-vscode] Fix lldb init file stdout issue.
Feb 12 2021, 11:30 AM · Restricted Project