Page MenuHomePhabricator

yinghuitan (jeffrey tan)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 11 2016, 4:06 PM (311 w, 1 d)

Recent Activity

Yesterday

yinghuitan accepted D134842: Improve dynamic loader support in DynamicLoaderPOSIXDYLD when using core files..

I think @labath or anyone owns the ELF coredump debugging should take a look. I am surprised other major companies did not hit this issue.

Wed, Sep 28, 9:54 PM · Restricted Project, Restricted Project
yinghuitan accepted D134333: When there are variable errors, display an error in VS Code's local variables view..
Wed, Sep 28, 9:37 PM · Restricted Project, Restricted Project

Tue, Sep 27

yinghuitan accepted D134508: Track which modules have debug info variable errors..
Tue, Sep 27, 11:55 AM · Restricted Project, Restricted Project
yinghuitan accepted D134333: When there are variable errors, display an error in VS Code's local variables view..

LGTM pending Pavel's suggestion.

Tue, Sep 27, 11:53 AM · Restricted Project, Restricted Project

Thu, Sep 22

yinghuitan committed rGc5073ed5f929: Add auto source map deduce count statistics (authored by yinghuitan).
Add auto source map deduce count statistics
Thu, Sep 22, 2:53 PM · Restricted Project
yinghuitan closed D134483: Add auto source map deduce count statistics.
Thu, Sep 22, 2:53 PM · Restricted Project, Restricted Project
yinghuitan updated the diff for D134483: Add auto source map deduce count statistics.

rebase and trigger linter

Thu, Sep 22, 2:47 PM · Restricted Project, Restricted Project
yinghuitan requested review of D134483: Add auto source map deduce count statistics.
Thu, Sep 22, 2:36 PM · Restricted Project, Restricted Project

Wed, Sep 21

yinghuitan accepted D134252: Track .dwo/.dwp loading errors and notify user when viewing variables..

Technical wise this patch looks good. One concern is that these error messages are user facing but we are making it favoring debugging, like skeleton DIE, showing the DIE offset etc... which is not very useful/actionable for end users.
Ideally, the user facing messages should focus on two things: 1. what is wrong in plain english. 2. any suggestion to fix it (e.g. ensure running lldb from build repo root). The more technical messages (with DIE offset) can be printed to log channel instead.

Wed, Sep 21, 10:19 AM · Restricted Project, Restricted Project

Mon, Sep 19

yinghuitan added a comment to D134252: Track .dwo/.dwp loading errors and notify user when viewing variables..

Do you plan to detect missing dwp file from SymbolFileDWARF::GetDwpSymbolFile() as well?

Mon, Sep 19, 10:38 PM · Restricted Project, Restricted Project
yinghuitan committed rGdc9e6c52f3d8: Add auto deduce source map setting (authored by yinghuitan).
Add auto deduce source map setting
Mon, Sep 19, 1:42 PM · Restricted Project
yinghuitan closed D133042: Add auto deduce source map setting.
Mon, Sep 19, 1:41 PM · Restricted Project, Restricted Project

Fri, Sep 16

yinghuitan updated the diff for D133042: Add auto deduce source map setting.

Fix nit

Fri, Sep 16, 11:50 PM · Restricted Project, Restricted Project

Thu, Sep 15

yinghuitan updated the diff for D133042: Add auto deduce source map setting.

Address review feedback

Thu, Sep 15, 5:52 PM · Restricted Project, Restricted Project
yinghuitan added a comment to D133042: Add auto deduce source map setting.

@clayborg, now I see you want to make this option true by default while full paths one to be optional. Then sure, it makes sense.

Thu, Sep 15, 4:23 PM · Restricted Project, Restricted Project

Wed, Sep 14

yinghuitan abandoned D133908: Add auto deduce source map setting.
Wed, Sep 14, 5:27 PM · Restricted Project, Restricted Project
yinghuitan updated the diff for D133042: Add auto deduce source map setting.

Address review comments

Wed, Sep 14, 5:26 PM · Restricted Project, Restricted Project
yinghuitan requested review of D133908: Add auto deduce source map setting.
Wed, Sep 14, 5:25 PM · Restricted Project, Restricted Project
yinghuitan added a comment to D133042: Add auto deduce source map setting.

@clayborg , it is my intention to make target.auto-deduce-source-map boolean flag ultimately working for both relative paths and two full paths (two full paths are really important for off build host debugging, e.g. dump or production debugging). In this patch, I focuses on getting relative path working because that's the default behavior; a follow-up patch can get two full paths working.
In my opinion boolean flag setting is dead simple to use (to enable both) and an enumeration setting would add extra barrier for adoption.

Wed, Sep 14, 4:38 PM · Restricted Project, Restricted Project

Mon, Sep 12

yinghuitan accepted D133164: Add the ability to show when variables fails to be available when debug info is valid..
Mon, Sep 12, 1:46 PM · Restricted Project, Restricted Project
yinghuitan added inline comments to D133038: Add SBDebugger::GetSetting() public API.
Mon, Sep 12, 10:25 AM · Restricted Project, Restricted Project

Sun, Sep 11

yinghuitan committed rGd5f54751048b: Add SBDebugger::GetSetting() public APIs (authored by yinghuitan).
Add SBDebugger::GetSetting() public APIs
Sun, Sep 11, 8:50 PM · Restricted Project
yinghuitan closed D133038: Add SBDebugger::GetSetting() public API.
Sun, Sep 11, 8:50 PM · Restricted Project, Restricted Project

Fri, Sep 9

yinghuitan updated the diff for D133038: Add SBDebugger::GetSetting() public API.

Address review comments

Fri, Sep 9, 2:49 PM · Restricted Project, Restricted Project
yinghuitan updated the diff for D133038: Add SBDebugger::GetSetting() public API.

Address review comments

Fri, Sep 9, 10:32 AM · Restricted Project, Restricted Project
yinghuitan added inline comments to D133038: Add SBDebugger::GetSetting() public API.
Fri, Sep 9, 9:38 AM · Restricted Project, Restricted Project

Thu, Sep 8

yinghuitan added a comment to D133038: Add SBDebugger::GetSetting() public API.
Thu, Sep 8, 5:53 PM · Restricted Project, Restricted Project
yinghuitan retitled D133038: Add SBDebugger::GetSetting() public API from Add SBDebugger::GetSetting()public APIs to Add SBDebugger::GetSetting() public API.
Thu, Sep 8, 5:52 PM · Restricted Project, Restricted Project
yinghuitan retitled D133038: Add SBDebugger::GetSetting() public API from Add SBDebugger::GetSetting()/GetSettings() public APIs to Add SBDebugger::GetSetting()public APIs.
Thu, Sep 8, 5:52 PM · Restricted Project, Restricted Project
yinghuitan updated the diff for D133038: Add SBDebugger::GetSetting() public API.

Address review comments

Thu, Sep 8, 5:48 PM · Restricted Project, Restricted Project
yinghuitan retitled D133038: Add SBDebugger::GetSetting() public API from Add GetSourceMap public API to Add SBDebugger::GetSetting()/GetSettings() public APIs.
Thu, Sep 8, 11:23 AM · Restricted Project, Restricted Project
yinghuitan updated the diff for D133038: Add SBDebugger::GetSetting() public API.

Address review feedback.

Thu, Sep 8, 11:22 AM · Restricted Project, Restricted Project

Thu, Sep 1

yinghuitan updated the summary of D133042: Add auto deduce source map setting.
Thu, Sep 1, 12:05 AM · Restricted Project, Restricted Project

Wed, Aug 31

yinghuitan requested review of D133042: Add auto deduce source map setting.
Wed, Aug 31, 12:17 PM · Restricted Project, Restricted Project
yinghuitan updated the diff for D133038: Add SBDebugger::GetSetting() public API.

Re-diff with clang-format

Wed, Aug 31, 11:49 AM · Restricted Project, Restricted Project
yinghuitan requested review of D133038: Add SBDebugger::GetSetting() public API.
Wed, Aug 31, 11:46 AM · Restricted Project, Restricted Project

Jul 13 2022

yinghuitan added a comment to D129307: Add a new breakpoint partial match settings.

From Jim, First off, I am supportive of your project, this is a pain point for some folks for sure. I am in favor of trying to automate "I built my binaries with sources in one location but locally they are in another" scenario.

Great to hear that! Seems all three companies are on the same page/goal to improve this area.

Jul 13 2022, 2:47 PM · Restricted Project, Restricted Project

Jul 12 2022

yinghuitan accepted D129528: Modify all register values whose byte size matches the address size to be formatter as eFormatAddressInfo..
Jul 12 2022, 5:17 PM · Restricted Project, Restricted Project

Jul 11 2022

yinghuitan added a comment to D129521: Add the ability to run expressions that call fork() or vfork()..

Change looks good to me. I will let @jingham take a second look before accepting.

Jul 11 2022, 9:54 PM · Restricted Project, Restricted Project
yinghuitan added inline comments to D129528: Modify all register values whose byte size matches the address size to be formatter as eFormatAddressInfo..
Jul 11 2022, 9:44 PM · Restricted Project, Restricted Project
yinghuitan added a comment to D129307: Add a new breakpoint partial match settings.

@jingham, thanks for sharing the thoughts.

Jul 11 2022, 1:27 PM · Restricted Project, Restricted Project

Jul 7 2022

yinghuitan updated the diff for D129307: Add a new breakpoint partial match settings.

Remove unnecessary format changes caused by IDE.

Jul 7 2022, 10:14 AM · Restricted Project, Restricted Project
yinghuitan requested review of D129307: Add a new breakpoint partial match settings.
Jul 7 2022, 10:03 AM · Restricted Project, Restricted Project

Jun 24 2022

yinghuitan added a comment to D127702: Support logpoints in lldb-vscode.

@cmtice, are you sure the failure is caused by/related with this patch? This is a pure lldb-vscode change which is not used by normal lldb. Also, no mention of code in this patch in the error message.

Jun 24 2022, 12:41 PM · Restricted Project, Restricted Project

Jun 20 2022

yinghuitan committed rG5109de2da2e2: Fix build break introduced by https://reviews.llvm.org/D127702 (authored by yinghuitan).
Fix build break introduced by https://reviews.llvm.org/D127702
Jun 20 2022, 5:32 PM · Restricted Project
yinghuitan closed D128234: Fix build break introduced by https://reviews.llvm.org/D127702.
Jun 20 2022, 5:31 PM · Restricted Project, Restricted Project
yinghuitan added a comment to D127702: Support logpoints in lldb-vscode.

Fixed in https://reviews.llvm.org/D128234

Jun 20 2022, 5:24 PM · Restricted Project, Restricted Project
yinghuitan requested review of D128234: Fix build break introduced by https://reviews.llvm.org/D127702.
Jun 20 2022, 5:23 PM · Restricted Project, Restricted Project
yinghuitan added a comment to D127702: Support logpoints in lldb-vscode.

Sorry, I was fooled by the buildbot which says everything is green. Working on a fix for the build break now.

Jun 20 2022, 5:18 PM · Restricted Project, Restricted Project
yinghuitan committed rG8c6e138aa893: Support logpoints in lldb-vscode (authored by yinghuitan).
Support logpoints in lldb-vscode
Jun 20 2022, 4:22 PM · Restricted Project
yinghuitan closed D127702: Support logpoints in lldb-vscode.
Jun 20 2022, 4:22 PM · Restricted Project, Restricted Project
yinghuitan updated the diff for D127702: Support logpoints in lldb-vscode.

Using a single structured LogMessagePart per suggestion.

Jun 20 2022, 11:24 AM · Restricted Project, Restricted Project

Jun 14 2022

yinghuitan added inline comments to D127702: Support logpoints in lldb-vscode.
Jun 14 2022, 10:22 AM · Restricted Project, Restricted Project

Jun 13 2022

yinghuitan updated the summary of D127702: Support logpoints in lldb-vscode.
Jun 13 2022, 3:26 PM · Restricted Project, Restricted Project
yinghuitan requested review of D127702: Support logpoints in lldb-vscode.
Jun 13 2022, 3:24 PM · Restricted Project, Restricted Project

May 23 2022

yinghuitan committed rGa1d490319a9e: Fix lldb-vscode frame test failure (authored by yinghuitan).
Fix lldb-vscode frame test failure
May 23 2022, 2:05 PM · Restricted Project
yinghuitan closed D126225: Fix lldb-vscode frame test failure.
May 23 2022, 2:05 PM · Restricted Project, Restricted Project
yinghuitan requested review of D126225: Fix lldb-vscode frame test failure.
May 23 2022, 10:21 AM · Restricted Project, Restricted Project
yinghuitan committed rG0fe220a33179: Show error message for optimized variables (authored by yinghuitan).
Show error message for optimized variables
May 23 2022, 10:05 AM · Restricted Project
yinghuitan closed D126014: Show error message for optimized variables.
May 23 2022, 10:05 AM · Restricted Project, Restricted Project
yinghuitan committed rG46c1f77e160a: Add [opt] suffix to optimized stack frame in lldb-vscode (authored by yinghuitan).
Add [opt] suffix to optimized stack frame in lldb-vscode
May 23 2022, 10:03 AM · Restricted Project
yinghuitan closed D126013: Add [opt] suffix to optimized stack frame in lldb-vscode.
May 23 2022, 10:03 AM · Restricted Project, Restricted Project

May 20 2022

yinghuitan updated the diff for D126013: Add [opt] suffix to optimized stack frame in lldb-vscode.

Address review comments

May 20 2022, 10:48 AM · Restricted Project, Restricted Project
yinghuitan added inline comments to D126013: Add [opt] suffix to optimized stack frame in lldb-vscode.
May 20 2022, 10:22 AM · Restricted Project, Restricted Project

May 19 2022

yinghuitan added reviewers for D126013: Add [opt] suffix to optimized stack frame in lldb-vscode: aadsm, kusmour.
May 19 2022, 1:27 PM · Restricted Project, Restricted Project
yinghuitan requested review of D126014: Show error message for optimized variables.
May 19 2022, 1:27 PM · Restricted Project, Restricted Project
yinghuitan requested review of D126013: Add [opt] suffix to optimized stack frame in lldb-vscode.
May 19 2022, 1:23 PM · Restricted Project, Restricted Project

May 16 2022

yinghuitan abandoned D124499: Rename conflict testcase.

Seems that this is a duplication to Pavel Labath's commit f513b5fc47df5c040a257ab6f4643942828fa610.

May 16 2022, 10:44 AM · Restricted Project, Restricted Project

May 11 2022

yinghuitan accepted D125347: Add "indexedVariables" to variables with lots of children..
May 11 2022, 4:03 PM · Restricted Project, Restricted Project

May 10 2022

yinghuitan added inline comments to D125347: Add "indexedVariables" to variables with lots of children..
May 10 2022, 6:00 PM · Restricted Project, Restricted Project

May 9 2022

yinghuitan added inline comments to D125253: Add the ability to debug through an exec into ld.
May 9 2022, 12:10 PM · Restricted Project, Restricted Project

Apr 28 2022

yinghuitan added a comment to D124572: Fix the encoding and decoding of UniqueCStringMap<T> objects when saved to cache files..

Also, to help diagnostics this kind of issue in future, it may worth to add an extra debug mode check in in UniqueCStringMap to ensure they are sorted. For example, in debug mode, add a m_isSorted flag which is set by UniqueCStringMap::Sort() method. All the binary search methods should assert m_isSorted == true.

Apr 28 2022, 8:20 AM · Restricted Project, Restricted Project

Apr 27 2022

yinghuitan accepted D124572: Fix the encoding and decoding of UniqueCStringMap<T> objects when saved to cache files..

This is a great finding! The change looks good. Some questions though:

  • Do you have any theory why we only see this issue on Mac not Linux? (For anyone else reading this, I found this bug during testing Mac but the same reproduce steps work on Linux)
  • Do we use/have data structures in other part of caching feature need similar change?
Apr 27 2022, 10:32 PM · Restricted Project, Restricted Project
yinghuitan added a comment to D124471: Disable symbol on-demand feature for Windows.

@labath, that's a good point. If I remember correctly, exported function symbols will be included in Windows COFF export address table (which I assume will be parsed by lldb symtab). So in theory, if we change the tests (or add new tests) to set symbolic function breakpoint on exported function symbols, they might work on Windows. I can spend some time looking once I got a Windows machine. But I agree it is a lower priority based on your input.

Apr 27 2022, 11:14 AM · Restricted Project, Restricted Project

Apr 26 2022

yinghuitan added a comment to D121631: Introduce new symbol on-demand for debug info.

Thanks for the context. Renames conflict testcase in https://reviews.llvm.org/D124499.

Apr 26 2022, 8:21 PM · Restricted Project, Restricted Project
yinghuitan requested review of D124499: Rename conflict testcase.
Apr 26 2022, 8:20 PM · Restricted Project, Restricted Project
yinghuitan added a comment to D121631: Introduce new symbol on-demand for debug info.

@jasonmolenda, thanks, I discovered a bit late that testcases can't have duplicate names; I fixed one case in the patch but missed these two. Will add a follow-up patch. It would be great if we have a linter/script to detect/warn duplications, not sure how hard to add though.

Apr 26 2022, 6:08 PM · Restricted Project, Restricted Project
yinghuitan committed rG0ffcec418e45: Fix missing import for test (authored by yinghuitan).
Fix missing import for test
Apr 26 2022, 4:41 PM · Restricted Project
yinghuitan closed D124479: Fix missing import for test.
Apr 26 2022, 4:40 PM · Restricted Project, Restricted Project
yinghuitan added a comment to D121631: Introduce new symbol on-demand for debug info.

Another patch to fix the missing import: https://reviews.llvm.org/D124479

Apr 26 2022, 2:35 PM · Restricted Project, Restricted Project
yinghuitan requested review of D124479: Fix missing import for test.
Apr 26 2022, 2:33 PM · Restricted Project, Restricted Project
yinghuitan committed rGd738d4717f6d: Disable symbol on-demand feature for Windows (authored by yinghuitan).
Disable symbol on-demand feature for Windows
Apr 26 2022, 1:36 PM · Restricted Project
yinghuitan closed D124471: Disable symbol on-demand feature for Windows.
Apr 26 2022, 1:35 PM · Restricted Project, Restricted Project
yinghuitan added a comment to D121631: Introduce new symbol on-demand for debug info.

@stella.stamenova, thanks for the heads-up. I am fixing this in https://reviews.llvm.org/D124471.

Apr 26 2022, 1:33 PM · Restricted Project, Restricted Project
yinghuitan requested review of D124471: Disable symbol on-demand feature for Windows.
Apr 26 2022, 12:18 PM · Restricted Project, Restricted Project
yinghuitan committed rG7b81192d462b: Introduce new symbol on-demand for debug info (authored by yinghuitan).
Introduce new symbol on-demand for debug info
Apr 26 2022, 10:42 AM · Restricted Project
yinghuitan closed D121631: Introduce new symbol on-demand for debug info.
Apr 26 2022, 10:42 AM · Restricted Project, Restricted Project

Apr 25 2022

yinghuitan updated the summary of D121631: Introduce new symbol on-demand for debug info.
Apr 25 2022, 6:37 PM · Restricted Project, Restricted Project
yinghuitan committed rG5cbf516cb79f: Refactor protected virtual functions from SymbolFile into new SymbolFileCommon… (authored by yinghuitan).
Refactor protected virtual functions from SymbolFile into new SymbolFileCommon…
Apr 25 2022, 6:34 PM · Restricted Project
yinghuitan closed D124110: Refactor protected virtual functions from SymbolFile into new SymbolFileActual class..
Apr 25 2022, 6:34 PM · Restricted Project, Restricted Project

Apr 24 2022

yinghuitan updated the diff for D121631: Introduce new symbol on-demand for debug info.

Incorporate feedback and update summary with follow-up todos.

Apr 24 2022, 7:27 PM · Restricted Project, Restricted Project
yinghuitan added a comment to D121631: Introduce new symbol on-demand for debug info.

Thanks for all the feedback. I will address the comments and add @clayborg's follow-up suggestions into summary.

Apr 24 2022, 7:19 PM · Restricted Project, Restricted Project
yinghuitan updated the diff for D124110: Refactor protected virtual functions from SymbolFile into new SymbolFileActual class..

Address review comment.

Apr 24 2022, 12:12 PM · Restricted Project, Restricted Project

Apr 21 2022

yinghuitan updated the diff for D121631: Introduce new symbol on-demand for debug info.

rebase

Apr 21 2022, 7:33 PM · Restricted Project, Restricted Project
yinghuitan updated the diff for D121631: Introduce new symbol on-demand for debug info.

rebase

Apr 21 2022, 3:44 PM · Restricted Project, Restricted Project
yinghuitan updated the diff for D124110: Refactor protected virtual functions from SymbolFile into new SymbolFileActual class..

Address review comments.

Apr 21 2022, 3:43 PM · Restricted Project, Restricted Project
yinghuitan added a comment to D124110: Refactor protected virtual functions from SymbolFile into new SymbolFileActual class..

Sounds good.

Apr 21 2022, 10:55 AM · Restricted Project, Restricted Project

Apr 20 2022

yinghuitan updated the diff for D121631: Introduce new symbol on-demand for debug info.

Rebase on top of https://reviews.llvm.org/D124110
Rename test file name to avoid conflict
Added a new totalModuleCountHasDebugInfo statistics

Apr 20 2022, 11:27 AM · Restricted Project, Restricted Project
yinghuitan requested review of D124110: Refactor protected virtual functions from SymbolFile into new SymbolFileActual class..
Apr 20 2022, 11:11 AM · Restricted Project, Restricted Project

Apr 12 2022

yinghuitan added a comment to D121631: Introduce new symbol on-demand for debug info.

Thanks for clarifying. The friendship declaration in SymbolFile is required not only for SetCompileUnitAtIndex but also for other protected virtual methods in SymbolFile like CalculateNumCompileUnits and ParseCompileUnitAtIndex which are pure virtual and require overriding and forwarding by SymbolFileOnDemand.
One solution I can think of is creating a new SymbolFileActual class as child class of SymbolFile and move all the protected virtual member functions from SymbolFile into SymbolFileActual, then modify the callsites of these protected virtual member functions into SymbolFileActual as well. This will get rid of friend declaration and SymbolFile won't/can't have protected virtual member functions. Something like below:

Apr 12 2022, 7:36 AM · Restricted Project, Restricted Project