Page MenuHomePhabricator

jsetoain (Javier Setoain)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 16 2020, 9:13 AM (128 w, 1 d)

Recent Activity

Mon, Jun 27

jsetoain added inline comments to D127875: [mlir][vector] Add vector.scalable.insert/extract ops.
Mon, Jun 27, 9:50 AM · Restricted Project, Restricted Project
jsetoain updated the diff for D127875: [mlir][vector] Add vector.scalable.insert/extract ops.

Answer comments and rebase on main

Mon, Jun 27, 9:50 AM · Restricted Project, Restricted Project
jsetoain committed rGf39c2a114283: [mlir][llvm] Add vector insert/extract intrinsics (authored by jsetoain).
[mlir][llvm] Add vector insert/extract intrinsics
Mon, Jun 27, 6:16 AM · Restricted Project, Restricted Project
jsetoain closed D127100: [mlir][llvm] Add vector insert/extract intrinsics.
Mon, Jun 27, 6:15 AM · Restricted Project, Restricted Project
jsetoain updated the diff for D127100: [mlir][llvm] Add vector insert/extract intrinsics.

Rebase on top of main with LLVM vector.insert/extract outside of experimental

Mon, Jun 27, 4:55 AM · Restricted Project, Restricted Project

Tue, Jun 21

jsetoain added inline comments to D127976: [IR] Move vector.insert/vector.extract out of experimental namespace.
Tue, Jun 21, 10:05 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Jun 20

jsetoain updated the diff for D121304: [mlir][sparse][ArmSVE] Add sparse integration tests for ArmSVE.

Move test to ArmSVE-specific directory

Mon, Jun 20, 7:50 AM · Restricted Project, Restricted Project

Fri, Jun 17

jsetoain published D121304: [mlir][sparse][ArmSVE] Add sparse integration tests for ArmSVE for review.
Fri, Jun 17, 12:24 AM · Restricted Project, Restricted Project

Thu, Jun 16

jsetoain added inline comments to D128027: [mlir] Start migrating more dialects to prefixed form.
Thu, Jun 16, 11:11 PM · Restricted Project, Restricted Project
jsetoain updated the diff for D127100: [mlir][llvm] Add vector insert/extract intrinsics.

Add missing constraints.

Thu, Jun 16, 1:03 PM · Restricted Project, Restricted Project
jsetoain published D127875: [mlir][vector] Add vector.scalable.insert/extract ops for review.
Thu, Jun 16, 12:38 PM · Restricted Project, Restricted Project
jsetoain added a comment to D127100: [mlir][llvm] Add vector insert/extract intrinsics.

I believe this change addresses the issue with vectors being too long. I also changed the constraints to match those of the LLVM intrinsic.

Thu, Jun 16, 11:04 AM · Restricted Project, Restricted Project
jsetoain updated the diff for D127100: [mlir][llvm] Add vector insert/extract intrinsics.

Adding verification of vector sizes, allowing more modes of operation.

Thu, Jun 16, 11:01 AM · Restricted Project, Restricted Project
jsetoain added a comment to D127100: [mlir][llvm] Add vector insert/extract intrinsics.

Brilliant! Thanks for heads up, Bradley!

Thu, Jun 16, 10:09 AM · Restricted Project, Restricted Project

Wed, Jun 15

jsetoain updated the diff for D127100: [mlir][llvm] Add vector insert/extract intrinsics.

Accept fixed-lenght insert/extract

Wed, Jun 15, 7:13 AM · Restricted Project, Restricted Project
jsetoain abandoned D127758: [mlir][vector] Add cast op between scalable and fixed-length vectors.
Wed, Jun 15, 3:01 AM · Restricted Project, Restricted Project

Tue, Jun 14

jsetoain added inline comments to D127758: [mlir][vector] Add cast op between scalable and fixed-length vectors.
Tue, Jun 14, 2:33 PM · Restricted Project, Restricted Project
jsetoain added a reviewer for D127758: [mlir][vector] Add cast op between scalable and fixed-length vectors: dcaballe.
Tue, Jun 14, 8:56 AM · Restricted Project, Restricted Project
jsetoain requested review of D127758: [mlir][vector] Add cast op between scalable and fixed-length vectors.
Tue, Jun 14, 8:55 AM · Restricted Project, Restricted Project

Wed, Jun 8

jsetoain added inline comments to D127100: [mlir][llvm] Add vector insert/extract intrinsics.
Wed, Jun 8, 2:01 AM · Restricted Project, Restricted Project

Tue, Jun 7

jsetoain added inline comments to D127100: [mlir][llvm] Add vector insert/extract intrinsics.
Tue, Jun 7, 2:26 AM · Restricted Project, Restricted Project

Mon, Jun 6

jsetoain updated the diff for D127100: [mlir][llvm] Add vector insert/extract intrinsics.

Bad merge

Mon, Jun 6, 5:43 AM · Restricted Project, Restricted Project
jsetoain added a reviewer for D127100: [mlir][llvm] Add vector insert/extract intrinsics: dcaballe.
Mon, Jun 6, 4:06 AM · Restricted Project, Restricted Project
jsetoain requested review of D127100: [mlir][llvm] Add vector insert/extract intrinsics.
Mon, Jun 6, 4:05 AM · Restricted Project, Restricted Project

May 25 2022

jsetoain abandoned D125855: [mlir][ArmSVE] Remove unnecessary ops.
May 25 2022, 3:47 PM · Restricted Project, Restricted Project

May 19 2022

jsetoain added a comment to D125855: [mlir][ArmSVE] Remove unnecessary ops.

I am not very convinced by the motivation of LLVM backend selecting the appropriate instructions. On other platforms, we have repeatedly seen the selection being fragile and sensitive to factors beyond our control, so I would rather have the possibility to target these directly even if it is not being used by some compilations pipelnes.

May 19 2022, 8:48 AM · Restricted Project, Restricted Project

May 18 2022

jsetoain requested review of D125855: [mlir][ArmSVE] Remove unnecessary ops.
May 18 2022, 12:16 AM · Restricted Project, Restricted Project

Apr 28 2022

jsetoain committed rG6301574206b3: [mlir][SparseTensor] Enable VLA ops in index value generation (authored by jsetoain).
[mlir][SparseTensor] Enable VLA ops in index value generation
Apr 28 2022, 1:46 AM · Restricted Project, Restricted Project
jsetoain closed D124454: [mlir][sparse] Enable VLA ops in index value generation.
Apr 28 2022, 1:45 AM · Restricted Project, Restricted Project

Apr 27 2022

jsetoain added inline comments to D124454: [mlir][sparse] Enable VLA ops in index value generation.
Apr 27 2022, 2:32 AM · Restricted Project, Restricted Project
jsetoain updated the diff for D124454: [mlir][sparse] Enable VLA ops in index value generation.

Replace unrealized cast with index cast

Apr 27 2022, 2:30 AM · Restricted Project, Restricted Project

Apr 26 2022

jsetoain retitled D124454: [mlir][sparse] Enable VLA ops in index value generation from [mlir][SparseTensor] Enable VLA ops in index value generation to [mlir][sparse] Enable VLA ops in index value generation.
Apr 26 2022, 7:12 AM · Restricted Project, Restricted Project
jsetoain updated the diff for D124454: [mlir][sparse] Enable VLA ops in index value generation.

Clang format

Apr 26 2022, 7:06 AM · Restricted Project, Restricted Project
jsetoain requested review of D124454: [mlir][sparse] Enable VLA ops in index value generation.
Apr 26 2022, 7:05 AM · Restricted Project, Restricted Project

Mar 29 2022

jsetoain committed rG7bc8ad5109eb: [mlir][vector][nfc] Rename index optimizations option (authored by jsetoain).
[mlir][vector][nfc] Rename index optimizations option
Mar 29 2022, 3:35 AM · Restricted Project, Restricted Project
jsetoain closed D122415: [mlir][vector][nfc] Rename index optimizations option.
Mar 29 2022, 3:35 AM · Restricted Project, Restricted Project

Mar 25 2022

jsetoain committed rGccb54d5b4203: [mlir][Vector] Add integration tests for ArmSVE (authored by jsetoain).
[mlir][Vector] Add integration tests for ArmSVE
Mar 25 2022, 6:22 AM · Restricted Project, Restricted Project
jsetoain closed D104517: [mlir][Vector] Add integration tests for ArmSVE.
Mar 25 2022, 6:21 AM · Restricted Project, Restricted Project
jsetoain updated the diff for D104517: [mlir][Vector] Add integration tests for ArmSVE.

Rebase on main

Mar 25 2022, 6:13 AM · Restricted Project, Restricted Project
jsetoain committed rG7783a178f575: [mlir][Sparse] Add option for VLA sparsification (authored by jsetoain).
[mlir][Sparse] Add option for VLA sparsification
Mar 25 2022, 3:56 AM · Restricted Project, Restricted Project
jsetoain closed D118379: [mlir][Sparse] Add option for VLA sparsification.
Mar 25 2022, 3:56 AM · Restricted Project, Restricted Project
jsetoain committed rGa75a46db89f3: [mlir][Vector] Enable create_mask for scalable vectors (authored by jsetoain).
[mlir][Vector] Enable create_mask for scalable vectors
Mar 25 2022, 3:50 AM · Restricted Project, Restricted Project
jsetoain closed D118248: [mlir][Vector] Enable create_mask for scalable vectors.
Mar 25 2022, 3:50 AM · Restricted Project, Restricted Project

Mar 24 2022

jsetoain added inline comments to D118248: [mlir][Vector] Enable create_mask for scalable vectors.
Mar 24 2022, 12:48 PM · Restricted Project, Restricted Project
jsetoain requested review of D122415: [mlir][vector][nfc] Rename index optimizations option.
Mar 24 2022, 9:55 AM · Restricted Project, Restricted Project
jsetoain added inline comments to D118248: [mlir][Vector] Enable create_mask for scalable vectors.
Mar 24 2022, 8:35 AM · Restricted Project, Restricted Project
jsetoain updated the diff for D118248: [mlir][Vector] Enable create_mask for scalable vectors.

Address reviewer comments

Mar 24 2022, 8:33 AM · Restricted Project, Restricted Project
jsetoain added inline comments to D118248: [mlir][Vector] Enable create_mask for scalable vectors.
Mar 24 2022, 4:36 AM · Restricted Project, Restricted Project
jsetoain updated the diff for D118248: [mlir][Vector] Enable create_mask for scalable vectors.

Address reviewer comments

Mar 24 2022, 4:36 AM · Restricted Project, Restricted Project

Mar 23 2022

jsetoain added a reviewer for D118248: [mlir][Vector] Enable create_mask for scalable vectors: dcaballe.
Mar 23 2022, 9:06 AM · Restricted Project, Restricted Project

Mar 9 2022

jsetoain added a comment to D118248: [mlir][Vector] Enable create_mask for scalable vectors.

Thanks for the review, Aart!

Mar 9 2022, 2:02 AM · Restricted Project, Restricted Project
jsetoain updated the diff for D118248: [mlir][Vector] Enable create_mask for scalable vectors.

Address reviewer comments

Mar 9 2022, 2:01 AM · Restricted Project, Restricted Project

Mar 8 2022

jsetoain committed rGf2b89c7ae083: [mlir][Vector] Use create_mask in transfer mask materializations (authored by jsetoain).
[mlir][Vector] Use create_mask in transfer mask materializations
Mar 8 2022, 1:09 AM · Restricted Project
jsetoain closed D120487: [mlir][Vector] Use create_mask in transfer mask materializations.
Mar 8 2022, 1:09 AM · Restricted Project, Restricted Project

Mar 4 2022

Herald added a project to D118248: [mlir][Vector] Enable create_mask for scalable vectors: Restricted Project.

@ftynse Hi Alex, I just wanted to kindly remind you about this patch, after the discussion in discourse nobody else seems to have anything against it, and it's currently blocking a stack of approved patches. Thank you!

Mar 4 2022, 8:39 AM · Restricted Project, Restricted Project

Feb 24 2022

jsetoain updated the diff for D120487: [mlir][Vector] Use create_mask in transfer mask materializations.

Clean-up patch

Feb 24 2022, 7:30 AM · Restricted Project, Restricted Project
jsetoain requested review of D120487: [mlir][Vector] Use create_mask in transfer mask materializations.
Feb 24 2022, 7:22 AM · Restricted Project, Restricted Project
jsetoain committed rGcd0d21b47b5e: [mlir][LLVM] Allow scalable vectors in ShuffleVectorOp (authored by jsetoain).
[mlir][LLVM] Allow scalable vectors in ShuffleVectorOp
Feb 24 2022, 3:35 AM
jsetoain closed D118371: [mlir][LLVM] Allow scalable vectors in ShuffleVectorOp.
Feb 24 2022, 3:35 AM · Restricted Project

Feb 23 2022

jsetoain added inline comments to D118371: [mlir][LLVM] Allow scalable vectors in ShuffleVectorOp.
Feb 23 2022, 3:46 AM · Restricted Project
jsetoain updated the diff for D118371: [mlir][LLVM] Allow scalable vectors in ShuffleVectorOp.

Change error message

Feb 23 2022, 3:41 AM · Restricted Project

Feb 21 2022

jsetoain updated the diff for D118248: [mlir][Vector] Enable create_mask for scalable vectors.

Address comments

Feb 21 2022, 8:38 AM · Restricted Project, Restricted Project
jsetoain updated the diff for D118379: [mlir][Sparse] Add option for VLA sparsification.

Fix missing case in type casting

Feb 21 2022, 7:17 AM · Restricted Project, Restricted Project
jsetoain added a reviewer for D118371: [mlir][LLVM] Allow scalable vectors in ShuffleVectorOp: c-rhodes.
Feb 21 2022, 2:38 AM · Restricted Project
jsetoain added a reviewer for D118248: [mlir][Vector] Enable create_mask for scalable vectors: c-rhodes.
Feb 21 2022, 2:38 AM · Restricted Project, Restricted Project

Feb 17 2022

jsetoain added inline comments to D118248: [mlir][Vector] Enable create_mask for scalable vectors.
Feb 17 2022, 10:15 AM · Restricted Project, Restricted Project
jsetoain updated the diff for D118248: [mlir][Vector] Enable create_mask for scalable vectors.

Accept particular cases of scalable constant masks.

Feb 17 2022, 9:56 AM · Restricted Project, Restricted Project
jsetoain updated the diff for D118371: [mlir][LLVM] Allow scalable vectors in ShuffleVectorOp.

Add constraint for shuffles on scalable vectors

Feb 17 2022, 3:10 AM · Restricted Project

Feb 15 2022

jsetoain updated the diff for D118379: [mlir][Sparse] Add option for VLA sparsification.

Adapt test to changes in vector.reduce

Feb 15 2022, 9:55 AM · Restricted Project, Restricted Project
jsetoain committed rG71705f531f6e: [mlir][Arith] Disallow casting between scalable and fixed-length vectors (authored by jsetoain).
[mlir][Arith] Disallow casting between scalable and fixed-length vectors
Feb 15 2022, 9:35 AM
jsetoain closed D119568: [mlir][Arith] Disallow casting between scalable and fixed-length vectors.
Feb 15 2022, 9:35 AM · Restricted Project

Feb 14 2022

jsetoain added inline comments to D119568: [mlir][Arith] Disallow casting between scalable and fixed-length vectors.
Feb 14 2022, 9:18 AM · Restricted Project
jsetoain updated the diff for D119568: [mlir][Arith] Disallow casting between scalable and fixed-length vectors.

Simplify check code

Feb 14 2022, 9:17 AM · Restricted Project

Feb 11 2022

jsetoain requested review of D119568: [mlir][Arith] Disallow casting between scalable and fixed-length vectors.
Feb 11 2022, 11:10 AM · Restricted Project
jsetoain added inline comments to D118379: [mlir][Sparse] Add option for VLA sparsification.
Feb 11 2022, 4:15 AM · Restricted Project, Restricted Project
jsetoain updated the diff for D118379: [mlir][Sparse] Add option for VLA sparsification.

Address comments

Feb 11 2022, 4:11 AM · Restricted Project, Restricted Project

Feb 10 2022

jsetoain added a comment to D118379: [mlir][Sparse] Add option for VLA sparsification.

@aartbik Hi Aart, I believe this is ready for final review. Thank you!

Feb 10 2022, 4:57 AM · Restricted Project, Restricted Project
jsetoain updated the diff for D118379: [mlir][Sparse] Add option for VLA sparsification.

Update to latests changes in sparse compiler and address comments.

Feb 10 2022, 4:56 AM · Restricted Project, Restricted Project
jsetoain added inline comments to D118379: [mlir][Sparse] Add option for VLA sparsification.
Feb 10 2022, 4:56 AM · Restricted Project, Restricted Project

Feb 9 2022

jsetoain updated the diff for D104517: [mlir][Vector] Add integration tests for ArmSVE.

Rebase on main

Feb 9 2022, 10:09 AM · Restricted Project, Restricted Project
jsetoain updated the diff for D118248: [mlir][Vector] Enable create_mask for scalable vectors.

Rebase on main

Feb 9 2022, 9:21 AM · Restricted Project, Restricted Project
jsetoain updated the diff for D118371: [mlir][LLVM] Allow scalable vectors in ShuffleVectorOp.

Rebase on main

Feb 9 2022, 9:20 AM · Restricted Project
jsetoain added inline comments to D118248: [mlir][Vector] Enable create_mask for scalable vectors.
Feb 9 2022, 9:11 AM · Restricted Project, Restricted Project
jsetoain updated the diff for D118248: [mlir][Vector] Enable create_mask for scalable vectors.

Switching to llvm.intr.experimental.stepvector for lowering. This fixes
consistency issues with fixed-length create_mask operations.

Feb 9 2022, 2:54 AM · Restricted Project, Restricted Project

Feb 1 2022

jsetoain updated the diff for D118248: [mlir][Vector] Enable create_mask for scalable vectors.

Fix create mask folder. Move create_mask on scalable vectors from
VectorTransforms to ConvertVectorToLLVM

Feb 1 2022, 9:07 AM · Restricted Project, Restricted Project

Jan 28 2022

jsetoain published D104517: [mlir][Vector] Add integration tests for ArmSVE for review.
Jan 28 2022, 9:56 AM · Restricted Project, Restricted Project
jsetoain updated the diff for D118379: [mlir][Sparse] Add option for VLA sparsification.

Added extra tests

Jan 28 2022, 5:53 AM · Restricted Project, Restricted Project

Jan 27 2022

jsetoain added a comment to D118379: [mlir][Sparse] Add option for VLA sparsification.

Note that you may hold off on this revision until https://reviews.llvm.org/D117919 goes in (which restructures our pipeline a bit) to avoid conflicts later on....

Jan 27 2022, 11:33 AM · Restricted Project, Restricted Project
jsetoain added a comment to D118371: [mlir][LLVM] Allow scalable vectors in ShuffleVectorOp.

This is a WiP for now. This patch comes with an issues I'd like to discuss (and fix) before it gets approved. The discussion thread is: Llvm.shufflevector operations for scalable vectors

Jan 27 2022, 9:53 AM · Restricted Project
jsetoain requested review of D118379: [mlir][Sparse] Add option for VLA sparsification.
Jan 27 2022, 8:42 AM · Restricted Project, Restricted Project
jsetoain requested review of D118371: [mlir][LLVM] Allow scalable vectors in ShuffleVectorOp.
Jan 27 2022, 7:59 AM · Restricted Project

Jan 26 2022

jsetoain added a comment to D118248: [mlir][Vector] Enable create_mask for scalable vectors.

This is the discussion thread: Vector.create_mask for scalable vectors

Jan 26 2022, 7:38 AM · Restricted Project, Restricted Project
jsetoain added a comment to D118248: [mlir][Vector] Enable create_mask for scalable vectors.

Please block the patch for now, this is just something I'm thinking about, I'm also opening a post in discourse to get some feedback.

Jan 26 2022, 7:09 AM · Restricted Project, Restricted Project
jsetoain requested review of D118248: [mlir][Vector] Enable create_mask for scalable vectors.
Jan 26 2022, 7:08 AM · Restricted Project, Restricted Project

Jan 23 2022

jsetoain accepted D117981: [mlir:ArmSVE][NFC] Remove dead code and unnecessary dependencies.

Thanks for this, really appreciated!

Jan 23 2022, 5:55 AM · Restricted Project

Jan 13 2022

jsetoain added a comment to D117251: Apply clang-tidy fixes for llvm-header-guard in MLIR (NFC).

Did you rename your LLVM source directory to something other than "llvm-project" (case sensitive)? That will mess up the bit of the code that figures out the guard name (check HeaderGuardCheck.cpp).

Jan 13 2022, 3:46 PM · Restricted Project
jsetoain added inline comments to D117251: Apply clang-tidy fixes for llvm-header-guard in MLIR (NFC).
Jan 13 2022, 2:49 PM · Restricted Project
jsetoain committed rG7c5645861660: [mlir] Fix scalable type translation in splat element attr (authored by jsetoain).
[mlir] Fix scalable type translation in splat element attr
Jan 13 2022, 3:22 AM
jsetoain closed D117125: [mlir] Fix scalable type translation in splat element attr.
Jan 13 2022, 3:22 AM · Restricted Project

Jan 12 2022

jsetoain updated the diff for D117125: [mlir] Fix scalable type translation in splat element attr.

Add missing test

Jan 12 2022, 9:22 AM · Restricted Project