This is an archive of the discontinued LLVM Phabricator instance.

[nfc] Mark classes final as reported by -Wsuggest-final-types
Needs ReviewPublic

Authored by Trass3r on Nov 13 2022, 3:38 PM.

Details

Reviewers
NoQ

Diff Detail

Event Timeline

Trass3r created this revision.Nov 13 2022, 3:38 PM
Herald added a project: Restricted Project. · View Herald Transcript
Trass3r requested review of this revision.Nov 13 2022, 3:38 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptNov 13 2022, 3:38 PM
Trass3r added a comment.EditedNov 13 2022, 3:59 PM

More of an RFC.
See https://github.com/llvm/llvm-project/issues/57525.
This marks some of the classes with devirtualization potential final, as reported by gcc.
It needs to be checked which of those make sense.
Also, is there a proper way to mark classes as 'explicitly designed to be subclassed' (along the lines of class F /*non-final*/ : ...?).

Trass3r updated this revision to Diff 475114.Nov 14 2022, 5:20 AM

fix build