User Details
- User Since
- Nov 24 2018, 4:02 AM (253 w, 2 d)
Jan 13 2023
I can only refer to my last comment, even in latest trunk that code is still active for the codegen passes.
But meanwhile I found the corresponding new code.
Dec 8 2022
Dec 3 2022
Well last time I checked it this code was still in use. When is it going to be deleted?
Also the test has value to ensure the new pass manager emits these entries as before.
Dec 2 2022
Yeah it was conscious at least. No strong opinion on that though.
Nov 18 2022
Nov 17 2022
Yeah quite complex: https://godbolt.org/z/8T5Pqadro
Thanks, it seems to fix the base case, but I still see multiple lenses when I add
One remaining issue is multiple lenses for template code like
Nov 14 2022
Thanks could you also commit it?
I only came across it when testing a PCH build.
https://github.com/Trass3r/llvm-project/actions/runs/3423679621/jobs/5702548183
Warning: <built-in>(1,9): warning: definition of macro '_GNU_SOURCE' does not match definition in precompiled header [-Wclang-cl-pch]
It was set for clang but not for llvm when building with clang-cl.
rebase
fix build
fix build error
Nov 13 2022
More of an RFC.
See https://github.com/llvm/llvm-project/issues/57525.
This marks some of the classes with devirtualization potential final, as reported by gcc.
It needs to be checked which of those make sense.
Also, is there a proper way to mark classes as 'explicitly designed to be subclassed' (along the lines of class F /*non-final*/ : ...?).
RFC. First described in https://github.com/clangd/clangd/issues/1326.
Nov 12 2022
Nov 7 2022
Thanks, could you also commit it? I don't have the rights.
add fallback DisplayString for ArrayRef
add this-> to make it clear
change SDNode DisplayString
remove bases codelens for classes
fix lit test
exclude self from ref count
Nov 6 2022
remove duplicate APInt
update SmallVector
@MaskRay ping
@thakis ping
Nov 2 2022
Thanks for this!
When I experimented with this for #42754 I also came across functions like
Expr::isConstantInitializer
ExprConstant.cpp HandleFunctionCall/HandleConstructorCall
ByteCodeEmitter::compileFunc
Oct 26 2022
Oct 19 2022
Oct 18 2022
Thanks, could you also commit it? I don't have the rights.
It looks like this:
There is a generic test for the TimeTraceScope functionality.
Other than that there's only this one I found in https://reviews.llvm.org/D135658#change-sRvmpoTP4Jas.
Oct 17 2022
Oct 14 2022
Oct 13 2022
Oct 12 2022
@MaskRay Thanks! Could you commit it for me?
Oct 11 2022
@thakis found a suitable test where I could add this
rebased
Any pointers where that test would go and how to write it?
@curdeius I built these up over time and would like to upstream them.
Some of them may be out of date now and some things were tricky like the Uses/User stuff so I could use some feedback in general to polish it.
explicit lambda capture and format
I don't know, are there any tests for all the other scopes?
There is a generic test for the functionality.
Aug 30 2022
Whenever I tried this option in the past it crashed clangd.
I recommend doing some more testing before flipping the switch.
Aug 8 2022
Aug 6 2022
Also fails on gcc 11.2: https://github.com/Trass3r/llvm-project/runs/7703302032
Aug 5 2022
I just searched again and found https://reviews.llvm.org/D91930.
But seems like it never got updated with the latest code featured here. Though looks like the test got dropped.
May 24 2022
Apr 6 2022
That's the general approach for clang-tidy use too, rely on clang-format for formatting the fixes.
Mar 15 2022
Hmm just a few curious questions from the sidelines.
Why a "custom system" instead of something -ftime-trace based?
How much overhead does this introduce, esp. for normal use-cases?
What's the gain? The information is very coarse and general-purpose system profiling tools should give you much better information regarding file system perf.
Mar 4 2022
@sammccall pls merge
Feb 23 2022
Feb 22 2022
For a callback like
[](auto) {...}
the inlay hint is displayed after the ).
Which also looks confusingly like a hint for the lambda return type (which isn't implemented yet afaik).
I don't have a good sense for how common the "multiple instantiations, same type" scenario is; perhaps @Trass3r has an opinion on that.
Feb 21 2022
No apparent differences. Is there a way to automatically reduce it?
Looks like this only covers a subset.
I see hints for some generic lambdas but not for others while hovering over auto reveals the type.
Feb 18 2022
Feb 15 2022
Is it intentional that the resolved type is not shown in the variable hover (I guess, looking at the code):
param payload Type: const auto &
Jul 21 2020
Sep 20 2019
Has this ever gotten anywhere?
I think the correct mapping would be something like -fno-ms-compatibility -fno-delayed-template-parsing, not sure about -fms-volatile -fms-extensions. Edit: Actually no, you need the extensions and disabling compat makes it disguise as gcc. So only the template parsing is left.
Dec 26 2018
Simply didn't look for other uses of IntShift :)
I'm currently not working on llvm but I still have a bunch of half-decent visualizers for llvm::Value types and the like.
Dec 8 2018
Is this still in progress?