Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Trass3r (Trass3r)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 24 2018, 4:02 AM (253 w, 2 d)

Recent Activity

Jan 13 2023

Trass3r updated the diff for D135658: demangle OptFunction trace names.

I can only refer to my last comment, even in latest trunk that code is still active for the codegen passes.
But meanwhile I found the corresponding new code.

Jan 13 2023, 5:10 AM · Restricted Project, Restricted Project, Restricted Project

Dec 8 2022

Trass3r added inline comments to D137918: [nfc] move expensive parts of Hashing.h into cpp file.
Dec 8 2022, 2:49 AM · Restricted Project, Restricted Project

Dec 3 2022

Trass3r added a comment to D135658: demangle OptFunction trace names.

Well last time I checked it this code was still in use. When is it going to be deleted?
Also the test has value to ensure the new pass manager emits these entries as before.

Dec 3 2022, 8:04 AM · Restricted Project, Restricted Project, Restricted Project

Dec 2 2022

Trass3r added a comment to D135658: demangle OptFunction trace names.

Yeah it was conscious at least. No strong opinion on that though.

Dec 2 2022, 6:58 AM · Restricted Project, Restricted Project, Restricted Project
Trass3r added reviewers for D135658: demangle OptFunction trace names: anton-afanasyev, dongjunduo, jamieschmeiser.
Dec 2 2022, 12:51 AM · Restricted Project, Restricted Project, Restricted Project
Trass3r added reviewers for D137914: [cmake] Simplify llvm_update_compile_flags: phosek, ldionne.
Dec 2 2022, 12:44 AM · Restricted Project, Restricted Project
Trass3r added inline comments to D137918: [nfc] move expensive parts of Hashing.h into cpp file.
Dec 2 2022, 12:05 AM · Restricted Project, Restricted Project

Nov 18 2022

Trass3r added inline comments to D138300: [clangd] Support type hints for `decltype(expr)`.
Nov 18 2022, 7:56 AM · Restricted Project, Restricted Project

Nov 17 2022

Trass3r added a comment to D131295: [clangd] Implement textDocument/codeLens.

Yeah quite complex: https://godbolt.org/z/8T5Pqadro

Nov 17 2022, 9:13 PM · Restricted Project, Restricted Project
Trass3r added a comment to D131295: [clangd] Implement textDocument/codeLens.

Thanks, it seems to fix the base case, but I still see multiple lenses when I add

Nov 17 2022, 2:18 PM · Restricted Project, Restricted Project
Trass3r added a comment to D131295: [clangd] Implement textDocument/codeLens.

One remaining issue is multiple lenses for template code like

Nov 17 2022, 3:02 AM · Restricted Project, Restricted Project

Nov 14 2022

Trass3r added a comment to D137917: [cmake] Fix _GNU_SOURCE being added unconditionally.
Nov 14 2022, 9:38 AM · Restricted Project, Restricted Project, Restricted Project
Trass3r added a comment to D137917: [cmake] Fix _GNU_SOURCE being added unconditionally.

Thanks could you also commit it?

Nov 14 2022, 9:00 AM · Restricted Project, Restricted Project, Restricted Project
Trass3r abandoned D137916: [cmake] Disable RTTI by default for tests.
Nov 14 2022, 8:26 AM · Restricted Project, Restricted Project
Trass3r added a comment to D137917: [cmake] Fix _GNU_SOURCE being added unconditionally.

I only came across it when testing a PCH build.
https://github.com/Trass3r/llvm-project/actions/runs/3423679621/jobs/5702548183

Warning: <built-in>(1,9): warning: definition of macro '_GNU_SOURCE' does not match definition in precompiled header [-Wclang-cl-pch]

It was set for clang but not for llvm when building with clang-cl.

Nov 14 2022, 6:58 AM · Restricted Project, Restricted Project, Restricted Project
Trass3r added inline comments to D137918: [nfc] move expensive parts of Hashing.h into cpp file.
Nov 14 2022, 5:45 AM · Restricted Project, Restricted Project
Trass3r updated the diff for D137918: [nfc] move expensive parts of Hashing.h into cpp file.

rebase

Nov 14 2022, 5:32 AM · Restricted Project, Restricted Project
Trass3r updated the diff for D137920: [nfc] Mark classes final as reported by -Wsuggest-final-types.

fix build

Nov 14 2022, 5:20 AM · Restricted Project, Restricted Project, Restricted Project
Trass3r updated the diff for D137916: [cmake] Disable RTTI by default for tests.

fix build error

Nov 14 2022, 5:06 AM · Restricted Project, Restricted Project
Trass3r added inline comments to D137917: [cmake] Fix _GNU_SOURCE being added unconditionally.
Nov 14 2022, 4:41 AM · Restricted Project, Restricted Project, Restricted Project
Trass3r added a reviewer for D137917: [cmake] Fix _GNU_SOURCE being added unconditionally: tstellar.
Nov 14 2022, 4:39 AM · Restricted Project, Restricted Project, Restricted Project

Nov 13 2022

Trass3r added a comment to D137920: [nfc] Mark classes final as reported by -Wsuggest-final-types.

More of an RFC.
See https://github.com/llvm/llvm-project/issues/57525.
This marks some of the classes with devirtualization potential final, as reported by gcc.
It needs to be checked which of those make sense.
Also, is there a proper way to mark classes as 'explicitly designed to be subclassed' (along the lines of class F /*non-final*/ : ...?).

Nov 13 2022, 3:59 PM · Restricted Project, Restricted Project, Restricted Project
Trass3r requested review of D137920: [nfc] Mark classes final as reported by -Wsuggest-final-types.
Nov 13 2022, 3:38 PM · Restricted Project, Restricted Project, Restricted Project
Trass3r added a comment to D137919: [clangd] use fine-grained code action kinds.

RFC. First described in https://github.com/clangd/clangd/issues/1326.

Nov 13 2022, 3:31 PM · Restricted Project, Restricted Project
Trass3r added a reviewer for D137919: [clangd] use fine-grained code action kinds: sammccall.
Nov 13 2022, 3:31 PM · Restricted Project, Restricted Project
Trass3r requested review of D137919: [clangd] use fine-grained code action kinds.
Nov 13 2022, 3:29 PM · Restricted Project, Restricted Project
Trass3r added a reviewer for D137918: [nfc] move expensive parts of Hashing.h into cpp file: hliao.
Nov 13 2022, 3:26 PM · Restricted Project, Restricted Project
Trass3r added inline comments to D137918: [nfc] move expensive parts of Hashing.h into cpp file.
Nov 13 2022, 3:24 PM · Restricted Project, Restricted Project
Trass3r requested review of D137918: [nfc] move expensive parts of Hashing.h into cpp file.
Nov 13 2022, 3:22 PM · Restricted Project, Restricted Project
Trass3r requested review of D137917: [cmake] Fix _GNU_SOURCE being added unconditionally.
Nov 13 2022, 3:18 PM · Restricted Project, Restricted Project, Restricted Project
Trass3r added inline comments to D137916: [cmake] Disable RTTI by default for tests.
Nov 13 2022, 3:12 PM · Restricted Project, Restricted Project
Trass3r requested review of D137916: [cmake] Disable RTTI by default for tests.
Nov 13 2022, 3:08 PM · Restricted Project, Restricted Project
Trass3r added inline comments to D131295: [clangd] Implement textDocument/codeLens.
Nov 13 2022, 2:51 PM · Restricted Project, Restricted Project
Trass3r requested review of D137914: [cmake] Simplify llvm_update_compile_flags.
Nov 13 2022, 2:44 PM · Restricted Project, Restricted Project

Nov 12 2022

SR_team awarded D131295: [clangd] Implement textDocument/codeLens a Like token.
Nov 12 2022, 1:58 PM · Restricted Project, Restricted Project

Nov 7 2022

Trass3r added a comment to D135685: [Visualizers] Add natvis visualizers for various internal llvm classes.

Thanks, could you also commit it? I don't have the rights.

Nov 7 2022, 10:07 AM · Restricted Project, Restricted Project
Trass3r added inline comments to D131295: [clangd] Implement textDocument/codeLens.
Nov 7 2022, 8:55 AM · Restricted Project, Restricted Project
Trass3r updated the diff for D135685: [Visualizers] Add natvis visualizers for various internal llvm classes.

add fallback DisplayString for ArrayRef

Nov 7 2022, 8:50 AM · Restricted Project, Restricted Project
Trass3r added inline comments to D135685: [Visualizers] Add natvis visualizers for various internal llvm classes.
Nov 7 2022, 8:49 AM · Restricted Project, Restricted Project
Trass3r updated the diff for D135685: [Visualizers] Add natvis visualizers for various internal llvm classes.

add this-> to make it clear

Nov 7 2022, 8:47 AM · Restricted Project, Restricted Project
Trass3r updated the diff for D135685: [Visualizers] Add natvis visualizers for various internal llvm classes.

change SDNode DisplayString

Nov 7 2022, 8:44 AM · Restricted Project, Restricted Project
Trass3r updated the diff for D131295: [clangd] Implement textDocument/codeLens.

remove bases codelens for classes
fix lit test
exclude self from ref count

Nov 7 2022, 7:24 AM · Restricted Project, Restricted Project
Trass3r added inline comments to D135685: [Visualizers] Add natvis visualizers for various internal llvm classes.
Nov 7 2022, 7:14 AM · Restricted Project, Restricted Project

Nov 6 2022

Trass3r updated the diff for D135685: [Visualizers] Add natvis visualizers for various internal llvm classes.

remove duplicate APInt
update SmallVector

Nov 6 2022, 2:40 PM · Restricted Project, Restricted Project
Trass3r added a comment to D135659: add gdb index time trace.

@MaskRay ping

Nov 6 2022, 1:51 PM · Restricted Project, Restricted Project
Trass3r added a comment to D135658: demangle OptFunction trace names.

@thakis ping

Nov 6 2022, 1:50 PM · Restricted Project, Restricted Project, Restricted Project

Nov 2 2022

Trass3r added a comment to D136022: [clang] Add time profile for constant evaluation.

Thanks for this!
When I experimented with this for #42754 I also came across functions like
Expr::isConstantInitializer
ExprConstant.cpp HandleFunctionCall/HandleConstructorCall
ByteCodeEmitter::compileFunc

Nov 2 2022, 10:04 AM · Restricted Project, Restricted Project

Oct 26 2022

Trass3r added inline comments to D135685: [Visualizers] Add natvis visualizers for various internal llvm classes.
Oct 26 2022, 10:36 AM · Restricted Project, Restricted Project

Oct 19 2022

Trass3r added inline comments to D135685: [Visualizers] Add natvis visualizers for various internal llvm classes.
Oct 19 2022, 2:51 PM · Restricted Project, Restricted Project
Trass3r added a comment to D135657: add time traces for AST serialization.
Oct 19 2022, 8:12 AM · Restricted Project, Restricted Project

Oct 18 2022

Trass3r added inline comments to D135690: [ASTMatchers] Add matcher for functions that are effectively inline.
Oct 18 2022, 9:43 AM · Restricted Project, Restricted Project
Trass3r added a comment to D135657: add time traces for AST serialization.

Thanks, could you also commit it? I don't have the rights.

Oct 18 2022, 9:06 AM · Restricted Project, Restricted Project
Trass3r added reviewers for D135685: [Visualizers] Add natvis visualizers for various internal llvm classes: RKSimon, aaron.ballman.
Oct 18 2022, 8:56 AM · Restricted Project, Restricted Project
Trass3r added a comment to D135657: add time traces for AST serialization.

It looks like this:



There is a generic test for the TimeTraceScope functionality.
Other than that there's only this one I found in https://reviews.llvm.org/D135658#change-sRvmpoTP4Jas.

Oct 18 2022, 8:50 AM · Restricted Project, Restricted Project
Trass3r added inline comments to D126506: workflows: Use new custom runners from github.
Oct 18 2022, 3:43 AM · Restricted Project, Restricted Project
Trass3r added a reviewer for D135657: add time traces for AST serialization: Djamma1986.
Oct 18 2022, 3:00 AM · Restricted Project, Restricted Project

Oct 17 2022

Trass3r added a comment to D135690: [ASTMatchers] Add matcher for functions that are effectively inline.

Pretty sure that was after /Zc:inline (IIRC that existed in MSVC 2015 which was roughly when I recall we were hitting this).

Oct 17 2022, 8:30 AM · Restricted Project, Restricted Project
Trass3r added a comment to D127403: [clangd] Implement semantic token modifier "definition".

https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access

Oct 17 2022, 3:01 AM · Restricted Project, Restricted Project

Oct 14 2022

Trass3r added a comment to D135690: [ASTMatchers] Add matcher for functions that are effectively inline.

Didn't realize it has a big cost. Looking inside the AST_MATCHER and REGISTER_MATCHER macros I can't see any unique instantiations, should be memoized?

IIRC, the cost may depend on the compiler. I know we had to enable /bigobj when building with MSVC because each template instantiation here was being added to its own section in the object file and we'd wind up with tens of thousands of sections.

Oct 14 2022, 8:32 AM · Restricted Project, Restricted Project

Oct 13 2022

Trass3r added a comment to D135690: [ASTMatchers] Add matcher for functions that are effectively inline.

what's the need for adding this matcher? Do you plan to use it for some in-tree needs? We usually only add new matchers where there's an immediate need for them because of how expensive AST matchers are to compile (and each matcher adds a fair number of template instantiations to the final binary as well, so there's a bit of runtime cost too).

Oct 13 2022, 2:00 PM · Restricted Project, Restricted Project

Oct 12 2022

Trass3r added a comment to D135659: add gdb index time trace.

@MaskRay Thanks! Could you commit it for me?

Oct 12 2022, 12:58 AM · Restricted Project, Restricted Project

Oct 11 2022

Trass3r added inline comments to D135690: [ASTMatchers] Add matcher for functions that are effectively inline.
Oct 11 2022, 4:30 PM · Restricted Project, Restricted Project
Trass3r updated the diff for D135658: demangle OptFunction trace names.

@thakis found a suitable test where I could add this

Oct 11 2022, 3:30 PM · Restricted Project, Restricted Project, Restricted Project
Trass3r published D135690: [ASTMatchers] Add matcher for functions that are effectively inline for review.
Oct 11 2022, 2:30 PM · Restricted Project, Restricted Project
Trass3r updated the diff for D135657: add time traces for AST serialization.

rebased

Oct 11 2022, 2:13 PM · Restricted Project, Restricted Project
Trass3r added a comment to D135658: demangle OptFunction trace names.

Any pointers where that test would go and how to write it?

Oct 11 2022, 12:16 PM · Restricted Project, Restricted Project, Restricted Project
Trass3r published D135685: [Visualizers] Add natvis visualizers for various internal llvm classes for review.

@curdeius I built these up over time and would like to upstream them.
Some of them may be out of date now and some things were tricky like the Uses/User stuff so I could use some feedback in general to polish it.

Oct 11 2022, 9:07 AM · Restricted Project, Restricted Project
Trass3r updated the diff for D135658: demangle OptFunction trace names.

explicit lambda capture and format

Oct 11 2022, 8:47 AM · Restricted Project, Restricted Project, Restricted Project
Trass3r added a comment to D135658: demangle OptFunction trace names.

I don't know, are there any tests for all the other scopes?
There is a generic test for the functionality.

Oct 11 2022, 8:26 AM · Restricted Project, Restricted Project, Restricted Project
Trass3r requested review of D135659: add gdb index time trace.
Oct 11 2022, 3:58 AM · Restricted Project, Restricted Project
Trass3r updated the summary of D135658: demangle OptFunction trace names.
Oct 11 2022, 3:52 AM · Restricted Project, Restricted Project, Restricted Project
Trass3r requested review of D135658: demangle OptFunction trace names.
Oct 11 2022, 3:48 AM · Restricted Project, Restricted Project, Restricted Project
Trass3r requested review of D135657: add time traces for AST serialization.
Oct 11 2022, 3:42 AM · Restricted Project, Restricted Project

Aug 30 2022

Trass3r added a comment to D132919: [clangd] Enable folding ranges by default..

Whenever I tried this option in the past it crashed clangd.
I recommend doing some more testing before flipping the switch.

Aug 30 2022, 2:26 AM · Restricted Project, Restricted Project

Aug 8 2022

Trass3r added a comment to D130689: [LLVM] Update C++ standard to 17.

land the change, wait for a couple of hours to ensure that all bots have picked up the revision, then revert

Aug 8 2022, 11:37 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Aug 6 2022

Trass3r added a comment to D130689: [LLVM] Update C++ standard to 17.

Also fails on gcc 11.2: https://github.com/Trass3r/llvm-project/runs/7703302032

Aug 6 2022, 2:46 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Aug 5 2022

Trass3r added a comment to D131295: [clangd] Implement textDocument/codeLens.

I just searched again and found https://reviews.llvm.org/D91930.
But seems like it never got updated with the latest code featured here. Though looks like the test got dropped.

Aug 5 2022, 3:04 PM · Restricted Project, Restricted Project
Trass3r published D131295: [clangd] Implement textDocument/codeLens for review.
Aug 5 2022, 2:59 PM · Restricted Project, Restricted Project

May 24 2022

Herald added a project to D120498: [AST] Test RecursiveASTVisitor's current traversal of templates.: Restricted Project.
May 24 2022, 11:01 PM · Restricted Project, Restricted Project
Herald added a project to D120504: [AST] RAV doesn't traverse explicitly instantiated function bodies by default: Restricted Project.
May 24 2022, 10:51 PM · Restricted Project, Restricted Project, Restricted Project

Apr 6 2022

Trass3r added a comment to D63085: Provide a fix-it hint for -Wswitch, which adds missing cases. If there are >3 cases, the inserted text will contain newlines so it will not be shown in console output (but will be applied by -fixit, available to libclang and clangd, etc)..

That's the general approach for clang-tidy use too, rely on clang-format for formatting the fixes.

Apr 6 2022, 11:42 AM · Restricted Project, Restricted Project

Mar 15 2022

Trass3r added a comment to D121712: [clangd] Track time spent in filesystem ops during preamble builds.

Hmm just a few curious questions from the sidelines.
Why a "custom system" instead of something -ftime-trace based?
How much overhead does this introduce, esp. for normal use-cases?
What's the gain? The information is very coarse and general-purpose system profiling tools should give you much better information regarding file system perf.

Mar 15 2022, 2:44 PM · Restricted Project, Restricted Project

Mar 4 2022

Herald added a project to D120258: [clangd] Add inlay hints for auto-typed parameters with one instantiation.: Restricted Project.

@sammccall pls merge

Mar 4 2022, 4:40 AM · Restricted Project, Restricted Project

Feb 23 2022

Trass3r added inline comments to D120416: [clangd] Function return type hints: support lambdas, don't duplicate "->".
Feb 23 2022, 11:54 AM · Restricted Project
Trass3r added a comment to D120258: [clangd] Add inlay hints for auto-typed parameters with one instantiation..

(I think this patch is good to go now, ready for a stamp if anyone agrees :-)).

Feb 23 2022, 9:44 AM · Restricted Project, Restricted Project
Trass3r added a comment to D120258: [clangd] Add inlay hints for auto-typed parameters with one instantiation..

I'll just suppress the hint here, ParamVarDecl::getLocation() appears to incorrectly point at the rparen and it's not obvious what we're hinting without a name in any case.

Feb 23 2022, 8:30 AM · Restricted Project, Restricted Project

Feb 22 2022

Trass3r added a comment to D120258: [clangd] Add inlay hints for auto-typed parameters with one instantiation..

For a callback like

[](auto) {...}

the inlay hint is displayed after the ).
Which also looks confusingly like a hint for the lambda return type (which isn't implemented yet afaik).

Feb 22 2022, 1:30 PM · Restricted Project, Restricted Project
Trass3r added a comment to D120258: [clangd] Add inlay hints for auto-typed parameters with one instantiation..

I don't have a good sense for how common the "multiple instantiations, same type" scenario is; perhaps @Trass3r has an opinion on that.

Feb 22 2022, 2:19 AM · Restricted Project, Restricted Project

Feb 21 2022

Trass3r added a comment to D120258: [clangd] Add inlay hints for auto-typed parameters with one instantiation..

No apparent differences. Is there a way to automatically reduce it?

Feb 21 2022, 1:37 PM · Restricted Project, Restricted Project
Trass3r added a comment to D120258: [clangd] Add inlay hints for auto-typed parameters with one instantiation..

Looks like this only covers a subset.
I see hints for some generic lambdas but not for others while hovering over auto reveals the type.

Feb 21 2022, 12:32 PM · Restricted Project, Restricted Project

Feb 18 2022

Trass3r added inline comments to D119537: [clangd] Treat 'auto' params as deduced if there's a single instantiation..
Feb 18 2022, 6:47 AM · Restricted Project

Feb 15 2022

Trass3r added a comment to D119537: [clangd] Treat 'auto' params as deduced if there's a single instantiation..

Is it intentional that the resolved type is not shown in the variable hover (I guess, looking at the code):

param payload
Type: const auto &
Feb 15 2022, 8:26 AM · Restricted Project

Jul 21 2020

Trass3r added a comment to D52296: [Clang] - Add '-gsplit-dwarf[=split,=single]' version for '-gsplit-dwarf' option..

Only DWARF supports this, correct?

I am not aware of any kind of debug information splitting except DWARF splitting.

Jul 21 2020, 2:52 PM

Sep 20 2019

Trass3r added a comment to D32435: clang-cl: Add support for /permissive-.

Has this ever gotten anywhere?
I think the correct mapping would be something like -fno-ms-compatibility -fno-delayed-template-parsing, not sure about -fms-volatile -fms-extensions. Edit: Actually no, you need the extensions and disabling compat makes it disguise as gcc. So only the template parsing is left.

Sep 20 2019, 9:50 AM

Dec 26 2018

Trass3r added a comment to D55252: fix PointerIntPair visualizer.

Simply didn't look for other uses of IntShift :)
I'm currently not working on llvm but I still have a bunch of half-decent visualizers for llvm::Value types and the like.

Dec 26 2018, 3:53 AM

Dec 8 2018

Trass3r added a comment to D47196: [Time-report ](2): Recursive timers in Clang.

Is this still in progress?

Dec 8 2018, 6:28 PM

Dec 3 2018

Trass3r created D55252: fix PointerIntPair visualizer.
Dec 3 2018, 10:59 PM