Page MenuHomePhabricator

Trass3r (Trass3r)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 24 2018, 4:02 AM (188 w, 3 d)

Recent Activity

May 24 2022

Herald added a project to D120498: [AST] Test RecursiveASTVisitor's current traversal of templates.: Restricted Project.
May 24 2022, 11:01 PM · Restricted Project, Restricted Project
Herald added a project to D120504: [AST] RAV doesn't traverse explicitly instantiated function bodies by default: Restricted Project.
May 24 2022, 10:51 PM · Restricted Project, Restricted Project, Restricted Project

Apr 6 2022

Trass3r added a comment to D63085: Provide a fix-it hint for -Wswitch, which adds missing cases. If there are >3 cases, the inserted text will contain newlines so it will not be shown in console output (but will be applied by -fixit, available to libclang and clangd, etc)..

That's the general approach for clang-tidy use too, rely on clang-format for formatting the fixes.

Apr 6 2022, 11:42 AM · Restricted Project, Restricted Project

Mar 15 2022

Trass3r added a comment to D121712: [clangd] Track time spent in filesystem ops during preamble builds.

Hmm just a few curious questions from the sidelines.
Why a "custom system" instead of something -ftime-trace based?
How much overhead does this introduce, esp. for normal use-cases?
What's the gain? The information is very coarse and general-purpose system profiling tools should give you much better information regarding file system perf.

Mar 15 2022, 2:44 PM · Restricted Project, Restricted Project

Mar 4 2022

Herald added a project to D120258: [clangd] Add inlay hints for auto-typed parameters with one instantiation.: Restricted Project.

@sammccall pls merge

Mar 4 2022, 4:40 AM · Restricted Project, Restricted Project

Feb 23 2022

Trass3r added inline comments to D120416: [clangd] Function return type hints: support lambdas, don't duplicate "->".
Feb 23 2022, 11:54 AM · Restricted Project
Trass3r added a comment to D120258: [clangd] Add inlay hints for auto-typed parameters with one instantiation..

(I think this patch is good to go now, ready for a stamp if anyone agrees :-)).

Feb 23 2022, 9:44 AM · Restricted Project, Restricted Project
Trass3r added a comment to D120258: [clangd] Add inlay hints for auto-typed parameters with one instantiation..

I'll just suppress the hint here, ParamVarDecl::getLocation() appears to incorrectly point at the rparen and it's not obvious what we're hinting without a name in any case.

Feb 23 2022, 8:30 AM · Restricted Project, Restricted Project

Feb 22 2022

Trass3r added a comment to D120258: [clangd] Add inlay hints for auto-typed parameters with one instantiation..

For a callback like

[](auto) {...}

the inlay hint is displayed after the ).
Which also looks confusingly like a hint for the lambda return type (which isn't implemented yet afaik).

Feb 22 2022, 1:30 PM · Restricted Project, Restricted Project
Trass3r added a comment to D120258: [clangd] Add inlay hints for auto-typed parameters with one instantiation..

I don't have a good sense for how common the "multiple instantiations, same type" scenario is; perhaps @Trass3r has an opinion on that.

Feb 22 2022, 2:19 AM · Restricted Project, Restricted Project

Feb 21 2022

Trass3r added a comment to D120258: [clangd] Add inlay hints for auto-typed parameters with one instantiation..

No apparent differences. Is there a way to automatically reduce it?

Feb 21 2022, 1:37 PM · Restricted Project, Restricted Project
Trass3r added a comment to D120258: [clangd] Add inlay hints for auto-typed parameters with one instantiation..

Looks like this only covers a subset.
I see hints for some generic lambdas but not for others while hovering over auto reveals the type.

Feb 21 2022, 12:32 PM · Restricted Project, Restricted Project

Feb 18 2022

Trass3r added inline comments to D119537: [clangd] Treat 'auto' params as deduced if there's a single instantiation..
Feb 18 2022, 6:47 AM · Restricted Project

Feb 15 2022

Trass3r added a comment to D119537: [clangd] Treat 'auto' params as deduced if there's a single instantiation..

Is it intentional that the resolved type is not shown in the variable hover (I guess, looking at the code):

param payload
Type: const auto &
Feb 15 2022, 8:26 AM · Restricted Project

Jul 21 2020

Trass3r added a comment to D52296: [Clang] - Add '-gsplit-dwarf[=split,=single]' version for '-gsplit-dwarf' option..

Only DWARF supports this, correct?

I am not aware of any kind of debug information splitting except DWARF splitting.

Jul 21 2020, 2:52 PM

Sep 20 2019

Trass3r added a comment to D32435: clang-cl: Add support for /permissive-.

Has this ever gotten anywhere?
I think the correct mapping would be something like -fno-ms-compatibility -fno-delayed-template-parsing, not sure about -fms-volatile -fms-extensions. Edit: Actually no, you need the extensions and disabling compat makes it disguise as gcc. So only the template parsing is left.

Sep 20 2019, 9:50 AM

Dec 26 2018

Trass3r added a comment to D55252: fix PointerIntPair visualizer.

Simply didn't look for other uses of IntShift :)
I'm currently not working on llvm but I still have a bunch of half-decent visualizers for llvm::Value types and the like.

Dec 26 2018, 3:53 AM

Dec 8 2018

Trass3r added a comment to D47196: [Time-report ](2): Recursive timers in Clang.

Is this still in progress?

Dec 8 2018, 6:28 PM

Dec 3 2018

Trass3r created D55252: fix PointerIntPair visualizer.
Dec 3 2018, 10:59 PM