Page MenuHomePhabricator

[nfc] Mark classes final as reported by -Wsuggest-final-types
Needs ReviewPublic

Authored by Trass3r on Nov 13 2022, 3:38 PM.



Diff Detail

Unit TestsFailed

60,040 msx64 debian > ThreadSanitizer-x86_64.ThreadSanitizer-x86_64::restore_stack.cpp
Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang --driver-mode=g++ -fsanitize=thread -Wall -m64 -msse4.2 -gline-tables-only -I/var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/tsan/../ -std=c++11 -I/var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/tsan/../ -O1 /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/tsan/restore_stack.cpp -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/tsan/X86_64Config/Output/restore_stack.cpp.tmp && not /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/tsan/X86_64Config/Output/restore_stack.cpp.tmp 2>&1 | FileCheck /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/tsan/restore_stack.cpp

Event Timeline

Trass3r created this revision.Nov 13 2022, 3:38 PM
Herald added a project: Restricted Project. · View Herald Transcript
Trass3r requested review of this revision.Nov 13 2022, 3:38 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptNov 13 2022, 3:38 PM
Trass3r added a comment.EditedNov 13 2022, 3:59 PM

More of an RFC.
This marks some of the classes with devirtualization potential final, as reported by gcc.
It needs to be checked which of those make sense.
Also, is there a proper way to mark classes as 'explicitly designed to be subclassed' (along the lines of class F /*non-final*/ : ...?).

Trass3r updated this revision to Diff 475114.Nov 14 2022, 5:20 AM

fix build