This is an archive of the discontinued LLVM Phabricator instance.

[VP][RISCV] Add vp.floor, vp.round, vp.roundeven and their RISC-V support
ClosedPublic

Authored by eopXD on Sep 27 2022, 1:03 PM.

Diff Detail

Event Timeline

eopXD created this revision.Sep 27 2022, 1:03 PM
eopXD requested review of this revision.Sep 27 2022, 1:03 PM
eopXD added a comment.Sep 27 2022, 1:05 PM

The 3 intrinsics are similar and share the same place in modifications so I fused them into this single patch. If it is too big I am also happy to split it.

craig.topper accepted this revision.Sep 27 2022, 1:26 PM

LGTM other than the node about the extra slash in the comment.

llvm/lib/Target/RISCV/RISCVISelLowering.cpp
1969

Drop the extra slash after domain. Not sure where that came from.

This revision is now accepted and ready to land.Sep 27 2022, 1:26 PM
eopXD updated this revision to Diff 463387.Sep 27 2022, 6:21 PM

Remove redundant / in comment.

eopXD marked an inline comment as done.Sep 27 2022, 6:22 PM
eopXD added inline comments.
llvm/lib/Target/RISCV/RISCVISelLowering.cpp
1969

Removed.

This revision was automatically updated to reflect the committed changes.
eopXD marked an inline comment as done.