This is an archive of the discontinued LLVM Phabricator instance.

Differential D134154

[RISCV][NFC]Remove outdated comment from targetShrinkDemandedConstant
ClosedPublic

Authored by liaolucy on Sep 18 2022, 6:40 PM.

Download Raw Diff

Details

Reviewers

Commits

rG8fee91c43517: [RISCV][NFC]Remove outdated comment from targetShrinkDemandedConstant

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

liaolucy created this revision.Sep 18 2022, 6:40 PM

Herald added a project: Restricted Project. · View Herald TranscriptSep 18 2022, 6:40 PM

Herald added subscribers: sunshaoce, VincentWu, StephenFan and 29 others. · View Herald Transcript

liaolucy requested review of this revision.Sep 18 2022, 6:40 PM

Herald added a project: Restricted Project. · View Herald TranscriptSep 18 2022, 6:40 PM

Herald added subscribers: llvm-commits, • pcwang-thead, eopXD, MaskRay. · View Herald Transcript

LGTM

This revision is now accepted and ready to land.Sep 18 2022, 7:07 PM

This revision was landed with ongoing or failed builds.Sep 18 2022, 7:23 PM

Closed by commit rG8fee91c43517: [RISCV][NFC]Remove outdated comment from targetShrinkDemandedConstant (authored by liaolucy). · Explain Why

This revision was automatically updated to reflect the committed changes.

liaolucy added a commit: rG8fee91c43517: [RISCV][NFC]Remove outdated comment from targetShrinkDemandedConstant.

Harbormaster completed remote builds in B187423: Diff 461119.Sep 18 2022, 8:20 PM

Revision Contents

Path

Size

llvm/

lib/

Target/

RISCV/

RISCVISelLowering.cpp

1 line

Diff 461124

llvm/lib/Target/RISCV/RISCVISelLowering.cpp

This file is larger than 256 KB, so syntax highlighting is disabled by default.

	Show First 20 Lines • Show All 9,998 Lines • ▼ Show 20 Lines		bool RISCVTargetLowering::targetShrinkDemandedConstant(
	// Delay this optimization as late as possible.			// Delay this optimization as late as possible.
	if (!TLO.LegalOps)			if (!TLO.LegalOps)
	return false;			return false;

	EVT VT = Op.getValueType();			EVT VT = Op.getValueType();
	if (VT.isVector())			if (VT.isVector())
	return false;			return false;

	// Only handle AND for now.
	unsigned Opcode = Op.getOpcode();			unsigned Opcode = Op.getOpcode();
	if (Opcode != ISD::AND && Opcode != ISD::OR && Opcode != ISD::XOR)			if (Opcode != ISD::AND && Opcode != ISD::OR && Opcode != ISD::XOR)
	return false;			return false;

	ConstantSDNode *C = dyn_cast<ConstantSDNode>(Op.getOperand(1));			ConstantSDNode *C = dyn_cast<ConstantSDNode>(Op.getOperand(1));
	if (!C)			if (!C)
	return false;			return false;

	▲ Show 20 Lines • Show All 3,234 Lines • Show Last 20 Lines