[6/12] patch series to port HWASAN for riscv64
Depends On D131574
Paths
| Differential D131343
[RISC-V][HWASAN] Add support for lowering HWASAN intrinsic for RISC-V ClosedPublic Authored by smd on Aug 6 2022, 2:46 PM.
Details
Diff Detail
Event Timelinesmd added a child revision: D131344: [RISC-V][HWASAN] Adjust lit test support for RISC-V HWASAN feature. craig.topper added inline comments.
Comment Actions Please split RISCVAsmParser/Printer and HWAddressSanitizer into separate patches
smd retitled this revision from [RISC-V][HWASAN] Add support for HWASAN code instrumentation for RISC-V to [RISC-V][HWASAN] Add support for lowering HWASAN intrinsic for RISC-V.Aug 10 2022, 8:03 AM smd added a parent revision: D131574: [RISC-V][HWASAN] Save sp address at the start of tag mismatch routine. smd added a child revision: D131575: [RISC-V][HWASAN] Add support for HWASAN code instrumentation for RISC-V.Aug 10 2022, 8:05 AM Comment Actions
Fixed, thanks. Comment Actions
The requested tests have been added as part of D131344. Comment Actions
llvm/test/CodeGen/RISCV/hwasan-check-memaccess.ll ? With moved test LGTM in general.
This revision is now accepted and ready to land.Aug 15 2022, 10:47 AM Comment Actions
I believe the same applies to D131575 and basic.ll, where changes to instrumentMemAccessInline are tested? Comment Actions
Sure. The logic is simple:
So D131344 should keep only compiler-rt/test/hwasan/TestCases/ as they look irrelevant to CodeGen and Instrumentation
This revision was landed with ongoing or failed builds.Aug 28 2022, 11:23 AM Closed by commit rGe3485345d30c: [RISC-V][HWASAN] Add support for lowering HWASAN intrinsic for RISC-V (authored by smd). · Explain Why This revision was automatically updated to reflect the committed changes. Comment Actions And if you’re committing a significant chunk of code to a backend I don’t think you should be doing so without getting approval from someone who regularly works on the backend
Comment Actions @jrtc27 sorry for the mess
What's the best way to fix it: would you like me to revert the commit or address the issues in next patches?
Would you mind me adding you as a reviewer for further patches?
Revision Contents
Diff 454956 llvm/lib/Target/RISCV/RISCVAsmPrinter.cpp
llvm/test/CodeGen/RISCV/hwasan-check-memaccess.ll
|
If we change RISCVAsmPrinter, I assume we need to update RISCVAsmParser.cpp and add corresponding tests