Details

Reviewers

eugenis
vitalybuka
luismarques

Commits

rG847fa84b3d34: [RISC-V][HWASAN] Adjust lit test support for RISC-V HWASAN feature

Summary

[10/11] patch series to port HWASAN for riscv64

Depends On D131575

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

smd created this revision.Aug 6 2022, 2:47 PM

Herald added a project: Restricted Project. · View Herald TranscriptAug 6 2022, 2:47 PM

Herald added subscribers: Enna1, sunshaoce, VincentWu and 13 others. · View Herald Transcript

smd edited the summary of this revision. (Show Details)Aug 6 2022, 2:55 PM

smd added a parent revision: D131343: [RISC-V][HWASAN] Add support for lowering HWASAN intrinsic for RISC-V.

smd added a child revision: D131345: [RISC-V][HWASAN] Enable HWASAN for RISC-V architecture.

smd added reviewers: eugenis, vitalybuka, luismarques.Aug 6 2022, 3:04 PM

smd added a project: Restricted Project.Aug 6 2022, 3:06 PM

Harbormaster completed remote builds in B179741: Diff 450578.Aug 6 2022, 3:20 PM

smd published this revision for review.Aug 7 2022, 3:29 AM

Herald added subscribers: Restricted Project, pcwang-thead. · View Herald TranscriptAug 7 2022, 3:29 AM

craig.topper added a subscriber: craig.topper.Aug 7 2022, 12:10 PM

craig.topper added inline comments.

compiler-rt/test/hwasan/TestCases/stack-uas.c
18	Why is there an x86 change in here?

Addressing comments

compiler-rt/test/hwasan/TestCases/stack-uas.c
18	Fixed, thanks

Harbormaster completed remote builds in B179841: Diff 450707.Aug 7 2022, 11:30 PM

With proper fixes to Linux kernel now more tests should work

Harbormaster completed remote builds in B180263: Diff 451279.Aug 9 2022, 3:15 PM

compiler-rt/test/hwasan/TestCases/use-after-scope-temp.cpp
6	I am not sure if I understand pointer-tagging and stable-runtime in context of hwasan. I hope to setup aarch64 buildbot for HWASAN soon, maybe I'll cleanup those features We don't want to list of archs in half of the tests explicitly

This revision is now accepted and ready to land.Aug 9 2022, 6:11 PM

smd edited the summary of this revision. (Show Details)Aug 10 2022, 8:06 AM

smd edited the summary of this revision. (Show Details)

smd added a parent revision: D131575: [RISC-V][HWASAN] Add support for HWASAN code instrumentation for RISC-V.

Introduce some new tests

Herald added a project: Restricted Project. · View Herald TranscriptAug 15 2022, 5:22 AM

Herald added subscribers: llvm-commits, frasercrmck, apazos and 13 others. · View Herald Transcript

Harbormaster completed remote builds in B181258: Diff 452635.Aug 15 2022, 5:23 AM

smd mentioned this in D131575: [RISC-V][HWASAN] Add support for HWASAN code instrumentation for RISC-V.Aug 15 2022, 5:23 AM

smd mentioned this in D131343: [RISC-V][HWASAN] Add support for lowering HWASAN intrinsic for RISC-V.

Moving tests to previous patches

Harbormaster completed remote builds in B181595: Diff 453091.Aug 16 2022, 12:05 PM

vitalybuka accepted this revision.Aug 16 2022, 1:03 PM

smd edited the summary of this revision. (Show Details)Aug 30 2022, 11:20 PM

@vitalybuka
After all the adjustments and supporting globals I have this picture:

Failed Tests (3):
  HWAddressSanitizer-riscv64 :: TestCases/stack-oob.c
  HWAddressSanitizer-riscv64 :: TestCases/try-catch.cpp
  HWAddressSanitizer-riscv64 :: TestCases/exported-tagged-global.c

The first two fail since risc-v doesn't have oldrt support and the last one fails due to aarch64 specific option(--aarch64-enable-global-isel-at-O=1).
Do you have any ideas how we should handle this? I.e. split those tests or just mark them as XFAIL and call it a day?

Thanks

Updating tests

Harbormaster completed remote builds in B195658: Diff 472550.Nov 2 2022, 2:42 AM

smd edited the summary of this revision. (Show Details)Nov 2 2022, 2:43 AM

This revision was landed with ongoing or failed builds.Dec 14 2022, 5:15 AM

Closed by commit rG847fa84b3d34: [RISC-V][HWASAN] Adjust lit test support for RISC-V HWASAN feature (authored by smd). · Explain Why

This revision was automatically updated to reflect the committed changes.

smd added a commit: rG847fa84b3d34: [RISC-V][HWASAN] Adjust lit test support for RISC-V HWASAN feature.

[RISC-V][HWASAN] Adjust lit test support for RISC-V HWASAN feature
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 482819

compiler-rt/test/hwasan/TestCases/Linux/atfork.cpp

compiler-rt/test/hwasan/TestCases/Linux/vfork.c

compiler-rt/test/hwasan/TestCases/exported-tagged-global.c

compiler-rt/test/hwasan/TestCases/stack-oob.c

compiler-rt/test/hwasan/TestCases/stack-uas.c

compiler-rt/test/hwasan/TestCases/tag-mismatch-border-address.c

compiler-rt/test/hwasan/TestCases/try-catch.cpp

compiler-rt/test/hwasan/TestCases/use-after-scope-capture.cpp

compiler-rt/test/hwasan/TestCases/use-after-scope-dtor-order.cpp

compiler-rt/test/hwasan/TestCases/use-after-scope-goto.cpp

compiler-rt/test/hwasan/TestCases/use-after-scope-if.cpp

compiler-rt/test/hwasan/TestCases/use-after-scope-inlined.cpp

compiler-rt/test/hwasan/TestCases/use-after-scope-loop-bug.cpp

compiler-rt/test/hwasan/TestCases/use-after-scope-loop-removed.cpp

compiler-rt/test/hwasan/TestCases/use-after-scope-loop.cpp

compiler-rt/test/hwasan/TestCases/use-after-scope-nobug.cpp

compiler-rt/test/hwasan/TestCases/use-after-scope-setjmp.cpp

compiler-rt/test/hwasan/TestCases/use-after-scope-temp.cpp

compiler-rt/test/hwasan/TestCases/use-after-scope-temp2.cpp

compiler-rt/test/hwasan/TestCases/use-after-scope-types.cpp

compiler-rt/test/hwasan/TestCases/use-after-scope.cpp

[RISC-V][HWASAN] Adjust lit test support for RISC-V HWASAN featureClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 482819

compiler-rt/test/hwasan/TestCases/Linux/atfork.cpp

compiler-rt/test/hwasan/TestCases/Linux/vfork.c

compiler-rt/test/hwasan/TestCases/exported-tagged-global.c

compiler-rt/test/hwasan/TestCases/stack-oob.c

compiler-rt/test/hwasan/TestCases/stack-uas.c

compiler-rt/test/hwasan/TestCases/tag-mismatch-border-address.c

compiler-rt/test/hwasan/TestCases/try-catch.cpp

compiler-rt/test/hwasan/TestCases/use-after-scope-capture.cpp

compiler-rt/test/hwasan/TestCases/use-after-scope-dtor-order.cpp

compiler-rt/test/hwasan/TestCases/use-after-scope-goto.cpp

compiler-rt/test/hwasan/TestCases/use-after-scope-if.cpp

compiler-rt/test/hwasan/TestCases/use-after-scope-inlined.cpp

compiler-rt/test/hwasan/TestCases/use-after-scope-loop-bug.cpp

compiler-rt/test/hwasan/TestCases/use-after-scope-loop-removed.cpp

compiler-rt/test/hwasan/TestCases/use-after-scope-loop.cpp

compiler-rt/test/hwasan/TestCases/use-after-scope-nobug.cpp

compiler-rt/test/hwasan/TestCases/use-after-scope-setjmp.cpp

compiler-rt/test/hwasan/TestCases/use-after-scope-temp.cpp

compiler-rt/test/hwasan/TestCases/use-after-scope-temp2.cpp

compiler-rt/test/hwasan/TestCases/use-after-scope-types.cpp

compiler-rt/test/hwasan/TestCases/use-after-scope.cpp

[RISC-V][HWASAN] Adjust lit test support for RISC-V HWASAN feature
ClosedPublic
Actions

Revision Contents
Changeset List