This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Restore "Enable shrink wrap by default"
ClosedPublic

Authored by fakepaper56 on Jun 30 2022, 11:09 PM.

Details

Summary

This reverts commit 7af3d4ab3d5da07256e1a7a0438e7308e14b9fd5.

RISC-V reverted the shrink wrap patch for bug 53662. Since the bug is fixed
by D123679, the commit re-enable it.

Diff Detail

Event Timeline

fakepaper56 created this revision.Jun 30 2022, 11:09 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 30 2022, 11:09 PM
fakepaper56 requested review of this revision.Jun 30 2022, 11:09 PM
reames accepted this revision.Jul 1 2022, 7:47 AM
reames added a subscriber: reames.

LGTM

This revision is now accepted and ready to land.Jul 1 2022, 7:47 AM
reames added a comment.Jul 1 2022, 7:49 AM

Though, please update the commit message. Revert revert is not super descriptive. Please use Restore "" and include the original commit message + the revert history above.

fakepaper56 updated this revision to Diff 441851.EditedJul 1 2022, 7:17 PM

Fix commit message.

fakepaper56 retitled this revision from Revert "Revert "[RISCV] Enable shrink wrap by default"" to [RISCV] Restore "Enable shrink wrap by default".Jul 1 2022, 7:19 PM
fakepaper56 edited the summary of this revision. (Show Details)
This revision was landed with ongoing or failed builds.Jul 1 2022, 8:11 PM
This revision was automatically updated to reflect the committed changes.