Page MenuHomePhabricator

jmorse (Jeremy Morse)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 19 2018, 2:57 AM (107 w, 1 d)

Recent Activity

Today

jmorse created D77639: [DebugInfo][NFC] Early-exit when analysing for single-location variables.
Tue, Apr 7, 4:49 AM · Restricted Project
jmorse added a comment to D74706: [WIP][DebugInfo][LiveDebugValues] Index variable location IDs by machine location.

I was looking at a benchmark for glyph rendering in WebKit. Unfortunately, the file appears to reference headers from an Apple-internal SDK, and I can't find an analogous benchmark in open source. I've stashed the bitcode for now: happy to benchmark future patches against it if requested.

Tue, Apr 7, 3:12 AM · Restricted Project

Yesterday

jmorse abandoned D74706: [WIP][DebugInfo][LiveDebugValues] Index variable location IDs by machine location.

Hi Vedant,

Mon, Apr 6, 9:11 AM · Restricted Project

Fri, Mar 20

jmorse accepted D76467: [LiveDebugValues] Speed up collectIDsForRegs, NFC.

LGTM

Fri, Mar 20, 10:49 AM · Restricted Project, debug-info
jmorse accepted D76466: [ADT] CoalescingBitVector: Add advanceToLowerBound iterator operation.

LGTM otherwise

Fri, Mar 20, 10:49 AM · Restricted Project
jmorse accepted D76465: [ADT] CoalescingBitVector: Avoid initial heap allocation, NFC.

LGTM

Fri, Mar 20, 10:17 AM · Restricted Project, debug-info

Mar 5 2020

jmorse committed rG737394c49044: Revert "clang: Treat ieee mode as the default for denormal-fp-math" (authored by jmorse).
Revert "clang: Treat ieee mode as the default for denormal-fp-math"
Mar 5 2020, 3:19 AM
jmorse added a reverting change for rGc64ca93053af: clang: Treat ieee mode as the default for denormal-fp-math: rG737394c49044: Revert "clang: Treat ieee mode as the default for denormal-fp-math".
Mar 5 2020, 3:19 AM

Mar 4 2020

jmorse committed rGd4f9675b5509: [analyzer] decode() a bytes object to make Python3 happy (authored by jmorse).
[analyzer] decode() a bytes object to make Python3 happy
Mar 4 2020, 9:34 AM
jmorse committed rG16c6e0f387e9: Quote a python executable path (authored by jmorse).
Quote a python executable path
Mar 4 2020, 7:53 AM

Mar 3 2020

jmorse added a comment to D75343: [RFC][debuginfo-tests][dexter] Add a test generation tool.

(NB, I haven't looked at the code as it seems you're requesting feedback for now,)

Mar 3 2020, 6:56 AM · Restricted Project, debug-info
jmorse accepted D75339: [debuginfo-tests][dexter] Add --builder gcc support for POSIX.

LGTM

Mar 3 2020, 6:03 AM · Restricted Project, debug-info
jmorse accepted D75338: [Coroutines] Use dbg.declare for frame variables.

LGTM with the remaining inline comments addressed, cheers.

Mar 3 2020, 6:02 AM · Restricted Project

Mar 2 2020

jmorse added reviewers for D75339: [debuginfo-tests][dexter] Add --builder gcc support for POSIX: TWeaver, StephenTozer.

Would it not be possible to override handle_options in the tool class, put the logic from _verify_options there (raising an Error if there's a problem), and then call super(Tool,self).handle_options() if there's no error? This would avoid the need to add a new method / code path.

Mar 2 2020, 7:53 AM · Restricted Project, debug-info
jmorse added a comment to D75338: [Coroutines] Use dbg.declare for frame variables.

Thanks for pushing through and finding out how to improve co-routine variable locations Brian; I have a few comments inline. Alas, I can't help with the lldb tests.

Mar 2 2020, 7:39 AM · Restricted Project

Feb 28 2020

jmorse added inline comments to D73725: [DebugInfo] Avoid a quadratic-complexity corner case in LiveDebugValues.
Feb 28 2020, 4:13 AM · Restricted Project
jmorse committed rG6af859dcca27: [DebugInfo] Re-implement LexicalScopes dominance method, add unit tests (authored by jmorse).
[DebugInfo] Re-implement LexicalScopes dominance method, add unit tests
Feb 28 2020, 3:53 AM
jmorse closed D73725: [DebugInfo] Avoid a quadratic-complexity corner case in LiveDebugValues.
Feb 28 2020, 3:53 AM · Restricted Project

Feb 25 2020

jmorse added a comment to D74984: [ADT] Add CoalescingBitVector, implemented using IntervalMap [1/3].

Looking good; I now see that IntervalMap will fire an assertion if an overlapping insert is made, I'd previously thought it would just be inefficient, this explains why CoalescingBitVector can't do it.

Feb 25 2020, 8:57 AM · debug-info, Restricted Project
jmorse committed rG0a3b0837915e: [debuginfo-tests] Warn, not error, if we can't delete working directory (authored by jmorse).
[debuginfo-tests] Warn, not error, if we can't delete working directory
Feb 25 2020, 5:18 AM
jmorse closed D74548: [debuginfo-tests][Dexter] Downgrade failure to delete working dir to warning not error.
Feb 25 2020, 5:18 AM · Restricted Project

Feb 24 2020

jmorse added a comment to D74984: [ADT] Add CoalescingBitVector, implemented using IntervalMap [1/3].

Nice, I can think of a few other places where this could prove useful (the register coalescing code for variable locations for starters). Some comments inline, plus

  • |= / set union could do with being covered in the unittests too,
  • Maybe some allocations could be avoided by using things like IntervalMap iterator setStartUnchecked and similar, but this looks good regardless.
Feb 24 2020, 8:12 AM · debug-info, Restricted Project
jmorse updated the diff for D73725: [DebugInfo] Avoid a quadratic-complexity corner case in LiveDebugValues.

I've added some unit tests; without the patch to LexicalScopes.cpp, these failures occur:

Feb 24 2020, 4:42 AM · Restricted Project

Feb 17 2020

jmorse accepted D74633: [LiveDebugValues] Visit open var locs just once in transferRegisterDef, NFC.

/me rustles around some drawers,

Feb 17 2020, 6:16 AM · Restricted Project, debug-info
jmorse accepted D74642: [CodeGenPrepare] Speed up placeDbgValues, NFC.

LGTM landed whichever way; am I right in thinking that this approach will still be faster than the domtree query even if the block is very large? (On account of the pointer set lookup being ordered, instead of walking through each instruction in a block).

Feb 17 2020, 6:07 AM · Restricted Project, debug-info
jmorse updated the summary of D74706: [WIP][DebugInfo][LiveDebugValues] Index variable location IDs by machine location.
Feb 17 2020, 5:30 AM · Restricted Project
jmorse created D74706: [WIP][DebugInfo][LiveDebugValues] Index variable location IDs by machine location.
Feb 17 2020, 5:30 AM · Restricted Project

Feb 13 2020

jmorse updated the diff for D74548: [debuginfo-tests][Dexter] Downgrade failure to delete working dir to warning not error.

Sounds good, how's this?

Feb 13 2020, 6:35 AM · Restricted Project
jmorse committed rG5ee4a03bc916: [debuginfo-tests][Dexter] Fix some Windows-unfriendly Dexter behaviours (authored by jmorse).
[debuginfo-tests][Dexter] Fix some Windows-unfriendly Dexter behaviours
Feb 13 2020, 6:26 AM
jmorse closed D74546: [debuginfo-tests][Dexter] Fix some Windows-unfriendly Dexter behaviours.
Feb 13 2020, 6:26 AM · Restricted Project
jmorse created D74548: [debuginfo-tests][Dexter] Downgrade failure to delete working dir to warning not error.
Feb 13 2020, 5:21 AM · Restricted Project
jmorse created D74546: [debuginfo-tests][Dexter] Fix some Windows-unfriendly Dexter behaviours.
Feb 13 2020, 4:55 AM · Restricted Project
jmorse committed rG26f6aa9e3ba4: [debuginfo-tests] Fix Dexter process creation failure on Windows (authored by jmorse).
[debuginfo-tests] Fix Dexter process creation failure on Windows
Feb 13 2020, 4:52 AM
jmorse closed D74409: [debuginfo-tests][Dexter] Fix process creation flake-out on Windows.
Feb 13 2020, 4:52 AM · Restricted Project
jmorse added inline comments to D74409: [debuginfo-tests][Dexter] Fix process creation flake-out on Windows.
Feb 13 2020, 4:01 AM · Restricted Project
jmorse added a comment to D74409: [debuginfo-tests][Dexter] Fix process creation flake-out on Windows.

Greg via email points out vswhere: https://devblogs.microsoft.com/setup/vswhere-is-now-installed-with-visual-studio-2017/ which seems to be just what the doctor ordered. I'll take a look at that shortly (and land this patch).

Feb 13 2020, 3:47 AM · Restricted Project
jmorse updated subscribers of D74517: [Local] Do not move around dbg.declares during replaceDbgDeclare.
Feb 13 2020, 3:07 AM · Restricted Project

Feb 12 2020

jmorse added a comment to D70597: [PHIEliminate] skip dbg instruction when LowerPHINode.

Hi, sorry for the long delay,

Feb 12 2020, 6:04 AM · Restricted Project
jmorse added a comment to D74030: [DebugInfo] Avoid generating duplicate llvm.dbg.value.

This generally sounds fine to me, I have some high level comments: if this functionality is likely to be repeated elsewhere, it might be better to use the DebugVariable class in DebugInfoMetadata.h. It'd be more concise to compare variable identities by equality of DebugVariable objects rather than by individual components. (Not necessary for this patch, but worth keeping in mind if there are similar upcoming patches).

Feb 12 2020, 3:00 AM · Restricted Project, debug-info

Feb 11 2020

jmorse created D74409: [debuginfo-tests][Dexter] Fix process creation flake-out on Windows.
Feb 11 2020, 7:32 AM · Restricted Project

Feb 10 2020

jmorse added a comment to D67500: [DebugInfo] LiveDebugValues: don't create transfer records for potentially invalid locations.

It's not represented in the *data* at all since we only have a set, it just falls out of the algorithm. Can you remind me why this works again? Is it because we visit each block locally once before calling any join() function?

Feb 10 2020, 6:12 AM · Restricted Project

Feb 6 2020

jmorse added a comment to D67500: [DebugInfo] LiveDebugValues: don't create transfer records for potentially invalid locations.

Adrian wrote:

My understanding is that for each DBG_VALUE d in the analyzed MIR function and each instruction i

  • true means: "it is correct to insert d at position i"
  • false means: "it would be wrong to insert d at position i"

In other words at each instruction i the set of DBG_VALUEs that are "true" are the set of "live" DBG_VALUEs.

Feb 6 2020, 9:19 AM · Restricted Project
jmorse committed rG6531a78ac4b5: Revert "[DebugInfo] Remove some users of DBG_VALUEs IsIndirect field" (authored by jmorse).
Revert "[DebugInfo] Remove some users of DBG_VALUEs IsIndirect field"
Feb 6 2020, 6:46 AM
jmorse added a reverting change for rGed29dbaafa49: [DebugInfo] Remove some users of DBG_VALUEs IsIndirect field: rG6531a78ac4b5: Revert "[DebugInfo] Remove some users of DBG_VALUEs IsIndirect field".
Feb 6 2020, 6:46 AM
jmorse committed rGece761427f63: Revert "[DebugInfo][DAG] Distinguish different kinds of location indirection" (authored by jmorse).
Revert "[DebugInfo][DAG] Distinguish different kinds of location indirection"
Feb 6 2020, 6:46 AM
jmorse added a reverting change for rG3137fe4d23ee: [DebugInfo][DAG] Distinguish different kinds of location indirection: rGece761427f63: Revert "[DebugInfo][DAG] Distinguish different kinds of location indirection".
Feb 6 2020, 6:46 AM
jmorse committed rGed5998d21e4b: Revert "[SafeStack][DebugInfo] Insert DW_OP_deref in correct location" (authored by jmorse).
Revert "[SafeStack][DebugInfo] Insert DW_OP_deref in correct location"
Feb 6 2020, 6:45 AM
jmorse added a reverting change for rG2d3174c4df6b: [SafeStack][DebugInfo] Insert DW_OP_deref in correct location: rGed5998d21e4b: Revert "[SafeStack][DebugInfo] Insert DW_OP_deref in correct location".
Feb 6 2020, 6:45 AM
jmorse added a comment to D73526: [SafeStack][DebugInfo] Insert DW_OP_deref in correct location.

Pushed up reverts in 6531a78ac4b5. I'll start looking at an actual fix for the -O0 path back in D68945.

Feb 6 2020, 6:44 AM · debug-info, Restricted Project

Feb 5 2020

jmorse added a comment to D73526: [SafeStack][DebugInfo] Insert DW_OP_deref in correct location.

Hmn -- it looks like a / the root cause of this is that the O0 pipeline has a different mechanism for handling DBG_VALUEs of spills [0], hence changing isIndirect for both compilation modes is causing trouble. The code path in [0] probably should have been updated in D68945, unfortunately I'm not familiar with O0, at all, and wasn't really aware of it. Fascinatingly it runs LiveDebugValues but not LiveDebugVariables...

Feb 5 2020, 10:24 AM · debug-info, Restricted Project

Feb 4 2020

jmorse added a comment to D73725: [DebugInfo] Avoid a quadratic-complexity corner case in LiveDebugValues.

I'm not going to make you write one, but this would be a great opportunity ;-)

Feb 4 2020, 9:08 AM · Restricted Project
jmorse added a comment to D67500: [DebugInfo] LiveDebugValues: don't create transfer records for potentially invalid locations.

Ping (summary of situation in previous comment).

Feb 4 2020, 9:08 AM · Restricted Project
jmorse committed rG41206b61e30c: [DebugInfo] Re-instate LiveDebugVariables scope trimming (authored by jmorse).
[DebugInfo] Re-instate LiveDebugVariables scope trimming
Feb 4 2020, 7:00 AM
jmorse closed D73691: [DebugInfo] Re-instate scope trimming in LiveDebugVariables.
Feb 4 2020, 7:00 AM · Restricted Project

Jan 31 2020

jmorse added a comment to D73725: [DebugInfo] Avoid a quadratic-complexity corner case in LiveDebugValues.

Adrian wrote:

We don't have an existing unit test for LexicalScopes that generates IR manually and tests a few common queries, do we?

Jan 31 2020, 7:12 AM · Restricted Project
jmorse edited reviewers for D73691: [DebugInfo] Re-instate scope trimming in LiveDebugVariables, added: Orlando; removed: vsk.
Jan 31 2020, 3:31 AM · Restricted Project

Jan 30 2020

jmorse created D73725: [DebugInfo] Avoid a quadratic-complexity corner case in LiveDebugValues.
Jan 30 2020, 10:10 AM · Restricted Project
jmorse added a comment to D72321: Add test for GDB pretty printers..

(Heading through my email backlog),

Jan 30 2020, 7:08 AM · Restricted Project
jmorse added inline comments to D73691: [DebugInfo] Re-instate scope trimming in LiveDebugVariables.
Jan 30 2020, 4:23 AM · Restricted Project
jmorse created D73691: [DebugInfo] Re-instate scope trimming in LiveDebugVariables.
Jan 30 2020, 4:21 AM · Restricted Project

Jan 29 2020

jmorse added inline comments to D73526: [SafeStack][DebugInfo] Insert DW_OP_deref in correct location.
Jan 29 2020, 7:21 AM · debug-info, Restricted Project

Jan 16 2020

jmorse requested changes to D70597: [PHIEliminate] skip dbg instruction when LowerPHINode.
Jan 16 2020, 6:10 AM · Restricted Project
jmorse reopened D70597: [PHIEliminate] skip dbg instruction when LowerPHINode.

Hi Chris,

Jan 16 2020, 6:10 AM · Restricted Project
jmorse committed rGc969335abdb2: Revert "[PHIEliminate] Move dbg values after phi and label" (authored by jmorse).
Revert "[PHIEliminate] Move dbg values after phi and label"
Jan 16 2020, 6:05 AM
jmorse added a reverting change for rG75188b01e9af: [PHIEliminate] Move dbg values after phi and label: rGc969335abdb2: Revert "[PHIEliminate] Move dbg values after phi and label".
Jan 16 2020, 6:04 AM
jmorse committed rG75188b01e9af: [PHIEliminate] Move dbg values after phi and label (authored by yechunliang).
[PHIEliminate] Move dbg values after phi and label
Jan 16 2020, 3:59 AM
jmorse closed D70597: [PHIEliminate] skip dbg instruction when LowerPHINode.
Jan 16 2020, 3:59 AM · Restricted Project
jmorse added a comment to D70597: [PHIEliminate] skip dbg instruction when LowerPHINode.

Hi, I'm now getting around to committing this. The developer policy [0] now says I should edit your details into the "Author" field of the commit, I'm using your phabricator-registered email address and "Chris Ye" from your phab profile. If there are buildbot failures when the commit goes up (possibly unrelated to this change), you might get messages to that email address.

Jan 16 2020, 3:59 AM · Restricted Project

Jan 8 2020

jmorse added inline comments to D70676: [DebugInfo] Don't repeatedly created undef DBG_VALUEs during machine-sinking.
Jan 8 2020, 8:46 AM · Restricted Project
jmorse updated the diff for D70676: [DebugInfo] Don't repeatedly created undef DBG_VALUEs during machine-sinking.

Address review comments; will drop an explanation inline.

Jan 8 2020, 8:46 AM · Restricted Project
jmorse accepted D70597: [PHIEliminate] skip dbg instruction when LowerPHINode.

LGTM, thanks for working through this. Do you still need patches to be committed for you?

Jan 8 2020, 7:59 AM · Restricted Project

Jan 7 2020

jmorse added a comment to D70597: [PHIEliminate] skip dbg instruction when LowerPHINode.

I wrote inline:

Wouldn't a block that has no PHIs or labels end up returning MBB2.begin()? Applying std::prev to that would break.

Jan 7 2020, 5:50 AM · Restricted Project
jmorse added a comment to D70597: [PHIEliminate] skip dbg instruction when LowerPHINode.

Looking good, this is almost there (see inline),

Jan 7 2020, 5:41 AM · Restricted Project
jmorse added a comment to D67500: [DebugInfo] LiveDebugValues: don't create transfer records for potentially invalid locations.

I think I can narrow the conceptual difference between our interpretations down to this:

Jan 7 2020, 4:46 AM · Restricted Project

Dec 17 2019

jmorse added a comment to D70597: [PHIEliminate] skip dbg instruction when LowerPHINode.

Look like adding one more method for SkipPHIsAndLabels with const_iterator would be more easier. I thought will be more duplicate code to implement SkipPHIsAndLabels and SkipPHIsLabelsAndDebug in MachineVerifier.

Dec 17 2019, 4:54 AM · Restricted Project

Dec 16 2019

jmorse added a comment to D70597: [PHIEliminate] skip dbg instruction when LowerPHINode.

I try to add below reference code to MachineVerifier::checkPHIOps, but meet a build error. In the function the type of MBB.begin() is const_iterator, but type of SkipPHIsAndLabels argument is (iterator I). How to convert const_iterator to iterator and pass to SkipPHIsAndLabels? Could I write the MachineVerifier as below code?

Dec 16 2019, 7:48 AM · Restricted Project
jmorse added a comment to D71450: Modification of bad code in Reassociate.cpp to avoid potential bug..

If I understand correctly, the problem is that calling user_back() might access a container with zero elements, yes? This would appear to be an easy fix -- however IMO you should add reviewers who're familiar with the Reassociate pass better [0]. From a couple of minutes examination it would appear ShouldBreakUpSubtract is only callable from OptimizeInst, and that in turn is guarded by isInstructionTriviallyDead, which I would expect to skip such an instruction. There might be something more complicated broken that someone more familiar with reassociate might spot.

Dec 16 2019, 6:45 AM · Restricted Project

Dec 12 2019

jmorse added a comment to D70644: [DebugInfo] Support for DW_OP_implicit_pointer (llvm.dbg_derefval).

Thanks for the patch, comments inline. A couple of things in general:

Dec 12 2019, 11:00 AM · Restricted Project, debug-info, Restricted Project
jmorse added a comment to D71416: [LiveDebugValues] Omit entry values for DBG_VALUEs with pre-existing expressions.

LGTM (I'm not very familiar with entry values, so best to see what other reviewers thing too).

Dec 12 2019, 8:42 AM · Restricted Project, debug-info
jmorse added a comment to D70597: [PHIEliminate] skip dbg instruction when LowerPHINode.

Great to hear that this is fixing the issue. I agree with Björn, there should be a MachineVerifier check too that DBG_VALUEs are not mixed with labels. That'll make it very easy to detect this issue reoccurring.

Dec 12 2019, 8:04 AM · Restricted Project
jmorse requested review of D70676: [DebugInfo] Don't repeatedly created undef DBG_VALUEs during machine-sinking.
Dec 12 2019, 4:24 AM · Restricted Project
jmorse reopened D70676: [DebugInfo] Don't repeatedly created undef DBG_VALUEs during machine-sinking.

Too lazy on the earlier explanation there sorry. To elaborate: I thought I'd accounted for nondeterminism in the two loops in reinsertSunkDebugDefs, but both were a bit broken:

Dec 12 2019, 4:24 AM · Restricted Project
jmorse updated the diff for D70676: [DebugInfo] Don't repeatedly created undef DBG_VALUEs during machine-sinking.

Remove some now needless variables, switch another DenseMap to MapVector. Having fluffed the explanation before, I'll reopen this momentarily with a fuller explanation,

Dec 12 2019, 4:06 AM · Restricted Project

Dec 11 2019

jmorse added a comment to D71175: [DebugInfo][SelectionDAG] Change order while transferring SDDbgValue to another node.

I found a couple of dozens of cases building clang where this patch causes SelectionDAG::transferDbgValues() to move processed debug value past another debug value of the same variable and I'm going to investigate them in details but it can take some time.

For now, I think we could conservatively let such debug values be on their places not changing their order (although it doesn't seem necessarily correct) and add corresponding TODO or FIXME note for further investigation.

Dec 11 2019, 9:28 AM · debug-info, Restricted Project
jmorse updated the diff for D70676: [DebugInfo] Don't repeatedly created undef DBG_VALUEs during machine-sinking.

Here's a revised patch using SetVector, although it's not at the location I was expecting. As it turns out, the llvm::sort of DebugVariables I was using was actively harmful -- the operator< method of DebugVariable compares pointers, which is fine for DenseMaps, but not for ensuring a consistent order.

Dec 11 2019, 9:08 AM · Restricted Project
jmorse added a comment to D70676: [DebugInfo] Don't repeatedly created undef DBG_VALUEs during machine-sinking.

I tried out D71279 and D71283 individually and they both seem to fix the problem I saw. I haven't done very wide testing, but the mir-reproducer I had passes. Nice!

Dec 11 2019, 6:36 AM · Restricted Project

Dec 10 2019

jmorse added a comment to D71175: [DebugInfo][SelectionDAG] Change order while transferring SDDbgValue to another node.

This risks changing the order in which variable assignments appear to occur, as there's no consideration of whether the new IROrder goes past a dbg.value intrinsic of the same variable.

Dec 10 2019, 9:50 AM · debug-info, Restricted Project
jmorse added a comment to D70676: [DebugInfo] Don't repeatedly created undef DBG_VALUEs during machine-sinking.

D71283 Should (TM) fix it, but, the x86 test that I wrote and which seemed to replicate the issue, now no longer replicates the issue. Which is unfortunate.

Dec 10 2019, 9:13 AM · Restricted Project
jmorse added a parent revision for D71283: [WIP][DebugInfo][MachineSink] Preserve DBG_VALUE subregisters when sinking: D71279: [DebugInfo][MachineSink] Don't stop copy-propagating DBG_VALUEs that will have a sunk copy created.
Dec 10 2019, 9:13 AM · Restricted Project
jmorse added a child revision for D71279: [DebugInfo][MachineSink] Don't stop copy-propagating DBG_VALUEs that will have a sunk copy created: D71283: [WIP][DebugInfo][MachineSink] Preserve DBG_VALUE subregisters when sinking.
Dec 10 2019, 9:13 AM · Restricted Project
jmorse created D71283: [WIP][DebugInfo][MachineSink] Preserve DBG_VALUE subregisters when sinking.
Dec 10 2019, 9:13 AM · Restricted Project
jmorse added a comment to D70676: [DebugInfo] Don't repeatedly created undef DBG_VALUEs during machine-sinking.

(D71279 is a precursor, just getting the second patch up, but I continue to be stuck in the tar pit...)

Dec 10 2019, 8:53 AM · Restricted Project
jmorse created D71279: [DebugInfo][MachineSink] Don't stop copy-propagating DBG_VALUEs that will have a sunk copy created.
Dec 10 2019, 8:53 AM · Restricted Project

Dec 9 2019

jmorse added a comment to D70676: [DebugInfo] Don't repeatedly created undef DBG_VALUEs during machine-sinking.

Misery, not today, but I still think there should be an easy fix. Please do revert this patch though if it's causing difficulties.

Dec 9 2019, 11:39 AM · Restricted Project
jmorse added a comment to D70676: [DebugInfo] Don't repeatedly created undef DBG_VALUEs during machine-sinking.

Ouch, yeah, I can see exactly why that is: the sunk DBG_VALUE is copied from the old / "original" DBG_VALUE, which in the meantime has been copy-propagated. And through the copy propagation, it grows an extra piece of subregister information.

Dec 9 2019, 5:28 AM · Restricted Project
jmorse committed rG00e238896cd8: [DebugInfo] Nerf placeDbgValues, with prejudice (authored by jmorse).
[DebugInfo] Nerf placeDbgValues, with prejudice
Dec 9 2019, 4:55 AM
jmorse closed D58453: [DebugInfo][CGP] Limit placeDbgValues movement of dbg.value intrinsics.
Dec 9 2019, 4:55 AM · Restricted Project

Dec 6 2019

jmorse committed rG4650b2f36949: Attempt to fix a debuginfo test that wasn't as generic as I thought (authored by jmorse).
Attempt to fix a debuginfo test that wasn't as generic as I thought
Dec 6 2019, 4:58 AM
jmorse committed rGc93a9b15ce88: [DebugInfo][CGP] Update dbg.values when sinking address computations (authored by jmorse).
[DebugInfo][CGP] Update dbg.values when sinking address computations
Dec 6 2019, 3:34 AM
jmorse closed D58403: [DebugInfo][CGP] Update dbg.values when updating memory address computations.
Dec 6 2019, 3:34 AM · Restricted Project