Page MenuHomePhabricator

jmorse (Jeremy Morse)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 19 2018, 2:57 AM (52 w, 3 d)

Recent Activity

Today

jmorse added a comment to D59431: [DebugInfo] Terminate constant-value location-list ranges at the end of basic blocks.

So I guess the answer to my question whether this is indicative of a bug in an earlier pass is: not necessarily.

Thu, Mar 21, 4:26 AM · debug-info, Restricted Project

Tue, Mar 19

jmorse added a comment to D59431: [DebugInfo] Terminate constant-value location-list ranges at the end of basic blocks.

Isn't that a symptom of previous passes failing to insert a dbg.value(undef) when they deleted a dbg.value? I'm trying to figure out what a legitimate example for this would look like.

Tue, Mar 19, 1:46 PM · debug-info, Restricted Project

Fri, Mar 15

jmorse created D59431: [DebugInfo] Terminate constant-value location-list ranges at the end of basic blocks.
Fri, Mar 15, 1:12 PM · debug-info, Restricted Project

Thu, Mar 14

jmorse updated the diff for D59272: [DebugInfo] Select debug intrinsic line-numbers more carefully when promoting dbg.declare.

Update to use unknown-locations for everything but promoted store instructions,

Thu, Mar 14, 7:49 AM · Restricted Project

Wed, Mar 13

jmorse added a comment to D58726: [DebugInfo][Docs] Explicitly document how dbg.value intrinsics are interpreted in optimized code.

Many thanks for the reviews!

Wed, Mar 13, 4:43 AM · Restricted Project
jmorse committed rG66943c32d2ad: [DebugInfo][Docs] Document how dbg.value intrinsics are interpreted in… (authored by jmorse).
[DebugInfo][Docs] Document how dbg.value intrinsics are interpreted in…
Wed, Mar 13, 4:43 AM
jmorse committed rL356041: [DebugInfo][Docs] Document how dbg.value intrinsics are interpreted in….
[DebugInfo][Docs] Document how dbg.value intrinsics are interpreted in…
Wed, Mar 13, 4:43 AM
jmorse closed D58726: [DebugInfo][Docs] Explicitly document how dbg.value intrinsics are interpreted in optimized code.
Wed, Mar 13, 4:43 AM · Restricted Project

Tue, Mar 12

jmorse created D59272: [DebugInfo] Select debug intrinsic line-numbers more carefully when promoting dbg.declare.
Tue, Mar 12, 1:20 PM · Restricted Project
jmorse added a comment to D58726: [DebugInfo][Docs] Explicitly document how dbg.value intrinsics are interpreted in optimized code.

Ping -- AFAIUI we're happy with the meaning in this patch, wording and presentation still needs review?

Tue, Mar 12, 8:45 AM · Restricted Project

Mon, Mar 11

jmorse committed rG90ede5f4bfe6: [SimplifyCFG] Retain debug info when threading jumps with critical edges (authored by jmorse).
[SimplifyCFG] Retain debug info when threading jumps with critical edges
Mon, Mar 11, 9:26 AM
jmorse committed rL355833: [SimplifyCFG] Retain debug info when threading jumps with critical edges.
[SimplifyCFG] Retain debug info when threading jumps with critical edges
Mon, Mar 11, 9:26 AM
jmorse closed D59206: [SimplifyCFG] Retain debug info when threading jumps with critical edges.
Mon, Mar 11, 9:25 AM · Restricted Project
jmorse committed rGb60aea41315c: [JumpThreading] Retain debug info when replacing branch instructions (authored by jmorse).
[JumpThreading] Retain debug info when replacing branch instructions
Mon, Mar 11, 4:49 AM
jmorse committed rL355822: [JumpThreading] Retain debug info when replacing branch instructions.
[JumpThreading] Retain debug info when replacing branch instructions
Mon, Mar 11, 4:48 AM
jmorse closed D58963: [JumpThreading] Retain debug info when replacing branch instructions.
Mon, Mar 11, 4:47 AM · Restricted Project

Fri, Mar 8

jmorse requested review of D58238: [DebugInfo] MachineSink: Insert undef DBG_VALUEs when sinking instructions, try to forward copies.

Yes, I was just thinking out loud about sinking/scheduling in general and not so much the specific situation with MachineSink. But I also wondered if the sinking done by MachineSink could be seen as a special case of sinking in general, where we sink one instruction at a time. For MachineSink we eventually reach the end of the BB, and then continue into a successor. So how do we determine when it is time to insert "undef" when sinking one instruction at a time? What kind of reorderings should/shouldn't trigger that we insert an "undef"? I guess this is one thing we should try to describe in the documentation (also for DGB_VALUE), to make sure new developers understand the basic logic behind how we implement these things.

Fri, Mar 8, 2:49 AM · Restricted Project

Thu, Mar 7

jmorse added a comment to D58238: [DebugInfo] MachineSink: Insert undef DBG_VALUEs when sinking instructions, try to forward copies.

I produced another patch (D59027, work-in-progress) that only creates undef DBG_VALUEs when the order of assignments would change... however I then realised I'd misunderstood Bjorns question here:

Thu, Mar 7, 3:47 AM · Restricted Project

Wed, Mar 6

jmorse created D59027: [WIP][DebugInfo] When sinking DBG_VALUEs, only insert undef DBG_VALUEs if sinking would re-order assignments.
Wed, Mar 6, 8:44 AM · Restricted Project

Mon, Mar 4

jmorse added inline comments to D58726: [DebugInfo][Docs] Explicitly document how dbg.value intrinsics are interpreted in optimized code.
Mon, Mar 4, 6:06 AM · Restricted Project
jmorse updated the diff for D58726: [DebugInfo][Docs] Explicitly document how dbg.value intrinsics are interpreted in optimized code.

Re-think opening of paragraph on the risks involved when moving/altering code.

Mon, Mar 4, 6:02 AM · Restricted Project
jmorse updated the diff for D58726: [DebugInfo][Docs] Explicitly document how dbg.value intrinsics are interpreted in optimized code.

Incorporate further wording and structure feedback

Mon, Mar 4, 5:57 AM · Restricted Project
jmorse committed rG09d8ea528250: [X86] Avoid codegen changes when DBG_VALUE appears between lowered selects (authored by jmorse).
[X86] Avoid codegen changes when DBG_VALUE appears between lowered selects
Mon, Mar 4, 2:55 AM
jmorse committed rL355307: [X86] Avoid codegen changes when DBG_VALUE appears between lowered selects.
[X86] Avoid codegen changes when DBG_VALUE appears between lowered selects
Mon, Mar 4, 2:55 AM
jmorse closed D58672: [X86] Avoid codegen changes when DBG_VALUE appears between lowered selects.
Mon, Mar 4, 2:55 AM · Restricted Project

Fri, Mar 1

jmorse updated the diff for D58672: [X86] Avoid codegen changes when DBG_VALUE appears between lowered selects.

Incorporate recommendations on using auto from Andrea, delivered offline,

Fri, Mar 1, 8:53 AM · Restricted Project
jmorse added a comment to D58831: [DebugInfo] Ignore bitcasts when lowering stack arg dbg.values.

LGTM, although I'll wait a bit for more opinions

Fri, Mar 1, 8:08 AM · Restricted Project, debug-info
jmorse updated the diff for D58672: [X86] Avoid codegen changes when DBG_VALUE appears between lowered selects.

Incorporate feedback: use skipDebugInstructionsForward for better readability, iterate forwards when sinking DBG_VALUEs.

Fri, Mar 1, 7:49 AM · Restricted Project
jmorse updated the diff for D56151: [DebugInfo] PR40010: Avoid register coalesing altering DBG_VALUE valuations.

Rename new test case's file name, move it to the 'DebugInfo' directory too as that seems more appropriate.

Fri, Mar 1, 7:18 AM
jmorse updated the diff for D58403: [DebugInfo][CGP] Update dbg.values when updating memory address computations.

Avoid relying on placeDbgValues for this change. We already walk (forwards) through all instructions in a block looking to optimise them, add a dbg.value visitor that rewrites the dbg.value operand if it refers to a sunk address computation.

Fri, Mar 1, 7:10 AM · Restricted Project
jmorse added inline comments to D58726: [DebugInfo][Docs] Explicitly document how dbg.value intrinsics are interpreted in optimized code.
Fri, Mar 1, 4:53 AM · Restricted Project
jmorse updated the diff for D58726: [DebugInfo][Docs] Explicitly document how dbg.value intrinsics are interpreted in optimized code.

Sprinkle some possessive apostrophes, speling, incorrect variable names

Fri, Mar 1, 4:53 AM · Restricted Project
jmorse added inline comments to D58726: [DebugInfo][Docs] Explicitly document how dbg.value intrinsics are interpreted in optimized code.
Fri, Mar 1, 4:29 AM · Restricted Project
jmorse updated the diff for D58726: [DebugInfo][Docs] Explicitly document how dbg.value intrinsics are interpreted in optimized code.

Apply review feedback, re-write the dbg.value undef example to better demonstrate the problem at hand.

Fri, Mar 1, 4:29 AM · Restricted Project

Wed, Feb 27

jmorse added a comment to D58453: [DebugInfo][CGP] Limit placeDbgValues movement of dbg.value intrinsics.

I've generated a short summary in https://reviews.llvm.org/D58726 which illustrates how I believe dbg.values are to be interpreted -- I'll chuck this at llvm-dev tomorrow if it's not obviously broken. As mentioned in the summary, it's likely that more could be said, but getting agreement on the location of a dbg.value being the location that an assignment ``happens'' would be good.

Wed, Feb 27, 9:49 AM · Restricted Project
jmorse created D58726: [DebugInfo][Docs] Explicitly document how dbg.value intrinsics are interpreted in optimized code.
Wed, Feb 27, 9:48 AM · Restricted Project

Tue, Feb 26

jmorse created D58672: [X86] Avoid codegen changes when DBG_VALUE appears between lowered selects.
Tue, Feb 26, 6:05 AM · Restricted Project

Mon, Feb 25

jmorse added a comment to D58453: [DebugInfo][CGP] Limit placeDbgValues movement of dbg.value intrinsics.

Hi Paul,

Mon, Feb 25, 1:12 PM · Restricted Project

Fri, Feb 22

jmorse planned changes to D58238: [DebugInfo] MachineSink: Insert undef DBG_VALUEs when sinking instructions, try to forward copies.

So then we should check if there is any other dbg.value that we sink past? Otherwise there won't be any reordering and no need for an undef location?

Fri, Feb 22, 5:44 AM · Restricted Project
jmorse added a comment to D58453: [DebugInfo][CGP] Limit placeDbgValues movement of dbg.value intrinsics.

In my view, the real problem as stated in the PR appears to be that the value later gets *lost*, sadly before the instructions directly related to the switch-case where the variable is used; the real problem is *not* that the value's description starts too soon.

So given all that, how does this patch help address the real problem?

Fri, Feb 22, 5:02 AM · Restricted Project
jmorse added inline comments to D58453: [DebugInfo][CGP] Limit placeDbgValues movement of dbg.value intrinsics.
Fri, Feb 22, 3:56 AM · Restricted Project
jmorse updated the diff for D58453: [DebugInfo][CGP] Limit placeDbgValues movement of dbg.value intrinsics.

Update comments in placeDbgValues to reflect its new purpose; remove code calculating the previous non-debug-instr, as we now use a dominator tree check instead.

Fri, Feb 22, 3:52 AM · Restricted Project

Thu, Feb 21

jmorse added inline comments to D58238: [DebugInfo] MachineSink: Insert undef DBG_VALUEs when sinking instructions, try to forward copies.
Thu, Feb 21, 5:18 AM · Restricted Project
jmorse updated the diff for D58238: [DebugInfo] MachineSink: Insert undef DBG_VALUEs when sinking instructions, try to forward copies.

Use isCopyInstr to detect copy instructions, which will catch more opportunities that just isCopy().

Thu, Feb 21, 5:18 AM · Restricted Project
jmorse abandoned D54715: [WIP][DebugInfo] Distinguish reads/writes of VRegs when creating debug SDNodes.
Thu, Feb 21, 3:10 AM · Restricted Project
Herald added a project to D54715: [WIP][DebugInfo] Distinguish reads/writes of VRegs when creating debug SDNodes: Restricted Project.

This problem had PR40427 hiding at the bottom of it, so this WIP isn't required.

Thu, Feb 21, 3:10 AM · Restricted Project

Wed, Feb 20

jmorse planned changes to D58403: [DebugInfo][CGP] Update dbg.values when updating memory address computations.

It turns out the validity of this change relies on placeDbgValues reordering (curses), a small amount of extra juggling will be required.

Wed, Feb 20, 9:08 AM · Restricted Project
jmorse added a child revision for D56151: [DebugInfo] PR40010: Avoid register coalesing altering DBG_VALUE valuations: D58453: [DebugInfo][CGP] Limit placeDbgValues movement of dbg.value intrinsics.
Wed, Feb 20, 8:24 AM
jmorse added parent revisions for D58453: [DebugInfo][CGP] Limit placeDbgValues movement of dbg.value intrinsics: D58450: [DebugInfo][MachineCSE] Don't try to copy-propagate debuginfo for every COPY seen, D58403: [DebugInfo][CGP] Update dbg.values when updating memory address computations, D58238: [DebugInfo] MachineSink: Insert undef DBG_VALUEs when sinking instructions, try to forward copies, D58386: [DebugInfo] Pre-RA MachineSink: sink DBG_VALUEs that don't immediately follow the sunk instruction too, D56151: [DebugInfo] PR40010: Avoid register coalesing altering DBG_VALUE valuations.
Wed, Feb 20, 8:24 AM · Restricted Project
jmorse added a child revision for D58238: [DebugInfo] MachineSink: Insert undef DBG_VALUEs when sinking instructions, try to forward copies: D58453: [DebugInfo][CGP] Limit placeDbgValues movement of dbg.value intrinsics.
Wed, Feb 20, 8:24 AM · Restricted Project
jmorse added a child revision for D58403: [DebugInfo][CGP] Update dbg.values when updating memory address computations: D58453: [DebugInfo][CGP] Limit placeDbgValues movement of dbg.value intrinsics.
Wed, Feb 20, 8:24 AM · Restricted Project
jmorse added a child revision for D58386: [DebugInfo] Pre-RA MachineSink: sink DBG_VALUEs that don't immediately follow the sunk instruction too: D58453: [DebugInfo][CGP] Limit placeDbgValues movement of dbg.value intrinsics.
Wed, Feb 20, 8:24 AM · Restricted Project
jmorse added a child revision for D58450: [DebugInfo][MachineCSE] Don't try to copy-propagate debuginfo for every COPY seen: D58453: [DebugInfo][CGP] Limit placeDbgValues movement of dbg.value intrinsics.
Wed, Feb 20, 8:24 AM · Restricted Project
jmorse created D58453: [DebugInfo][CGP] Limit placeDbgValues movement of dbg.value intrinsics.
Wed, Feb 20, 8:23 AM · Restricted Project
jmorse added a child revision for D56265: [DebugInfo] MCP: collect and update DBG_VALUEs encountered in local block: D58450: [DebugInfo][MachineCSE] Don't try to copy-propagate debuginfo for every COPY seen.
Wed, Feb 20, 7:33 AM
jmorse added a parent revision for D58450: [DebugInfo][MachineCSE] Don't try to copy-propagate debuginfo for every COPY seen: D56265: [DebugInfo] MCP: collect and update DBG_VALUEs encountered in local block.
Wed, Feb 20, 7:33 AM · Restricted Project
jmorse created D58450: [DebugInfo][MachineCSE] Don't try to copy-propagate debuginfo for every COPY seen.
Wed, Feb 20, 7:31 AM · Restricted Project

Feb 19 2019

jmorse created D58403: [DebugInfo][CGP] Update dbg.values when updating memory address computations.
Feb 19 2019, 1:15 PM · Restricted Project
jmorse added a parent revision for D58386: [DebugInfo] Pre-RA MachineSink: sink DBG_VALUEs that don't immediately follow the sunk instruction too: D58238: [DebugInfo] MachineSink: Insert undef DBG_VALUEs when sinking instructions, try to forward copies.
Feb 19 2019, 7:35 AM · Restricted Project
jmorse added a child revision for D58238: [DebugInfo] MachineSink: Insert undef DBG_VALUEs when sinking instructions, try to forward copies: D58386: [DebugInfo] Pre-RA MachineSink: sink DBG_VALUEs that don't immediately follow the sunk instruction too.
Feb 19 2019, 7:35 AM · Restricted Project
jmorse created D58386: [DebugInfo] Pre-RA MachineSink: sink DBG_VALUEs that don't immediately follow the sunk instruction too.
Feb 19 2019, 7:35 AM · Restricted Project

Feb 15 2019

jmorse added a comment to D58238: [DebugInfo] MachineSink: Insert undef DBG_VALUEs when sinking instructions, try to forward copies.

I have some doubt about this. Mainly the part about inserting undefs. Although, some of my doubts are partially based on the big-black-hole regarding how debug info is supposed to work for heavily optimized code (and more specifically how this is supposed to work in LLVM based on what we got today).

Feb 15 2019, 4:25 AM · Restricted Project
jmorse added inline comments to D58238: [DebugInfo] MachineSink: Insert undef DBG_VALUEs when sinking instructions, try to forward copies.
Feb 15 2019, 2:38 AM · Restricted Project
jmorse updated the diff for D58238: [DebugInfo] MachineSink: Insert undef DBG_VALUEs when sinking instructions, try to forward copies.

Explicitly test for whether we're pre or post regalloc when deciding whether a copy can be propagated, refactor test logic.

Feb 15 2019, 2:30 AM · Restricted Project

Feb 14 2019

jmorse added a child revision for D58191: [DebugInfo] Make postra sinking of DBG_VALUEs safe in the presence of subregisters: D58238: [DebugInfo] MachineSink: Insert undef DBG_VALUEs when sinking instructions, try to forward copies.
Feb 14 2019, 7:56 AM · Restricted Project
jmorse added a parent revision for D58238: [DebugInfo] MachineSink: Insert undef DBG_VALUEs when sinking instructions, try to forward copies: D58191: [DebugInfo] Make postra sinking of DBG_VALUEs safe in the presence of subregisters.
Feb 14 2019, 7:56 AM · Restricted Project
jmorse created D58238: [DebugInfo] MachineSink: Insert undef DBG_VALUEs when sinking instructions, try to forward copies.
Feb 14 2019, 7:56 AM · Restricted Project
jmorse added inline comments to D58191: [DebugInfo] Make postra sinking of DBG_VALUEs safe in the presence of subregisters.
Feb 14 2019, 7:04 AM · Restricted Project
jmorse updated the diff for D58191: [DebugInfo] Make postra sinking of DBG_VALUEs safe in the presence of subregisters.

Sort dbg-values to be sunk to ensure determinism, sprinkle -NEXT on some CHECKS to strengthen test.

Feb 14 2019, 7:04 AM · Restricted Project
jmorse added inline comments to D56788: [DebugInfo][InstCombine] Prefer salvaging dbg.values over sinking them.
Feb 14 2019, 3:26 AM · Restricted Project
jmorse committed rG897a9f8d008c: Fix an accidentally flipped pair of arguments, NFCI (authored by jmorse).
Fix an accidentally flipped pair of arguments, NFCI
Feb 14 2019, 3:10 AM
jmorse committed rL354019: Fix an accidentally flipped pair of arguments, NFCI.
Fix an accidentally flipped pair of arguments, NFCI
Feb 14 2019, 3:10 AM

Feb 13 2019

jmorse created D58191: [DebugInfo] Make postra sinking of DBG_VALUEs safe in the presence of subregisters.
Feb 13 2019, 9:20 AM · Restricted Project
jmorse committed rG291713a596fb: [DebugInfo][DAG] Either salvage dangling debug info or emit Undef DBG_VALUEs (authored by jmorse).
[DebugInfo][DAG] Either salvage dangling debug info or emit Undef DBG_VALUEs
Feb 13 2019, 8:33 AM
jmorse committed rL353954: [DebugInfo][DAG] Either salvage dangling debug info or emit Undef DBG_VALUEs.
[DebugInfo][DAG] Either salvage dangling debug info or emit Undef DBG_VALUEs
Feb 13 2019, 8:33 AM
jmorse closed D57694: [DebugInfo][DAG] Either salvage dangling debug info or emit Undef DBG_VALUEs.
Feb 13 2019, 8:33 AM · Restricted Project
jmorse committed rG6d3cd3b4ec72: [DebugInfo][DAG] Refactor dbg.value lowering into its own method (authored by jmorse).
[DebugInfo][DAG] Refactor dbg.value lowering into its own method
Feb 13 2019, 7:53 AM
jmorse committed rL353950: [DebugInfo][DAG] Refactor dbg.value lowering into its own method.
[DebugInfo][DAG] Refactor dbg.value lowering into its own method
Feb 13 2019, 7:53 AM
jmorse closed D57697: [DebugInfo][DAG] Refactor dbg.value intrinsic lowering in SelectionDAGBuilder to method.
Feb 13 2019, 7:53 AM · Restricted Project
jmorse committed rGa9a11aac0f94: [DebugInfo][DAG] Limit special-casing of dbg.values for Arguments (authored by jmorse).
[DebugInfo][DAG] Limit special-casing of dbg.values for Arguments
Feb 13 2019, 5:38 AM
jmorse committed rL353948: [DebugInfo][DAG] Limit special-casing of dbg.values for Arguments.
[DebugInfo][DAG] Limit special-casing of dbg.values for Arguments
Feb 13 2019, 5:37 AM
jmorse closed D57584: [DebugInfo][DAG] Reduce SelectionDAGs reordering of variables referring to Arguments.
Feb 13 2019, 5:37 AM · Restricted Project
jmorse added a comment to D57584: [DebugInfo][DAG] Reduce SelectionDAGs reordering of variables referring to Arguments.

The filtering from r353735 happily makes the sparc test change un-necessary.

Feb 13 2019, 3:11 AM · Restricted Project
jmorse updated the diff for D57584: [DebugInfo][DAG] Reduce SelectionDAGs reordering of variables referring to Arguments.

Rebase onto Bjorns changes, remove now un-necessary test change.

Feb 13 2019, 3:08 AM · Restricted Project
jmorse committed rGf10af3f134f2: [DebugInfo][InstCombine] Prefer to salvage debuginfo over sinking it (authored by jmorse).
[DebugInfo][InstCombine] Prefer to salvage debuginfo over sinking it
Feb 13 2019, 2:55 AM
jmorse committed rL353936: [DebugInfo][InstCombine] Prefer to salvage debuginfo over sinking it.
[DebugInfo][InstCombine] Prefer to salvage debuginfo over sinking it
Feb 13 2019, 2:54 AM
jmorse closed D56788: [DebugInfo][InstCombine] Prefer salvaging dbg.values over sinking them.
Feb 13 2019, 2:54 AM · Restricted Project
jmorse added inline comments to D56788: [DebugInfo][InstCombine] Prefer salvaging dbg.values over sinking them.
Feb 13 2019, 2:34 AM · Restricted Project
jmorse added a comment to D56788: [DebugInfo][InstCombine] Prefer salvaging dbg.values over sinking them.

Also, thanks for reviews!

Feb 13 2019, 2:34 AM · Restricted Project

Feb 12 2019

jmorse added a comment to D56788: [DebugInfo][InstCombine] Prefer salvaging dbg.values over sinking them.

(Plus I added a new test to cover this behaviour, and removed some plumbing for salvageDebugUsersForDbgValues that was folded into an earlier commit).

Feb 12 2019, 8:33 AM · Restricted Project
jmorse updated the diff for D56788: [DebugInfo][InstCombine] Prefer salvaging dbg.values over sinking them.

The issue with generating new DW_OP_derefs has been resolved by r353824, as a result we no longer change existing tests with this patch.

Feb 12 2019, 8:32 AM · Restricted Project
jmorse added a comment to D56265: [DebugInfo] MCP: collect and update DBG_VALUEs encountered in local block.

Ping, @CarlosAlbertoEnciso how's the utility function?

Feb 12 2019, 3:52 AM
jmorse added a comment to D57962: [DebugInfo] PR40628: Don't salvage load operations.

Folded last comments into commit, but phab doesn't show those comments inline because of path differences it seems:

  • Added comment warning against salvaging loads in salvageDebugInfoImpl
  • Removed TBBA metadata and un-necessary DILocations
  • New test case positively checks for an undef dbg.value corresponding to the optimised-out load.
Feb 12 2019, 2:58 AM · Restricted Project
jmorse committed rGb33a5c7347fc: [DebugInfo] Don't salvage load operations (PR40628). (authored by jmorse).
[DebugInfo] Don't salvage load operations (PR40628).
Feb 12 2019, 2:55 AM
jmorse committed rL353824: [DebugInfo] Don't salvage load operations (PR40628)..
[DebugInfo] Don't salvage load operations (PR40628).
Feb 12 2019, 2:55 AM
jmorse closed D57962: [DebugInfo] PR40628: Don't salvage load operations.
Feb 12 2019, 2:55 AM · Restricted Project

Feb 11 2019

jmorse added a comment to D57702: [SelectionDAGBuilder] Add restrictions to EmitFuncArgumentDbgValue.
plus it'd be good to hear Adrians view on the fragment scenario.

Do you have any specific questions in mind?

Feb 11 2019, 4:12 AM · Restricted Project
jmorse added a comment to D57962: [DebugInfo] PR40628: Don't salvage load operations.

Would it be feasible to inject a dbg_value(undef) at the end of the basic block or before the next store, whichever is earlier, instead?

Feb 11 2019, 4:08 AM · Restricted Project

Feb 8 2019

jmorse created D57962: [DebugInfo] PR40628: Don't salvage load operations.
Feb 8 2019, 10:03 AM · Restricted Project
jmorse abandoned D54712: [WIP][DebugInfo] Fix SelectionDAGs placement of phi-reading dbg.values.

This turned out to have PR40427 burried at the bottom of it, and was fixed in r352350.

Feb 8 2019, 6:53 AM · Restricted Project