This patch gives basic parsing and semantic support for "modifiers" of order clause introduced in OpenMP 5.1 ( section 2.11.3 )
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
clang/include/clang/Sema/Scope.h | ||
---|---|---|
483–488 | I needed a new scope flag to keep track of all the new scopes created inside a region which has an associated order clause. Then I proceeded to mark all those nested scopes within 'order clause' region with this flag. I needed to do this to implement this restriction (OpenMP 5.1 - 2.11.3): A region that corresponds to a construct with an order clause that specifies concurrent may not contain calls to the OpenMP Runtime API. Changes in this file, in SemaOpenMP.cpp ( in Sema::ActOnOpenMPCall() ) and in Scope.cpp together form the implementation of the above restriction. |
I have made some indentation changes using "git clang format" and added the context for all the files in this patch.
clang/include/clang/Basic/DiagnosticSemaKinds.td | ||
---|---|---|
10644 | Do you have the test for this error message? | |
clang/lib/Sema/SemaOpenMP.cpp | ||
875 | isOrderConcurrent | |
882 | isParentOrderConcurrent | |
7218 | Remove this | |
7219 | I think you can drop call of StringRef constructor here, just omp_ | |
16793 | Remove this | |
16806–16824 | Remove this |
As I do not have commit access, can someone commit this patch, now that it passes the pre-merge tests ?
Hi jyu2, sorry for a late reply, and yes I will fix it. Thanks for pointing this out.
Hey @jyu2 , this error is not reproducible anymore, I think the issue is solved, by someone else's patch.
Commit as NFC change