Details

clang/include/clang/AST/OpenMPClause.h
7646	Commit as NFC change
clang/include/clang/Sema/Scope.h
483–488	Why do wee need new scope?
clang/lib/Basic/OpenMPKinds.cpp
649–654	C/C++ does not have do and workshare directives.

sandeepkosuri added inline comments.Oct 13 2022, 10:21 PM

clang/include/clang/Sema/Scope.h
483–488	I needed a new scope flag to keep track of all the new scopes created inside a region which has an associated order clause. Then I proceeded to mark all those nested scopes within 'order clause' region with this flag. I needed to do this to implement this restriction (OpenMP 5.1 - 2.11.3): A region that corresponds to a construct with an order clause that specifies concurrent may not contain calls to the OpenMP Runtime API. Changes in this file, in SemaOpenMP.cpp ( in Sema::ActOnOpenMPCall() ) and in Scope.cpp together form the implementation of the above restriction.

I have made some indentation changes using "git clang format" and added the context for all the files in this patch.

Harbormaster completed remote builds in B196433: Diff 473598.Nov 7 2022, 3:12 AM

ABataev added inline comments.Nov 7 2022, 6:21 AM

clang/include/clang/Basic/DiagnosticSemaKinds.td
10644	Do you have the test for this error message?
clang/lib/Sema/SemaOpenMP.cpp
875	`isOrderConcurrent`
882	`isParentOrderConcurrent`
7218	Remove `this`
7219	I think you can drop call of `StringRef` constructor here, just `omp_`
16793	Remove `this`
16806–16824	Remove `this`

sandeepkosuri added inline comments.Nov 9 2022, 8:53 PM

clang/include/clang/Basic/DiagnosticSemaKinds.td
10644	I forgot to add a test for this, I will do it. Thanks for noticing.
clang/lib/Sema/SemaOpenMP.cpp
875	This function is never used, So I will remove this altogether. Thanks for pointing this out.

Addressed the comments

This revision is now accepted and ready to land.Nov 11 2022, 7:33 AM

Harbormaster completed remote builds in B197224: Diff 474750.Nov 11 2022, 7:48 AM

Fixed the Semantic analysis and updated the newly added LIT test case.

Harbormaster completed remote builds in B199478: Diff 477860.Nov 25 2022, 12:31 AM

As I do not have commit access, can someone commit this patch, now that it passes the pre-merge tests ?

Closed by commit rG7c34e74c2547: [OpenMP] Basic parse and sema support for modifiers in order clause (authored by cchen). · Explain WhyDec 12 2022, 1:52 PM

This revision was automatically updated to reflect the committed changes.

cchen added a commit: rG7c34e74c2547: [OpenMP] Basic parse and sema support for modifiers in order clause.

In D127855#3956014, @sandeepkosuri wrote:

As I do not have commit access, can someone commit this patch, now that it passes the pre-merge tests ?

I see some tests failed after this patch. Failed only with -fopenmp-vesion=51

https://www.godbolt.org/z/3oxWTcxn7

Hi @sandeepkosuri, do you plan to fix this? Thanks. Jennifer

In D127855#4059776, @jyu2 wrote:

Hi @sandeepkosuri, do you plan to fix this? Thanks. Jennifer

Hi jyu2, sorry for a late reply, and yes I will fix it. Thanks for pointing this out.

In D127855#4048642, @jyu2 wrote:

In D127855#3956014, @sandeepkosuri wrote:

As I do not have commit access, can someone commit this patch, now that it passes the pre-merge tests ?

I see some tests failed after this patch. Failed only with -fopenmp-vesion=51

https://www.godbolt.org/z/3oxWTcxn7

Hey @jyu2 , this error is not reproducible anymore, I think the issue is solved, by someone else's patch.

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

[OpenMP] Basic parse and sema support for modifiers in order clause ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 482259

clang/include/clang/AST/OpenMPClause.h

clang/include/clang/Basic/DiagnosticSemaKinds.td

clang/include/clang/Basic/OpenMPKinds.h

clang/include/clang/Basic/OpenMPKinds.def

clang/include/clang/Sema/Scope.h

clang/include/clang/Sema/Sema.h

clang/lib/AST/OpenMPClause.cpp

clang/lib/Basic/OpenMPKinds.cpp

clang/lib/Parse/ParseOpenMP.cpp

clang/lib/Sema/Scope.cpp

clang/lib/Sema/SemaOpenMP.cpp

clang/lib/Sema/TreeTransform.h

clang/lib/Serialization/ASTReader.cpp

clang/lib/Serialization/ASTWriter.cpp

clang/test/OpenMP/distribute_parallel_for_ast_print.cpp

clang/test/OpenMP/distribute_parallel_for_messages.cpp

clang/test/OpenMP/distribute_parallel_for_simd_ast_print.cpp

clang/test/OpenMP/distribute_parallel_for_simd_misc_messages.c

clang/test/OpenMP/distribute_simd_ast_print.cpp

clang/test/OpenMP/distribute_simd_misc_messages.c

clang/test/OpenMP/for_ast_print.cpp

clang/test/OpenMP/for_misc_messages.c

clang/test/OpenMP/for_order_messages.cpp

clang/test/OpenMP/for_simd_ast_print.cpp

clang/test/OpenMP/for_simd_misc_messages.c

clang/test/OpenMP/master_taskloop_simd_ast_print.cpp

clang/test/OpenMP/parallel_for_ast_print.cpp

clang/test/OpenMP/parallel_for_messages.cpp

clang/test/OpenMP/parallel_for_simd_ast_print.cpp

clang/test/OpenMP/parallel_for_simd_misc_messages.c

clang/test/OpenMP/parallel_master_taskloop_simd_ast_print.cpp

clang/test/OpenMP/simd_ast_print.cpp

clang/test/OpenMP/simd_misc_messages.c

clang/test/OpenMP/target_parallel_for_ast_print.cpp

clang/test/OpenMP/target_parallel_for_messages.cpp

clang/test/OpenMP/target_parallel_for_simd_ast_print.cpp

clang/test/OpenMP/target_parallel_for_simd_loop_messages.cpp

clang/test/OpenMP/target_simd_ast_print.cpp

clang/test/OpenMP/target_simd_loop_messages.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_ast_print.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_messages.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_simd_ast_print.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_simd_loop_messages.cpp

clang/test/OpenMP/target_teams_distribute_simd_ast_print.cpp

clang/test/OpenMP/target_teams_distribute_simd_misc_messages.c

clang/test/OpenMP/taskloop_simd_ast_print.cpp

clang/test/OpenMP/taskloop_simd_misc_messages.c

clang/test/OpenMP/teams_distribute_parallel_for_ast_print.cpp

clang/test/OpenMP/teams_distribute_parallel_for_messages.cpp

clang/test/OpenMP/teams_distribute_parallel_for_simd_ast_print.cpp

clang/test/OpenMP/teams_distribute_parallel_for_simd_messages.cpp

clang/test/OpenMP/teams_distribute_simd_ast_print.cpp

clang/test/OpenMP/teams_distribute_simd_messages.cpp

[OpenMP] Basic parse and sema support for modifiers in order clause
ClosedPublic
Actions

Revision Contents
Changeset List