This patch adds implementations for the load/store SME ACLE intrinsics:
- @llvm.aarch64.sme.ld1*
- @llvm.aarch64.sme.st1*
Paths
| Differential D127210
[AArch64][SME] Add load/store intrinsics ClosedPublic Authored by RosieSumpter on Jun 7 2022, 5:39 AM.
Details Summary This patch adds implementations for the load/store SME ACLE intrinsics:
Diff Detail
Event Timelinepaulwalker-arm added inline comments.
Comment Actions I'm not going to comment on the design / implementation since I wrote much of it, but I've left a few minor comments
david-arm added a child revision: D127317: [AArch64][SME] Add ldr/str (fill/spill) intrinsics.Jun 8 2022, 9:01 AM aemerson added inline comments.
RosieSumpter marked 4 inline comments as done. Comment Actions
Comment Actions We can revisit the opaque pointers issue later. LGTM otherwise with a nit.
This revision is now accepted and ready to land.Jun 13 2022, 11:23 AM Closed by commit rG2c4e44752d1d: [AArch64][SME] Add load/store intrinsics (authored by RosieSumpter). · Explain WhyJun 14 2022, 3:19 AM This revision was automatically updated to reflect the committed changes. RosieSumpter marked an inline comment as done.
Revision Contents
Diff 436723 llvm/include/llvm/IR/Intrinsics.td
llvm/include/llvm/IR/IntrinsicsAArch64.td
llvm/lib/Target/AArch64/AArch64ISelDAGToDAG.cpp
llvm/lib/Target/AArch64/AArch64ISelLowering.h
llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
llvm/lib/Target/AArch64/AArch64RegisterInfo.cpp
llvm/lib/Target/AArch64/AArch64RegisterInfo.td
llvm/lib/Target/AArch64/SMEInstrFormats.td
llvm/lib/Target/AArch64/SVEInstrFormats.td
llvm/test/CodeGen/AArch64/SME/sme-intrinsics-loads.ll
llvm/test/CodeGen/AArch64/SME/sme-intrinsics-stores.ll
|
Given the transition to opaque pointers, should we be using such specific pointer types or can we just use llvm_ptr_ty instead?