Page MenuHomePhabricator

bryanpkc (Bryan Chan)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 28 2016, 3:30 AM (364 w, 4 d)

Recent Activity

Wed, Mar 1

bryanpkc added inline comments to D128648: [Clang][AArch64][SME] Add vector read/write (mova) intrinsics .
Wed, Mar 1, 9:53 AM · Restricted Project, Restricted Project

Sun, Feb 26

bryanpkc updated the diff for D128648: [Clang][AArch64][SME] Add vector read/write (mova) intrinsics .

Incorporated review comments for D127910:

Sun, Feb 26, 5:42 PM · Restricted Project, Restricted Project
bryanpkc updated the diff for D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics.

Fix some bugs in the range checks of immediate operands.

Sun, Feb 26, 5:36 PM · Restricted Project, Restricted Project
bryanpkc updated the diff for D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics.

Moved test case acle_target_sme.c into clang/test/Sema/aarch64-sme-intrinsics/.

Sun, Feb 26, 2:58 PM · Restricted Project, Restricted Project
bryanpkc added a comment to D127762: [Clang][AArch64] Add ACLE attributes for SME..

@sdesmalen @rsandifo-arm @aaron.ballman @erichkeane What is the plan for this patch? Is it going to be abandoned in favor of D139028, or can it be landed in its current form after addressing all outstanding review comments?

Sun, Feb 26, 7:24 AM · Restricted Project, Restricted Project
bryanpkc updated the summary of D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics.
Sun, Feb 26, 7:13 AM · Restricted Project, Restricted Project
bryanpkc updated the diff for D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics.

Removed EltTypeBool128 as suggested.

Sun, Feb 26, 7:09 AM · Restricted Project, Restricted Project

Feb 21 2023

bryanpkc added inline comments to D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics.
Feb 21 2023, 3:54 PM · Restricted Project, Restricted Project

Feb 19 2023

bryanpkc added inline comments to D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics.
Feb 19 2023, 4:26 PM · Restricted Project, Restricted Project
bryanpkc updated the diff for D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics.

Addressed review comments.

Feb 19 2023, 4:18 PM · Restricted Project, Restricted Project

Feb 13 2023

bryanpkc updated the diff for D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics.

Fixed minor bugs in the previous upload.

Feb 13 2023, 7:29 AM · Restricted Project, Restricted Project
bryanpkc added inline comments to D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics.
Feb 13 2023, 6:51 AM · Restricted Project, Restricted Project
bryanpkc updated the diff for D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics.

Addressed review comments.

Feb 13 2023, 6:49 AM · Restricted Project, Restricted Project

Feb 12 2023

bryanpkc added inline comments to D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics.
Feb 12 2023, 7:00 PM · Restricted Project, Restricted Project

Feb 7 2023

bryanpkc updated the diff for D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics.

Rebased on trunk and addressed review comments.

Feb 7 2023, 10:24 AM · Restricted Project, Restricted Project
bryanpkc added inline comments to D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics.
Feb 7 2023, 10:18 AM · Restricted Project, Restricted Project

Jan 27 2023

bryanpkc requested review of D142702: [Clang][AArch64][SME] Generate target features from +(no)sme.* options.
Jan 27 2023, 3:44 AM · Restricted Project, Restricted Project
bryanpkc updated the diff for D134681: [Clang][AArch64][SME] Add outer product intrinsics.

Rebased and cleaned up the patch. Also added _m suffix to the intrinsics as required by the amendment in https://github.com/ARM-software/acle/pull/218.

Jan 27 2023, 3:39 AM · Restricted Project, Restricted Project
bryanpkc updated the diff for D134680: [Clang][AArch64][SME] Add intrinsics for adding vector elements to ZA tile.

Added _m suffix to the intrinsics as required by the amendment in https://github.com/ARM-software/acle/pull/218.

Jan 27 2023, 3:37 AM · Restricted Project, Restricted Project
bryanpkc updated the diff for D134680: [Clang][AArch64][SME] Add intrinsics for adding vector elements to ZA tile.

Rebased and cleaned up the patch.

Jan 27 2023, 2:51 AM · Restricted Project, Restricted Project
bryanpkc updated the diff for D134679: [Clang][AArch64][SME] Add intrinsics for reading streaming vector length.

Rebased and cleaned up the patch.

Jan 27 2023, 2:48 AM · Restricted Project, Restricted Project
bryanpkc updated the diff for D134677: [Clang][AArch64][SME] Add ZA zeroing intrinsics.

Update patch with more context.

Jan 27 2023, 2:45 AM · Restricted Project, Restricted Project
bryanpkc updated the diff for D134678: [Clang][AArch64][SME] Add intrinsics for ZA array load/store (LDR/STR).

Rebased and cleaned up the patch.

Jan 27 2023, 2:43 AM · Restricted Project, Restricted Project
bryanpkc updated the summary of D134677: [Clang][AArch64][SME] Add ZA zeroing intrinsics.
Jan 27 2023, 2:36 AM · Restricted Project, Restricted Project
bryanpkc updated the diff for D128648: [Clang][AArch64][SME] Add vector read/write (mova) intrinsics .

Update patch with more context.

Jan 27 2023, 2:28 AM · Restricted Project, Restricted Project

Jan 26 2023

bryanpkc updated the diff for D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics.

Minor clean-up. Sorry for the noise.

Jan 26 2023, 3:19 PM · Restricted Project, Restricted Project
bryanpkc updated the diff for D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics.

Updated the patch to define the __ARM_FEATURE_SME macro when the feature is enabled.

Jan 26 2023, 3:13 PM · Restricted Project, Restricted Project

Jan 21 2023

bryanpkc commandeered D134679: [Clang][AArch64][SME] Add intrinsics for reading streaming vector length.
Jan 21 2023, 2:23 PM · Restricted Project, Restricted Project
bryanpkc commandeered D134680: [Clang][AArch64][SME] Add intrinsics for adding vector elements to ZA tile.
Jan 21 2023, 2:23 PM · Restricted Project, Restricted Project
bryanpkc commandeered D134681: [Clang][AArch64][SME] Add outer product intrinsics.
Jan 21 2023, 2:22 PM · Restricted Project, Restricted Project
bryanpkc commandeered D134678: [Clang][AArch64][SME] Add intrinsics for ZA array load/store (LDR/STR).
Jan 21 2023, 2:18 PM · Restricted Project, Restricted Project

Jan 20 2023

bryanpkc committed rG275ab246ee81: [Clang][test] Avoid FileCheck error when matching `-cc1` (authored by hezuoqiang <hezuoqiang2@huawei.com>).
[Clang][test] Avoid FileCheck error when matching `-cc1`
Jan 20 2023, 8:37 PM · Restricted Project, Restricted Project
bryanpkc closed D141886: [Clang][test] Avoid FileCheck error when matching `-cc1`.
Jan 20 2023, 8:37 PM · Restricted Project, Restricted Project
bryanpkc accepted D141886: [Clang][test] Avoid FileCheck error when matching `-cc1`.

LGTM

Jan 20 2023, 4:29 AM · Restricted Project, Restricted Project

Jan 17 2023

bryanpkc requested changes to D141886: [Clang][test] Avoid FileCheck error when matching `-cc1`.
Jan 17 2023, 10:47 AM · Restricted Project, Restricted Project

Jan 16 2023

bryanpkc added reviewers for D141886: [Clang][test] Avoid FileCheck error when matching `-cc1`: bryanpkc, rsmith, ABataev.
Jan 16 2023, 7:53 PM · Restricted Project, Restricted Project
bryanpkc added a comment to D141886: [Clang][test] Avoid FileCheck error when matching `-cc1`.

Thanks for the patch. I just have some simple suggestions.

Jan 16 2023, 7:47 PM · Restricted Project, Restricted Project

Jan 9 2023

bryanpkc updated the diff for D134677: [Clang][AArch64][SME] Add ZA zeroing intrinsics.
Jan 9 2023, 4:39 AM · Restricted Project, Restricted Project
bryanpkc commandeered D134677: [Clang][AArch64][SME] Add ZA zeroing intrinsics.
Jan 9 2023, 4:38 AM · Restricted Project, Restricted Project
bryanpkc updated the diff for D128648: [Clang][AArch64][SME] Add vector read/write (mova) intrinsics .

Removed incorrect IsPreservesZA flag from SVWRITE intrinsics.

Jan 9 2023, 4:22 AM · Restricted Project, Restricted Project

Jan 8 2023

bryanpkc updated the diff for D128648: [Clang][AArch64][SME] Add vector read/write (mova) intrinsics .

Re-upload to add diff context. No change to the patch itself.

Jan 8 2023, 7:53 PM · Restricted Project, Restricted Project
bryanpkc updated the diff for D128648: [Clang][AArch64][SME] Add vector read/write (mova) intrinsics .

Rebased on the new D127910.

Jan 8 2023, 7:29 PM · Restricted Project, Restricted Project
bryanpkc commandeered D128648: [Clang][AArch64][SME] Add vector read/write (mova) intrinsics .
Jan 8 2023, 6:36 PM · Restricted Project, Restricted Project

Dec 8 2022

bryanpkc updated the diff for D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics.

Removed some more unnecessary lines.

Dec 8 2022, 2:05 AM · Restricted Project, Restricted Project

Dec 7 2022

bryanpkc updated the diff for D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics.

Removed some diffs that weren't necessary.

Dec 7 2022, 6:52 PM · Restricted Project, Restricted Project
bryanpkc added a comment to D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics.

@david-arm, I have moved all the SME definitions into a new file, arm_sme.td. I have moved the common definitions into another file, arm_sve_sme_incl.td, which will be included by both arm_sve.td and arm_sme.td. SveEmitter has been updated to incorporate your suggestions.

Dec 7 2022, 6:18 PM · Restricted Project, Restricted Project
bryanpkc updated the diff for D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics.

Updated the patch according to review comments which suggest to treat SME as a different architecture.

Dec 7 2022, 6:12 PM · Restricted Project, Restricted Project

Nov 24 2022

bryanpkc commandeered D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics.

Hi @sagarkulkarni19, just a gentle ping to see if you are still planning to do more work on this patch?

Nov 24 2022, 3:34 PM · Restricted Project, Restricted Project

Oct 3 2022

bryanpkc added inline comments to D133896: [AArch64][SME] Add codegen pass to handle ZA state in arm_new_za functions..
Oct 3 2022, 2:44 PM · Restricted Project, Restricted Project

Aug 24 2022

bryanpkc added a comment to D132529: [AArch64] Fix sched model for tsv110.

LGTM.

Aug 24 2022, 10:18 AM · Restricted Project, Restricted Project

Jul 21 2022

bryanpkc added inline comments to D130166: [flang] Adding a guideline for flang design documentation.
Jul 21 2022, 11:16 AM · Restricted Project, Restricted Project

Jun 9 2022

bryanpkc added inline comments to D127342: [TargetTransformInfo] Added an option for the cache line size.
Jun 9 2022, 9:30 AM · Restricted Project, Restricted Project, Restricted Project

Apr 1 2022

Herald added a project to D93351: [llvm-shlib] Build backend libraries as loadable modules: Restricted Project.
Apr 1 2022, 10:40 AM · Restricted Project, Restricted Project

Mar 22 2022

bryanpkc committed rG5269dd7f4877: [ThinLTO] Work around buggy FileCheck pattern; NFC (authored by bryanpkc).
[ThinLTO] Work around buggy FileCheck pattern; NFC
Mar 22 2022, 5:40 AM · Restricted Project

Aug 24 2021

bryanpkc added a comment to D108123: [MemoryBuiltins] Mark user defined delete as nobuiltin.

The C++ standard says all the optimizations we want to do on new/delete expressions are legal whether or not the user replaces the operators . See [expr.new] (http://eel.is/c++draft/expr.new#12) . The weird issues this patch is trying to fix only show up when the definitions are available.

Aug 24 2021, 6:51 AM · Restricted Project, Restricted Project

Aug 23 2021

bryanpkc added a comment to D108123: [MemoryBuiltins] Mark user defined delete as nobuiltin.

Just saying "any function with a definition isn't a target library function" probably produces a sane result in most cases.

Aug 23 2021, 5:09 AM · Restricted Project, Restricted Project

Aug 19 2021

bryanpkc added a comment to D108123: [MemoryBuiltins] Mark user defined delete as nobuiltin.

Wasn't there some command-line argument to specify that a certain builtin isn't a builtin?

Aug 19 2021, 5:59 AM · Restricted Project, Restricted Project

Jul 21 2021

bryanpkc added a comment to D105575: [AArch64][SME] Add zero instruction.

@bryanpkc you make a good point and it would be interested to see those patches!

For this patch I think that unless the changes you're suggesting are trivial, it would make sense to have any changes that are not required for the assembler as follow-up patches. I'm a bit cautious about this otherwise holding up SME asm support into LLVM 13, since those changes aren't necessarily required for the assembler.

Jul 21 2021, 8:45 PM · Restricted Project

Jul 20 2021

bryanpkc added a comment to D105575: [AArch64][SME] Add zero instruction.

Hi @bryanpkc, thanks for the comments. Do you also have an implementation for this?

Jul 20 2021, 8:28 AM · Restricted Project

Jul 19 2021

bryanpkc added a comment to D105575: [AArch64][SME] Add zero instruction.

Hi @c-rhodes, we had done some design work for the ZERO instruction, and it is interesting to see your implementation. I have some questions about the code, based on my understanding of the ISA.

Jul 19 2021, 11:30 AM · Restricted Project

Jun 7 2021

bryanpkc committed rG54f059c9007b: [OpenMP] Check loc for NULL before dereferencing it (authored by bryanpkc).
[OpenMP] Check loc for NULL before dereferencing it
Jun 7 2021, 7:46 AM

Apr 29 2021

bryanpkc accepted D101532: [AArch64] Change __ARM_FEATURE_FP16FML macro name to __ARM_FEATURE_FP16_FML.

LGTM. Thanks.

Apr 29 2021, 9:42 AM · Restricted Project

Mar 13 2021

bryanpkc updated subscribers of D95376: [OpenMP][Libomptarget] Fix check-libomptarget.

@tstellar Can this patch be cherry-picked into release/12.x? It fixes libomptarget testing in downstream compilers.

Mar 13 2021, 1:10 PM · Restricted Project
bryanpkc added inline comments to D97080: [flang][driver] Add -fintrinsic-modules-path option.
Mar 13 2021, 10:09 AM · Restricted Project, Restricted Project
bryanpkc added inline comments to D98580: [flang][OpenMP] Add support for getting parent context and clauses and modify the relevant sema checks to use the new functions..
Mar 13 2021, 9:48 AM · Restricted Project

Mar 4 2021

bryanpkc added a comment to D97119: [flang][driver] Add options for -std=f2018.

I agree with @richard.barton.arm that we could add -std= now, even if only for a subset of possible language standards. I expect that standard conformance checks would be quite pervasive, and it would be better to design the infrastructure for such checks earlier rather than try to retrofit them at a later stage when we have to start supporting f202x, etc.

Mar 4 2021, 2:35 AM · Restricted Project, Restricted Project

Jan 20 2021

bryanpkc updated subscribers of rGfa1e543e0b8c: [flang][driver] Update error messages (nfc).

@awarzynski, @sscalpone added the rule in C++Style.md in fdb58597e859. Perhaps Steve could explain the motivation for deviating from Clang's style guide (https://llvm.org/docs/CodingStandards.html#error-and-warning-messages)? IMO Flang should behave more consistently with Clang, especially if we start sharing more code between the two frontends going forward.

Jan 20 2021, 8:29 AM

Dec 10 2020

bryanpkc added a comment to D63329: Allow static linking of libc++ on Linux, just like -static-libstdc++.

@erikjv Are you still working on this? Or is a better alternative being pursued? IIUC, this functionality is still missing in trunk.

Dec 10 2020, 10:14 AM · Restricted Project, Restricted Project

Oct 29 2020

bryanpkc added inline comments to D89972: Add pipeline model for HiSilicon's TSV110.
Oct 29 2020, 10:33 PM · Restricted Project, Restricted Project

Sep 14 2020

bryanpkc added a comment to D86843: [EarlyCSE] Equivalent SELECTs should hash equally.

Apologies for the bug and thanks @hliao for the quick fix.

Sep 14 2020, 5:55 AM · Restricted Project

Sep 10 2020

bryanpkc committed rGc9826829d74e: [EarlyCSE] Equivalent SELECTs should hash equally (authored by bryanpkc).
[EarlyCSE] Equivalent SELECTs should hash equally
Sep 10 2020, 2:00 PM
bryanpkc closed D86843: [EarlyCSE] Equivalent SELECTs should hash equally.
Sep 10 2020, 2:00 PM · Restricted Project
bryanpkc added a comment to D86843: [EarlyCSE] Equivalent SELECTs should hash equally.

Thanks Sanjay.

Sep 10 2020, 1:56 PM · Restricted Project

Sep 6 2020

bryanpkc requested review of D87204: [EarlyCSE] Force hash collision with EXPENSIVE_CHECKS.
Sep 6 2020, 5:52 AM · Restricted Project, Restricted Project

Sep 4 2020

bryanpkc added a comment to D86843: [EarlyCSE] Equivalent SELECTs should hash equally.

Pinging reviewers.

Sep 4 2020, 7:42 AM · Restricted Project
bryanpkc committed rG3404add4684d: [EarlyCSE] Verify hash code in regression tests (authored by bryanpkc).
[EarlyCSE] Verify hash code in regression tests
Sep 4 2020, 7:41 AM
bryanpkc closed D86863: [EarlyCSE] Verify hash code in regression tests.
Sep 4 2020, 7:41 AM · Restricted Project
bryanpkc added inline comments to D86863: [EarlyCSE] Verify hash code in regression tests.
Sep 4 2020, 7:35 AM · Restricted Project

Sep 3 2020

bryanpkc updated the summary of D86863: [EarlyCSE] Verify hash code in regression tests.
Sep 3 2020, 12:56 PM · Restricted Project
bryanpkc added inline comments to D86863: [EarlyCSE] Verify hash code in regression tests.
Sep 3 2020, 12:55 PM · Restricted Project
bryanpkc updated the diff for D86863: [EarlyCSE] Verify hash code in regression tests.

Removed the change to the default value of EarlyCSEDebugHash as per @lebedev.ri's suggestion.

Sep 3 2020, 12:43 PM · Restricted Project
bryanpkc committed rGa09eef113f17: Replace CRLF with LF; NFC (authored by bryanpkc).
Replace CRLF with LF; NFC
Sep 3 2020, 12:30 PM

Aug 31 2020

bryanpkc updated the summary of D86863: [EarlyCSE] Verify hash code in regression tests.
Aug 31 2020, 1:56 AM · Restricted Project
bryanpkc requested review of D86863: [EarlyCSE] Verify hash code in regression tests.
Aug 31 2020, 1:55 AM · Restricted Project

Aug 30 2020

bryanpkc updated the diff for D86843: [EarlyCSE] Equivalent SELECTs should hash equally.

Fixed linter warning.

Aug 30 2020, 11:15 AM · Restricted Project
bryanpkc added a comment to D86843: [EarlyCSE] Equivalent SELECTs should hash equally.
  1. As a preparatory patch, we should adjust every test that uses EarlyCSE to also specify -earlycse-debug-hash, at least to those where it doesn't result in an assertion

Thanks for your suggestions, Roman. I have added the reproducer to the EarlyCSE tests, next to other similar test cases. Regarding your first suggestion, do you mean that we should enable -earlycse-debug-hash in all tests under llvm/test/Transforms/EarlyCSE/, or even all tests under llvm/test/ that may implicitly use EarlyCSE?

At least for every test that explicitly uses -early-cse.

That seems like overkill.

OTOH these bugs aren't fun, and they should be trivially caught by existing tests, since the test coverage should be good anyways.

Aug 30 2020, 11:13 AM · Restricted Project
bryanpkc added inline comments to D86843: [EarlyCSE] Equivalent SELECTs should hash equally.
Aug 30 2020, 11:12 AM · Restricted Project
bryanpkc added a comment to D86843: [EarlyCSE] Equivalent SELECTs should hash equally.
  1. As a preparatory patch, we should adjust every test that uses EarlyCSE to also specify -earlycse-debug-hash, at least to those where it doesn't result in an assertion
Aug 30 2020, 11:07 AM · Restricted Project
bryanpkc updated the diff for D86843: [EarlyCSE] Equivalent SELECTs should hash equally.

Added a regression test using the -earlycse-debug-hash option.

Aug 30 2020, 11:00 AM · Restricted Project

Aug 29 2020

bryanpkc updated the diff for D86843: [EarlyCSE] Equivalent SELECTs should hash equally.

Cleaned up unused code.

Aug 29 2020, 7:13 PM · Restricted Project
bryanpkc updated the diff for D86843: [EarlyCSE] Equivalent SELECTs should hash equally.

Moved the fix into matchSelectWithOptionalNotCond instead of duplicating code.

Aug 29 2020, 7:11 PM · Restricted Project
bryanpkc requested review of D86843: [EarlyCSE] Equivalent SELECTs should hash equally.
Aug 29 2020, 3:39 PM · Restricted Project

Jun 18 2020

bryanpkc added a comment to D80801: [DAGCombiner] allow more folding of fadd + fmul into fma.

We are only pulling the trailing addition in with an existing multiply.

The problem here is that it's the "wrong" multiply: you have, essentially (A*B+D*E)+F, and you're turning it into A*B+(D*E+F). I don't think contraction is supposed to cover that.

Jun 18 2020, 6:03 PM · Restricted Project
bryanpkc added a comment to D80801: [DAGCombiner] allow more folding of fadd + fmul into fma.

Sorry for the late question, but I don't understand why this kind of folding is not considered reassociation. I thought reassociation was not allowed even when -ffp-contract=fast.

Jun 18 2020, 2:15 PM · Restricted Project

Apr 14 2020

bryanpkc committed rGb86ff5f6efbe: [OpenMP] Sync writes to child thread's data before reduction (authored by bryanpkc).
[OpenMP] Sync writes to child thread's data before reduction
Apr 14 2020, 11:51 AM
bryanpkc closed D77603: [OpenMP] Sync writes to child thread's data before reduction.
Apr 14 2020, 11:51 AM · Restricted Project

Apr 13 2020

bryanpkc added a comment to D77603: [OpenMP] Sync writes to child thread's data before reduction.

Yes, ideally barriers of all types should have these extra synchronizations, though with lesser priority I think. Because other barriers do not work by default, they need to be explicitly requested.

Apr 13 2020, 2:13 PM · Restricted Project
bryanpkc added a comment to D77603: [OpenMP] Sync writes to child thread's data before reduction.

Sorry, found one more issue.

I think the first MB should be moved inside the block:

for (level...
  if (((tid...
Apr 13 2020, 11:17 AM · Restricted Project
bryanpkc updated the diff for D77603: [OpenMP] Sync writes to child thread's data before reduction.

Pair the memory barriers correctly at the same nesting level within the loop.

Apr 13 2020, 10:44 AM · Restricted Project
bryanpkc updated the diff for D77603: [OpenMP] Sync writes to child thread's data before reduction.

Add a paired memory barrier to the child thread's path after it finishes writing to its own data and before releasing the parent thread.

Apr 13 2020, 3:44 AM · Restricted Project