Page MenuHomePhabricator

bryanpkc (Bryan Chan)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 28 2016, 3:30 AM (155 w, 6 d)

Recent Activity

Feb 15 2019

bryanpkc added a comment to D53927: [AArch64] Enable libm vectorized functions via SLEEF.

Thanks Stephan, now looks good.

Did you see the comment on lgamma coming after isoc99? I wonder if that's reproducible in all systems...

Yup I saw it. But I don't get any errors here (Ubuntu 16.04 / Ubuntu 18.something) AArch64.

And it's not clear to me how that sorted alphabetical order is supposed to work. There's a bunch of other functions that come after lgamma/tgamma that aren't sorted.

For example:

/// char * __strtok_r(char *s, const char *delim, char **save_ptr);
TLI_DEFINE_ENUM_INTERNAL(dunder_strtok_r)
TLI_DEFINE_STRING_INTERNAL("__strtok_r")
/// int abs(int j);
TLI_DEFINE_ENUM_INTERNAL(abs)
TLI_DEFINE_STRING_INTERNAL("abs")
/// int access(const char *path, int amode);
TLI_DEFINE_ENUM_INTERNAL(access)
TLI_DEFINE_STRING_INTERNAL("access")
Feb 15 2019, 3:35 PM · Restricted Project

Feb 13 2019

bryanpkc added inline comments to D53927: [AArch64] Enable libm vectorized functions via SLEEF.
Feb 13 2019, 1:13 PM · Restricted Project

Feb 5 2019

bryanpkc added a comment to D47210: [lit] Fix the `--max-time` flag feature which was completely broken..

Is there any plan to fix this patch and land it? We use --max-time in our tests and intermittently run into the Python assertion. We can work around the problem by killing lit.py with another timer, but then we lose the report that lit.py produces at the end of the run.

Feb 5 2019, 9:33 AM

Jan 10 2019

bryanpkc committed rL350825: [AArch64] Fix operation actions for FP16 vector intrinsics.
[AArch64] Fix operation actions for FP16 vector intrinsics
Jan 10 2019, 7:06 AM
bryanpkc closed D56296: [AArch64] Fix operation actions for FP16 vector intrinsics.
Jan 10 2019, 7:06 AM
bryanpkc updated the diff for D56296: [AArch64] Fix operation actions for FP16 vector intrinsics.

Rebased on trunk.

Jan 10 2019, 7:05 AM
bryanpkc updated the diff for D56296: [AArch64] Fix operation actions for FP16 vector intrinsics.

Removed trailing spaces. NFC.

Jan 10 2019, 5:12 AM

Jan 8 2019

bryanpkc added a comment to D56296: [AArch64] Fix operation actions for FP16 vector intrinsics.

Pinging reviewers.

Jan 8 2019, 4:42 PM

Jan 3 2019

bryanpkc created D56296: [AArch64] Fix operation actions for FP16 vector intrinsics.
Jan 3 2019, 3:16 PM

Nov 26 2018

bryanpkc added inline comments to D54633: [NFC][AArch64] Split out backend features.
Nov 26 2018, 2:24 PM

Nov 22 2018

bryanpkc added inline comments to D54633: [NFC][AArch64] Split out backend features.
Nov 22 2018, 10:45 PM

Nov 9 2018

bryanpkc committed rL346546: [AArch64] Support HiSilicon's TSV110 processor.
[AArch64] Support HiSilicon's TSV110 processor
Nov 9 2018, 11:34 AM
bryanpkc closed D53908: [AArch64] Support HiSilicon's TSV110 processor.
Nov 9 2018, 11:34 AM
bryanpkc added a comment to D53908: [AArch64] Support HiSilicon's TSV110 processor.

Thanks Kristof!

Nov 9 2018, 10:59 AM

Nov 6 2018

bryanpkc added a comment to D53908: [AArch64] Support HiSilicon's TSV110 processor.

Pinging reviewers....

Nov 6 2018, 10:19 AM

Nov 1 2018

bryanpkc updated the diff for D53908: [AArch64] Support HiSilicon's TSV110 processor.

Added a unit test for lib/Support/Host.cpp and removed some redundant tests.

Nov 1 2018, 2:28 PM
bryanpkc added inline comments to D53908: [AArch64] Support HiSilicon's TSV110 processor.
Nov 1 2018, 2:27 PM

Oct 30 2018

bryanpkc created D53908: [AArch64] Support HiSilicon's TSV110 processor.
Oct 30 2018, 3:34 PM

Oct 29 2018

bryanpkc committed rL345515: [AArch64] Rename FP16FML instruction format (NFC).
[AArch64] Rename FP16FML instruction format (NFC)
Oct 29 2018, 10:29 AM

Oct 25 2018

bryanpkc committed rC345344: [AArch64] Implement FP16FML intrinsics.
[AArch64] Implement FP16FML intrinsics
Oct 25 2018, 4:51 PM
bryanpkc committed rL345344: [AArch64] Implement FP16FML intrinsics.
[AArch64] Implement FP16FML intrinsics
Oct 25 2018, 4:50 PM
bryanpkc closed D53633: [AArch64] Implement FP16FML intrinsics.
Oct 25 2018, 4:50 PM · Restricted Project
bryanpkc committed rL345337: [AArch64] Implement FP16FML intrinsics.
[AArch64] Implement FP16FML intrinsics
Oct 25 2018, 4:39 PM
bryanpkc closed D53632: [AArch64] Implement FP16FML intrinsics.
Oct 25 2018, 4:39 PM

Oct 24 2018

bryanpkc added a comment to D53633: [AArch64] Implement FP16FML intrinsics.

I think this is reasonable.

Oct 24 2018, 12:02 PM · Restricted Project

Oct 23 2018

bryanpkc updated the diff for D53632: [AArch64] Implement FP16FML intrinsics.

Updated the patch to avoid using monorepo path names.

Oct 23 2018, 9:44 PM
bryanpkc created D53633: [AArch64] Implement FP16FML intrinsics.
Oct 23 2018, 9:42 PM · Restricted Project
bryanpkc created D53632: [AArch64] Implement FP16FML intrinsics.
Oct 23 2018, 9:34 PM

Sep 3 2018

bryanpkc added inline comments to D50685: [AArch64] Support conversion between fp16 and fp128.
Sep 3 2018, 11:37 PM

Aug 25 2018

bryanpkc added a comment to D50685: [AArch64] Support conversion between fp16 and fp128.

Pinging reviewers...

Aug 25 2018, 3:43 PM

Aug 15 2018

bryanpkc added a reviewer for D50685: [AArch64] Support conversion between fp16 and fp128: howard.hinnant.
Aug 15 2018, 12:06 PM

Aug 13 2018

bryanpkc created D50685: [AArch64] Support conversion between fp16 and fp128.
Aug 13 2018, 8:58 PM

Aug 6 2018

bryanpkc committed rL339013: [AArch64] Fix assertion failure on widened f16 BUILD_VECTOR.
[AArch64] Fix assertion failure on widened f16 BUILD_VECTOR
Aug 6 2018, 7:15 AM
bryanpkc closed D50202: [AArch64] Fix assertion failure on widened f16 BUILD_VECTOR.
Aug 6 2018, 7:15 AM

Aug 3 2018

bryanpkc updated the diff for D50202: [AArch64] Fix assertion failure on widened f16 BUILD_VECTOR.

Removed impossible code path from NormalizeBuildVector.

Aug 3 2018, 2:21 PM
bryanpkc added inline comments to D50202: [AArch64] Fix assertion failure on widened f16 BUILD_VECTOR.
Aug 3 2018, 10:21 AM

Aug 2 2018

bryanpkc created D50202: [AArch64] Fix assertion failure on widened f16 BUILD_VECTOR.
Aug 2 2018, 3:33 PM

Aug 1 2018

bryanpkc committed rL338554: [AArch64] Fix FCCMP with FP16 operands.
[AArch64] Fix FCCMP with FP16 operands
Aug 1 2018, 6:51 AM
bryanpkc closed D50115: [AArch64] Fix FCCMP with FP16 operands.
Aug 1 2018, 6:50 AM

Jul 31 2018

bryanpkc created D50115: [AArch64] Fix FCCMP with FP16 operands.
Jul 31 2018, 4:29 PM

Jul 2 2018

bryanpkc added a comment to D48614: [SelectionDAG] Fix promotion of extracted FP vector element.

There are actually two selection DAGs for that test. I'm not sure why yet. The final schedule is printed separately for each DAG.

Jul 2 2018, 10:59 PM
bryanpkc added inline comments to D48614: [SelectionDAG] Fix promotion of extracted FP vector element.
Jul 2 2018, 9:03 PM

Jun 26 2018

bryanpkc created D48614: [SelectionDAG] Fix promotion of extracted FP vector element.
Jun 26 2018, 3:11 PM

Jun 17 2016

bryanpkc added a comment to D14727: [Driver] Adapt Linux::GCCVersion::Parse to match GCC 5 installations.

Thanks for the review! I have committed the patch.

Jun 17 2016, 9:54 AM
bryanpkc committed rL273012: [Driver] Adapt Linux::GCCVersion::Parse to match GCC 5 installations.
[Driver] Adapt Linux::GCCVersion::Parse to match GCC 5 installations
Jun 17 2016, 9:54 AM
bryanpkc closed D14727: [Driver] Adapt Linux::GCCVersion::Parse to match GCC 5 installations.
Jun 17 2016, 9:53 AM

Jun 14 2016

bryanpkc added a comment to D14727: [Driver] Adapt Linux::GCCVersion::Parse to match GCC 5 installations.

Ping?

Jun 14 2016, 7:32 PM

May 26 2016

bryanpkc updated the diff for D14727: [Driver] Adapt Linux::GCCVersion::Parse to match GCC 5 installations.

Re-added test/Driver/Inputs/gcc_version_parsing5/lib/gcc/i386-unknown-linux/4.9.2/crtbegin.o.

May 26 2016, 5:22 PM
bryanpkc updated the diff for D14727: [Driver] Adapt Linux::GCCVersion::Parse to match GCC 5 installations.

Fixed the code to set GoodVersion.MajorStr before returning, and removed an unnecessary file (test/Driver/Inputs/gcc_version_parsing5/lib/gcc/i386-unknown-linux/4.9.2/crtbegin.o).

May 26 2016, 5:06 PM
bryanpkc commandeered D14727: [Driver] Adapt Linux::GCCVersion::Parse to match GCC 5 installations.
May 26 2016, 5:03 PM

May 19 2016

bryanpkc committed rL270062: Avoid an assertion failure when a bit field is extracted from a value of the….
Avoid an assertion failure when a bit field is extracted from a value of the…
May 19 2016, 6:58 AM
bryanpkc closed D20355: Avoid an assertion failure when a bit field is extracted from a value of the same size..
May 19 2016, 6:57 AM
bryanpkc added a comment to D20355: Avoid an assertion failure when a bit field is extracted from a value of the same size..

Do you have commit access?

May 19 2016, 6:21 AM

May 18 2016

bryanpkc updated the diff for D20355: Avoid an assertion failure when a bit field is extracted from a value of the same size..

Added a unit test in ScalarTest.cpp that catches this particular error.

May 18 2016, 3:47 PM
bryanpkc committed rL269922: [SystemZ] Fix register ordering for BinaryRRF instructions.
[SystemZ] Fix register ordering for BinaryRRF instructions
May 18 2016, 6:31 AM
bryanpkc closed D20308: [SystemZ] Fix register ordering for BinaryRRF instructions by committing rL269922: [SystemZ] Fix register ordering for BinaryRRF instructions.
May 18 2016, 6:31 AM
bryanpkc retitled D20355: Avoid an assertion failure when a bit field is extracted from a value of the same size. from to Avoid an assertion failure when a bit field is extracted from a value of the same size..
May 18 2016, 2:17 AM

May 16 2016

bryanpkc committed rL269688: [SystemZ] Support LRVH and STRVH opcodes.
[SystemZ] Support LRVH and STRVH opcodes
May 16 2016, 1:38 PM
bryanpkc closed D18732: [SystemZ] Support LRVH and STRVH opcodes.
May 16 2016, 1:38 PM

May 13 2016

bryanpkc added a comment to D20033: [RuntimeDyld] Support R_390_PC64 relocation type.

Thanks for the review. I will try to add some test cases in a future patch.

May 13 2016, 10:31 AM
bryanpkc committed rL269436: [RuntimeDyld] Support R_390_PC64 relocation type.
[RuntimeDyld] Support R_390_PC64 relocation type
May 13 2016, 10:30 AM
bryanpkc closed D20033: [RuntimeDyld] Support R_390_PC64 relocation type.
May 13 2016, 10:29 AM

May 6 2016

bryanpkc retitled D20033: [RuntimeDyld] Support R_390_PC64 relocation type from to [RuntimeDyld] Support R_390_PC64 relocation type.
May 6 2016, 2:18 PM

May 4 2016

bryanpkc committed rL268520: Fix a SIGSEGV caused by dereferencing a pointer without a null check.
Fix a SIGSEGV caused by dereferencing a pointer without a null check
May 4 2016, 10:30 AM

Apr 28 2016

bryanpkc added a comment to D19432: [SystemZ] Support Swift calling convention.

Thank you for the reviews.

Apr 28 2016, 7:02 AM
bryanpkc committed rL267879: [SystemZ] Support Swift calling convention.
[SystemZ] Support Swift calling convention
Apr 28 2016, 7:02 AM
bryanpkc closed D19432: [SystemZ] Support Swift calling convention.
Apr 28 2016, 7:02 AM

Apr 27 2016

bryanpkc added a comment to D19414: [SystemZ] Support Swift Calling Convention.

Thanks for the review.

Apr 27 2016, 8:38 PM
bryanpkc committed rL267823: [SystemZ] Support Swift Calling Convention.
[SystemZ] Support Swift Calling Convention
Apr 27 2016, 5:23 PM
bryanpkc closed D19414: [SystemZ] Support Swift Calling Convention.
Apr 27 2016, 5:23 PM
bryanpkc added a reviewer for D19432: [SystemZ] Support Swift calling convention: uweigand.
Apr 27 2016, 10:50 AM

Apr 22 2016

bryanpkc retitled D19432: [SystemZ] Support Swift calling convention from to [SystemZ] Support Swift calling convention.
Apr 22 2016, 1:26 PM
bryanpkc updated D19414: [SystemZ] Support Swift Calling Convention.
Apr 22 2016, 8:43 AM
bryanpkc retitled D19414: [SystemZ] Support Swift Calling Convention from to [SystemZ] Support Swift Calling Convention.
Apr 22 2016, 8:43 AM

Apr 4 2016

bryanpkc added a comment to D18732: [SystemZ] Support LRVH and STRVH opcodes.

Your change to README.txt implies that LRVH and STRVH still are not generated by the compiler. However, the change to SystemZInstrInfo.td actually installs DAG patterns for the SelectionDAG pass to recognize, so this is somewhat confusing.

Apr 4 2016, 5:20 AM

Apr 2 2016

bryanpkc retitled D18732: [SystemZ] Support LRVH and STRVH opcodes from to [SystemZ] Support LRVH and STRVH opcodes.
Apr 2 2016, 2:43 PM
bryanpkc updated the diff for D18644: [SystemZ] Support ATOMIC_FENCE.

I have updated the patch to mimic the behaviour of ATOMIC_FENCE on X86, as suggested.

Apr 2 2016, 7:36 AM

Mar 31 2016

bryanpkc retitled D18644: [SystemZ] Support ATOMIC_FENCE from to [SystemZ] Support ATOMIC_FENCE.
Mar 31 2016, 6:07 AM

Mar 30 2016

bryanpkc updated D18514: [SystemZ] Support llvm.frameaddress/llvm.returnaddress intrinsics.
Mar 30 2016, 5:17 PM
bryanpkc updated the diff for D18514: [SystemZ] Support llvm.frameaddress/llvm.returnaddress intrinsics.

Hi Ulrich, thank you for your review. You are right that the non-zero frame traversal count is probably not very common. In the updated patch, I have removed the proposed -mattr=backchain changes. Is it better?

Mar 30 2016, 5:16 PM

Mar 28 2016

bryanpkc retitled D18514: [SystemZ] Support llvm.frameaddress/llvm.returnaddress intrinsics from to [SystemZ] Support llvm.frameaddress/llvm.returnaddress intrinsics.
Mar 28 2016, 4:13 AM