User Details
- User Since
- Mar 28 2016, 3:30 AM (364 w, 4 d)
Wed, Mar 1
Sun, Feb 26
Incorporated review comments for D127910:
Fix some bugs in the range checks of immediate operands.
Moved test case acle_target_sme.c into clang/test/Sema/aarch64-sme-intrinsics/.
@sdesmalen @rsandifo-arm @aaron.ballman @erichkeane What is the plan for this patch? Is it going to be abandoned in favor of D139028, or can it be landed in its current form after addressing all outstanding review comments?
Removed EltTypeBool128 as suggested.
Feb 21 2023
Feb 19 2023
Addressed review comments.
Feb 13 2023
Fixed minor bugs in the previous upload.
Addressed review comments.
Feb 12 2023
Feb 7 2023
Rebased on trunk and addressed review comments.
Jan 27 2023
Rebased and cleaned up the patch. Also added _m suffix to the intrinsics as required by the amendment in https://github.com/ARM-software/acle/pull/218.
Added _m suffix to the intrinsics as required by the amendment in https://github.com/ARM-software/acle/pull/218.
Rebased and cleaned up the patch.
Rebased and cleaned up the patch.
Update patch with more context.
Rebased and cleaned up the patch.
Update patch with more context.
Jan 26 2023
Minor clean-up. Sorry for the noise.
Updated the patch to define the __ARM_FEATURE_SME macro when the feature is enabled.
Jan 21 2023
Jan 20 2023
LGTM
Jan 17 2023
Jan 16 2023
Thanks for the patch. I just have some simple suggestions.
Jan 9 2023
Removed incorrect IsPreservesZA flag from SVWRITE intrinsics.
Jan 8 2023
Re-upload to add diff context. No change to the patch itself.
Rebased on the new D127910.
Dec 8 2022
Removed some more unnecessary lines.
Dec 7 2022
Removed some diffs that weren't necessary.
@david-arm, I have moved all the SME definitions into a new file, arm_sme.td. I have moved the common definitions into another file, arm_sve_sme_incl.td, which will be included by both arm_sve.td and arm_sme.td. SveEmitter has been updated to incorporate your suggestions.
Updated the patch according to review comments which suggest to treat SME as a different architecture.
Nov 24 2022
Oct 3 2022
Aug 24 2022
LGTM.
Jul 21 2022
Jun 9 2022
Apr 1 2022
Mar 22 2022
Aug 24 2021
The C++ standard says all the optimizations we want to do on new/delete expressions are legal whether or not the user replaces the operators . See [expr.new] (http://eel.is/c++draft/expr.new#12) . The weird issues this patch is trying to fix only show up when the definitions are available.
Aug 23 2021
Just saying "any function with a definition isn't a target library function" probably produces a sane result in most cases.
Aug 19 2021
Wasn't there some command-line argument to specify that a certain builtin isn't a builtin?
Jul 21 2021
@bryanpkc you make a good point and it would be interested to see those patches!
For this patch I think that unless the changes you're suggesting are trivial, it would make sense to have any changes that are not required for the assembler as follow-up patches. I'm a bit cautious about this otherwise holding up SME asm support into LLVM 13, since those changes aren't necessarily required for the assembler.
Jul 20 2021
Hi @bryanpkc, thanks for the comments. Do you also have an implementation for this?
Jul 19 2021
Hi @c-rhodes, we had done some design work for the ZERO instruction, and it is interesting to see your implementation. I have some questions about the code, based on my understanding of the ISA.
Jun 7 2021
Apr 29 2021
LGTM. Thanks.
Mar 13 2021
@tstellar Can this patch be cherry-picked into release/12.x? It fixes libomptarget testing in downstream compilers.
Mar 4 2021
I agree with @richard.barton.arm that we could add -std= now, even if only for a subset of possible language standards. I expect that standard conformance checks would be quite pervasive, and it would be better to design the infrastructure for such checks earlier rather than try to retrofit them at a later stage when we have to start supporting f202x, etc.
Jan 20 2021
@awarzynski, @sscalpone added the rule in C++Style.md in fdb58597e859. Perhaps Steve could explain the motivation for deviating from Clang's style guide (https://llvm.org/docs/CodingStandards.html#error-and-warning-messages)? IMO Flang should behave more consistently with Clang, especially if we start sharing more code between the two frontends going forward.
Dec 10 2020
@erikjv Are you still working on this? Or is a better alternative being pursued? IIUC, this functionality is still missing in trunk.
Oct 29 2020
Sep 14 2020
Apologies for the bug and thanks @hliao for the quick fix.
Sep 10 2020
Thanks Sanjay.
Sep 6 2020
Sep 4 2020
Pinging reviewers.
Sep 3 2020
Removed the change to the default value of EarlyCSEDebugHash as per @lebedev.ri's suggestion.
Aug 31 2020
Aug 30 2020
Fixed linter warning.
Added a regression test using the -earlycse-debug-hash option.
Aug 29 2020
Cleaned up unused code.
Moved the fix into matchSelectWithOptionalNotCond instead of duplicating code.
Jun 18 2020
Sorry for the late question, but I don't understand why this kind of folding is not considered reassociation. I thought reassociation was not allowed even when -ffp-contract=fast.
Apr 14 2020
Apr 13 2020
Pair the memory barriers correctly at the same nesting level within the loop.
Add a paired memory barrier to the child thread's path after it finishes writing to its own data and before releasing the parent thread.