This patch corrects some diagnostics for the SVE sizeless vector
operators, including correctly diagnosing when the vectors are
different sizes.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
| clang/lib/Sema/SemaExpr.cpp | ||
|---|---|---|
| 10609–10614 | why is this removed? | |
| 10614 | missing a test for this? | |
| clang/test/Sema/aarch64-sve-vector-arith-ops.c | ||
| 23 | I think these vector + imm tests should be removed in D126380 but fine to keep here if it's easier | |
| clang/lib/Sema/SemaExpr.cpp | ||
|---|---|---|
| 10609–10614 | This is sort of an artefact of splitting this and D126380; essentially that patch was motivated by the fact that this code here doesn't really do anything meaningful for scalable vectors. I added it for symmetry with non-scalable vectors but the triggers for conversions here don't really fire in meaningful code. | |
| 10614 | I wrote this test but seem to have forgotten to add it... Will do that! | |
| clang/test/Sema/aarch64-sve-vector-arith-ops.c | ||
| 23 | Ah yes I missed this, you're correct but I will be pushing the two patches at the same time so I guess it doesn't matter much except for correct history? Happy to change it though. | |
| clang/test/Sema/aarch64-sve-vector-arith-ops.c | ||
|---|---|---|
| 23 |
Yeah no worries keep them in here, thanks for clarifying | |
missing a test for this?