This is an archive of the discontinued LLVM Phabricator instance.

[NFC][RISCV] Reuse ISD::NodeType in float extension
ClosedPublic

Authored by achieveartificialintelligence on Feb 23 2022, 7:26 AM.

Diff Detail

Event Timeline

achieveartificialintelligence requested review of this revision.Feb 23 2022, 7:26 AM
craig.topper added inline comments.Feb 23 2022, 11:34 AM
llvm/lib/Target/RISCV/RISCVISelLowering.cpp
321

I think you should add static here. It will prevent FPLegalNodeTypes from being created as a local variable on the stack which requires initialization code. Making it static will put it in the .rodata section instead.

achieveartificialintelligence marked an inline comment as done.

Address @craig.topper's comment

asb accepted this revision.Feb 24 2022, 3:38 AM

LGTM, thanks.

This revision is now accepted and ready to land.Feb 24 2022, 3:38 AM
This revision was landed with ongoing or failed builds.Feb 24 2022, 3:58 AM
This revision was automatically updated to reflect the committed changes.