This is an archive of the discontinued LLVM Phabricator instance.

[CMake] Rename TARGET_TRIPLE to LLVM_TARGET_TRIPLE
ClosedPublic

Authored by phosek on Feb 15 2022, 11:55 PM.

Details

Summary

This clarifies that this is an LLVM specific variable and avoids
potential conflicts with other projects.

Diff Detail

Event Timeline

phosek created this revision.Feb 15 2022, 11:55 PM
Herald added a reviewer: rafauler. · View Herald Transcript
Herald added a reviewer: Amir. · View Herald Transcript
Herald added a reviewer: maksfb. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
phosek requested review of this revision.Feb 15 2022, 11:55 PM
Herald added projects: Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project. · View Herald TranscriptFeb 15 2022, 11:55 PM
MaskRay accepted this revision.Feb 15 2022, 11:58 PM
MaskRay added a subscriber: MaskRay.

Looks great!

This revision is now accepted and ready to land.Feb 15 2022, 11:58 PM
rovka added a subscriber: rovka.Feb 16 2022, 1:48 AM

Is this going to break for everyone that still passes TARGET_TRIPLE to cmake? If so, we should probably have a period where we support both.

In particular, this might break some of our buildbots who explicitly set TARGET_TRIPLE. Could you send a patch to zorg cleaning that up (and maybe wait for that to go through before removing TARGET_TRIPLE completely)?

ldionne accepted this revision.Feb 16 2022, 6:16 AM

LGTM from libc++/libc++abi's perspective.

phosek updated this revision to Diff 409394.Feb 16 2022, 1:36 PM

Provide fallback for TARGET_TRIPLE and print a warning about deprecation and future removal.

rovka accepted this revision.Feb 17 2022, 4:52 AM

I'm happy if the buildbots are happy :D thanks.

Shall we land this?

Herald added a project: Restricted Project. · View Herald TranscriptMar 4 2022, 11:26 AM
Amir accepted this revision.Mar 4 2022, 11:35 AM

LGTM from BOLT side

@phosek @rovka

no need those changes for CrossWinToARMLinux.cmake. TARGET_TRIPLE is using to parametrize the cache file only.
But if there is a goal to completely remove TARGET_TRIPLE from the source tree I will update the cache file and the buildbot configuration accordingly

This revision was landed with ongoing or failed builds.Mar 11 2022, 3:43 PM
This revision was automatically updated to reflect the committed changes.