User Details
- User Since
- Nov 26 2013, 11:15 AM (373 w, 3 d)
Nov 30 2020
LGTM
Nov 27 2020
Nov 25 2020
Nov 13 2020
Nov 10 2020
OK, it is not a problem.
I'll prepare another patch with the string formatting fixes.
Nov 5 2020
Oct 30 2020
LGTM
Oct 27 2020
LGTM
Oct 22 2020
also tested with the aarch64/armv7 compiler-rt tests on Windows cross builders.
LGTM
UNSUPPORTED: * is not working actually. Please check a build log for linux > Builtins-x86_64-linux.Builtins-x86_64-linux::gcc_personality_test.c above. It says
ValueError: Error in UNSUPPORTED list: couldn't parse text: '*' in expression: '*'
Sep 17 2020
jfi for updated diff: the cross toolchain build on Windows has passed. check-llvm/check-clang also looks ok.
Sep 16 2020
Hi @AndrewLitteken,
sorry, but this commit fails the cross toolchain builders on Windows platform with the following errors:
FAILED: lib/Analysis/CMakeFiles/LLVMAnalysis.dir/IRSimilarityIdentifier.cpp.obj C:\PROGRA~2\MICROS~1\2017\COMMUN~1\VC\Tools\MSVC\1416~1.270\bin\Hostx64\x64\cl.exe /nologo /TP -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib\Analysis -IC:\buildbot\as-builder-2\x-aarch64\llvm-project\llvm\lib\Analysis -Iinclude -IC:\buildbot\as-builder-2\x-aarch64\llvm-project\llvm\include -D__OPTIMIZE__ /Zc:inline /Zc:__cplusplus /Zc:strictStrings /Oi /Zc:rvalueCast /bigobj /W4 -wd4141 -wd4146 -wd4244 -wd4267 -wd4291 -wd4351 -wd4456 -wd4457 -wd4458 -wd4459 -wd4503 -wd4624 -wd4722 -wd4100 -wd4127 -wd4512 -wd4505 -wd4610 -wd4510 -wd4702 -wd4245 -wd4706 -wd4310 -wd4701 -wd4703 -wd4389 -wd4611 -wd4805 -wd4204 -wd4577 -wd4091 -wd4592 -wd4319 -wd4709 -wd4324 -w14062 -we4238 /Gw /MD /O2 /Ob2 /EHs-c- /GR- -UNDEBUG -std:c++14 /showIncludes /Folib\Analysis\CMakeFiles\LLVMAnalysis.dir\IRSimilarityIdentifier.cpp.obj /Fdlib\Analysis\CMakeFiles\LLVMAnalysis.dir\LLVMAnalysis.pdb /FS -c C:\buildbot\as-builder-2\x-aarch64\llvm-project\llvm\lib\Analysis\IRSimilarityIdentifier.cpp C:\buildbot\as-builder-2\x-aarch64\llvm-project\llvm\include\llvm/Analysis/IRSimilarityIdentifier.h(154): error C3861: 'hash_value': identifier not found C:\buildbot\as-builder-2\x-aarch64\llvm-project\llvm\include\llvm/Analysis/IRSimilarityIdentifier.h(154): error C2672: 'llvm::IRSimilarity::hash_value': no matching overloaded function found C:\buildbot\as-builder-2\x-aarch64\llvm-project\llvm\include\llvm/Analysis/IRSimilarityIdentifier.h(153): error C2672: 'hash_combine': no matching overloaded function found
see more details here:
http://lab.llvm.org:8011/builders/llvm-clang-win-x-aarch64/builds/3016
http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l/builds/1265
Sep 10 2020
Sep 4 2020
Sep 2 2020
Hi Sergej,
Aug 31 2020
the LLVM::minsize-call-cse-2.ll test gets failed on llvm-clang-x86_64-expensive-checks-ubuntu builder:
http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-ubuntu/builds/8634
Aug 26 2020
sorry, but looks like your changes break one of libc++ tests on ARM cross toolchain build on Windows: libc++::function_type_default_deleter.fail.cpp
Here is the first failed build: http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l/builds/945
Aug 24 2020
@enh,
may be let's commit the fix? This problem keeps the builder in red for a week already.
Aug 21 2020
It works fine now for me
Testing Time: 61.79s Unsupported: 12 Passed : 51
I understand, not a problem. I'm testing the updated patch.
Aug 20 2020
The test got failed again. I got the following output:
ubuntu@jetson8:~$ ./t.tmp.exe Testing 29715 symbols. 1ILeeeEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEE -> <-0x1.cecececececececececececececep+11983L Got instead: <-0x1.cecececececececececececececep+11983L> t.tmp.exe: C:/buildbot/temp/llvm-project/libcxxabi/test/test_demangle.pass.cpp:30001: void testFPLiterals(): Assertion `false' failed. Aborted (core dumped)
looks like it does not expect trailing >.
I ran the test directly on our aarch64 board. The output is the following
ubuntu@jetson8:~$ ./t.tmp.exe Testing 29715 symbols. 1ILeeeEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEE -> <-0x1.cecececececececececececececep+11983 Got instead: <-0x1.cecececececececececececececep+11983L> t.tmp.exe: C:/buildbot/temp/llvm-project/libcxxabi/test/test_demangle.pass.cpp:30001: void testFPLiterals(): Assertion `false' failed. Aborted (core dumped)
Aug 17 2020
Thank you @smeenai,
not a problem.
Aug 15 2020
sorry, but LLVM::universal-output.test test gets failed on the armv7 cross toolchain buider.
Here is a direct link to the failed test log
http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l/builds/802
Aug 13 2020
I have tested the patch with VS2017/cl 19.16 build + clang/llvm tests and clang/llvm unit tests.
It looks fine.
Jul 30 2020
commit 84a8d8239a92abef139a41730d8a22a74e2bf083 Author: Vladimir Vereschaka <vvereschaka@accesssoftek.com> Date: Thu Jun 18 13:50:09 2020 -0700
Jul 27 2020
Hi Sergei,
sorry for a late answer.
I have tested these changes on Windows cross build to Aarch64 and I found the following problems:
Jun 26 2020
Hi Dmitri, Eduardo,
Jun 25 2020
Hello Eduardo,
Jun 18 2020
Jun 13 2020
Jun 12 2020
Jun 7 2020
Hi Alex,
May 27 2020
Hi Marco,
May 13 2020
May 1 2020
Apr 30 2020
I see that Harbormaster failed the build on Windows, but there is a lot of error: Connection to server timed out errors. Looks like there is some problem with that build system.
I have tested this patch on the ubuntu builder with enabled expensive checks and no-inputs.test test has passed.
Is there maybe a problem with this buildbot and parameters like -out:<value>?
This is the expensive checks builder and I see this crash on all that kind of builders
Hi Eric,
Apr 29 2020
Hi @compnerd,
here is one more place, which needs a proper detection for Python3/Python2.
I just copied a part of your changes accordingly.
also we get the following cmake warning during the build
CMake Warning at C:/buildbot/as-builder-1/llvm-clang-win-x-armv7l/llvm-project/llvm/cmake/modules/AddLLVM.cmake:1638 (message): LLVM_EXTERNAL_LIT set to C:/buildbot/as-builder-1/llvm-clang-win-x-armv7l/build/./bin/llvm-lit, but the path does not exist. Call Stack (most recent call first): C:/buildbot/as-builder-1/llvm-clang-win-x-armv7l/llvm-project/llvm/cmake/modules/AddLLVM.cmake:1682 (get_llvm_lit_path) C:/buildbot/as-builder-1/llvm-clang-win-x-armv7l/llvm-project/llvm/cmake/modules/AddLLVM.cmake:1727 (add_lit_target) C:/buildbot/as-builder-1/llvm-clang-win-x-armv7l/llvm-project/libunwind/test/CMakeLists.txt:33 (add_lit_testsuite)
Mar 27 2020
LGTM
Mar 12 2020
here is failed libunwind test on Aarch64 toolchain builder
http://lab.llvm.org:8011/builders/llvm-clang-win-x-aarch64/builds/5660
LGTM
I was able to build with these changes successfully on the local builder host.
Mar 11 2020
I tried to reproduce the problem on the builder in a temporary folder and I found that CMAKE_SOURCE_DIR == CMAKE_BINARY_DIR == <build_dir>.
Here is a list of all CMAKE_ variables available on a moment of initial configuration:
-- CMAKE_AR: c:/buildbot/temp/build/bin/llvm-ar.exe -- CMAKE_BINARY_DIR: C:/buildbot/temp/build -- CMAKE_BUILD_TYPE: Release -- CMAKE_CL_SHOWINCLUDES_PREFIX: Note: including file: -- CMAKE_COMMAND: C:/Program Files/CMake/bin/cmake.exe -- CMAKE_CPACK_COMMAND: C:/Program Files/CMake/bin/cpack.exe -- CMAKE_CROSSCOMPILING: ON -- CMAKE_CTEST_COMMAND: C:/Program Files/CMake/bin/ctest.exe -- CMAKE_CURRENT_BINARY_DIR: C:/buildbot/temp/build -- CMAKE_CURRENT_LIST_DIR: C:/buildbot/temp/llvm-project/clang/cmake/caches -- CMAKE_CURRENT_LIST_FILE: C:/buildbot/temp/llvm-project/clang/cmake/caches/CrossWinToARMLinux.cmake -- CMAKE_CURRENT_SOURCE_DIR: C:/buildbot/temp/build -- CMAKE_CXX_FLAGS: -D__OPTIMIZE__ -- CMAKE_C_COMPILER_TARGET: armv7-linux-gnueabihf -- CMAKE_FILES_DIRECTORY: /CMakeFiles -- CMAKE_HOST_SYSTEM_NAME: Windows -- CMAKE_HOST_WIN32: 1 -- CMAKE_INSTALL_PREFIX: ../install -- CMAKE_MAJOR_VERSION: 3 -- CMAKE_MINOR_VERSION: 10 -- CMAKE_PATCH_VERSION: 2 -- CMAKE_ROOT: C:/Program Files/CMake/share/cmake-3.10 -- CMAKE_SOURCE_DIR: C:/buildbot/temp/build -- CMAKE_TWEAK_VERSION: 0 -- CMAKE_VERSION: 3.10.2
Looks like this is a feature (bug?_ of CMake. CMake doc says
CMAKE_SOURCE_DIR The path to the top level of the source tree.
Mar 3 2020
Feb 28 2020
updated with revision 62983613a0def0859fdcc823e385202f7f6101b5
@gkistanova ping
Feb 25 2020
this commit breaks Aarch64 builder with failed Clang::uninit-asm-goto.cpp test
http://lab.llvm.org:8011/builders/llvm-clang-win-x-aarch64/builds/5020
Feb 18 2020
looks like these changes broke the ARM builders:
http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l/builds/4749
http://lab.llvm.org:8011/builders/llvm-clang-win-x-aarch64/builds/4752
Feb 14 2020
these changes break the tests on the expensive check builder
http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-ubuntu/builds/2884
Feb 12 2020
OpenMPIRBuilderTest.ParallelCancelBarrier is failed on Windows builders:
it also gets failed on the Linux builders
These changes break few Windows builders
- http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l/builds/4527/steps/build-llvm-project/logs/stdio
- http://lab.llvm.org:8011/builders/llvm-clang-win-x-aarch64/builds/4523/steps/build-llvm-project/logs/stdio
- http://lab.llvm.org:8011/builders/llvm-clang-x86_64-win-fast/builds/11232/steps/build-unified-tree/logs/stdio
LGTM
Feb 7 2020
Also got failed clang tests on Arm/Aarch64 builders
the builders are broken for the third day in a row.
Sorry, but I'm going to revert this commit.
Feb 6 2020
these changes break the ARM cross builders on Windows:
http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l/builds/4240
Feb 5 2020
Hello Petr,
Feb 3 2020
commited with id 7e272b6925855525b62859c86b1b319438189849
commitied with id f3823f5fe91d59d9b5ef840380e2dff70d406952
commited with id e7e9b4eca0b8fc474a61ab232ee5133dff62003d
Jan 31 2020
Jan 29 2020
the CodeGen/AArch64/global-merge-hidden-minsize.ll test gets failed on aarch64 builder
http://lab.llvm.org:8011/builders/llvm-clang-win-x-aarch64/builds/3704/steps/test-check-llvm/logs/FAIL%3A%20LLVM%3A%3Aglobal-merge-hidden-minsize.ll
Jan 28 2020
Jan 21 2020
You mean, instead of ninja check-cxx just invoke LIT directly and pass this argument?