Same broken test on the arm cross builders:

• https://lab.llvm.org/buildbot/#/builders/60/builds/12166/steps/14/logs/FAIL__llvm-libc__-static_cfg_in__transitive_includ
• https://lab.llvm.org/buildbot/#/builders/119/builds/13457/steps/14/logs/FAIL__llvm-libc__-static_cfg_in__transitive_includ

works for me, thanks.

it was fixed for armv7l, but these changes do not work for armv7-* targets.

@azat would you fix the test also for armv7-unknown-linux-gnueabihf target?

the llvm-clang-win-x-armv7l builder runs the libc++ tests on the NV Jetson tk1 ARM board. This board has a limited memory: KiB Mem : 1788136 total, 90716 free, 148584 used, 1548836 buff/cache
In case MAX_INT is >2G for that target we should get an out-of-memory exception there or something similar.
I'll start looking, but most likely a reason of the test failures is a limited memory on the boards.

Unfortunately I don't think I can really try to fix it without having access to some hardware. If you could give me access to a machine I'd be happy to work on fixing this.

@philnik,

Since this is isn't a libc++-supported configuration AFAICT and reverting the patch would break our own CI, I don't think that's an option.

This is supported libc++ configuration.

here is a problem with the test during the remote runs on the windows cross builders. A lot of those messages because of broken path:

clang++: error: no such file or directory: 'C:buildbotas-builder-1x-armv7lllvm-projectlibcxxtestlibcxxmodules_include.sh.cpp'
clang++: error: no input files
...

• https://lab.llvm.org/buildbot/#/builders/60/builds/10870/steps/14/logs/FAIL__llvm-libc__-static_cfg_in__modules_include_s
• https://lab.llvm.org/buildbot/#/builders/119/builds/12143/steps/14/logs/FAIL__llvm-libc__-static_cfg_in__modules_include_s

the CodeGen/MLRegalloc/bb-profile-dump.ll test gets failed on arm/aarch64 cross builders with these changes:

would you provide a complete rollback for the changes and fix the C1689.cppm test failures on the builders

I have tested the latest changes on llvm-nvptx-nvidia-ubuntu (https://lab.llvm.org/buildbot/#/builders/234) builder locally and the unit tests get built and run successfully.
Thank you @huangjd.

check-llvm gets failed with the following linker errors:

FAILED: unittests/tools/llvm-profdata/LLVMProfdataTests 
: && /usr/bin/c++ -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-maybe-uninitialized -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -fuse-ld=gold     -Wl,--gc-sections unittests/tools/llvm-profdata/CMakeFiles/LLVMProfdataTests.dir/OutputSizeLimitTest.cpp.o -o unittests/tools/llvm-profdata/LLVMProfdataTests  -Wl,-rpath,/home/buildbot/worker/as-builder-7/llvm-nvptx-nvidia-ubuntu/build/lib  lib/libLLVMProfileData.so.16git  lib/libllvm_gtest_main.so.16git  lib/libLLVMTestingSupport.so.16git  lib/libllvm_gtest.so.16git  lib/libLLVMSupport.so.16git  -Wl,-rpath-link,/home/buildbot/worker/as-builder-7/llvm-nvptx-nvidia-ubuntu/build/lib && :
unittests/tools/llvm-profdata/CMakeFiles/LLVMProfdataTests.dir/OutputSizeLimitTest.cpp.o:OutputSizeLimitTest.cpp:function TestOutputSizeLimit_TestOutputSizeLimit1_Test::TestBody() [clone .localalias]: error: undefined reference to 'llvm::LLVMContext::LLVMContext()'
unittests/tools/llvm-profdata/CMakeFiles/LLVMProfdataTests.dir/OutputSizeLimitTest.cpp.o:OutputSizeLimitTest.cpp:function TestOutputSizeLimit_TestOutputSizeLimit1_Test::TestBody() [clone .localalias]: error: undefined reference to 'llvm::LLVMContext::~LLVMContext()'
collect2: error: ld returned 1 exit status

https://lab.llvm.org/buildbot/#/builders/234/builds/2655

Hi @brad,
thank you for fixing the broken tests.

would you fix the tests
https://lab.llvm.org/buildbot/#/builders/60/builds/10125

Updated the builder configurations - removed collapseRequests option. Also reduced a number of concurrent builds for the Windows worker to 1.

ping

Added nvptx-nvidia builders into the patch.

They are not ready yet, but ok.

@gkistanova
these new workers have the same access token as all our as-builder-* workers.

@ldionne ,
I have checked out our cmake cache for win-to-linux cross builds and I found that we already use the "new-style" test configuration files all libs accordingly: llvm-libc++-static.cfg.in, llvm-libc++abi-static.cfg.in and llvm-libunwind-static.cfg.in. It works fine for the builds currently.
We provide <lib>_TARGET_INFO=libcxx.test.target_info.LinuxRemoteTI and <lib>_EXECUTOR cmake vars only for these configurations.
Actually, the tests work without <lib>_TARGET_INFO also, but because there is still an appropriate parameter I did keep them there just in case.

Hi @ldionne. Got it, thank you! I'll check our cmake cache file out and remove any deprecated variables.

got it. Yes, looks like it fixed. The test got passed during the last build: https://lab.llvm.org/buildbot/#/builders/104/builds/7812
Thank you.

the zero-call-used-regs.ll test gets failed on llvm-clang-x86_64-expensive-checks-ubuntu builder with the following errors:

...
*** Bad machine code: Illegal physical register for instruction ***
- function:    all_arg
- basic block: %bb.0 entry (0x555be568bb88)
- instruction: $q0 = MOVID 0
- operand 0:   $q0
$q0 is not a FPR64 register.
...

see more details here https://lab.llvm.org/buildbot/#/builders/104/builds/7797/steps/6/logs/FAIL__LLVM__zero-call-used-regs_ll

the FAIL: llvm-libunwind-static.cfg.in:: aarch64.ra_sign_state.pass.cpp test is getting failed on Linux Ubuntu/Aarch64 toolchain builders with the following output:

@dgg5503, I did one more rebuild and this time the result completely different. In comparison with the previous build, where libcxx ci and windows tests have failed, this time all those tests have passed, but the debian target tests have failed. I suppose, because these changes touch the common cmake configuration file, it triggers all possible cases/targets for the builds and not all of these tests are work correctly in that time.
So, the changes are not related with these failed tests. I'll commit your changes.

Thank you @paulkirth. I have tested these changes locally on the builder. It works fine.

Hi @dgg5503, thank you, LGTM, but the pre-build status is failed. I don't see that failing of those tests are related with these changes. Anyway, would you double check it just in case?

using of specific triple within stack-usage-safestack.c test causes a failure for the compilers, which don't support these triples (arm/aarch64 in my case).
Such as:

error: unable to create target: 'No available targets are compatible with triple "i386-apple-darwin"'

see more details in https://lab.llvm.org/buildbot/#/builders/119/builds/8169/steps/9/logs/FAIL__Clang__stack-usage-safestack_c result for the failed build.

@ldionne, would you take a look? I would like to restart our ARMv7 win-to-linux cross builder with these new configuration files, but they don't work with the remote test execution properly.

thank you a lot! The armv7/aarch64 cross win-x-linux release builders are green now:

• https://lab.llvm.org/buildbot/#/builders/144/builds/238
• https://lab.llvm.org/buildbot/#/builders/143/builds/262

I found that the release/14.x branch has missed at least the following commits for clang/cmake/caches/CrossWinToARMLinux.cmake file:

thank you a lot to pointing at the problems. Looks like armv7 builder gets failed because of some missed commits. aarch64 looks very strange, but also possible that there is the same reason.
I'm investigating the problems.

@gkistanova I would like to connect those workers/builders to the staging master at first and switch to the production master later.

I'm testing https://reviews.llvm.org/D119918 locally on the builders. Looks like TARGET_TRIPLE as a cache file parameter slightly affects the configuration. I'm getting the warnings during the initial configuration.
I'll replace the parameter name to TOOLCHAIN_TARGET_TRIPLE to avoid the possible future mistakes and just in case.

no need those changes for CrossWinToARMLinux.cmake. TARGET_TRIPLE is using to parametrize the cache file only.
But if there is a goal to completely remove TARGET_TRIPLE from the source tree I will update the cache file and the buildbot configuration accordingly

I was planning on landing https://reviews.llvm.org/D119918 which renames TARGET_TRIPLE in CrossWinToARMLinux.cmake, would that address the issue?

Those builders are currently on staging buildbot.

the TARGET_TRIPLE is a parameter for the CrossWinToARMLinux.cmake cache file and used within it to configure the build, including LLVM_DEFAULT_TARGET_TRIPLE. Your changes will break the Win-to-Linux cross toolchain builds.
Would you revert your commit?

@vvereschaka @broadwaylamb clang/cmake/caches/CrossWinToARMLinux.cmake is using those variables -- we should try to use the native CMake equivalents instead.

@ldionne , thank you. 'll update CrossWinToARMLinux.cmake accordingly.

@ldionne

@vvereschaka Actually, I think it's adding a space after -isystem that broke your Windows build.

yes, that's it. Thank you, it is fixed now.

The libc++::in_out_result.pass.cpp test gets failed to build with the following error:

Updated with revision id 6911944e3a24864c6560733310c1047af9a9f5a6

Do we need to apply attribute((noinline)) to main? Can you try that out and let me know if that helps?

I ran these changes on Linux (Ubuntu 18.04)/Aarch64 board. The test gets failed because of missed 'main':

ubuntu@jetson8:/tmp$ ./t.tmp.exe 
info.dli_sname: _Z14signal_handleri
info.dli_sname: __kernel_rt_sigreturn
info.dli_sname: _Z18crashing_leaf_funcv
info.dli_sname: __libc_start_main

Hi @danielkiss,
The buildbot's build is broken already for more than one day without attention. Sorry, but I'm going to revert this commit.

understood, thank you!
I'll take a closer look at these warnings to figure out the source.