LGTM

here is failed libunwind test on Aarch64 toolchain builder
http://lab.llvm.org:8011/builders/llvm-clang-win-x-aarch64/builds/5660

LGTM
I was able to build with these changes successfully on the local builder host.

I tried to reproduce the problem on the builder in a temporary folder and I found that CMAKE_SOURCE_DIR == CMAKE_BINARY_DIR == <build_dir>.
Here is a list of all CMAKE_ variables available on a moment of initial configuration:

-- CMAKE_AR: c:/buildbot/temp/build/bin/llvm-ar.exe
-- CMAKE_BINARY_DIR: C:/buildbot/temp/build
-- CMAKE_BUILD_TYPE: Release
-- CMAKE_CL_SHOWINCLUDES_PREFIX: Note: including file:
-- CMAKE_COMMAND: C:/Program Files/CMake/bin/cmake.exe
-- CMAKE_CPACK_COMMAND: C:/Program Files/CMake/bin/cpack.exe
-- CMAKE_CROSSCOMPILING: ON
-- CMAKE_CTEST_COMMAND: C:/Program Files/CMake/bin/ctest.exe
-- CMAKE_CURRENT_BINARY_DIR: C:/buildbot/temp/build
-- CMAKE_CURRENT_LIST_DIR: C:/buildbot/temp/llvm-project/clang/cmake/caches
-- CMAKE_CURRENT_LIST_FILE: C:/buildbot/temp/llvm-project/clang/cmake/caches/CrossWinToARMLinux.cmake
-- CMAKE_CURRENT_SOURCE_DIR: C:/buildbot/temp/build
-- CMAKE_CXX_FLAGS: -D__OPTIMIZE__
-- CMAKE_C_COMPILER_TARGET: armv7-linux-gnueabihf
-- CMAKE_FILES_DIRECTORY: /CMakeFiles
-- CMAKE_HOST_SYSTEM_NAME: Windows
-- CMAKE_HOST_WIN32: 1
-- CMAKE_INSTALL_PREFIX: ../install
-- CMAKE_MAJOR_VERSION: 3
-- CMAKE_MINOR_VERSION: 10
-- CMAKE_PATCH_VERSION: 2
-- CMAKE_ROOT: C:/Program Files/CMake/share/cmake-3.10
-- CMAKE_SOURCE_DIR: C:/buildbot/temp/build
-- CMAKE_TWEAK_VERSION: 0
-- CMAKE_VERSION: 3.10.2

Looks like this is a feature (bug?_ of CMake. CMake doc says

CMAKE_SOURCE_DIR
The path to the top level of the source tree.

updated with revision 62983613a0def0859fdcc823e385202f7f6101b5

@gkistanova ping

this commit breaks Aarch64 builder with failed Clang::uninit-asm-goto.cpp test
http://lab.llvm.org:8011/builders/llvm-clang-win-x-aarch64/builds/5020

looks like these changes broke the ARM builders:
http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l/builds/4749
http://lab.llvm.org:8011/builders/llvm-clang-win-x-aarch64/builds/4752

these changes break the tests on the expensive check builder
http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-ubuntu/builds/2884

OpenMPIRBuilderTest.ParallelCancelBarrier is failed on Windows builders:

it also gets failed on the Linux builders

These changes break few Windows builders

• http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l/builds/4527/steps/build-llvm-project/logs/stdio
• http://lab.llvm.org:8011/builders/llvm-clang-win-x-aarch64/builds/4523/steps/build-llvm-project/logs/stdio
• http://lab.llvm.org:8011/builders/llvm-clang-x86_64-win-fast/builds/11232/steps/build-unified-tree/logs/stdio

LGTM

Also got failed clang tests on Arm/Aarch64 builders

the builders are broken for the third day in a row.
Sorry, but I'm going to revert this commit.

these changes break the ARM cross builders on Windows:
http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l/builds/4240

Hello Petr,

commited with id 7e272b6925855525b62859c86b1b319438189849

commitied with id f3823f5fe91d59d9b5ef840380e2dff70d406952

commited with id e7e9b4eca0b8fc474a61ab232ee5133dff62003d

the CodeGen/AArch64/global-merge-hidden-minsize.ll test gets failed on aarch64 builder
http://lab.llvm.org:8011/builders/llvm-clang-win-x-aarch64/builds/3704/steps/test-check-llvm/logs/FAIL%3A%20LLVM%3A%3Aglobal-merge-hidden-minsize.ll

You mean, instead of ninja check-cxx just invoke LIT directly and pass this argument?

Hi Richard,

LGTM

May be just keep a note in the comments that this lit parameter is required for the remote libcxx tests.

Hi Sergej,

LGTM

LGTM

@gkistanova
I have tested this patch on the silent master and it works as expected.

Thank you Sterling, I agree.

Sorry, I mean the silent master.
I would like to test those changes before we run them on the staged master.

Thank you Sterling.
LGTM

Hi Sterling Augustine,

Thank you @gkistanova
Would we test this patch on the staged builder?

Hi Victor,

Updated CMake configuration parameter names and worker properties for Window to ARM Linux cross builder (armv7).

Renamed configuration arguments to REMOTE_TEST_HOST and REMOTE_TEST_USER

I have updated the diff without using those options.

Done

Thank you Sergej.

The commit has been reverted by 3d3445e3e691a34a72643d07e675c618adeddafc

Thanks @mgorny and @krytarowski for letting me know.

LGTM

LGTM