- User Since
- Aug 19 2016, 10:21 AM (130 w, 5 d)
Switch to clang-library-headers pending cfe-dev discussion
Ah, I didn't realize there were existing uses of DEPS, but thanks for the rename :)
Fri, Feb 15
I'm not entirely happy with the name clang-dev-headers, and am open to suggestions. It's unfortunate clang-headers was already taken for something different, but renaming that target or increasing its scope seems bad for existing users. Other possibilities I thought of include clang-tooling-headers, though that might be confused with the headers for libTooling specifically, and clang-library-headers. I'm open to suggestions.
CC @lebedev.ri, since I believe you raised some issues during the corresponding LLVM change but those were addressed.
Thu, Feb 14
A couple of things I noticed while writing this patch:
Wed, Feb 13
LGTM. There's more clean up that could be done here, but this addresses the immediate issue. Thanks!
This could also be improved by teaching clang to use LLVM_BUILD_MAIN_SRC_DIR when that's available.
Tue, Feb 12
Can you also add clang-tools-extra to LLVM_ALL_PROJECTS?
Mon, Feb 11
I think the commit message could be clarified a bit. Something like
I'll give @ruiu a bit to commit this, since he reviewed it, otherwise I can take care of that for you.
Fri, Feb 8
Do you need someone to commit this for you?
LGTM, thanks! I think this makes more sense than before.
@phosek and I discussed this on IRC, and I'm summarizing our discussion here. We're not sure if it actually makes sense for the runtimes build to set the *_STANDALONE_BUILD variables, and he was gonna play with that.
Thu, Feb 7
Wed, Feb 6
I'm putting this up for review just in case there's some potential for breakage I'm not seeing. Note that all these directories are present in the old monorepo as well, so it shouldn't break anyone who's still on that.
Tue, Feb 5
Ah, I just saw your llvm-dev posts. Thanks :)
Mon, Feb 4
Do you have any follow-up plans here? No pressure; just didn't want to potentially duplicate any work.
Sat, Feb 2
Fri, Feb 1
+@hans for the release branch.
Would it be equivalent if you changed https://reviews.llvm.org/diffusion/L/browse/llvm/trunk/cmake/modules/AddLLVM.cmake;352949$1007-1009?as=source&blame=off from an option to a FORCEd cache set? The default value is computed based off the presence of the corresponding LLVM_EXTERNAL_*_SOURCE_DIR variable, which will be set for each project in LLVM_ENABLE_PROJECTS.
Thu, Jan 31
Wait, what happens if you call shutil.rmtree with the \\?\ normalized path, instead of dropping down to ctypes?
Tue, Jan 29
An alternative would be to just add build to our top-level .gitignore, assuming that's what most people are naming their build directory. @pcc attempted to do something a bit more ambitious in D57400, but just ignoring /build* (as suggested by @jyknight there) shouldn't cause issues, I think.