Page MenuHomePhabricator

smeenai (Shoaib Meenai)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 19 2016, 10:21 AM (139 w, 15 h)

Recent Activity

Wed, Apr 17

smeenai requested changes to D60847: [CMake] Enable policy CMP0056.

Actually, this might not be needed? https://cmake.org/cmake/help/v3.4/manual/cmake-policies.7.html says

Wed, Apr 17, 6:37 PM · Restricted Project
smeenai added inline comments to D50407: Remove obsolete policy settings.
Wed, Apr 17, 6:37 PM · Restricted Project
Herald added a project to D50407: Remove obsolete policy settings: Restricted Project.
Wed, Apr 17, 6:37 PM · Restricted Project
smeenai accepted D60847: [CMake] Enable policy CMP0056.

Hmm, I'd done this as part of https://reviews.llvm.org/D39431, but then https://reviews.llvm.org/D50407 erroneously removed it.

Wed, Apr 17, 6:32 PM · Restricted Project

Mon, Apr 15

smeenai added a comment to D60470: [DWARF] Change ambiguity resolution from smallest CUOffset to largest (LowPC, CUOffset).

Have you run make check on this patch?

If you meant llvm-objdump -exports-trie. It was my problem and I apologize for the llvm-objdump test failure I caused. Or https://reviews.llvm.org/D60376 where I didn't notice BSD sed's escape character support for y command is different from GNU sed on Linux. ("The meaning of a <backslash> followed by any character that is not 'n', a <backslash>, or the delimiter character is undefined."). Thank you for telling that there is ninja check beside check-all check-llvm ..., but those discussions are unrelated to this revision.

Mon, Apr 15, 9:53 PM · Restricted Project
smeenai committed rG1826095a5faa: Reapply [Support] Fix recursive response file expansion guard (authored by smeenai).
Reapply [Support] Fix recursive response file expansion guard
Mon, Apr 15, 5:23 PM
smeenai committed rG0a61be96fc9f: Reapply [Support] Add a test for recursive response file expansion (authored by smeenai).
Reapply [Support] Add a test for recursive response file expansion
Mon, Apr 15, 5:23 PM
smeenai committed rL358466: Reapply [Support] Fix recursive response file expansion guard.
Reapply [Support] Fix recursive response file expansion guard
Mon, Apr 15, 5:23 PM
smeenai committed rL358465: Reapply [Support] Add a test for recursive response file expansion.
Reapply [Support] Add a test for recursive response file expansion
Mon, Apr 15, 5:23 PM
smeenai committed rG8eeb56d1333c: Revert [Support] Add a test for recursive response file expansion (authored by smeenai).
Revert [Support] Add a test for recursive response file expansion
Mon, Apr 15, 3:57 PM
smeenai committed rGd60ac111e671: Revert [Support] Fix recursive response file expansion guard (authored by smeenai).
Revert [Support] Fix recursive response file expansion guard
Mon, Apr 15, 3:57 PM
smeenai committed rL358460: Revert [Support] Fix recursive response file expansion guard.
Revert [Support] Fix recursive response file expansion guard
Mon, Apr 15, 3:50 PM
smeenai committed rL358461: Revert [Support] Add a test for recursive response file expansion.
Revert [Support] Add a test for recursive response file expansion
Mon, Apr 15, 3:50 PM
smeenai committed rGc8df4fb9c386: [Support] Fix recursive response file expansion guard (authored by smeenai).
[Support] Fix recursive response file expansion guard
Mon, Apr 15, 2:31 PM
smeenai committed rGc8497467edc5: [Support] Add a test for recursive response file expansion (authored by smeenai).
[Support] Add a test for recursive response file expansion
Mon, Apr 15, 2:31 PM
smeenai committed rL358452: [Support] Fix recursive response file expansion guard.
[Support] Fix recursive response file expansion guard
Mon, Apr 15, 2:31 PM
smeenai closed D60631: [Support] Fix recursive response file expansion guard.
Mon, Apr 15, 2:30 PM · Restricted Project
smeenai committed rL358451: [Support] Add a test for recursive response file expansion.
[Support] Add a test for recursive response file expansion
Mon, Apr 15, 2:30 PM
smeenai closed D60630: [Support] Add a test for recursive response file expansion.
Mon, Apr 15, 2:30 PM · Restricted Project
smeenai updated the diff for D60631: [Support] Fix recursive response file expansion guard.

Review comments

Mon, Apr 15, 2:30 PM · Restricted Project
smeenai added inline comments to D60631: [Support] Fix recursive response file expansion guard.
Mon, Apr 15, 2:30 PM · Restricted Project
smeenai updated the diff for D60630: [Support] Add a test for recursive response file expansion.

Review comments

Mon, Apr 15, 2:22 PM · Restricted Project
smeenai added inline comments to D60630: [Support] Add a test for recursive response file expansion.
Mon, Apr 15, 2:22 PM · Restricted Project
smeenai accepted D60711: Removed CMake cache upgrade code from 2011.

LGTM, thanks!

Mon, Apr 15, 10:11 AM · Restricted Project

Fri, Apr 12

smeenai added a parent revision for D60631: [Support] Fix recursive response file expansion guard: D60630: [Support] Add a test for recursive response file expansion.
Fri, Apr 12, 12:54 PM · Restricted Project
smeenai added a child revision for D60630: [Support] Add a test for recursive response file expansion: D60631: [Support] Fix recursive response file expansion guard.
Fri, Apr 12, 12:54 PM · Restricted Project
smeenai created D60631: [Support] Fix recursive response file expansion guard.
Fri, Apr 12, 12:54 PM · Restricted Project
smeenai created D60630: [Support] Add a test for recursive response file expansion.
Fri, Apr 12, 12:54 PM · Restricted Project

Thu, Apr 11

smeenai added a comment to D60577: [X86AsmPrinter] refactor static functions into private methods. NFC.

I have zero context on this change specifically, but "we should prefer functions in a private namespace" seems to be the exact opposite of the advice in https://llvm.org/docs/CodingStandards.html#static

While the commit comment references possibly moving things to a private namespace (which I agree is in contradiction to the referenced page), the actual code moves these to being private member functions. For functions that are taking *this, or propagating a *this in all usage, it seems fairly appropriate to me. Updating the commit message to not disagree with the official guidance would be helpful.

Thu, Apr 11, 3:14 PM · Restricted Project
smeenai added a comment to D60577: [X86AsmPrinter] refactor static functions into private methods. NFC.

I have zero context on this change specifically, but "we should prefer functions in a private namespace" seems to be the exact opposite of the advice in https://llvm.org/docs/CodingStandards.html#static

Thu, Apr 11, 2:36 PM · Restricted Project
smeenai added reviewers for D60495: Load balancing for LTO: pcc, tejohnson.
Thu, Apr 11, 2:27 PM · Restricted Project
smeenai accepted D60576: [cmake] Fix dependency issue in TableGen.

LGTM, thanks.

Thu, Apr 11, 2:08 PM · Restricted Project

Mon, Apr 8

smeenai committed rG867131a96cad: [BinaryFormat] Update Mach-O ARM64E CPU subtype and dumping (authored by smeenai).
[BinaryFormat] Update Mach-O ARM64E CPU subtype and dumping
Mon, Apr 8, 2:36 PM
smeenai committed rL357945: [BinaryFormat] Update Mach-O ARM64E CPU subtype and dumping.
[BinaryFormat] Update Mach-O ARM64E CPU subtype and dumping
Mon, Apr 8, 2:35 PM
smeenai closed D58636: [BinaryFormat] Update Mach-O ARM64E CPU subtype and dumping.
Mon, Apr 8, 2:35 PM · Restricted Project
smeenai added a comment to D58636: [BinaryFormat] Update Mach-O ARM64E CPU subtype and dumping.

Thank you!

Mon, Apr 8, 1:26 PM · Restricted Project

Fri, Apr 5

smeenai accepted D60276: [libc++] Localize CMake code only related to the shared library.

LGTM. Thanks for doing this!

Fri, Apr 5, 12:20 PM · Restricted Project
smeenai added a comment to D60309: [libcxx] Update gen_link_script.py to support different input and output.

While we're at it, do you know why the LIBCXX_ENABLE_ABI_LINKER_SCRIPT isn't allowed on Apple platforms? It doesn't seem to me like this is something you'd want to necessarily prevent on Apple platforms.

Fri, Apr 5, 12:18 PM

Thu, Apr 4

smeenai added inline comments to D60276: [libc++] Localize CMake code only related to the shared library.
Thu, Apr 4, 3:52 PM · Restricted Project
smeenai added inline comments to D60276: [libc++] Localize CMake code only related to the shared library.
Thu, Apr 4, 3:49 PM · Restricted Project
smeenai updated subscribers of D60276: [libc++] Localize CMake code only related to the shared library.
Thu, Apr 4, 12:13 PM · Restricted Project
smeenai edited reviewers for D60274: [ELF] Implement Dependent Libraries Feature, added: ruiu; removed: rui314.

(adding the correct Phabricator account for Rui)

Thu, Apr 4, 11:38 AM · Restricted Project
smeenai added a comment to D60276: [libc++] Localize CMake code only related to the shared library.

I really like the direction this is going.

Thu, Apr 4, 11:29 AM · Restricted Project

Wed, Apr 3

smeenai added inline comments to D59632: [llvm] [cmake] Add additional headers only if they exist.
Wed, Apr 3, 5:29 PM · Restricted Project
smeenai accepted D59632: [llvm] [cmake] Add additional headers only if they exist.

LGTM with the comment added.

Wed, Apr 3, 5:06 PM · Restricted Project
smeenai added inline comments to D59632: [llvm] [cmake] Add additional headers only if they exist.
Wed, Apr 3, 9:40 AM · Restricted Project

Tue, Apr 2

smeenai added inline comments to D60166: [libc++abi] Refactor CMake build to avoid object libraries.
Tue, Apr 2, 5:45 PM · Restricted Project
smeenai requested changes to D60166: [libc++abi] Refactor CMake build to avoid object libraries.
Tue, Apr 2, 5:42 PM · Restricted Project
smeenai added inline comments to D60166: [libc++abi] Refactor CMake build to avoid object libraries.
Tue, Apr 2, 5:42 PM · Restricted Project
smeenai accepted D60166: [libc++abi] Refactor CMake build to avoid object libraries.

LGTM

Tue, Apr 2, 5:18 PM · Restricted Project
smeenai added a comment to D60114: [CMake] Differentiate between static and shared libc++abi.

(to be clear I also think it's fine to unbreak this first and do the find_package change later, but the latter should hopefully end up being much nicer)

Tue, Apr 2, 11:40 AM · Restricted Project
smeenai added a comment to D60114: [CMake] Differentiate between static and shared libc++abi.

LGTM, though I agree with @ldionne, and I'll wait for him (or another libc++ maintainer) to accept.

Tue, Apr 2, 11:39 AM · Restricted Project
smeenai committed rG7c16c5b6aec5: [llvm-shlib] Fix cross-compilation for LLVM-C (authored by smeenai).
[llvm-shlib] Fix cross-compilation for LLVM-C
Tue, Apr 2, 9:01 AM
smeenai committed rGf92acf129950: [cmake] Add function for building native tool (authored by smeenai).
[cmake] Add function for building native tool
Tue, Apr 2, 9:01 AM
smeenai committed rL357486: [cmake] Add function for building native tool.
[cmake] Add function for building native tool
Tue, Apr 2, 9:01 AM
smeenai committed rL357487: [llvm-shlib] Fix cross-compilation for LLVM-C.
[llvm-shlib] Fix cross-compilation for LLVM-C
Tue, Apr 2, 9:01 AM
smeenai closed D60024: [cmake] Add function for building native tool.
Tue, Apr 2, 9:01 AM · Restricted Project
smeenai closed D60025: [llvm-shlib] Fix cross-compilation for LLVM-C.
Tue, Apr 2, 9:01 AM · Restricted Project

Mon, Apr 1

smeenai added a comment to D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM.

Any updates here?

Mon, Apr 1, 10:03 PM · Restricted Project
smeenai added inline comments to D59839: Open fstream files in O_CLOEXEC mode when possible..
Mon, Apr 1, 1:46 PM · Restricted Project
smeenai updated the diff for D60025: [llvm-shlib] Fix cross-compilation for LLVM-C.

Rebase

Mon, Apr 1, 11:32 AM · Restricted Project
smeenai updated the diff for D60024: [cmake] Add function for building native tool.

Address review comments

Mon, Apr 1, 11:28 AM · Restricted Project
smeenai added inline comments to D60024: [cmake] Add function for building native tool.
Mon, Apr 1, 11:07 AM · Restricted Project

Fri, Mar 29

smeenai added a child revision for D60024: [cmake] Add function for building native tool: D60025: [llvm-shlib] Fix cross-compilation for LLVM-C.
Fri, Mar 29, 7:37 PM · Restricted Project
smeenai added a parent revision for D60025: [llvm-shlib] Fix cross-compilation for LLVM-C: D60024: [cmake] Add function for building native tool.
Fri, Mar 29, 7:37 PM · Restricted Project
smeenai created D60025: [llvm-shlib] Fix cross-compilation for LLVM-C.
Fri, Mar 29, 7:36 PM · Restricted Project
smeenai updated the diff for D60024: [cmake] Add function for building native tool.

Standardize COMMENT

Fri, Mar 29, 7:30 PM · Restricted Project
smeenai added inline comments to D60024: [cmake] Add function for building native tool.
Fri, Mar 29, 7:18 PM · Restricted Project
smeenai created D60024: [cmake] Add function for building native tool.
Fri, Mar 29, 7:13 PM · Restricted Project
smeenai committed rGff852744c2cd: [cmake] Remove use of deprecated generator expression. NFC (authored by smeenai).
[cmake] Remove use of deprecated generator expression. NFC
Fri, Mar 29, 6:34 PM
smeenai committed rL357338: [cmake] Remove use of deprecated generator expression. NFC.
[cmake] Remove use of deprecated generator expression. NFC
Fri, Mar 29, 6:33 PM
smeenai requested changes to D60011: If MSVC and cross compiling use CMAKE_NM for gen_exports_msvc.

Sorry, I went down a rabbit hole reviewing this, and ended up writing an alternate solution which just generates a native llvm-nm using the same mechanism as tblgen. Gimme a little bit to put that up.

Fri, Mar 29, 3:58 PM · Restricted Project

Thu, Mar 28

smeenai committed rG155e26f0f43c: [CodeGen] Add additional mangling for struct members of non trivial structs (authored by smeenai).
[CodeGen] Add additional mangling for struct members of non trivial structs
Thu, Mar 28, 10:02 AM
smeenai committed rC357184: [CodeGen] Add additional mangling for struct members of non trivial structs.
[CodeGen] Add additional mangling for struct members of non trivial structs
Thu, Mar 28, 10:02 AM
smeenai committed rL357184: [CodeGen] Add additional mangling for struct members of non trivial structs.
[CodeGen] Add additional mangling for struct members of non trivial structs
Thu, Mar 28, 10:02 AM
smeenai closed D59873: Add additional mangling for struct members of non trivial structs.
Thu, Mar 28, 10:02 AM · Restricted Project, Restricted Project
smeenai added a comment to D59873: Add additional mangling for struct members of non trivial structs.

Looks good. I'll commit this.

Thu, Mar 28, 9:44 AM · Restricted Project, Restricted Project

Wed, Mar 27

smeenai added a comment to D59873: Add additional mangling for struct members of non trivial structs.

Also, it might be worth adding a third level of struct to the test, to show that it handles arbitrary nesting correctly (which it does).

Wed, Mar 27, 10:53 AM · Restricted Project, Restricted Project
smeenai added a comment to D59873: Add additional mangling for struct members of non trivial structs.

Do you need someone to commit this for you?

Wed, Mar 27, 10:15 AM · Restricted Project, Restricted Project

Tue, Mar 26

smeenai updated subscribers of D58636: [BinaryFormat] Update Mach-O ARM64E CPU subtype and dumping.

@ab, @mtrent – this is a small patch, and I can keep it locally if need be, especially if all the arm64e work will be upstreamed soon. With that said, I'd really appreciate any input on whether this is okay or not from the perspective of conflicting with Apple's planned arm64e upstreaming, and what the timeline on that upstreaming might look like. Also CC'ing @ributzka, since TAPI was my motivation for adding this.

Tue, Mar 26, 6:13 PM · Restricted Project
smeenai committed rG19c45546fc70: [cmake] Reset variable before using it (authored by smeenai).
[cmake] Reset variable before using it
Tue, Mar 26, 3:16 PM
smeenai committed rL357036: [cmake] Reset variable before using it.
[cmake] Reset variable before using it
Tue, Mar 26, 3:15 PM
smeenai committed rC357036: [cmake] Reset variable before using it.
[cmake] Reset variable before using it
Tue, Mar 26, 3:15 PM
smeenai added inline comments to D59572: Fix and speedup __libcpp_locale_guard on Windows.
Tue, Mar 26, 1:00 PM
smeenai added inline comments to D59572: Fix and speedup __libcpp_locale_guard on Windows.
Tue, Mar 26, 12:52 PM
smeenai added a comment to D59727: [libc++] Fix return value of snprintf_l() on Windows when buffer is too small.

FWIW, this will break mingw builds that use the old msvcrt.dll. Since a couple years, mingw-w64 also supports the UCRT, but this is not the default configuration upstream yet (while it is in my own builds).

Tue, Mar 26, 12:43 PM · Restricted Project

Mon, Mar 25

smeenai added a comment to D58636: [BinaryFormat] Update Mach-O ARM64E CPU subtype and dumping.

Ping @ab. Any objections to me landing this?

Mon, Mar 25, 5:59 PM · Restricted Project
smeenai added inline comments to D59797: [COFF] Reduce the size of Chunk and SectionChunk, NFC.
Mon, Mar 25, 5:27 PM · Restricted Project, Restricted Project
smeenai added a comment to D59755: gitignore: Ignore in-tree Swift builds.

I'd recommend keeping the projects out-of-tree and using LLVM_ENABLE_PROJECTS instead.

Mon, Mar 25, 11:46 AM · Restricted Project

Fri, Mar 22

smeenai added a comment to D59649: [ELF] Improve error message for relocations to symbols defined in discarded sections.

Thank you! This does even better than gold now :)

Fri, Mar 22, 2:08 PM · Restricted Project
smeenai added a reviewer for D59694: [PPC64][libunwind] Fix r2 not properly restored: compnerd.
Fri, Mar 22, 1:58 PM · Restricted Project

Thu, Mar 21

smeenai added a comment to D59649: [ELF] Improve error message for relocations to symbols defined in discarded sections.

Thank you!

If I'm understanding correctly, for the case where the relocation is not in the same object file as the discarded section, we'll still get the "undefined symbol" error message. I don't know if it would be possible to enhance that case to print the "relocation against discarded section" message as well. (gold does print that message in this case; it just doesn't print the additional information about the section group signature and prevailing definition.)

Symbol has the File field but not the section index (st_shndx). If the relocation is not in the same object as the discarded section, we can't get the defined section easily.

Thu, Mar 21, 5:21 PM · Restricted Project
smeenai added a comment to D59649: [ELF] Improve error message for relocations to symbols defined in discarded sections.

Thank you!

Thu, Mar 21, 11:25 AM · Restricted Project

Mar 19 2019

smeenai added a comment to D59525: Speed up certain locale functions on Windows.

In any case, I apologize for the confusion, @thomasanderson – this isn't on you :)

Mar 19 2019, 2:49 PM · Restricted Project
smeenai added a comment to D59525: Speed up certain locale functions on Windows.

@mclow.lists – this is a small localized change specific to libc++'s Windows support. The only libc++ specific thing here is the use of the _LIBCPP_MSVCRT conditionals, but they're consistent with the rest of this file (and with the general intent to support non-msvcrt runtimes on Windows). I've reviewed and contributed a bunch of libc++ Windows support, so I considered myself to be a qualified reviewer for this change, although for this particular change I think anyone sufficiently familiar with msvcrt would be able to review it.

Mar 19 2019, 2:49 PM · Restricted Project
smeenai added a comment to D59525: Speed up certain locale functions on Windows.

Unrelated, but out of curiosity: I believe libc++ is set up to require building against the Windows 10 SDK and the Universal CRT right now. For older Windows versions, does Chrome require the Universal CRT to be installed?

Mar 19 2019, 1:12 PM · Restricted Project
smeenai accepted D59525: Speed up certain locale functions on Windows.

LGTM, though you'll wanna update the commit message.

Mar 19 2019, 1:11 PM · Restricted Project
smeenai added a reviewer for D59525: Speed up certain locale functions on Windows: halyavin.
Mar 19 2019, 10:32 AM · Restricted Project
smeenai added a comment to D58636: [BinaryFormat] Update Mach-O ARM64E CPU subtype and dumping.

Ping @ab. Any objections to me landing this?

Mar 19 2019, 10:20 AM · Restricted Project

Mar 18 2019

smeenai added inline comments to D59525: Speed up certain locale functions on Windows.
Mar 18 2019, 10:42 PM · Restricted Project