Page MenuHomePhabricator

smeenai (Shoaib Meenai)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 19 2016, 10:21 AM (148 w, 4 d)

Recent Activity

Yesterday

smeenai added inline comments to D63735: [MachOObjectFile]Added Valid Architecture Function.
Mon, Jun 24, 3:38 PM · Restricted Project
smeenai added a comment to D63341: [llvm-lipo] Implement -thin.

Would be nice if "llvm-lipo -thin" printed a reasonable error message before dumping usage. Apple lipo will print "missing argument to -thin option"

Another difference is llvm-lipo will not validate the arch until all arguments are received, whereas Apple lipo will validate archs immediately. ("lipo -arch asdf")

Would be nice if "llvm-lipo" printed a list of valid archs when the arch is invalid. Currently it prints "llvm-lipo: error: Invalid architecture: asdf" and it exits. Apple lipo prints "unknown architecture specification flag: asdf in specifying thin operation: -thin asdf. known architecture flags are: ..."

PLEASE FIX: llvm-lipo does not support using "-o" in place of "-output"

Note: "llvm-lipo" does not work properly with certain Mach-O executables, such as those built with the -hideARM64 flag.

Fixed most of these issues, but for printing a list of knows architectures I am planning to make a change in a separate diff that returns a list of valid architectures, since I will no longer be modifying llvm-lipo code.

Mon, Jun 24, 3:37 PM · Restricted Project
smeenai added a comment to D63735: [MachOObjectFile]Added Valid Architecture Function.

I'll wait for a day in case any other reviewers have comments and then commit this for you.

Mon, Jun 24, 3:35 PM · Restricted Project
smeenai accepted D63735: [MachOObjectFile]Added Valid Architecture Function.

LGTM

Mon, Jun 24, 3:35 PM · Restricted Project
smeenai added a comment to D63735: [MachOObjectFile]Added Valid Architecture Function.

Looking good, just a few style nits.

Mon, Jun 24, 2:56 PM · Restricted Project

Fri, Jun 21

smeenai committed rG6442317219ff: [llvm-lipo] Implement -thin (authored by smeenai).
[llvm-lipo] Implement -thin
Fri, Jun 21, 3:00 PM
smeenai committed rL364107: [llvm-lipo] Implement -thin.
[llvm-lipo] Implement -thin
Fri, Jun 21, 3:00 PM
smeenai closed D63341: [llvm-lipo] Implement -thin.
Fri, Jun 21, 3:00 PM · Restricted Project
smeenai accepted D63341: [llvm-lipo] Implement -thin.

LGTM

Fri, Jun 21, 2:22 PM · Restricted Project

Tue, Jun 18

smeenai added a comment to D63453: [Support] Move llvm::MemoryBuffer to sys::fs::file_t.
In D63453#1548672, @rnk wrote:

Where do you want to keep these open? The default OS limit on open files for OSX is 256.

In COFF LLD.

Tue, Jun 18, 4:00 PM · Restricted Project

Fri, Jun 14

smeenai committed rG744870f46904: [compiler-rt] Respect CMAKE_NM (authored by smeenai).
[compiler-rt] Respect CMAKE_NM
Fri, Jun 14, 9:38 PM
smeenai committed rL363483: [compiler-rt] Respect CMAKE_NM.
[compiler-rt] Respect CMAKE_NM
Fri, Jun 14, 9:38 PM
smeenai closed D63368: [compiler-rt] Respect CMAKE_NM.
Fri, Jun 14, 9:38 PM · Restricted Project, Restricted Project
smeenai created D63368: [compiler-rt] Respect CMAKE_NM.
Fri, Jun 14, 4:01 PM · Restricted Project, Restricted Project

Wed, Jun 12

smeenai accepted D62982: build: extract LLVM distribution target handling.

Ah, so just having variables to hold the different distribution sets? Makes sense ... you'd need to adjust the CMake exporting logic, and I'm not quite sure how that'll play out yet, but we can see when we get to that.

Wed, Jun 12, 7:26 PM · Restricted Project
smeenai committed rG8f4973f57b0c: [llvm-lipo] Update llvm-lipo docs for -archs flag (authored by smeenai).
[llvm-lipo] Update llvm-lipo docs for -archs flag
Wed, Jun 12, 10:35 AM
smeenai committed rL363182: [llvm-lipo] Update llvm-lipo docs for -archs flag.
[llvm-lipo] Update llvm-lipo docs for -archs flag
Wed, Jun 12, 10:34 AM
smeenai closed D63100: [llvm-lipo] Update llvm-lipo docs for -archs flag.
Wed, Jun 12, 10:34 AM · Restricted Project
smeenai added a comment to D63100: [llvm-lipo] Update llvm-lipo docs for -archs flag.

I'll go ahead and commit this since all comments have been addressed.

Wed, Jun 12, 10:16 AM · Restricted Project

Mon, Jun 10

smeenai committed rG5062cf599ca2: [Support] Explicitly detect recursive response files (authored by smeenai).
[Support] Explicitly detect recursive response files
Mon, Jun 10, 4:21 PM
smeenai committed rL363005: [Support] Explicitly detect recursive response files.
[Support] Explicitly detect recursive response files
Mon, Jun 10, 4:21 PM
smeenai closed D62798: Explicitly detect recursive response files.
Mon, Jun 10, 4:21 PM · Restricted Project
smeenai added a comment to D62798: Explicitly detect recursive response files.

Sorry, I thought James was gonna commit this, but I'll go ahead and do so.

Mon, Jun 10, 4:15 PM · Restricted Project
smeenai added inline comments to D63014: [docs] Add "GNU binutils Replacements" section to command guide.
Mon, Jun 10, 10:14 AM · Restricted Project

Fri, Jun 7

smeenai committed rG20361de879dc: [llvm-lipo] Drop unneeded braces. NFC (authored by smeenai).
[llvm-lipo] Drop unneeded braces. NFC
Fri, Jun 7, 1:50 PM
smeenai committed rL362841: [llvm-lipo] Drop unneeded braces. NFC.
[llvm-lipo] Drop unneeded braces. NFC
Fri, Jun 7, 1:50 PM
smeenai committed rG61f7df54e3ba: [llvm-lipo] Implement -archs (authored by smeenai).
[llvm-lipo] Implement -archs
Fri, Jun 7, 1:50 PM
smeenai committed rL362840: [llvm-lipo] Implement -archs.
[llvm-lipo] Implement -archs
Fri, Jun 7, 1:45 PM
smeenai closed D62753: [llvm-lipo] Implement -archs.
Fri, Jun 7, 1:45 PM · Restricted Project

Thu, Jun 6

smeenai added a reviewer for D62982: build: extract LLVM distribution target handling: phosek.

This is technically a behavior change because with the old code, you wouldn't run any of the distribution code if LLVM_DISTRIBUTION_COMPONENTS was empty, even if LLVM_RUNTIME_DISTRIBUTION_COMPONENTS was non-empty. The new behavior seems more correct though.

Thu, Jun 6, 2:42 PM · Restricted Project
smeenai added a comment to D62982: build: extract LLVM distribution target handling.

This looks good, but what were you envisioning the interface would look like for configuring multiple distributions? It'd be a lot easier to judge with that context.

Thu, Jun 6, 2:40 PM · Restricted Project

Wed, Jun 5

smeenai added inline comments to D62798: Explicitly detect recursive response files.
Wed, Jun 5, 12:05 PM · Restricted Project

Tue, Jun 4

smeenai added a comment to D62837: [LLD][COFF] Don't take into account the 'age' when looking for PDB type server.

Phabricator memes are the best thing about Phabricator :)

Tue, Jun 4, 6:21 PM · Restricted Project, lld
smeenai added a comment to D62868: [libc++] Always build with -fvisibility=hidden.

<3

Tue, Jun 4, 3:02 PM · Restricted Project

Mon, Jun 3

smeenai added inline comments to D62798: Explicitly detect recursive response files.
Mon, Jun 3, 10:20 PM · Restricted Project

Fri, May 31

smeenai added inline comments to D62753: [llvm-lipo] Implement -archs.
Fri, May 31, 6:58 PM · Restricted Project
smeenai added inline comments to D62753: [llvm-lipo] Implement -archs.
Fri, May 31, 5:56 PM · Restricted Project
smeenai added inline comments to D62753: [llvm-lipo] Implement -archs.
Fri, May 31, 5:56 PM · Restricted Project
smeenai added inline comments to D62753: [llvm-lipo] Implement -archs.
Fri, May 31, 5:33 PM · Restricted Project
smeenai added inline comments to D62753: [llvm-lipo] Implement -archs.
Fri, May 31, 3:28 PM · Restricted Project

Thu, May 30

smeenai added a reviewer for D62706: [llvm-lipo] Add docs for llvm-lipo: anushabasana.

LGTM, but I'd wait for @mtrent.

Thu, May 30, 3:26 PM · Restricted Project
smeenai added a comment to D62694: Write new tests for r362121.

We're actively working on llvm-lipo (we have a bunch more diffs in the pipeline that'll be coming through over the summer). Is it worth adding either a TODO or filing a bug to change these tests once llvm-lipo is complete enough to support the required functionality?

Thu, May 30, 12:09 PM · Restricted Project
smeenai accepted D62640: [CMake] Use find_package(LLVM) instead of LLVMConfig.
Thu, May 30, 12:20 AM · Restricted Project, Restricted Project
smeenai added a comment to D62640: [CMake] Use find_package(LLVM) instead of LLVMConfig.

LGTM with the NO_CMAKE_FIND_ROOT_PATH added.

Thu, May 30, 12:20 AM · Restricted Project, Restricted Project

Wed, May 29

smeenai added inline comments to D62640: [CMake] Use find_package(LLVM) instead of LLVMConfig.
Wed, May 29, 11:41 PM · Restricted Project, Restricted Project

Tue, May 28

smeenai committed rCRT361866: [compiler-rt] Fix cmake warnings.
[compiler-rt] Fix cmake warnings
Tue, May 28, 12:11 PM
smeenai committed rG363079fe73eb: [compiler-rt] Fix cmake warnings (authored by smeenai).
[compiler-rt] Fix cmake warnings
Tue, May 28, 12:11 PM
smeenai committed rL361866: [compiler-rt] Fix cmake warnings.
[compiler-rt] Fix cmake warnings
Tue, May 28, 12:06 PM
smeenai closed D61203: [compiler-rt] Fix cmake warnings.
Tue, May 28, 12:06 PM · Restricted Project, Restricted Project

May 24 2019

smeenai added a comment to D61203: [compiler-rt] Fix cmake warnings.

@winksaville I can commit this for you on Monday if no one's gotten to it before.

May 24 2019, 5:12 PM · Restricted Project, Restricted Project
smeenai accepted D61203: [compiler-rt] Fix cmake warnings.

LGTM

May 24 2019, 1:41 PM · Restricted Project, Restricted Project

May 23 2019

smeenai committed rG87226a720293: [AsmPrinter] Treat a narrowing PtrToInt like Trunc (authored by smeenai).
[AsmPrinter] Treat a narrowing PtrToInt like Trunc
May 23 2019, 9:31 AM
smeenai committed rL361508: [AsmPrinter] Treat a narrowing PtrToInt like Trunc.
[AsmPrinter] Treat a narrowing PtrToInt like Trunc
May 23 2019, 9:26 AM
smeenai closed D61325: Treat a narrowing PtrToInt like Trunc when generating asm.
May 23 2019, 9:26 AM · Restricted Project
smeenai accepted D62289: CMake: allow using LLVM_EXTERNAL_PROJECTS with LLVM_ENABLE_PROJECTS.

LGTM

May 23 2019, 9:15 AM · Restricted Project

May 20 2019

smeenai added inline comments to D62111: Tweaks for setting CMAKE_LINKER to lld-link.
May 20 2019, 9:59 PM · Restricted Project
smeenai added a comment to D62171: build: Enable CMake Policy 0077.

(or if they're different, what the difference is and whether that's desirable)

May 20 2019, 9:05 PM · Restricted Project
smeenai added a comment to D62171: build: Enable CMake Policy 0077.

Could you perform a configure before and after this change and confirm that your CMakeCache.txt is the same? If so, this LGTM.

May 20 2019, 9:05 PM · Restricted Project
smeenai updated subscribers of D62063: CMake changes to get Windows self-host with PGO working.
In D62063#1509321, @rnk wrote:

Seems reasonable to me. I'm surprised CMake doesn't have a general facility for escaping paths used in cflags. I suppose users generally don't add paths, just flags.

May 20 2019, 5:35 PM · Restricted Project
smeenai added inline comments to D62155: [CMake] Copy C++ headers before configuring runtimes build.
May 20 2019, 5:23 PM · Restricted Project, Restricted Project
smeenai added a comment to D61974: [ObjC] Fix encoding of ObjC pointer types that are pointers to typedefs.

Delete the entire code path that tries to work around a bug in gcc.

May 20 2019, 11:21 AM · Restricted Project
smeenai added inline comments to D62155: [CMake] Copy C++ headers before configuring runtimes build.
May 20 2019, 11:15 AM · Restricted Project, Restricted Project

May 17 2019

smeenai added inline comments to D62040: [docs] Add new document on building distributions.
May 17 2019, 5:44 PM · Restricted Project
smeenai added inline comments to D62060: Make libc++'s libc++abi discovery work in the monorepo layout.
May 17 2019, 12:33 PM
smeenai added inline comments to D62060: Make libc++'s libc++abi discovery work in the monorepo layout.
May 17 2019, 12:17 PM

May 16 2019

smeenai added reviewers for D62034: compiler-rt/lib/builtins: s/#include <windows.h>/#include <Windows.h>/g to match proper case.: mstorsjo, rnk.

I believe MinGW lowercases all their headers, so that's the convention LLVM has been following, since cross-compilation using the Windows SDK generally involves some sort of case correction (through VFS overlays or CIOPFS or similar) anyway.

May 16 2019, 4:13 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
smeenai added a comment to D61203: [compiler-rt] Fix cmake warnings.

This is a straightforward build system fix, so it should be fine.

May 16 2019, 1:16 PM · Restricted Project, Restricted Project

May 14 2019

smeenai added a comment to D61927: [tools]Introduce llvm-lipo.

Looks good, though I'm not super familiar with the libObject APIs (yet) :)

May 14 2019, 11:25 PM · Restricted Project

May 10 2019

smeenai committed rGbbdc8593e1f4: [compiler-rt] Fix crtbegin.c compilation (authored by smeenai).
[compiler-rt] Fix crtbegin.c compilation
May 10 2019, 7:33 PM
smeenai committed rCRT360503: [compiler-rt] Fix crtbegin.c compilation.
[compiler-rt] Fix crtbegin.c compilation
May 10 2019, 7:32 PM
smeenai committed rL360503: [compiler-rt] Fix crtbegin.c compilation.
[compiler-rt] Fix crtbegin.c compilation
May 10 2019, 7:32 PM

May 8 2019

smeenai added a comment to D56205: Add -z common-page-size option.

D61688 implements -z common-page-size.

May 8 2019, 9:35 PM · Restricted Project

May 7 2019

smeenai committed rG45ab7d7dc64a: [compiler-rt] Create install targets for Darwin libraries (authored by smeenai).
[compiler-rt] Create install targets for Darwin libraries
May 7 2019, 11:59 AM
smeenai committed rCRT360181: [compiler-rt] Create install targets for Darwin libraries.
[compiler-rt] Create install targets for Darwin libraries
May 7 2019, 11:58 AM
smeenai committed rL360181: [compiler-rt] Create install targets for Darwin libraries.
[compiler-rt] Create install targets for Darwin libraries
May 7 2019, 11:58 AM
smeenai closed D61541: [compiler-rt] Create install targets for Darwin libraries.
May 7 2019, 11:58 AM · Restricted Project, Restricted Project
smeenai added inline comments to D61541: [compiler-rt] Create install targets for Darwin libraries.
May 7 2019, 11:58 AM · Restricted Project, Restricted Project
smeenai added a comment to D61541: [compiler-rt] Create install targets for Darwin libraries.

Will address any additional comments post-commit. Thanks for the quick review!

May 7 2019, 11:49 AM · Restricted Project, Restricted Project
smeenai accepted D61615: [COFF] Use COFF stubs for extern_weak functions.

LGTM, neat!

May 7 2019, 10:08 AM · Restricted Project, Restricted Project

May 6 2019

smeenai added inline comments to D61541: [compiler-rt] Create install targets for Darwin libraries.
May 6 2019, 3:59 PM · Restricted Project, Restricted Project
smeenai added inline comments to D49587: [CMake] Support exporting runtimes using the CMake export.
May 6 2019, 3:30 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

May 3 2019

smeenai created D61541: [compiler-rt] Create install targets for Darwin libraries.
May 3 2019, 3:15 PM · Restricted Project, Restricted Project

May 2 2019

smeenai accepted D61448: build: disable unwind tables whenever possible.

LGTM, given it doesn't have any effect by default. I'm not sure if there are negative consequences around e.g. stack walking for crashes, but having the option shouldn't hurt.

May 2 2019, 11:42 AM · Restricted Project
smeenai added a comment to D49587: [CMake] Support exporting runtimes using the CMake export.

Seems like you got the wrong diff.

May 2 2019, 11:16 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Apr 30 2019

smeenai added a comment to D61356: [compiler-rt] Rework the object build support.

This is really nasty, but I'm not sure if there's a better way to do this.

Apr 30 2019, 5:46 PM · Restricted Project, Restricted Project
smeenai added a comment to D61275: [libcxx] Move CMake file to src, avoid using globs.

Last time this came up, we wanted to implement a check to ensure no source files were forgotten, as in do a glob and compare to the explicit list of files.

Is it possible to forget a file, without it failing some lit test?
Are globs used elsewhere in llvm's cmake for this reason? I hope not. I don't remember it causing much issues.

The original plan was to use llvm_process_sources for that, but we couldn't do that cos libc++'s build can't rely on LLVM being around yet (though maybe we ought to reconsider that at some point with the upcoming monorepo move...).

Passing-by 2 cent: that seems like an unreasonably high price for an insufficiently motivating reason.

Do you think it's worth implementing that?

Apr 30 2019, 12:05 PM · Restricted Project
smeenai added a comment to D49587: [CMake] Support exporting runtimes using the CMake export.

Sorry, had missed this.

Apr 30 2019, 12:02 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
smeenai accepted D61220: lib/Header: Fix Visual Studio builds try #2.

LGTM

Apr 30 2019, 12:00 PM · Restricted Project, Restricted Project
smeenai added a comment to D61275: [libcxx] Move CMake file to src, avoid using globs.

Last time this came up, we wanted to implement a check to ensure no source files were forgotten, as in do a glob and compare to the explicit list of files. The original plan was to use llvm_process_sources for that, but we couldn't do that cos libc++'s build can't rely on LLVM being around yet (though maybe we ought to reconsider that at some point with the upcoming monorepo move...). Do you think it's worth implementing that?

Apr 30 2019, 11:56 AM · Restricted Project

Apr 29 2019

smeenai accepted D61188: [cmake] Fix error message in simulated VS version check.

LGTM with the indent fixed.

Apr 29 2019, 4:37 PM · Restricted Project

Apr 25 2019

smeenai accepted D60969: [libc++][CMake] Refactor how we link against system libraries.

This is awesome!

Apr 25 2019, 10:32 PM · Restricted Project, Restricted Project
smeenai added a comment to D61121: [Windows] Separate elements in -print-search-dirs with semicolons.

I feel something like llvm::sys::path::PathListSeparator would be nicer, since AFAIK any path list should be separated with semicolons on Windows and colons everywhere else.

Apr 25 2019, 10:33 AM · Restricted Project, Restricted Project
smeenai added a comment to D61123: [libc++] Set _LIBCPP_DLL_VIS on _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS in MinGW mode.

LGTM, though you'll wanna wait for a libc++ code owner too.

Apr 25 2019, 10:28 AM
smeenai added a comment to D61118: [MinGW] Fix dllexport of explicit template instantiation.

LGTM, though I'd wait for Hans and/or Reid too.

Apr 25 2019, 12:45 AM · Restricted Project, Restricted Project

Apr 24 2019

smeenai added a comment to D61100: [ObjC][ARC] Let ARC optimizer bail out if the number of pointer states it keeps track of becomes too large.

The test case I'm looking at has a function with over 500k instructions and lots of ObjC runtime function calls.

Apr 24 2019, 5:30 PM · Restricted Project
smeenai accepted D61100: [ObjC][ARC] Let ARC optimizer bail out if the number of pointer states it keeps track of becomes too large.
Apr 24 2019, 5:30 PM · Restricted Project
smeenai accepted D61054: lib/Header: Fix Visual Studio builds.

This would break if someone does a debug and release build simultaneously, the copies occur simultaneously and the filesystem gets unhappy, That seems fairly contrived though, and this is also restoring the behavior before your previous change.

Apr 24 2019, 9:56 AM · Restricted Project

Apr 23 2019

smeenai accepted D60879: [CMake] Use add_dependencies in add_llvm_install_targets.
Apr 23 2019, 11:20 AM · Restricted Project
smeenai added reviewers for D60879: [CMake] Use add_dependencies in add_llvm_install_targets: phosek, beanz.

LGTM, thanks!

Apr 23 2019, 11:18 AM · Restricted Project

Apr 22 2019

smeenai added a comment to D58537: lib/Header: Simplify CMakeLists.txt.

@tstellar ping. Someone appears to be running into this on the CMake mailing list too: https://cmake.org/pipermail/cmake/2019-April/069359.html

Apr 22 2019, 4:11 PM · Restricted Project, Restricted Project