Page MenuHomePhabricator

smeenai (Shoaib Meenai)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 19 2016, 10:21 AM (179 w, 6 h)

Recent Activity

Today

smeenai updated subscribers of D72831: [llvm-mc] - Produce R_X86_64_PLT32 relocation for branches with JCC opcodes too..

CC @hans ... there was discussion in https://bugs.llvm.org/show_bug.cgi?id=44397 about whether this is worth picking to 10.0.

Fri, Jan 24, 11:10 AM · Restricted Project

Yesterday

smeenai added a comment to D73253: [llvm] Fix file ignoring inside directories.

I think we should instead remove the entire "tracked independently" parts, because that's no longer the recommended directory layout. And also remove these "global" ignores which you moved, because they're already in /.gitignore, and thus don't need to be in /llvm/.gitignore

Thu, Jan 23, 2:21 PM · Restricted Project

Wed, Jan 22

smeenai added a comment to D72960: Include phabricator.uri in .arcconfig.

I'm assuming git-phab is https://pypi.org/project/git-phab/

Wed, Jan 22, 10:43 PM · Restricted Project
smeenai created D73253: [llvm] Fix file ignoring inside directories.
Wed, Jan 22, 10:43 PM · Restricted Project
smeenai created D73251: [runtimes] Fix installation for LLVM_RUNTIME_DISTRIBUTION_COMPONENTS.
Wed, Jan 22, 10:43 PM · Restricted Project
smeenai created D73252: [runtimes] Support install-*-stripped targets.
Wed, Jan 22, 10:43 PM · Restricted Project
smeenai updated the diff for D69195: [libcxx] Fix .gitignore to not exclude test directories.

Comments

Wed, Jan 22, 7:04 PM · Restricted Project
smeenai added a comment to D73236: [clang-tidy] Add clang-tidy headers to clang distribution.

This LGTM, but I'll give the clang-tidy developers some time to weigh in.

Wed, Jan 22, 5:50 PM · Restricted Project, Restricted Project
smeenai added a comment to D73236: [clang-tidy] Add clang-tidy headers to clang distribution.

Can you upload the patch with context (git diff -U9999 if you're using the web interface or via arcanist)?

Wed, Jan 22, 3:40 PM · Restricted Project, Restricted Project

Tue, Jan 21

smeenai added a comment to D72943: [ELF] Allow R_PLT_PC (R_PC) to a hidden undefined weak symbol.

rGb841e119d77ed0502e3a2e710f26a899bef28b3c is in the 10.0 branch. Should this be cherry picked to 10.0? CC @hans

This commit is in release/10.x

git branch origin/release/10.x --contains 9aacec8331d9bc1f80046e5954be1f5e0e0acd42 => success

Tue, Jan 21, 12:14 PM · Restricted Project
smeenai updated subscribers of D72943: [ELF] Allow R_PLT_PC (R_PC) to a hidden undefined weak symbol.

rGb841e119d77ed0502e3a2e710f26a899bef28b3c is in the 10.0 branch. Should this be cherry picked to 10.0? CC @hans

Tue, Jan 21, 11:55 AM · Restricted Project
smeenai added reviewers for D72980: Add test for spaceship operator to __config: EricWF, ldionne.
Tue, Jan 21, 9:48 AM · Restricted Project, Restricted Project
smeenai updated subscribers of D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation.

CC @plotfi for the InterfaceStubs failures

Tue, Jan 21, 9:38 AM · Restricted Project, Restricted Project

Fri, Jan 17

smeenai added a comment to D72952: [libunwind] Set LIBUNWIND_ASM_SOURCES to the ASM source language from C.

The diff here looks weird ... it looks like a diff against your previous diff instead of a diff against master? (Phabricator says the line you're deleting has LANGUAGE ASM instead of LANGUAGE C, as it does on master.)

Eek, sorry. We use CodeCollaborator internally, which would have effectively shown the diff from the original commit to the final (after 2 change sets), which would have shown the C in the before and nothing after. I mistakenly treated Phabricator the same way erroneously.

I'll re-upload this so it looks right. My apologies!

Fri, Jan 17, 3:58 PM · Restricted Project
smeenai accepted D72952: [libunwind] Set LIBUNWIND_ASM_SOURCES to the ASM source language from C.

The diff here looks weird ... it looks like a diff against your previous diff instead of a diff against master? (Phabricator says the line you're deleting has LANGUAGE ASM instead of LANGUAGE C, as it does on master.)

Fri, Jan 17, 3:39 PM · Restricted Project
smeenai committed rG97ba483026cd: [xray] Allow instrumenting only function entry and/or only function exit (authored by ianlevesque).
[xray] Allow instrumenting only function entry and/or only function exit
Fri, Jan 17, 1:36 PM
smeenai committed rG7628e474a591: [xray] Add xray-ignore-loops option (authored by ianlevesque).
[xray] Add xray-ignore-loops option
Fri, Jan 17, 1:36 PM
smeenai committed rG1d62be244108: [clang][xray] Add -fxray-ignore-loops option (authored by ianlevesque).
[clang][xray] Add -fxray-ignore-loops option
Fri, Jan 17, 1:36 PM
smeenai closed D72890: [xray] Allow instrumenting only function entry and/or only function exit.
Fri, Jan 17, 1:36 PM · Restricted Project, Restricted Project
smeenai closed D72873: [clang][xray] Add -fxray-ignore-loops option.
Fri, Jan 17, 1:36 PM · Restricted Project
smeenai closed D72659: [xray] Add xray-ignore-loops option.
Fri, Jan 17, 1:36 PM · Restricted Project
smeenai added a reviewer for D72952: [libunwind] Set LIBUNWIND_ASM_SOURCES to the ASM source language from C: compnerd.

Adding @compnerd, who's familiar with both libunwind and CMake :)

Fri, Jan 17, 1:36 PM · Restricted Project

Thu, Jan 16

smeenai committed rG8ef57f3e3f1b: [xray] add --no-demangle cli opt for llvm-xray extract to output mangled names (authored by johnislarry).
[xray] add --no-demangle cli opt for llvm-xray extract to output mangled names
Thu, Jan 16, 4:41 PM
smeenai closed D72804: [xray] add --symbolize-mangled cli opt for llvm-xray extract to output mangled names.
Thu, Jan 16, 4:40 PM · Restricted Project
smeenai added a comment to D72543: [libcxxabi] Insert padding in __cxa_exception struct for compatibility.

From spelunking through history, it looks like D33030 tried to solve the same problem, and then rL319123 undid that solution and came up with a different one to solve the same underlying issue. rL319123 is still in place; does it need to be adjusted for the change in this diff?

It looks like those patches were attempts to ensure adequate alignment of the exception object given the absence of an alignment attribute on the _Unwind_Exception type itself. rL319123 became inadequate after _Unwind_Exception became an aligned type because that change still affected the layout of the C++ exception types. What we're fixing here is essentially the same problem that was introduced by D33030.

Makes sense. Should rL319123 be reverted then? The extra space that's being allocated by that change doesn't do what it's meant to do, so it seems wasteful to keep allocating it.

If __cxa_exception is already sufficiently aligned, I believe that patch does not allocate any extra space.

Thu, Jan 16, 4:22 PM · Restricted Project
smeenai updated subscribers of D72543: [libcxxabi] Insert padding in __cxa_exception struct for compatibility.

From spelunking through history, it looks like D33030 tried to solve the same problem, and then rL319123 undid that solution and came up with a different one to solve the same underlying issue. rL319123 is still in place; does it need to be adjusted for the change in this diff?

It looks like those patches were attempts to ensure adequate alignment of the exception object given the absence of an alignment attribute on the _Unwind_Exception type itself. rL319123 became inadequate after _Unwind_Exception became an aligned type because that change still affected the layout of the C++ exception types. What we're fixing here is essentially the same problem that was introduced by D33030.

Thu, Jan 16, 3:53 PM · Restricted Project
smeenai added a reviewer for D72543: [libcxxabi] Insert padding in __cxa_exception struct for compatibility: ahatanak.

From spelunking through history, it looks like D33030 tried to solve the same problem, and then rL319123 undid that solution and came up with a different one to solve the same underlying issue. rL319123 is still in place; does it need to be adjusted for the change in this diff?

Thu, Jan 16, 2:15 PM · Restricted Project

Wed, Jan 15

smeenai added a comment to D72567: [ELF] Avoid false-positive assert in getErrPlace().

Should this be cherry-picked to the release branch?

Wed, Jan 15, 4:51 PM · Restricted Project

Tue, Jan 14

smeenai added a comment to D72194: [MC][ELF] Ensure that mergeable globals with an explicit section are assigned to SHF_MERGE sections with compatible entsizes.

Is this worth merging into 10.0 if it lands after the branch?

Tue, Jan 14, 6:19 PM · Restricted Project

Mon, Jan 13

smeenai added a comment to D71795: [ELF] Delete an unused special rule from isStaticLinkTimeConstant. NFC.

If any follow-ups get landed after the branch, can we make sure they get merged to the branch? Thanks!

Mon, Jan 13, 6:59 PM · Restricted Project
smeenai resigned from D72659: [xray] Add xray-ignore-loops option.

To make sure I'm understanding this correctly, previously, for any function with a loop in it, XRay would ignore the minimum instruction count threshold and instrument it unconditionally. You're adding an option to make XRay respect the threshold even if the function has loops. Is that correct?

Mon, Jan 13, 5:36 PM · Restricted Project

Thu, Jan 9

smeenai committed rG995c18fc5051: [xray] Remove cl::sub from alias options (authored by smeenai).
[xray] Remove cl::sub from alias options
Thu, Jan 9, 10:11 PM
smeenai closed D69386: [xray] Remove cl::sub from alias options.
Thu, Jan 9, 10:10 PM · Restricted Project
smeenai added a comment to D69386: [xray] Remove cl::sub from alias options.

Sorry for the delay. Committed this.

Thu, Jan 9, 10:10 PM · Restricted Project
smeenai committed rGe7d488c3dc6d: [arm64e] Make test work on non-Darwin hosts (authored by smeenai).
[arm64e] Make test work on non-Darwin hosts
Thu, Jan 9, 3:41 PM

Wed, Jan 8

smeenai added inline comments to D69770: [APFloat] Add recoverable string parsing errors to APFloat.
Wed, Jan 8, 2:42 PM · Restricted Project, Restricted Project

Mon, Jan 6

smeenai added a comment to D70764: build: reduce CMake handling for zlib.

this is now in master, and I am seeing build failures in cross-building clang, e.g. when building clang for arm on a x86_64 host. its resorting to finding, libz from buildhost instead of target sysroot ( using --sysroot) and failing in link step. e.g.

FAILED: bin/llvm-config
...
.... -o bin/llvm-config -Wl,-rpath,"\$ORIGIN/../lib" lib/libLLVMSupport.a /usr/lib/libz.so -lrt -ldl -ltinfo -lm lib/libLLVMDemangle.a
...

aarch64-yoe-linux-musl/aarch64-yoe-linux-musl-ld: /usr/lib/libz.so: error adding symbols: file in wrong format
clang-10: error: linker command failed with exit code 1 (use -v to see invocation)

you can see that its adding /usr/lib/libz.so to linker cmdline while cross linking.

Mon, Jan 6, 11:02 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
smeenai added a comment to D71951: [CMake] Pass symlink dependency to add_llvm_install_targets explicitly.

Sorry, was on vacation. Looks good, thanks!

Mon, Jan 6, 8:15 PM · Restricted Project

Dec 14 2019

smeenai committed rG2c59c4ffb9c1: [perf-training] Make training data location configurable (authored by smeenai).
[perf-training] Make training data location configurable
Dec 14 2019, 9:50 AM
smeenai closed D71507: [perf-training] Make training data location configurable.
Dec 14 2019, 9:50 AM · Restricted Project

Dec 13 2019

smeenai added a comment to D71507: [perf-training] Make training data location configurable.

I'm not sure where best to document this. We have https://llvm.org/docs/HowToBuildWithPGO.html, but that doesn't mention the build system's built-in PGO support as far as I can tell.

Dec 13 2019, 7:49 PM · Restricted Project
smeenai created D71507: [perf-training] Make training data location configurable.
Dec 13 2019, 7:42 PM · Restricted Project
smeenai accepted D71429: [llvm] Add llvm-lipo dependency to runtimes.

LGTM ... I'll wait a few more days in case anyone has comments.

Dec 13 2019, 7:33 PM · Restricted Project
smeenai committed rG61c8ee6a2fa4: [clang] Move CLANG_BOOTSTRAP_CMAKE_ARGS above PASSTHROUGH_VARIABLES (authored by xinxinw1).
[clang] Move CLANG_BOOTSTRAP_CMAKE_ARGS above PASSTHROUGH_VARIABLES
Dec 13 2019, 7:06 PM
smeenai closed D71428: [clang] Move CLANG_BOOTSTRAP_CMAKE_ARGS above PASSTHROUGH_VARIABLES.
Dec 13 2019, 7:06 PM · Restricted Project

Dec 12 2019

smeenai added a reviewer for D71429: [llvm] Add llvm-lipo dependency to runtimes: xiaobai.
Dec 12 2019, 2:43 PM · Restricted Project
smeenai added a reviewer for D71430: [llvm/runtimes] Add runtimes as a dependency of clang-bootstrap-deps: xiaobai.
Dec 12 2019, 2:43 PM · Restricted Project
smeenai added a reviewer for D71429: [llvm] Add llvm-lipo dependency to runtimes: plotfi.
Dec 12 2019, 2:35 PM · Restricted Project
smeenai added a reviewer for D71430: [llvm/runtimes] Add runtimes as a dependency of clang-bootstrap-deps: plotfi.
Dec 12 2019, 2:35 PM · Restricted Project
smeenai committed rG332bbcecb286: [DirectoryWatcher] Fix Windows stub after LLVM change (authored by smeenai).
[DirectoryWatcher] Fix Windows stub after LLVM change
Dec 12 2019, 2:28 PM
smeenai committed rGe626fb698244: [IndexStore] Update for DirectoryWatcher API change (authored by smeenai).
[IndexStore] Update for DirectoryWatcher API change
Dec 12 2019, 2:28 PM
smeenai added reviewers for D71429: [llvm] Add llvm-lipo dependency to runtimes: beanz, phosek, compnerd, smeenai, mtrent.

Makes sense to me ... it'd be ideal to limit this to runtimes being built for Darwin targets, but idk if that's possible, and I don't think it's that big of a deal to build llvm-lipo when it's not needed, since it's a pretty tiny dependency.

Dec 12 2019, 2:01 PM · Restricted Project
smeenai accepted D71428: [clang] Move CLANG_BOOTSTRAP_CMAKE_ARGS above PASSTHROUGH_VARIABLES.

LGTM

Dec 12 2019, 1:58 PM · Restricted Project
smeenai added reviewers for D71430: [llvm/runtimes] Add runtimes as a dependency of clang-bootstrap-deps: beanz, phosek, compnerd, smeenai.

This makes sense to me ... @beanz @phosek what do you think?

Dec 12 2019, 1:58 PM · Restricted Project
smeenai committed rG9c31fef1c431: [AST] Fix test for Swift clang (authored by smeenai).
[AST] Fix test for Swift clang
Dec 12 2019, 1:50 PM
smeenai committed rGab2295888308: [clang] Fix test/CodeGenObjC/class-stubs.m after LLVM r360359 (authored by smeenai).
[clang] Fix test/CodeGenObjC/class-stubs.m after LLVM r360359
Dec 12 2019, 1:41 PM

Dec 3 2019

smeenai accepted D70995: [llvm-strip][MachO] Test llvm-strip --strip-debug.

LGTM, thanks.

Dec 3 2019, 8:53 PM · Restricted Project
smeenai added inline comments to D70476: [llvm-objcopy][MachO] Implement --strip-debug.
Dec 3 2019, 7:13 PM · Restricted Project

Nov 28 2019

smeenai added inline comments to D70815: Enable `-funwind-tables` flag when building libunwind.
Nov 28 2019, 10:36 PM · Restricted Project

Nov 27 2019

smeenai added inline comments to D70658: [LLD][ELF] - Make compression level be dependent on -On..
Nov 27 2019, 9:13 AM · Restricted Project

Nov 26 2019

smeenai committed rG75fd939bb917: [ELF] Adjust test to work for zlib 1.2.8 (authored by smeenai).
[ELF] Adjust test to work for zlib 1.2.8
Nov 26 2019, 5:21 PM
smeenai added inline comments to D70658: [LLD][ELF] - Make compression level be dependent on -On..
Nov 26 2019, 5:20 PM · Restricted Project
smeenai added inline comments to D70658: [LLD][ELF] - Make compression level be dependent on -On..
Nov 26 2019, 4:28 PM · Restricted Project

Nov 25 2019

smeenai committed rGd018b556c755: [libcxx] Omit unneeded locale fallbacks on Android 21+ (authored by smeenai).
[libcxx] Omit unneeded locale fallbacks on Android 21+
Nov 25 2019, 11:13 AM
smeenai closed D69983: [libcxx] Omit unneeded locale fallbacks on Android 21+.
Nov 25 2019, 11:13 AM · Restricted Project
smeenai added a comment to D69983: [libcxx] Omit unneeded locale fallbacks on Android 21+.

Ping.

Nov 25 2019, 11:04 AM · Restricted Project

Nov 20 2019

smeenai accepted D70522: [llvm-lipo] Implement -extract.

LGTM

Nov 20 2019, 7:48 PM · Restricted Project

Nov 18 2019

smeenai added reviewers for D70378: [LLD][COFF] Fix missing cache cleanup in COFF::link(): ruiu, rnk.

It's recommended to uploaded patches with full context (e.g. by using git diff -U9999 when uploading a patch using the web interface).

Nov 18 2019, 6:53 PM · lld, Restricted Project
smeenai added a comment to D69983: [libcxx] Omit unneeded locale fallbacks on Android 21+.

Ping.

Nov 18 2019, 10:14 AM · Restricted Project

Nov 17 2019

smeenai added a comment to D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM.

Are there plans to move this forward?

Nov 17 2019, 10:25 PM · Restricted Project, Restricted Project

Nov 13 2019

smeenai added a comment to D69968: [COFF] Don't error if the only inputs are from /wholearchive:.

Somewhat related to the comments, I believe lld-link's ability to generate an import library from a def file directly is non-standard. MSVC's toolchain requires you to go through lib for that.

Nov 13 2019, 12:37 PM · Restricted Project

Nov 11 2019

smeenai added inline comments to D70027: ARM: Don't emit R_ARM_NONE relocations to compact unwinding decoders in .ARM.exidx on Android..
Nov 11 2019, 8:35 PM · Restricted Project
smeenai added inline comments to D70026: [cmake] Always build the libLLVM shared library.
Nov 11 2019, 8:07 PM · Restricted Project
smeenai accepted D69931: Add rpath to liblldb so vendors can ship their own python framework (or others).

LGTM

Nov 11 2019, 2:38 PM · Restricted Project
smeenai accepted D69973: [libcxxabi] Prevent cmake from removing our explicit system C++ include paths.

Accepting to unblock, though I'd like to see the LIBCXXABI_USE_SYSTEM_LIBCXX solution explored as a follow-up.

Nov 11 2019, 11:17 AM · Restricted Project
smeenai added inline comments to D69931: Add rpath to liblldb so vendors can ship their own python framework (or others).
Nov 11 2019, 10:31 AM · Restricted Project
smeenai added a reviewer for D69983: [libcxx] Omit unneeded locale fallbacks on Android 21+: ldionne.

Thanks. WIll wait for an approval from a libc++ code owner before committing.

Nov 11 2019, 9:17 AM · Restricted Project
smeenai added a comment to D69931: Add rpath to liblldb so vendors can ship their own python framework (or others).

Commit message needs to be updated.

Nov 11 2019, 9:17 AM · Restricted Project
smeenai accepted D70019: change LLVM_VERSION_SUFFIX default from svn to git.
Nov 11 2019, 9:17 AM · Restricted Project, Restricted Project

Nov 8 2019

smeenai added a reviewer for D69973: [libcxxabi] Prevent cmake from removing our explicit system C++ include paths: ldionne.

I don't think so no, its the dependency between libcxxabi and the libcxx that is the issue. I think libcxxabi assumes the libcxx is in non-default place when it builds. Perhaps out case that actually isn't true so another possible fix might be to add LIBCXXABI_USE_SYSTEM_LIBCXX which would avoid the need to -nostdinc (although maybe thats needed for other reasons too).

Nov 8 2019, 5:08 PM · Restricted Project
smeenai committed rG56cd447eec8e: [llvm-xray] Add basic test for AArch64 support (authored by smeenai).
[llvm-xray] Add basic test for AArch64 support
Nov 8 2019, 2:06 PM
smeenai added a comment to D69967: [llvm-xray] Add AArch64 to llvm-xray extract.

I converted the test to YAML and committed it as rG56cd447eec8e.

Nov 8 2019, 2:06 PM · Restricted Project
smeenai added a comment to D70011: lld patch for Linker Script UTF-8 BOM encoding capability .

This needs a test case, and it's a good idea to upload patches with more context (use -U99999 if generating a patch via git to upload to the web interface, or just use arcanist).

Nov 8 2019, 12:15 PM · Restricted Project, lld
smeenai added a comment to D69967: [llvm-xray] Add AArch64 to llvm-xray extract.

It seems like the commit dropped the tests. I'm planning to re-add them, and try converting the binary to YAML in the process.

Nov 8 2019, 12:06 PM · Restricted Project
smeenai added a comment to D68623: Optimize and fix basic_string move assignment operator.

@mvels, I'm assuming you don't have commit access to LLVM. The standard procedure there is that when your commit is accepted, you comment saying you don't have commit access and ask a reviewer to commit it for you. In this case, @mclow.lists should be able to commit it on your behalf.

Nov 8 2019, 11:57 AM · Restricted Project
smeenai added a comment to D69931: Add rpath to liblldb so vendors can ship their own python framework (or others).

It is a bit gross that Python does an @rpath install name, that is generally against convention. I can see adding an option to add rpaths to liblldb making sense. I certainly agree LLDB shouldn't be in the business of packaging transitive dependencies.

In a broader sense, Frameworks are dylibs. They can have all the same rpath magic that a dylib has. When you link a macho, the static linker pulls the install_name from each dylib you link against and embeds those as the dylibs to load. Since Python 3.7's install_name is @rpath based, it means that the dynamic linker will look for it in all the @rpath-relative locations specified by liblldb when linking. The proposed path in this patch, -rpath "@loader_path/../../../", uses the @loader_path expansion which is the directory containing the binary that the load command is in (in this case liblldb's directory). Popping 3 directories up from that is likely not sane in most build configurations, but if it works for you meh...

Nov 8 2019, 11:48 AM · Restricted Project
smeenai added a comment to D70019: change LLVM_VERSION_SUFFIX default from svn to git.

This LGTM, thanks! I'll give a couple of days for @hans and @tstellar to look at this in case they have any thoughts as the release managers.

Nov 8 2019, 11:21 AM · Restricted Project, Restricted Project
smeenai added a comment to D69983: [libcxx] Omit unneeded locale fallbacks on Android 21+.
In D69983#1738155, @enh wrote:

honestly, if it was me, i'd keep all these inlines even for current releases: inlining a call to the underlying function saves you a layer of useless cruft at runtime. (the Android "implementations" are just one-liners that drop the extra argument and call the underlying function, just like these inlines.)

if Android were the only system making use of this and you could otherwise remove it, that would be different, but since you need it for other configurations anyway...

Nov 8 2019, 9:49 AM · Restricted Project

Nov 7 2019

smeenai created D69983: [libcxx] Omit unneeded locale fallbacks on Android 21+.
Nov 7 2019, 8:06 PM · Restricted Project
smeenai added a comment to D69973: [libcxxabi] Prevent cmake from removing our explicit system C++ include paths.

You should report a bug to CMake (you're right that their implicit removal should account for the various -nostdinc-like options), but this seems like an okay workaround in the meantime.

Nov 7 2019, 7:04 PM · Restricted Project
smeenai added a comment to D69931: Add rpath to liblldb so vendors can ship their own python framework (or others).

I agree on not getting into the business of installing Python ourselves, but there's also the rpath issue. The Windows case is different because you just put all your DLLs in the same directory (or some other directory in your PATH) and you're done. With macOS, you have to specify an rpath for liblldb to be able to find the Python framework. It'd be really nice to support adding additional rpaths in the build system itself (it could be a more generic mechanism; it doesn't have to be Python-specific). CMake does offer CMAKE_INSTALL_RPATH, but that applies to every single target. You could also use install_name_tool after building to modify the rpath, but that feels like a kludge.

Nov 7 2019, 6:27 PM · Restricted Project

Oct 29 2019

smeenai added a comment to D69294: [LLD][ELF] Support --[no-]mmap-output-file with F_no_mmap.

I can commit this for you tomorrow if one of your reviewers hasn't gotten to it by then.

Oct 29 2019, 2:01 PM · lld, Restricted Project

Oct 25 2019

smeenai added a comment to D69294: [LLD][ELF] Support --[no-]mmap-output-file with F_no_mmap.

Will you need someone to commit this for you?

Oct 25 2019, 11:21 AM · lld, Restricted Project

Oct 24 2019

smeenai accepted D69419: [llvm-objcopy][MachO] Add support for min os version load commands.

LGTM ... seems like a trivial change that matches the existing handling of LC_VERSION_MIN_MACOSX (and adds test coverage as an added bonus).

Oct 24 2019, 6:54 PM · Restricted Project
smeenai added a reviewer for D69407: build: remove `LLVM_CXX_STD` extension point: jfb.

The change itself looks fine, but idk if we need to preserve support for any of the older variables (LLVM_ENABLE_CXX1Z in particular). Idk if there's an easy way to e.g. audit bot configurations to see what variables they're using ... maybe posting to llvm-dev would be a good idea?

Oct 24 2019, 3:14 PM · Restricted Project
smeenai accepted D69410: [compiler-rt] cmake: add include include(BuiltinTests).

LGTM

Oct 24 2019, 2:50 PM · Restricted Project, Restricted Project
smeenai added a comment to D69407: build: remove `LLVM_CXX_STD` extension point.

Why do you want LLVM_CXX_STD to be removed? I suppose somebody will eventually add LLVM_ENABLE_CXX2A, which will require additional logic to ensure that somebody doesn't set LLVM_ENABLE_CXX2A and LLVM_ENABLE_CXX1Z at the same time. I think this can be avoided by removing LLVM_ENABLE_CXX1Z entirely and going through LLVM_CXX_STD entirely.

Oct 24 2019, 2:50 PM · Restricted Project

Oct 23 2019

smeenai committed rGe3d26b42b95c: [Hexagon] Fix typo. NFC (authored by smeenai).
[Hexagon] Fix typo. NFC
Oct 23 2019, 6:07 PM
smeenai added a comment to D68952: Guard against possible overflow in span.subpan.

(I'm not sure how to withdraw my "Request Changes" without approving - I'm not an authorized approver for libc++ - so I'll "Resign as Reviewer" and see if my red X goes away.)

Oct 23 2019, 6:06 PM

Oct 21 2019

smeenai accepted D69239: [CMake] Allow overriding MSVC_DIA_SDK_DIR via CMake.

LGTM

Oct 21 2019, 1:45 PM · Restricted Project