Page MenuHomePhabricator

smeenai (Shoaib Meenai)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 19 2016, 10:21 AM (157 w, 5 h)

Recent Activity

Wed, Aug 7

smeenai added a comment to D65924: Revert "[cmake] Pass LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN to NATIVE configure".
In D65924#1620382, @jfb wrote:

I take it LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN will be going away entirely? If so, LGTM.

I intend to leave it there so it's easy to do the same dance for the next compiler bump. It won't be active for a bit, but we also won't have to re-agree on how to bump the version next time around :)

Wed, Aug 7, 10:41 PM · Restricted Project
smeenai accepted D65924: Revert "[cmake] Pass LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN to NATIVE configure".

I take it LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN will be going away entirely? If so, LGTM.

Wed, Aug 7, 10:34 PM · Restricted Project
smeenai added a comment to D65831: libc++: add `-include` or `/FI` to the interface compile definitions.

Hmm, yes, it is for use from the build tree. I don't see how INTERFACE_INCLUDE_DIRECTORIES can do a -include though. It has to be INTERFACE_COMPILE_OPTIONS or INTERFACE_COMPILE_DEFINITIONS.

Wed, Aug 7, 1:30 PM

Tue, Aug 6

smeenai requested changes to D65831: libc++: add `-include` or `/FI` to the interface compile definitions.

When libc++ is installed, the __config_site and __config are concatenated to make a single __config. I'm imagining this is specific to using libc++ from the build tree? If so, you should use INTERFACE_INCLUDE_DIRECTORIES and $<BUILD_INTERFACE:...> to limit it to builds.

Tue, Aug 6, 7:29 PM
smeenai added a parent revision for D65841: [Driver] Switch -stdlib++-isystem test to -###-verbatim: D65839: [Driver] Add verbatim dry run option.
Tue, Aug 6, 6:21 PM · Restricted Project
smeenai added a child revision for D65839: [Driver] Add verbatim dry run option: D65841: [Driver] Switch -stdlib++-isystem test to -###-verbatim.
Tue, Aug 6, 6:21 PM · Restricted Project
smeenai created D65841: [Driver] Switch -stdlib++-isystem test to -###-verbatim.
Tue, Aug 6, 6:20 PM · Restricted Project
smeenai updated the diff for D65839: [Driver] Add verbatim dry run option.

Output to stdout

Tue, Aug 6, 6:18 PM · Restricted Project
smeenai added a comment to D65839: [Driver] Add verbatim dry run option.

I'm not tied to the name -###-verbatim and am open to suggestions if anyone can think of something better.

Tue, Aug 6, 6:04 PM · Restricted Project
smeenai abandoned D64538: [Driver] Don't escape backslashes on Windows.

Abandoning in favor of D65839

Tue, Aug 6, 6:02 PM · Restricted Project
smeenai added a parent revision for D65839: [Driver] Add verbatim dry run option: D65838: [Driver] Use enumeration for quoting mode. NFC.
Tue, Aug 6, 6:02 PM · Restricted Project
smeenai added a child revision for D65838: [Driver] Use enumeration for quoting mode. NFC: D65839: [Driver] Add verbatim dry run option.
Tue, Aug 6, 6:02 PM · Restricted Project
smeenai created D65839: [Driver] Add verbatim dry run option.
Tue, Aug 6, 6:02 PM · Restricted Project
smeenai created D65838: [Driver] Use enumeration for quoting mode. NFC.
Tue, Aug 6, 5:45 PM · Restricted Project
smeenai accepted D65818: Add order-dependencies to object libraries.

LGTM

Tue, Aug 6, 10:58 AM · Restricted Project
smeenai committed rGfe08528c8e8a: [DirectoryWatcher] Fix asserts Mac builds (authored by smeenai).
[DirectoryWatcher] Fix asserts Mac builds
Tue, Aug 6, 12:16 AM
smeenai committed rL367984: [DirectoryWatcher] Fix asserts Mac builds.
[DirectoryWatcher] Fix asserts Mac builds
Tue, Aug 6, 12:14 AM

Mon, Aug 5

smeenai committed rGb50e8c592789: [Driver] Introduce -stdlib++-isystem (authored by smeenai).
[Driver] Introduce -stdlib++-isystem
Mon, Aug 5, 11:50 PM
smeenai committed rL367982: [Driver] Introduce -stdlib++-isystem.
[Driver] Introduce -stdlib++-isystem
Mon, Aug 5, 11:49 PM
smeenai closed D64089: [Driver] Introduce -stdlib++-isystem.
Mon, Aug 5, 11:49 PM · Restricted Project, Restricted Project
smeenai added a reviewer for D64089: [Driver] Introduce -stdlib++-isystem: rnk.

Adding @rnk as someone familiar with the driver/frontend :)

Mon, Aug 5, 7:38 PM · Restricted Project, Restricted Project

Tue, Jul 30

smeenai accepted D65477: [build] add the ability to create a symlink for lipo.

LGTM

Tue, Jul 30, 2:08 PM · Restricted Project

Fri, Jul 26

smeenai accepted D65342: add 'a' to chmod in llvm-lipo executability tests.

LGTM, thanks!

Fri, Jul 26, 11:41 AM · Restricted Project

Wed, Jul 24

smeenai committed rG5aee1c6b102f: [llvm-lipo] Implement alignment function in -create (authored by smeenai).
[llvm-lipo] Implement alignment function in -create
Wed, Jul 24, 5:31 PM
smeenai committed rGa67f6f17467f: [Object] Add public MaxSectionAlignment to MachOUniversal (authored by smeenai).
[Object] Add public MaxSectionAlignment to MachOUniversal
Wed, Jul 24, 5:30 PM
smeenai committed rG7418b10b1652: [llvm-lipo] Add test for -verify_archs (authored by smeenai).
[llvm-lipo] Add test for -verify_archs
Wed, Jul 24, 5:30 PM
smeenai committed rL366970: [llvm-lipo] Implement alignment function in -create.
[llvm-lipo] Implement alignment function in -create
Wed, Jul 24, 5:30 PM
smeenai closed D64871: [llvm-lipo] Implement alignment function in -create.
Wed, Jul 24, 5:30 PM · Restricted Project
smeenai committed rL366969: [Object] Add public MaxSectionAlignment to MachOUniversal.
[Object] Add public MaxSectionAlignment to MachOUniversal
Wed, Jul 24, 5:30 PM
smeenai closed D65117: [llvm-Object] Added public MaxSectionAlignment to MachOUniversal.
Wed, Jul 24, 5:29 PM · Restricted Project
smeenai committed rL366968: [llvm-lipo] Add test for -verify_archs.
[llvm-lipo] Add test for -verify_archs
Wed, Jul 24, 5:29 PM
smeenai closed D65251: [llvm-lipo] Add test for -verify_archs.
Wed, Jul 24, 5:29 PM · Restricted Project
smeenai added inline comments to D64089: [Driver] Introduce -stdlib++-isystem.
Wed, Jul 24, 5:19 PM · Restricted Project, Restricted Project
smeenai accepted D65251: [llvm-lipo] Add test for -verify_archs.

LGTM

Wed, Jul 24, 5:12 PM · Restricted Project

Jul 23 2019

smeenai updated subscribers of rL366765: [Statepoints] Fix a bug in statepoint lowering for functions w/no-realign-stack.
Jul 23 2019, 9:56 AM
smeenai added a reviewer for D65149: [Format] Add test demonstrating PR42722: MyDeveloperDay.
Jul 23 2019, 8:16 AM · Restricted Project

Jul 22 2019

smeenai added inline comments to rL366765: [Statepoints] Fix a bug in statepoint lowering for functions w/no-realign-stack.
Jul 22 2019, 10:32 PM
smeenai added inline comments to rL366765: [Statepoints] Fix a bug in statepoint lowering for functions w/no-realign-stack.
Jul 22 2019, 10:32 PM
smeenai committed rG99ccc3c9f144: [llvm-lipo] Implement -info (authored by smeenai).
[llvm-lipo] Implement -info
Jul 22 2019, 5:46 PM
smeenai committed rL366772: [llvm-lipo] Implement -info.
[llvm-lipo] Implement -info
Jul 22 2019, 5:42 PM
smeenai closed D64668: [llvm-lipo] Implement -info.
Jul 22 2019, 5:41 PM · Restricted Project

Jul 19 2019

smeenai added a comment to D61479: Finish "Adapt -fsanitize=function to SANITIZER_NON_UNIQUE_TYPEINFO".

eh, the summary here doesn't get updated from the actual git commit message :(

thanks for the reviews!

Jul 19 2019, 2:38 PM · Restricted Project, Restricted Project, Restricted Project
smeenai committed rGb50f10875b3d: [llvm-lipo] Remove trailing whitespace. NFC (authored by smeenai).
[llvm-lipo] Remove trailing whitespace. NFC
Jul 19 2019, 10:24 AM
smeenai committed rL366595: [llvm-lipo] Remove trailing whitespace. NFC.
[llvm-lipo] Remove trailing whitespace. NFC
Jul 19 2019, 10:20 AM

Jul 18 2019

smeenai committed rG16a9632558e7: Reapply [llvm-lipo] Implement -create (with hardcoded alignments) (authored by smeenai).
Reapply [llvm-lipo] Implement -create (with hardcoded alignments)
Jul 18 2019, 3:49 PM
smeenai committed rL366512: Reapply [llvm-lipo] Implement -create (with hardcoded alignments).
Reapply [llvm-lipo] Implement -create (with hardcoded alignments)
Jul 18 2019, 3:48 PM
smeenai accepted D64837: [cmake] Convert the NATIVE llvm build process to be project agnostic.

LGTM

Jul 18 2019, 3:20 PM · Restricted Project
smeenai accepted D64873: Remove the static initialize introduced in r365099.

Sorry, I missed this. Thanks, LGTM.

Jul 18 2019, 1:22 PM · Restricted Project

Jul 17 2019

smeenai accepted D64846: [cmake] Add NATIVE build for cross compiling standalone builds.

LGTM

Jul 17 2019, 4:42 PM
smeenai added a comment to D64846: [cmake] Add NATIVE build for cross compiling standalone builds.

You can use CROSS_TOOLCHAIN_FLAGS_<PROJECT_NAME> (in this case CROSS_TOOLCHAIN_FLAGS_LLDB) to pass additional variables to the cross-compiling configure. That seems more appropriate for setting these options instead of hardcoding them in LLDB's CMake.

I think LLDB_PATH_TO_NATIVE_CLANG_BUILD along with the error that would occur makes it much clearer to the user what's happening. CROSS_TOOLCHAIN_FLAGS is a hell of a lot more ambiguous as to it's purpose than the former. If you've never heard of the NATIVE build then this would point it out to you relatively easily.

Jul 17 2019, 3:40 PM
smeenai added a comment to D64837: [cmake] Convert the NATIVE llvm build process to be project agnostic.

This just seems like it's replacing all instances of LLVM with ${CMAKE_PROJECT_NAME}?

I think it'd be cleaner and more explicit to pass an additional project name parameter to llvm_create_cross_target instead of implicitly using ${CMAKE_PROJECT_NAME}. There's some prior art for that, e.g. in https://reviews.llvm.org/diffusion/L/browse/llvm/trunk/cmake/modules/AddLLVM.cmake;366290$1009?as=source&blame=off

That's what I did originally. However, the users of build_natve_tool wouldn't have the proper context to know what to use. It's only non-llvm specific usage is within add_tablegen which would then have to learn how to decide what project_name variable to pass in. e.g. if lldb is part of ENABLE_PROJECTS then add_tablegen should call llvm_native_build(LLVM NATIVE ...) else llvm_native_build(LLDB NATIVE ...). So we'd have to propagate that to all users of add_tablegen where we'd have to figure out whether the build is standalone or not via checking CMAKE_PROJECT_NAME anyways. e.g.

 if (${CMAKE_PROJECT_NAME} MATCHES lldb)
    add_tablegen(lldb lldb lldb-tblgen)
else()
    add_tablegen(llvm lldb lldb-tblgen)
endif()

I'm not convinced that adding the granularity to choose your llvm_create_cross_target project is worth propagating the configuration outwards given that there are no users that don't satisfy CMAKE_PROJECT_NAME == project_name.

An alternative would be to have some global variable llvm_cross_targets list that build_native_tool iterates over. But this is making an already clumsy solution more clumsy.

Jul 17 2019, 3:39 PM · Restricted Project

Jul 16 2019

smeenai added a comment to D64846: [cmake] Add NATIVE build for cross compiling standalone builds.

Having Swift-specific options in here is a non-starter, since Swift support isn't in mainline LLDB yet.

You can use CROSS_TOOLCHAIN_FLAGS_<PROJECT_NAME> (in this case CROSS_TOOLCHAIN_FLAGS_LLDB) to pass additional variables to the cross-compiling configure. That seems more appropriate for setting these options instead of hardcoding them in LLDB's CMake.

Jul 16 2019, 10:28 PM
smeenai added inline comments to D64837: [cmake] Convert the NATIVE llvm build process to be project agnostic.
Jul 16 2019, 10:26 PM · Restricted Project
smeenai added a comment to D64837: [cmake] Convert the NATIVE llvm build process to be project agnostic.

This just seems like it's replacing all instances of LLVM with ${CMAKE_PROJECT_NAME}?

Jul 16 2019, 10:25 PM · Restricted Project
smeenai requested changes to D64846: [cmake] Add NATIVE build for cross compiling standalone builds.

Having Swift-specific options in here is a non-starter, since Swift support isn't in mainline LLDB yet.

Jul 16 2019, 10:21 PM
smeenai added inline comments to D64837: [cmake] Convert the NATIVE llvm build process to be project agnostic.
Jul 16 2019, 4:04 PM · Restricted Project
smeenai added a comment to D63735: [MachOObjectFile]Added Valid Architecture Function.

This adds an unnecessary static initializer to the MachOObject.cpp. Can you move the array of validArchs into filescope? You can declare it in getValidArchs() and use getValidArchs() in isValidArchs.

Jul 16 2019, 11:24 AM · Restricted Project

Jul 15 2019

smeenai added a comment to D64089: [Driver] Introduce -stdlib++-isystem.

Ping.

Jul 15 2019, 7:27 PM · Restricted Project, Restricted Project
smeenai committed rGc9e3c8301446: Revert [llvm-lipo] Implement -create (with hardcoded alignments) (authored by smeenai).
Revert [llvm-lipo] Implement -create (with hardcoded alignments)
Jul 15 2019, 3:45 PM
smeenai committed rL366144: Revert [llvm-lipo] Implement -create (with hardcoded alignments).
Revert [llvm-lipo] Implement -create (with hardcoded alignments)
Jul 15 2019, 3:45 PM
smeenai committed rG67cee1dc7ee2: [llvm-lipo] Implement -create (with hardcoded alignments) (authored by smeenai).
[llvm-lipo] Implement -create (with hardcoded alignments)
Jul 15 2019, 3:30 PM
smeenai committed rL366142: [llvm-lipo] Implement -create (with hardcoded alignments).
[llvm-lipo] Implement -create (with hardcoded alignments)
Jul 15 2019, 3:30 PM
smeenai closed D64102: [llvm-lipo] Implement -create part 1.
Jul 15 2019, 3:30 PM · Restricted Project
smeenai added a comment to D64461: [lld-link] implement -thinlto-index-only.

Distributed ThinLTO doesn't support archives: http://lists.llvm.org/pipermail/llvm-dev/2019-June/133145.html. @tejohnson suggested -start-lib -end-lib as a workaround, but that's not a thing for COFF. Do you have plans for archive support, or is that not something you need to deal with for your use cases?

Jul 15 2019, 3:01 PM · Restricted Project
smeenai added inline comments to D64668: [llvm-lipo] Implement -info.
Jul 15 2019, 11:47 AM · Restricted Project

Jul 12 2019

smeenai committed rGaaa490346ce7: Revert [clang-shlib] Fix clang-shlib for PRIVATE dependencies (authored by smeenai).
Revert [clang-shlib] Fix clang-shlib for PRIVATE dependencies
Jul 12 2019, 10:25 AM
smeenai committed rL365922: Revert [clang-shlib] Fix clang-shlib for PRIVATE dependencies.
Revert [clang-shlib] Fix clang-shlib for PRIVATE dependencies
Jul 12 2019, 10:23 AM

Jul 11 2019

smeenai accepted D64547: [Driver] -noprofilelib flag.

LGTM

Jul 11 2019, 2:48 PM · Restricted Project, Restricted Project
smeenai committed rG3173c60f96c3: [clang-shlib] Fix clang-shlib for PRIVATE dependencies (authored by smeenai).
[clang-shlib] Fix clang-shlib for PRIVATE dependencies
Jul 11 2019, 2:23 PM
smeenai committed rL365825: [clang-shlib] Fix clang-shlib for PRIVATE dependencies.
[clang-shlib] Fix clang-shlib for PRIVATE dependencies
Jul 11 2019, 2:23 PM
smeenai closed D64579: [clang-shlib] Fix clang-shlib for PRIVATE dependencies.
Jul 11 2019, 2:23 PM · Restricted Project, Restricted Project
smeenai added a comment to D64579: [clang-shlib] Fix clang-shlib for PRIVATE dependencies.

Yea, this makes sense even if it is a bit sad. We do use the --whole-archive approach for libLLVM, and it works. I was hoping to avoid it here in part to free up the ability to link libclang_shared before or in parallel to archiving the libclang*.a archives.

Jul 11 2019, 2:23 PM · Restricted Project, Restricted Project
smeenai accepted D64582: cmake: Fix install of libclang_shared.so when LLVM_INSTALL_TOOLCHAIN_ONLY=ON.

LGTM

Jul 11 2019, 2:12 PM · Restricted Project, Restricted Project
smeenai added a comment to D64580: cmake: Add INSTALL_WITH_TOOLCHAIN option to add_*_library macros.

Nice.

Jul 11 2019, 2:12 PM · Restricted Project, Restricted Project
smeenai added a comment to D64579: [clang-shlib] Fix clang-shlib for PRIVATE dependencies.

While upgrading to newer CMake would be nice, I think it's unlikely that we could move all the way to 3.12 since that version was only released a year ago and still isn't available in most distributions, so this LGTM. Maybe leave a TODO that this should be revisited after we bump minimum CMake requirement to 3.12 or newer?

FWIW, CMake 3.4.3 was released Jan 25 2016 (https://cmake.org/pipermail/cmake/2016-January/062616.html) and we started requiring it on May 31 2016 (https://reviews.llvm.org/D20822), so we do have precedence for requiring a pretty recent CMake version. I guess we should figure out what other compelling reasons we'd have for moving to that version though.

Jul 11 2019, 12:18 PM · Restricted Project, Restricted Project
smeenai added a comment to D64579: [clang-shlib] Fix clang-shlib for PRIVATE dependencies.

While upgrading to newer CMake would be nice, I think it's unlikely that we could move all the way to 3.12 since that version was only released a year ago and still isn't available in most distributions, so this LGTM. Maybe leave a TODO that this should be revisited after we bump minimum CMake requirement to 3.12 or newer?

Jul 11 2019, 12:15 PM · Restricted Project, Restricted Project
smeenai added a comment to D64579: [clang-shlib] Fix clang-shlib for PRIVATE dependencies.

@beanz, what do you think of this? I think it's kinda awful, but I can't think of a better alternative short of upgrading to CMake 3.12 (as detailed in my comment).

Jul 11 2019, 12:03 PM · Restricted Project, Restricted Project
smeenai created D64579: [clang-shlib] Fix clang-shlib for PRIVATE dependencies.
Jul 11 2019, 12:02 PM · Restricted Project, Restricted Project

Jul 10 2019

smeenai added a comment to D64538: [Driver] Don't escape backslashes on Windows.
In D64538#1579610, @rnk wrote:
In D64538#1579561, @rnk wrote:

An extremely convenient feature of the current escaping pattern is that it magically works for both the cmd shell and various bash implementations. You can simply copy paste the commands and run them. This matters, for example, for the .sh crash reproducer script. On Windows today, you can just run it with bash, and it works. So, I'd prefer it if we didn't do this.

If you want -### output to be more FileCheck friendly, then I would recommend adding a new driver flag for testing that dumps the commands without doing any escaping. This came up before:
https://reviews.llvm.org/D62493

As long as the backslashes aren't followed by a few special characters (as detailed in my comment), the backslash should still continue to work. I've been testing this with git bash and I'm still able to copy-paste the ouptut command.

For the use case of crash reproduction, we often get these .sh files from users, and then try to reproduce and reduce the crash on Linux. Right now it's just a matter of adjusting the clang binary being run to reproduce a crash, but with this change, it will be harder. The current escaping is kind of the universal currency, a quoting style that is accepted everywhere.

Jul 10 2019, 4:12 PM · Restricted Project
smeenai added a comment to D64538: [Driver] Don't escape backslashes on Windows.
In D64538#1579561, @rnk wrote:

An extremely convenient feature of the current escaping pattern is that it magically works for both the cmd shell and various bash implementations. You can simply copy paste the commands and run them. This matters, for example, for the .sh crash reproducer script. On Windows today, you can just run it with bash, and it works. So, I'd prefer it if we didn't do this.

If you want -### output to be more FileCheck friendly, then I would recommend adding a new driver flag for testing that dumps the commands without doing any escaping. This came up before:
https://reviews.llvm.org/D62493

Jul 10 2019, 3:42 PM · Restricted Project
smeenai updated subscribers of D64538: [Driver] Don't escape backslashes on Windows.

CC @phosek, since I believe you had issues writing tests referencing the installation directory in the past.

Jul 10 2019, 3:33 PM · Restricted Project
smeenai accepted D64532: [CMake] Support separate installation of InstrProfData.inc.

LGTM with the comment; the use case makes sense to me.

Jul 10 2019, 3:33 PM · Restricted Project
smeenai added inline comments to D64532: [CMake] Support separate installation of InstrProfData.inc.
Jul 10 2019, 3:28 PM · Restricted Project
smeenai added a comment to D64538: [Driver] Don't escape backslashes on Windows.

Hmm, this only fixes -###. Looking into -v now.

Jul 10 2019, 3:25 PM · Restricted Project
smeenai added a comment to D64538: [Driver] Don't escape backslashes on Windows.

Hmm, this only fixes -###. Looking into -v now.

Jul 10 2019, 3:24 PM · Restricted Project
smeenai created D64538: [Driver] Don't escape backslashes on Windows.
Jul 10 2019, 3:21 PM · Restricted Project

Jul 9 2019

smeenai added a comment to D64191: [libcxxabi] Don't process exceptions in cxa_handlers when they're disabled.

FYIe, you can also prevent this symbol to be linked in by putting a cxa_demangle function in an obj file that gets linked first, like so: https://cs.chromium.org/chromium/src/third_party/android_crazy_linker/src/src/crazy_linker_wrappers.cpp?type=cs&q=cxa_demangle+file:android&sq=package:chromium&g=0&l=54 – but I agree that since cxa_demangle is so large, it'd be nice if the upstream version was behind some kind of define. Then we could set that and remove that hack in chromium too. I don't have an opinion on if that should be a new define or if _LIBCXXABI_NO_EXCEPTIONS should be reused. Actually, I think we build libcxxabi with exceptions enabled because some of our test code can in theory throw exceptions, but we have an external dumper so we don't need the stack from terminate() – so it'd be somewhat more convenient for us if we could turn off the stack from terminate() (and the pulling in of __cxa_demangle) while still being able to build without setting _LIBCXXABI_NO_EXCEPTIONS.

Jul 9 2019, 11:12 PM · Restricted Project
smeenai updated subscribers of D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.

Thanks for the revert.

There's actually one more problem - seems like ninja doesn't like the generated build.ninja file on Linux.

ninja: error: build.ninja:52390: bad $-escape (literal $ must be written as $$)

http://lab.llvm.org:8011/builders/clang-with-lto-ubuntu/builds/13617/steps/build-stage1-compiler/logs/stdio

Jul 9 2019, 10:59 PM · Restricted Project, Restricted Project
smeenai added a comment to D64089: [Driver] Introduce -stdlib++-isystem.

Background question: I'm familiar with the behavior on Darwin, where we prefer C++ headers in the toolchain (alongside the driver), however do other platforms behave the same? I thought this was something specific to Darwin.

Jul 9 2019, 1:11 PM · Restricted Project, Restricted Project
smeenai added a comment to D63883: [libc++] Do not cleverly link against libc++abi just because it happens to be there.

I think it's worth advertising the required configuration change (to explicitly say -DLIBCXX_CXX_ABI=libcxxabi) in the documentation and/or the release notes, otherwise the behavior change will be surprising.

Jul 9 2019, 1:07 PM · Restricted Project, Restricted Project
smeenai accepted D64225: [cmake] Don't set install rules for tblgen if building utils is disabled.

LGTM

Jul 9 2019, 1:02 PM · Restricted Project
smeenai added a comment to D64089: [Driver] Introduce -stdlib++-isystem.

Ping.

Jul 9 2019, 12:25 PM · Restricted Project, Restricted Project
smeenai added inline comments to D64383: build: use multiple `install` rather than building up a list.
Jul 9 2019, 12:22 PM
smeenai accepted D64383: build: use multiple `install` rather than building up a list.

Nice!

Jul 9 2019, 12:21 PM

Jul 3 2019

smeenai committed rG995798d2d584: [MachO] Add valid architecture function (authored by smeenai).
[MachO] Add valid architecture function
Jul 3 2019, 5:20 PM
smeenai committed rL365099: [MachO] Add valid architecture function.
[MachO] Add valid architecture function
Jul 3 2019, 5:17 PM
smeenai closed D63735: [MachOObjectFile]Added Valid Architecture Function.
Jul 3 2019, 5:17 PM · Restricted Project
smeenai added a comment to D63735: [MachOObjectFile]Added Valid Architecture Function.

Given that we're following an existing name here, and we'd have to change that existing name as well were we to decide on a new name, I'm going to go ahead and commit this on @anushabasana's behalf. We can figure out the best name to use here and then change all of them at once post-commit.

Jul 3 2019, 5:08 PM · Restricted Project
smeenai added inline comments to D64102: [llvm-lipo] Implement -create part 1.
Jul 3 2019, 3:57 PM · Restricted Project
smeenai added inline comments to D64102: [llvm-lipo] Implement -create part 1.
Jul 3 2019, 11:52 AM · Restricted Project