- User Since
- Aug 19 2016, 10:21 AM (179 w, 6 h)
Wed, Jan 22
I'm assuming git-phab is https://pypi.org/project/git-phab/
This LGTM, but I'll give the clang-tidy developers some time to weigh in.
Can you upload the patch with context (git diff -U9999 if you're using the web interface or via arcanist)?
Tue, Jan 21
CC @plotfi for the InterfaceStubs failures
Fri, Jan 17
The diff here looks weird ... it looks like a diff against your previous diff instead of a diff against master? (Phabricator says the line you're deleting has LANGUAGE ASM instead of LANGUAGE C, as it does on master.)
Adding @compnerd, who's familiar with both libunwind and CMake :)
Thu, Jan 16
From spelunking through history, it looks like D33030 tried to solve the same problem, and then rL319123 undid that solution and came up with a different one to solve the same underlying issue. rL319123 is still in place; does it need to be adjusted for the change in this diff?
Wed, Jan 15
Should this be cherry-picked to the release branch?
Tue, Jan 14
Is this worth merging into 10.0 if it lands after the branch?
Mon, Jan 13
If any follow-ups get landed after the branch, can we make sure they get merged to the branch? Thanks!
To make sure I'm understanding this correctly, previously, for any function with a loop in it, XRay would ignore the minimum instruction count threshold and instrument it unconditionally. You're adding an option to make XRay respect the threshold even if the function has loops. Is that correct?
Thu, Jan 9
Sorry for the delay. Committed this.
Wed, Jan 8
Mon, Jan 6
Sorry, was on vacation. Looks good, thanks!
Dec 14 2019
Dec 13 2019
I'm not sure where best to document this. We have https://llvm.org/docs/HowToBuildWithPGO.html, but that doesn't mention the build system's built-in PGO support as far as I can tell.
LGTM ... I'll wait a few more days in case anyone has comments.
Dec 12 2019
Makes sense to me ... it'd be ideal to limit this to runtimes being built for Darwin targets, but idk if that's possible, and I don't think it's that big of a deal to build llvm-lipo when it's not needed, since it's a pretty tiny dependency.
Dec 3 2019
Nov 28 2019
Nov 27 2019
Nov 26 2019
Nov 25 2019
Nov 20 2019
Nov 18 2019
It's recommended to uploaded patches with full context (e.g. by using git diff -U9999 when uploading a patch using the web interface).
Nov 17 2019
Are there plans to move this forward?
Nov 13 2019
Somewhat related to the comments, I believe lld-link's ability to generate an import library from a def file directly is non-standard. MSVC's toolchain requires you to go through lib for that.
Nov 11 2019
Accepting to unblock, though I'd like to see the LIBCXXABI_USE_SYSTEM_LIBCXX solution explored as a follow-up.
Thanks. WIll wait for an approval from a libc++ code owner before committing.
Commit message needs to be updated.
Nov 8 2019
I converted the test to YAML and committed it as rG56cd447eec8e.
This needs a test case, and it's a good idea to upload patches with more context (use -U99999 if generating a patch via git to upload to the web interface, or just use arcanist).
It seems like the commit dropped the tests. I'm planning to re-add them, and try converting the binary to YAML in the process.
@mvels, I'm assuming you don't have commit access to LLVM. The standard procedure there is that when your commit is accepted, you comment saying you don't have commit access and ask a reviewer to commit it for you. In this case, @mclow.lists should be able to commit it on your behalf.
Nov 7 2019
You should report a bug to CMake (you're right that their implicit removal should account for the various -nostdinc-like options), but this seems like an okay workaround in the meantime.
I agree on not getting into the business of installing Python ourselves, but there's also the rpath issue. The Windows case is different because you just put all your DLLs in the same directory (or some other directory in your PATH) and you're done. With macOS, you have to specify an rpath for liblldb to be able to find the Python framework. It'd be really nice to support adding additional rpaths in the build system itself (it could be a more generic mechanism; it doesn't have to be Python-specific). CMake does offer CMAKE_INSTALL_RPATH, but that applies to every single target. You could also use install_name_tool after building to modify the rpath, but that feels like a kludge.
Oct 29 2019
I can commit this for you tomorrow if one of your reviewers hasn't gotten to it by then.
Oct 25 2019
Will you need someone to commit this for you?
Oct 24 2019
LGTM ... seems like a trivial change that matches the existing handling of LC_VERSION_MIN_MACOSX (and adds test coverage as an added bonus).
The change itself looks fine, but idk if we need to preserve support for any of the older variables (LLVM_ENABLE_CXX1Z in particular). Idk if there's an easy way to e.g. audit bot configurations to see what variables they're using ... maybe posting to llvm-dev would be a good idea?
Oct 23 2019
Oct 21 2019