Addressed additional comments

Addressed comments

Addressed nits

Ping

I moved the semantic error checking code for PowerPC intrinsics into check-call.cpp. It is called from within expression.cpp
This implementation checks if an intrinsic name (after resolution) begins with "__ppc_" to determine if its a PPC intrinsic (PPC builtins scope must exist). We decided to go with this option since it can be argued that a name collision with (for e.g.) __ppc_mtfsf would be at the fault of the user, especially because double underscore names are typically reserved for the compiler.

Move semantic error checking to check-call.cpp

fcfi is actually just another name for fcfid and both should lower to the same llvm.ppc.fcfid intrinsic. llvm.ppc.fcfi does not exist.
This change and the fcf* intrinsics are now properly tested.

We are looking for community input regarding the error handling for these intrinsics (and more PowerPC intrinsics to come):

In D143469#4113928, @klausler wrote:

Please coordinate with https://reviews.llvm.org/D143606

In D143606#4113927, @klausler wrote:

Please coordinate with https://reviews.llvm.org/D143469.

Replaced unneeded SayExternalDeclared methods with Say and fixed typo

Ping

I have added a couple more reviewers based on revision history of the file being modified. If anybody is aware of anybody else who should be aware of this revision that would be appreciated

This is a needed fix for AIX, the code is trivial and used similarly on other targets.

Removed set CMAKE_Fortran_COMPILER

Added set CMAKE_Fortran_COMPILER

fix tested to work

Fix for when multiple testsuites passed

Re-opening to apply fixes and reland

Addressed Nits

Removed unneeded secondary enable_language

another determinable order fix for the exception map

Removed whitespace

removing comment

Addressed nits

In D134195#3895476, @tschuett wrote:

In D134195#3895297, @pscoro wrote:

Replacing DenseMap usage with std::map to ensure a determinable order of exception entries

Could you please check whether you find something for your use case:
https://llvm.org/docs/ProgrammersManual.html#picking-the-right-data-structure-for-a-task

std::map is frowned upon in LLVM. It is very heap heavy.

Replacing DenseMap usage with std::map to ensure a determinable order of exception entries

Removed unneeded llvm-objdump tests

fixes

optimizations and lit test fixes

changes to debug lit tests

optimizations

added addExceptionEntry fatal error if not XCOFF

rebase

@shchenz I do not have commit privileges yet. If there are no further revision requests, could you commit this when you get the chance? Thanks

changed LowerTargetIntrinsic to CollectTargetIntrinsicOperands

mostly formatting fixes

changed lit test file names

adding missing file change

addressing nits

changes to LowerTargetIntrinsic

fixes

Added temporary llvm_unreachable for integrated assembler path

Split review

In D132146#3785383, @shchenz wrote:

You should not add the integrated-as mode change to the existing non integrated-as change.
Better to post two patches for these two functionalities.

whitespace fix

small fix to lit test

formatting

Added integrated assembly support

Reverted chain revision again, final

Re added chain fix

reverted previous fix

chain input fix

Small revisions

removed comments