Page MenuHomePhabricator

pscoro (Paul Scoropan)
User

Projects

User does not belong to any projects.

User Details

User Since
May 18 2022, 7:55 AM (44 w, 4 d)

Recent Activity

Wed, Mar 22

pscoro updated the diff for D144876: [Flang][PowerPC] Implement PPC mtfsf/mtfsfi intrinsics.

Addressed additional comments

Wed, Mar 22, 1:02 PM · Restricted Project, Restricted Project
pscoro updated the diff for D144876: [Flang][PowerPC] Implement PPC mtfsf/mtfsfi intrinsics.

Addressed comments

Wed, Mar 22, 7:29 AM · Restricted Project, Restricted Project

Tue, Mar 21

pscoro updated the diff for D144876: [Flang][PowerPC] Implement PPC mtfsf/mtfsfi intrinsics.

Addressed nits

Tue, Mar 21, 11:34 AM · Restricted Project, Restricted Project

Mon, Mar 20

pscoro committed rG5a222c0b82f8: [Flang] [PowerPC] Implement remaining PPC math operation intrinsics that do not… (authored by pscoro).
[Flang] [PowerPC] Implement remaining PPC math operation intrinsics that do not…
Mon, Mar 20, 8:04 AM · Restricted Project, Restricted Project
pscoro closed D146139: [Flang] [PowerPC] Implement remaining PPC math operation intrinsics that do not require semantic error checks.
Mon, Mar 20, 8:04 AM · Restricted Project, Restricted Project, Restricted Project
pscoro added a comment to D144876: [Flang][PowerPC] Implement PPC mtfsf/mtfsfi intrinsics.

Ping

Mon, Mar 20, 6:02 AM · Restricted Project, Restricted Project

Wed, Mar 15

pscoro updated the summary of D146139: [Flang] [PowerPC] Implement remaining PPC math operation intrinsics that do not require semantic error checks.
Wed, Mar 15, 7:48 AM · Restricted Project, Restricted Project, Restricted Project
pscoro requested review of D146139: [Flang] [PowerPC] Implement remaining PPC math operation intrinsics that do not require semantic error checks.
Wed, Mar 15, 7:45 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Mar 13

pscoro updated the summary of D144876: [Flang][PowerPC] Implement PPC mtfsf/mtfsfi intrinsics.
Mon, Mar 13, 11:08 AM · Restricted Project, Restricted Project
pscoro added a comment to D144876: [Flang][PowerPC] Implement PPC mtfsf/mtfsfi intrinsics.

I moved the semantic error checking code for PowerPC intrinsics into check-call.cpp. It is called from within expression.cpp
This implementation checks if an intrinsic name (after resolution) begins with "__ppc_" to determine if its a PPC intrinsic (PPC builtins scope must exist). We decided to go with this option since it can be argued that a name collision with (for e.g.) __ppc_mtfsf would be at the fault of the user, especially because double underscore names are typically reserved for the compiler.

Mon, Mar 13, 9:28 AM · Restricted Project, Restricted Project
pscoro updated the diff for D144876: [Flang][PowerPC] Implement PPC mtfsf/mtfsfi intrinsics.

Move semantic error checking to check-call.cpp

Mon, Mar 13, 9:20 AM · Restricted Project, Restricted Project

Mon, Mar 6

pscoro committed rG070dd18e3112: [Flang] [PowerPC} Implement the floating-point conversion PowerPC intrinsics (authored by pscoro).
[Flang] [PowerPC} Implement the floating-point conversion PowerPC intrinsics
Mon, Mar 6, 7:02 AM · Restricted Project, Restricted Project
pscoro closed D145080: [Flang] [PowerPC} Implement the floating-point conversion PowerPC intrinsics.
Mon, Mar 6, 7:02 AM · Restricted Project, Restricted Project

Fri, Mar 3

pscoro updated the diff for D145080: [Flang] [PowerPC} Implement the floating-point conversion PowerPC intrinsics.

fcfi is actually just another name for fcfid and both should lower to the same llvm.ppc.fcfid intrinsic. llvm.ppc.fcfi does not exist.
This change and the fcf* intrinsics are now properly tested.

Fri, Mar 3, 7:59 AM · Restricted Project, Restricted Project

Wed, Mar 1

pscoro retitled D145080: [Flang] [PowerPC} Implement the floating-point conversion PowerPC intrinsics from [Flang] [PowerPC} Implement the fc* PowerPC intrinsics to [Flang] [PowerPC} Implement the floating-point conversion PowerPC intrinsics.
Wed, Mar 1, 10:08 AM · Restricted Project, Restricted Project
pscoro updated the summary of D145080: [Flang] [PowerPC} Implement the floating-point conversion PowerPC intrinsics.
Wed, Mar 1, 10:08 AM · Restricted Project, Restricted Project
pscoro requested review of D145080: [Flang] [PowerPC} Implement the floating-point conversion PowerPC intrinsics.
Wed, Mar 1, 10:02 AM · Restricted Project, Restricted Project

Mon, Feb 27

pscoro added a comment to D144876: [Flang][PowerPC] Implement PPC mtfsf/mtfsfi intrinsics.

We are looking for community input regarding the error handling for these intrinsics (and more PowerPC intrinsics to come):

Mon, Feb 27, 9:25 AM · Restricted Project, Restricted Project
pscoro updated the summary of D144876: [Flang][PowerPC] Implement PPC mtfsf/mtfsfi intrinsics.
Mon, Feb 27, 7:38 AM · Restricted Project, Restricted Project
pscoro requested review of D144876: [Flang][PowerPC] Implement PPC mtfsf/mtfsfi intrinsics.
Mon, Feb 27, 7:33 AM · Restricted Project, Restricted Project

Feb 8 2023

pscoro added a comment to D143469: [flang] Remove macro replacement in angular bracket includes.

Please coordinate with https://reviews.llvm.org/D143606

Feb 8 2023, 2:22 PM · Restricted Project, Restricted Project
pscoro abandoned D143606: [flang] Fix to omit #include directives from macro replacement.

Please coordinate with https://reviews.llvm.org/D143469.

Feb 8 2023, 2:20 PM · Restricted Project, Restricted Project
pscoro added a reviewer for D143606: [flang] Fix to omit #include directives from macro replacement: klausler.
Feb 8 2023, 2:02 PM · Restricted Project, Restricted Project
pscoro requested review of D143606: [flang] Fix to omit #include directives from macro replacement.
Feb 8 2023, 1:59 PM · Restricted Project, Restricted Project

Feb 7 2023

pscoro committed rGfe55e42eff24: [Flang] [Semantics] More descript warning message for same named external… (authored by pscoro).
[Flang] [Semantics] More descript warning message for same named external…
Feb 7 2023, 8:04 AM · Restricted Project, Restricted Project
pscoro closed D143426: [Flang] [Semantics] More descript warning message for same named external statements and interfaces.
Feb 7 2023, 8:03 AM · Restricted Project, Restricted Project
pscoro updated the diff for D143426: [Flang] [Semantics] More descript warning message for same named external statements and interfaces.

Replaced unneeded SayExternalDeclared methods with Say and fixed typo

Feb 7 2023, 7:21 AM · Restricted Project, Restricted Project

Feb 6 2023

pscoro added reviewers for D143426: [Flang] [Semantics] More descript warning message for same named external statements and interfaces: klausler, peixin, tislam, DanielCChen.
Feb 6 2023, 11:19 AM · Restricted Project, Restricted Project
pscoro requested review of D143426: [Flang] [Semantics] More descript warning message for same named external statements and interfaces.
Feb 6 2023, 11:16 AM · Restricted Project, Restricted Project

Jan 24 2023

pscoro added a comment to D140628: [flang] Add driver install directory to AIX toolchain program paths list.

Ping

Jan 24 2023, 8:21 AM · Restricted Project, Restricted Project

Jan 18 2023

pscoro added a comment to D140628: [flang] Add driver install directory to AIX toolchain program paths list.

I have added a couple more reviewers based on revision history of the file being modified. If anybody is aware of anybody else who should be aware of this revision that would be appreciated

Jan 18 2023, 10:06 AM · Restricted Project, Restricted Project
pscoro updated the summary of D140628: [flang] Add driver install directory to AIX toolchain program paths list.
Jan 18 2023, 10:04 AM · Restricted Project, Restricted Project

Jan 16 2023

pscoro added a comment to D140628: [flang] Add driver install directory to AIX toolchain program paths list.

This is a needed fix for AIX, the code is trivial and used similarly on other targets.

Jan 16 2023, 12:00 PM · Restricted Project, Restricted Project

Jan 6 2023

pscoro updated the diff for D139633: Enable Fortran testsuite when TEST_SUITE_SUBDIRS=Fortran.

Removed set CMAKE_Fortran_COMPILER

Jan 6 2023, 10:05 AM · Restricted Project

Jan 5 2023

pscoro updated the diff for D139633: Enable Fortran testsuite when TEST_SUITE_SUBDIRS=Fortran.

Added set CMAKE_Fortran_COMPILER

Jan 5 2023, 6:20 AM · Restricted Project

Dec 23 2022

pscoro added reviewers for D140628: [flang] Add driver install directory to AIX toolchain program paths list: rzurob, madanial, tislam, DanielCChen.
Dec 23 2022, 7:11 AM · Restricted Project, Restricted Project
pscoro requested review of D140628: [flang] Add driver install directory to AIX toolchain program paths list.
Dec 23 2022, 7:09 AM · Restricted Project, Restricted Project

Dec 14 2022

pscoro updated the diff for D139633: Enable Fortran testsuite when TEST_SUITE_SUBDIRS=Fortran.

fix tested to work

Dec 14 2022, 11:03 AM · Restricted Project
pscoro updated the diff for D139633: Enable Fortran testsuite when TEST_SUITE_SUBDIRS=Fortran.

Fix for when multiple testsuites passed

Dec 14 2022, 10:21 AM · Restricted Project
pscoro reopened D139633: Enable Fortran testsuite when TEST_SUITE_SUBDIRS=Fortran.

Re-opening to apply fixes and reland

Dec 14 2022, 10:21 AM · Restricted Project

Dec 12 2022

pscoro updated the diff for D139633: Enable Fortran testsuite when TEST_SUITE_SUBDIRS=Fortran.

Addressed Nits

Dec 12 2022, 7:50 AM · Restricted Project

Dec 8 2022

pscoro updated the diff for D139633: Enable Fortran testsuite when TEST_SUITE_SUBDIRS=Fortran.

Removed unneeded secondary enable_language

Dec 8 2022, 8:06 AM · Restricted Project
pscoro updated the summary of D139633: Enable Fortran testsuite when TEST_SUITE_SUBDIRS=Fortran.
Dec 8 2022, 7:53 AM · Restricted Project
pscoro requested review of D139633: Enable Fortran testsuite when TEST_SUITE_SUBDIRS=Fortran.
Dec 8 2022, 7:50 AM · Restricted Project

Dec 1 2022

pscoro added inline comments to D137819: [XCOFF] support the overflow section (only relocation overflow is handled)..
Dec 1 2022, 12:09 PM · Restricted Project, Restricted Project

Nov 20 2022

pscoro updated the diff for D134195: [PowerPC] XCOFF exception section support on the integrated assembler path.

another determinable order fix for the exception map

Nov 20 2022, 8:02 PM · Restricted Project, Restricted Project

Nov 8 2022

pscoro updated the diff for D134195: [PowerPC] XCOFF exception section support on the integrated assembler path.

Removed whitespace

Nov 8 2022, 11:19 AM · Restricted Project, Restricted Project

Nov 7 2022

pscoro updated the diff for D134195: [PowerPC] XCOFF exception section support on the integrated assembler path.

removing comment

Nov 7 2022, 5:58 PM · Restricted Project, Restricted Project

Nov 2 2022

pscoro added inline comments to D134195: [PowerPC] XCOFF exception section support on the integrated assembler path.
Nov 2 2022, 8:18 AM · Restricted Project, Restricted Project
pscoro updated the diff for D134195: [PowerPC] XCOFF exception section support on the integrated assembler path.

Addressed nits

Nov 2 2022, 8:14 AM · Restricted Project, Restricted Project

Oct 31 2022

pscoro added a comment to D134195: [PowerPC] XCOFF exception section support on the integrated assembler path.

Replacing DenseMap usage with std::map to ensure a determinable order of exception entries

Could you please check whether you find something for your use case:
https://llvm.org/docs/ProgrammersManual.html#picking-the-right-data-structure-for-a-task

std::map is frowned upon in LLVM. It is very heap heavy.

Oct 31 2022, 6:22 AM · Restricted Project, Restricted Project

Oct 30 2022

pscoro updated the diff for D134195: [PowerPC] XCOFF exception section support on the integrated assembler path.

Replacing DenseMap usage with std::map to ensure a determinable order of exception entries

Oct 30 2022, 5:24 PM · Restricted Project, Restricted Project

Oct 25 2022

pscoro updated the diff for D134195: [PowerPC] XCOFF exception section support on the integrated assembler path.

Removed unneeded llvm-objdump tests

Oct 25 2022, 11:19 AM · Restricted Project, Restricted Project

Oct 24 2022

pscoro added inline comments to D134195: [PowerPC] XCOFF exception section support on the integrated assembler path.
Oct 24 2022, 2:13 PM · Restricted Project, Restricted Project
pscoro added inline comments to D134195: [PowerPC] XCOFF exception section support on the integrated assembler path.
Oct 24 2022, 12:30 PM · Restricted Project, Restricted Project
pscoro updated the diff for D134195: [PowerPC] XCOFF exception section support on the integrated assembler path.

fixes

Oct 24 2022, 12:28 PM · Restricted Project, Restricted Project

Oct 20 2022

pscoro updated the diff for D134195: [PowerPC] XCOFF exception section support on the integrated assembler path.

optimizations and lit test fixes

Oct 20 2022, 7:12 AM · Restricted Project, Restricted Project

Oct 17 2022

pscoro added inline comments to D134195: [PowerPC] XCOFF exception section support on the integrated assembler path.
Oct 17 2022, 11:03 AM · Restricted Project, Restricted Project
pscoro updated the diff for D134195: [PowerPC] XCOFF exception section support on the integrated assembler path.

changes to debug lit tests

Oct 17 2022, 10:59 AM · Restricted Project, Restricted Project
pscoro added inline comments to D134195: [PowerPC] XCOFF exception section support on the integrated assembler path.
Oct 17 2022, 10:52 AM · Restricted Project, Restricted Project
pscoro updated the diff for D134195: [PowerPC] XCOFF exception section support on the integrated assembler path.

optimizations

Oct 17 2022, 10:45 AM · Restricted Project, Restricted Project

Oct 11 2022

pscoro added inline comments to D134195: [PowerPC] XCOFF exception section support on the integrated assembler path.
Oct 11 2022, 7:00 AM · Restricted Project, Restricted Project
pscoro updated the diff for D134195: [PowerPC] XCOFF exception section support on the integrated assembler path.

added addExceptionEntry fatal error if not XCOFF

Oct 11 2022, 6:58 AM · Restricted Project, Restricted Project

Oct 9 2022

pscoro added inline comments to D134195: [PowerPC] XCOFF exception section support on the integrated assembler path.
Oct 9 2022, 3:04 PM · Restricted Project, Restricted Project
pscoro updated the diff for D134195: [PowerPC] XCOFF exception section support on the integrated assembler path.

rebase

Oct 9 2022, 2:37 PM · Restricted Project, Restricted Project

Sep 26 2022

pscoro added a comment to D132146: [PowerPC] XCOFF exception section support on the direct assembler path and exception language and reason code lowering from trap intrinsics.

@shchenz I do not have commit privileges yet. If there are no further revision requests, could you commit this when you get the chance? Thanks

Sep 26 2022, 8:01 AM · Restricted Project, Restricted Project
pscoro updated the diff for D132146: [PowerPC] XCOFF exception section support on the direct assembler path and exception language and reason code lowering from trap intrinsics.

changed LowerTargetIntrinsic to CollectTargetIntrinsicOperands

Sep 26 2022, 7:29 AM · Restricted Project, Restricted Project
pscoro added inline comments to D132146: [PowerPC] XCOFF exception section support on the direct assembler path and exception language and reason code lowering from trap intrinsics.
Sep 26 2022, 6:55 AM · Restricted Project, Restricted Project
pscoro added inline comments to D132146: [PowerPC] XCOFF exception section support on the direct assembler path and exception language and reason code lowering from trap intrinsics.
Sep 26 2022, 6:34 AM · Restricted Project, Restricted Project
pscoro added inline comments to D132146: [PowerPC] XCOFF exception section support on the direct assembler path and exception language and reason code lowering from trap intrinsics.
Sep 26 2022, 6:06 AM · Restricted Project, Restricted Project

Sep 25 2022

pscoro updated the diff for D134195: [PowerPC] XCOFF exception section support on the integrated assembler path.

mostly formatting fixes

Sep 25 2022, 7:51 PM · Restricted Project, Restricted Project
pscoro updated the diff for D132146: [PowerPC] XCOFF exception section support on the direct assembler path and exception language and reason code lowering from trap intrinsics.

changed lit test file names

Sep 25 2022, 7:22 PM · Restricted Project, Restricted Project
pscoro updated the diff for D134195: [PowerPC] XCOFF exception section support on the integrated assembler path.

adding missing file change

Sep 25 2022, 7:15 PM · Restricted Project, Restricted Project
pscoro added inline comments to D132146: [PowerPC] XCOFF exception section support on the direct assembler path and exception language and reason code lowering from trap intrinsics.
Sep 25 2022, 6:19 PM · Restricted Project, Restricted Project
pscoro updated the diff for D132146: [PowerPC] XCOFF exception section support on the direct assembler path and exception language and reason code lowering from trap intrinsics.

addressing nits

Sep 25 2022, 6:16 PM · Restricted Project, Restricted Project

Sep 21 2022

pscoro updated the diff for D132146: [PowerPC] XCOFF exception section support on the direct assembler path and exception language and reason code lowering from trap intrinsics.

changes to LowerTargetIntrinsic

Sep 21 2022, 12:05 PM · Restricted Project, Restricted Project
pscoro updated the diff for D132146: [PowerPC] XCOFF exception section support on the direct assembler path and exception language and reason code lowering from trap intrinsics.

fixes

Sep 21 2022, 10:57 AM · Restricted Project, Restricted Project

Sep 19 2022

pscoro retitled D134195: [PowerPC] XCOFF exception section support on the integrated assembler path from finished integrated assembler version to [PowerPC] XCOFF exception section support on the integrated assembler path.
Sep 19 2022, 10:02 AM · Restricted Project, Restricted Project
pscoro updated the summary of D132146: [PowerPC] XCOFF exception section support on the direct assembler path and exception language and reason code lowering from trap intrinsics.
Sep 19 2022, 9:59 AM · Restricted Project, Restricted Project
pscoro requested review of D134195: [PowerPC] XCOFF exception section support on the integrated assembler path.
Sep 19 2022, 9:58 AM · Restricted Project, Restricted Project
pscoro retitled D132146: [PowerPC] XCOFF exception section support on the direct assembler path and exception language and reason code lowering from trap intrinsics from [PowerPC] XCOFF exception section support ondirect assembler path and exception language and reason code lowering from trap intrinsics to [PowerPC] XCOFF exception section support on the direct assembler path and exception language and reason code lowering from trap intrinsics.
Sep 19 2022, 9:56 AM · Restricted Project, Restricted Project
pscoro retitled D132146: [PowerPC] XCOFF exception section support on the direct assembler path and exception language and reason code lowering from trap intrinsics from [PowerPC] XCOFF exception section support on integrated and direct assembler paths and exception language and reason code lowering from trap intrinsics to [PowerPC] XCOFF exception section support ondirect assembler path and exception language and reason code lowering from trap intrinsics.
Sep 19 2022, 9:56 AM · Restricted Project, Restricted Project
pscoro updated the diff for D132146: [PowerPC] XCOFF exception section support on the direct assembler path and exception language and reason code lowering from trap intrinsics.

Added temporary llvm_unreachable for integrated assembler path

Sep 19 2022, 9:31 AM · Restricted Project, Restricted Project
pscoro updated the diff for D132146: [PowerPC] XCOFF exception section support on the direct assembler path and exception language and reason code lowering from trap intrinsics.

Split review

Sep 19 2022, 9:20 AM · Restricted Project, Restricted Project

Sep 13 2022

pscoro added a comment to D132146: [PowerPC] XCOFF exception section support on the direct assembler path and exception language and reason code lowering from trap intrinsics.

You should not add the integrated-as mode change to the existing non integrated-as change.
Better to post two patches for these two functionalities.

Sep 13 2022, 6:41 AM · Restricted Project, Restricted Project

Sep 12 2022

pscoro updated the diff for D132146: [PowerPC] XCOFF exception section support on the direct assembler path and exception language and reason code lowering from trap intrinsics.

whitespace fix

Sep 12 2022, 7:45 AM · Restricted Project, Restricted Project
pscoro retitled D132146: [PowerPC] XCOFF exception section support on the direct assembler path and exception language and reason code lowering from trap intrinsics from [PowerPC] XCOFF exception section support on assembler path and exception language and reason code lowering from trap intrinsics to [PowerPC] XCOFF exception section support on integrated and direct assembler paths and exception language and reason code lowering from trap intrinsics.
Sep 12 2022, 7:41 AM · Restricted Project, Restricted Project
pscoro updated the diff for D132146: [PowerPC] XCOFF exception section support on the direct assembler path and exception language and reason code lowering from trap intrinsics.

small fix to lit test

Sep 12 2022, 7:37 AM · Restricted Project, Restricted Project
pscoro updated the diff for D132146: [PowerPC] XCOFF exception section support on the direct assembler path and exception language and reason code lowering from trap intrinsics.

formatting

Sep 12 2022, 6:44 AM · Restricted Project, Restricted Project
pscoro updated the diff for D132146: [PowerPC] XCOFF exception section support on the direct assembler path and exception language and reason code lowering from trap intrinsics.

Added integrated assembly support

Sep 12 2022, 6:41 AM · Restricted Project, Restricted Project

Aug 31 2022

pscoro added inline comments to D133030: [AIX] llvm-readobj support a new option --exception-section for xcoff object file..
Aug 31 2022, 9:53 AM · Restricted Project, Restricted Project

Aug 18 2022

pscoro retitled D132146: [PowerPC] XCOFF exception section support on the direct assembler path and exception language and reason code lowering from trap intrinsics from [PowerPC] XCOFF exception section support and exception language and reason code lowering from trap intrinsics to [PowerPC] XCOFF exception section support on assembler path and exception language and reason code lowering from trap intrinsics.
Aug 18 2022, 10:06 AM · Restricted Project, Restricted Project
pscoro requested review of D132146: [PowerPC] XCOFF exception section support on the direct assembler path and exception language and reason code lowering from trap intrinsics.
Aug 18 2022, 10:00 AM · Restricted Project, Restricted Project

Aug 17 2022

pscoro updated the diff for D129016: [PowerPC] implemented @llvm.ppc.kill.canary to corrupt stack guard.

Reverted chain revision again, final

Aug 17 2022, 6:32 AM · Restricted Project, Restricted Project, Restricted Project

Aug 16 2022

pscoro updated the diff for D129016: [PowerPC] implemented @llvm.ppc.kill.canary to corrupt stack guard.

Re added chain fix

Aug 16 2022, 1:05 PM · Restricted Project, Restricted Project, Restricted Project
pscoro updated the diff for D129016: [PowerPC] implemented @llvm.ppc.kill.canary to corrupt stack guard.

reverted previous fix

Aug 16 2022, 6:52 AM · Restricted Project, Restricted Project, Restricted Project

Aug 15 2022

pscoro updated the diff for D129016: [PowerPC] implemented @llvm.ppc.kill.canary to corrupt stack guard.

chain input fix

Aug 15 2022, 10:39 AM · Restricted Project, Restricted Project, Restricted Project

Aug 9 2022

pscoro updated the diff for D129016: [PowerPC] implemented @llvm.ppc.kill.canary to corrupt stack guard.

Small revisions

Aug 9 2022, 6:35 AM · Restricted Project, Restricted Project, Restricted Project

Aug 3 2022

pscoro updated the diff for D129016: [PowerPC] implemented @llvm.ppc.kill.canary to corrupt stack guard.

removed comments

Aug 3 2022, 9:18 AM · Restricted Project, Restricted Project, Restricted Project

Aug 2 2022

pscoro added inline comments to D129016: [PowerPC] implemented @llvm.ppc.kill.canary to corrupt stack guard.
Aug 2 2022, 8:41 AM · Restricted Project, Restricted Project, Restricted Project