User Details
- User Since
- May 18 2022, 7:55 AM (44 w, 4 d)
Wed, Mar 22
Addressed additional comments
Addressed comments
Tue, Mar 21
Addressed nits
Mon, Mar 20
Ping
Wed, Mar 15
Mon, Mar 13
I moved the semantic error checking code for PowerPC intrinsics into check-call.cpp. It is called from within expression.cpp
This implementation checks if an intrinsic name (after resolution) begins with "__ppc_" to determine if its a PPC intrinsic (PPC builtins scope must exist). We decided to go with this option since it can be argued that a name collision with (for e.g.) __ppc_mtfsf would be at the fault of the user, especially because double underscore names are typically reserved for the compiler.
Move semantic error checking to check-call.cpp
Mon, Mar 6
Fri, Mar 3
fcfi is actually just another name for fcfid and both should lower to the same llvm.ppc.fcfid intrinsic. llvm.ppc.fcfi does not exist.
This change and the fcf* intrinsics are now properly tested.
Wed, Mar 1
Mon, Feb 27
We are looking for community input regarding the error handling for these intrinsics (and more PowerPC intrinsics to come):
Feb 8 2023
Feb 7 2023
Replaced unneeded SayExternalDeclared methods with Say and fixed typo
Feb 6 2023
Jan 24 2023
Ping
Jan 18 2023
I have added a couple more reviewers based on revision history of the file being modified. If anybody is aware of anybody else who should be aware of this revision that would be appreciated
Jan 16 2023
This is a needed fix for AIX, the code is trivial and used similarly on other targets.
Jan 6 2023
Removed set CMAKE_Fortran_COMPILER
Jan 5 2023
Added set CMAKE_Fortran_COMPILER
Dec 23 2022
Dec 14 2022
fix tested to work
Fix for when multiple testsuites passed
Re-opening to apply fixes and reland
Dec 12 2022
Addressed Nits
Dec 8 2022
Removed unneeded secondary enable_language
Dec 1 2022
Nov 20 2022
another determinable order fix for the exception map
Nov 8 2022
Removed whitespace
Nov 7 2022
removing comment
Nov 2 2022
Addressed nits
Oct 31 2022
Oct 30 2022
Replacing DenseMap usage with std::map to ensure a determinable order of exception entries
Oct 25 2022
Removed unneeded llvm-objdump tests
Oct 24 2022
fixes
Oct 20 2022
optimizations and lit test fixes
Oct 17 2022
changes to debug lit tests
optimizations
Oct 11 2022
added addExceptionEntry fatal error if not XCOFF
Oct 9 2022
rebase
Sep 26 2022
@shchenz I do not have commit privileges yet. If there are no further revision requests, could you commit this when you get the chance? Thanks
changed LowerTargetIntrinsic to CollectTargetIntrinsicOperands
Sep 25 2022
mostly formatting fixes
changed lit test file names
adding missing file change
addressing nits
Sep 21 2022
changes to LowerTargetIntrinsic
fixes
Sep 19 2022
Added temporary llvm_unreachable for integrated assembler path
Split review
Sep 13 2022
Sep 12 2022
whitespace fix
small fix to lit test
formatting
Added integrated assembly support
Aug 31 2022
Aug 18 2022
Aug 17 2022
Reverted chain revision again, final
Aug 16 2022
Re added chain fix
reverted previous fix
Aug 15 2022
chain input fix
Aug 9 2022
Small revisions
Aug 3 2022
removed comments