Page MenuHomePhabricator

[RISCV] Use __extendhfsf2/__truncsfhf2 for fp16 <-> fp32
ClosedPublic

Authored by kito-cheng on Jan 25 2022, 6:27 PM.

Details

Summary

__gnu_h2f_ieee and __gnu_f2h_ieee are introduce by ARM and set that as
default name for fp16 and fp32 conversion in LLVM.

However RISC-V GCC using default naming scheme for that, which is
__extendhfsf2 and __truncsfhf2 for that, that cause runtime ABI
incompatible issue.

Although we didn't have formal runtime ABI spec to specify those naming
convention yet, but I think it would be great to fix the incompatible
issue first.

And I've plan to create a runtime ABI spec undere psABI spec this year.

Diff Detail

Event Timeline

kito-cheng created this revision.Jan 25 2022, 6:27 PM
kito-cheng requested review of this revision.Jan 25 2022, 6:27 PM
asb accepted this revision.Jan 28 2022, 6:08 AM

LGTM. Thanks Kito.

This revision is now accepted and ready to land.Jan 28 2022, 6:08 AM
This revision was landed with ongoing or failed builds.Jan 28 2022, 8:01 AM
This revision was automatically updated to reflect the committed changes.