This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Provide VLOperand in td.
ClosedPublic

Authored by HanKuanChen on Jan 16 2022, 10:50 PM.

Details

Summary

Currently, users expected VL is the last operand. However, since some

intrinsics has tail policy in the last operand, this rule cannot be used

anymore.

Diff Detail

Event Timeline

HanKuanChen created this revision.Jan 16 2022, 10:50 PM
HanKuanChen requested review of this revision.Jan 16 2022, 10:50 PM

Cool, seems like this patch also fixed a potential bug for rv32.

craig.topper accepted this revision.Jan 16 2022, 11:15 PM

LGTM

llvm/include/llvm/IR/IntrinsicsRISCV.td
126

is not exist -> does not exist

This revision is now accepted and ready to land.Jan 16 2022, 11:15 PM

Apply grammar fix: is not exist -> does not exist

frasercrmck accepted this revision.Jan 17 2022, 2:48 AM

LGTM otherwise

llvm/include/llvm/IR/IntrinsicsRISCV.td
126

Sorry as this is super nitty but the comment still doesn't read well to me. Maybe The intrinsic does not have a VL operand. as that also fits the description of NoSplatOperand?

apply sentence advise

This revision was landed with ongoing or failed builds.Jan 17 2022, 8:30 PM
This revision was automatically updated to reflect the committed changes.