Page MenuHomePhabricator

[LV, VP] Add CLI option to support predicated vectorization
Needs ReviewPublic

Authored by vkmr on Jun 21 2021, 3:43 PM.

Details

Summary

This patch adds a hidden command line option to enable predicated vectorization using VP intrinsics.
It is the 3rd patch in the series of patches to enable vector predication support (D99750).

Diff Detail

Event Timeline

vkmr created this revision.Jun 21 2021, 3:43 PM
vkmr requested review of this revision.Jun 21 2021, 3:43 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 21 2021, 3:43 PM

A link to the VP intrinsics section in the LangRef would be nice.

llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
238

This is a lot of text. Maybe restructure this to make clear what the default is right now (NoPredication), what the default should be in the future (IfAVLSupported) and mention the other two explicitly as experimental/test settings.

simoll added inline comments.Wed, Jul 7, 10:37 AM
llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
238

@vkmr pong: I stand by that comment ;-)

vkmr added inline comments.Wed, Jul 7, 2:07 PM
llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
238

Oops my bad! @simoll I 100% stand by your comment too!
I totally forgot about it before the ping. I will address it in an upcoming update.

Matt added a subscriber: Matt.Mon, Jul 12, 7:17 AM