Page MenuHomePhabricator
Differential D100412

[Aarch64] handle "o" inline asm memory constraints
ClosedPublic
Actions

Authored by nickdesaulniers on Apr 13 2021, 2:10 PM.

Details

Reviewers
arsenm
t.p.northover
MaskRay
srhines
Commits
rGbb7016f8f50e: [Aarch64] handle "o" inline asm memory constraints
Summary

This Linux kernel is making use of this inline asm constraint which is
causing an ICE.

PR49956

Link: https://github.com/ClangBuiltLinux/linux/issues/1348

Diff Detail

Event Timeline

nickdesaulniers created this revision.Apr 13 2021, 2:10 PM
Herald added subscribers: danielkiss, hiraditya, kristof.beyls. · View Herald TranscriptApr 13 2021, 2:10 PM
nickdesaulniers requested review of this revision.Apr 13 2021, 2:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 13 2021, 2:10 PM
Herald added subscribers: llvm-commits, wdng. · View Herald Transcript
nickdesaulniers added a subscriber: kees.Apr 13 2021, 2:17 PM
nickdesaulniers updated this revision to Diff 337264.Apr 13 2021, 2:53 PM
  • add CHECKs to test case
nickdesaulniers added a child revision: D100416: [TargetLowering] move "o" and "X" constraint handling to base class.Apr 13 2021, 3:30 PM
Harbormaster completed remote builds in B98556: Diff 337257.Apr 13 2021, 7:26 PM
Harbormaster completed remote builds in B98560: Diff 337264.Apr 13 2021, 8:01 PM
nathanchance added a comment.Apr 14 2021, 6:03 PM

This resolves the error noted in the issue above and I can boot with randomize_kstack_offset=on on bare metal without any issues.

nickdesaulniers added reviewers: MaskRay, srhines.Apr 15 2021, 10:06 AM
nickdesaulniers removed a subscriber: srhines.
MaskRay accepted this revision.Apr 15 2021, 7:07 PM
MaskRay added inline comments.
llvm/test/CodeGen/AArch64/arm64-inline-asm.ll
301

The comment may not be needed. This is a simple lack of handling of a particular constraint type. Having the coverage is sufficient. Readers may not want to read the link.

303

Appending : can make the label more unique.

This revision is now accepted and ready to land.Apr 15 2021, 7:07 PM
nickdesaulniers updated this revision to Diff 337996.Apr 15 2021, 11:09 PM
  • fix test comment and CHECK
nickdesaulniers marked 2 inline comments as done.Apr 15 2021, 11:09 PM
This revision was landed with ongoing or failed builds.Apr 15 2021, 11:36 PM
Closed by commit rGbb7016f8f50e: [Aarch64] handle "o" inline asm memory constraints (authored by nickdesaulniers). · Explain Why
This revision was automatically updated to reflect the committed changes.
nickdesaulniers added a commit: rGbb7016f8f50e: [Aarch64] handle "o" inline asm memory constraints.
nickdesaulniers added a comment.Apr 15 2021, 11:36 PM

thanks for the review

Harbormaster completed remote builds in B99085: Diff 337996.Apr 16 2021, 12:00 AM

Revision Contents
Changeset List

PathSize
llvm/
lib/
Target/
AArch64/
1 line
2 lines
test/
CodeGen/
AArch64/
10 lines

Diff 338001

View Options

llvm/lib/Target/AArch64/AArch64ISelDAGToDAG.cpp

Loading...
View Options

llvm/lib/Target/AArch64/AArch64ISelLowering.h

Loading...
View Options

llvm/test/CodeGen/AArch64/arm64-inline-asm.ll

Loading...