Page MenuHomePhabricator

nathanchance (Nathan Chancellor)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 9 2018, 11:07 PM (54 w, 18 h)

Recent Activity

Sun, Oct 13

nathanchance accepted D68726: [libc] Do not add unittests LLVM_INCLUDE_TESTS is OFF..
Sun, Oct 13, 7:01 PM · Restricted Project

Thu, Oct 10

nathanchance added a comment to D68726: [libc] Do not add unittests LLVM_INCLUDE_TESTS is OFF..

Yes, it does! I can approve this if you need it but I am not an expect in cmake so I cannot comment on how proper this is.

Thu, Oct 10, 12:21 AM · Restricted Project

Wed, Oct 9

nathanchance added a comment to D67867: [libc] Add few docs and implementation of strcpy and strcat..

Just as an FYI, this patch breaks LLVM_INCLUDE_TESTS=OFF for me:

Wed, Oct 9, 11:54 AM · Restricted Project, Restricted Project

Aug 29 2019

nathanchance added a comment to D66404: [CFG] Make destructor calls more accurate.

@NoQ thank you for the fix, I can confirm it works!

Aug 29 2019, 10:23 PM · Restricted Project, Restricted Project
nathanchance added a comment to D66404: [CFG] Make destructor calls more accurate.

This commit causes some warnings in the Linux kernel that appear to be false positives. For example:

Aug 29 2019, 12:24 AM · Restricted Project, Restricted Project

Aug 28 2019

nathanchance accepted D66873: [Test][Time profiler] Fix test for python3.

LGTM.

Aug 28 2019, 5:07 PM · Restricted Project, Restricted Project
nathanchance added a comment to D66873: [Test][Time profiler] Fix test for python3.

The test case passes for me after this, thanks for the fix!

Aug 28 2019, 12:01 PM · Restricted Project, Restricted Project

Aug 26 2019

nathanchance added a comment to D66537: [DAGCombiner] Remove a bunch of redundant AddToWorklist calls..

My instrumented stage 2 build fails after this commit with this script.

Aug 26 2019, 4:16 PM · Restricted Project

Aug 23 2019

nathanchance added a comment to D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks.

Could it be an issue with python? What is the version you are using?

Aug 23 2019, 12:12 PM · Restricted Project, Restricted Project
nathanchance added a comment to D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks.

Done, thanks for looking into this!

Aug 23 2019, 8:39 AM · Restricted Project, Restricted Project

Aug 22 2019

nathanchance added a comment to D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks.

This test case has never passed for me with check-clang, is there something environment related that is needed with this or are others experiencing this too?

Aug 22 2019, 10:54 PM · Restricted Project, Restricted Project

Aug 12 2019

nathanchance abandoned D65726: [gold] Fix X86/strip_names.ll after r367755.

Yes, it does look like that is the case, I will abandon this. Thanks for the reply!

Aug 12 2019, 9:47 AM · Restricted Project

Aug 8 2019

nathanchance added inline comments to D65352: [CodeGen] Require a name for a block addr target.
Aug 8 2019, 11:52 AM · Restricted Project
nathanchance added inline comments to D65352: [CodeGen] Require a name for a block addr target.
Aug 8 2019, 11:46 AM · Restricted Project

Aug 4 2019

nathanchance added a comment to rGc9171bd0a955: [x86] change free truncate hook to handle only simple types (PR42880).

This causes a compiler hang (I assume infinite loop or deadlock somewhere) when compiling the Linux kernel.

Aug 4 2019, 7:25 PM
nathanchance created D65726: [gold] Fix X86/strip_names.ll after r367755.
Aug 4 2019, 12:54 PM · Restricted Project
nathanchance updated the summary of D65726: [gold] Fix X86/strip_names.ll after r367755.
Aug 4 2019, 12:54 PM · Restricted Project

Jul 22 2019

nathanchance added a comment to D65108: Reland "driver: Don't warn about assembler flags being unused when not assembling".

I tested this patch on top of r366728 and saw no regressions in my set of kernel builds.

Jul 22 2019, 2:43 PM

Jul 11 2019

nathanchance added a comment to D64527: driver: Don't warn about assembler flags being unused when not assembling.

This change breaks building the Linux kernel for arm32 (at least):

Jul 11 2019, 1:43 AM · Restricted Project

Jun 4 2019

nathanchance added a comment to D62873: Avoid building analyzer plugins if CLANG_ENABLE_STATIC_ANALYZER is OFF.

Thanks for the quick fix, looks good to me!

Jun 4 2019, 1:06 PM · Restricted Project
nathanchance added inline comments to D62445: [test] Fix plugin tests.
Jun 4 2019, 12:11 PM · Restricted Project, Restricted Project

May 21 2019

nathanchance added a comment to D62218: [docs][cmake] document LLVM_ENABLE_PLUGINS.

Is there a point to adding this if it isn't a user selectable option? LLVM_ENABLE_PLUGINS doesn't have an option in any cmake files, it is only ever set.

May 21 2019, 2:45 PM · Restricted Project

Jan 15 2019

nathanchance added inline comments to D56658: [MSP430] Add msp430 toochain.
Jan 15 2019, 1:32 PM
nathanchance added inline comments to D56658: [MSP430] Add msp430 toochain.
Jan 15 2019, 1:14 PM