- User Since
- Oct 9 2018, 11:07 PM (77 w, 6 d)
This does not take into account CLANG_DEFAULT_LINKER, resulting in a check-clang failure:
Sun, Mar 22
I can confirm this fixes my issue, thank you for the quick fix! I can approve if need be but might be better for someone else more familiar with this area to do that :)
This change breaks -DLLVM_INCLUDE_TESTS=OFF:
Seems sane to me if I am understanding the string arithmetic correctly. I can confirm this fixes the Debian use case that we came across.
Mar 7 2020
Thanks for the review and accepting. I do not have commit rights, would you mind doing that on my behalf?
Mar 6 2020
Mar 3 2020
Feb 18 2020
Feb 16 2020
There appear to a be semantic difference between GCC and clang with the current version of this patch which results in a lot of additional warnings in the Linux kernel: https://godbolt.org/z/eHFJd8
Feb 11 2020
The Linux kernel hits the assert in markConstant on arm32 defconfig in net/mac80211/sta_info.o, as reported by Linaro's CI:
Feb 7 2020
Please revert; I am happy to test a new revision to make sure there are no warnings but I don’t want this shipped in clang-10 and a revert is something that we can easily backport unless you can come up with a fix rather quickly.
Jan 19 2020
Jan 13 2020
This fixes the error for me and looks better from a documentation perspective.
I am seeing the same failure that @leonardchan reported above. This is related to -DCLANG_DEFAULT_LINKER=lld:
Dec 21 2019
Dec 18 2019
As a follow up to my previous post, I have sent patches to clean up all of the warnings that I see in the Linux kernel. However, I found one that I do believe is a false positive:
Dec 4 2019
IMO that is misleading indentation. A single space followed by a tab? WTF
Dec 3 2019
As an FYI, this appears to cause several false positive warnings with the Linux kernel:
Oct 13 2019
Oct 10 2019
Yes, it does! I can approve this if you need it but I am not an expect in cmake so I cannot comment on how proper this is.
Oct 9 2019
Just as an FYI, this patch breaks LLVM_INCLUDE_TESTS=OFF for me:
Aug 29 2019
@NoQ thank you for the fix, I can confirm it works!
This commit causes some warnings in the Linux kernel that appear to be false positives. For example:
Aug 28 2019
The test case passes for me after this, thanks for the fix!
Aug 26 2019
My instrumented stage 2 build fails after this commit with this script.
Aug 23 2019
Could it be an issue with python? What is the version you are using?
Done, thanks for looking into this!
Aug 22 2019
This test case has never passed for me with check-clang, is there something environment related that is needed with this or are others experiencing this too?
Aug 12 2019
Yes, it does look like that is the case, I will abandon this. Thanks for the reply!
Aug 8 2019
Aug 4 2019
This causes a compiler hang (I assume infinite loop or deadlock somewhere) when compiling the Linux kernel.
Jul 22 2019
I tested this patch on top of r366728 and saw no regressions in my set of kernel builds.
Jul 11 2019
This change breaks building the Linux kernel for arm32 (at least):
Jun 4 2019
Thanks for the quick fix, looks good to me!
May 21 2019
Is there a point to adding this if it isn't a user selectable option? LLVM_ENABLE_PLUGINS doesn't have an option in any cmake files, it is only ever set.