Page MenuHomePhabricator

srhines (Stephen Hines)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 23 2012, 7:46 PM (421 w, 2 d)

Recent Activity

Tue, Sep 15

srhines committed rG516a01b5f36d: Implement __isOSVersionAtLeast for Android (authored by srhines).
Implement __isOSVersionAtLeast for Android
Tue, Sep 15, 12:56 PM
srhines closed D86596: Implement __isOSVersionAtLeast for Android.
Tue, Sep 15, 12:55 PM · Restricted Project

Fri, Sep 11

srhines added a comment to D83144: Allow to specify macro names for android-comparison-in-temp-failure-retry..

Thanks for the review! Should I wait for Alex to take a look, or is it fine like this?

Fri, Sep 11, 12:31 PM · Restricted Project
srhines accepted D83144: Allow to specify macro names for android-comparison-in-temp-failure-retry..

Thanks for creating the new test, and for making this more flexible. Everything else looks good here.

Fri, Sep 11, 11:43 AM · Restricted Project

Thu, Sep 10

srhines added inline comments to D83144: Allow to specify macro names for android-comparison-in-temp-failure-retry..
Thu, Sep 10, 1:41 PM · Restricted Project

Wed, Sep 9

srhines accepted D86596: Implement __isOSVersionAtLeast for Android.

Sorry, Jiyong, I had forgotten to subscribe llvm-commits when I first uploaded this (because it's part of compiler-rt and doesn't seem to have a default rule to add them). In any case, this patch LGTM, and I am going to go ahead and approve it since this only affects Android. Let's give it 24 hours for anyone else to comment before committing though (especially since I messed up with the original upload/review).

Wed, Sep 9, 1:57 AM · Restricted Project
srhines removed a reviewer for D86596: Implement __isOSVersionAtLeast for Android: llvm-commits.
Wed, Sep 9, 1:53 AM · Restricted Project
srhines added a reviewer for D86596: Implement __isOSVersionAtLeast for Android: llvm-commits.
Wed, Sep 9, 1:52 AM · Restricted Project

Thu, Sep 3

srhines added inline comments to D87067: [llvm-symbolizer] Add back --use-symbol-table=true.
Thu, Sep 3, 3:17 PM · Restricted Project

Wed, Aug 26

srhines requested review of D86596: Implement __isOSVersionAtLeast for Android.
Wed, Aug 26, 1:31 AM · Restricted Project

Mon, Aug 24

srhines accepted D86321: Fix test for D77924..

Yes, let's just submit this now. If it breaks further, then we can consider other options. I'm not sure why there is a separate libc++abi reviewer listed here.

Mon, Aug 24, 3:00 PM · Restricted Project

Aug 14 2020

srhines added a comment to D67689: [llvm-objcopy] Add support for --gap-fill and --pad-to options.

@asmith, are you still working on this patch? The gap-fill feature is definitely needed for parity with existing objcopy implementations.

Aug 14 2020, 8:22 AM · Restricted Project

Jul 13 2020

srhines committed rG9d5a8b7edb28: Fix a missing update that C compiles default to gnu17. (authored by srhines).
Fix a missing update that C compiles default to gnu17.
Jul 13 2020, 4:36 PM
srhines closed D83726: Fix a missing update that C compiles default to gnu17..
Jul 13 2020, 4:36 PM · Restricted Project
Herald added a project to D83726: Fix a missing update that C compiles default to gnu17.: Restricted Project.
Jul 13 2020, 3:43 PM · Restricted Project

Jun 15 2020

srhines accepted D81622: [Clang] Search computed sysroot for libc++ header paths.

Thanks, Ryan!

Jun 15 2020, 1:14 PM · Restricted Project

Jun 10 2020

srhines added a comment to D81622: [Clang] Search computed sysroot for libc++ header paths.

Thanks, Ryan, for diagnosing and addressing this bug.

Jun 10 2020, 9:02 PM · Restricted Project

Jun 1 2020

srhines accepted D80828: [Clang][A32/T32][Linux] -O1 implies -fomit-frame-pointer.

Thanks, Nick, for cleaning this up and always striving to make things more compatible.

Jun 1 2020, 12:25 PM · Restricted Project, Restricted Project
srhines added inline comments to D80828: [Clang][A32/T32][Linux] -O1 implies -fomit-frame-pointer.
Jun 1 2020, 11:18 AM · Restricted Project, Restricted Project

May 29 2020

srhines added inline comments to D80828: [Clang][A32/T32][Linux] -O1 implies -fomit-frame-pointer.
May 29 2020, 4:25 PM · Restricted Project, Restricted Project

Apr 30 2020

srhines accepted D78787: [libcxx][libcxxabi][libunwind] Use libgcc on Android.

I'm also satisfied with this from the Android side. Thank you for discussing this with Ryan.

Apr 30 2020, 3:09 PM · Restricted Project, Restricted Project, Restricted Project

Apr 24 2020

srhines accepted D78837: [lld] Remove special cases from default ld driver mode..

LGTM on the Android side. Thanks Dan for handling this.

Apr 24 2020, 5:21 PM · Restricted Project, lld

Apr 22 2020

srhines added a comment to D77330: Consider increasing the default ARM32 max page size to 64k..

Hmm...seems to have regressed ARMv5 Linux kernel boots according to a bisection from @nathanchance (https://groups.google.com/g/clang-built-linux/c/aKDK-N6JN4g)

I don't think that URL is publicly visible.

I don't know why that started happening :/

I think we saw such issue before. That time I think the URL of a page from incognito mode worked (i.e. a different URL to the same page).

Apr 22 2020, 2:08 AM · Restricted Project, lld

Apr 16 2020

srhines added a comment to D77168: Add a flag to debug automatic variable initialization.
In D77168#1988122, @jfb wrote:

pragma clang attribute is interesting, but how do you apply that in a selective fashion to local variables (especially in a way that can be automated)? At first, I didn't think the goal for this should be to create a frequently used option for most end users, but I do think that it could be quite useful for more folks when debugging, especially if it is easy to automate (which optimization-fuel approaches are, while pragmas are not).

__attribute__((uninitialized)) for more selectiveness :)

Of course, not automated. In general we don't really automate compiler things of this sort, say UBSan. OptRemarks is the best we really have to dig into these things. One other option would be to truly randomize the init pattern: emit a handful of different byte patterns, and then see the crash caused by a different pattern, and track it back to which local variable got that byte pattern.

Apr 16 2020, 9:06 PM · Restricted Project
srhines added a comment to D77168: Add a flag to debug automatic variable initialization.

pragma clang attribute is interesting, but how do you apply that in a selective fashion to local variables (especially in a way that can be automated)? At first, I didn't think the goal for this should be to create a frequently used option for most end users, but I do think that it could be quite useful for more folks when debugging, especially if it is easy to automate (which optimization-fuel approaches are, while pragmas are not).

Apr 16 2020, 6:57 PM · Restricted Project

Apr 8 2020

srhines accepted D77746: [Driver] Default arm-linux-androideabi to -z max-page-size=4096.

Thank you for making this clear.

Apr 8 2020, 11:57 AM · Restricted Project
srhines added a comment to D77330: Consider increasing the default ARM32 max page size to 64k..

I agree with Ryan. Please update the Clang driver for this to pass this same flag for 32-bit ARM as we already pass for AArch64.

Apr 8 2020, 1:35 AM · Restricted Project, lld

Apr 3 2020

srhines added a comment to D77330: Consider increasing the default ARM32 max page size to 64k..

I should have looked more closely at the AOSP sources, because we already hard-code the expected 4KB max-page-size. We do have some crufty flags that can be cleaned up, so I'll do that instead (https://android-review.googlesource.com/c/platform/build/soong/+/1278815). :) I'll also go ahead and create/test a CL to revert the Clang driver change forcing 4KB max-page-size next week.

Apr 3 2020, 8:34 PM · Restricted Project, lld
srhines updated subscribers of D77330: Consider increasing the default ARM32 max page size to 64k..

So it turns out that the ld shipped in the NDK actually did have the 64KB max-page-size patch, so not taking this patch would change current user behavior. Thanks to @MaskRay for sharing the exact binutils patch we were looking for to verify that it has it. For that reason, this patch should be fine for our 32-bit ARM NDK users. For the platform, we'll see if we should just set the max-page-size back to 4KB explicitly in the build rules, but that shouldn't affect this CL.

Apr 3 2020, 8:02 PM · Restricted Project, lld
srhines added inline comments to D77283: scudo: Add support for diagnosing memory errors when memory tagging is enabled..
Apr 3 2020, 9:40 AM · Restricted Project
srhines added a comment to D77330: Consider increasing the default ARM32 max page size to 64k..

We (Android Google folks) have an internal thread going on about what implications this might have, but I can say that I am concerned about making this kind of change for ARM Android targets. Even though we manually set a 4KB max page size in our platform builds for 32-bit, we also have to consider the needs of NDK developers (i.e. those folks making native applications/games/etc.). Some of their build configurations might behave very differently with this change, so my current thinking is that 64KB should not be the default for ARM Android targets.

Apr 3 2020, 1:34 AM · Restricted Project, lld

Apr 1 2020

srhines added a comment to D77168: Add a flag to debug automatic variable initialization.
In D77168#1955312, @jfb wrote:

Do you not think pragma is a more general approach? That's what's used in a bunch of other cases, and I'd like to see it attempted here.
If not, I agree with John that just counting up isn't a good bisection experience. I'd rather see a begin / end bound.

Apr 1 2020, 11:31 AM · Restricted Project

Mar 31 2020

srhines added a comment to D77168: Add a flag to debug automatic variable initialization.
In D77168#1953635, @jfb wrote:

I'm not sure this is a good idea at all. We want to keep the codepath as simple as possible to avoid introducing bugs. If a codebase sees a crash then it's easier to bisect one function at a time than doing something like this. I'd much rather see bisection using pragma to apply the uninitialized attribute to multiple declarations.

Mar 31 2020, 6:12 PM · Restricted Project

Mar 30 2020

srhines accepted D77100: [SelectionDAGISel] small cleanup to INLINEASM_BR selection. NFC.
Mar 30 2020, 3:51 PM · Restricted Project

Mar 26 2020

srhines added a comment to D76452: Use LLD by default for Android..

Another approach will be -DCLANG_DEFAULT_LINKER=lld. It provides a default value for -fuse-ld=.

How does that work for Darwin builds? Is lld fully supported for MachO at this point, or will Clang still choose to use the preferred Apple linker?

I am not clear about your use case. lld can be used as ELF/Mach-O/COFF/WebAssembly linker. If you want to build ELF objects, -fuse-ld=lld (via clangDriver) or configure clang with -DCLANG_DEFAULT_LINKER=lld.
If you want to build Mach-O objects, lld's current Mach-O port lacks features (and will be removed). The new Mach-O port is still under development.

Mar 26 2020, 3:14 PM · Restricted Project
srhines added a comment to D76452: Use LLD by default for Android..

Another approach will be -DCLANG_DEFAULT_LINKER=lld. It provides a default value for -fuse-ld=.

Mar 26 2020, 1:02 PM · Restricted Project

Mar 20 2020

srhines accepted D76452: Use LLD by default for Android..

Thanks, Dan, for setting this up.

Mar 20 2020, 1:00 PM · Restricted Project

Feb 27 2020

srhines added inline comments to D75238: [DAGCombine] Fix alias analysis for unaligned accesses.
Feb 27 2020, 11:46 AM · Restricted Project

Feb 14 2020

srhines added inline comments to D74375: [ELF] Support INSERT [AFTER|BEFORE] for orphan sections.
Feb 14 2020, 7:55 AM · Restricted Project

Dec 10 2019

srhines added a reviewer for D70800: Fix AArch64 AAPCS frame record chain: cferris.
Dec 10 2019, 9:23 AM · Restricted Project

Nov 6 2019

srhines added a comment to D69925: remove redundant LLVM version from version string when setting CLANG_VENDOR.

I think the reason it's written this way is that CLANG_VERSION_STRING might not correspond to an LLVM version? For example, Apple has its own versioning scheme.

Nov 6 2019, 6:53 PM · Restricted Project

Oct 25 2019

srhines added inline comments to D69418: [llvm-ar] Add output option for extract operation.
Oct 25 2019, 3:35 PM · Restricted Project

Oct 17 2019

srhines accepted D68972: [libunwind][Android] Fix findUnwindSections for ARM EHABI Bionic.
Oct 17 2019, 3:15 PM · Restricted Project, Restricted Project, Restricted Project

Oct 4 2019

srhines added a comment to D68269: [libc++abi] Do not define new/delete by default.

If the Android and FreeBSD folks are ok with this, I'm fine with it

Fine for Android for at least the platform and the NDK (we don't actually build with CMake in those cases). +srhines just in case there's another case I don't know about.

Oct 4 2019, 1:08 PM · Restricted Project

Sep 9 2019

srhines accepted D67364: [Driver] Handle default case in refactored addOpenMPRuntime.
Sep 9 2019, 12:47 PM · Restricted Project, Restricted Project
srhines accepted D67364: [Driver] Handle default case in refactored addOpenMPRuntime.
Sep 9 2019, 12:42 PM · Restricted Project, Restricted Project

Sep 5 2019

srhines accepted D67200: Add -static-openmp driver option.

Looks really nice. I am sure the NDK developers will be happy to see support for static OpenMP. Do you want to add the public NDK github issue link in the commit message?

Sep 5 2019, 5:51 PM · Restricted Project, Restricted Project

Sep 4 2019

srhines committed rL371011: Request commit access for srhines.
Request commit access for srhines
Sep 4 2019, 8:15 PM
srhines added a comment to D67196: [Verifier] add invariant check for callbr.

LGTM, but please wait for someone more familiar with LangRef policies to review that part.

Sep 4 2019, 7:47 PM · Restricted Project
srhines added inline comments to D67196: [Verifier] add invariant check for callbr.
Sep 4 2019, 3:56 PM · Restricted Project

Aug 29 2019

srhines added a comment to D64666: [Sema] Enable -Wimplicit-int-float-conversion for integral to floating point precision loss.

@ziangwan maybe you should add this improvement to the release notes, wdyt?

Aug 29 2019, 1:58 PM · Restricted Project, Restricted Project

Aug 26 2019

srhines accepted D66689: [Platform/Android] Read the adb server from an env variable if set.

Thanks for improving this for LLDB and Android.

Aug 26 2019, 3:16 PM · Restricted Project

Aug 6 2019

srhines added inline comments to D65822: Detect HAVE_SYS_TYPES_H in lldb.
Aug 6 2019, 12:43 PM · Restricted Project, Restricted Project

Jul 12 2019

srhines added a comment to D64666: [Sema] Enable -Wimplicit-int-float-conversion for integral to floating point precision loss.

You have patch.patch in the diff above. You should drop that.

Jul 12 2019, 2:23 PM · Restricted Project, Restricted Project
srhines added a comment to D64655: [Clang][Driver] don't error for unsupported as options for -no-integrated-as.

s/integrates/integrated in the title, but otherwise this looks good.

Jul 12 2019, 12:38 PM · Restricted Project
srhines added inline comments to D64427: [Test-Suite] Support Cross-Compilation and Cross-execution targeting arm64-linux-android.
Jul 12 2019, 3:41 AM · Restricted Project
srhines added inline comments to D64427: [Test-Suite] Support Cross-Compilation and Cross-execution targeting arm64-linux-android.
Jul 12 2019, 3:41 AM · Restricted Project

Jul 3 2019

srhines added inline comments to D64118: [lldb_test_suite] Fix lldb test suite targeting remote Android.
Jul 3 2019, 10:41 AM · Restricted Project, Restricted Project

Jul 2 2019

srhines added inline comments to D64101: [LoopUnroll] fix cloning callbr.
Jul 2 2019, 5:38 PM · Restricted Project
srhines added a reviewer for D64089: [Driver] Introduce -stdlib++-isystem: danalbert.
Jul 2 2019, 11:07 AM · Restricted Project, Restricted Project

Jun 25 2019

srhines accepted D63774: android: enable double-word CAS on x86_64.

Craig, can you confirm that this is acceptable? I don't think there are any chips with SSE4.2 but without cx16, so this just seemed like an oversight. It might be a good idea to really audit the list of possible CPU features for other missing inclusions. Another idea would be to set a baseline minimum CPU for Android, which would cut down on having to specify so many features separately.

Jun 25 2019, 9:57 AM · Restricted Project

Jun 3 2019

srhines added a comment to rGb8fee677bf8e: Re-check in clang support gun asm goto after fixing tests..

FYI, https://reviews.llvm.org/D56571 is the review where this was accepted.

Jun 3 2019, 4:35 PM
srhines updated subscribers of rGb8fee677bf8e: Re-check in clang support gun asm goto after fixing tests..
Jun 3 2019, 4:35 PM

May 31 2019

srhines added inline comments to D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module..
May 31 2019, 1:09 PM · Restricted Project, Restricted Project, Restricted Project
srhines added inline comments to D61967: [clang-tidy] Add a close-on-exec check on pipe() in Android module..
May 31 2019, 1:05 PM · Restricted Project, Restricted Project, Restricted Project

May 30 2019

srhines added inline comments to D62555: [TailDuplicator] prevent tail duplication for INLINEASM_BR.
May 30 2019, 5:12 PM · Restricted Project

May 29 2019

srhines accepted D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module..

Everything looks great. Thanks for adding these improvements. While it's probably safe to commit this, perhaps you should give it 24 hours in case some of the other clang-tidy folks have different style or testing concerns.

May 29 2019, 4:00 PM · Restricted Project, Restricted Project, Restricted Project
srhines added inline comments to D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module..
May 29 2019, 3:11 PM · Restricted Project, Restricted Project, Restricted Project

May 23 2019

srhines added inline comments to D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module..
May 23 2019, 11:06 AM · Restricted Project, Restricted Project, Restricted Project

May 21 2019

srhines accepted D62218: [docs][cmake] document LLVM_ENABLE_PLUGINS.
May 21 2019, 2:34 PM · Restricted Project
srhines added inline comments to D62218: [docs][cmake] document LLVM_ENABLE_PLUGINS.
May 21 2019, 2:21 PM · Restricted Project
srhines added inline comments to D62218: [docs][cmake] document LLVM_ENABLE_PLUGINS.
May 21 2019, 2:12 PM · Restricted Project
srhines accepted D57930: [Driver] Verify GCCInstallation is valid.

Thanks for picking this up and finishing it.

May 21 2019, 2:04 PM · Restricted Project
srhines added inline comments to D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module..
May 21 2019, 11:25 AM · Restricted Project, Restricted Project, Restricted Project
srhines added inline comments to D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module..
May 21 2019, 1:00 AM · Restricted Project, Restricted Project, Restricted Project

May 17 2019

srhines accepted D62055: [ARM][AArch64] Revert Android Bionic PT_TLS overaligning hack.

The revert is fine with me, although I still would like Ryan to follow up on verifying that the suggested fix for Bionic will indeed work for all cases. I think it is fine for you to merge now to unbreak things for everyone else though. Thanks for working through the problem.

May 17 2019, 7:54 PM · Restricted Project
srhines added a comment to D61931: [Driver] Use --android-tls for Android ARM/AArch64 when lld is used.

This LGTM if Ryan is happy with it. Thanks for taking care of getting a workaround implemented until this can be fixed.

May 17 2019, 11:21 AM · Restricted Project

May 16 2019

srhines updated subscribers of D61967: [clang-tidy] Add a close-on-exec check on pipe() in Android module..
May 16 2019, 1:14 PM · Restricted Project, Restricted Project, Restricted Project

Apr 30 2019

srhines added inline comments to D58260: [INLINER] allow inlining of blockaddresses if sole uses are callbrs.
Apr 30 2019, 12:02 AM · Restricted Project

Apr 26 2019

srhines added inline comments to D61201: [LLD][ELF] Full support for -n (--nmagic) and -N (--omagic).
Apr 26 2019, 10:50 AM
srhines added a comment to D61201: [LLD][ELF] Full support for -n (--nmagic) and -N (--omagic).

I had just a few small suggestions to make things more consistent. Feel free to ignore my fallthrough comment, but I feel like -Wimplicit-fallthrough has been quite valuable in Android.

Apr 26 2019, 10:43 AM

Apr 20 2019

srhines added a comment to D60927: [llvm-objdump] Switch between ARM/Thumb based on mapping symbols..

I added Peter and Oliver since they might have some suggestions here too.

Apr 20 2019, 11:17 AM · Restricted Project
srhines updated subscribers of D60927: [llvm-objdump] Switch between ARM/Thumb based on mapping symbols..
Apr 20 2019, 11:17 AM · Restricted Project

Apr 17 2019

srhines accepted D60840: [AArch64][MC] Reject "add x0, x1, w2, lsl #1" etc..

Thanks for taking a look at this.

Apr 17 2019, 6:15 PM · Restricted Project

Apr 16 2019

srhines accepted D60805: [builtins] Add __cmpsf2 for ARM version of comparesf2.

Thanks for finding this. Note that this is the exact code in comparesf2.c.

Apr 16 2019, 6:04 PM · Restricted Project, Restricted Project

Apr 11 2019

srhines added a comment to D60577: [X86AsmPrinter] refactor static functions into private methods. NFC.

I have zero context on this change specifically, but "we should prefer functions in a private namespace" seems to be the exact opposite of the advice in https://llvm.org/docs/CodingStandards.html#static

Apr 11 2019, 3:13 PM · Restricted Project

Apr 4 2019

srhines accepted rG5d289ed3fee3: [test] Specify an explicit darwin version in a triple in `test/Driver/debug….

Thank you for fixing this quickly!

Apr 4 2019, 6:48 PM
srhines committed rG1ee8876d3d70: Verify that Android targets generate DWARF 4 by default. (authored by srhines).
Verify that Android targets generate DWARF 4 by default.
Apr 4 2019, 11:17 AM
srhines committed rC357713: Verify that Android targets generate DWARF 4 by default..
Verify that Android targets generate DWARF 4 by default.
Apr 4 2019, 11:17 AM
srhines committed rL357713: Verify that Android targets generate DWARF 4 by default..
Verify that Android targets generate DWARF 4 by default.
Apr 4 2019, 11:16 AM
srhines closed D60238: Verify that Android targets generate DWARF 4 by default..
Apr 4 2019, 11:16 AM · Restricted Project, Restricted Project

Apr 3 2019

srhines added inline comments to D60238: Verify that Android targets generate DWARF 4 by default..
Apr 3 2019, 4:53 PM · Restricted Project, Restricted Project
srhines created D60238: Verify that Android targets generate DWARF 4 by default..
Apr 3 2019, 4:06 PM · Restricted Project, Restricted Project
srhines updated subscribers of D60238: Verify that Android targets generate DWARF 4 by default..
Apr 3 2019, 4:06 PM · Restricted Project, Restricted Project

Apr 1 2019

srhines added a comment to D60059: [Driver] implement -feverything.

In addition to -fno-everything, don't forget about -fnothing and -fno-nothing, which seem like they would also be nice to have.

Apr 1 2019, 8:56 AM · Restricted Project, Restricted Project

Mar 29 2019

srhines accepted D53344: [Driver] Use --warn-shared-textrel for Android..
Mar 29 2019, 11:04 AM · Restricted Project

Mar 25 2019

srhines accepted D59807: Fix nondeterminism introduced in r353954.

@jmorse can I get your approval on this CL before we submit it? Thanks.

Mar 25 2019, 11:45 PM · Restricted Project
srhines added a comment to D57694: [DebugInfo][DAG] Either salvage dangling debug info or emit Undef DBG_VALUEs.

https://reviews.llvm.org/D59807 has the fix for the nondeterminism. Thanks for the hints about the reverse iteration order. That helps make it more likely to fail deterministically, but it still runs a small chance of "passing" if the fix isn't there.

Mar 25 2019, 11:41 PM · Restricted Project
srhines added a comment to D57694: [DebugInfo][DAG] Either salvage dangling debug info or emit Undef DBG_VALUEs.

Switching it to a MapVector makes it deterministic. I was just struggling late last night to try to reduce the .ll file down to something worth checking in! If you want to take over to minimize the test case, that would be much appreciated. Let me know so I can continue doing that if needed. Thanks.

Mar 25 2019, 8:11 AM · Restricted Project

Mar 23 2019

srhines added a comment to D57694: [DebugInfo][DAG] Either salvage dangling debug info or emit Undef DBG_VALUEs.

This patch appears to generate non-reproducible builds in some cases. I can craft a more minimal test case, but the following link (https://godbolt.org/z/sWucUZ) is what I have been using. If I run Clang multiple times, the output eventually swaps the order of some undef DEBUG_VALUE's. I am just passing "-O1 -g" with that .ii file. It isn't obvious to me yet what is causing this to be unordered/non-deterministic.

Mar 23 2019, 9:44 AM · Restricted Project