Dan, this seems pretty important for the NDK. If you submit this, would you want it cherry-picked ASAP?

I asked Chris to comment here about libunwindstack. Hopefully we can get the problem fixed, but I think this workaround might be necessary for code running on older devices in any case (i.e. NDK apps).

Very cool, thank you for coming up with a great way to improve this case.

Would it be reasonable to have a test for this with perhaps an invalid GCC installation? There is some mock GCC/sysroot testing in https://github.com/llvm/llvm-project/blob/master/clang/test/Driver/android-gcc-toolchain.c and https://github.com/llvm/llvm-project/blob/master/clang/test/Driver/android-ndk-standalone.cpp. I am not sure that it will be easy to trip this same bug that way, but I think it is possible.

LGTM for removing the broken Android builders.

In D36806#1385936, @lhames wrote:

Looks like this was LGTM'd but never applied. Stephen -- do you have commit access?

Sorry about the delay.

Craig, does this look ok now?

In D55029#1312167, @ruiu wrote:

I wouldn't rush to submit this now, given that this issue is not new at all. Maybe we can just wait for Peter's response?

Thanks Zhizhou! I'm curious about Peter's answer to the 64KiB default as well, but I think we should move forward with getting this patch submitted.

I just wanted to follow up here.

Yabin did some of the work to bring TSan to Android. Perhaps he knows whether this is has significant use. Considering that it is meant as a debugging aide, I would actually be comfortable with moving it. You are also correct that we never officially marked it as a feature of the NDK (or platform). That is something we want to do though.

LGTM, but please wait for dberris approval.

Please remove the reference to b/X in the commit message. LLVM doesn't allow internal bug numbers, and you described the issue well enough without it.

This LGTM, but we should wait to hear from Kristof before submitting.

Really cool! Thanks for making everything easier to use out-of-the-box.

+enh and danalbert - in case they have any other concerns about this (Ryan's already on the review). From my perspective, everything here makes sense for resolving this issue.

Thanks @dblaikie for the quick fixup. I must have accidentally dropped the '!', because I did run check-all to test the change.

In D52191#1238628, @dblaikie wrote:

Sure, looks good. Though my other/vague concern is why does this case error about fomit-frame-pointer having no effect, but other things (like using -fomit-frame-pointer on a target that requires frame pointers) that ignore -fomit-frame-pointer don't? Weird. But it probably makes sense somehow.

+Ryan in case there is anything here that could affect Bionic loading from these pages.

Thanks again! @alexshap feel free to submit this or I can do it in the morning tomorrow (can't stay up any later to watch for unlikely breakage, etc.).

Thanks for noticing this missing feature, as well as for the patch! You really should add a simple test to test/tools/llvm-objcopy/strip-all-gnu.test so that this doesn't ever regress. The test strip-all-and-keep-symbol.test is an example that has multiple RUN lines. Here is what you need to change the strip-all-gnu.test to (I believe) in order to get this working:

In D51713#1232414, @manojgupta wrote:

What is the call generated with -pg for AMR32, gnu_mcount_nc or _mount? gnu_mcount_nc with "-pg" is known to be broken ( https://bugs.llvm.org/show_bug.cgi?id=33845)

Union punning is one of my pet peeves, so I am glad to see this. bit_cast seems generally useful too, so thanks for adding it.

Thanks for the update. I'll let the project maintainers give a final LGTM, but I'm happy with it.

http://b/32510864 was the internal bug request, so I am noting it here for future reference, but I think that the patch itself is pretty self-explanatory (rather than filing a distinct upstream bug about this issue).

This was discovered in the Android build system (which passes -fomit-frame-pointer by default for ARM configurations. This leads to the inability to specify -pg, since there is no way to override the mere presence of -fomit-frame-pointer.

Thanks for the detailed explanations. I only had one minor nitpick.

Please upload patches with context, as it makes it easier to review. https://llvm.org/docs/Phabricator.html has instructions on how to do this (search for "context").

Thanks for cleaning this up and adding better checks for Android. :)

Sorry, this got buried in my inbox back in April right before EuroLLVM.

In D49534#1177242, @alexshap wrote:

@srhines - is there anything blocking this diff ?

Definitely deal with the submodule stuff. We don't want a new file checked in for tools/clang.

I restored the original change, since I had confused things with arcanist before. PTAL

Revert back to not layering the positional argument change.

Gah, you are correct. Our Android build system had grown to depend on this behavior from llvm-strip previously. Doing an update now is how I am finding all of these issues. I'll fix it in our build system and abandon this CL. Thanks for the review.

Switch to using .back() because I was lazy in the first upload. :)

• Fix positional output argument for llvm-strip.

Ran git-clang-format and added rationale to the test.

Thanks for the quick review.

https://reviews.llvm.org/D47100 is the commit where this got dropped.

Removed this in favor of the suggestions here. Setting the CMAKE_FIND_ROOT_PATH_MODE* variables does make this properly hermetic.