Page MenuHomePhabricator
People kees

kees (Kees Cook)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 6 2019, 5:35 AM (31 w, 4 d)

Recent Activity
View All

Aug 15 2019

kees added a comment to D63260: [Attr] Support _attribute__ ((fallthrough)).

For latest version see https://reviews.llvm.org/D64838

Aug 15 2019, 11:08 AM · Restricted Project

Aug 9 2019

kees added a comment to D65629: cfi-icall: Allow the jump table to be optionally made non-canonical..

Just FYI, I can confirm a happily running arm64 kernel with CFI enabled built with this patch series. The C wrappers aren't needed and CFI is still triggering on mismatches:

Aug 9 2019, 1:00 AM · Restricted Project, Restricted Project

May 30 2019

kees added a comment to D56571: [RFC prototype] Implementation of asm-goto support in clang.

Nick points out that "REQUIRES: x86-registered-target" is likely not needed.

May 30 2019, 12:14 PM
kees added inline comments to D56571: [RFC prototype] Implementation of asm-goto support in clang.
May 30 2019, 11:21 AM

May 22 2019

kees committed rGc2187c20a461: [TargetLowering] Extend bool args to inline-asm according to getBooleanType (authored by kees).
[TargetLowering] Extend bool args to inline-asm according to getBooleanType
May 22 2019, 9:16 AM
kees committed rL361404: [TargetLowering] Extend bool args to inline-asm according to getBooleanType.
[TargetLowering] Extend bool args to inline-asm according to getBooleanType
May 22 2019, 9:16 AM
kees closed D60224: [TargetLowering] Extend bool args to inline-asm according to getBooleanType.
May 22 2019, 9:16 AM · Restricted Project
kees committed rGa7a687e50004: [TargetLowering] Add blank line (test commit) (authored by kees).
[TargetLowering] Add blank line (test commit)
May 22 2019, 9:00 AM
kees committed rL361403: [TargetLowering] Add blank line (test commit).
[TargetLowering] Add blank line (test commit)
May 22 2019, 8:59 AM

May 20 2019

kees updated the diff for D60224: [TargetLowering] Extend bool args to inline-asm according to getBooleanType.

Rebasing to monorepo...

May 20 2019, 5:02 PM · Restricted Project

May 18 2019

kees updated the summary of D60224: [TargetLowering] Extend bool args to inline-asm according to getBooleanType.
May 18 2019, 9:40 AM · Restricted Project
kees updated the diff for D60224: [TargetLowering] Extend bool args to inline-asm according to getBooleanType.

Rebased to latest LLVM

May 18 2019, 9:24 AM · Restricted Project

Apr 5 2019

kees accepted D60306: Fix -emit-reloc against local symbols..

I can confirm this fixes the Linux kernel relocation visibility problem I saw. Thank you!

Apr 5 2019, 8:55 AM · Restricted Project

Apr 3 2019

kees added a comment to D60224: [TargetLowering] Extend bool args to inline-asm according to getBooleanType.

Should I respin to make booleans always zero extended? I can adjust the X86 code at the same time...

Apr 3 2019, 4:28 PM · Restricted Project
kees added a comment to D60208: [X86] Extend boolean arguments to inline-asm according to getBooleanType.

For the non-X86 case: https://reviews.llvm.org/D60224

Apr 3 2019, 12:23 PM · Restricted Project
kees added a comment to D60224: [TargetLowering] Extend bool args to inline-asm according to getBooleanType.

For note, this is based on https://reviews.llvm.org/D60208

Apr 3 2019, 12:22 PM · Restricted Project
kees created D60224: [TargetLowering] Extend bool args to inline-asm according to getBooleanType.
Apr 3 2019, 12:20 PM · Restricted Project
kees added a comment to D60208: [X86] Extend boolean arguments to inline-asm according to getBooleanType.

What other target have their own lowering code? (Or, restated, is x86 the only target not using the generic lowering code?)

Apr 3 2019, 11:08 AM · Restricted Project

Feb 6 2019

kees added a comment to D53765: [RFC prototype] Implementation of asm-goto support in LLVM.
In D53765#1386975, @kees wrote:

I found a weird mis-compilation bug. Not sure if in LLVM or Clang half. Details here: https://reviews.llvm.org/D56571#1386973

Feb 6 2019, 11:16 PM · Restricted Project
kees added a comment to D56571: [RFC prototype] Implementation of asm-goto support in clang.
In D56571#1386973, @kees wrote:

Not sure if this is the fault of the LLVM half or the Clang half, but I'm seeing mis-compilations in the current patches (llvm ca1e713fdd4fab5273b36ba6f292a844fca4cb2d with D53765.185490 and clang 01879634f01bdbfac4636ebe03b68e85b20cd664 with D56571.185489). My earlier builds were okay (llvm b1650507d25d28a03f30626843b7b133796597b4 with D53765.183738 and clang 61738985ebe78eeff6cfae7f97543d3456bac25a with D56571.181973).

Feb 6 2019, 11:15 PM
kees added a comment to D56571: [RFC prototype] Implementation of asm-goto support in clang.

I reduced the C code to this:

Feb 6 2019, 7:43 AM
kees added a comment to D53765: [RFC prototype] Implementation of asm-goto support in LLVM.

I found a weird mis-compilation bug. Not sure if in LLVM or Clang half. Details here: https://reviews.llvm.org/D56571#1386973

Feb 6 2019, 5:56 AM · Restricted Project
kees added a comment to D56571: [RFC prototype] Implementation of asm-goto support in clang.

Not sure if this is the fault of the LLVM half or the Clang half, but I'm seeing mis-compilations in the current patches (llvm ca1e713fdd4fab5273b36ba6f292a844fca4cb2d with D53765.185490 and clang 01879634f01bdbfac4636ebe03b68e85b20cd664 with D56571.185489). My earlier builds were okay (llvm b1650507d25d28a03f30626843b7b133796597b4 with D53765.183738 and clang 61738985ebe78eeff6cfae7f97543d3456bac25a with D56571.181973).

Feb 6 2019, 5:55 AM