This is an archive of the discontinued LLVM Phabricator instance.

[PatternMatch] Big mechanical rename OwningRewritePatternList -> RewritePatternSet and insert -> add. NFC
ClosedPublic

Authored by lattner on Mar 22 2021, 5:00 PM.

Details

Summary

This doesn't change APIs, this just cleans up the many in-tree uses of these
names to use the new preferred names. We'll keep the old names around for a
couple weeks to help transitions.

Diff Detail

Event Timeline

lattner created this revision.Mar 22 2021, 5:00 PM
lattner requested review of this revision.Mar 22 2021, 5:00 PM
rriddle accepted this revision.Mar 22 2021, 5:11 PM

Looks good! (Didn't look at all of them, but I trust that you renamed+clang-formatted correctly).

Can you also update the naming of https://github.com/llvm/llvm-project/blob/main/mlir/include/mlir/Rewrite/FrozenRewritePatternList.h for consistency while you are at it?

Sounds good, I'll update that in a separate patch.

Sounds good, I'll update that in a separate patch.

Great, thanks!

This revision was not accepted when it landed; it landed in state Needs Review.Mar 22 2021, 5:21 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.