Page MenuHomePhabricator

silvas (Sean Silva)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 20 2012, 11:51 AM (398 w, 1 d)

Recent Activity

Today

silvas added a comment to D77067: [mlir][Linalg] Create a tool to generate named Linalg ops from a Tensor Comprehensions-like specification..

Does this help mitigate your position?

Tue, Apr 7, 11:57 AM · Restricted Project

Yesterday

silvas added inline comments to D77067: [mlir][Linalg] Create a tool to generate named Linalg ops from a Tensor Comprehensions-like specification..
Mon, Apr 6, 8:44 PM · Restricted Project
silvas added a comment to D77067: [mlir][Linalg] Create a tool to generate named Linalg ops from a Tensor Comprehensions-like specification..

@nicolasvasilache any progress on reusing the MLIR parser? I consider that refactoring as blocking for submitting this patch. I don't want us to have a custom parser copypasted here that somebody has to clean up later without a strong reason.

Mon, Apr 6, 8:44 PM · Restricted Project
silvas added a comment to D77067: [mlir][Linalg] Create a tool to generate named Linalg ops from a Tensor Comprehensions-like specification..

meta-point: @ftynse let's not review the core parser code at the top of the file, as Nicolas says that they are just copypasta from the .mlir parser and won't be in the final patch.

Mon, Apr 6, 8:10 PM · Restricted Project

Fri, Apr 3

silvas requested changes to D77067: [mlir][Linalg] Create a tool to generate named Linalg ops from a Tensor Comprehensions-like specification..

First round of comments.

Fri, Apr 3, 5:53 PM · Restricted Project

Mon, Mar 30

silvas added a comment to D77067: [mlir][Linalg] Create a tool to generate named Linalg ops from a Tensor Comprehensions-like specification..

Do you intend for this to be "approaching production quality code" and reviewed as such or still proof-of-concept level?

Mon, Mar 30, 7:41 PM · Restricted Project
silvas added inline comments to D77067: [mlir][Linalg] Create a tool to generate named Linalg ops from a Tensor Comprehensions-like specification..
Mon, Mar 30, 7:41 PM · Restricted Project

Sat, Mar 28

silvas added a comment to D75837: [MLIR] Introduce std.execute_region op.

Presumably yield should replace the linalg and loop yields? I would add std.yield in a separate patch that refactors the other dialects to use it as well.

Sat, Mar 28, 9:07 AM · Restricted Project

Fri, Mar 27

silvas committed rG66774771903a: Verify number of result types in generated builder. (authored by silvas).
Verify number of result types in generated builder.
Fri, Mar 27, 8:24 PM
silvas closed D76888: Verify number of result types in generated builder..
Fri, Mar 27, 8:23 PM · Restricted Project
silvas committed rG569e4f9bc99a: `shape` dialect: add some ops (authored by silvas).
`shape` dialect: add some ops
Fri, Mar 27, 5:07 PM
silvas closed D76817: `shape` dialect: add some ops.
Fri, Mar 27, 5:06 PM · Restricted Project
silvas added inline comments to D76817: `shape` dialect: add some ops.
Fri, Mar 27, 4:32 PM · Restricted Project

Thu, Mar 26

silvas added inline comments to D76817: `shape` dialect: add some ops.
Thu, Mar 26, 7:02 PM · Restricted Project
silvas added inline comments to D76817: `shape` dialect: add some ops.
Thu, Mar 26, 5:57 PM · Restricted Project
silvas updated the summary of D76817: `shape` dialect: add some ops.
Thu, Mar 26, 3:47 PM · Restricted Project
silvas updated the summary of D76817: `shape` dialect: add some ops.
Thu, Mar 26, 3:18 PM · Restricted Project
silvas updated the diff for D76817: `shape` dialect: add some ops.

Update description

Thu, Mar 26, 3:17 PM · Restricted Project
silvas created D76888: Verify number of result types in generated builder..
Thu, Mar 26, 3:14 PM · Restricted Project
silvas updated the diff for D76817: `shape` dialect: add some ops.

Address comments.

Thu, Mar 26, 3:14 PM · Restricted Project
silvas committed rG3dceb6d24605: Allow IndexType inside tensors. (authored by silvas).
Allow IndexType inside tensors.
Thu, Mar 26, 11:23 AM
silvas closed D76726: Allow IndexType inside tensors..
Thu, Mar 26, 11:23 AM · Restricted Project

Wed, Mar 25

silvas abandoned D21047: [clang] Documentation fixes for LibASTMatchersTutorial.
Wed, Mar 25, 6:58 PM
silvas resigned from D12715: Reduce PGO Instrumentation binary and profile data size (Patch-1).
Wed, Mar 25, 6:58 PM
silvas resigned from D13327: Add Buck and xctool to json compilation database docs.
Wed, Mar 25, 6:58 PM
silvas resigned from D15829: [PGO] Clang Option that enables IR level PGO instrumentation .
Wed, Mar 25, 6:58 PM
silvas resigned from D12717: Reduce PGO Instrumentation binary and profile data size (Patch-3).
Wed, Mar 25, 6:58 PM
silvas resigned from D12716: Reduce PGO Instrumentation binary and profile data size (Patch-2).
Wed, Mar 25, 6:58 PM
silvas resigned from D56569: [ObjectYAML][yaml2obj][ELF] Add basic support for dynamic entries.
Wed, Mar 25, 6:58 PM · Restricted Project
silvas resigned from D55601: [bugpoint] Add ability to reduce to zero elements.
Wed, Mar 25, 6:58 PM · Restricted Project
silvas resigned from D33332: Possible typo in ProgrammersManual documentation.
Wed, Mar 25, 6:58 PM
silvas resigned from D29999: [InlineFunction] add nonnull assumptions based on argument attributes.
Wed, Mar 25, 6:58 PM
silvas closed D27155: Merge strings using concurrent hash map (3rd try!).

we landed a different version of this IIRC. Closing diff.

Wed, Mar 25, 6:58 PM
silvas closed D27152: Merge strings using sharded hash tables..

we landed a different version of this IIRC

Wed, Mar 25, 6:58 PM
silvas commandeered D21047: [clang] Documentation fixes for LibASTMatchersTutorial.
Wed, Mar 25, 6:58 PM
silvas resigned from D21047: [clang] Documentation fixes for LibASTMatchersTutorial.
Wed, Mar 25, 6:58 PM
silvas abandoned D21921: [proof of concept] Port old PM CGSCC visitation logic to new PM.
Wed, Mar 25, 6:58 PM
silvas abandoned D21954: [PM] Add some internal options for testing out the new PM..
Wed, Mar 25, 6:58 PM
silvas abandoned D23256: Teach the analysis manager about inter-analysis dependencies..
Wed, Mar 25, 6:58 PM
silvas abandoned D36367: [Phab test] Testing expansion of O0 O3 etc..
Wed, Mar 25, 6:58 PM
silvas resigned from D22298: [LCG] Update and expand comments to properly document the design motivation, tradeoffs, and constraints..
Wed, Mar 25, 6:58 PM
silvas resigned from D75826: [NFC] Add lexicon definition for PHI node..
Wed, Mar 25, 6:27 PM · Restricted Project
silvas resigned from D57975: [ObjectYAML] Let dynamic entries use section names as values.
Wed, Mar 25, 6:25 PM · Restricted Project
silvas resigned from D42191: [RFC] [TargetTransformInfo] Introduce isRegisterRich, it returns true if the target architecture is register-rich..
Wed, Mar 25, 6:25 PM
silvas resigned from D35559: [CMake][Modules] Tweak Modules-unfriendly builds.
Wed, Mar 25, 6:25 PM
silvas resigned from D31305: Added clang-expand to list of external clang tools.
Wed, Mar 25, 6:25 PM
silvas created D76817: `shape` dialect: add some ops.
Wed, Mar 25, 6:25 PM · Restricted Project

Tue, Mar 24

silvas added a comment to D76726: Allow IndexType inside tensors..

Thanks @mehdi_amini, addressed.

Tue, Mar 24, 3:39 PM · Restricted Project
silvas updated the diff for D76726: Allow IndexType inside tensors..

update

Tue, Mar 24, 3:39 PM · Restricted Project
silvas updated the diff for D76726: Allow IndexType inside tensors..

Address comments

Tue, Mar 24, 3:39 PM · Restricted Project
silvas updated the diff for D76726: Allow IndexType inside tensors..

Update Rationale.md

Tue, Mar 24, 3:39 PM · Restricted Project
silvas accepted D75837: [MLIR] Introduce std.execute_region op.
Tue, Mar 24, 2:00 PM · Restricted Project
silvas added a comment to D75837: [MLIR] Introduce std.execute_region op.

LGTM from me. I think the "free returnop from funcop" discussion could go on for a while, so I would encourage you to introduce a new terminator for now so that we can land this.

Tue, Mar 24, 2:00 PM · Restricted Project
silvas updated the diff for D76726: Allow IndexType inside tensors..

Fix extraneous stuff in the diff

Tue, Mar 24, 12:54 PM · Restricted Project
silvas created D76726: Allow IndexType inside tensors..
Tue, Mar 24, 12:54 PM · Restricted Project

Thu, Mar 19

silvas committed rGc31ee83abb0c: Add Builder::get{I32,I64}TensorAttr. (authored by silvas).
Add Builder::get{I32,I64}TensorAttr.
Thu, Mar 19, 12:00 PM
silvas closed D76403: Add Builder::get{I32,I64}TensorAttr..
Thu, Mar 19, 12:00 PM · Restricted Project
silvas updated the diff for D76403: Add Builder::get{I32,I64}TensorAttr..

Address comments

Thu, Mar 19, 11:30 AM · Restricted Project

Wed, Mar 18

silvas updated the diff for D76403: Add Builder::get{I32,I64}TensorAttr..

Fix typo

Wed, Mar 18, 10:15 PM · Restricted Project
silvas added a comment to D75837: [MLIR] Introduce std.execute_region op.

Okay, let's land this without allowing explicit captures, given that's the most restrictive semantics. We can loosen it later if there's a compelling need.

Wed, Mar 18, 10:15 PM · Restricted Project
silvas added a reviewer for D76403: Add Builder::get{I32,I64}TensorAttr.: bondhugula.
Wed, Mar 18, 8:36 PM · Restricted Project
silvas updated the diff for D76403: Add Builder::get{I32,I64}TensorAttr..

Address comments.

Wed, Mar 18, 8:36 PM · Restricted Project
silvas created D76403: Add Builder::get{I32,I64}TensorAttr..
Wed, Mar 18, 8:04 PM · Restricted Project

Tue, Mar 17

silvas accepted D76321: [mlir] Add target for Shape dialect.

LGTM after comments are addressed.

Tue, Mar 17, 2:35 PM · Restricted Project
silvas added a comment to D76321: [mlir] Add target for Shape dialect.

Thanks, this is a good start.

Tue, Mar 17, 2:02 PM · Restricted Project
silvas added a comment to D75837: [MLIR] Introduce std.execute_region op.

+1 This is also exactly what I wanted to say. If there were arguments in the land you were starting from (say you were inlining a call), those arguments should just get propagated and eliminated. Keeping arguments around will necessitate all kinds of tracking/bookkeeping in moving code across, reimplementing existing canonicalizations on this op and largely defeating the purpose of this op - which is to let SSA dominance and dataflow work freely from above and through it.

Tue, Mar 17, 2:02 PM · Restricted Project

Fri, Mar 13

silvas committed rG94f848d7b569: Add Builder::getI64VectorAttr. (authored by silvas).
Add Builder::getI64VectorAttr.
Fri, Mar 13, 3:08 PM
silvas closed D75883: Add Builder::getI64VectorAttr..
Fri, Mar 13, 3:08 PM · Restricted Project

Wed, Mar 11

silvas updated the diff for D75883: Add Builder::getI64VectorAttr..

Update for Uday's comment.

Wed, Mar 11, 3:20 PM · Restricted Project
silvas added inline comments to D75883: Add Builder::getI64VectorAttr..
Wed, Mar 11, 3:20 PM · Restricted Project
silvas accepted D75973: [mlir] Add support for non-identifier attribute names..

Nice improvement! Thanks for the quick turnaround :)

Wed, Mar 11, 9:37 AM · Restricted Project

Mon, Mar 9

silvas added a comment to D71961: [MLIR] Free ReturnOp from being restricted to a FuncOp.

All other use cases I could immediately think of actually treat 'return' the same way irrespective of whether it's inside a parent func op or an imperative one -- for eg., all region local / CFG transformations. Wouldn't that actually be an upside of reusing return? (You won't have to check for two terminators FWIW) Do you have use cases for the "something here" part below that require treating imperative and declarative parent ops of std.return differently? And I think that has to be weighed against the scenarios that require the same treatment.

Mon, Mar 9, 5:17 PM · Restricted Project
silvas added a comment to D75883: Add Builder::getI64VectorAttr..

Let me know if you want me to add a unittest. Couldn't find any intree users to update.

Mon, Mar 9, 4:45 PM · Restricted Project
silvas created D75883: Add Builder::getI64VectorAttr..
Mon, Mar 9, 4:12 PM · Restricted Project
silvas added a comment to D71961: [MLIR] Free ReturnOp from being restricted to a FuncOp.

I'd like to suggest the following though exercise. Consider the following code in a pass:

Mon, Mar 9, 12:58 PM · Restricted Project
silvas added a comment to D71961: [MLIR] Free ReturnOp from being restricted to a FuncOp.

Hi Sean, this patch already updates the verifier to work with both FuncOp and with execute_region! (see near Ops.cpp:1938) I see the change as trivial. :-) To generalize it to all func like ops, we need an op interface - but that doesn't complicate the verifier in any way.

Mon, Mar 9, 12:58 PM · Restricted Project

Mar 5 2020

silvas added a comment to D71961: [MLIR] Free ReturnOp from being restricted to a FuncOp.

FWIW, I also think that we should not use std.return for inlined_call/execute_region. I can’t think of a nontrivial verifier that we could write that would allow both that use and the more typical use in FuncOp.

Mar 5 2020, 6:35 PM · Restricted Project
silvas added a comment to D71961: [MLIR] Free ReturnOp from being restricted to a FuncOp.

Since it seems the discussion is a bit stalled, maybe I can make a suggestion.

Mar 5 2020, 6:03 PM · Restricted Project

Feb 19 2020

silvas committed rGe84aa5922b1c: Fix Block::eraseArgument when block arg is also a successor operand. (authored by silvas).
Fix Block::eraseArgument when block arg is also a successor operand.
Feb 19 2020, 9:33 AM
silvas closed D74583: Fix Block::eraseArgument when block arg is also a successor operand..
Feb 19 2020, 9:32 AM · Restricted Project

Feb 14 2020

silvas added a comment to D74583: Fix Block::eraseArgument when block arg is also a successor operand..

I couldn't think of a great way to test this. The one place I can think of that could potentially benefit from this uses updatePredTerms=false because it erases successor operands manually for other reasons:
https://github.com/llvm/llvm-project/blob/e8358455a2b662bec59bc3971c18346800d7cb00/mlir/lib/Transforms/Utils/RegionUtils.cpp#L278

Feb 14 2020, 10:12 AM · Restricted Project

Feb 13 2020

silvas created D74583: Fix Block::eraseArgument when block arg is also a successor operand..
Feb 13 2020, 4:31 PM · Restricted Project

Jan 29 2020

silvas committed rG9accbd58fb3f: Add IntegerAttr::verifyConstructionInvariants. (authored by silvas).
Add IntegerAttr::verifyConstructionInvariants.
Jan 29 2020, 12:26 PM
silvas closed D73645: Add IntegerAttr::verifyConstructionInvariants..
Jan 29 2020, 12:26 PM · Restricted Project
silvas updated the diff for D73645: Add IntegerAttr::verifyConstructionInvariants..

Fix review feeback.

Jan 29 2020, 11:03 AM · Restricted Project
silvas added a comment to D73645: Add IntegerAttr::verifyConstructionInvariants..

Fix review feedback.

Jan 29 2020, 11:03 AM · Restricted Project
silvas created D73645: Add IntegerAttr::verifyConstructionInvariants..
Jan 29 2020, 10:16 AM · Restricted Project

Dec 23 2019

A. Unique TensorFlower <gardener@tensorflow.org> committed rG553f794b6fce: Add a couple useful LLVM_DEBUG's to the inliner. (authored by silvas).
Add a couple useful LLVM_DEBUG's to the inliner.
Dec 23 2019, 9:26 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rG26484bc0b6ce: Print out large elementsattr's such that they are parseable. (authored by silvas).
Print out large elementsattr's such that they are parseable.
Dec 23 2019, 9:18 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rG82f9f9d112ca: Make diagnostic a bit clearer. (authored by silvas).
Make diagnostic a bit clearer.
Dec 23 2019, 9:18 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rG67515e8d7a3b: Verifier: Better error message in case of successor operand mismatch. (authored by silvas).
Verifier: Better error message in case of successor operand mismatch.
Dec 23 2019, 9:18 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rGe4f83c6c2690: Add multi-level DCE pass. (authored by silvas).
Add multi-level DCE pass.
Dec 23 2019, 9:16 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rG486f2122cde3: Add FuncOp::eraseArgument (authored by silvas).
Add FuncOp::eraseArgument
Dec 23 2019, 9:14 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rGf6188b5b0741: Replace some remnant uses of "inst" with "op". (authored by silvas).
Replace some remnant uses of "inst" with "op".
Dec 23 2019, 9:13 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rG9297a129b163: Rename Region::RegionType to Region::BlockListType (authored by silvas).
Rename Region::RegionType to Region::BlockListType
Dec 23 2019, 9:12 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rG66ec24d83310: Parse locations in parseGenericOperation (authored by silvas).
Parse locations in parseGenericOperation
Dec 23 2019, 9:11 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rG9c9a7e9268bd: Add support for function result attributes. (authored by silvas).
Add support for function result attributes.
Dec 23 2019, 9:10 PM

Nov 19 2019

silvas added inline comments to D70410: Tablegen: Remove the error for duplicate include files..
Nov 19 2019, 5:09 PM · Restricted Project
silvas accepted D70410: Tablegen: Remove the error for duplicate include files..

Thanks. This makes sense now that we have include guards.

Nov 19 2019, 4:59 PM · Restricted Project

Sep 11 2019

silvas committed rL371695: Request commit access for silvas.
Request commit access for silvas
Sep 11 2019, 5:03 PM