Page MenuHomePhabricator

springerm (Matthias Springer)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 13 2021, 11:39 PM (71 w, 2 d)

Recent Activity

Yesterday

springerm committed rG2f0a634c5e80: [mlir][bufferization] Add extra filter mechanism to bufferizeOp (authored by springerm).
[mlir][bufferization] Add extra filter mechanism to bufferizeOp
Fri, May 27, 7:53 PM · Restricted Project, Restricted Project
springerm closed D126569: [mlir][bufferization] Add extra filter mechanism to bufferizeOp.
Fri, May 27, 7:52 PM · Restricted Project, Restricted Project
springerm committed rGf470f8cbcefd: [mlir][bufferize][NFC] Split analysis+bufferization of ModuleBufferization (authored by springerm).
[mlir][bufferize][NFC] Split analysis+bufferization of ModuleBufferization
Fri, May 27, 7:48 PM · Restricted Project, Restricted Project
springerm closed D126572: [mlir][bufferize][NFC] Split analysis+bufferization of ModuleBufferization.
Fri, May 27, 7:47 PM · Restricted Project, Restricted Project
springerm committed rG3490aadf56c9: [mlir][bufferization][NFC] Remove post-analysis step infrastructure (authored by springerm).
[mlir][bufferization][NFC] Remove post-analysis step infrastructure
Fri, May 27, 7:40 PM · Restricted Project, Restricted Project
springerm closed D126571: [mlir][bufferization][NFC] Remove post-analysis step infrastructure.
Fri, May 27, 7:40 PM · Restricted Project, Restricted Project
springerm committed rG1534177f8f7e: [mlir][bufferization][NFC] Move OpFilter out of BufferizationOptions (authored by springerm).
[mlir][bufferization][NFC] Move OpFilter out of BufferizationOptions
Fri, May 27, 4:51 PM · Restricted Project, Restricted Project
springerm closed D126568: [mlir][bufferization][NFC] Move OpFilter out of BufferizationOptions.
Fri, May 27, 4:51 PM · Restricted Project, Restricted Project
springerm updated the diff for D126252: [mlir][bufferization] Decouple buffer-deallocation from One-Shot Bufferize.

update

Fri, May 27, 4:46 PM · Restricted Project, Restricted Project
springerm updated the summary of D126252: [mlir][bufferization] Decouple buffer-deallocation from One-Shot Bufferize.
Fri, May 27, 3:53 PM · Restricted Project, Restricted Project
springerm updated the diff for D126573: [mlir][bufferization] Add TensorCopyInsertion pass.

update

Fri, May 27, 3:52 PM · Restricted Project, Restricted Project
springerm updated the diff for D126570: [mlir][bufferization] Add optional `copy` operand to AllocTensorOp.

address comments

Fri, May 27, 3:51 PM · Restricted Project, Restricted Project
springerm requested review of D126573: [mlir][bufferization] Add TensorCopyInsertion pass.
Fri, May 27, 3:14 PM · Restricted Project, Restricted Project
springerm requested review of D126572: [mlir][bufferize][NFC] Split analysis+bufferization of ModuleBufferization.
Fri, May 27, 3:11 PM · Restricted Project, Restricted Project
springerm requested review of D126571: [mlir][bufferization][NFC] Remove post-analysis step infrastructure.
Fri, May 27, 3:10 PM · Restricted Project, Restricted Project
springerm requested review of D126570: [mlir][bufferization] Add optional `copy` operand to AllocTensorOp.
Fri, May 27, 3:08 PM · Restricted Project, Restricted Project
springerm updated the diff for D126253: [mlir][bufferize] Decouple promoteBufferResultsToOutParams from One-Shot Bufferize.

update

Fri, May 27, 3:07 PM · Restricted Project, Restricted Project
springerm updated the diff for D126252: [mlir][bufferization] Decouple buffer-deallocation from One-Shot Bufferize.

rebase

Fri, May 27, 3:06 PM · Restricted Project, Restricted Project
springerm requested review of D126569: [mlir][bufferization] Add extra filter mechanism to bufferizeOp.
Fri, May 27, 3:05 PM · Restricted Project, Restricted Project
springerm requested review of D126568: [mlir][bufferization][NFC] Move OpFilter out of BufferizationOptions.
Fri, May 27, 3:04 PM · Restricted Project, Restricted Project

Wed, May 25

springerm committed rG52698a33d031: [mlir][bufferization] Clean up imports and code comments (authored by springerm).
[mlir][bufferization] Clean up imports and code comments
Wed, May 25, 8:49 PM · Restricted Project, Restricted Project
springerm closed D126427: [mlir][bufferization] Clean up imports and code comments.
Wed, May 25, 8:49 PM · Restricted Project, Restricted Project
springerm requested review of D126427: [mlir][bufferization] Clean up imports and code comments.
Wed, May 25, 3:38 PM · Restricted Project, Restricted Project
springerm committed rGab249fd87d30: [mlir][bufferization][NFC] Remove dead code (authored by springerm).
[mlir][bufferization][NFC] Remove dead code
Wed, May 25, 1:29 PM · Restricted Project, Restricted Project
springerm closed D126414: [mlir][bufferization][NFC] Remove dead code.
Wed, May 25, 1:28 PM · Restricted Project, Restricted Project
springerm requested review of D126414: [mlir][bufferization][NFC] Remove dead code.
Wed, May 25, 1:25 PM · Restricted Project, Restricted Project
springerm committed rG0ee1c0388ca3: [mlir][bufferize] Remove hoisting functionality from One-Shot Bufferize (authored by springerm).
[mlir][bufferize] Remove hoisting functionality from One-Shot Bufferize
Wed, May 25, 10:56 AM · Restricted Project, Restricted Project
springerm closed D126251: [mlir][bufferize] Remove hoisting functionality from One-Shot Bufferize.
Wed, May 25, 10:56 AM · Restricted Project, Restricted Project
springerm accepted D126381: [mlir] Use-after-free checker for the Transform dialect.
Wed, May 25, 10:43 AM · Restricted Project, Restricted Project

Mon, May 23

springerm requested review of D126253: [mlir][bufferize] Decouple promoteBufferResultsToOutParams from One-Shot Bufferize.
Mon, May 23, 4:03 PM · Restricted Project, Restricted Project
springerm requested review of D126252: [mlir][bufferization] Decouple buffer-deallocation from One-Shot Bufferize.
Mon, May 23, 3:59 PM · Restricted Project, Restricted Project
springerm requested review of D126251: [mlir][bufferize] Remove hoisting functionality from One-Shot Bufferize.
Mon, May 23, 3:58 PM · Restricted Project, Restricted Project
springerm committed rG82c85bf38e9d: [mlir][bufferize][NFC] Update One-Shot Bufferize pass documentation (authored by springerm).
[mlir][bufferize][NFC] Update One-Shot Bufferize pass documentation
Mon, May 23, 9:53 AM · Restricted Project, Restricted Project
springerm closed D125637: [mlir][bufferize][NFC] Update One-Shot Bufferize pass documentation.
Mon, May 23, 9:53 AM · Restricted Project, Restricted Project
springerm committed rG598c5ddba6b0: [mlir][bufferize] Support fully dynamic layout maps in BufferResultsToOutParams (authored by springerm).
[mlir][bufferize] Support fully dynamic layout maps in BufferResultsToOutParams
Mon, May 23, 9:47 AM · Restricted Project, Restricted Project
springerm closed D125636: [mlir][bufferize] Support fully dynamic layout maps in BufferResultsToOutParams.
Mon, May 23, 9:47 AM · Restricted Project, Restricted Project
springerm updated the diff for D125636: [mlir][bufferize] Support fully dynamic layout maps in BufferResultsToOutParams.

address comments

Mon, May 23, 9:37 AM · Restricted Project, Restricted Project
springerm committed rG210c4e7fc887: [mlir][bufferization] Fix Python bindings (authored by springerm).
[mlir][bufferization] Fix Python bindings
Mon, May 23, 9:16 AM · Restricted Project, Restricted Project
springerm closed D126179: [mlir][bufferization] Fix Python bindings.
Mon, May 23, 9:16 AM · Restricted Project, Restricted Project
springerm added a comment to D126178: [mlir][bufferization][NFC] Improve assembly format of AllocTensorOp.

The AllocTensorOp assembly format is changes so that it matches the MemRef AllocOp format. No change to MemRefOps.td.

Mon, May 23, 7:59 AM · Restricted Project, Restricted Project
springerm committed rGec55f0bd5833: [mlir][bufferization][NFC] Improve assembly format of AllocTensorOp (authored by springerm).
[mlir][bufferization][NFC] Improve assembly format of AllocTensorOp
Mon, May 23, 7:59 AM · Restricted Project, Restricted Project
springerm closed D126178: [mlir][bufferization][NFC] Improve assembly format of AllocTensorOp.
Mon, May 23, 7:58 AM · Restricted Project, Restricted Project
springerm accepted D126182: NFC: Silence two warnings for unused bufferization symbols in release mode..
Mon, May 23, 7:48 AM · Restricted Project, Restricted Project

Sun, May 22

springerm added reviewers for D126179: [mlir][bufferization] Fix Python bindings: pifon2a, aartbik.
Sun, May 22, 5:14 PM · Restricted Project, Restricted Project
springerm updated the summary of D126179: [mlir][bufferization] Fix Python bindings.
Sun, May 22, 5:14 PM · Restricted Project, Restricted Project
springerm requested review of D126180: [mlir][sparse][NFC] Switch InitOp to bufferization::AllocTensorOp.
Sun, May 22, 5:14 PM · Restricted Project, Restricted Project
springerm requested review of D126179: [mlir][bufferization] Fix Python bindings.
Sun, May 22, 5:13 PM · Restricted Project, Restricted Project
springerm requested review of D126178: [mlir][bufferization][NFC] Improve assembly format of AllocTensorOp.
Sun, May 22, 5:12 PM · Restricted Project, Restricted Project

Fri, May 20

springerm committed rGffdbecccafdf: [mlir][bufferization] Add bufferization.alloc_tensor op (authored by springerm).
[mlir][bufferization] Add bufferization.alloc_tensor op
Fri, May 20, 5:57 PM · Restricted Project, Restricted Project
springerm closed D126003: [mlir][bufferization] Add bufferization.alloc_tensor op.
Fri, May 20, 5:57 PM · Restricted Project, Restricted Project
springerm updated the diff for D126003: [mlir][bufferization] Add bufferization.alloc_tensor op.

update

Fri, May 20, 5:44 PM · Restricted Project, Restricted Project
springerm added inline comments to D126003: [mlir][bufferization] Add bufferization.alloc_tensor op.
Fri, May 20, 5:25 PM · Restricted Project, Restricted Project
springerm updated the diff for D126003: [mlir][bufferization] Add bufferization.alloc_tensor op.

update

Fri, May 20, 9:25 AM · Restricted Project, Restricted Project
springerm added inline comments to D126003: [mlir][bufferization] Add bufferization.alloc_tensor op.
Fri, May 20, 9:15 AM · Restricted Project, Restricted Project
springerm added inline comments to D126003: [mlir][bufferization] Add bufferization.alloc_tensor op.
Fri, May 20, 8:58 AM · Restricted Project, Restricted Project
springerm added inline comments to D125637: [mlir][bufferize][NFC] Update One-Shot Bufferize pass documentation.
Fri, May 20, 7:50 AM · Restricted Project, Restricted Project

Thu, May 19

springerm requested review of D126003: [mlir][bufferization] Add bufferization.alloc_tensor op.
Thu, May 19, 11:56 AM · Restricted Project, Restricted Project

Tue, May 17

springerm committed rG996834e6813a: [mlir][SCF] Fix scf.while bufferization (authored by springerm).
[mlir][SCF] Fix scf.while bufferization
Tue, May 17, 3:38 PM · Restricted Project, Restricted Project
springerm closed D125835: [mlir][SCF] Fix scf.while bufferization.
Tue, May 17, 3:38 PM · Restricted Project, Restricted Project
springerm requested review of D125835: [mlir][SCF] Fix scf.while bufferization.
Tue, May 17, 1:59 PM · Restricted Project, Restricted Project

Mon, May 16

springerm committed rG0b293bf0451c: [mlir][bufferize] Better propagation of errors (authored by springerm).
[mlir][bufferize] Better propagation of errors
Mon, May 16, 2:17 PM · Restricted Project, Restricted Project
springerm closed D125087: [mlir][bufferize] Better propagation of errors.
Mon, May 16, 2:17 PM · Restricted Project, Restricted Project
springerm updated the diff for D125087: [mlir][bufferize] Better propagation of errors.

update

Mon, May 16, 2:09 PM · Restricted Project, Restricted Project
springerm added a reviewer for D125718: [mlir][bufferize] Improve handling of to_memref ops during analysis: hanchung.
Mon, May 16, 12:10 PM · Restricted Project, Restricted Project
springerm requested review of D125718: [mlir][bufferize] Improve handling of to_memref ops during analysis.
Mon, May 16, 12:09 PM · Restricted Project, Restricted Project
springerm committed rGf287da8a1581: [mlir][bufferize] Better user control of layout maps (authored by springerm).
[mlir][bufferize] Better user control of layout maps
Mon, May 16, 9:09 AM · Restricted Project, Restricted Project
springerm closed D125615: [mlir][bufferize] Better user control of layout maps.
Mon, May 16, 9:09 AM · Restricted Project, Restricted Project

Sun, May 15

springerm committed rG12e41d9264b6: [mlir][bufferize] Infer memref types when possible (authored by springerm).
[mlir][bufferize] Infer memref types when possible
Sun, May 15, 5:02 PM · Restricted Project, Restricted Project
springerm closed D125614: [mlir][bufferize] Infer memref types when possible.
Sun, May 15, 5:02 PM · Restricted Project, Restricted Project
springerm requested review of D125637: [mlir][bufferize][NFC] Update One-Shot Bufferize pass documentation.
Sun, May 15, 10:38 AM · Restricted Project, Restricted Project
springerm updated the diff for D125636: [mlir][bufferize] Support fully dynamic layout maps in BufferResultsToOutParams.

update

Sun, May 15, 10:26 AM · Restricted Project, Restricted Project
springerm requested review of D125636: [mlir][bufferize] Support fully dynamic layout maps in BufferResultsToOutParams.
Sun, May 15, 10:18 AM · Restricted Project, Restricted Project

Sat, May 14

springerm added a reviewer for D125614: [mlir][bufferize] Infer memref types when possible: pifon2a.
Sat, May 14, 12:44 PM · Restricted Project, Restricted Project
springerm requested review of D125615: [mlir][bufferize] Better user control of layout maps.
Sat, May 14, 12:43 PM · Restricted Project, Restricted Project
springerm requested review of D125614: [mlir][bufferize] Infer memref types when possible.
Sat, May 14, 12:42 PM · Restricted Project, Restricted Project

Fri, May 13

springerm added inline comments to D125098: [mlir][bufferization] Add OneShotBufferize transform op.
Fri, May 13, 3:09 AM · Restricted Project, Restricted Project
springerm committed rGe9fa5590971b: [mlir][sparse][NFC] Use RewriterBase/OpBuilder when possible (authored by springerm).
[mlir][sparse][NFC] Use RewriterBase/OpBuilder when possible
Fri, May 13, 2:37 AM · Restricted Project, Restricted Project
springerm closed D125466: [mlir][sparse][NFC] Use RewriterBase/OpBuilder when possible.
Fri, May 13, 2:37 AM · Restricted Project, Restricted Project
springerm added a comment to D125466: [mlir][sparse][NFC] Use RewriterBase/OpBuilder when possible.

Changes look good, and it is of course good to require the minimum required type. But is there a major advantage of doing it this way? (follow up or otherwise)?

Fri, May 13, 2:34 AM · Restricted Project, Restricted Project
springerm committed rG8f42939a0754: [mlir][bufferize][NFC] Make getContiguousMemRefType a static function (authored by springerm).
[mlir][bufferize][NFC] Make getContiguousMemRefType a static function
Fri, May 13, 2:31 AM · Restricted Project, Restricted Project
springerm closed D125361: [mlir][bufferize][NFC] Make getContiguousMemRefType a static function.
Fri, May 13, 2:31 AM · Restricted Project, Restricted Project

Thu, May 12

springerm added a reviewer for D125361: [mlir][bufferize][NFC] Make getContiguousMemRefType a static function: ingomueller-net.
Thu, May 12, 6:33 AM · Restricted Project, Restricted Project
springerm added a comment to D125466: [mlir][sparse][NFC] Use RewriterBase/OpBuilder when possible.

The dependent revisions are not needed. This is standalone.

Thu, May 12, 6:12 AM · Restricted Project, Restricted Project
springerm requested review of D125466: [mlir][sparse][NFC] Use RewriterBase/OpBuilder when possible.
Thu, May 12, 6:11 AM · Restricted Project, Restricted Project
springerm updated the diff for D125087: [mlir][bufferize] Better propagation of errors.

update

Thu, May 12, 3:33 AM · Restricted Project, Restricted Project
springerm accepted D125430: [mlir][vector] Add lowering pattern for vector.warp_execute_on_lane_0 op.
Thu, May 12, 3:15 AM · Restricted Project, Restricted Project
springerm committed rG82ea0d8b8248: [mlir][bufferize] Support alloc hoisting across function boundaries (authored by springerm).
[mlir][bufferize] Support alloc hoisting across function boundaries
Thu, May 12, 12:47 AM · Restricted Project, Restricted Project
springerm closed D125376: [mlir][bufferize] Support alloc hoisting across function boundaries.
Thu, May 12, 12:47 AM · Restricted Project, Restricted Project
springerm added a comment to D125356: [mlir][bufferize] Fix op filter.

The reported failure seems unrelated but please double-check too.
Thanks for fixing this so quickly!

Thu, May 12, 12:34 AM · Restricted Project, Restricted Project
springerm committed rG2fe40c34eaea: [mlir][bufferize] Fix op filter (authored by springerm).
[mlir][bufferize] Fix op filter
Thu, May 12, 12:33 AM · Restricted Project, Restricted Project
springerm closed D125356: [mlir][bufferize] Fix op filter.
Thu, May 12, 12:33 AM · Restricted Project, Restricted Project
springerm committed rG011f1b1c1ffb: [mlir][bufferize] Add helpers for templatized DENY filters (authored by springerm).
[mlir][bufferize] Add helpers for templatized DENY filters
Thu, May 12, 12:23 AM · Restricted Project, Restricted Project
springerm closed D125358: [mlir][bufferize] Add helpers for templatized DENY filters.
Thu, May 12, 12:23 AM · Restricted Project, Restricted Project

Wed, May 11

springerm added inline comments to D125376: [mlir][bufferize] Support alloc hoisting across function boundaries.
Wed, May 11, 7:49 AM · Restricted Project, Restricted Project
springerm updated the diff for D125376: [mlir][bufferize] Support alloc hoisting across function boundaries.

address comments

Wed, May 11, 7:49 AM · Restricted Project, Restricted Project
springerm committed rG248e113e9f6e: [mlir][bufferize][NFC] Move helper functions to BufferizationOptions (authored by springerm).
[mlir][bufferize][NFC] Move helper functions to BufferizationOptions
Wed, May 11, 7:24 AM · Restricted Project, Restricted Project
springerm closed D125375: [mlir][bufferize][NFC] Move helper functions to BufferizationOptions.
Wed, May 11, 7:23 AM · Restricted Project, Restricted Project
springerm accepted D125384: [mlir] Add TensorToLinalgPass.
Wed, May 11, 7:13 AM · Restricted Project, Restricted Project
springerm requested review of D125376: [mlir][bufferize] Support alloc hoisting across function boundaries.
Wed, May 11, 4:57 AM · Restricted Project, Restricted Project
springerm requested review of D125375: [mlir][bufferize][NFC] Move helper functions to BufferizationOptions.
Wed, May 11, 4:56 AM · Restricted Project, Restricted Project