Page MenuHomePhabricator
People springerm

springerm (Matthias Springer)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 13 2021, 11:39 PM (114 w, 3 d)

Recent Activity
View All

Yesterday

springerm accepted D120368: [mlir] Add support for "promised" interfaces.

This revision is already quite old now but I rebased the "promised interfaces" part (D146414) and it worked well. Would be great to get this landed. I'm preparing a stack of revisions for a new interface with external model impls (D145681) and it would benefit from this revision.

Sat, Mar 25, 5:16 AM · Restricted Project, Restricted Project, Restricted Project
springerm committed rG7e5d300d0a6d: [mlir][Analysis] Fix assertion in FlatLinearConstraints (authored by springerm).
[mlir][Analysis] Fix assertion in FlatLinearConstraints
Sat, Mar 25, 4:59 AM · Restricted Project, Restricted Project
springerm closed D146869: [mlir][Analysis] Fix assertion in FlatLinearConstraints.
Sat, Mar 25, 4:59 AM · Restricted Project, Restricted Project
springerm requested review of D146871: [mlir][Arith][WIP] ValueBoundsOpInterface: Add support for `arith.select`/`scf.if`.
Sat, Mar 25, 4:36 AM · Restricted Project, Restricted Project
springerm requested review of D146870: [mlir][Interfaces] ValueBoundsOpInterface: Support IntegerTypes.
Sat, Mar 25, 4:35 AM · Restricted Project, Restricted Project
springerm updated the summary of D145681: [mlir][Interfaces] Add ValueBoundsOpInterface and tensor dialect op impl.
Sat, Mar 25, 3:09 AM · Restricted Project, Restricted Project
springerm updated the diff for D145681: [mlir][Interfaces] Add ValueBoundsOpInterface and tensor dialect op impl.

rebase

Sat, Mar 25, 3:08 AM · Restricted Project, Restricted Project
springerm requested review of D146869: [mlir][Analysis] Fix assertion in FlatLinearConstraints.
Sat, Mar 25, 3:05 AM · Restricted Project, Restricted Project
springerm updated the diff for D144193: [mlir][IR] Trigger notifyOperationRemoved callback for nested ops.

rebase and trigger new CI run

Sat, Mar 25, 2:48 AM · Restricted Project, Restricted Project
springerm requested review of D146868: [mlir][bufferize] Fix tracking of erased ops.
Sat, Mar 25, 2:26 AM · Restricted Project, Restricted Project
springerm added a reviewer for D145681: [mlir][Interfaces] Add ValueBoundsOpInterface and tensor dialect op impl: mehdi_amini.
Sat, Mar 25, 1:26 AM · Restricted Project, Restricted Project

Fri, Mar 24

springerm accepted D146755: [mlir][Vector][Transforms] Improve the control over individual vector lowerings and transforms.
Fri, Mar 24, 4:33 AM · Restricted Project, Restricted Project
springerm added inline comments to D146755: [mlir][Vector][Transforms] Improve the control over individual vector lowerings and transforms.
Fri, Mar 24, 2:36 AM · Restricted Project, Restricted Project

Thu, Mar 23

springerm accepted D146624: [mlir][Tensor] Add a FoldTensorSubsetOps pass and patterns.
Thu, Mar 23, 2:37 AM · Restricted Project, Restricted Project
springerm committed rG47bff1cc46b5: [mlir][Analysis][NFC] Make BoundType a top-level enum (authored by springerm).
[mlir][Analysis][NFC] Make BoundType a top-level enum
Thu, Mar 23, 1:47 AM · Restricted Project, Restricted Project
springerm closed D146210: [mlir][Analysis][NFC] Make BoundType a top-level enum.
Thu, Mar 23, 1:47 AM · Restricted Project, Restricted Project
springerm committed rG5b0055a4ae8d: [mlir][Analysis][NFC] Split FlatAffineValueConstraints into multiple classes (authored by springerm).
[mlir][Analysis][NFC] Split FlatAffineValueConstraints into multiple classes
Thu, Mar 23, 1:39 AM · Restricted Project, Restricted Project
springerm closed D146201: [mlir][Analysis][NFC] Split FlatAffineValueConstraints into multiple classes.
Thu, Mar 23, 1:39 AM · Restricted Project, Restricted Project
springerm accepted D146698: [MLIR][Affine] Fix bug and MSAN issue in affine loop utils.
Thu, Mar 23, 1:28 AM · Restricted Project, Restricted Project
springerm added inline comments to D146698: [MLIR][Affine] Fix bug and MSAN issue in affine loop utils.
Thu, Mar 23, 1:24 AM · Restricted Project, Restricted Project

Wed, Mar 22

springerm added inline comments to D144193: [mlir][IR] Trigger notifyOperationRemoved callback for nested ops.
Wed, Mar 22, 2:55 AM · Restricted Project, Restricted Project
springerm updated the diff for D144193: [mlir][IR] Trigger notifyOperationRemoved callback for nested ops.

Perform a custom iteration over regions/blocks/ops. This is much simpler than trying to make ReverseDominanceIterator enumerate dead (unreachable) blocks.

Wed, Mar 22, 2:53 AM · Restricted Project, Restricted Project
springerm committed rG9297b9f8eeec: [mlir][Transforms][NFC] Improve builder/listener API of OperationFolder (authored by springerm).
[mlir][Transforms][NFC] Improve builder/listener API of OperationFolder
Wed, Mar 22, 1:25 AM · Restricted Project, Restricted Project
springerm closed D146134: [mlir][Transforms][NFC] Improve builder/listener API of OperationFolder.
Wed, Mar 22, 1:24 AM · Restricted Project, Restricted Project
springerm updated the summary of D146201: [mlir][Analysis][NFC] Split FlatAffineValueConstraints into multiple classes.
Wed, Mar 22, 1:14 AM · Restricted Project, Restricted Project
springerm committed rG9c16eef1ec46: [mlir][IR] Add ReverseDominanceIterator for IR walkers (authored by springerm).
[mlir][IR] Add ReverseDominanceIterator for IR walkers
Wed, Mar 22, 1:02 AM · Restricted Project, Restricted Project
springerm closed D146125: [mlir][IR] Add ReverseDominanceIterator for IR walkers.
Wed, Mar 22, 1:02 AM · Restricted Project, Restricted Project
springerm added a comment to D143910: [mlir][tensor] Add transform to make tensor.pad/empty loop-independent.
In D143910#4212287, @nicolasvasilache wrote:

Does this update change the way this is supposed to interact with HoistPadding ?
Or in other words, how do you see this interacting with HoistPadding ?

Wed, Mar 22, 12:39 AM · Restricted Project, Restricted Project

Tue, Mar 21

springerm retitled D143910: [mlir][tensor] Add transform to make tensor.pad/empty loop-independent from [mlir][tensor] Add transform to make tensor.pad loop-independent to [mlir][tensor] Add transform to make tensor.pad/empty loop-independent.
Tue, Mar 21, 6:36 AM · Restricted Project, Restricted Project
springerm updated the diff for D143910: [mlir][tensor] Add transform to make tensor.pad/empty loop-independent.

reimplement with ValueBoundsOpInterface

Tue, Mar 21, 6:36 AM · Restricted Project, Restricted Project
springerm requested review of D146524: [mlir][Arith] ValueBoundsOpInterface: Reify with Arith ops.
Tue, Mar 21, 6:34 AM · Restricted Project, Restricted Project
springerm updated the diff for D146356: [mlir][linalg] Remove `linalg::getUpperBoundForIndex` util.

rebase

Tue, Mar 21, 6:34 AM · Restricted Project, Restricted Project
springerm updated the diff for D146306: [mlir][SCF] ValueBoundsOpInterface: Support `scf.for` results and iter_args.

rebase

Tue, Mar 21, 6:34 AM · Restricted Project, Restricted Project
springerm updated the diff for D146296: [mlir][Interfaces] ValueBoundsOpInterface: Compute constant bounds.

rebase

Tue, Mar 21, 6:33 AM · Restricted Project, Restricted Project
springerm updated the diff for D145806: [mlir][linalg] Add ValueBoundsOpInterface impls for Linalg structured ops.

rebase

Tue, Mar 21, 6:33 AM · Restricted Project, Restricted Project
springerm updated the diff for D145804: [mlir][SCF] Add ValueBoundsOpInterface impl for scf.for.

rebase

Tue, Mar 21, 6:32 AM · Restricted Project, Restricted Project
springerm updated the diff for D145787: [mlir][Interfaces] ValueBoundsOpInterface: Support LB and UB bounds.

rebase

Tue, Mar 21, 6:32 AM · Restricted Project, Restricted Project
springerm updated the diff for D145696: [mlir][Arith] Add ValueBoundsOpInterface impls.

rebase

Tue, Mar 21, 6:32 AM · Restricted Project, Restricted Project
springerm updated the diff for D145695: [mlir][MemRef] Add ValueBoundsOpInterface impls.

rebase

Tue, Mar 21, 6:32 AM · Restricted Project, Restricted Project
springerm updated the diff for D145694: [mlir][Affine] Add ValueBoundsOpInterface for affine.apply.

rebase

Tue, Mar 21, 6:31 AM · Restricted Project, Restricted Project
springerm updated the diff for D145681: [mlir][Interfaces] Add ValueBoundsOpInterface and tensor dialect op impl.

rebase

Tue, Mar 21, 6:31 AM · Restricted Project, Restricted Project
springerm updated the diff for D146210: [mlir][Analysis][NFC] Make BoundType a top-level enum.

rebase

Tue, Mar 21, 6:31 AM · Restricted Project, Restricted Project
springerm updated the diff for D146201: [mlir][Analysis][NFC] Split FlatAffineValueConstraints into multiple classes.

rebase

Tue, Mar 21, 6:30 AM · Restricted Project, Restricted Project
springerm accepted D146433: [mlir] Transform dialect: add named sequences.
Tue, Mar 21, 12:58 AM · Restricted Project, Restricted Project

Mon, Mar 20

springerm accepted D146381: [mlir] Support bufferization of arith.constant to memref.global with memory space.
Mon, Mar 20, 7:21 AM · Restricted Project, Restricted Project
springerm accepted D144469: [mlir] Implement pass utils for 1:N type conversions..
Mon, Mar 20, 6:08 AM · Restricted Project, Restricted Project
springerm added inline comments to D145681: [mlir][Interfaces] Add ValueBoundsOpInterface and tensor dialect op impl.
Mon, Mar 20, 4:28 AM · Restricted Project, Restricted Project
springerm added a comment to D146414: [mlir] Add support for "promised" interfaces.

This is a re-upload of River's revision. Trying address a comment mentioned by @mehdi_amini in https://reviews.llvm.org/D145681?id=503721#inline-1408557. So that I can use this revision as a diffbase for my stack.

Mon, Mar 20, 4:21 AM · Restricted Project, Restricted Project
springerm requested review of D146414: [mlir] Add support for "promised" interfaces.
Mon, Mar 20, 4:20 AM · Restricted Project, Restricted Project
springerm updated the summary of D146201: [mlir][Analysis][NFC] Split FlatAffineValueConstraints into multiple classes.
Mon, Mar 20, 2:49 AM · Restricted Project, Restricted Project
springerm updated the diff for D146201: [mlir][Analysis][NFC] Split FlatAffineValueConstraints into multiple classes.

rename: FlatConstraints -> FlatLinearConstraints

Mon, Mar 20, 2:44 AM · Restricted Project, Restricted Project
springerm accepted D146305: [mlir][Linalg][Transform] Avoid FunctionalStyleTransformOpTrait where unnecesseary to improve usability.
Mon, Mar 20, 2:04 AM · Restricted Project, Restricted Project

Sat, Mar 18

springerm requested review of D146356: [mlir][linalg] Remove `linalg::getUpperBoundForIndex` util.
Sat, Mar 18, 1:59 AM · Restricted Project, Restricted Project
springerm accepted D146308: [mlir][nfc] Fix syntax to conform with the C++20 restrictions on error-prone redundancy.
Sat, Mar 18, 1:25 AM · Restricted Project, Restricted Project

Fri, Mar 17

springerm updated the summary of D146306: [mlir][SCF] ValueBoundsOpInterface: Support `scf.for` results and iter_args.
Fri, Mar 17, 9:27 AM · Restricted Project, Restricted Project
springerm requested review of D146306: [mlir][SCF] ValueBoundsOpInterface: Support `scf.for` results and iter_args.
Fri, Mar 17, 9:26 AM · Restricted Project, Restricted Project
springerm updated the diff for D146296: [mlir][Interfaces] ValueBoundsOpInterface: Compute constant bounds.

rebase

Fri, Mar 17, 9:25 AM · Restricted Project, Restricted Project
springerm updated the diff for D145806: [mlir][linalg] Add ValueBoundsOpInterface impls for Linalg structured ops.

rebase

Fri, Mar 17, 9:25 AM · Restricted Project, Restricted Project
springerm updated the diff for D145804: [mlir][SCF] Add ValueBoundsOpInterface impl for scf.for.

rebase

Fri, Mar 17, 9:25 AM · Restricted Project, Restricted Project
springerm updated the diff for D145787: [mlir][Interfaces] ValueBoundsOpInterface: Support LB and UB bounds.

rebase

Fri, Mar 17, 9:24 AM · Restricted Project, Restricted Project
springerm updated the diff for D145681: [mlir][Interfaces] Add ValueBoundsOpInterface and tensor dialect op impl.

Remove loc

Fri, Mar 17, 9:24 AM · Restricted Project, Restricted Project
springerm updated the summary of D145787: [mlir][Interfaces] ValueBoundsOpInterface: Support LB and UB bounds.
Fri, Mar 17, 9:17 AM · Restricted Project, Restricted Project
springerm requested review of D146296: [mlir][Interfaces] ValueBoundsOpInterface: Compute constant bounds.
Fri, Mar 17, 6:38 AM · Restricted Project, Restricted Project
springerm updated the diff for D145806: [mlir][linalg] Add ValueBoundsOpInterface impls for Linalg structured ops.

rebase

Fri, Mar 17, 6:38 AM · Restricted Project, Restricted Project
springerm updated the diff for D145804: [mlir][SCF] Add ValueBoundsOpInterface impl for scf.for.

rebase

Fri, Mar 17, 6:37 AM · Restricted Project, Restricted Project
springerm updated the diff for D145787: [mlir][Interfaces] ValueBoundsOpInterface: Support LB and UB bounds.

rebase

Fri, Mar 17, 6:37 AM · Restricted Project, Restricted Project
springerm updated the diff for D145696: [mlir][Arith] Add ValueBoundsOpInterface impls.

rebase

Fri, Mar 17, 6:37 AM · Restricted Project, Restricted Project
springerm updated the diff for D145695: [mlir][MemRef] Add ValueBoundsOpInterface impls.

rebase

Fri, Mar 17, 6:36 AM · Restricted Project, Restricted Project
springerm updated the diff for D145694: [mlir][Affine] Add ValueBoundsOpInterface for affine.apply.

rebase

Fri, Mar 17, 6:36 AM · Restricted Project, Restricted Project
springerm updated the diff for D145681: [mlir][Interfaces] Add ValueBoundsOpInterface and tensor dialect op impl.

rebase

Fri, Mar 17, 6:35 AM · Restricted Project, Restricted Project
springerm updated the diff for D146210: [mlir][Analysis][NFC] Make BoundType a top-level enum.

rebase

Fri, Mar 17, 6:35 AM · Restricted Project, Restricted Project
springerm updated the diff for D146201: [mlir][Analysis][NFC] Split FlatAffineValueConstraints into multiple classes.

rebase

Fri, Mar 17, 6:34 AM · Restricted Project, Restricted Project
springerm updated the diff for D145681: [mlir][Interfaces] Add ValueBoundsOpInterface and tensor dialect op impl.

update

Fri, Mar 17, 2:53 AM · Restricted Project, Restricted Project

Thu, Mar 16

springerm retitled D145806: [mlir][linalg] Add ValueBoundsOpInterface impls for Linalg structured ops from [mlir][linalg] ValueBoundsOpInterface: Add LinalgOps to [mlir][linalg] Add ValueBoundsOpInterface impls for Linalg structured ops.
Thu, Mar 16, 8:17 AM · Restricted Project, Restricted Project
springerm retitled D145804: [mlir][SCF] Add ValueBoundsOpInterface impl for scf.for from [mlir][SCF] Add ValueBoundsOpInterface impls to [mlir][SCF] Add ValueBoundsOpInterface impl for scf.for.
Thu, Mar 16, 8:16 AM · Restricted Project, Restricted Project
springerm retitled D145804: [mlir][SCF] Add ValueBoundsOpInterface impl for scf.for from [mlir][linalg] ValueBoundsOpInterface: Add scf.for to [mlir][SCF] Add ValueBoundsOpInterface impls.
Thu, Mar 16, 8:16 AM · Restricted Project, Restricted Project
springerm retitled D145787: [mlir][Interfaces] ValueBoundsOpInterface: Support LB and UB bounds from [mlir][linalg] ValueBoundsOpInterface: Support LB and UB bounds to [mlir][Interfaces] ValueBoundsOpInterface: Support LB and UB bounds.
Thu, Mar 16, 8:16 AM · Restricted Project, Restricted Project
springerm retitled D145696: [mlir][Arith] Add ValueBoundsOpInterface impls from [mlir][linalg] ValueBoundsOpInterface: Add a few arith ops to [mlir][Arith] Add ValueBoundsOpInterface impls.
Thu, Mar 16, 8:16 AM · Restricted Project, Restricted Project
springerm retitled D145695: [mlir][MemRef] Add ValueBoundsOpInterface impls from [mlir][linalg] ValueBoundsOpInterface: Add memref ops to [mlir][MemRef] Add ValueBoundsOpInterface impls.
Thu, Mar 16, 8:15 AM · Restricted Project, Restricted Project
springerm retitled D145694: [mlir][Affine] Add ValueBoundsOpInterface for affine.apply from [mlir][linalg] ValueBoundsOpInterface: Add affine.apply op to [mlir][Affine] Add ValueBoundsOpInterface for affine.apply .
Thu, Mar 16, 8:15 AM · Restricted Project, Restricted Project
springerm updated the diff for D145806: [mlir][linalg] Add ValueBoundsOpInterface impls for Linalg structured ops.

rebase

Thu, Mar 16, 8:14 AM · Restricted Project, Restricted Project
springerm updated the diff for D145804: [mlir][SCF] Add ValueBoundsOpInterface impl for scf.for.

rebase

Thu, Mar 16, 8:14 AM · Restricted Project, Restricted Project
springerm updated the diff for D145787: [mlir][Interfaces] ValueBoundsOpInterface: Support LB and UB bounds.

rebase

Thu, Mar 16, 8:14 AM · Restricted Project, Restricted Project
springerm updated the diff for D145696: [mlir][Arith] Add ValueBoundsOpInterface impls.

rebase

Thu, Mar 16, 8:13 AM · Restricted Project, Restricted Project
springerm updated the diff for D145695: [mlir][MemRef] Add ValueBoundsOpInterface impls.

rebase

Thu, Mar 16, 8:12 AM · Restricted Project, Restricted Project
springerm updated the diff for D145694: [mlir][Affine] Add ValueBoundsOpInterface for affine.apply.

rebase

Thu, Mar 16, 8:12 AM · Restricted Project, Restricted Project
springerm updated the summary of D145681: [mlir][Interfaces] Add ValueBoundsOpInterface and tensor dialect op impl.
Thu, Mar 16, 8:04 AM · Restricted Project, Restricted Project
springerm retitled D145681: [mlir][Interfaces] Add ValueBoundsOpInterface and tensor dialect op impl from [mlir][linalg] Add ValueBoundsOpInterface and tensor dialect op impl to [mlir][Interfaces] Add ValueBoundsOpInterface and tensor dialect op impl.
Thu, Mar 16, 8:03 AM · Restricted Project, Restricted Project
springerm updated the diff for D145681: [mlir][Interfaces] Add ValueBoundsOpInterface and tensor dialect op impl.

address some comments and move to mlir/Interfaces

Thu, Mar 16, 8:02 AM · Restricted Project, Restricted Project
springerm added inline comments to D145681: [mlir][Interfaces] Add ValueBoundsOpInterface and tensor dialect op impl.
Thu, Mar 16, 8:02 AM · Restricted Project, Restricted Project
springerm updated the summary of D145681: [mlir][Interfaces] Add ValueBoundsOpInterface and tensor dialect op impl.
Thu, Mar 16, 8:00 AM · Restricted Project, Restricted Project
springerm added a comment to D146052: [mlir][Interfaces] Add ReifyShapeDimTypeInterface.

@mehdi_amini Just took another look at your original comment: Can we replace this with an interface method on ShapedTypeInterface and avoid hard-depending on specific dialect implementations?

Thu, Mar 16, 5:00 AM · Restricted Project, Restricted Project
springerm updated the diff for D146210: [mlir][Analysis][NFC] Make BoundType a top-level enum.

update

Thu, Mar 16, 3:41 AM · Restricted Project, Restricted Project
springerm retitled D146210: [mlir][Analysis][NFC] Make BoundType a top-level enum from [mlir][Affine][Analysis][NFC] Make BoundType a top-level enum to [mlir][Analysis][NFC] Make BoundType a top-level enum.
Thu, Mar 16, 3:25 AM · Restricted Project, Restricted Project
springerm added reviewers for D146210: [mlir][Analysis][NFC] Make BoundType a top-level enum: Groverkss, arjunp.
Thu, Mar 16, 3:25 AM · Restricted Project, Restricted Project
springerm requested review of D146210: [mlir][Analysis][NFC] Make BoundType a top-level enum.
Thu, Mar 16, 3:24 AM · Restricted Project, Restricted Project
springerm abandoned D146029: [mlir][analysis][NFC] Move functions from FlatAffineValueConstraints to IntegerPolyhedron.

Splitting FlatAffineValueConstraints: D146201

Thu, Mar 16, 2:14 AM · Restricted Project, Restricted Project
springerm added reviewers for D146201: [mlir][Analysis][NFC] Split FlatAffineValueConstraints into multiple classes: Groverkss, arjunp.
Thu, Mar 16, 2:13 AM · Restricted Project, Restricted Project
springerm requested review of D146201: [mlir][Analysis][NFC] Split FlatAffineValueConstraints into multiple classes.
Thu, Mar 16, 2:12 AM · Restricted Project, Restricted Project
springerm planned changes to D144193: [mlir][IR] Trigger notifyOperationRemoved callback for nested ops.

This does not work correctly if an op in a dead region has nested ops. I was trying to do without, but we really need a ReverseDominanceIterator that also enumerates dead blocks.

Thu, Mar 16, 12:46 AM · Restricted Project, Restricted Project